warscript 0.0.1-dev.9c98c3a → 0.0.1-dev.9d07b64

package/destroyable.d.ts

@@ -10,6 +10,7 @@ export interface Destroyable {
     destroy(): void;
 }
 export declare abstract class AbstractDestroyable implements Destroyable {
+    get isDestroyed(): boolean;
     /**
      * An overriding function should always call the super one at the end of it,
      * in the following manner: `return super.onDestroy()`.

package/destroyable.lua

@@ -1,6 +1,7 @@
 local ____lualib = require("lualib_bundle")
 local __TS__Class = ____lualib.__TS__Class
 local __TS__New = ____lualib.__TS__New
+local __TS__SetDescriptor = ____lualib.__TS__SetDescriptor
 local ____exports = {}
 local ____exception = require("exception")
 local IllegalStateException = ____exception.IllegalStateException
@@ -28,4 +29,12 @@ function AbstractDestroyable.prototype.destroy(self)
     end
     return true
 end
+__TS__SetDescriptor(
+    AbstractDestroyable.prototype,
+    "isDestroyed",
+    {get = function(self)
+        return stateByDestroyable[self] ~= nil
+    end},
+    true
+)
 return ____exports

package/engine/ability-type-extended-tooltip.d.ts

@@ -0,0 +1,8 @@
+/** @noSelfInFile */
+import { AbilityTypeId } from "./object-data/entry/ability-type";
+/**
+ * The ability type's own extended tooltip for the level, unaffected by local display
+ * overrides (see {@link overrideAbilityTypeExtendedTooltipLocally}). Use it instead of
+ * `BlzGetAbilityExtendedTooltip` wherever the type's tooltip serves as a template.
+ */
+export declare const getAbilityTypeExtendedTooltip: (abilityTypeId: AbilityTypeId, level: number) => string;

package/engine/ability-type-extended-tooltip.lua

@@ -0,0 +1,44 @@
+local ____exports = {}
+local getAbilityExtendedTooltip = BlzGetAbilityExtendedTooltip
+local setAbilityExtendedTooltip = BlzSetAbilityExtendedTooltip
+local originalTooltipByLevelByAbilityTypeId = {}
+local overriddenTooltipByLevelByAbilityTypeId = {}
+--- The ability type's own extended tooltip for the level, unaffected by local display
+-- overrides (see {@link overrideAbilityTypeExtendedTooltipLocally}). Use it instead of
+-- `BlzGetAbilityExtendedTooltip` wherever the type's tooltip serves as a template.
+____exports.getAbilityTypeExtendedTooltip = function(abilityTypeId, level)
+    local ____opt_0 = originalTooltipByLevelByAbilityTypeId[abilityTypeId]
+    return ____opt_0 and ____opt_0[level] or getAbilityExtendedTooltip(abilityTypeId, level)
+end
+--- Replaces the displayed extended tooltip of every ability of the type for the local
+-- player only; `undefined` restores the type's own tooltip. The value is async: never
+-- feed it back into synchronous logic.
+-- 
+-- @internal For use by internal systems only.
+____exports.overrideAbilityTypeExtendedTooltipLocally = function(abilityTypeId, level, tooltip)
+    local overriddenTooltipByLevel = overriddenTooltipByLevelByAbilityTypeId[abilityTypeId]
+    if (overriddenTooltipByLevel and overriddenTooltipByLevel[level]) == tooltip then
+        return
+    end
+    local originalTooltipByLevel = originalTooltipByLevelByAbilityTypeId[abilityTypeId]
+    if originalTooltipByLevel == nil then
+        originalTooltipByLevel = {}
+        originalTooltipByLevelByAbilityTypeId[abilityTypeId] = originalTooltipByLevel
+    end
+    local originalTooltip = originalTooltipByLevel[level]
+    if originalTooltip == nil then
+        originalTooltip = getAbilityExtendedTooltip(abilityTypeId, level)
+        originalTooltipByLevel[level] = originalTooltip
+    end
+    if overriddenTooltipByLevel == nil then
+        overriddenTooltipByLevel = {}
+        overriddenTooltipByLevelByAbilityTypeId[abilityTypeId] = overriddenTooltipByLevel
+    end
+    if tooltip == nil then
+        overriddenTooltipByLevel[level] = nil
+    else
+        overriddenTooltipByLevel[level] = tooltip
+    end
+    setAbilityExtendedTooltip(abilityTypeId, tooltip or originalTooltip, level)
+end
+return ____exports

package/engine/behavior.d.ts

@@ -1,6 +1,11 @@
 /** @noSelfInFile */
 import { AbstractDestroyable, Destructor } from "../destroyable";
 import { Event } from "../event";
+export declare const enum BehaviorPriority {
+    HIGH = 0,
+    MEDIUM = 1,
+    LOW = 2
+}
 export type BehaviorConstructor<T extends Behavior<AnyNotNil>, Parameters extends any[] = any[]> = OmitConstructor<typeof Behavior<any>> & (abstract new (...parameters: Parameters) => T);
 declare const enum BehaviorPropertyKey {
     PREVIOUS_BEHAVIOR = 0,
@@ -9,12 +14,15 @@ declare const enum BehaviorPropertyKey {
 }
 export declare abstract class Behavior<T extends AnyNotNil, PeriodicActionParameters extends any[] = any[]> extends AbstractDestroyable {
     protected readonly object: T;
+    readonly priority: BehaviorPriority;
     private [BehaviorPropertyKey.PREVIOUS_BEHAVIOR]?;
     private [BehaviorPropertyKey.NEXT_BEHAVIOR]?;
     private [BehaviorPropertyKey.TIMER]?;
-    protected constructor(object: T);
+    constructor(object: T, priority?: BehaviorPriority);
     protected onDestroy(): Destructor;
-    protected registerEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, listener: K): void;
+    protected registerGlobalEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, listener: K): void;
+    protected deregisterGlobalEvent(event: Event<any>): boolean;
+    protected registerEvent<K extends string, Args extends any[]>(this: Behavior<any, PeriodicActionParameters> & Record<K, (this: this, ...args: Args) => unknown>, event: Event<[...Args]>, extractObject: (...args: Args) => T | undefined, listener: K): void;
     protected deregisterEvent(event: Event<any>): boolean;
     protected onPeriod(...parameters: PeriodicActionParameters): void;
     protected startPeriodicAction(interval: number, ...parameters: PeriodicActionParameters): void;

package/engine/behavior.lua

@@ -18,56 +18,71 @@ local mutableLuaMap = ____lua_2Dmaps.mutableLuaMap
 local ____lua_2Dsets = require("utility.lua-sets")
 local mutableLuaSet = ____lua_2Dsets.mutableLuaSet
 local safeCall = warpack.safeCall
-local firstBehaviorByObject = {}
-local lastBehaviorByObject = {}
+local firstBehaviorByObjectByPriority = {[0] = {}, [2] = {}, [1] = {}}
+local lastBehaviorByObjectByPriority = {[0] = {}, [2] = {}, [1] = {}}
 local function invokeBehaviorOnPeriod(behavior, ...)
     behavior.onPeriod(behavior, ...)
 end
 local function reduceBehaviors(behaviorConstructor, object, operation, initial, consumerOrKey, ...)
     local accumulator = initial
-    local behavior = firstBehaviorByObject[object]
-    if behavior ~= nil then
-        if type(consumerOrKey) == "function" then
-            repeat
-                do
-                    if __TS__InstanceOf(behavior, behaviorConstructor) then
-                        local isSuccessful, result = safeCall(consumerOrKey, behavior, ...)
-                        if isSuccessful then
-                            accumulator = operation(accumulator, result)
+    for priority = 0, 2 do
+        local behavior = firstBehaviorByObjectByPriority[priority][object]
+        if behavior ~= nil then
+            if type(consumerOrKey) == "function" then
+                repeat
+                    do
+                        if __TS__InstanceOf(behavior, behaviorConstructor) then
+                            local isSuccessful, result = safeCall(consumerOrKey, behavior, ...)
+                            if isSuccessful then
+                                accumulator = operation(accumulator, result)
+                            end
                         end
+                        behavior = behavior[1]
                     end
-                    behavior = behavior[1]
-                end
-            until not (behavior ~= nil)
-        else
-            repeat
-                do
-                    if __TS__InstanceOf(behavior, behaviorConstructor) then
-                        local isSuccessful, result = safeCall(behavior[consumerOrKey], behavior, ...)
-                        if isSuccessful then
-                            accumulator = operation(accumulator, result)
+                until not (behavior ~= nil)
+            else
+                repeat
+                    do
+                        if __TS__InstanceOf(behavior, behaviorConstructor) then
+                            local isSuccessful, result = safeCall(behavior[consumerOrKey], behavior, ...)
+                            if isSuccessful then
+                                accumulator = operation(accumulator, result)
+                            end
                         end
+                        behavior = behavior[1]
                     end
-                    behavior = behavior[1]
-                end
-            until not (behavior ~= nil)
+                until not (behavior ~= nil)
+            end
         end
     end
     return accumulator
 end
+local behaviorsByGlobalEvent = {}
+local listenerByBehaviorByGlobalEvent = {}
+local globalEventsByBehavior = {}
 local behaviorsByEvent = {}
 local listenerByBehaviorByEvent = {}
 local eventsByBehavior = {}
+local function safeCallBehaviorListener(behavior, behaviors, listenerByBehavior, ...)
+    if behaviors[behavior] ~= nil then
+        safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+    end
+end
 ____exports.Behavior = __TS__Class()
 local Behavior = ____exports.Behavior
 Behavior.name = "Behavior"
 __TS__ClassExtends(Behavior, AbstractDestroyable)
-function Behavior.prototype.____constructor(self, object)
+function Behavior.prototype.____constructor(self, object, priority)
+    if priority == nil then
+        priority = 1
+    end
     AbstractDestroyable.prototype.____constructor(self)
     self.object = object
+    self.priority = priority
+    local lastBehaviorByObject = lastBehaviorByObjectByPriority[priority]
     local lastBehavior = lastBehaviorByObject[object]
     if lastBehavior == nil then
-        firstBehaviorByObject[object] = self
+        firstBehaviorByObjectByPriority[priority][object] = self
         lastBehaviorByObject[object] = self
     else
         self[0] = lastBehavior
@@ -80,18 +95,32 @@ function Behavior.prototype.onDestroy(self)
     if ____opt_0 ~= nil then
         ____opt_0:destroy()
     end
-    local events = eventsByBehavior[self]
-    if events ~= nil then
-        for event in pairs(events) do
-            local ____opt_2 = behaviorsByEvent[event]
+    local globalEvents = globalEventsByBehavior[self]
+    if globalEvents ~= nil then
+        for event in pairs(globalEvents) do
+            local ____opt_2 = behaviorsByGlobalEvent[event]
             if ____opt_2 ~= nil then
                 ____opt_2:remove(self)
             end
-            local ____opt_4 = listenerByBehaviorByEvent[event]
+            local ____opt_4 = listenerByBehaviorByGlobalEvent[event]
             if ____opt_4 ~= nil then
                 ____opt_4[self] = nil
             end
         end
+        globalEventsByBehavior[self] = nil
+    end
+    local events = eventsByBehavior[self]
+    if events ~= nil then
+        for event in pairs(events) do
+            local ____opt_6 = behaviorsByEvent[event]
+            if ____opt_6 ~= nil then
+                ____opt_6[self] = nil
+            end
+            local ____opt_8 = listenerByBehaviorByEvent[event]
+            if ____opt_8 ~= nil then
+                ____opt_8[self] = nil
+            end
+        end
         eventsByBehavior[self] = nil
     end
     local previousBehavior = self[0]
@@ -99,16 +128,44 @@ function Behavior.prototype.onDestroy(self)
     if previousBehavior ~= nil then
         previousBehavior[1] = nextBehavior
     else
-        firstBehaviorByObject[self.object] = nextBehavior
+        firstBehaviorByObjectByPriority[self.priority][self.object] = nextBehavior
     end
     if nextBehavior ~= nil then
         nextBehavior[0] = previousBehavior
     else
-        lastBehaviorByObject[self.object] = previousBehavior
+        lastBehaviorByObjectByPriority[self.priority][self.object] = previousBehavior
     end
     return AbstractDestroyable.prototype.onDestroy(self)
 end
-function Behavior.prototype.registerEvent(self, event, listener)
+function Behavior.prototype.registerGlobalEvent(self, event, listener)
+    local listenerByBehavior = getOrPut(listenerByBehaviorByGlobalEvent, event, mutableLuaMap)
+    listenerByBehavior[self] = listener
+    getOrPut(globalEventsByBehavior, self, mutableLuaSet)[event] = true
+    local behaviors = behaviorsByGlobalEvent[event]
+    if behaviors == nil then
+        event:addListener(function(...)
+            local behaviors = behaviorsByGlobalEvent[event]
+            if behaviors ~= nil then
+                for behavior in pairs(behaviors) do
+                    safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+                end
+            end
+        end)
+        behaviors = __TS__New(LinkedSet)
+        behaviorsByGlobalEvent[event] = behaviors
+    end
+    behaviors:add(self)
+end
+function Behavior.prototype.deregisterGlobalEvent(self, event)
+    local behaviors = behaviorsByGlobalEvent[event]
+    if behaviors ~= nil and behaviors:remove(self) then
+        globalEventsByBehavior[self][event] = nil
+        listenerByBehaviorByGlobalEvent[event][self] = nil
+        return true
+    end
+    return false
+end
+function Behavior.prototype.registerEvent(self, event, extractObject, listener)
     local listenerByBehavior = getOrPut(listenerByBehaviorByEvent, event, mutableLuaMap)
     listenerByBehavior[self] = listener
     getOrPut(eventsByBehavior, self, mutableLuaSet)[event] = true
@@ -117,19 +174,27 @@ function Behavior.prototype.registerEvent(self, event, listener)
         event:addListener(function(...)
             local behaviors = behaviorsByEvent[event]
             if behaviors ~= nil then
-                for behavior in pairs(behaviors) do
-                    safeCall(behavior[listenerByBehavior[behavior]], behavior, ...)
+                local object = extractObject(...)
+                if object ~= nil then
+                    ____exports.Behavior:forAll(
+                        object,
+                        safeCallBehaviorListener,
+                        behaviors,
+                        listenerByBehavior,
+                        ...
+                    )
                 end
             end
         end)
-        behaviors = __TS__New(LinkedSet)
+        behaviors = {}
         behaviorsByEvent[event] = behaviors
     end
-    behaviors:add(self)
+    behaviors[self] = true
 end
 function Behavior.prototype.deregisterEvent(self, event)
     local behaviors = behaviorsByEvent[event]
-    if behaviors ~= nil and behaviors:remove(self) then
+    if behaviors ~= nil and behaviors[self] ~= nil then
+        behaviors[self] = nil
         eventsByBehavior[self][event] = nil
         listenerByBehaviorByEvent[event][self] = nil
         return true
@@ -161,78 +226,94 @@ function Behavior.prototype.stopPeriodicAction(self)
 end
 function Behavior.count(self, object, limit)
     local behaviorsCount = 0
-    local behavior = firstBehaviorByObject[object]
-    while behavior ~= nil and (limit == nil or behaviorsCount < limit) do
-        if __TS__InstanceOf(behavior, self) then
-            behaviorsCount = behaviorsCount + 1
+    for priority = 0, 2 do
+        local behavior = firstBehaviorByObjectByPriority[priority][object]
+        while behavior ~= nil and (limit == nil or behaviorsCount < limit) do
+            if __TS__InstanceOf(behavior, self) then
+                behaviorsCount = behaviorsCount + 1
+            end
+            behavior = behavior[1]
         end
-        behavior = behavior[1]
     end
     return behaviorsCount
 end
 function Behavior.getFirst(self, object, countOrPredicate, ...)
-    local behavior = firstBehaviorByObject[object]
     if type(countOrPredicate) ~= "number" then
-        while behavior ~= nil do
-            if __TS__InstanceOf(behavior, self) and (countOrPredicate == nil or countOrPredicate(behavior, ...)) then
-                return behavior
+        for priority = 0, 2 do
+            local behavior = firstBehaviorByObjectByPriority[priority][object]
+            while behavior ~= nil do
+                if __TS__InstanceOf(behavior, self) and (countOrPredicate == nil or countOrPredicate(behavior, ...)) then
+                    return behavior
+                end
+                behavior = behavior[1]
             end
-            behavior = behavior[1]
         end
         return nil
     end
     local behaviors = {}
     local behaviorsCount = 0
-    while behavior ~= nil and behaviorsCount < countOrPredicate do
-        if __TS__InstanceOf(behavior, self) then
-            behaviorsCount = behaviorsCount + 1
-            behaviors[behaviorsCount] = behavior
+    for priority = 0, 2 do
+        local behavior = firstBehaviorByObjectByPriority[priority][object]
+        while behavior ~= nil and behaviorsCount < countOrPredicate do
+            if __TS__InstanceOf(behavior, self) then
+                behaviorsCount = behaviorsCount + 1
+                behaviors[behaviorsCount] = behavior
+            end
+            behavior = behavior[1]
         end
-        behavior = behavior[1]
     end
     return behaviors
 end
 function Behavior.getLast(self, object)
-    local behavior = lastBehaviorByObject[object]
-    while behavior ~= nil do
-        if __TS__InstanceOf(behavior, self) then
-            return behavior
+    for priority = 2, 0, -1 do
+        local behavior = lastBehaviorByObjectByPriority[priority][object]
+        while behavior ~= nil do
+            if __TS__InstanceOf(behavior, self) then
+                return behavior
+            end
+            behavior = behavior[0]
         end
-        behavior = behavior[0]
     end
     return nil
 end
 function Behavior.getAll(self, object, predicate, ...)
     local behaviors = {}
     local behaviorsCount = 0
-    local behavior = firstBehaviorByObject[object]
-    while behavior ~= nil do
-        if __TS__InstanceOf(behavior, self) and (predicate == nil or predicate(behavior, ...)) then
-            behaviorsCount = behaviorsCount + 1
-            behaviors[behaviorsCount] = behavior
+    for priority = 0, 2 do
+        local behavior = firstBehaviorByObjectByPriority[priority][object]
+        while behavior ~= nil do
+            if __TS__InstanceOf(behavior, self) and (predicate == nil or predicate(behavior, ...)) then
+                behaviorsCount = behaviorsCount + 1
+                behaviors[behaviorsCount] = behavior
+            end
+            behavior = behavior[1]
         end
-        behavior = behavior[1]
     end
     return behaviors
 end
 function Behavior.forFirst(self, object, count, consumerOrKey, ...)
     local behaviorsCount = 0
-    local behavior = firstBehaviorByObject[object]
     if type(consumerOrKey) == "function" then
-        while behavior ~= nil and behaviorsCount < count do
-            if __TS__InstanceOf(behavior, self) then
-                safeCall(consumerOrKey, behavior, ...)
-                behaviorsCount = behaviorsCount + 1
+        for priority = 0, 2 do
+            local behavior = firstBehaviorByObjectByPriority[priority][object]
+            while behavior ~= nil and behaviorsCount < count do
+                if __TS__InstanceOf(behavior, self) then
+                    safeCall(consumerOrKey, behavior, ...)
+                    behaviorsCount = behaviorsCount + 1
+                end
+                behavior = behavior[1]
             end
-            behavior = behavior[1]
         end
     else
-        while behavior ~= nil and behaviorsCount < count do
-            if __TS__InstanceOf(behavior, self) then
-                safeCall(behavior[consumerOrKey], behavior, ...)
-                behaviorsCount = behaviorsCount + 1
+        for priority = 0, 2 do
+            local behavior = firstBehaviorByObjectByPriority[priority][object]
+            while behavior ~= nil and behaviorsCount < count do
+                if __TS__InstanceOf(behavior, self) then
+                    safeCall(behavior[consumerOrKey], behavior, ...)
+                    behaviorsCount = behaviorsCount + 1
+                end
+                behavior = behavior[1]
             end
-            behavior = behavior[1]
         end
     end
     return behaviorsCount

package/engine/behaviour/ability/apply-buff.lua

@@ -27,7 +27,7 @@ function ApplyBuffAbilityBehavior.prototype.____constructor(self, ability, const
                 constructorOrTypeIdOrTypeIds,
                 typeIdOrTypeIdsOrPolarityOrTypeIdSelectionPolicy,
                 polarityOrTypeIdSelectionPolicyOrResistanceType,
-                ability,
+                self,
                 resistanceTypeOrPolarityOrParameters
             )
         end
@@ -39,7 +39,7 @@ function ApplyBuffAbilityBehavior.prototype.____constructor(self, ability, const
                 typeIdOrTypeIdsOrPolarityOrTypeIdSelectionPolicy,
                 polarityOrTypeIdSelectionPolicyOrResistanceType,
                 resistanceTypeOrPolarityOrParameters,
-                ability,
+                self,
                 parametersOrResistanceType
             )
         end
@@ -50,7 +50,7 @@ function ApplyBuffAbilityBehavior.prototype.____constructor(self, ability, const
                 typeIdOrTypeIdsOrPolarityOrTypeIdSelectionPolicy,
                 polarityOrTypeIdSelectionPolicyOrResistanceType,
                 resistanceTypeOrPolarityOrParameters,
-                ability,
+                self,
                 parametersOrResistanceType
             )
         end
@@ -62,7 +62,7 @@ function ApplyBuffAbilityBehavior.prototype.____constructor(self, ability, const
                 polarityOrTypeIdSelectionPolicyOrResistanceType,
                 resistanceTypeOrPolarityOrParameters,
                 parametersOrResistanceType,
-                ability,
+                self,
                 parameters
             )
         end

package/engine/behaviour/ability/apply-unit-behavior.lua

@@ -7,6 +7,8 @@ local __TS__New = ____lualib.__TS__New
 local ____exports = {}
 local ____ability = require("engine.behaviour.ability")
 local AbilityBehavior = ____ability.AbilityBehavior
+local ____unit = require("engine.internal.unit")
+local Unit = ____unit.Unit
 local ____ability = require("engine.object-field.ability")
 local AbilityField = ____ability.AbilityField
 local AbilityLevelField = ____ability.AbilityLevelField
@@ -56,4 +58,7 @@ end)
 AbilityLevelField.valueChangeEvent:addListener(function(ability)
     ____exports.ApplyUnitBehaviorAbilityBehavior:forAll(ability, "update")
 end)
+Unit.abilityLevelChangedEvent:addListener(function(_, ability)
+    ____exports.ApplyUnitBehaviorAbilityBehavior:forAll(ability, "update")
+end)
 return ____exports

package/engine/behaviour/ability/damage.d.ts

@@ -5,6 +5,7 @@ import { Unit } from "../../internal/unit";
 import { AbilityDependentValue } from "../../object-field/ability";
 import { Widget } from "../../../core/types/widget";
 import { DamageType, WeaponType } from "../../internal/unit+damage";
+import "../../internal/unit+damage";
 import { CombatClassifications } from "../../object-data/auxiliary/combat-classification";
 import { AttackType } from "../../object-data/auxiliary/attack-type";
 export type DamageAbilityBehaviorParameters = {
@@ -25,8 +26,11 @@ export declare abstract class DamageAbilityBehavior<T extends DamageAbilityBehav
     protected readonly damage: AbilityDependentValue<number>;
     protected readonly parameters?: T | undefined;
     protected constructor(ability: Ability, damage: AbilityDependentValue<number>, parameters?: T | undefined);
+    protected precalculatedDamage?: number;
     protected calculateDamage(caster: Unit): number;
     protected damageTarget(caster: Unit, target: Widget, damage?: number): void;
+    onChannelingStart(caster: Unit): void;
+    onStop(): void;
 }
 export declare class DamageSelfAbilityBehavior extends DamageAbilityBehavior {
     constructor(ability: Ability, damage: AbilityDependentValue<number>, parameters?: DamageAbilityBehaviorParameters);

package/engine/behaviour/ability/damage.lua

@@ -4,11 +4,10 @@ local __TS__ClassExtends = ____lualib.__TS__ClassExtends
 local ____exports = {}
 local ____ability = require("engine.behaviour.ability")
 local AbilityBehavior = ____ability.AbilityBehavior
-local ____unit = require("engine.internal.unit")
-local Unit = ____unit.Unit
 local ____ability = require("engine.standard.fields.ability")
 local ALLOWED_TARGETS_ABILITY_COMBAT_CLASSIFICATIONS_LEVEL_FIELD = ____ability.ALLOWED_TARGETS_ABILITY_COMBAT_CLASSIFICATIONS_LEVEL_FIELD
 local AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD = ____ability.AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD
+require("engine.internal.unit+damage")
 ____exports.DamageAbilityBehavior = __TS__Class()
 local DamageAbilityBehavior = ____exports.DamageAbilityBehavior
 DamageAbilityBehavior.name = "DamageAbilityBehavior"
@@ -39,7 +38,7 @@ function DamageAbilityBehavior.prototype.damageTarget(self, caster, target, dama
     local parameters = self.parameters
     caster:damageTarget(
         target,
-        damage or self:calculateDamage(caster),
+        damage or self.precalculatedDamage or self:calculateDamage(caster),
         nil,
         nil,
         self:resolveCurrentAbilityDependentValue(parameters and parameters.attackType),
@@ -48,6 +47,12 @@ function DamageAbilityBehavior.prototype.damageTarget(self, caster, target, dama
         self:resolveCurrentAbilityDependentValue(parameters and parameters.metadata)
     )
 end
+function DamageAbilityBehavior.prototype.onChannelingStart(self, caster)
+    self.precalculatedDamage = self:calculateDamage(caster)
+end
+function DamageAbilityBehavior.prototype.onStop(self)
+    self.precalculatedDamage = nil
+end
 ____exports.DamageSelfAbilityBehavior = __TS__Class()
 local DamageSelfAbilityBehavior = ____exports.DamageSelfAbilityBehavior
 DamageSelfAbilityBehavior.name = "DamageSelfAbilityBehavior"
@@ -76,21 +81,20 @@ function DamageAreaAbilityBehavior.prototype.____constructor(self, ability, dama
 end
 function DamageAreaAbilityBehavior.prototype.damageArea(self, caster, x, y)
     local parameters = self.parameters
-    local targets = Unit.getAllowedTargetsInCollisionRange(
-        caster,
-        self:resolveCurrentAbilityDependentValue(parameters and parameters.allowedTargetCombatClassifications or ALLOWED_TARGETS_ABILITY_COMBAT_CLASSIFICATIONS_LEVEL_FIELD),
+    caster:damageArea(
         x,
         y,
-        self:resolveCurrentAbilityDependentValue(parameters and parameters.areaOfEffect or AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD)
+        self:resolveCurrentAbilityDependentValue(parameters and parameters.areaOfEffect or AREA_OF_EFFECT_ABILITY_FLOAT_LEVEL_FIELD),
+        self:resolveCurrentAbilityDependentValue(parameters and parameters.allowedTargetCombatClassifications or ALLOWED_TARGETS_ABILITY_COMBAT_CLASSIFICATIONS_LEVEL_FIELD),
+        self.precalculatedDamage or self:calculateDamage(caster),
+        self:resolveCurrentAbilityDependentValue(parameters and parameters.maximumDamage or 0),
+        nil,
+        nil,
+        self:resolveCurrentAbilityDependentValue(parameters and parameters.attackType),
+        parameters and parameters.damageType,
+        parameters and parameters.weaponType,
+        self:resolveCurrentAbilityDependentValue(parameters and parameters.metadata)
     )
-    local damage = self:calculateDamage(caster)
-    local maximumDamage = self:resolveCurrentAbilityDependentValue(parameters and parameters.maximumDamage or 0)
-    if maximumDamage ~= 0 and damage > maximumDamage then
-        damage = maximumDamage / #targets
-    end
-    for ____, target in ipairs(targets) do
-        self:damageTarget(caster, target, damage)
-    end
 end
 ____exports.DamageSelfAreaAbilityBehavior = __TS__Class()
 local DamageSelfAreaAbilityBehavior = ____exports.DamageSelfAreaAbilityBehavior

package/engine/behaviour/ability/emulate-impact.lua

@@ -10,9 +10,6 @@ local Unit = ____unit.Unit
 local ____ability = require("engine.standard.fields.ability")
 local COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD = ____ability.COOLDOWN_ABILITY_FLOAT_LEVEL_FIELD
 local MANA_COST_ABILITY_INTEGER_LEVEL_FIELD = ____ability.MANA_COST_ABILITY_INTEGER_LEVEL_FIELD
-local ____math = require("math")
-local max = ____math.max
-local MINIMUM_POSITIVE_NORMALIZED_FLOAT = ____math.MINIMUM_POSITIVE_NORMALIZED_FLOAT
 local ____sound = require("core.types.sound")
 local Sound3D = ____sound.Sound3D
 local SoundSettings = ____sound.SoundSettings
@@ -31,7 +28,11 @@ function EmulateImpactAbilityBehavior.prototype.emulateImpact(self, caster)
         return false
     end
     caster.mana = caster.mana - manaCost
-    self.ability.cooldownRemaining = max(cooldown, MINIMUM_POSITIVE_NORMALIZED_FLOAT)
+    if cooldown == 0 then
+        self.ability:interruptCast()
+    else
+        self.ability:startCooldown(cooldown)
+    end
     self:flashCasterEffect(caster)
     local soundPresetId = self.ability:getField(ABILITY_SF_EFFECT_SOUND)
     if soundPresetId ~= "" then

package/engine/behaviour/ability/on-command-impact.d.ts

@@ -1,5 +1,6 @@
 /** @noSelfInFile */
 import { Unit } from "../../internal/unit";
+import "../../internal/unit/item-order-events";
 import { EmulateImpactAbilityBehavior } from "./emulate-impact";
 import { Ability } from "../../internal/ability";
 export declare class OnCommandImpactAbilityBehavior extends EmulateImpactAbilityBehavior {

package/engine/behaviour/ability/on-command-impact.lua

@@ -4,6 +4,7 @@ local __TS__ClassExtends = ____lualib.__TS__ClassExtends
 local ____exports = {}
 local ____unit = require("engine.internal.unit")
 local Unit = ____unit.Unit
+require("engine.internal.unit.item-order-events")
 local ____emulate_2Dimpact = require("engine.behaviour.ability.emulate-impact")
 local EmulateImpactAbilityBehavior = ____emulate_2Dimpact.EmulateImpactAbilityBehavior
 ____exports.OnCommandImpactAbilityBehavior = __TS__Class()