tiddlywiki 5.3.6 → 5.3.8

package/editions/markdowndemo/tiddlers/HelloThere.tid

@@ -6,4 +6,10 @@ This is a demo of TiddlyWiki5 incorporating a plugin for parsing tiddlers writte
 
 To add the plugin to your own TiddlyWiki5, just drag this link to the browser window:
 
-[[$:/plugins/tiddlywiki/markdown]]
+[[$:/plugins/tiddlywiki/markdown]]
+
+! Overridden Defaults
+
+This demo overrides the default value for tiddlers created from missing tiddler
+links so that Markdown is the default rather than WikiText. See
+the [[$:/config/DefaultMissingType]] tiddler for the modification.

package/editions/markdowndemo/tiddlywiki.info

@@ -13,6 +13,9 @@
 	],
 	"build": {
 		"index": [
-			"--rendertiddler","$:/core/save/all","markdowndemo.html","text/plain"]
+			"--rendertiddler","$:/core/save/all","markdowndemo.html","text/plain"],
+		"external": [
+			"--render","$:/core/save/all-external-js","markdowndemo.html","text/plain"
+		]
 	}
 }

package/editions/prerelease/tiddlers/system/PrereleaseLocalPluginLibrary.tid

@@ -1,6 +1,6 @@
 title: $:/config/LocalPluginLibrary
 tags: $:/tags/PluginLibrary
-url: http://127.0.0.1:8080/prerelease/library/v5.3.6/index.html
+url: http://127.0.0.1:8080/prerelease/library/v5.3.7/index.html
 caption: {{$:/language/OfficialPluginLibrary}} (Prerelease Local)
 
 A locally installed version of the official ~TiddlyWiki plugin library at tiddlywiki.com for testing and debugging. //Requires a local web server to share the library//

package/editions/prerelease/tiddlers/system/PrereleaseOfficialPluginLibrary.tid

@@ -1,6 +1,6 @@
 title: $:/config/OfficialPluginLibrary
 tags: $:/tags/PluginLibrary
-url: https://tiddlywiki.com/prerelease/library/v5.3.6/index.html
+url: https://tiddlywiki.com/prerelease/library/v5.3.8/index.html
 caption: {{$:/language/OfficialPluginLibrary}} (Prerelease)
 
 The prerelease version of the official ~TiddlyWiki plugin library at tiddlywiki.com. Plugins, themes and language packs are maintained by the core team.

package/editions/prerelease/tiddlywiki.info

@@ -3,20 +3,16 @@
 	"plugins": [
 		"tiddlywiki/browser-sniff",
 		"tiddlywiki/help",
-		"tiddlywiki/stacked-view",
 		"tiddlywiki/powered-by-tiddlywiki",
 		"tiddlywiki/internals",
 		"tiddlywiki/highlight",
 		"tiddlywiki/bibtex",
-		"tiddlywiki/savetrail",
-		"tiddlywiki/external-attachments",
 		"tiddlywiki/dynaview",
 		"tiddlywiki/dynannotate",
 		"tiddlywiki/codemirror",
 		"tiddlywiki/menubar",
 		"tiddlywiki/jszip",
 		"tiddlywiki/confetti",
-		"tiddlywiki/dynannotate",
 		"tiddlywiki/tour"
 	],
 	"themes": [

package/editions/test/tiddlers/tests/data/data-widget/ImportCompound.tid

@@ -24,4 +24,4 @@ This is a payload tiddler from a compound tiddler
 +
 title: ExpectedResult
 
-<p><div><div>[{"title":"Payload Tiddler","tags":"Alpha Beta Gamma","text":"This is a payload tiddler from a compound tiddler","custom":"Alpha"}]</div></div></p>
+<p><div class="tc-test-case "><div>[{"title":"Payload Tiddler","tags":"Alpha Beta Gamma","text":"This is a payload tiddler from a compound tiddler","custom":"Alpha"}]</div></div></p>

package/editions/test/tiddlers/tests/data/data-widget/ImportCustomTitle.tid

@@ -20,4 +20,4 @@ This is the tiddler HelloThere
 +
 title: ExpectedResult
 
-<p><div><div>[{"title":"RealTitle","tags":"Definitions","text":"This is the tiddler HelloThere"}]</div></div></p>
+<p><div class="tc-test-case "><div>[{"title":"RealTitle","tags":"Definitions","text":"This is the tiddler HelloThere"}]</div></div></p>

package/editions/test/tiddlers/tests/data/data-widget/ImportFilter.tid

@@ -25,4 +25,4 @@ This is the tiddler AnotherDefinition
 +
 title: ExpectedResult
 
-<p><div><div>[{"title":"AnotherDefinition","tags":"Definitions","text":"This is the tiddler AnotherDefinition","custom":"Alpha"},{"title":"HelloThere","tags":"Definitions","text":"This is the tiddler HelloThere","custom":"Alpha"}]</div></div></p>
+<p><div class="tc-test-case "><div>[{"title":"AnotherDefinition","tags":"Definitions","text":"This is the tiddler AnotherDefinition","custom":"Alpha"},{"title":"HelloThere","tags":"Definitions","text":"This is the tiddler HelloThere","custom":"Alpha"}]</div></div></p>

package/editions/test/tiddlers/tests/data/data-widget/ImportTiddler.tid

@@ -20,4 +20,4 @@ This is the tiddler HelloThere
 +
 title: ExpectedResult
 
-<p><div><div>[{"title":"HelloThere","tags":"Definitions","text":"This is the tiddler HelloThere","custom":"Alpha"}]</div></div></p>
+<p><div class="tc-test-case "><div>[{"title":"HelloThere","tags":"Definitions","text":"This is the tiddler HelloThere","custom":"Alpha"}]</div></div></p>

package/editions/test/tiddlers/tests/data/data-widget/Simple.tid

@@ -9,10 +9,10 @@ text: Standalone data widget to create individual tiddlers
 title: Output
 
 \whitespace trim
-<$testcase template="$:/core/ui/testcases/RawJSONTemplate">
+<$testcase template="$:/core/ui/testcases/RawJSONTemplate" class="my-class an-other-class">
 <$data title="Epsilon" text="Theta"/>
 </$testcase>
 +
 title: ExpectedResult
 
-<p><div><div>[{"title":"Epsilon","text":"Theta"}]</div></div></p>
+<p><div class="tc-test-case my-class an-other-class"><div>[{"title":"Epsilon","text":"Theta"}]</div></div></p>

package/editions/test/tiddlers/tests/data/transclude/CustomWidget-RawAndSlotted.tid

@@ -0,0 +1,34 @@
+title: Transclude/CustomWidget/RawAndSlotted
+description: Custom widget can mix ts-raw and custom slots
+type: text/vnd.tiddlywiki-multiple
+tags: [[$:/tags/wiki-test-spec]]
+
+title: Output
+
+\whitespace trim
+\widget $my.widget()
+\whitespace trim
+<$slot $name="ts-header">
+	Default Header
+</$slot>
+-
+<$slot $name="ts-raw"/>
+\end
+<$my.widget>
+	First Body
+</$my.widget>
+
+
+<$my.widget>
+	<$fill $name="ts-header">
+		Custom Header
+	</$fill>
+	<$fill $name="ts-never">
+		<$log RawAndSlotted="Transclude/CustomWidget/RawAndSlotted is actually failing. $fill slots are executing silently when they weren't invoked." />
+	</$fill>
+	Second Body
+</$my.widget>
++
+title: ExpectedResult
+
+<p>Default Header-First Body</p><p>Custom Header-Second Body</p>

package/editions/test/tiddlers/tests/data/widgets/SubstitutedAttributes.tid

@@ -7,9 +7,9 @@ title: Output
 
 \whitespace trim
 <$set name="var with spaces" value="spaces">
-<$let project="TiddlyWiki" disabled="true" var-with-dashes="dashes">
+<$let project="TiddlyWiki" disabled="true" $tiddler="Getting Started" var-with-dashes="dashes">
 <div class=`$(project)$ 
-${ [[Hello]addsuffix[There]] }$` attrib=`myvalue` otherattrib=`$(1)$` blankattrib=`` quoted="here" disabled=```$(disabled)$``` dashes=`$(var-with-dashes)$` spaces=`$(var with spaces)$`>
+${ [[Hello]addsuffix[There]] }$` attrib=`myvalue` otherattrib=`$(1)$` blankattrib=`` quoted="here" disabled=```$(disabled)$``` dollar=`p-$($tiddler)$-s` dashes=`$(var-with-dashes)$` spaces=`$(var with spaces)$`>
 </div>
 </$let>
 </$set>
@@ -18,4 +18,4 @@ ${ [[Hello]addsuffix[There]] }$` attrib=`myvalue` otherattrib=`$(1)$` blankattri
 title: ExpectedResult
 
 <p><div attrib="myvalue" blankattrib="" class="TiddlyWiki 
-HelloThere" dashes="dashes" disabled="true" otherattrib="" quoted="here" spaces="spaces"></div></p>
+HelloThere" dashes="dashes" disabled="true" dollar="p-Getting Started-s" otherattrib="" quoted="here" spaces="spaces"></div></p>

package/editions/test/tiddlers/tests/modules/utils/test-csv.js

@@ -6,9 +6,6 @@ tags: [[$:/tags/test-spec]]
 Tests the backlinks mechanism.
 
 \*/
-(function(){
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe('CSV Parsing', function() {
@@ -29,5 +26,3 @@ describe('CSV Parsing', function() {
 	})
 	
 });
-
-})();

package/editions/test/tiddlers/tests/test-action-deletefield.js

@@ -6,12 +6,6 @@ tags: [[$:/tags/test-spec]]
 Tests <$action-deletefield />.
 
 \*/
-(function(){
-
-/* jslint node: true, browser: true */
-/* eslint-env node, browser, jasmine */
-/* eslint no-mixed-spaces-and-tabs: ["error", "smart-tabs"]*/
-/* global $tw, require */
 "use strict";
 
 describe("<$action-deletefield /> tests", function() {
@@ -172,5 +166,3 @@ it("should correctly delete fields", function() {
 });
 
 });
-
-})();

package/editions/test/tiddlers/tests/test-action-widgets.js

@@ -6,7 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests the action widgets.
 
 \*/
-(function(){
+
 
 /* jslint node: true, browser: true */
 /* eslint-env node, browser, jasmine */
@@ -94,5 +94,3 @@ it("should handle the action-listops widget", function() {
 
 });
 
-})();
-	

package/editions/test/tiddlers/tests/test-backlinks.js

@@ -6,9 +6,6 @@ tags: [[$:/tags/test-spec]]
 Tests the backlinks mechanism.
 
 \*/
-(function(){
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe('Backlinks tests', function() {
@@ -141,5 +138,3 @@ describe('Backlinks tests', function() {
 		});
 	});
 });
-
-})();

package/editions/test/tiddlers/tests/test-backtranscludes.js

@@ -6,9 +6,6 @@ tags: $:/tags/test-spec
 Tests the backtranscludes mechanism.
 
 \*/
-(function(){
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe('Backtranscludes and transclude filter tests', function() {
@@ -253,5 +250,3 @@ describe('Backtranscludes and transclude filter tests', function() {
 		});
 	});
 });
-
-})();

package/editions/test/tiddlers/tests/test-checkbox-widget.js

@@ -6,7 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests the checkbox widget thoroughly.
 
 \*/
-(function(){
+
 
     /*jslint node: true, browser: true */
     /*global $tw: false */
@@ -78,6 +78,13 @@ Tests the checkbox widget thoroughly.
                 startsOutChecked: false,
                 expectedChange: { "TiddlerOne": { expand: "yes" } }
             },
+            {
+                testName: "field mode default when missing -> true",
+                tiddlers: [],
+                widgetText: "<$checkbox tiddler='TiddlerOne' field='expand' default='yes' checked='yes' unchecked='no' />",
+                startsOutChecked: true,
+                expectedChange: { "TiddlerOne": { expand: "no" } }
+            },
             {
                 testName: "field mode indeterminate -> true",
                 tiddlers: [{title: "TiddlerOne", text: "Jolly Old World", expand: "some other value"}],
@@ -98,19 +105,28 @@ Tests the checkbox widget thoroughly.
         var indexModeTests = fieldModeTests.map(data => {
             var newData = {...data};
             var newName = data.testName.replace('field mode', 'index mode');
+            var tiddlerOneAlreadyExists = false;
             var newTiddlers = data.tiddlers.map(tiddler => {
+                if(tiddler.title === "TiddlerOne") {
+                    tiddlerOneAlreadyExists = true;
+                }
                 return {title: tiddler.title, type: "application/x-tiddler-dictionary", text: `one: a\nexpand: ${tiddler.expand}\ntwo: b`}
             });
             var newWidgetText = data.widgetText.replace("field='expand'", "index='expand'");
             var newChange = {};
             for (var key of Object.keys(data.expectedChange)) {
                 var oldChange = data.expectedChange[key];
-                if (oldChange.expand) {
-                    newChange[key] = { text: `one: a\nexpand: ${oldChange.expand}\ntwo: b` }
+                var text;
+                if (!tiddlerOneAlreadyExists) {
+                    // If it wasn't there, the created one will be JSON
+                    text = `{\n    "expand": "${oldChange.expand}"\n}`;
+                } else if (oldChange.expand) {
+                    text = `one: a\nexpand: ${oldChange.expand}\ntwo: b`;
                 } else {
                     // In index tiddlers, the "expand" field gets completely removed, not turned into "expand: (undefined)"
-                    newChange[key] = { text: `one: a\ntwo: b` }
+                    text = `one: a\ntwo: b`;
                 }
+                newChange[key] = { text: text };
             }
             newData.testName = newName;
             newData.tiddlers = newTiddlers;
@@ -514,7 +530,9 @@ Tests the checkbox widget thoroughly.
         /*
          * Checkbox widget tests using the test data above
          */
-        for (var data of checkboxTestData) {
+        // MAKE SURE TO USE $tw.utils.each HERE!!!
+        // If you use a forloop, the closure of the tests will all use the last value "data" was assigned to, and thus all run the same test.
+        $tw.utils.each(checkboxTestData, function(data) {
             it('checkbox widget test: ' + data.testName, function() {
                 // Setup
     
@@ -553,9 +571,8 @@ Tests the checkbox widget thoroughly.
                     }
                 }
             })
-        }
+        });
     
     });
     
-})();
     

package/editions/test/tiddlers/tests/test-compare-filter.js

@@ -6,7 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests the compare filter.
 
 \*/
-(function(){
+
 
 /* jslint node: true, browser: true */
 /* eslint-env node, browser, jasmine */
@@ -81,4 +81,3 @@ describe("'compare' filter tests", function() {
 
 });
 
-})();

package/editions/test/tiddlers/tests/test-deserialize-operator.js

@@ -6,7 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests deserialize[] filter operator with various core deserializers
 
 \*/
-(function(){
+
 
 	/* jslint node: true, browser: true */
 	/* eslint-env node, browser, jasmine */
@@ -37,8 +37,4 @@ Tests deserialize[] filter operator with various core deserializers
 		});
 	});
 	
-})();
-
-
 
- 

package/editions/test/tiddlers/tests/test-deserializers.js

@@ -6,7 +6,6 @@ tags: [[$:/tags/test-spec]]
 Tests various core deserializers
 
 \*/
-(function(){
 
 	/* jslint node: true, browser: true */
 	/* eslint-env node, browser, jasmine */
@@ -34,6 +33,3 @@ Tests various core deserializers
 		executeTestCase("dezerializer test data case 5",[ { title: 'Hello "There"', text: 'Abacus', type: 'text/vnd.tiddlywiki' }, { title: 'Hello "There"', text: 'Calculator'} , { title: 'Hello "There"', text: 'Protractor'}  ]);
 		
 	});
-	
-	})();
-	

package/editions/test/tiddlers/tests/test-fakedom.js

@@ -6,10 +6,6 @@ tags: [[$:/tags/test-spec]]
 Tests the fakedom that Tiddlywiki occasionally uses.
 
 \*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe("fakedom tests", function() {
@@ -23,5 +19,3 @@ describe("fakedom tests", function() {
 		expect($tw.fakeDocument.createTextNode("text").TEXT_NODE).toBe(3);
 	});
 });
-
-})();

package/editions/test/tiddlers/tests/test-filters.js

@@ -6,12 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests the filtering mechanism.
 
 \*/
-(function(){
 
-	/* jslint node: true, browser: true */
-	/* eslint-env node, browser, jasmine */
-	/* eslint no-mixed-spaces-and-tabs: ["error", "smart-tabs"]*/
-	/* global $tw, require */
 	"use strict";
 	
 	describe("Filter tests", function() {
@@ -1134,9 +1129,26 @@ Tests the filtering mechanism.
 			expect(wiki.filterTiddlers("[[<>:\"/\\|?*]encodeuricomponent[]]").join(",")).toBe("%3C%3E%3A%22%2F%5C%7C%3F%2A");
 		});
 	
+		it("should handle the moduleproperty operator", function() {
+			// We don't need to confirm them all, only it it finds at least one module name that we're sure is there.
+			expect(wiki.filterTiddlers("[[macro]modules[]moduleproperty[name]]")).toContain("qualify");
+			// No such property. Nothing to return.
+			expect(wiki.filterTiddlers("[[macro]modules[]moduleproperty[nonexistent]]").length).toBe(0);
+			// No such tiddlers. Nothing to return.
+			expect(wiki.filterTiddlers("[[nonexistent]moduleproperty[name]]").length).toBe(0);
+			// Non string properties should get toStringed.
+			expect(wiki.filterTiddlers("[[$:/core/modules/commands/init.js]moduleproperty[info]]").join(" ")).toBe('{"name":"init","synchronous":true}');
+		});
+
+		it("should minimize unnecessary variable lookup", function() {
+			var widget = wiki.makeWidget();
+			var getVar = spyOn(widget, "getVariableInfo").and.callThrough();
+			expect(wiki.filterTiddlers("[all[]prefix[anything]]", widget).length).toBe(0);
+			// We didn't use any indirect operands or variables.
+			// No variable lookup should have occurred.
+			expect(getVar).not.toHaveBeenCalled();
+		});
 	}
 	
 	});
 	
-	})();
-	

package/editions/test/tiddlers/tests/test-html-parser.js

@@ -6,10 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests for the internal components of the HTML tag parser
 
 \*/
-(function(){
 
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 function FakeParser() {
@@ -231,5 +228,3 @@ describe("HTML tag new parser tests", function() {
 	});
 
 });
-
-})();

package/editions/test/tiddlers/tests/test-json-filters.js

@@ -6,7 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests the JSON filters and the format:json operator
 
 \*/
-(function(){
+
 
 /* jslint node: true, browser: true */
 /* eslint-env node, browser, jasmine */
@@ -151,4 +151,3 @@ describe("json filter tests", function() {
 
 });
 
-})();

package/editions/test/tiddlers/tests/test-linked-list.js

@@ -21,10 +21,7 @@ NOTE TO FURTHER LINKED LIST DEVELOPERS:
 	the end. I think you'll probably be better off preventing 'prev' from ever
 	adding undefined.
 \*/
-(function(){
 
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe("LinkedList class tests", function() {
@@ -307,4 +304,3 @@ describe("LinkedList class tests", function() {
 	});
 });
 
-})();

package/editions/test/tiddlers/tests/test-parsetextreference.js

@@ -6,10 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests for source attribute in parser returned from wiki.parseTextReference
 
 \*/
-(function(){
 
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe("Wiki.parseTextReference tests", function() {
@@ -129,4 +126,3 @@ describe("Wiki.parseTextReference tests", function() {
 
 });
 
-})();

package/editions/test/tiddlers/tests/test-plugins.js

@@ -6,10 +6,6 @@ tags: [[$:/tags/test-spec]]
 Tests for integrity of the core plugins, languages, themes and editions
 
 \*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 if($tw.node) {
@@ -50,6 +46,3 @@ if($tw.node) {
 		});
 	});
 }
-
-
-})();

package/editions/test/tiddlers/tests/test-popup.js

@@ -6,10 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests some utility function of the Popup prototype.
 
 \*/
-(function(){
 
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe("Popup tests", function() {
@@ -60,4 +57,3 @@ describe("Popup tests", function() {
 	});
 });
 
-})();

package/editions/test/tiddlers/tests/test-prefixes-filter.js

@@ -4,7 +4,7 @@ type: application/javascript
 tags: [[$:/tags/test-spec]]
 Tests the reduce prefix and filter.
 \*/
-(function(){
+
 
 /* jslint node: true, browser: true */
 /* eslint-env node, browser, jasmine */
@@ -459,5 +459,3 @@ describe("'reduce' and 'intersection' filter prefix tests", function() {
 		expect(wiki.filterTiddlers('[tag[shopping]] :reduce[<echo "$(accumulator)$ $(index)$ $(currentTiddler)$,">]',anchorWidget).join(",")).toBe(" 0 Brownies, 1 Chick Peas, 2 Milk, 3 Rice Pudding,");
 	});
 });
-
-})();

package/editions/test/tiddlers/tests/test-tags-operator.js

@@ -6,8 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests the tagging mechanism.
 
 \*/
-/*jslint node: true, browser: true */
-/*global $tw: false */
+
 "use strict";
 
 describe("Tags Operator tests", function() {

package/editions/test/tiddlers/tests/test-tags.js

@@ -6,10 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests the tagging mechanism.
 
 \*/
-(function(){
 
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe("Tag tests", function() {
@@ -179,4 +176,3 @@ function runTests(wiki,wikiOptions) {
 
 });
 
-})();

package/editions/test/tiddlers/tests/test-tiddler.js

@@ -6,10 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests the tiddler object
 
 \*/
-(function(){
 
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe("Tiddler tests", function() {
@@ -134,4 +131,3 @@ describe("Tiddler tests", function() {
 
 });
 
-})();

package/editions/test/tiddlers/tests/test-utils.js

@@ -6,10 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests various utility functions.
 
 \*/
-(function(){
 
-/*jslint node: true, browser: true */
-/*global $tw: false */
 "use strict";
 
 describe("Utility tests", function() {
@@ -210,5 +207,3 @@ describe("Utility tests", function() {
 	});
 
 });
-
-})();