magus-cli 7.7.0 → 7.9.0

package/src/services/version-snapshot.ts

@@ -1,189 +0,0 @@
-/**
- * version-snapshot.ts — detect plugin changes that happened outside magus.
- *
- * Plugins get updated by things magus does not control: Claude Code's own
- * `plugin install`/`update`, or a direct CLI
- * call. All of them write `installed_plugins.json`; none of them tell the user
- * anything the next time magus opens, so versions move underfoot silently.
- *
- * Rather than log what magus itself did — which misses every other source —
- * this records what magus last *saw* installed and diffs against reality on
- * load. Any change is reported, regardless of who made it.
- *
- * The snapshot is advisory UI state, kept separate from the update-check cache
- * so a TTL expiry or a corrupt cache can never make plugins look changed.
- */
-
-import { promises as fs } from "node:fs";
-import os from "node:os";
-import path from "node:path";
-
-/**
- * Sentinel recorded by Claude Code for a plugin that is installed but whose
- * version is unknown — every plugin in the official Anthropic marketplace uses
- * it. It is not a real version and must never be rendered as one.
- */
-export const UNKNOWN_VERSION = "0.0.0";
-
-/** True when a version string carries no usable information. */
-export function isKnownVersion(v: string | undefined): v is string {
-	return !!v && v !== UNKNOWN_VERSION;
-}
-
-export type PluginChangeKind = "installed" | "updated";
-
-export interface PluginChange {
-	pluginId: string;
-	kind: PluginChangeKind;
-	/** Previous version. Only set for "updated", and always a known version. */
-	from?: string;
-	/** Current version. May be UNKNOWN_VERSION — callers must not render it raw. */
-	to: string;
-}
-
-interface SnapshotFile {
-	/**
-	 * Legacy flat baseline: pluginId -> version, with no record of which project
-	 * it was observed from. Kept only so an existing file can be migrated.
-	 */
-	seen?: Record<string, string>;
-	/**
-	 * projectPath -> (pluginId -> installedVersion) as of the last time magus
-	 * rendered that project.
-	 *
-	 * Versions are per-project (installed_plugins.json keys installs by
-	 * projectPath), but this file is global. A single flat map therefore let two
-	 * projects legitimately on different versions overwrite each other's
-	 * baseline, and every differing plugin was badged "updated" on the next
-	 * render — a change that never happened. Keying by project removes the
-	 * cross-talk entirely.
-	 */
-	byProject?: Record<string, Record<string, string>>;
-	/** Set on the run that first created the baseline. */
-	seededAt: string;
-	updatedAt: string;
-}
-
-/**
- * Honour CLAUDE_CONFIG_DIR — the same override Claude Code itself uses.
- *
- * `os.homedir()` reads the passwd database on macOS and ignores $HOME, so a
- * test that only overrides HOME writes to the operator's real snapshot file.
- * That is not hypothetical: it happened while building the tests for this fix.
- */
-function snapshotPath(): string {
-	const configDir =
-		process.env.CLAUDE_CONFIG_DIR || path.join(os.homedir(), ".claude");
-	return path.join(configDir, "magus-version-snapshot.json");
-}
-
-async function read(): Promise<SnapshotFile | null> {
-	try {
-		const raw = await fs.readFile(snapshotPath(), "utf-8");
-		const data = JSON.parse(raw) as SnapshotFile;
-		if (!data) return null;
-		const hasFlat = typeof data.seen === "object" && data.seen !== null;
-		const hasByProject =
-			typeof data.byProject === "object" && data.byProject !== null;
-		if (!hasFlat && !hasByProject) return null;
-		return data;
-	} catch {
-		return null; // absent or corrupt — treated as "no baseline yet"
-	}
-}
-
-/**
- * Diff what is installed now against the previous snapshot.
- *
- * Three cases are deliberately silent, because each reflects magus's own
- * knowledge changing rather than anything happening to the user's plugins:
- *
- *  1. No baseline (first run). Every plugin would otherwise be reported as
- *     newly installed on the very first launch — a guaranteed false flood that
- *     trains the user to ignore the badge. The first run seeds and says nothing.
- *
- *  2. A version moving to or from UNKNOWN_VERSION. That is magus learning
- *     (or losing) a version it could not previously resolve — notably after
- *     v4.22.0 taught it to read the registry — not the plugin changing.
- *
- *  3. A plugin disappearing. Uninstalls are visible elsewhere; nothing to badge.
- *
- * A downgrade IS reported: rolling back is a real change worth surfacing.
- */
-export function diffVersions(
-	previous: Record<string, string> | null,
-	current: Record<string, string>,
-): PluginChange[] {
-	if (!previous) return [];
-
-	const changes: PluginChange[] = [];
-	for (const [pluginId, to] of Object.entries(current)) {
-		const from = previous[pluginId];
-
-		// Never seen before → newly installed, not an update. There is no
-		// meaningful "from", and `to` may legitimately be UNKNOWN_VERSION.
-		if (from === undefined) {
-			changes.push({ pluginId, kind: "installed", to });
-			continue;
-		}
-
-		if (from === to) continue;
-
-		// One side carries no real version: we learned or lost it, nothing moved.
-		if (!isKnownVersion(from) || !isKnownVersion(to)) continue;
-
-		changes.push({ pluginId, kind: "updated", from, to });
-	}
-	return changes;
-}
-
-/**
- * Load the baseline for one project, or null when that project has none.
- *
- * A project seen for the first time returns null, so `diffVersions` stays
- * silent — the same rule as a first ever run. That is deliberate: opening
- * magus in a new project must not badge every plugin as "updated" just
- * because this file has never seen that path before.
- *
- * A pre-migration flat file is adopted as the baseline for whichever project
- * asks first, which is the closest thing to the truth it contains.
- */
-export async function loadSeenVersions(
-	projectPath: string,
-): Promise<Record<string, string> | null> {
-	const data = await read();
-	if (!data) return null;
-	const scoped = data.byProject?.[projectPath];
-	if (scoped) return scoped;
-	// Legacy flat baseline, project unknown — use it once, then it is replaced
-	// by per-project entries on save.
-	if (data.seen && !data.byProject) return data.seen;
-	return null;
-}
-
-/**
- * Persist what is installed now, so the same change is not reported twice.
- * Best-effort: a failure here must never break the UI — it only means the badge
- * shows again next launch.
- */
-export async function saveSeenVersions(
-	projectPath: string,
-	current: Record<string, string>,
-): Promise<void> {
-	try {
-		const file = snapshotPath();
-		await fs.mkdir(path.dirname(file), { recursive: true });
-		const existing = await read();
-		const now = new Date().toISOString();
-		const payload: SnapshotFile = {
-			// Other projects' baselines are preserved — writing only this project's
-			// slot is the entire point of the fix.
-			byProject: { ...(existing?.byProject ?? {}), [projectPath]: current },
-			seededAt: existing?.seededAt ?? now,
-			updatedAt: now,
-		};
-		await fs.writeFile(file, JSON.stringify(payload, null, 2), "utf-8");
-	} catch {
-		// ignore
-	}
-}

package/src/utils/go-module.ts

@@ -1,36 +0,0 @@
-/**
- * Go module path → installed binary name.
- *
- * `go install` names the binary after the last path element of the module
- * path, EXCEPT when that element is a major-version suffix: the module
- * `github.com/MadAppGang/tmux-mcp/v2` installs `tmux-mcp`, not `v2`. Taking a
- * plain basename therefore points every later check at a binary that never
- * exists — presence probes fail, so the module is reinstalled on every run,
- * doctor reports it missing, and the pin comparison never runs at all.
- *
- * Only the Go rule lives here. npm and cargo share the `name@version` syntax
- * but not the suffix convention — an npm scoped package can legitimately be
- * called `@scope/v2` — so this must not be folded into the generic spec parser.
- */
-
-/**
- * Trailing major-version suffix per the Go modules spec: `/vN` with N >= 2.
- * Anchored to the END of the path with nothing after `vN`, so a segment that
- * merely starts with "v2" (`github.com/x/v2tool`) is a real name, not a suffix.
- * v0 and v1 are never written as a path suffix. The alternation, not a plain
- * `[2-9][0-9]*`, because that shorthand rejects v10–v19 — a first digit of 1
- * is only excluded when it is the ONLY digit.
- */
-const MAJOR_VERSION_SUFFIX = /\/v(?:[2-9]|[1-9][0-9]+)$/;
-
-/**
- * The binary `go install <modulePath>` produces.
- *
- * Takes the MODULE PATH — the part before any `@version` — so callers that
- * hold a full `path@version` spec split it first. An empty or single-segment
- * input is returned unchanged.
- */
-export function goBinaryName(modulePath: string): string {
-	const withoutSuffix = modulePath.replace(MAJOR_VERSION_SUFFIX, "");
-	return withoutSuffix.split("/").pop() || withoutSuffix;
-}