magus-cli 7.7.0 → 7.9.0

package/src/__tests__/notices-rules.test.ts

@@ -1,476 +0,0 @@
-/**
- * Notice rules: eviction order, pausing under a modal, the unchanged-plugin summary,
- * and what PROFILE_ACTIVATED asks of the app.
- *
- * Written blind: from the spec and the exported signatures and types only
- * (`appReducer`, `initialState`, `MAX_NOTICES`, `NOTICE_DURATION_MS`, the AppAction
- * union and AppState in ui/state/types.ts, `noMoveReasons()` and the `ApplyReporter`
- * interface it hands back). No function body was used to decide an expectation.
- *
- * Coverage map (requirement → describe block):
- *   REQ-A1 5th distinct notice drops the oldest SUCCESS       → "REQ-A eviction"
- *   REQ-A2 a warning goes only when every line is a warning   → "REQ-A eviction"
- *   REQ-A3 a new success is itself dropped among 4 warnings   → "REQ-A eviction"
- *   REQ-B1 EXPIRE_NOTICES does nothing while paused           → "REQ-B pause"
- *   REQ-B2 resume gives each line back the time it was held   → "REQ-B pause"
- *   REQ-B3 ... capped at its full duration from resume        → "REQ-B pause"
- *   REQ-B4 a line posted while paused gets its full duration  → "REQ-B pause"
- *   REQ-C1 0 unchanged → no notice                            → "REQ-C noMoveReasons"
- *   REQ-C2 1 unchanged → `No change: <id>: <reason>`          → "REQ-C noMoveReasons"
- *   REQ-C3 several, same reason → one line with the reason    → "REQ-C noMoveReasons"
- *   REQ-C4 several, different reasons → one line, no reason   → "REQ-C noMoveReasons"
- *   REQ-D  PROFILE_ACTIVATED bumps both counters by one       → "REQ-D PROFILE_ACTIVATED"
- *
- * Known gaps:
- *   REQ-C tone ("warning"): `notice()` returns a bare string, so the tone is chosen
- *   by the screen that posts it; the contract gives no pure seam to observe it.
- *   REQ-B "while a modal is open": which component dispatches PAUSE/RESUME is not in
- *   the contract, so only the reducer half is tested.
- *
- * Reasons reach `noMoveReasons` through its reporter: the contract says the engine
- * reports the cause as the finish detail `no change — <why>` for an item whose
- * installer exited 0, so the tests call `reporter.finish(true, name, detail, ms)`.
- */
-import { describe, expect, test } from "bun:test";
-import { noMoveReasons } from "../ui/adapters/pluginsAdapter.js";
-import {
-	MAX_NOTICES,
-	NOTICE_DURATION_MS,
-	appReducer,
-	initialState,
-} from "../ui/state/reducer.js";
-import type {
-	AppAction,
-	AppState,
-	ModalState,
-	Notice,
-	NoticeTone,
-} from "../ui/state/types.js";
-
-// ---------------------------------------------------------------------------
-// Builders
-// ---------------------------------------------------------------------------
-
-let nextId = 1;
-function notice(
-	text: string,
-	tone: NoticeTone = "success",
-	expiresAt = 1_000_000,
-): Notice {
-	return { id: nextId++, text, tone, expiresAt };
-}
-
-function stateWith(notices: Notice[] = []): AppState {
-	return { ...initialState, notices };
-}
-
-function run(state: AppState, ...actions: AppAction[]): AppState {
-	return actions.reduce(appReducer, state);
-}
-
-function notifyAll(state: AppState, notices: Notice[]): AppState {
-	return run(
-		state,
-		...notices.map((n): AppAction => ({ type: "NOTIFY", notice: n })),
-	);
-}
-
-function texts(state: AppState): string[] {
-	return state.notices.map((n) => n.text);
-}
-
-// ---------------------------------------------------------------------------
-// REQ-A eviction
-// ---------------------------------------------------------------------------
-
-describe("REQ-A eviction", () => {
-	test("REQ-A the banner holds at most MAX_NOTICES (4) lines", () => {
-		expect(MAX_NOTICES).toBe(4);
-
-		const next = notifyAll(
-			stateWith(),
-			["a", "b", "c", "d", "e", "f"].map((t) => notice(t)),
-		);
-
-		expect(next.notices).toHaveLength(MAX_NOTICES);
-	});
-
-	test("REQ-A1 a fifth warning drops the only success, not the oldest warning", () => {
-		const lines = [
-			notice("warn-1", "warning"),
-			notice("warn-2", "warning"),
-			notice("ok-1", "success"),
-			notice("warn-3", "warning"),
-		];
-
-		const next = notifyAll(stateWith(), [
-			...lines,
-			notice("warn-4", "warning"),
-		]);
-
-		expect(texts(next)).toEqual(["warn-1", "warn-2", "warn-3", "warn-4"]);
-	});
-
-	test("REQ-A1 of two successes, the OLDER success is the one dropped", () => {
-		const next = notifyAll(stateWith(), [
-			notice("warn-1", "warning"),
-			notice("ok-old", "success"),
-			notice("ok-new", "success"),
-			notice("warn-2", "warning"),
-			notice("ok-latest", "success"),
-		]);
-
-		expect(texts(next)).toEqual(["warn-1", "ok-new", "warn-2", "ok-latest"]);
-	});
-
-	test("REQ-A1 a success that is the oldest line overall is dropped first", () => {
-		const next = notifyAll(stateWith(), [
-			notice("ok-1", "success"),
-			notice("warn-1", "warning"),
-			notice("ok-2", "success"),
-			notice("warn-2", "warning"),
-			notice("warn-3", "warning"),
-		]);
-
-		expect(texts(next)).toEqual(["warn-1", "ok-2", "warn-2", "warn-3"]);
-	});
-
-	test("REQ-A2 when every line is a warning, the oldest warning is dropped", () => {
-		const next = notifyAll(stateWith(), [
-			notice("warn-1", "warning"),
-			notice("warn-2", "warning"),
-			notice("warn-3", "warning"),
-			notice("warn-4", "warning"),
-			notice("warn-5", "warning"),
-		]);
-
-		expect(texts(next)).toEqual(["warn-2", "warn-3", "warn-4", "warn-5"]);
-	});
-
-	test("REQ-A3 a new success among four warnings is itself the line dropped", () => {
-		const warnings = [
-			notice("warn-1", "warning"),
-			notice("warn-2", "warning"),
-			notice("warn-3", "warning"),
-			notice("warn-4", "warning"),
-		];
-
-		const next = notifyAll(stateWith(), [...warnings, notice("ok-new")]);
-
-		expect(next.notices).toEqual(warnings);
-	});
-
-	test("REQ-A a repeated text at the cap evicts nothing else", () => {
-		const next = notifyAll(stateWith(), [
-			notice("ok-1", "success"),
-			notice("warn-1", "warning"),
-			notice("ok-2", "success"),
-			notice("warn-2", "warning"),
-			notice("ok-1", "success"),
-		]);
-
-		expect([...texts(next)].sort()).toEqual([
-			"ok-1",
-			"ok-2",
-			"warn-1",
-			"warn-2",
-		]);
-	});
-});
-
-// ---------------------------------------------------------------------------
-// REQ-B pause
-// ---------------------------------------------------------------------------
-
-const PAUSED_AT = 1_000_000;
-const RESUMED_AT = PAUSED_AT + 60_000;
-
-describe("REQ-B pause", () => {
-	test("REQ-B1 EXPIRE_NOTICES removes nothing while paused, even long past expiry", () => {
-		const a = notice("ok", "success", PAUSED_AT + 2_000);
-		const b = notice("careful", "warning", PAUSED_AT + 5_000);
-
-		const next = run(
-			stateWith([a, b]),
-			{ type: "PAUSE_NOTICES", now: PAUSED_AT },
-			{ type: "EXPIRE_NOTICES", now: PAUSED_AT + 500_000 },
-		);
-
-		expect(next.notices).toEqual([a, b]);
-	});
-
-	test("REQ-B1 PAUSE_NOTICES records when the pause began; RESUME_NOTICES clears it", () => {
-		const paused = run(stateWith(), { type: "PAUSE_NOTICES", now: PAUSED_AT });
-		const resumed = run(paused, { type: "RESUME_NOTICES", now: RESUMED_AT });
-
-		expect(paused.noticesPausedAt).toBe(PAUSED_AT);
-		expect(resumed.noticesPausedAt).toBeNull();
-	});
-
-	test("REQ-B2 a line with 2 s left at pause still has 2 s after resume", () => {
-		const held = notice("ok", "success", PAUSED_AT + 2_000);
-
-		const resumed = run(
-			stateWith([held]),
-			{ type: "PAUSE_NOTICES", now: PAUSED_AT },
-			{ type: "RESUME_NOTICES", now: RESUMED_AT },
-		);
-
-		expect(resumed.notices).toHaveLength(1);
-		expect(resumed.notices[0].expiresAt).toBe(RESUMED_AT + 2_000);
-	});
-
-	test("REQ-B2 after resume the line survives just before its held time and is gone just after", () => {
-		const held = notice("careful", "warning", PAUSED_AT + 3_000);
-		const resumed = run(
-			stateWith([held]),
-			{ type: "PAUSE_NOTICES", now: PAUSED_AT },
-			{ type: "RESUME_NOTICES", now: RESUMED_AT },
-		);
-
-		const before = run(resumed, {
-			type: "EXPIRE_NOTICES",
-			now: RESUMED_AT + 2_999,
-		});
-		const after = run(resumed, {
-			type: "EXPIRE_NOTICES",
-			now: RESUMED_AT + 3_001,
-		});
-
-		expect(texts(before)).toEqual(["careful"]);
-		expect(texts(after)).toEqual([]);
-	});
-
-	test("REQ-B2 each line keeps its own remaining time", () => {
-		const soon = notice("soon", "success", PAUSED_AT + 1_000);
-		const later = notice("later", "warning", PAUSED_AT + 7_000);
-
-		const resumed = run(
-			stateWith([soon, later]),
-			{ type: "PAUSE_NOTICES", now: PAUSED_AT },
-			{ type: "RESUME_NOTICES", now: RESUMED_AT },
-		);
-
-		expect(resumed.notices.map((n) => [n.text, n.expiresAt])).toEqual([
-			["soon", RESUMED_AT + 1_000],
-			["later", RESUMED_AT + 7_000],
-		]);
-	});
-
-	test("REQ-B2 timers run again after resume", () => {
-		const held = notice("ok", "success", PAUSED_AT + 2_000);
-
-		const next = run(
-			stateWith([held]),
-			{ type: "PAUSE_NOTICES", now: PAUSED_AT },
-			{ type: "RESUME_NOTICES", now: RESUMED_AT },
-			{ type: "EXPIRE_NOTICES", now: RESUMED_AT + 100_000 },
-		);
-
-		expect(next.notices).toEqual([]);
-	});
-
-	test("REQ-B3 a success held with more than its full duration is capped at the success duration", () => {
-		const long = notice("ok", "success", PAUSED_AT + 50_000);
-
-		const resumed = run(
-			stateWith([long]),
-			{ type: "PAUSE_NOTICES", now: PAUSED_AT },
-			{ type: "RESUME_NOTICES", now: RESUMED_AT },
-		);
-
-		expect(resumed.notices[0].expiresAt).toBe(
-			RESUMED_AT + NOTICE_DURATION_MS.success,
-		);
-	});
-
-	test("REQ-B3 a warning is capped at the warning duration, not the success one", () => {
-		const long = notice("careful", "warning", PAUSED_AT + 500_000);
-
-		const resumed = run(
-			stateWith([long]),
-			{ type: "PAUSE_NOTICES", now: PAUSED_AT },
-			{ type: "RESUME_NOTICES", now: RESUMED_AT },
-		);
-
-		expect(resumed.notices[0].expiresAt).toBe(
-			RESUMED_AT + NOTICE_DURATION_MS.warning,
-		);
-	});
-
-	test("REQ-B4 a success posted during the pause gets its full duration counted from resume", () => {
-		const postedAt = PAUSED_AT + 30_000;
-		const posted = notice(
-			"posted under a modal",
-			"success",
-			postedAt + NOTICE_DURATION_MS.success,
-		);
-
-		const resumed = run(
-			stateWith(),
-			{ type: "PAUSE_NOTICES", now: PAUSED_AT },
-			{ type: "NOTIFY", notice: posted },
-			{ type: "EXPIRE_NOTICES", now: RESUMED_AT - 1 },
-			{ type: "RESUME_NOTICES", now: RESUMED_AT },
-		);
-
-		expect(texts(resumed)).toEqual(["posted under a modal"]);
-		expect(resumed.notices[0].expiresAt).toBe(
-			RESUMED_AT + NOTICE_DURATION_MS.success,
-		);
-	});
-
-	test("REQ-B4 a warning posted during the pause gets the full warning duration from resume", () => {
-		const postedAt = PAUSED_AT + 10;
-		const posted = notice(
-			"act on this",
-			"warning",
-			postedAt + NOTICE_DURATION_MS.warning,
-		);
-
-		const resumed = run(
-			stateWith(),
-			{ type: "PAUSE_NOTICES", now: PAUSED_AT },
-			{ type: "NOTIFY", notice: posted },
-			{ type: "RESUME_NOTICES", now: RESUMED_AT },
-		);
-
-		expect(resumed.notices[0].expiresAt).toBe(
-			RESUMED_AT + NOTICE_DURATION_MS.warning,
-		);
-	});
-});
-
-// ---------------------------------------------------------------------------
-// REQ-C noMoveReasons
-// ---------------------------------------------------------------------------
-
-/** Report `name` as the engine does for an item that ran and did not move. */
-function reportNoMove(
-	collector: ReturnType<typeof noMoveReasons>,
-	name: string,
-	why: string,
-): void {
-	collector.reporter.begin(name);
-	collector.reporter.finish(true, name, `no change — ${why}`, 0);
-}
-
-describe("REQ-C noMoveReasons", () => {
-	test("REQ-C1 nothing unchanged gives no notice", () => {
-		const c = noMoveReasons();
-
-		expect(c.notice([])).toBeNull();
-	});
-
-	test("REQ-C1 nothing unchanged gives no notice even when a reason was reported", () => {
-		const c = noMoveReasons();
-		reportNoMove(c, "dev@magus", "already at the newest version");
-
-		expect(c.notice([])).toBeNull();
-	});
-
-	test("REQ-C2 one unchanged plugin is `No change: <id>: <reason>`", () => {
-		const c = noMoveReasons();
-		reportNoMove(c, "dev@magus", "already at the newest version");
-
-		expect(c.notice(["dev@magus"])).toBe(
-			"No change: dev@magus: already at the newest version",
-		);
-	});
-
-	test("REQ-C3 several unchanged with the same reason are ONE line with count, names and reason", () => {
-		const c = noMoveReasons();
-		for (const name of ["alpha", "beta", "gamma"]) {
-			reportNoMove(c, name, "marketplace not refreshed");
-		}
-
-		const line = c.notice(["alpha", "beta", "gamma"]);
-
-		expect(line).toBe(
-			"3 plugins unchanged — alpha, beta, gamma: marketplace not refreshed",
-		);
-	});
-
-	test("REQ-C3 the count follows the number of unchanged plugins", () => {
-		const c = noMoveReasons();
-		reportNoMove(c, "alpha", "pinned");
-		reportNoMove(c, "beta", "pinned");
-
-		expect(c.notice(["alpha", "beta"])).toBe(
-			"2 plugins unchanged — alpha, beta: pinned",
-		);
-	});
-
-	test("REQ-C4 several unchanged with different reasons are ONE line with no reason", () => {
-		const c = noMoveReasons();
-		reportNoMove(c, "alpha", "marketplace not refreshed");
-		reportNoMove(c, "beta", "pinned");
-		reportNoMove(c, "gamma", "marketplace not refreshed");
-
-		const line = c.notice(["alpha", "beta", "gamma"]);
-
-		expect(line).toBe("3 plugins unchanged — alpha, beta, gamma");
-	});
-
-	test("REQ-C the summary is a single line", () => {
-		const c = noMoveReasons();
-		reportNoMove(c, "alpha", "one");
-		reportNoMove(c, "beta", "two");
-
-		const line = c.notice(["alpha", "beta"]);
-
-		expect(line).not.toBeNull();
-		expect(line).not.toContain("\n");
-	});
-});
-
-// ---------------------------------------------------------------------------
-// REQ-D PROFILE_ACTIVATED
-// ---------------------------------------------------------------------------
-
-describe("REQ-D PROFILE_ACTIVATED", () => {
-	const modal: ModalState = { type: "loading", message: "Working" };
-
-	function activeState(): AppState {
-		return {
-			...initialState,
-			dataRefreshVersion: 7,
-			gitignoreCheckRequest: 3,
-			notices: [notice("Saved"), notice("careful", "warning")],
-			modal,
-		};
-	}
-
-	test("REQ-D bumps dataRefreshVersion by one", () => {
-		const next = appReducer(activeState(), { type: "PROFILE_ACTIVATED" });
-
-		expect(next.dataRefreshVersion).toBe(8);
-	});
-
-	test("REQ-D bumps gitignoreCheckRequest by one", () => {
-		const next = appReducer(activeState(), { type: "PROFILE_ACTIVATED" });
-
-		expect(next.gitignoreCheckRequest).toBe(4);
-	});
-
-	test("REQ-D twice bumps both by two", () => {
-		const next = run(
-			activeState(),
-			{ type: "PROFILE_ACTIVATED" },
-			{ type: "PROFILE_ACTIVATED" },
-		);
-
-		expect([next.dataRefreshVersion, next.gitignoreCheckRequest]).toEqual([
-			9, 5,
-		]);
-	});
-
-	test("REQ-D leaves the notices and the modal unchanged", () => {
-		const state = activeState();
-
-		const next = appReducer(state, { type: "PROFILE_ACTIVATED" });
-
-		expect(next.notices).toEqual(state.notices);
-		expect(next.modal).toBe(modal);
-	});
-});