magus-cli 7.7.0 → 7.9.0

package/src/__tests__/failure-popup-review2.test.tsx

@@ -0,0 +1,896 @@
+/**
+ * The second review of the 7.8.0 failure popup: everything the user must know
+ * because something failed goes into ONE popup, for every kind of subject, and
+ * nothing else is said. One describe per review item (H1–H5, M6–M10, L11).
+ *
+ * Pure builders are tested directly; the apply paths through the real engine
+ * with injected Claude Code calls, so the words are the engine's own.
+ */
+
+import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
+import { mkdir } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { testRender } from "@opentui/react/test-utils";
+import { act } from "react";
+import { findPluginLoadProblems } from "../cli/doctor.js";
+import { claudeFailureMessage } from "../services/claude-cli.js";
+import {
+	type StaleLoadRepairResult,
+	forgetInstalledPluginVersion,
+	notDownloadedReason,
+} from "../services/claude-settings.js";
+import {
+	type PluginInfo,
+	orphanCandidateIds,
+} from "../services/plugin-manager.js";
+import type { ActivationResult } from "../services/profile-activate.js";
+import { requiredByHere, resolveDependencies } from "../services/resolver.js";
+import {
+	type PluginApplyDeps,
+	applyPlugins,
+	describeLoadNotForward,
+} from "../services/update-engine.js";
+import {
+	type PluginUpdateItem,
+	planPluginUpdates,
+} from "../services/update-plan.js";
+import { failureReport } from "../ui/adapters/failureReport.js";
+import {
+	INSTALL_CLAUDE_FIX,
+	RETRY_NETWORK_FIX,
+	exceptionReason,
+	failureReasons,
+	pluginFailureReport,
+	unchangedReason,
+} from "../ui/adapters/pluginsAdapter.js";
+import {
+	activationFailureReport,
+	gitignoreStartupReport,
+	gitignoreTemplateReport,
+	profileProblemRow,
+	profileProblemsReport,
+	staleRepairReport,
+} from "../ui/adapters/startupReports.js";
+import {
+	FailureListModal,
+	visibleFailureRows,
+} from "../ui/components/modals/FailureListModal.js";
+import { renderMcpDetail, renderMcpRow } from "../ui/renderers/mcpRenderers.js";
+import { appReducer, initialState } from "../ui/state/reducer.js";
+import type { FailureReport } from "../ui/state/types.js";
+
+const PROJECT = "/tmp/magus-failure-popup-review2";
+
+function updateItem(
+	pluginId: string,
+	over: Partial<PluginUpdateItem> = {},
+): PluginUpdateItem {
+	return {
+		pluginId,
+		pinned: "latest",
+		installed: "1.0.0",
+		loaded: "1.0.0",
+		available: "2.0.0",
+		target: "2.0.0",
+		action: "update",
+		reason: "behind",
+		scopes: ["project"],
+		beforeVersions: { project: "1.0.0" },
+		...over,
+	};
+}
+
+/** Every call succeeds; `readInstalled` answers `lands` per plugin. */
+function deps(
+	lands: Record<string, string | null>,
+	throws: Record<string, string> = {},
+): PluginApplyDeps {
+	return {
+		install: async (id) => {
+			if (throws[id]) throw new Error(throws[id]);
+		},
+		update: async (id) => {
+			if (throws[id]) throw new Error(throws[id]);
+		},
+		repair: async () => {},
+		readInstalled: async (id) => lands[id] ?? null,
+		saveInstalled: async () => {},
+		repairStaleLoad: async (id, target) => ({
+			pluginId: id,
+			target,
+			rewritten: 0,
+			backup: null,
+			loaded: target,
+			ok: true,
+		}),
+	};
+}
+
+function info(over: Partial<PluginInfo> & { id: string }): PluginInfo {
+	const [name = over.id, marketplace = ""] = over.id.split("@");
+	return {
+		name,
+		version: null,
+		description: "",
+		marketplace,
+		marketplaceDisplay: marketplace,
+		...over,
+	};
+}
+
+/** Every string the popup shows. */
+function texts(report: FailureReport): string {
+	return [
+		report.headline,
+		...report.rows.flatMap((r) => [r.subject, r.reason, r.fix ?? ""]),
+		report.fix ?? "",
+	].join("\n");
+}
+
+// ── H1 ───────────────────────────────────────────────────────────────────────
+
+describe("H1: an update that ran and changed nothing is 'not updated'", () => {
+	test("the engine's unchanged item reaches the popup, with the reason in the user's terms", async () => {
+		const popup = failureReasons();
+		const items = [updateItem("dev@magus"), updateItem("go@magus")];
+		// dev reads back the version it had; go moves.
+		const result = await applyPlugins(
+			items,
+			PROJECT,
+			deps({ "dev@magus": "1.0.0", "go@magus": "2.0.0" }),
+			popup.reporter,
+		);
+		expect(result.failed).toEqual([]);
+		expect(result.unchanged).toEqual(["dev@magus"]);
+
+		const report = popup.report(
+			result.failed,
+			new Map(items.map((i) => [i.pluginId, i.action])),
+			result.unchanged,
+		);
+		expect(report).toEqual({
+			headline: "dev was not updated",
+			rows: [{ subject: "dev", reason: "it ran, but it is still v1.0.0" }],
+			fix: null,
+		});
+		expect(texts(report as FailureReport)).not.toContain("installer");
+		expect(texts(report as FailureReport)).not.toContain("exited 0");
+	});
+
+	test("NEGATIVE CONTROL: nothing unchanged and nothing failed — no popup", async () => {
+		const popup = failureReasons();
+		const result = await applyPlugins(
+			[updateItem("go@magus")],
+			PROJECT,
+			deps({ "go@magus": "2.0.0" }),
+			popup.reporter,
+		);
+		expect(popup.report(result.failed, undefined, result.unchanged)).toBeNull();
+	});
+
+	test("the words: version, nothing recorded, and a misdirected update with its fix", () => {
+		expect(
+			unchangedReason(
+				"no change — the installer exited 0 but dev@magus is still 8.0.0",
+			),
+		).toBe("it ran, but it is still v8.0.0");
+		expect(
+			unchangedReason(
+				"no change — the installer exited 0 but no version of dev@magus was recorded",
+			),
+		).toBe("it ran, but no installed version of it can be found afterwards");
+		const report = pluginFailureReport([
+			{
+				pluginId: "dev@magus",
+				verb: "updated",
+				unchanged: true,
+				detail:
+					"no change — the installer exited 0 but dev@magus is still 0.4.0 (Claude Code updated another folder of this repository instead of this one, and this folder could not follow: v0.6.0 is not downloaded — run magus install)",
+			},
+		]);
+		expect(report?.fix).toBe("Run magus install");
+		expect(report?.rows[0]?.reason).toStartWith(
+			"it ran, but it is still v0.4.0; ",
+		);
+	});
+});
+
+// ── H2 ───────────────────────────────────────────────────────────────────────
+
+describe("H2: the startup gate's refusals go into the popup", () => {
+	const problem =
+		".claude/settings.json cannot be read (Unexpected token } in JSON at position 12) — fix it by hand; magus left it as it is and did not switch";
+
+	test("the file is the subject, the instruction the fix", () => {
+		expect(profileProblemRow(problem)).toEqual({
+			subject: ".claude/settings.json",
+			reason:
+				"cannot be read (Unexpected token } in JSON at position 12) — magus left it as it is and did not switch",
+			fix: "Fix it by hand",
+		});
+		const report = profileProblemsReport([problem]);
+		expect(report?.headline).toBe(
+			"This project's profile was not brought up to date",
+		);
+		expect(report?.fix).toBe("Fix it by hand");
+	});
+
+	test("a line of another shape is about the profile", () => {
+		expect(profileProblemRow('Profile "x" not found. Available: a, b')).toEqual(
+			{
+				subject: "profile",
+				reason: 'Profile "x" not found. Available: a, b',
+			},
+		);
+	});
+
+	test("NEGATIVE CONTROL: no problems, no popup", () => {
+		expect(profileProblemsReport([])).toBeNull();
+	});
+});
+
+// ── H3 ───────────────────────────────────────────────────────────────────────
+
+function activation(over: Partial<ActivationResult> = {}): ActivationResult {
+	return {
+		profileId: "team",
+		displaced: [],
+		skills: { skills: {}, installed: [], removed: [], failed: [] },
+		conversion: {
+			converted: false,
+			managed: {},
+			restored: [],
+			conflicts: [],
+			keptAt: null,
+		},
+		tracked: [],
+		keptAt: null,
+		...over,
+	};
+}
+
+describe("H3: what an activation could not do, from ONE builder", () => {
+	test("blocked dependency, not downloaded, failed skill, two copies — each a row with its fix", () => {
+		const report = activationFailureReport([
+			activation({
+				dependencies: {
+					derived: [],
+					unreadable: ["mnemex@magus"],
+					blocked: [
+						{ plugin: "multimodel@magus", dependency: "claudish@magus" },
+					],
+				},
+				skills: {
+					skills: {},
+					installed: [],
+					removed: [],
+					failed: [{ skill: "tdd", reason: "GitHub answered 404\nstack" }],
+				},
+				conversion: {
+					converted: true,
+					managed: {},
+					restored: [],
+					conflicts: [
+						{
+							folder: "notes",
+							kept: ".claude/skills/notes",
+							other: ".claude/_profiles/team/skills/notes",
+						},
+					],
+					keptAt: null,
+				},
+			}),
+		]) as FailureReport;
+
+		expect(report.headline).toBe(
+			'Profile "team" is active, but 4 things did not work',
+		);
+		expect(report.fix).toBeNull();
+		expect(report.rows).toEqual([
+			{
+				subject: "multimodel",
+				reason:
+					'will not load: it depends on claudish, which profile "team" turns off',
+				fix: 'Remove "claudish@magus": false from the profile to let it load',
+			},
+			{
+				subject: "mnemex",
+				reason:
+					"is not downloaded on this machine, so nothing it depends on was turned on",
+				fix: "Run magus install",
+			},
+			{
+				subject: "skill tdd",
+				reason: "was not installed: GitHub answered 404",
+			},
+			{
+				subject: "skill notes",
+				reason:
+					"exists in two copies: .claude/skills/notes is the one in use, the other is at .claude/_profiles/team/skills/notes",
+				fix: "Compare the two and delete the one you do not want",
+			},
+		]);
+	});
+
+	test("the same finding from two activations (re-render, then conversion) is said once", () => {
+		const blocked = activation({
+			dependencies: {
+				derived: [],
+				unreadable: ["mnemex@magus"],
+				blocked: [],
+			},
+		});
+		const report = activationFailureReport([blocked, blocked]);
+		expect(report?.rows).toHaveLength(1);
+		expect(report?.fix).toBe("Run magus install");
+	});
+
+	test("NEGATIVE CONTROL: a clean activation says nothing", () => {
+		expect(activationFailureReport([activation()])).toBeNull();
+		expect(activationFailureReport([])).toBeNull();
+	});
+});
+
+// ── H4 ───────────────────────────────────────────────────────────────────────
+
+describe("H4: the startup repair's failures go into the popup", () => {
+	const result = (
+		pluginId: string,
+		ok: boolean,
+		error?: string,
+	): StaleLoadRepairResult => ({
+		pluginId,
+		target: "2.0.0",
+		rewritten: ok ? 1 : 0,
+		backup: null,
+		loaded: ok ? "2.0.0" : "1.0.0",
+		ok,
+		...(error ? { error } : {}),
+	});
+
+	test("only the repairs that did not take, each with its reason", () => {
+		const report = staleRepairReport([
+			result("dev@magus", true),
+			result(
+				"go@magus",
+				false,
+				"Claude Code loads the USER install of it here — update it at USER scope",
+			),
+		]);
+		expect(report).toEqual({
+			headline: "go was not repaired",
+			rows: [
+				{
+					subject: "go",
+					reason: "Claude Code loads the USER install of it here",
+				},
+			],
+			fix: "Update it at USER scope",
+		});
+	});
+
+	test("NEGATIVE CONTROL: every repair took — no popup", () => {
+		expect(staleRepairReport([result("dev@magus", true)])).toBeNull();
+	});
+});
+
+// ── H5 ───────────────────────────────────────────────────────────────────────
+
+describe("H5: installedPluginVersions alone is never an install", () => {
+	let dir: string;
+	beforeEach(async () => {
+		dir = await mkdtemp(join(tmpdir(), "magus-h5-"));
+		await mkdir(join(dir, ".claude"), { recursive: true });
+	});
+	afterEach(async () => {
+		await rm(dir, { recursive: true, force: true });
+	});
+
+	test("forgetInstalledPluginVersion drops only magus's claim, leaving Claude Code's fields", async () => {
+		const file = join(dir, ".claude", "settings.json");
+		await writeFile(
+			file,
+			JSON.stringify({
+				enabledPlugins: { "old@magus": true },
+				installedPluginVersions: { "old@magus": "1.0.0", "dev@magus": "9.0.0" },
+			}),
+		);
+		await forgetInstalledPluginVersion("old@magus", "project", dir);
+		const after = JSON.parse(await readFile(file, "utf8"));
+		expect(after.installedPluginVersions).toEqual({ "dev@magus": "9.0.0" });
+		expect(after.enabledPlugins).toEqual({ "old@magus": true });
+	});
+
+	test("NEGATIVE CONTROL: a file with no claim for the plugin is not rewritten", async () => {
+		const file = join(dir, ".claude", "settings.json");
+		const bytes = '{ "installedPluginVersions": {"dev@magus":"9.0.0"} }';
+		await writeFile(file, bytes);
+		await forgetInstalledPluginVersion("old@magus", "project", dir);
+		expect(await readFile(file, "utf8")).toBe(bytes);
+	});
+
+	test("a removal clears the claim at each scope it removed from — not where it is still installed", async () => {
+		const forgotten: string[] = [];
+		const stillAt = new Set(["user"]);
+		const result = await applyPlugins(
+			[
+				updateItem("old@magus", {
+					action: "remove",
+					reason: "deprecated",
+					available: null,
+					target: null,
+					scopes: ["project", "user"],
+				}),
+			],
+			PROJECT,
+			{
+				...deps({}),
+				remove: {
+					uninstall: async () => {},
+					isInstalled: async (_id, scope) => stillAt.has(scope),
+					dropFromProfile: async () => true,
+					forgetVersion: async (_id, scope) => {
+						forgotten.push(scope);
+					},
+				},
+			},
+		);
+		expect(result.failed).toEqual(["old@magus"]);
+		expect(forgotten).toEqual(["project"]);
+	});
+
+	test("doctor: a settings-only claim does not 'load nothing'", () => {
+		const HERE = "/nonexistent/magus-h5/project";
+		expect(
+			findPluginLoadProblems({ "ghost@magus": "1.0.0" }, {}, HERE),
+		).toEqual({ stale: [], loadsNothing: [] });
+		// Turned on here, or with registry rows: that IS an install that loads nothing.
+		expect(
+			findPluginLoadProblems({ "ghost@magus": "1.0.0" }, {}, HERE, {
+				"ghost@magus": true,
+			}).loadsNothing,
+		).toEqual(["ghost@magus"]);
+	});
+
+	test("the Plugins list builds no row from a settings-only claim", () => {
+		const ids = orphanCandidateIds(
+			{ "on@magus": true },
+			{ "ghost@magus": "1.0.0", "rows@magus": "2.0.0" },
+			{
+				"rows@magus": [
+					{
+						scope: "user",
+						version: "2.0.0",
+						installPath: "/nonexistent",
+						installedAt: "",
+						lastUpdated: "",
+					},
+				],
+			},
+		);
+		expect([...ids].sort()).toEqual(["on@magus", "rows@magus"]);
+	});
+});
+
+// ── M6 ───────────────────────────────────────────────────────────────────────
+
+describe("M6: grouping keeps every sentence true", () => {
+	test("different versions become nouns; never 'still loads in this folder'", () => {
+		const report = pluginFailureReport([
+			{
+				pluginId: "a@magus",
+				verb: "updated",
+				detail: "installed v1.3.0, but it did not download — run magus install",
+			},
+			{
+				pluginId: "b@magus",
+				verb: "updated",
+				detail: "installed v2.0.0, but it did not download — run magus install",
+			},
+		]) as FailureReport;
+		expect(report.rows).toEqual([
+			{
+				subject: "a, b",
+				reason: "installed the new version, but it did not download",
+			},
+		]);
+		expect(report.fix).toBe("Run magus install");
+		expect(texts(report)).not.toContain("is not downloaded");
+		expect(texts(report)).not.toContain("still loads in this folder");
+	});
+
+	test("the same recognised exception is one row, its hint said once as the fix", () => {
+		const message =
+			"claude CLI not found in PATH. Install with: npm install -g @anthropic-ai/claude-code";
+		const report = pluginFailureReport([
+			{
+				pluginId: "a@magus",
+				verb: "updated",
+				detail: message,
+				exception: true,
+			},
+			{
+				pluginId: "b@magus",
+				verb: "installed",
+				detail: message,
+				exception: true,
+			},
+		]) as FailureReport;
+		expect(report).toEqual({
+			headline: "2 plugins were not updated or installed",
+			rows: [{ subject: "a, b", reason: "claude CLI not found in PATH" }],
+			fix: INSTALL_CLAUDE_FIX,
+		});
+	});
+
+	test("NEGATIVE CONTROL: an exception magus cannot explain keeps a row of its own", () => {
+		const report = pluginFailureReport([
+			{ pluginId: "a@magus", verb: "updated", detail: "boom", exception: true },
+			{ pluginId: "b@magus", verb: "updated", detail: "boom", exception: true },
+		]);
+		expect(report?.rows).toHaveLength(2);
+		expect(report?.fix).toBeNull();
+	});
+});
+
+// ── M7 ───────────────────────────────────────────────────────────────────────
+
+describe("M7: every dependency edge counts, and a required plugin is never removed", () => {
+	test("an edge to a plugin the profile also names is recorded", async () => {
+		const report = await resolveDependencies(
+			["dev@magus", "kanban@magus"],
+			new Set(),
+			async (id) => (id === "dev@magus" ? ["kanban@magus"] : []),
+		);
+		expect(report.derived).toEqual([]);
+		expect(report.requiredBy).toEqual({ "kanban@magus": "dev@magus" });
+	});
+
+	test("installed plugins' edges join the profile's; the profile's wins", async () => {
+		const edges = await requiredByHere(
+			{ "x@magus": "profile-plugin@magus" },
+			["user-plugin@magus", "other@magus"],
+			PROJECT,
+			async (id) =>
+				id === "user-plugin@magus"
+					? ["kanban@magus", "x@magus"]
+					: id === "other@magus"
+						? null
+						: [],
+		);
+		expect(edges).toEqual({
+			"kanban@magus": "user-plugin@magus",
+			"x@magus": "profile-plugin@magus",
+		});
+	});
+
+	test("a USER-scope install no profile declares, required by an installed plugin, is not removed", () => {
+		const listed = info({
+			id: "user-plugin@magus",
+			version: "1.0.0",
+			userScope: { installed: true, version: "1.0.0" },
+		});
+		const kanban = info({
+			id: "kanban@magus",
+			version: "1.6.2",
+			installedVersion: "1.6.2",
+			isOrphaned: true,
+			userScope: { installed: true, version: "1.6.2" },
+		});
+		const [kept] = planPluginUpdates({}, [listed, kanban], {
+			"kanban@magus": "user-plugin@magus",
+		}).filter((i) => i.pluginId === "kanban@magus");
+		expect(kept).toMatchObject({ action: "unknown", reason: "still-required" });
+
+		// NEGATIVE CONTROL: without the edge it is deprecated and removed.
+		const [removed] = planPluginUpdates({}, [listed, kanban]).filter(
+			(i) => i.pluginId === "kanban@magus",
+		);
+		expect(removed).toMatchObject({ action: "remove" });
+	});
+});
+
+// ── M9 ───────────────────────────────────────────────────────────────────────
+
+describe("M9: MCP restart is state; gitignore failures go into the popup", () => {
+	const server = {
+		name: "context7",
+		description: "docs",
+		type: "http" as const,
+		url: "https://example.invalid",
+	};
+
+	test("a server changed this session carries the restart on its row and detail", async () => {
+		const state = appReducer(initialState, {
+			type: "MCP_SERVER_CHANGED",
+			name: "context7",
+		});
+		expect(state.mcp.changedThisSession).toEqual(["context7"]);
+		// Idempotent.
+		expect(
+			appReducer(state, { type: "MCP_SERVER_CHANGED", name: "context7" }).mcp
+				.changedThisSession,
+		).toEqual(["context7"]);
+
+		const item = {
+			kind: "server" as const,
+			server: server as never,
+			isInstalled: true,
+			needsRestart: true,
+		};
+		const { captureCharFrame, renderOnce, renderer } = await testRender(
+			<box flexDirection="column">
+				{renderMcpRow(item, 0, false)}
+				{renderMcpDetail(item, false)}
+			</box>,
+			{ width: 80, height: 20 },
+		);
+		await act(async () => {
+			await renderOnce();
+		});
+		const frame = captureCharFrame();
+		await act(async () => renderer.destroy());
+		expect(frame).toContain("restart Claude Code");
+		expect(frame).toContain("after restarting Claude Code");
+	});
+
+	test("NEGATIVE CONTROL: a server not changed this session says nothing about a restart", async () => {
+		const item = {
+			kind: "server" as const,
+			server: server as never,
+			isInstalled: true,
+		};
+		const { captureCharFrame, renderOnce, renderer } = await testRender(
+			<box flexDirection="column">
+				{renderMcpRow(item, 0, false)}
+				{renderMcpDetail(item, false)}
+			</box>,
+			{ width: 80, height: 20 },
+		);
+		await act(async () => {
+			await renderOnce();
+		});
+		const frame = captureCharFrame();
+		await act(async () => renderer.destroy());
+		expect(frame).not.toContain("restart");
+	});
+
+	test("the startup fix's untracking failures carry git's reason", () => {
+		expect(
+			gitignoreStartupReport([
+				{
+					path: ".claude/settings.json",
+					reason:
+						"fatal: pathspec '.claude/settings.json' did not match any files",
+				},
+			]),
+		).toEqual({
+			headline: "1 generated file is still tracked by git",
+			rows: [
+				{
+					subject: ".claude/settings.json",
+					reason:
+						"fatal: pathspec '.claude/settings.json' did not match any files",
+				},
+			],
+			fix: null,
+		});
+		expect(gitignoreStartupReport([])).toBeNull();
+	});
+
+	test("a template's skipped rules are named, sharing one row", () => {
+		expect(gitignoreTemplateReport("node", ["dist/", "*.log"])).toEqual({
+			headline: '2 rules from "node" were not added',
+			rows: [
+				{
+					subject: "dist/, *.log",
+					reason: "skipped: conflicts with existing rules",
+				},
+			],
+			fix: null,
+		});
+		expect(gitignoreTemplateReport("node", [])).toBeNull();
+	});
+});
+
+// ── M10 ──────────────────────────────────────────────────────────────────────
+
+describe("M10: known failures carry their fix", () => {
+	test("claude not on PATH: the hint leaves the reason and becomes the fix", () => {
+		expect(
+			exceptionReason(
+				"claude CLI not found in PATH. Install with: npm install -g @anthropic-ai/claude-code",
+			),
+		).toEqual({
+			reason: "claude CLI not found in PATH",
+			fix: INSTALL_CLAUDE_FIX,
+			known: true,
+		});
+	});
+
+	test("a failure through the real engine produces a fix line", async () => {
+		const popup = failureReasons();
+		const result = await applyPlugins(
+			[updateItem("a@magus"), updateItem("b@magus")],
+			PROJECT,
+			deps(
+				{},
+				{
+					"a@magus": "connect ETIMEDOUT 140.82.112.3:443",
+					"b@magus": "connect ETIMEDOUT 140.82.112.3:443",
+				},
+			),
+			popup.reporter,
+		);
+		const report = popup.report(result.failed) as FailureReport;
+		expect(report.fix).toBe(RETRY_NETWORK_FIX);
+		expect(report.rows).toEqual([
+			{ subject: "a, b", reason: "connect ETIMEDOUT 140.82.112.3:443" },
+		]);
+	});
+
+	test("NEGATIVE CONTROL: an unrecognised exception has no fix", () => {
+		expect(exceptionReason("boom")).toEqual({ reason: "boom", known: false });
+	});
+});
+
+// ── L11 ──────────────────────────────────────────────────────────────────────
+
+describe("L11: no mechanism in the words", () => {
+	test("'Command failed: <path> …' is dropped; Claude Code's own output wins", () => {
+		const args = ["plugin", "install", "dev@magus", "--scope", "project"];
+		expect(
+			claudeFailureMessage(
+				{
+					message:
+						"Command failed: /Users/x/.local/bin/claude plugin install dev@magus --scope project\nPlugin not found",
+				},
+				args,
+				60000,
+			),
+		).toBe("Plugin not found");
+		expect(
+			claudeFailureMessage(
+				{ message: "Command failed: /x/claude plugin install", stderr: "boom" },
+				args,
+				60000,
+			),
+		).toBe("boom");
+		expect(
+			claudeFailureMessage(
+				{ message: "Command failed: /x/claude plugin install", killed: true },
+				args,
+				60000,
+			),
+		).toBe("claude plugin install did not finish within 60s");
+		expect(
+			claudeFailureMessage(
+				{ message: "Command failed: /x/claude plugin install" },
+				args,
+				60000,
+			),
+		).toBe("claude plugin install failed");
+	});
+
+	test("a version that did not download is not 'installed vX, but vX is not downloaded'", () => {
+		const text = describeLoadNotForward({
+			pluginId: "dev@magus",
+			target: "1.3.0",
+			rewritten: 0,
+			backup: null,
+			loaded: null,
+			ok: false,
+			error: notDownloadedReason("1.3.0"),
+		});
+		expect(text).toBe(
+			"installed v1.3.0, but it did not download — run magus install",
+		);
+		expect(
+			pluginFailureReport([
+				{ pluginId: "dev@magus", verb: "updated", detail: text },
+			]),
+		).toEqual({
+			headline: "dev was not updated",
+			rows: [
+				{ subject: "dev", reason: "installed v1.3.0, but it did not download" },
+			],
+			fix: "Run magus install",
+		});
+	});
+});
+
+// ── the popup's shape ─────────────────────────────────────────────────────────
+
+describe("the popup is not plugin-only, and fits the terminal", () => {
+	const many: FailureReport = {
+		headline: "30 things did not work",
+		rows: Array.from({ length: 30 }, (_, i) => ({
+			subject: `file-${i}.json`,
+			reason: "cannot be read",
+		})),
+		fix: null,
+	};
+
+	test("any subject, and a fix shared by every row is said once", () => {
+		expect(
+			failureReport("2 files were not written", [
+				{ subject: "a.json", reason: "locked — fix it by hand" },
+				{ subject: "b.json", reason: "read-only — fix it by hand" },
+			]),
+		).toEqual({
+			headline: "2 files were not written",
+			rows: [
+				{ subject: "a.json", reason: "locked" },
+				{ subject: "b.json", reason: "read-only" },
+			],
+			fix: "Fix it by hand",
+		});
+	});
+
+	test("capped to the terminal's height, ending with '+N more'", async () => {
+		const { rows, hidden } = visibleFailureRows(many, 80, 24);
+		expect(hidden).toBeGreaterThan(0);
+		expect(rows.length + hidden).toBe(30);
+
+		const { captureCharFrame, renderOnce, renderer } = await testRender(
+			<FailureListModal report={many} terminalWidth={80} terminalHeight={24} />,
+			{ width: 80, height: 24 },
+		);
+		await act(async () => {
+			await renderOnce();
+			await renderOnce();
+		});
+		const frame = captureCharFrame();
+		await act(async () => renderer.destroy());
+		expect(frame).toContain(`+${hidden} more`);
+		expect(frame).toContain("30 things did not work");
+		expect(frame).toContain("Press any key to continue");
+	});
+
+	test("NEGATIVE CONTROL: rows that fit are all drawn, with no '+N more'", () => {
+		expect(visibleFailureRows(many, 80, 60)).toEqual({
+			rows: many.rows,
+			hidden: 0,
+		});
+		expect(visibleFailureRows(many, 80)).toEqual({
+			rows: many.rows,
+			hidden: 0,
+		});
+	});
+
+	test("a row's own fix is drawn under its reason", async () => {
+		const { captureCharFrame, renderOnce, renderer } = await testRender(
+			<FailureListModal
+				report={{
+					headline: "2 plugins were not updated",
+					rows: [
+						{
+							subject: "dev",
+							reason: "v8.1.3 is not downloaded",
+							fix: "Run magus install",
+						},
+						{ subject: "go", reason: "the folder could not be written" },
+					],
+					fix: null,
+				}}
+				terminalWidth={80}
+				terminalHeight={24}
+			/>,
+			{ width: 80, height: 24 },
+		);
+		await act(async () => {
+			await renderOnce();
+			await renderOnce();
+		});
+		const lines = captureCharFrame().split("\n");
+		await act(async () => renderer.destroy());
+		const reasonAt = lines.findIndex((l) =>
+			l.includes("v8.1.3 is not downloaded"),
+		);
+		const fixAt = lines.findIndex((l) => l.includes("Run magus install"));
+		expect(reasonAt).toBeGreaterThanOrEqual(0);
+		expect(fixAt).toBe(reasonAt + 1);
+	});
+});