magus-cli 7.7.0 → 7.9.0

package/src/__tests__/shell-script-callers.test.ts

@@ -1,92 +0,0 @@
-/**
- * `runShellScript` has exactly one legitimate caller, and this pins it.
- *
- * The whole of item 3 is the split between two ways of running a child process:
- * argv (`runCommand`), which no shell ever sees, and a script (`runShellScript`),
- * which `/bin/sh` parses. Every installer command belongs to the first, because
- * it is assembled from package names that arrive in `.claude/profiles.json` and
- * plugin `requires.bin` — hand-authored, committed by teammates, fetched from
- * marketplaces, validated by nothing. The second exists only for the two
- * `TOOLCHAIN_BOOTSTRAP` values, which are constants in this repo copied from
- * bun.sh and brew.sh and which genuinely contain a pipe and a command
- * substitution.
- *
- * Nothing in the type system distinguishes them — both are strings — so after
- * the commit lands, the design decision is enforced by this test or by nothing.
- * A branded `ShellScript` type would enforce it at compile time and was
- * considered; for one map, two entries and one call site it is more machinery
- * than the rule is worth, and unlike a brand this is greppable.
- *
- * Source-scanning precedent in this suite: `uppercase-keybindings.test.ts`.
- */
-
-import { describe, expect, test } from "bun:test";
-import path from "node:path";
-import fs from "fs-extra";
-
-const SRC_DIR = path.join(import.meta.dir, "..");
-
-/** Files permitted to call `runShellScript`, relative to `src/`. */
-const ALLOWED = ["cli/install.ts"];
-
-/** The definition itself, plus this test, are not callers. */
-const NOT_CALLERS = ["utils/run.ts", "__tests__/shell-script-callers.test.ts"];
-
-async function sourceFiles(dir: string): Promise<string[]> {
-	const out: string[] = [];
-	for (const entry of await fs.readdir(dir, { withFileTypes: true })) {
-		const full = path.join(dir, entry.name);
-		if (entry.isDirectory()) out.push(...(await sourceFiles(full)));
-		else if (/\.tsx?$/.test(entry.name)) out.push(full);
-	}
-	return out;
-}
-
-const isComment = (line: string) => {
-	const t = line.trim();
-	return t.startsWith("//") || t.startsWith("*") || t.startsWith("/*");
-};
-
-async function callersOf(pattern: RegExp): Promise<string[]> {
-	const found = new Set<string>();
-	for (const file of await sourceFiles(SRC_DIR)) {
-		const rel = path.relative(SRC_DIR, file);
-		if (NOT_CALLERS.includes(rel)) continue;
-		const text = await fs.readFile(file, "utf8");
-		for (const line of text.split("\n")) {
-			if (isComment(line)) continue;
-			if (pattern.test(line)) found.add(rel);
-		}
-	}
-	return [...found].sort();
-}
-
-describe("only the toolchain bootstrap goes through a shell", () => {
-	test("runShellScript is called from exactly the allowed files", async () => {
-		expect(await callersOf(/\brunShellScript\(/)).toEqual(ALLOWED);
-	});
-
-	test("nothing spawns with a shell outside utils/run.ts", async () => {
-		// Catches someone reaching for `spawn`/`exec` directly rather than
-		// through the seam — a second shell path that never names
-		// `runShellScript`.
-		//
-		// Both spellings: `shell: true` and a named shell (`shell: "/bin/bash"`).
-		// The CLI Tools screen used the second for its version probe (`which -a`
-		// pipelines, a string-form `exec` of each check command); that probe now
-		// lives in services/tool-probe.ts and runs argv only. `shell: false` and
-		// the alias writer's `shell: ShellKind` values are not spawn options and
-		// do not match.
-		expect(await callersOf(/shell:\s*(true|["'`])/)).toEqual([]);
-	});
-
-	test("the scan can actually fail", async () => {
-		// Negative control. The two assertions above pass trivially if the walk
-		// finds nothing or the pattern never matches, and a check that cannot
-		// fail is not evidence. `runCommand(` is known to be called from several
-		// files, so a working scan must find them.
-		const runCommandCallers = await callersOf(/\brunCommand\(/);
-		expect(runCommandCallers.length).toBeGreaterThan(0);
-		expect(runCommandCallers).toContain("cli/install.ts");
-	});
-});

package/src/__tests__/styles-status-line.test.ts

@@ -1,72 +0,0 @@
-import { describe, expect, test } from "bun:test";
-import { appReducer, initialState } from "../ui/state/reducer.js";
-import type { AppAction, AppState } from "../ui/state/types.js";
-
-function run(actions: AppAction[], from: AppState = initialState): AppState {
-	return actions.reduce(appReducer, from);
-}
-
-/**
- * The status line lives in app state, not in the screen.
- *
- * Two bugs drove this, and both were invisible to every test we had:
- *
- *  1. It was cleared on a 5-second wall clock, so the message describing what
- *     you just did was usually gone before you looked at it — and unobservable
- *     to anything sampling the screen a moment later.
- *  2. It was component-local, and `Router` swaps the component type on a tab
- *     change, so `9 → 1 → 9` destroyed it.
- */
-describe("status line state", () => {
-	test("survives leaving the tab and coming back", () => {
-		const shown = run([
-			{
-				type: "STYLES_STATUS_SET",
-				status: { text: "Selection reset to the live style", tone: "success" },
-			},
-		]);
-		expect(shown.styles.status?.text).toBe("Selection reset to the live style");
-
-		// Navigating away and back is what unmounts the screen.
-		const roundTrip = run(
-			[
-				{ type: "NAVIGATE", route: { screen: "plugins" } },
-				{ type: "NAVIGATE", route: { screen: "styles" } },
-			],
-			shown,
-		);
-		expect(roundTrip.styles.status?.text).toBe(
-			"Selection reset to the live style",
-		);
-	});
-
-	test("a new message replaces the previous one", () => {
-		const state = run([
-			{ type: "STYLES_STATUS_SET", status: { text: "first", tone: "success" } },
-			{ type: "STYLES_STATUS_SET", status: { text: "second", tone: "error" } },
-		]);
-		expect(state.styles.status).toEqual({ text: "second", tone: "error" });
-	});
-
-	test("clearing returns the line to its default", () => {
-		const state = run([
-			{ type: "STYLES_STATUS_SET", status: { text: "done", tone: "success" } },
-			{ type: "STYLES_STATUS_CLEAR" },
-		]);
-		expect(state.styles.status).toBeNull();
-	});
-
-	test("starts empty", () => {
-		expect(initialState.styles.status).toBeNull();
-	});
-
-	test("keeps the tone, so an error cannot render as a success", () => {
-		const state = run([
-			{
-				type: "STYLES_STATUS_SET",
-				status: { text: "Already talking to GitHub", tone: "error" },
-			},
-		]);
-		expect(state.styles.status?.tone).toBe("error");
-	});
-});

package/src/__tests__/version-snapshot.test.ts

@@ -1,212 +0,0 @@
-import { describe, expect, test } from "bun:test";
-import { promises as fs } from "node:fs";
-import os from "node:os";
-import path from "node:path";
-import {
-	UNKNOWN_VERSION,
-	diffVersions,
-	isKnownVersion,
-	loadSeenVersions,
-	saveSeenVersions,
-} from "../services/version-snapshot.js";
-
-/**
- * Plugins get updated by things magus does not control — Claude Code's own
- * `plugin update` writes installed_plugins.json without touching magus's
- * bookkeeping. Diffing what we last rendered against reality catches every
- * source; logging only magus's own actions catches none of them.
- */
-
-describe("isKnownVersion", () => {
-	test('"0.0.0" is not a usable version', () => {
-		// Claude Code records this for a plugin whose version it cannot determine.
-		expect(isKnownVersion(UNKNOWN_VERSION)).toBe(false);
-		expect(isKnownVersion(undefined)).toBe(false);
-		expect(isKnownVersion("")).toBe(false);
-		expect(isKnownVersion("1.0.0")).toBe(true);
-	});
-});
-
-describe("diffVersions — first run", () => {
-	test("no baseline reports nothing at all", () => {
-		// Without this, the first launch would flag every installed plugin as new,
-		// which is both wrong and the fastest way to train someone to ignore badges.
-		expect(
-			diffVersions(null, { "dev@magus": "2.12.1", "a@mp": UNKNOWN_VERSION }),
-		).toEqual([]);
-	});
-
-	test("an empty baseline is NOT the same as no baseline", () => {
-		// A real snapshot that happens to be empty means we have looked before and
-		// saw nothing, so anything present now is genuinely new.
-		const changes = diffVersions({}, { "dev@magus": "2.12.1" });
-		expect(changes).toEqual([
-			{ pluginId: "dev@magus", kind: "installed", to: "2.12.1" },
-		]);
-	});
-});
-
-describe("diffVersions — installs", () => {
-	test("a plugin absent from the baseline is reported as installed, not updated", () => {
-		const changes = diffVersions(
-			{ "other@mp": "1.0.0" },
-			{ "new@mp": "3.1.0" },
-		);
-		expect(changes).toEqual([
-			{ pluginId: "new@mp", kind: "installed", to: "3.1.0" },
-		]);
-	});
-
-	test("an install with an unknown version is still reported", () => {
-		// The version is unusable but the install is real — the UI shows "new"
-		// with no version rather than suppressing the plugin entirely.
-		const changes = diffVersions({}, { "a@mp": UNKNOWN_VERSION });
-		expect(changes).toEqual([
-			{ pluginId: "a@mp", kind: "installed", to: UNKNOWN_VERSION },
-		]);
-	});
-});
-
-describe("diffVersions — updates", () => {
-	test("reports a genuine version transition", () => {
-		expect(
-			diffVersions({ "dev@magus": "2.12.0" }, { "dev@magus": "2.12.1" }),
-		).toEqual([
-			{ pluginId: "dev@magus", kind: "updated", from: "2.12.0", to: "2.12.1" },
-		]);
-	});
-
-	test("unchanged versions report nothing", () => {
-		expect(
-			diffVersions({ "dev@magus": "2.12.1" }, { "dev@magus": "2.12.1" }),
-		).toEqual([]);
-	});
-
-	test("learning a previously unknown version is not an update", () => {
-		// This is exactly what v4.22.0's registry overlay caused: versions that
-		// could not be resolved suddenly could be. Reporting it would announce
-		// magus's own bugfix as if the user's plugins had changed.
-		expect(
-			diffVersions({ "a@mp": UNKNOWN_VERSION }, { "a@mp": "5.3.0" }),
-		).toEqual([]);
-	});
-
-	test("losing a known version is not an update either", () => {
-		expect(
-			diffVersions({ "a@mp": "5.3.0" }, { "a@mp": UNKNOWN_VERSION }),
-		).toEqual([]);
-	});
-
-	test("a downgrade IS reported", () => {
-		// Rolling back is a real change, arguably the most important to surface.
-		expect(diffVersions({ "a@mp": "2.0.0" }, { "a@mp": "1.0.0" })).toEqual([
-			{ pluginId: "a@mp", kind: "updated", from: "2.0.0", to: "1.0.0" },
-		]);
-	});
-});
-
-describe("diffVersions — removals and mixed sets", () => {
-	test("a removed plugin is not reported", () => {
-		expect(diffVersions({ "gone@mp": "1.0.0" }, {})).toEqual([]);
-	});
-
-	test("classifies each plugin independently in one pass", () => {
-		const changes = diffVersions(
-			{ same: "1.0.0", moved: "2.0.0", learned: UNKNOWN_VERSION },
-			{ same: "1.0.0", moved: "2.1.0", learned: "9.0.0", fresh: "0.1.0" },
-		);
-		expect(changes).toEqual([
-			{ pluginId: "moved", kind: "updated", from: "2.0.0", to: "2.1.0" },
-			{ pluginId: "fresh", kind: "installed", to: "0.1.0" },
-		]);
-	});
-});
-
-describe("per-project baselines", () => {
-	/**
-	 * The baseline used to be one flat map for the whole machine, but the
-	 * versions written into it are resolved per project. Two projects
-	 * legitimately on different versions overwrote each other's baseline, so
-	 * every differing plugin was reported as "updated" on the next render — a
-	 * change that never happened.
-	 *
-	 * CLAUDE_CONFIG_DIR, not HOME: os.homedir() reads the passwd database on
-	 * macOS and ignores $HOME, so a HOME-only override writes to the operator's
-	 * real ~/.claude. That is not hypothetical — it happened while writing these.
-	 */
-	const withSandbox = async (fn: () => Promise<void>): Promise<void> => {
-		const dir = await fs.mkdtemp(path.join(os.tmpdir(), "vsnap-"));
-		const prev = process.env.CLAUDE_CONFIG_DIR;
-		process.env.CLAUDE_CONFIG_DIR = dir;
-		try {
-			await fn();
-		} finally {
-			// biome-ignore lint/performance/noDelete: assigning undefined to process.env stores the string "undefined"; only delete unsets the variable
-			if (prev === undefined) delete process.env.CLAUDE_CONFIG_DIR;
-			else process.env.CLAUDE_CONFIG_DIR = prev;
-			await fs.rm(dir, { recursive: true, force: true });
-		}
-	};
-
-	test("a project with no baseline of its own reports nothing", async () => {
-		await withSandbox(async () => {
-			await saveSeenVersions("/proj/a", { "setup@magus": "2.2.0" });
-			const baseline = await loadSeenVersions("/proj/b");
-			expect(baseline).toBeNull();
-			expect(diffVersions(baseline, { "setup@magus": "2.5.0" })).toEqual([]);
-		});
-	});
-
-	test("saving one project preserves the others", async () => {
-		await withSandbox(async () => {
-			await saveSeenVersions("/proj/a", { "designer@magus": "2.0.0" });
-			await saveSeenVersions("/proj/b", { "designer@magus": "2.0.1" });
-			expect(await loadSeenVersions("/proj/a")).toEqual({
-				"designer@magus": "2.0.0",
-			});
-			expect(await loadSeenVersions("/proj/b")).toEqual({
-				"designer@magus": "2.0.1",
-			});
-		});
-	});
-
-	test("a real update inside one project is still reported", async () => {
-		await withSandbox(async () => {
-			await saveSeenVersions("/proj/a", { "dev@magus": "3.0.0" });
-			const previous = await loadSeenVersions("/proj/a");
-			expect(diffVersions(previous, { "dev@magus": "3.0.1" })).toEqual([
-				{ pluginId: "dev@magus", kind: "updated", from: "3.0.0", to: "3.0.1" },
-			]);
-		});
-	});
-
-	test("a pre-migration flat baseline is adopted once, then replaced", async () => {
-		await withSandbox(async () => {
-			const file = path.join(
-				process.env.CLAUDE_CONFIG_DIR as string,
-				"magus-version-snapshot.json",
-			);
-			await fs.writeFile(
-				file,
-				JSON.stringify({
-					seen: { "dev@magus": "3.0.0" },
-					seededAt: "2026-07-29T00:00:00.000Z",
-					updatedAt: "2026-07-29T00:00:00.000Z",
-				}),
-			);
-
-			// Legacy shape carries no project, so it stands in for whoever asks first
-			// rather than being thrown away.
-			expect(await loadSeenVersions("/proj/a")).toEqual({
-				"dev@magus": "3.0.0",
-			});
-
-			await saveSeenVersions("/proj/a", { "dev@magus": "3.0.1" });
-			// Once per-project entries exist, the flat map is no longer consulted.
-			expect(await loadSeenVersions("/proj/b")).toBeNull();
-			expect(await loadSeenVersions("/proj/a")).toEqual({
-				"dev@magus": "3.0.1",
-			});
-		});
-	});
-});