magus-cli 7.7.0 → 7.9.0

package/src/__tests__/profile-startup.test.ts

@@ -137,7 +137,7 @@ describe("detectProfileStartupNeed", () => {
 		expect(describeNeed(need).message).toContain('"gone"');
 	});
 
-	test("the TUI startup runs the gate first and reports what it absorbed", async () => {
+	test("the TUI startup runs the gate first, absorbing edits into the profile", async () => {
 		await fs.outputJson(join(project, ".claude", "profiles.json"), LEAN);
 		await activateProfile(LEAN, "lean", project, { onDisplace: () => {} });
 		const live = join(project, ".claude", "settings.json");
@@ -145,10 +145,13 @@ describe("detectProfileStartupNeed", () => {
 		settings.enabledPlugins["code-search@magus"] = true;
 		await fs.writeFile(live, JSON.stringify(settings));
 
-		const { need, notices } = await prepareProfileStartup(project);
+		const { need } = await prepareProfileStartup(project);
 
 		expect(need.state).toBe("ok");
-		expect(notices).toEqual(['Added code-search@magus to profile "lean"']);
+		const manifest = await fs.readJson(
+			join(project, ".claude", "profiles.json"),
+		);
+		expect(manifest.profiles.lean.plugins["code-search@magus"]).toBeTruthy();
 	});
 
 	test("what is enabled never changes the answer", async () => {
@@ -403,46 +406,71 @@ describe("a failure that already moved something", () => {
 		link: `/p/.claude/${name}`,
 		savedTo: `/p/.claude/.magus-backups/S/${name}`,
 	});
+	const lean = { kind: "activate" as const, id: "lean" };
+	/** Everything the failure popup says, as one string. */
+	const said = (report: ReturnType<typeof describeFailure>): string =>
+		[
+			report.headline,
+			...report.rows.map((r) => `${r.subject} ${r.reason} ${r.fix ?? ""}`),
+			report.fix ?? "",
+		].join("\n");
 
 	test("a true no-op says so", () => {
-		const msg = describeFailure(new Error("boom"), [], "/p", null);
+		const report = describeFailure(new Error("boom"), [], "/p", null, lean);
+		expect(report.headline).toBe('Profile "lean" was not activated');
+		const msg = said(report);
 		expect(msg).toContain("boom");
 		expect(msg).toContain("exactly as it was");
 	});
 
+	test("an adoption that failed says the profile was not created", () => {
+		const report = describeFailure(new Error("boom"), [], "/p", null, {
+			kind: "adopt",
+			id: "default",
+			name: "Mine",
+		});
+		expect(report.headline).toBe('Profile "Mine" was not created');
+	});
+
 	test("a partial failure never claims nothing happened", () => {
 		// Activation moves up to four artifacts in sequence and settings.json goes
 		// FIRST, so a throw on the second leaves it already in the backup. The old
 		// message said "Nothing was activated" unconditionally — false about the
 		// user's own file, and `.magus-backups/` is gitignored, so git status
 		// showed the deletion with no sign of the copy.
-		const msg = describeFailure(
+		const report = describeFailure(
 			new Error("EACCES: skills"),
 			[at("settings.json")],
 			"/p",
 			"lean",
+			lean,
 		);
+		const msg = said(report);
 
-		expect(msg).not.toContain("Nothing was moved");
+		expect(msg.toLowerCase()).not.toContain("nothing was moved");
 		expect(msg).not.toContain("exactly as it was");
-		// It must name where the file went, project-relative.
-		expect(msg).toContain(".claude/settings.json");
-		expect(msg).toContain(".claude/.magus-backups/S/settings.json");
+		// It must name where the file went, project-relative: one row per file.
+		expect(report.rows).toContainEqual({
+			subject: ".claude/settings.json",
+			reason: "is kept at .claude/.magus-backups/S/settings.json",
+		});
 	});
 
 	test("it warns against the re-attempt that would capture an empty set", () => {
 		// Re-choosing save-what-you-have runs adoption again, and adoption reads
 		// settings.json — now in the backup. It would capture an empty plugin set
 		// into a second profile and call that the user's setup.
-		const msg = describeFailure(
+		const report = describeFailure(
 			new Error("boom"),
 			[at("settings.json")],
 			"/p",
 			"lean",
+			lean,
 		);
 
-		expect(msg).toContain("Do NOT save-what-you-have");
-		expect(msg).toContain("Activating lean again is safe");
+		// The fix line, said once under the rows.
+		expect(report.fix).toContain("Do NOT save-what-you-have");
+		expect(report.fix).toContain("Activating lean again is safe");
 	});
 });