magus-cli 7.7.0 → 7.9.0

package/src/__tests__/doctor.test.ts

@@ -15,7 +15,13 @@ import { existsSync } from "node:fs";
 import { mkdir, mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
-import { doctorExitCode } from "../cli/doctor.js";
+import {
+	doctorExitCode,
+	enabledHere,
+	findPluginLoadProblems,
+	isClaimedHere,
+	pluginLoadLines,
+} from "../cli/doctor.js";
 import { checkProject, fixDoctorIssues } from "../services/doctor.js";
 import type { DoctorResult } from "../services/doctor.js";
 
@@ -492,3 +498,155 @@ describe("doctorExitCode", () => {
 		expect(doctorExitCode({ fixable: 2, unfixable: 1, fix: true })).toBe(1);
 	});
 });
+
+/**
+ * M7: a plugin recorded as installed here that Claude Code loads NO version of
+ * in this folder. It was skipped by the stale-load comparison and then counted
+ * among the plugins that "load at their installed version".
+ */
+describe("doctor plugin loads: a plugin that loads nothing", () => {
+	const HERE = "/nonexistent/magus-doctor-m7/project";
+	const row = (projectPath: string, version: string) => ({
+		scope: "project" as const,
+		projectPath,
+		version,
+		installPath: `/nonexistent/cache/${version}`,
+		installedAt: "2026-01-01T00:00:00.000Z",
+		lastUpdated: "2026-01-01T00:00:00.000Z",
+	});
+
+	it("is its own finding, with magus update as the fix, and never counted as healthy", () => {
+		const findings = findPluginLoadProblems(
+			{ "dev@magus": "8.0.0", "kanban@magus": "1.6.2" },
+			{
+				"dev@magus": [row(HERE, "8.0.0")],
+				// Its only row belongs to another folder, so nothing loads here —
+				// and this folder turns it on, so it IS claimed here.
+				"kanban@magus": [row("/nonexistent/magus-doctor-m7/other", "1.6.2")],
+			},
+			HERE,
+			{ "kanban@magus": true },
+		);
+		expect(findings).toEqual({ stale: [], loadsNothing: ["kanban@magus"] });
+		const lines = pluginLoadLines(findings, 2);
+		expect(lines).toContain(
+			"  ✗ kanban@magus is installed, but Claude Code loads no version of it in this folder",
+		);
+		expect(lines).toContain("    Run `magus update` to fix it.");
+		expect(lines.some((l) => l.includes("All 2 installed plugins load"))).toBe(
+			false,
+		);
+	});
+
+	it("NEGATIVE CONTROL: when every plugin loads its version, all are healthy", () => {
+		const findings = findPluginLoadProblems(
+			{ "dev@magus": "8.0.0" },
+			{ "dev@magus": [row(HERE, "8.0.0")] },
+			HERE,
+		);
+		expect(findings).toEqual({ stale: [], loadsNothing: [] });
+		expect(pluginLoadLines(findings, 1)).toContain(
+			"  ✓ All 1 installed plugins load at their installed version.",
+		);
+	});
+});
+
+/**
+ * M1: "claimed here" means claimed by something that APPLIES to this folder —
+ * a scope that turns it on here, or a registry row the loader would consider
+ * here. A row for an unrelated repository is neither, so a stale
+ * `installedPluginVersions` entry plus such a row is not "loads nothing".
+ *
+ * Real (temp) repositories, because relevance is decided by repository root and
+ * a path in no repository would make every foreign row irrelevant trivially.
+ */
+describe("doctor plugin loads: claimed here, not anywhere", () => {
+	let base: string;
+	let here: string;
+	let sibling: string;
+	let unrelated: string;
+	const row = (
+		projectPath: string | undefined,
+		version: string,
+		scope: "project" | "local" | "user" = "project",
+	) => ({
+		scope,
+		...(projectPath ? { projectPath } : {}),
+		version,
+		installPath: `/nonexistent/cache/${version || "none"}`,
+		installedAt: "2026-01-01T00:00:00.000Z",
+		lastUpdated: "2026-01-01T00:00:00.000Z",
+	});
+
+	beforeEach(async () => {
+		base = await mkdtemp(join(tmpdir(), "magus-doctor-m1-"));
+		here = join(base, "repo-a");
+		sibling = join(here, "packages", "other");
+		unrelated = join(base, "repo-b");
+		await mkdir(join(here, ".git"), { recursive: true });
+		await mkdir(sibling, { recursive: true });
+		await mkdir(join(unrelated, ".git"), { recursive: true });
+	});
+
+	afterEach(async () => {
+		await rm(base, { recursive: true, force: true });
+	});
+
+	it("rows only for an unrelated repo plus a stale installedPluginVersions claim is NOT a finding", () => {
+		const findings = findPluginLoadProblems(
+			{ "kanban@magus": "1.6.2" },
+			{ "kanban@magus": [row(unrelated, "1.6.2"), row(unrelated, "1.5.0")] },
+			here,
+			{},
+		);
+		expect(findings).toEqual({ stale: [], loadsNothing: [] });
+		expect(
+			isClaimedHere("kanban@magus", [row(unrelated, "1.6.2")], here, {}),
+		).toBe(false);
+	});
+
+	it("CONTROL: the same rows with the plugin turned on here IS a finding", () => {
+		const findings = findPluginLoadProblems(
+			{ "kanban@magus": "1.6.2" },
+			{ "kanban@magus": [row(unrelated, "1.6.2")] },
+			here,
+			{ "kanban@magus": true },
+		);
+		expect(findings.loadsNothing).toEqual(["kanban@magus"]);
+	});
+
+	it("CONTROL: a relevant row that resolves no version IS a finding", () => {
+		// Same repository, other folder — the loader considers it here.
+		expect(
+			findPluginLoadProblems(
+				{ "kanban@magus": "1.6.2" },
+				{ "kanban@magus": [row(sibling, "")] },
+				here,
+				{},
+			).loadsNothing,
+		).toEqual(["kanban@magus"]);
+		// A machine-wide row applies to every folder.
+		expect(
+			findPluginLoadProblems(
+				{ "kanban@magus": "1.6.2" },
+				{ "kanban@magus": [row(undefined, "", "user")] },
+				here,
+				{},
+			).loadsNothing,
+		).toEqual(["kanban@magus"]);
+	});
+
+	it("enabledHere applies user, then project, then local — a later scope wins", () => {
+		const enabled = enabledHere(
+			{ enabledPlugins: { "a@magus": true, "b@magus": true } },
+			{ enabledPlugins: { "b@magus": false, "c@magus": true } },
+			{ enabledPlugins: { "c@magus": false } },
+		);
+		expect(enabled).toEqual({
+			"a@magus": true,
+			"b@magus": false,
+			"c@magus": false,
+		});
+		expect(enabledHere({}, {}, {})).toEqual({});
+	});
+});