lighthouse 8.6.0 → 9.0.0

package/shared/localization/locales/zh.json

@@ -3,7 +3,7 @@
     "message": "所有报告"
   },
   "flow-report/src/i18n/ui-strings.js | categories": {
-    "message": "Categories"
+    "message": "类别"
   },
   "flow-report/src/i18n/ui-strings.js | categoryAccessibility": {
     "message": "无障碍"
@@ -24,40 +24,46 @@
     "message": "桌面版"
   },
   "flow-report/src/i18n/ui-strings.js | helpDialogTitle": {
-    "message": "Understanding the Lighthouse Flow Report"
+    "message": "了解 Lighthouse 流程报告"
   },
   "flow-report/src/i18n/ui-strings.js | helpLabel": {
-    "message": "Understanding Flows"
+    "message": "了解流程"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseInstructionNavigation": {
-    "message": "Use Navigation reports to..."
+    "message": "使用导航报告可以…"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseInstructionSnapshot": {
-    "message": "Use Snapshot reports to..."
+    "message": "使用快照报告可以…"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseInstructionTimespan": {
-    "message": "Use Timespan reports to..."
+    "message": "使用时间跨度报告可以…"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseNavigation1": {
-    "message": "Obtain a Lighthouse Performance score."
+    "message": "获取 Lighthouse 给出的性能得分。"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseNavigation2": {
-    "message": "Measure page load Performance metrics such as Largest Contentful Paint and Speed Index."
+    "message": "衡量网页加载性能指标，例如 Largest Contentful Paint 和 Speed Index。"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseNavigation3": {
-    "message": "Assess Progressive Web App capabilities."
+    "message": "评估渐进式 Web 应用的功能。"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseSnapshot1": {
-    "message": "Find accessibility issues in single page applications or complex forms."
+    "message": "查找单页应用或复杂表单中的无障碍功能方面的问题。"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseSnapshot2": {
-    "message": "Evaluate best practices of menus and UI elements hidden behind interaction."
+    "message": "评估互动背后隐藏的菜单和界面元素的最佳做法。"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseTimespan1": {
-    "message": "Measure layout shifts and JavaScript execution time on a series of interactions."
+    "message": "衡量一系列互动的布局偏移和 JavaScript 执行用时。"
   },
   "flow-report/src/i18n/ui-strings.js | helpUseCaseTimespan2": {
-    "message": "Discover performance opportunities to improve the experience for long-lived pages and single-page applications."
+    "message": "发掘性能提升机会，以便改进长期网页和单页应用的用户体验。"
+  },
+  "flow-report/src/i18n/ui-strings.js | highestImpact": {
+    "message": "影响力最大"
+  },
+  "flow-report/src/i18n/ui-strings.js | informativeAuditCount": {
+    "message": "{numInformative,plural, =1{{numInformative} 项参考性评估}other{{numInformative} 项参考性评估}}"
   },
   "flow-report/src/i18n/ui-strings.js | mobile": {
     "message": "移动版"
@@ -66,11 +72,20 @@
     "message": "网页加载"
   },
   "flow-report/src/i18n/ui-strings.js | navigationLongDescription": {
-    "message": "Navigation reports analyze a single page load, exactly like the original Lighthouse reports."
+    "message": "导航报告旨在分析单个网页的加载情况，与最初的 Lighthouse 报告完全一样。"
   },
   "flow-report/src/i18n/ui-strings.js | navigationReport": {
     "message": "导航报告"
   },
+  "flow-report/src/i18n/ui-strings.js | navigationReportCount": {
+    "message": "{numNavigation,plural, =1{{numNavigation} 份导航报告}other{{numNavigation} 份导航报告}}"
+  },
+  "flow-report/src/i18n/ui-strings.js | passableAuditCount": {
+    "message": "{numPassableAudits,plural, =1{{numPassableAudits} 项有望通过的评估}other{{numPassableAudits} 项有望通过的评估}}"
+  },
+  "flow-report/src/i18n/ui-strings.js | passedAuditCount": {
+    "message": "{numPassed,plural, =1{通过了 {numPassed} 项评估}other{通过了 {numPassed} 项评估}}"
+  },
   "flow-report/src/i18n/ui-strings.js | ratingAverage": {
     "message": "一般"
   },
@@ -84,17 +99,20 @@
     "message": "良好"
   },
   "flow-report/src/i18n/ui-strings.js | save": {
-    "message": "Save"
+    "message": "保存"
   },
   "flow-report/src/i18n/ui-strings.js | snapshotDescription": {
     "message": "捕获到的网页状态"
   },
   "flow-report/src/i18n/ui-strings.js | snapshotLongDescription": {
-    "message": "Snapshot reports analyze the page in a particular state, typically after user interactions."
+    "message": "快照报告旨在分析处于特定状态的网页（通常是在用户互动之后）。"
   },
   "flow-report/src/i18n/ui-strings.js | snapshotReport": {
     "message": "快照报告"
   },
+  "flow-report/src/i18n/ui-strings.js | snapshotReportCount": {
+    "message": "{numSnapshot,plural, =1{{numSnapshot} 份快照报告}other{{numSnapshot} 份快照报告}}"
+  },
   "flow-report/src/i18n/ui-strings.js | summary": {
     "message": "摘要"
   },
@@ -102,11 +120,14 @@
     "message": "用户互动"
   },
   "flow-report/src/i18n/ui-strings.js | timespanLongDescription": {
-    "message": "Timespan reports analyze an arbitrary period of time, typically containing user interactions."
+    "message": "时间跨度报告旨在分析任意时间段（通常包含用户互动）。"
   },
   "flow-report/src/i18n/ui-strings.js | timespanReport": {
     "message": "时间跨度报告"
   },
+  "flow-report/src/i18n/ui-strings.js | timespanReportCount": {
+    "message": "{numTimespan,plural, =1{{numTimespan} 份时间跨度报告}other{{numTimespan} 份时间跨度报告}}"
+  },
   "flow-report/src/i18n/ui-strings.js | title": {
     "message": "Lighthouse 用户流报告"
   },
@@ -743,18 +764,6 @@
   "lighthouse-core/audits/deprecations.js | title": {
     "message": "请勿使用已弃用的 API"
   },
-  "lighthouse-core/audits/dobetterweb/appcache-manifest.js | description": {
-    "message": "应用缓存已被弃用。[了解详情](https://web.dev/appcache-manifest/)。"
-  },
-  "lighthouse-core/audits/dobetterweb/appcache-manifest.js | displayValue": {
-    "message": "发现了“{AppCacheManifest}”"
-  },
-  "lighthouse-core/audits/dobetterweb/appcache-manifest.js | failureTitle": {
-    "message": "使用了应用缓存"
-  },
-  "lighthouse-core/audits/dobetterweb/appcache-manifest.js | title": {
-    "message": "请勿使用应用缓存"
-  },
   "lighthouse-core/audits/dobetterweb/charset.js | description": {
     "message": "必须声明字符编码。您可以在 HTML 的前 1024 个字节中使用 `<meta>` 标记来声明，也可以在 HTTP 响应标头 Content-Type 中进行声明。[了解详情](https://web.dev/charset/)。"
   },
@@ -812,21 +821,6 @@
   "lighthouse-core/audits/dobetterweb/dom-size.js | title": {
     "message": "避免 DOM 规模过大"
   },
-  "lighthouse-core/audits/dobetterweb/external-anchors-use-rel-noopener.js | columnFailingAnchors": {
-    "message": "未通过审核的锚点"
-  },
-  "lighthouse-core/audits/dobetterweb/external-anchors-use-rel-noopener.js | description": {
-    "message": "向任何外部链接添加 `rel=\"noopener\"` 或 `rel=\"noreferrer\"`，可提高性能并减少安全漏洞。[了解详情](https://web.dev/external-anchors-use-rel-noopener/)。"
-  },
-  "lighthouse-core/audits/dobetterweb/external-anchors-use-rel-noopener.js | failureTitle": {
-    "message": "指向跨域目的地的链接不安全"
-  },
-  "lighthouse-core/audits/dobetterweb/external-anchors-use-rel-noopener.js | title": {
-    "message": "指向跨域目的地的链接安全"
-  },
-  "lighthouse-core/audits/dobetterweb/external-anchors-use-rel-noopener.js | warning": {
-    "message": "无法确定锚点 ({anchorHTML}) 的目的地。如果不用作超链接，建议移除 target=_blank。"
-  },
   "lighthouse-core/audits/dobetterweb/geolocation-on-start.js | description": {
     "message": "如果网站在缺少上下文的情况下请求位置，会导致用户不信任网站或感到困惑。建议将请求与用户操作进行绑定。[了解详情](https://web.dev/geolocation-on-start/)。"
   },
@@ -1277,15 +1271,6 @@
   "lighthouse-core/audits/preload-lcp-image.js | title": {
     "message": "预加载 LCP 元素所用图片"
   },
-  "lighthouse-core/audits/redirects-http.js | description": {
-    "message": "如果您已设置 HTTPS，请确保将所有 HTTP 流量重定向到 HTTPS，以便让所有用户都能使用安全的网络功能。[了解详情](https://web.dev/redirects-http/)。"
-  },
-  "lighthouse-core/audits/redirects-http.js | failureTitle": {
-    "message": "未将 HTTP 流量重定向到 HTTPS"
-  },
-  "lighthouse-core/audits/redirects-http.js | title": {
-    "message": "将 HTTP 流量重定向到 HTTPS"
-  },
   "lighthouse-core/audits/redirects.js | description": {
     "message": "重定向会在网页可加载前引入更多延迟。[了解详情](https://web.dev/redirects/)。"
   },
@@ -1776,7 +1761,7 @@
     "message": "基准 [PWA 核对清单](https://developers.google.com/web/progressive-web-apps/checklist)要求必须进行此类检查，但 Lighthouse 不会自动进行此类检查。它们不会影响您的得分，但您必须手动对其进行验证。"
   },
   "lighthouse-core/config/default-config.js | pwaCategoryTitle": {
-    "message": "渐进式 Web 应用"
+    "message": "PWA"
   },
   "lighthouse-core/config/default-config.js | pwaInstallableGroupTitle": {
     "message": "可安装"
@@ -2078,30 +2063,6 @@
   "lighthouse-core/lib/lh-error.js | urlInvalid": {
     "message": "您提供的网址似乎无效。"
   },
-  "lighthouse-treemap/app/src/util.js | allLabel": {
-    "message": "全部"
-  },
-  "lighthouse-treemap/app/src/util.js | allScriptsDropdownLabel": {
-    "message": "所有脚本"
-  },
-  "lighthouse-treemap/app/src/util.js | coverageColumnName": {
-    "message": "覆盖率"
-  },
-  "lighthouse-treemap/app/src/util.js | duplicateModulesLabel": {
-    "message": "重复的模块"
-  },
-  "lighthouse-treemap/app/src/util.js | resourceBytesLabel": {
-    "message": "资源字节数"
-  },
-  "lighthouse-treemap/app/src/util.js | tableColumnName": {
-    "message": "名称"
-  },
-  "lighthouse-treemap/app/src/util.js | toggleTableButtonLabel": {
-    "message": "显示/隐藏表格"
-  },
-  "lighthouse-treemap/app/src/util.js | unusedBytesLabel": {
-    "message": "未使用的字节数"
-  },
   "node_modules/lighthouse-stack-packs/packs/amp.js | efficient-animated-content": {
     "message": "对于动画内容，请使用 [`amp-anim`](https://amp.dev/documentation/components/amp-anim/) 尽量减少当内容在屏幕外时的 CPU 使用量。"
   },
@@ -2369,6 +2330,9 @@
   "report/renderer/util.js | calculatorLink": {
     "message": "查看计算器。"
   },
+  "report/renderer/util.js | collapseView": {
+    "message": "收起视图"
+  },
   "report/renderer/util.js | crcInitialNavigation": {
     "message": "初始导航"
   },
@@ -2405,9 +2369,15 @@
   "report/renderer/util.js | errorMissingAuditInfo": {
     "message": "报告错误：没有任何审核信息"
   },
+  "report/renderer/util.js | expandView": {
+    "message": "展开视图"
+  },
   "report/renderer/util.js | footerIssue": {
     "message": "提交问题"
   },
+  "report/renderer/util.js | hide": {
+    "message": "隐藏"
+  },
   "report/renderer/util.js | labDataTitle": {
     "message": "实验室数据"
   },
@@ -2429,6 +2399,12 @@
   "report/renderer/util.js | passedAuditsGroupTitle": {
     "message": "已通过的审核"
   },
+  "report/renderer/util.js | runtimeAnalysisWindow": {
+    "message": "初始网页加载"
+  },
+  "report/renderer/util.js | runtimeCustom": {
+    "message": "自定义节流"
+  },
   "report/renderer/util.js | runtimeDesktopEmulation": {
     "message": "模拟桌面设备"
   },
@@ -2447,33 +2423,30 @@
   "report/renderer/util.js | runtimeSettingsCPUThrottling": {
     "message": "CPU 节流"
   },
-  "report/renderer/util.js | runtimeSettingsChannel": {
-    "message": "所用工具"
-  },
   "report/renderer/util.js | runtimeSettingsDevice": {
     "message": "设备"
   },
-  "report/renderer/util.js | runtimeSettingsFetchTime": {
-    "message": "提取时间"
-  },
   "report/renderer/util.js | runtimeSettingsNetworkThrottling": {
     "message": "网络节流"
   },
-  "report/renderer/util.js | runtimeSettingsTitle": {
-    "message": "运行时设置"
-  },
-  "report/renderer/util.js | runtimeSettingsUA": {
-    "message": "用户代理（主机）"
-  },
   "report/renderer/util.js | runtimeSettingsUANetwork": {
     "message": "用户代理（网络）"
   },
-  "report/renderer/util.js | runtimeSettingsUrl": {
-    "message": "网址"
+  "report/renderer/util.js | runtimeSingleLoad": {
+    "message": "单次网页加载"
+  },
+  "report/renderer/util.js | runtimeSingleLoadTooltip": {
+    "message": "此数据是取自单次网页加载，现场数据则是汇总了许多次网页加载。"
+  },
+  "report/renderer/util.js | runtimeSlow4g": {
+    "message": "低速 4G 节流"
   },
   "report/renderer/util.js | runtimeUnknown": {
     "message": "不明"
   },
+  "report/renderer/util.js | show": {
+    "message": "显示"
+  },
   "report/renderer/util.js | showRelevantAudits": {
     "message": "显示与所选指标相关的评估结果："
   },
@@ -2503,5 +2476,29 @@
   },
   "report/renderer/util.js | warningHeader": {
     "message": "警告： "
+  },
+  "treemap/app/src/util.js | allLabel": {
+    "message": "全部"
+  },
+  "treemap/app/src/util.js | allScriptsDropdownLabel": {
+    "message": "所有脚本"
+  },
+  "treemap/app/src/util.js | coverageColumnName": {
+    "message": "覆盖率"
+  },
+  "treemap/app/src/util.js | duplicateModulesLabel": {
+    "message": "重复的模块"
+  },
+  "treemap/app/src/util.js | resourceBytesLabel": {
+    "message": "资源字节数"
+  },
+  "treemap/app/src/util.js | tableColumnName": {
+    "message": "名称"
+  },
+  "treemap/app/src/util.js | toggleTableButtonLabel": {
+    "message": "显示/隐藏表格"
+  },
+  "treemap/app/src/util.js | unusedBytesLabel": {
+    "message": "未使用的字节数"
   }
 }

package/shared/localization/locales.js

@@ -12,6 +12,12 @@
  * Google locale inheritance rules: https://goto.google.com/ccssm
  * CLDR language aliases: https://www.unicode.org/cldr/charts/latest/supplemental/aliases.html
  * CLDR locale inheritance: https://github.com/unicode-cldr/cldr-core/blob/master/supplemental/parentLocales.json
+ *
+ * For Lighthouse bundles that shouldn't include locale data, the recommended pattern
+ * is to replace the default export of this file with `{}` so that no locale messages
+ * are included. Strings will work normally through the IcuMessage.formattedDefault
+ * fallback, and locale messages can be added on demand (e.g. dynamically fetched)
+ * through `format.registerLocaleData()`.
  */
 
 // TODO(paulirish): Centralize locale inheritance (combining this & i18n.lookupLocale()), adopt cldr parentLocale rules.

package/shared/test/localization/format-test.js

@@ -9,10 +9,54 @@ const path = require('path');
 
 const format = require('../../localization/format.js');
 const i18n = require('../../../lighthouse-core/lib/i18n/i18n.js');
+const constants = require('../../../lighthouse-core/config/constants.js');
+const locales = require('../../localization/locales.js');
 
 /* eslint-env jest */
 
 describe('format', () => {
+  describe('DEFAULT_LOCALE', () => {
+    it('is the same as the default config locale', () => {
+      expect(format.DEFAULT_LOCALE).toBe(constants.defaultSettings.locale);
+    });
+  });
+
+  describe('#getAvailableLocales', () => {
+    it('has all the available locales', () => {
+      const availableLocales = format.getAvailableLocales();
+      for (const locale of ['en', 'es', 'ru', 'zh']) {
+        expect(availableLocales).toContain(locale);
+      }
+
+      const rawLocales = Object.keys(locales).sort();
+      expect(availableLocales.sort()).toEqual(rawLocales);
+    });
+
+    it('contains the default locale', () => {
+      expect(format.getAvailableLocales()).toContain(format.DEFAULT_LOCALE);
+    });
+  });
+
+  describe('#getCanonicalLocales', () => {
+    it('contains some canonical locales', () => {
+      const canonicalLocales = format.getCanonicalLocales();
+      for (const locale of ['en-US', 'es', 'ru', 'zh']) {
+        expect(canonicalLocales).toContain(locale);
+      }
+    });
+
+    it('is a subset of the available locales', () => {
+      const canonicalLocales = format.getCanonicalLocales();
+      const availableLocales = format.getAvailableLocales();
+
+      for (const canonicalLocale of canonicalLocales) {
+        expect(availableLocales).toContain(canonicalLocale);
+      }
+
+      expect(canonicalLocales.length).toBeLessThan(availableLocales.length);
+    });
+  });
+
   describe('#_formatPathAsString', () => {
     it('handles simple paths', () => {
       expect(format._formatPathAsString(['foo'])).toBe('foo');
@@ -363,15 +407,7 @@ describe('format', () => {
       expect(helloInfinityStr).toBeDisplayString('Hello ∞ World');
 
       const helloNaNStr = str_(UIStrings.helloBytesWorld, {in: NaN});
-      // TODO(COMPAT): workaround can be removed after Node 13 is retired.
-      // expect(helloNaNStr).toBeDisplayString('Hello NaN World');
-
-      // Node 13/V8 7.9 and 8.0 have a bug where `({a: NaN}).a.toLocaleString() === "-NaN"`. It
-      // works correctly in Node 12 and 14, so work around it since NaN isn't essential for
-      // user-facing strings and it will eventually correct itself.
-      const formattedNaNStr = format.getFormatted(helloNaNStr, 'en-US');
-      expect(formattedNaNStr === 'Hello NaN World' || formattedNaNStr === 'Hello -NaN World')
-        .toBe(true);
+      expect(helloNaNStr).toBeDisplayString('Hello NaN World');
     });
   });
 });

package/shared/test/localization/swap-locale-test.js

@@ -6,23 +6,11 @@
 'use strict';
 
 const swapLocale = require('../../localization/swap-locale.js');
-const {isNode12SmallIcu} = require('../../../lighthouse-core/test/test-utils.js');
 
 const lhr = require('../../../lighthouse-core/test/results/sample_v2.json');
 
 /* eslint-env jest */
 describe('swap-locale', () => {
-  // COMPAT: Node 12 only has 'en' by default. Skip these tests since they're all about swapping locales.
-  if (isNode12SmallIcu()) {
-    // Jest requires at least one test per suite.
-    it('throws if locale is not supported', () => {
-      // Even though 'pt' is requested, 'en' is all that's available.
-      expect(() => swapLocale(lhr, 'pt')).toThrow('Unsupported locale \'pt\'');
-    });
-
-    return;
-  }
-
   it('does not mutate the original lhr', () => {
     /** @type {LH.Result} */
     const lhrClone = JSON.parse(JSON.stringify(lhr));

package/third-party/chromium-synchronization/inspector-issueAdded-types-test.js

@@ -31,18 +31,26 @@ describe('issueAdded types', () => {
       .sort();
   });
 
-  // TODO: https://github.com/GoogleChrome/lighthouse/issues/13147
-  it.skip('should notify us if something changed', () => {
+  it('should notify us if something changed', () => {
     expect(inspectorIssueDetailsTypes).toMatchInlineSnapshot(`
-      Array [
-        "blockedByResponseIssueDetails",
-        "contentSecurityPolicyIssueDetails",
-        "heavyAdIssueDetails",
-        "mixedContentIssueDetails",
-        "sameSiteCookieIssueDetails",
-        "sharedArrayBufferTransferIssueDetails",
-      ]
-    `);
+Array [
+  "attributionReportingIssueDetails",
+  "blockedByResponseIssueDetails",
+  "contentSecurityPolicyIssueDetails",
+  "corsIssueDetails",
+  "deprecationIssueDetails",
+  "genericIssueDetails",
+  "heavyAdIssueDetails",
+  "lowTextContrastIssueDetails",
+  "mixedContentIssueDetails",
+  "navigatorUserAgentIssueDetails",
+  "quirksModeIssueDetails",
+  "sameSiteCookieIssueDetails",
+  "sharedArrayBufferIssueDetails",
+  "twaQualityEnforcementDetails",
+  "wasmCrossOriginModuleSharingIssue",
+]
+`);
   });
 
   // TODO: https://github.com/GoogleChrome/lighthouse/issues/13147

package/third-party/chromium-synchronization/installability-errors-test.js

@@ -11,6 +11,8 @@ const InstallableManifestAudit = require('../../lighthouse-core/audits/installab
 
 /* eslint-env jest */
 
+jest.setTimeout(20_000);
+
 describe('installabilityErrors', () => {
   let chromiumErrorIds;
 

package/third-party/download-content-shell/download-content-shell.js

@@ -85,7 +85,7 @@ function deleteOldContentShells() {
   const remainingNumberOfContentShells = MAX_CONTENT_SHELLS / 2;
   const oldContentShellDirs = files.slice(remainingNumberOfContentShells);
   for (let i = 0; i < oldContentShellDirs.length; i++) {
-    utils.removeRecursive(path.resolve(CACHE_PATH, oldContentShellDirs[i]));
+    fs.rmSync(path.resolve(CACHE_PATH, oldContentShellDirs[i]), {recursive: true, force: true});
   }
   console.log(`Removed old content shells: ${oldContentShellDirs}`);
 }
@@ -126,7 +126,7 @@ function findPreviousUploadedPosition(commitPosition) {
 async function prepareContentShellDirectory(folder) {
   const contentShellPath = path.join(CACHE_PATH, folder);
   if (utils.isDir(contentShellPath)) {
-    utils.removeRecursive(contentShellPath);
+    fs.rmSync(contentShellPath, {recursive: true, force: true});
   }
   fs.mkdirSync(contentShellPath);
   return folder;

package/third-party/download-content-shell/utils.js

@@ -96,29 +96,6 @@ function copyRecursive(src, dest) {
   }
 }
 
-function removeRecursive(filePath) {
-  try {
-    if (fs.existsSync(filePath)) {
-      if (isFile(filePath)) {
-        fs.unlinkSync(filePath);
-        return;
-      }
-      const files = fs.readdirSync(filePath);
-      for (let i = 0; i < files.length; i++) {
-        const childPath = path.resolve(filePath, files[i]);
-        if (isDir(childPath)) {
-          removeRecursive(childPath);
-        } else {
-          fs.unlinkSync(childPath);
-        }
-      }
-      fs.rmdirSync(filePath);
-    }
-  } catch (error) {
-    throw new Error(`Received an error: [${error}] while trying to remove: ${filePath}`);
-  }
-}
-
 function includes(sequence, target) {
   return sequence.indexOf(target) > -1;
 }
@@ -145,7 +122,6 @@ module.exports = {
   isDir,
   copy,
   copyRecursive,
-  removeRecursive,
   includes,
   shellOutput,
   parseArgs,

package/tsconfig-all.json

@@ -6,8 +6,8 @@
     {"path": "./types/lhr/"},
     {"path": "./report/"},
     {"path": "./report/generator/"},
-    {"path": "./lighthouse-viewer/"},
-    {"path": "./lighthouse-treemap/"},
+    {"path": "./viewer/"},
+    {"path": "./treemap/"},
     {"path": "./flow-report/"},
     {"path": "./shared/"},
   ],

package/tsconfig.json

@@ -58,7 +58,6 @@
     "lighthouse-core/test/gather/gatherers/full-page-screenshot-test.js",
     "lighthouse-core/test/gather/gatherers/global-listeners-test.js",
     "lighthouse-core/test/gather/gatherers/html-without-javascript-test.js",
-    "lighthouse-core/test/gather/gatherers/http-redirect-test.js",
     "lighthouse-core/test/gather/gatherers/js-usage-test.js",
     "lighthouse-core/test/gather/gatherers/link-elements-test.js",
     "lighthouse-core/test/gather/gatherers/offline-test.js",

package/types/artifacts.d.ts

@@ -25,7 +25,6 @@ export interface Artifacts extends BaseArtifacts, GathererArtifacts {}
 
 export type FRArtifacts = StrictOmit<Artifacts,
   | 'Fonts'
-  | 'HTTPRedirect'
   | 'Manifest'
   | 'MixedContent'
   | keyof FRBaseArtifacts
@@ -123,8 +122,6 @@ export interface GathererArtifacts extends PublicGathererArtifacts,LegacyBaseArt
   Accessibility: Artifacts.Accessibility;
   /** Array of all anchors on the page. */
   AnchorElements: Artifacts.AnchorElement[];
-  /** The value of the page's <html> manifest attribute, or null if not defined */
-  AppCacheManifest: string | null;
   /** Array of all URLs cached in CacheStorage. */
   CacheContents: string[];
   /** CSS coverage information for styles used by page's final state. */
@@ -148,8 +145,6 @@ export interface GathererArtifacts extends PublicGathererArtifacts,LegacyBaseArt
   FullPageScreenshot: Artifacts.FullPageScreenshot | null;
   /** Information about event listeners registered on the global object. */
   GlobalListeners: Array<Artifacts.GlobalListener>;
-  /** Whether the page ended up on an HTTPS page after attempting to load the HTTP version. */
-  HTTPRedirect: {value: boolean};
   /** The issues surfaced in the devtools Issues panel */
   InspectorIssues: Artifacts.InspectorIssues;
   /** JS coverage information for code used during page load. Keyed by network URL. */
@@ -211,6 +206,7 @@ declare module Artifacts {
       target: Array<string>;
       failureSummary?: string;
       node: NodeDetails;
+      relatedNodes: NodeDetails[];
     }>;
     error?: RuleExecutionError;
   }
@@ -491,8 +487,6 @@ declare module Artifacts {
     isPicture: boolean;
     /** Flags whether this element was contained within a ShadowRoot */
     isInShadowDOM: boolean;
-    /** The MIME type of the underlying image file. */
-    mimeType?: string;
     /** Details for node in DOM for the image element */
     node: NodeDetails;
     /** The loading attribute of the image. */
@@ -564,6 +558,7 @@ declare module Artifacts {
     blockedByResponse: LH.Crdp.Audits.BlockedByResponseIssueDetails[];
     heavyAds: LH.Crdp.Audits.HeavyAdIssueDetails[];
     contentSecurityPolicy: LH.Crdp.Audits.ContentSecurityPolicyIssueDetails[];
+    deprecations: LH.Crdp.Audits.DeprecationIssueDetails[];
   }
 
   // Computed artifact types below.
@@ -875,6 +870,11 @@ declare module Artifacts {
   }
 
   type ConsoleMessage = ConsoleAPICall | ConsoleException | ConsoleProtocolLog;
+
+  interface ImageElementRecord extends ImageElement {
+    /** The MIME type of the underlying image file. */
+    mimeType?: string;
+  }
 }
 
 export interface Trace {

package/types/enquirer.d.ts

@@ -4,6 +4,8 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
+import {EventEmitter} from 'events';
+
 declare module 'enquirer' {
   interface ConfirmOption {
     name: string | (() => string);
@@ -12,7 +14,7 @@ declare module 'enquirer' {
     actions?: {'ctrl': {[key: string]: string}}
   }
 
-  class Confirm extends NodeJS.EventEmitter {
+  class Confirm extends EventEmitter {
     constructor(option: ConfirmOption);
     run: () => Promise<boolean>;
     close: () => Promise<void>