lighthouse 12.5.1 → 12.6.0

package/core/lib/i18n/i18n.js

@@ -24,9 +24,9 @@ const UIStrings = {
   /** Used to show the duration in seconds that something lasted. The {timeInMs} placeholder will be replaced with the time duration, shown in seconds (e.g. 5.2 s) */
   seconds: '{timeInMs, number, seconds}\xa0s',
   /** Label shown per-audit to show how many bytes smaller the page could be if the user implemented the suggestions. The `{wastedBytes}` placeholder will be replaced with the number of bytes, shown in kibibytes (e.g. 148 KiB) */
-  displayValueByteSavings: 'Potential savings of {wastedBytes, number, bytes}\xa0KiB',
+  displayValueByteSavings: 'Est savings of {wastedBytes, number, bytes}\xa0KiB',
   /** Label shown per-audit to show how many milliseconds faster the page load could be if the user implemented the suggestions. The `{wastedMs}` placeholder will be replaced with the time duration, shown in milliseconds (e.g. 140 ms) */
-  displayValueMsSavings: 'Potential savings of {wastedMs, number, milliseconds}\xa0ms',
+  displayValueMsSavings: 'Est savings of {wastedMs, number, milliseconds}\xa0ms',
   /** Label shown per-audit to show how many HTML elements did not pass the audit. The `{# elements found}` placeholder will be replaced with the number of failing HTML elements. */
   displayValueElementsFound: `{nodeCount, plural, =1 {1 element found} other {# elements found}}`,
   /** Label for a column in a data table; entries will be the URL of a web resource */
@@ -40,9 +40,9 @@ const UIStrings = {
   /** Label for a column in a data table; entries will be the time to live value of the cache header on a web resource. */
   columnCacheTTL: 'Cache TTL',
   /** Label for a column in a data table; entries will be the number of kilobytes the user could reduce their page by if they implemented the suggestions. */
-  columnWastedBytes: 'Potential Savings',
+  columnWastedBytes: 'Est Savings',
   /** Label for a column in a data table; entries will be the number of milliseconds the user could reduce page load by if they implemented the suggestions. */
-  columnWastedMs: 'Potential Savings',
+  columnWastedMs: 'Est Savings',
   /** Label for a table column that displays how much time each row spent blocking other work on the main thread, entries will be the number of milliseconds spent. */
   columnBlockingTime: 'Main-Thread Blocking Time',
   /** Label for a column in a data table; entries will be the number of milliseconds spent during a particular activity. */

package/core/lib/legacy-javascript/legacy-javascript.js

@@ -15,21 +15,14 @@
 /** @typedef {{name: string, line: number, column: number}} PatternMatchResult */
 /** @typedef {{matches: PatternMatchResult[], estimatedByteSavings: number}} Result */
 
-import fs from 'fs';
-
-import {LH_ROOT} from '../../../shared/root.js';
-
-const polyfillModuleDataJson = fs.readFileSync(
-  `${LH_ROOT}/core/lib/legacy-javascript/polyfill-module-data.json`, 'utf-8');
+import polyfillModuleData_ from './polyfill-module-data.json' with { type: 'json' };
+import graph_ from './polyfill-graph-data.json' with { type: 'json' };
 
 /** @type {import('../../scripts/legacy-javascript/create-polyfill-module-data.js').PolyfillModuleData} */
-const polyfillModuleData = JSON.parse(polyfillModuleDataJson);
-
-const graphJson = fs.readFileSync(
-  `${LH_ROOT}/core/lib/legacy-javascript/polyfill-graph-data.json`, 'utf-8');
+const polyfillModuleData = polyfillModuleData_;
 
 /** @type {import('../../scripts/legacy-javascript/create-polyfill-size-estimation.js').PolyfillSizeEstimator} */
-const graph = JSON.parse(graphJson);
+const graph = graph_;
 
 /**
  * Takes a list of patterns (consisting of a name identifier and a RegExp expression string)

package/core/lib/legacy-javascript/package.json

@@ -0,0 +1,14 @@
+{
+  "name": "legacy-javascript",
+  "type": "module",
+  "version": "0.0.1",
+  "description": "Identify legacy polyfills and code transforms",
+  "main": "./legacy-javascript.js",
+  "repository": "GoogleChrome/lighthouse",
+  "author": "Google LLC",
+  "license": "Apache-2.0",
+  "bugs": {
+    "url": "https://github.com/GoogleChrome/lighthouse/issues"
+  },
+  "homepage": "https://github.com/GoogleChrome/lighthouse#readme"
+}

package/core/lib/page-functions.d.ts

@@ -43,7 +43,7 @@ export type ParseSelector<T extends string> = import("typed-query-selector/parse
  * @param {string|Error} [err] The error to convert
  * @return {{__failedInBrowser: boolean, name: string, message: string, stack: string|undefined}}
  */
-declare function wrapRuntimeEvalErrorInBrowser(err?: string | Error | undefined): {
+declare function wrapRuntimeEvalErrorInBrowser(err?: string | Error): {
     __failedInBrowser: boolean;
     name: string;
     message: string;

package/core/lib/stack-packs.js

@@ -69,7 +69,7 @@ const stackPacksToInclude = [
   },
   {
     packId: 'angular',
-    requiredStacks: ['js:@angular/core'],
+    requiredStacks: ['js:angular'],
   },
   {
     packId: 'react',

package/core/lib/tracehouse/cpu-profile-model.d.ts

@@ -223,6 +223,6 @@ export class CpuProfileModel {
      * @param {Array<LH.Artifacts.TaskNode>} [knownTaskNodes]
      * @return {Array<LH.TraceEvent>}
      */
-    synthesizeTraceEvents(knownTaskNodes?: import("./main-thread-tasks.js").TaskNode[] | undefined): Array<LH.TraceEvent>;
+    synthesizeTraceEvents(knownTaskNodes?: Array<LH.Artifacts.TaskNode>): Array<LH.TraceEvent>;
 }
 //# sourceMappingURL=cpu-profile-model.d.ts.map

package/core/lib/tracehouse/main-thread-tasks.d.ts

@@ -59,7 +59,7 @@ export class MainThreadTasks {
      * @param {LH.TraceEvent} [endEvent]
      * @return {TaskNode}
      */
-    static _createNewTaskNode(event: LH.TraceEvent, endEvent?: LH.TraceEvent | undefined): TaskNode;
+    static _createNewTaskNode(event: LH.TraceEvent, endEvent?: LH.TraceEvent): TaskNode;
     /**
      *
      * @param {TaskNode} currentTask
@@ -132,7 +132,7 @@ export class MainThreadTasks {
      * @param {TaskNode} task
      * @param {TaskGroup} [parentGroup]
      */
-    static _computeRecursiveTaskGroup(task: TaskNode, parentGroup?: import("./task-groups.js").TaskGroup | undefined): void;
+    static _computeRecursiveTaskGroup(task: TaskNode, parentGroup?: TaskGroup): void;
     /**
      * @param {LH.TraceEvent[]} mainThreadEvents
      * @param {Array<{id: string, url: string}>} frames
@@ -143,7 +143,7 @@ export class MainThreadTasks {
     static getMainThreadTasks(mainThreadEvents: LH.TraceEvent[], frames: Array<{
         id: string;
         url: string;
-    }>, traceEndTs: number, traceStartTs?: number | undefined): TaskNode[];
+    }>, traceEndTs: number, traceStartTs?: number): TaskNode[];
     /**
      * Prints an artistic rendering of the task tree for easier debugability.
      *

package/core/lib/tracehouse/main-thread-tasks.js

@@ -267,6 +267,14 @@ class MainThreadTasks {
             // It's less than 1ms, we'll let it slide by increasing the duration of the parent.
             currentTask.endTime = nextTask.endTime;
             currentTask.duration += timeDelta;
+
+            // Recursively extend parent endTimes, as needed.
+            let cur = currentTask.parent;
+            while (cur && cur.endTime < nextTask.endTime) {
+              cur.duration += nextTask.endTime - cur.endTime;
+              cur.endTime = nextTask.endTime;
+              cur = cur.parent;
+            }
           } else if (nextTask.unbounded) {
             // It's ending at traceEndTs, it means we were missing the end event. We'll truncate it to the parent.
             nextTask.endTime = currentTask.endTime;

package/core/lib/tracehouse/trace-processor.d.ts

@@ -220,7 +220,7 @@ export class TraceProcessor {
     */
     static processTrace(trace: LH.Trace, options?: {
         timeOriginDeterminationMethod?: TimeOriginDeterminationMethod;
-    } | undefined): LH.Artifacts.ProcessedTrace;
+    }): LH.Artifacts.ProcessedTrace;
     /**
      * Finds key navigation trace events and computes timings of events in milliseconds since the time
      * origin in addition to the standard microsecond monotonic timestamps.

package/core/lib/traces/metric-trace-events.d.ts

@@ -3,11 +3,11 @@ export class MetricTraceEvents {
      * Returns simplified representation of all metrics
      * @return {Array<{id: string, name: string, tsKey: keyof LH.Artifacts.TimingSummary}>} metrics to consider
      */
-    static get metricsDefinitions(): {
+    static get metricsDefinitions(): Array<{
         id: string;
         name: string;
         tsKey: keyof LH.Artifacts.TimingSummary;
-    }[];
+    }>;
     /**
      * @param {Array<LH.TraceEvent>} traceEvents
      * @param {LH.Result['audits']} auditResults

package/core/runner.js

@@ -147,8 +147,9 @@ class Runner {
    * @param {LH.Artifacts.ComputedContext} context
    */
   static async getEntityClassification(artifacts, context) {
-    const devtoolsLog = artifacts.devtoolsLogs?.[Audit.DEFAULT_PASS];
+    const devtoolsLog = artifacts.DevtoolsLog;
     if (!devtoolsLog) return;
+
     const classifiedEntities = await EntityClassification.request(
       {URL: artifacts.URL, devtoolsLog}, context);