lighthouse 12.5.1 → 12.6.0

package/core/audits/insights/legacy-javascript-insight.js

@@ -0,0 +1,101 @@
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/LegacyJavaScript.js';
+
+import {Audit} from '../audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+import {JSBundles} from '../../computed/js-bundles.js';
+import {adaptInsightToAuditProduct} from './insight-audit.js';
+
+// eslint-disable-next-line max-len
+const str_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/models/trace/insights/LegacyJavaScript.js', UIStrings);
+
+/** @typedef {LH.Audit.Details.TableItem & {subItems: {type: 'subitems', items: SubItem[]}}} Item */
+/** @typedef {{signal: string, location: LH.Audit.Details.SourceLocationValue}} SubItem */
+
+class LegacyJavaScriptInsight extends Audit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'legacy-javascript-insight',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.title),
+      description: str_(UIStrings.description),
+      guidanceLevel: 2,
+      requiredArtifacts: ['Trace', 'Scripts', 'SourceMaps'],
+    };
+  }
+
+  /**
+   * @param {LH.Artifacts} artifacts
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
+   */
+  static async audit(artifacts, context) {
+    const bundles = await JSBundles.request(artifacts, context);
+
+    return adaptInsightToAuditProduct(artifacts, context, 'LegacyJavaScript', (insight) => {
+      /** @type {LH.Audit.Details.Table['headings']} */
+      const headings = [
+        /* eslint-disable max-len */
+        {key: 'url', valueType: 'url', subItemsHeading: {key: 'location', valueType: 'source-location'}, label: str_(i18n.UIStrings.columnURL)},
+        {key: null, valueType: 'code', subItemsHeading: {key: 'signal'}, label: ''},
+        {key: 'wastedBytes', valueType: 'bytes', label: str_(UIStrings.columnWastedBytes)},
+        /* eslint-enable max-len */
+      ];
+
+      /** @type {Item[]} */
+      const items = [];
+
+      for (const [script, result] of insight.legacyJavaScriptResults) {
+        const bundle = bundles.find(bundle => bundle.script.scriptId === script.scriptId);
+
+        /** @type {Item} */
+        const item = {
+          url: script.url ?? '',
+          wastedBytes: result.estimatedByteSavings,
+          subItems: {
+            type: 'subitems',
+            items: [],
+          },
+        };
+
+        for (const match of result.matches) {
+          const {name, line, column} = match;
+          /** @type {SubItem} */
+          const subItem = {
+            signal: name,
+            location: Audit.makeSourceLocation(script.url ?? '', line, column, bundle),
+          };
+          item.subItems.items.push(subItem);
+        }
+
+        items.push(item);
+      }
+
+      // TODO: add this warning to the insight.
+      // for (const bundle of bundles) {
+      //   if (classifiedEntities.isFirstParty(bundle.script.url)) {
+      //     if (bundle.rawMap.sources.some(s => s.match(/node_modules\/core-js\/modules\/es[67]/))) {
+      //       if (!insight.warnings) {
+      //         insight.warnings = [];
+      //       }
+
+      //       insight.warnings.push(str_(UIStrings.detectedCoreJs2Warning));
+      //       break;
+      //     }
+      //   }
+      // }
+
+      return Audit.makeTableDetails(headings, items);
+    });
+  }
+}
+
+export default LegacyJavaScriptInsight;

package/core/audits/insights/modern-http-insight.d.ts

@@ -0,0 +1,11 @@
+export default ModernHTTPInsight;
+declare class ModernHTTPInsight extends Audit {
+    /**
+     * @param {LH.Artifacts} artifacts
+     * @param {LH.Audit.Context} context
+     * @return {Promise<LH.Audit.Product>}
+     */
+    static audit(artifacts: LH.Artifacts, context: LH.Audit.Context): Promise<LH.Audit.Product>;
+}
+import { Audit } from '../audit.js';
+//# sourceMappingURL=modern-http-insight.d.ts.map

package/core/audits/insights/modern-http-insight.js

@@ -0,0 +1,53 @@
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/ModernHTTP.js';
+
+import {Audit} from '../audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+import {adaptInsightToAuditProduct} from './insight-audit.js';
+
+// eslint-disable-next-line max-len
+const str_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/models/trace/insights/ModernHTTP.js', UIStrings);
+
+class ModernHTTPInsight extends Audit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'modern-http-insight',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.title),
+      description: str_(UIStrings.description),
+      guidanceLevel: 3,
+      requiredArtifacts: ['Trace', 'SourceMaps'],
+    };
+  }
+
+  /**
+   * @param {LH.Artifacts} artifacts
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
+   */
+  static async audit(artifacts, context) {
+    return adaptInsightToAuditProduct(artifacts, context, 'ModernHTTP', (insight) => {
+      /** @type {LH.Audit.Details.Table['headings']} */
+      const headings = [
+        /* eslint-disable max-len */
+        {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
+        {key: 'protocol', valueType: 'text', label: str_(UIStrings.protocol)},
+        /* eslint-enable max-len */
+      ];
+      /** @type {LH.Audit.Details.Table['items']} */
+      const items =
+        insight.requests.map(r => ({url: r.args.data.url, protocol: r.args.data.protocol}));
+      return Audit.makeTableDetails(headings, items);
+    });
+  }
+}
+
+export default ModernHTTPInsight;

package/core/audits/insights/network-dependency-tree-insight.d.ts

@@ -1,5 +1,10 @@
 export default NetworkDependencyTreeInsight;
 declare class NetworkDependencyTreeInsight extends Audit {
+    /**
+     * @param {import('@paulirish/trace_engine').Insights.Models.NetworkDependencyTree.CriticalRequestNode[]} nodes
+     * @return {LH.Audit.Details.NetworkNode}
+     */
+    static traceEngineNodesToDetailsNodes(nodes: import("@paulirish/trace_engine").Insights.Models.NetworkDependencyTree.CriticalRequestNode[]): LH.Audit.Details.NetworkNode;
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context

package/core/audits/insights/network-dependency-tree-insight.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-unused-vars */ // TODO: remove once implemented.
-
 /**
  * @license
  * Copyright 2025 Google LLC
@@ -10,7 +8,7 @@ import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/NetworkDe
 
 import {Audit} from '../audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
-import {adaptInsightToAuditProduct, makeNodeItemForNodeId} from './insight-audit.js';
+import {adaptInsightToAuditProduct} from './insight-audit.js';
 
 // eslint-disable-next-line max-len
 const str_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/models/trace/insights/NetworkDependencyTree.js', UIStrings);
@@ -25,27 +23,51 @@ class NetworkDependencyTreeInsight extends Audit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.title),
       description: str_(UIStrings.description),
-      guidanceLevel: 3,
-      requiredArtifacts: ['traces', 'TraceElements', 'SourceMaps'],
+      guidanceLevel: 1,
+      requiredArtifacts: ['Trace', 'SourceMaps'],
       replacesAudits: ['critical-request-chains'],
     };
   }
 
+  /**
+   * @param {import('@paulirish/trace_engine').Insights.Models.NetworkDependencyTree.CriticalRequestNode[]} nodes
+   * @return {LH.Audit.Details.NetworkNode}
+   */
+  static traceEngineNodesToDetailsNodes(nodes) {
+    /** @type {LH.Audit.Details.NetworkNode} */
+    const simpleRequestNode = {};
+
+    for (const node of nodes) {
+      const {request} = node;
+
+      simpleRequestNode[request.args.data.requestId] = {
+        url: request.args.data.url,
+        navStartToEndTime: Math.round(node.timeFromInitialRequest / 1000),
+        transferSize: request.args.data.encodedDataLength,
+        isLongest: node.isLongest,
+        children: this.traceEngineNodesToDetailsNodes(node.children),
+      };
+    }
+
+    return simpleRequestNode;
+  }
+
   /**
    * @param {LH.Artifacts} artifacts
    * @param {LH.Audit.Context} context
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    // TODO: implement.
     return adaptInsightToAuditProduct(artifacts, context, 'NetworkDependencyTree', (insight) => {
-      /** @type {LH.Audit.Details.Table['headings']} */
-      const headings = [
-      ];
-      /** @type {LH.Audit.Details.Table['items']} */
-      const items = [
-      ];
-      return Audit.makeTableDetails(headings, items);
+      const chains = this.traceEngineNodesToDetailsNodes(insight.rootNodes);
+
+      return {
+        type: 'network-tree',
+        chains,
+        longestChain: {
+          duration: Math.round(insight.maxTime / 1000),
+        },
+      };
     });
   }
 }

package/core/audits/insights/render-blocking-insight.js

@@ -24,7 +24,7 @@ class RenderBlockingInsight extends Audit {
       failureTitle: str_(UIStrings.title),
       description: str_(UIStrings.description),
       guidanceLevel: 3,
-      requiredArtifacts: ['traces', 'TraceElements', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'TraceElements', 'SourceMaps'],
       replacesAudits: ['render-blocking-resources'],
     };
   }

package/core/audits/insights/slow-css-selector-insight.js

@@ -1,5 +1,7 @@
 /* eslint-disable no-unused-vars */ // TODO: remove once implemented.
 
+// TODO: currently disabled via core/scripts/generate-insight-audits.js. Ignore for now.
+
 /**
  * @license
  * Copyright 2025 Google LLC
@@ -26,7 +28,7 @@ class SlowCSSSelectorInsight extends Audit {
       failureTitle: str_(UIStrings.title),
       description: str_(UIStrings.description),
       guidanceLevel: 3,
-      requiredArtifacts: ['traces', 'TraceElements', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'TraceElements', 'SourceMaps'],
     };
   }
 

package/core/audits/insights/third-parties-insight.d.ts

@@ -13,10 +13,10 @@ export type URLSummary = {
 declare class ThirdPartiesInsight extends Audit {
     /**
      * @param {LH.Artifacts.Entity} entity
-     * @param {import('@paulirish/trace_engine/models/trace/insights/ThirdParties.js').ThirdPartiesInsightModel} insight
-     * @return {Array<URLSummary>}
+     * @param {import('@paulirish/trace_engine/models/trace/extras/ThirdParties.js').URLSummary[]} urlSummaries
+     * @return {URLSummary[]}
      */
-    static makeSubItems(entity: LH.Artifacts.Entity, insight: import("@paulirish/trace_engine/models/trace/insights/ThirdParties.js").ThirdPartiesInsightModel): Array<URLSummary>;
+    static makeSubItems(entity: LH.Artifacts.Entity, urlSummaries: import("@paulirish/trace_engine/models/trace/extras/ThirdParties.js").URLSummary[]): URLSummary[];
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context

package/core/audits/insights/third-parties-insight.js

@@ -5,6 +5,7 @@
  */
 
 import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/ThirdParties.js';
+import {summarizeByURL} from '@paulirish/trace_engine/models/trace/extras/ThirdParties.js';
 
 import {Audit} from '../audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
@@ -31,24 +32,23 @@ class ThirdPartiesInsight extends Audit {
       failureTitle: str_(UIStrings.title),
       description: str_(UIStrings.description),
       guidanceLevel: 3,
-      requiredArtifacts: ['traces', 'TraceElements', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'TraceElements', 'SourceMaps'],
       replacesAudits: ['third-party-summary'],
     };
   }
 
   /**
    * @param {LH.Artifacts.Entity} entity
-   * @param {import('@paulirish/trace_engine/models/trace/insights/ThirdParties.js').ThirdPartiesInsightModel} insight
-   * @return {Array<URLSummary>}
+   * @param {import('@paulirish/trace_engine/models/trace/extras/ThirdParties.js').URLSummary[]} urlSummaries
+   * @return {URLSummary[]}
    */
-  static makeSubItems(entity, insight) {
-    const urls = [...insight.urlsByEntity.get(entity) ?? []];
-    return urls
-      .map(url => ({
-        url,
-        mainThreadTime: 0,
-        transferSize: 0,
-        ...insight.summaryByUrl.get(url),
+  static makeSubItems(entity, urlSummaries) {
+    urlSummaries = urlSummaries.filter(s => s.entity === entity);
+    return urlSummaries.filter(s => s.entity === entity)
+      .map(s => ({
+        url: s.url,
+        mainThreadTime: s.mainThreadTime,
+        transferSize: s.transferSize,
       }))
       // Sort by main thread time first, then transfer size to break ties.
       .sort((a, b) => (b.mainThreadTime - a.mainThreadTime) || (b.transferSize - a.transferSize));
@@ -60,9 +60,12 @@ class ThirdPartiesInsight extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    return adaptInsightToAuditProduct(artifacts, context, 'ThirdParties', (insight) => {
-      const thirdPartyEntities = [...insight.summaryByEntity.entries()]
-        .filter((([entity, _]) => entity !== insight.firstPartyEntity));
+    return adaptInsightToAuditProduct(artifacts, context, 'ThirdParties', (insight, extras) => {
+      const urlSummaries = summarizeByURL(extras.parsedTrace, extras.insights.bounds);
+
+      const thirdPartySummaries = insight.entitySummaries
+        .filter(summary => summary.entity !== insight.firstPartyEntity || null)
+        .sort((a, b) => b.mainThreadTime - a.mainThreadTime);
 
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
@@ -73,15 +76,17 @@ class ThirdPartiesInsight extends Audit {
         /* eslint-enable max-len */
       ];
       /** @type {LH.Audit.Details.Table['items']} */
-      const items = thirdPartyEntities.map(([entity, summary]) => ({
-        entity: entity.name,
-        transferSize: summary.transferSize,
-        mainThreadTime: summary.mainThreadTime,
-        subItems: {
-          type: /** @type {const} */ ('subitems'),
-          items: ThirdPartiesInsight.makeSubItems(entity, insight),
-        },
-      }));
+      const items = thirdPartySummaries.map((summary) => {
+        return {
+          entity: summary.entity.name,
+          mainThreadTime: summary.mainThreadTime,
+          transferSize: summary.transferSize,
+          subItems: {
+            type: /** @type {const} */ ('subitems'),
+            items: ThirdPartiesInsight.makeSubItems(summary.entity, urlSummaries),
+          },
+        };
+      });
       return Audit.makeTableDetails(headings, items, {isEntityGrouped: true});
     });
   }

package/core/audits/insights/viewport-insight.js

@@ -24,7 +24,7 @@ class ViewportInsight extends Audit {
       failureTitle: str_(UIStrings.title),
       description: str_(UIStrings.description),
       guidanceLevel: 3,
-      requiredArtifacts: ['traces', 'TraceElements', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'TraceElements', 'SourceMaps'],
       replacesAudits: ['viewport'],
     };
   }

package/core/audits/is-on-https.js

@@ -61,7 +61,7 @@ class HTTPS extends Audit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['devtoolsLogs', 'InspectorIssues'],
+      requiredArtifacts: ['DevtoolsLog', 'InspectorIssues'],
     };
   }
 
@@ -71,7 +71,7 @@ class HTTPS extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    const devtoolsLogs = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
+    const devtoolsLogs = artifacts.DevtoolsLog;
     const networkRecords = await NetworkRecords.request(devtoolsLogs, context);
     const insecureURLs = networkRecords
       .filter(record => !NetworkRequest.isSecureRequest(record))

package/core/audits/largest-contentful-paint-element.js

@@ -50,7 +50,7 @@ class LargestContentfulPaintElement extends Audit {
       guidanceLevel: 1,
       supportedModes: ['navigation'],
       requiredArtifacts:
-        ['traces', 'TraceElements', 'devtoolsLogs', 'GatherContext', 'settings', 'URL',
+        ['Trace', 'TraceElements', 'DevtoolsLog', 'GatherContext', 'settings', 'URL',
           'SourceMaps'],
     };
   }
@@ -120,8 +120,8 @@ class LargestContentfulPaintElement extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    const trace = artifacts.traces[Audit.DEFAULT_PASS];
-    const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
+    const trace = artifacts.Trace;
+    const devtoolsLog = artifacts.DevtoolsLog;
     const gatherContext = artifacts.GatherContext;
     const metricComputationData = {
       trace, devtoolsLog, gatherContext,

package/core/audits/layout-shifts.js

@@ -47,7 +47,7 @@ class LayoutShifts extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 2,
-      requiredArtifacts: ['traces', 'TraceElements', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'TraceElements', 'SourceMaps'],
     };
   }
 
@@ -58,7 +58,7 @@ class LayoutShifts extends Audit {
    */
   static async audit(artifacts, context) {
     const settings = context.settings;
-    const trace = artifacts.traces[Audit.DEFAULT_PASS];
+    const trace = artifacts.Trace;
     const SourceMaps = artifacts.SourceMaps;
     const traceEngineResult =
       await TraceEngineResult.request({trace, settings, SourceMaps}, context);
@@ -97,9 +97,9 @@ class LayoutShifts extends Audit {
       /** @type {SubItem[]} */
       const subItems = [];
       if (rootCauses) {
-        for (const backendNodeId of rootCauses.unsizedImages) {
+        for (const unsizedImage of rootCauses.unsizedImages) {
           const element = artifacts.TraceElements.find(
-            t => t.traceEventType === 'trace-engine' && t.nodeId === backendNodeId);
+            t => t.traceEventType === 'trace-engine' && t.nodeId === unsizedImage.backendNodeId);
           subItems.push({
             extra: element ? Audit.makeNodeItem(element.node) : undefined,
             cause: str_(UIStrings.rootCauseUnsizedMedia),

package/core/audits/lcp-lazy-loaded.js

@@ -36,7 +36,7 @@ class LargestContentfulPaintLazyLoaded extends Audit {
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 3,
       requiredArtifacts: ['TraceElements', 'ViewportDimensions', 'ImageElements',
-        'traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
+        'Trace', 'DevtoolsLog', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 

package/core/audits/long-tasks.d.ts

@@ -29,7 +29,7 @@ declare class LongTasks extends Audit {
      * @param {Map<TaskGroupIds, number>} [timeByTaskGroup]
      * @return {{startTime: number, duration: number, timeByTaskGroup: Map<TaskGroupIds, number>}}
      */
-    static getTimingBreakdown(task: LH.Artifacts.TaskNode, taskTimingsByEvent: Map<Lantern.Types.TraceEvent, LH.Gatherer.Simulation.NodeTiming> | undefined, timeByTaskGroup?: Map<import("../lib/tracehouse/task-groups.js").TaskGroupIds, number> | undefined): {
+    static getTimingBreakdown(task: LH.Artifacts.TaskNode, taskTimingsByEvent: Map<Lantern.Types.TraceEvent, LH.Gatherer.Simulation.NodeTiming> | undefined, timeByTaskGroup?: Map<TaskGroupIds, number>): {
         startTime: number;
         duration: number;
         timeByTaskGroup: Map<TaskGroupIds, number>;

package/core/audits/long-tasks.js

@@ -68,7 +68,7 @@ class LongTasks extends Audit {
       scoreDisplayMode: Audit.SCORING_MODES.INFORMATIVE,
       title: str_(UIStrings.title),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'DevtoolsLog', 'URL', 'GatherContext', 'SourceMaps'],
       guidanceLevel: 1,
     };
   }
@@ -177,9 +177,9 @@ class LongTasks extends Audit {
   static async audit(artifacts, context) {
     const settings = context.settings || {};
     const {URL, SourceMaps} = artifacts;
-    const trace = artifacts.traces[Audit.DEFAULT_PASS];
+    const trace = artifacts.Trace;
     const tasks = await MainThreadTasks.request(trace, context);
-    const devtoolsLog = artifacts.devtoolsLogs[LongTasks.DEFAULT_PASS];
+    const devtoolsLog = artifacts.DevtoolsLog;
     const networkRecords = await NetworkRecords.request(devtoolsLog, context);
 
     const metricComputationData = Audit.makeMetricComputationDataInput(artifacts, context);

package/core/audits/main-thread-tasks.js

@@ -17,7 +17,7 @@ class MainThreadTasks extends Audit {
       scoreDisplayMode: Audit.SCORING_MODES.INFORMATIVE,
       title: 'Tasks',
       description: 'Lists the toplevel main thread tasks that executed during page load.',
-      requiredArtifacts: ['traces'],
+      requiredArtifacts: ['Trace'],
     };
   }
 
@@ -27,7 +27,7 @@ class MainThreadTasks extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    const trace = artifacts.traces[Audit.DEFAULT_PASS];
+    const trace = artifacts.Trace;
     const tasks = await MainThreadTasksComputed.request(trace, context);
 
     const results = tasks

package/core/audits/mainthread-work-breakdown.d.ts

@@ -5,7 +5,7 @@ declare class MainThreadWorkBreakdown extends Audit {
     /**
      * @return {LH.Audit.ScoreOptions}
      */
-    static get defaultOptions(): import("../../types/audit.js").default.ScoreOptions;
+    static get defaultOptions(): LH.Audit.ScoreOptions;
     /**
      * @param {LH.Artifacts.TaskNode[]} tasks
      * @return {Map<TaskGroupIds, number>}

package/core/audits/mainthread-work-breakdown.js

@@ -46,7 +46,7 @@ class MainThreadWorkBreakdown extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 1,
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'DevtoolsLog', 'URL', 'GatherContext', 'SourceMaps'],
     };
   }
 
@@ -84,7 +84,7 @@ class MainThreadWorkBreakdown extends Audit {
    */
   static async audit(artifacts, context) {
     const settings = context.settings || {};
-    const trace = artifacts.traces[MainThreadWorkBreakdown.DEFAULT_PASS];
+    const trace = artifacts.Trace;
 
     let tbtSavings = 0;
     try {

package/core/audits/manual/manual-audit.d.ts

@@ -3,7 +3,7 @@ declare class ManualAudit extends Audit {
     /**
      * @return {Pick<LH.Audit.Meta, 'scoreDisplayMode'|'requiredArtifacts'>}
      */
-    static get partialMeta(): Pick<import("../../../types/audit.js").default.Meta, "scoreDisplayMode" | "requiredArtifacts">;
+    static get partialMeta(): Pick<LH.Audit.Meta, "scoreDisplayMode" | "requiredArtifacts">;
     /**
      * @return {LH.Audit.Product}
      */

package/core/audits/metrics/cumulative-layout-shift.d.ts

@@ -6,7 +6,7 @@ declare class CumulativeLayoutShift extends Audit {
     /**
      * @return {LH.Audit.ScoreOptions}
      */
-    static get defaultOptions(): import("../../../types/audit.js").default.ScoreOptions;
+    static get defaultOptions(): LH.Audit.ScoreOptions;
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context

package/core/audits/metrics/cumulative-layout-shift.js

@@ -30,7 +30,7 @@ class CumulativeLayoutShift extends Audit {
       title: str_(i18n.UIStrings.cumulativeLayoutShiftMetric),
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
-      requiredArtifacts: ['traces'],
+      requiredArtifacts: ['Trace'],
     };
   }
 
@@ -53,7 +53,7 @@ class CumulativeLayoutShift extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    const trace = artifacts.traces[Audit.DEFAULT_PASS];
+    const trace = artifacts.Trace;
 
     // impactByNodeId is unused but we don't want it on debug data
     // eslint-disable-next-line no-unused-vars

package/core/audits/metrics/first-contentful-paint.js

@@ -27,7 +27,7 @@ class FirstContentfulPaint extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
       supportedModes: ['navigation'],
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
+      requiredArtifacts: ['Trace', 'DevtoolsLog', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 
@@ -61,8 +61,8 @@ class FirstContentfulPaint extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    const trace = artifacts.traces[Audit.DEFAULT_PASS];
-    const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
+    const trace = artifacts.Trace;
+    const devtoolsLog = artifacts.DevtoolsLog;
     const gatherContext = artifacts.GatherContext;
     const metricComputationData = {trace, devtoolsLog, gatherContext,
       settings: context.settings, URL: artifacts.URL,

package/core/audits/metrics/first-meaningful-paint.js

@@ -28,7 +28,7 @@ class FirstMeaningfulPaint extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
       supportedModes: ['navigation'],
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+      requiredArtifacts: ['Trace', 'DevtoolsLog', 'GatherContext', 'URL'],
     };
   }
 

package/core/audits/metrics/interaction-to-next-paint.d.ts

@@ -6,7 +6,7 @@ declare class InteractionToNextPaint extends Audit {
     /**
      * @return {LH.Audit.ScoreOptions}
      */
-    static get defaultOptions(): import("../../../types/audit.js").default.ScoreOptions;
+    static get defaultOptions(): LH.Audit.ScoreOptions;
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context