gloomberb 0.18.2 → 0.18.4

package/src/plugins/builtin/broker-trading/pane.tsx

@@ -1,8 +1,9 @@
+import { logFailure } from "../../../utils/log-failure";
 import { useCallback, useEffect, useMemo, useRef, useState, useSyncExternalStore } from "react";
 import { isPlainKey } from "../../../utils/keyboard";
-import { Button, EmptyState, Notice, PaneFooterScope, SelectButton, usePaneFooter, usePaneMenuItems, type SelectControl } from "../../../components";
+import { Button, EmptyState, Notice, PaneFooterScope, SelectButton, confirmDialog, usePaneFooter, usePaneMenuItems, type SelectControl } from "../../../components";
 import { useShortcut } from "../../../react/input";
-import { useDialogState } from "../../../ui/dialog";
+import { useDialog, useDialogState } from "../../../ui/dialog";
 import { usePaneRefreshKey } from "../../../components/data-table/table-pane";
 import { usePaneVisible } from "../../../state/app/activity";
 import { useAppGetState, usePaneAppConfig, usePaneStateValue } from "../../../state/app/context";
@@ -11,14 +12,15 @@ import type { BrokerAdapter } from "../../../types/broker";
 import type { BrokerInstanceConfig } from "../../../types/config";
 import type { BrokerContractRef } from "../../../types/instrument";
 import type { PaneProps, TickerResearchTabProps } from "../../../types/plugin";
-import type { BrokerAccount, BrokerOrder } from "../../../types/trading";
+import type { BrokerAccount, BrokerOrder, BrokerOrderRequest } from "../../../types/trading";
 import { Box, useUiCapabilities } from "../../../ui";
+import { accountsShownFor } from "../../../brokers/broker-portfolio-sync";
 import { usePluginAppActions, usePluginBrokerActions } from "../../runtime";
 import { BrokerTradingController, type BrokerOrderOutcome } from "./controller";
 import { takeTradeIntent } from "./command";
 import { BrokerAccountPicker } from "./account-picker";
 import { BrokerOrdersView } from "./orders";
-import { brokerOrderDone, brokerOrderStatus } from "./orders-data";
+import { brokerOrderDone, brokerOrderKey, brokerOrderStatus } from "./orders-data";
 import { brokerOrderFeed, orderToastBody, useBrokerOrderFeed, useFeedOrderResult } from "./order-feed";
 import { isStrategyOrder, orderInstrumentLabel } from "./strategy";
 import {
@@ -26,7 +28,7 @@ import {
   resolveTicketContract, subscribeTradingStatus, ticketAccountChoiceKey, ticketPositionContext, type ProfileAccountChoice, type TicketPositionSnapshot,
 } from "./pane-model";
 import { BrokerTicketView, type TicketAction, type TicketField } from "./ticket";
-import { ticketChartLevels, ticketOrderMatches } from "./chart-levels";
+import { chartPriceOnTick, orderLevelTarget, orderLineMoves, TICKET_LEVEL_FIELDS, ticketChartLevels, ticketLineOrders, ticketOrderMatches } from "./chart-levels";
 import { useResearchTrading } from "../shared/research-trading";
 import { useThemeColors } from "../../../theme/theme-context";
 
@@ -62,6 +64,12 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
   const [defaultPriceLabel, setDefaultPriceLabel] = useState<string>();
   const [tradeIntent, setTradeIntent] = usePaneStateValue<string | null>("brokerTradeIntent", null);
   const [focusRevision, setFocusRevision] = useState(0);
+  // A change made on the chart leaves the ticket on Review: its next step. Its own counter, so a chart nudge moves
+  // the focus without asking for the quote again, as a new order does.
+  const [focusReview, setFocusReview] = useState(false);
+  const [chartFocusRevision, setChartFocusRevision] = useState(0);
+  // Whether the person changed the ticket's order since it began: work a drag on another order must not drop unasked.
+  const touched = useRef(false);
   const [pendingModify, setPendingModify] = useState<BrokerOrder>();
   const refreshResources = useRef<() => void>(() => {});
   const current = useRef({ broker, instance, accounts, accountId, positions });
@@ -97,6 +105,7 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
   useEffect(() => () => controller.dispose(), [controller]);
   useEffect(() => {
     controller.setDraft(newTicketDraft(broker, instance, contract, current.current.accountId));
+    touched.current = false;
   }, [controller, instance.id, contract]);
   useEffect(() => {
     if (!tradeIntent || ordersFirst) return;
@@ -117,6 +126,7 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
       }
       controller.reset();
       controller.setDraft(next);
+      touched.current = false;
       setTyped(""); setError(undefined); setDefaultPriceLabel(undefined); setPage("ticket");
       setFocusRevision((revision) => revision + 1);
     } catch (failure) { reportError(failure); }
@@ -157,7 +167,7 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
       void Promise.allSettled([broker.listAccounts?.(instance) ?? Promise.resolve([]), broker.importPositions(instance)]).then(([accountResult, positionResult]) => {
       if (!active) return;
       if (accountResult.status === "fulfilled") {
-        const nextAccounts = accountResult.value;
+        const nextAccounts = accountsShownFor(getState().config, instance, accountResult.value);
         current.current.accounts = nextAccounts;
         setAccounts(nextAccounts);
         const previous = current.current.accountId;
@@ -173,14 +183,17 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
     refresh();
     const timer = setInterval(refresh, 30_000);
     return () => { active = false; clearInterval(timer); if (refreshResources.current === refresh) refreshResources.current = () => {}; };
-  }, [broker, instance, connected, visible, selectAccount, allowAutoAccount, statusVersion]);
-  // A new ticket's limit defaults to its side of the quote, from the first quote that has a price, asked for
-  // or streamed, until the trader sets one. A stop is the trader's: at the touch it would trigger at once.
+  }, [broker, instance, connected, visible, selectAccount, allowAutoAccount, statusVersion, getState]);
+  // A new ticket's limit defaults to its side of the quote, from the first current quote that has a price,
+  // asked for or streamed, until the trader sets one. A stop is the trader's: at the touch it would trigger at
+  // once. A stale quote (before the open, the last session's book) is no price to trade at: the ticket shows
+  // its age and waits for a current one, which a broker's stream brings within seconds.
   const pricePending = useRef(false);
   const prefillPrice = useCallback(() => {
     const latest = controller.getSnapshot();
     const currentDraft = latest.draft, q = latest.quote?.quote;
-    if (!pricePending.current || !currentDraft || !q || latest.phase !== "editing" || latest.modifying) return;
+    // An OCO's limit is a target away from the market, never the touch.
+    if (!pricePending.current || !currentDraft || !q || latest.quote?.stale !== false || latest.phase !== "editing" || latest.modifying || currentDraft.orderClass === "oco") return;
     const source = currentDraft.action === "BUY" && q.ask !== undefined ? "ask" : currentDraft.action === "SELL" && q.bid !== undefined ? "bid" : "last";
     try {
       if ((currentDraft.orderType === "LMT" || currentDraft.orderType === "STP LMT") && currentDraft.limitPrice === undefined) {
@@ -188,7 +201,9 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
         setDefaultPriceLabel(`Broker ${source}. Editable.`);
       }
       pricePending.current = false;
-    } catch { /* No usable price in this quote yet: the next one may have it. */ }
+    } catch {
+      // Intentional ignore: an unusable quote cannot supply a default price; wait for the next quote.
+    }
   }, [controller]);
   useEffect(() => { prefillPrice(); }, [state.quote, prefillPrice]);
   const quote = useCallback(async (prefill = false) => {
@@ -196,7 +211,10 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
     try {
       await controller.loadQuote();
       prefillPrice();
-    } catch { /* The controller owns safe error state. */ }
+    } catch (error) {
+      logFailure("broker-trading.pane", "Load broker ticket quote failed")(error);
+      /* The controller owns safe error state. */
+    }
   }, [controller, prefillPrice]);
   usePaneRefreshKey(() => { refreshResources.current(); if (accountId && ticketContract.symbol) void quote(); }, { focused, enabled: page === "ticket" && !busy });
   // The broker's own quote stream, where it has one, keeps the ticket's bid, ask and last current;
@@ -222,12 +240,19 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
   }, [broker, instance, controller, visible, streamsQuotes, page, contractKey]);
   // The app's order feed: the drawer, chart levels and this ticket's result follow it.
   const orderFeed = useBrokerOrderFeed(broker, instance, connected);
+  // A fill changes the position a sell is sized against: the ticket reads it again then, not at its next 30 seconds.
+  const fillsSeen = useRef(orderFeed.fills);
+  useEffect(() => {
+    if (orderFeed.fills === fillsSeen.current) return;
+    fillsSeen.current = orderFeed.fills;
+    refreshResources.current();
+  }, [orderFeed.fills]);
   useFeedOrderResult(orderFeed, instance.id, state.result, controller.applyOrderUpdate);
   // Without pushed order changes, or while a change's outcome is unknown, the result is asked for every 10 seconds until it ends.
   const unknownResult = state.result?.status.toUpperCase() === "UNKNOWN" && state.result.orderId !== 0;
   useEffect(() => {
     if (!visible || !connected || (orderFeed.live && !unknownResult) || state.phase !== "result" || !state.result || ["FILLED", "CANCELLED", "CANCELED", "REJECTED", "EXPIRED", "SUPERSEDED"].includes(state.result.status.toUpperCase())) return;
-    const timer = setInterval(() => { void controller.refreshResult().catch(() => {}); }, 10_000);
+    const timer = setInterval(() => { void controller.refreshResult().catch(logFailure("broker-trading.pane", "Poll broker ticket result failed")); }, 10_000);
     return () => clearInterval(timer);
   }, [visible, connected, orderFeed.live, unknownResult, state.phase, state.result?.orderId, state.result?.status, controller]);
   // A placed order says so in a toast here; its later fills and its end toast from the order feed, app-wide.
@@ -258,6 +283,7 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
       // Controlled inputs can echo a programmatic value before React commits the next render.
       if (Object.entries(next).every(([key, nextValue]) => Object.is(nextValue, latestDraft[key as keyof typeof latestDraft]))) return;
       controller.setDraft(next);
+      touched.current = true;
       setTyped(""); setError(undefined);
       if (field === "limitPrice" || field === "orderType") setDefaultPriceLabel(undefined);
       if (field === "limitPrice" || field === "stopPrice") pricePending.current = false;
@@ -290,6 +316,7 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
           const account = current.current.accounts.find((value) => value.accountId === current.current.accountId);
           const quantity = quickTicketQuantity(latestDraft, capabilities, controller.getSnapshot().quote?.quote, account, held, action === "quantity25" ? 0.25 : action === "quantity50" ? 0.5 : 1);
           controller.setDraft({ ...latestDraft, quantity });
+          touched.current = true;
           setTyped("");
         }
         else if (action === "priceBid" || action === "priceMid" || action === "priceAsk" || action === "priceLast") {
@@ -297,6 +324,7 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
           if (!latestDraft || latestDraft.orderType === "MKT") throw new Error("Choose a limit or stop order before setting a price.");
           const source = ({ priceBid: "bid", priceMid: "mid", priceAsk: "ask", priceLast: "last" } as const)[action];
           controller.applyPriceDefault(source, latestDraft.orderType === "STP" ? "stopPrice" : "limitPrice");
+          touched.current = true;
           setDefaultPriceLabel(`Broker ${source}. Editable.`); setTyped("");
         }
         else if (action === "orders") setPage("orders");
@@ -304,6 +332,7 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
           controller.reset();
           // After a spread, a new order is for the ticket's own instrument again.
           controller.setDraft(newTicketDraft(broker, instance, isStrategyOrder({ contract: ticketContract }) ? contract : ticketContract, accountId));
+          touched.current = false;
           setTyped(""); setDefaultPriceLabel(undefined); setPage("ticket");
         }
       } catch (failure) { reportError(failure); }
@@ -317,20 +346,60 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
     if (choice.profileId === instance.id) onAccountChange(choice.accountId);
     onChooseProfileAccount?.(choice);
   };
-  const onModify = (order: BrokerOrder, edit?: { price: number; review: boolean }) => {
+  const onModify = (order: BrokerOrder, edit?: { price: number; review: boolean; field?: "limitPrice" | "stopPrice" }) => {
     try {
       if (!order.accountId) throw new Error("This order has no account. Refresh it in your broker.");
       selectAccount(order.accountId);
       controller.beginModify(order);
+      touched.current = false;
       if (edit) {
         const next = controller.getSnapshot().draft!;
-        controller.setDraft({ ...next, ...(next.orderType === "STP" ? { stopPrice: edit.price } : { limitPrice: edit.price }) });
+        controller.setDraft({ ...next, [edit.field ?? (next.orderType === "STP" ? "stopPrice" : "limitPrice")]: edit.price });
+        touched.current = true;
         if (edit.review) void controller.review().catch(reportError);
       }
-      setTyped(""); setError(undefined); setPage("ticket");
+      setTyped(""); setError(undefined); setPage("ticket"); setFocusReview(false);
       setFocusRevision((revision) => revision + 1);
     } catch (failure) { reportError(failure); }
   };
+  // The chart beside the ticket moves its levels and picks its prices through these, with the latest state. A
+  // draft price changes in the draft; a working order's line opens its change here. Review and confirm still decide.
+  const chartEdits = useRef({ setPrice: (_field: string, _value: number) => {}, moveLevel: (_id: string, _value: number) => {} });
+  const chartOrders = useRef<readonly BrokerOrder[]>([]);
+  const dialog = useDialog();
+  chartEdits.current.setPrice = (field, value) => {
+    const snapshot = controller.getSnapshot();
+    if (busy || snapshot.phase !== "editing" || !snapshot.draft) return;
+    onEdit(field as TicketField, String(chartPriceOnTick(value, caps?.priceStep, caps?.priceDecimals)));
+    setFocusReview(true); setChartFocusRevision((revision) => revision + 1);
+  };
+  chartEdits.current.moveLevel = (id, value) => {
+    if (busy) return;
+    const draftField = TICKET_LEVEL_FIELDS[id as keyof typeof TICKET_LEVEL_FIELDS];
+    if (draftField) { chartEdits.current.setPrice(draftField, value); return; }
+    // The orders the lines were drawn from: a confirmed change's latest terms, under the ID the broker gave it.
+    const target = orderLevelTarget(id, chartOrders.current);
+    if (!target) return;
+    const snapshot = controller.getSnapshot();
+    const changing = controller.modifyingOrder();
+    if (changing && brokerOrderKey(changing) === brokerOrderKey(target.order) && snapshot.phase === "editing") {
+      chartEdits.current.setPrice(target.field, value);
+      return;
+    }
+    const price = chartPriceOnTick(value, caps?.priceStep, caps?.priceDecimals);
+    const start = () => {
+      if (trade && !trade.visible) trade.open();
+      onModify(target.order, { price, review: false, field: target.field });
+      setFocusReview(true);
+    };
+    // An order or change the person is still writing is theirs: another order's change replaces it only when asked.
+    if (snapshot.phase !== "editing" || !touched.current) { start(); return; }
+    void confirmDialog(dialog, {
+      title: "Replace the ticket's order?",
+      body: [changing ? "The ticket holds a change you have not sent." : "The ticket holds an order you have not sent.", `Change ${orderToastBody(target.order)} instead?`],
+      confirmLabel: "Replace", cancelLabel: "Keep editing", width: 52, footer: "Enter replace · Esc keep editing",
+    }).then((replace) => { if (replace) start(); });
+  };
   useEffect(() => {
     if (!pendingModify) return;
     if (pendingModify.brokerInstanceId && pendingModify.brokerInstanceId !== instance.id) {
@@ -345,15 +414,31 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
   const mode = accounts.find((account) => account.accountId === accountId)?.tradingMode;
   useEffect(() => {
     // A spread's net premium is not a price on the underlying's chart.
-    const orders = openOrders.filter((order) => !isStrategyOrder(order) && ticketOrderMatches(order, ticketContract, instance.id, accountId));
+    const listed = openOrders.filter((order) => !isStrategyOrder(order) && ticketOrderMatches(order, ticketContract, instance.id, accountId));
     const latestOrder = state.result && !isStrategyOrder(state.result) && ticketOrderMatches(state.result, ticketContract, instance.id, accountId) ? state.result : undefined;
+    const orders = ticketLineOrders(listed, latestOrder);
+    chartOrders.current = orders;
+    const editing = state.phase === "editing" && trade?.visible !== false;
+    // A working order's line moves where the broker changes it and the ticket is free to open its change.
+    const free = !busy && (state.phase === "editing" || state.phase === "result") && page !== "enable" && !!broker.modifyOrder;
+    const movable = (order: BrokerOrder) => free && orderLineMoves(order, broker.getTradingCapabilities?.(instance, order.contract, order.orderType as BrokerOrderRequest["orderType"]));
     const levels = ticketChartLevels({
-      draft: strategy ? undefined : draft, editing: state.phase === "editing" && trade?.visible !== false, orders, latestOrder,
+      draft: strategy ? undefined : draft, editing, orders, modifying: state.modifying ? controller.modifyingOrder() : undefined, movable,
       avgCost: position?.avgCost, position: position?.quantity, colors, priceStep: caps?.priceStep, priceDecimals: caps?.priceDecimals,
     });
-    publish?.({ mode, busy, contract: ticketContract, levels });
-  }, [publish, mode, busy, draft, strategy, trade?.visible, state.phase, state.result, openOrders, ticketContract, instance.id, accountId, position?.avgCost, position?.quantity, colors, caps?.priceStep, caps?.priceDecimals]);
+    // The prices a pick on the chart sets: the entry's first, then a bracket's exits.
+    const priceFields = editing && draft && !strategy ? [
+      ...(["LMT", "STP LMT"].includes(draft.orderType) ? [{ field: "limitPrice", label: "limit" }] : []),
+      ...(["STP", "STP LMT"].includes(draft.orderType) ? [{ field: "stopPrice", label: "stop" }] : []),
+      ...(draft.orderClass === "oco" ? [{ field: "stopLossPrice", label: "stop" }] : []),
+      ...(draft.orderClass === "bracket" ? [{ field: "takeProfitPrice", label: "take profit" }, { field: "stopLossPrice", label: "stop loss" }] : []),
+    ] : [];
+    publish?.({ mode, busy, contract: ticketContract, levels, priceFields,
+      setPrice: (field, value) => chartEdits.current.setPrice(field, value), moveLevel: (id, value) => chartEdits.current.moveLevel(id, value) });
+  }, [publish, mode, busy, draft, strategy, trade?.visible, state.phase, state.result, state.modifying, page, openOrders, ticketContract, instance, broker, accountId, position?.avgCost, position?.quantity, colors, caps?.priceStep, caps?.priceDecimals, controller]);
   useEffect(() => () => publish?.({ levels: [] }), [publish]);
+  // Review takes the focus for the step after a chart edit only: back from review ("Edit order"), a change's price does.
+  useEffect(() => { if (state.phase !== "editing") setFocusReview(false); }, [state.phase]);
   // Docked, the open orders show only while this ticker has some, or when asked
   // for: o from the ticket shows and focuses them, o again (or Hide/Show orders) hides them.
   const tickerOrderCount = openOrders.filter((order) => ticketOrderMatches(order, ticketContract, instance.id, accountId) && !brokerOrderDone(order.status)).length;
@@ -389,16 +474,19 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
     <Box visible={docked || page !== "orders"} height={docked && native ? undefined : ticketHeight} maxHeight={ticketHeight} flexShrink={0}>
     <PaneFooterScope active={page !== "orders"}>
     <BrokerTicketView onContentHeight={setTicketContentHeight} blocked={ordersBusy} asking={drawerConfirming} width={width} height={ticketHeight} focused={focused && page !== "orders"} onCapture={onCapture} docked={docked} onClose={onClose} model={{
-    brokerName: broker.name, symbol: orderInstrumentLabel(receipt?.request ?? draft ?? { contract: ticketContract }), accounts, accountId,
+    // An adapter that fronts several brokers (signed in) names the one this profile connects.
+    brokerName: broker.describeInstance?.(instance).brokerName ?? broker.name, symbol: orderInstrumentLabel(receipt?.request ?? draft ?? { contract: ticketContract }), accounts, accountId,
     accountChoices, accountChoiceValue: accountChoices && accountId ? ticketAccountChoiceKey(instance.id, accountId) : undefined,
     accountType: accounts.find((account) => account.accountId === accountId)?.accountType,
-    quote: state.quote?.quote, legQuotes: state.quote?.legs, quoteData: connection?.quoteData,
+    quote: state.quote?.quote, quoteStale: state.quote?.stale, legQuotes: state.quote?.legs, quoteData: connection?.quoteData,
     phase: page === "enable" ? "enable" : state.phase, draft: receipt?.request ?? draft, preview: state.review?.preview ?? receipt?.preview, warnings: state.review?.warnings ?? [], result: state.result, resultQuantities: state.resultQuantities,
     error: connection?.state === "error" && connection.message ? connection.message : error ?? state.error, reconnecting,
     position: position?.quantity, avgCost: position?.avgCost, positionPnl: position?.pnl, tradingEnabled: caps?.enabled === true,
     typedConfirmation: typed, connected, capabilities: caps, modifying: state.modifying, original: state.modifying ? controller.modifyingOrder() : undefined, defaultPriceLabel, confirmOrders: state.confirmOrders,
-    initialFocus: state.modifying ? draft?.orderType === "STP" ? "stopPrice" : "limitPrice" : focusRevision ? "review" : undefined, focusRevision,
-  }} onEdit={onEdit} onAction={onAction} onAccountChange={onTicketAccountChange} />
+    initialFocus: focusReview ? "review" : state.modifying ? draft?.orderType === "STP" ? "stopPrice" : draft?.orderType === "TRAIL" ? "trailing" : "limitPrice" : focusRevision ? "review" : undefined,
+    focusRevision: focusRevision + chartFocusRevision,
+  }} onEdit={onEdit} onAction={onAction} onAccountChange={onTicketAccountChange}
+    onPickPrice={trade?.docked && trade.visible && trade.pickPrice ? (field) => trade.pickPrice!(field) : undefined} />
     </PaneFooterScope>
     </Box>
     <Box visible={ordersShown || !docked && page === "orders"} onMouseDown={() => setPage("orders")} marginTop={ordersShown && !native ? 1 : 0}
@@ -414,6 +502,7 @@ function ProfileTicket({ broker, instance, contract, width, height, focused, ord
 export function BrokerTradeTab({ width, height, focused, onCapture, docked, onClose }: TickerResearchTabProps & { docked?: boolean; onClose?: () => void }) {
   const identity = usePaneTickerIdentity();
   const config = usePaneAppConfig();
+  const getState = useAppGetState();
   const visible = usePaneVisible();
   const { getBrokerAdapter } = usePluginBrokerActions();
   const { showPane } = usePluginAppActions();
@@ -450,7 +539,7 @@ export function BrokerTradeTab({ width, height, focused, onCapture, docked, onCl
         const adapter = getBrokerAdapter(profile.brokerType);
         const state = adapter?.getStatus?.(profile).state;
         // A profile reconnecting keeps its accounts, so the ticket does not ask to choose one again.
-        const accounts = state === "connected" ? await adapter!.listAccounts?.(profile) ?? [] : state === "connecting" ? lastAccounts.current.get(profile.id) ?? [] : [];
+        const accounts = state === "connected" ? accountsShownFor(getState().config, profile, await adapter!.listAccounts?.(profile) ?? []) : state === "connecting" ? lastAccounts.current.get(profile.id) ?? [] : [];
         lastAccounts.current.set(profile.id, accounts);
         return { profile, accounts };
       })).then((results) => {
@@ -460,7 +549,7 @@ export function BrokerTradeTab({ width, height, focused, onCapture, docked, onCl
     refresh();
     const timer = setInterval(refresh, 30_000);
     return () => { active = false; clearInterval(timer); };
-  }, [groupProfiles, getBrokerAdapter, visible, statusVersion]);
+  }, [groupProfiles, getBrokerAdapter, visible, statusVersion, getState]);
   const resolution = useMemo(() => broker && instance ? resolveTicketContract(identity, broker, instance) : {}, [identity, instance?.id, broker]);
   // A refreshed ticker record resolves the same contract again; only another contract starts a new draft.
   const contractValue = JSON.stringify(resolution.contract ?? null);

package/src/plugins/builtin/broker-trading/ticket-parts.tsx

@@ -9,7 +9,13 @@ import { orderEstimatePrice } from "./orders-data";
 
 export const ticketNumber = (value: number | undefined) => value === undefined || !Number.isFinite(value) ? "Unavailable" : value.toLocaleString("en-US", { maximumFractionDigits: 4 });
 export const ticketMoney = (value: number | undefined, currency = "USD") => value === undefined || !Number.isFinite(value) ? "Not reported" : new Intl.NumberFormat("en-US", { style: "currency", currency, maximumFractionDigits: 2 }).format(value);
-export const ticketTypeName: Record<string, string> = { MKT: "Market", LMT: "Limit", STP: "Stop", "STP LMT": "Stop limit" };
+/** A preview figure: "Not available" when the broker said it gives none for this order, never a zero. */
+export const ticketImpactMoney = (preview: TicketViewModel["preview"], value: number | undefined, currency = "USD") =>
+  value === undefined && preview?.impactSource === "unavailable" ? "Not available" : ticketMoney(value, currency);
+/** The figures' source for a broker that names it: "Brokerage preview" or "Not available". */
+export const ticketImpactSource = (preview: TicketViewModel["preview"]) =>
+  preview?.impactSource === "broker" ? "Brokerage preview" : preview?.impactSource === "unavailable" ? "Not available" : undefined;
+export const ticketTypeName: Record<string, string> = { MKT: "Market", LMT: "Limit", STP: "Stop", "STP LMT": "Stop limit", TRAIL: "Trailing stop" };
 export const ticketTifName: Record<string, string> = { DAY: "Day", GTC: "Good til cancelled", IOC: "Immediate or cancel", FOK: "Fill or kill", EXTENDED_HOURS: "Extended hours", AT_THE_OPENING: "At the opening", AT_THE_CLOSE: "At the close" };
 /** `selectable`: a review or receipt whose figures someone may copy by hand. */
 export function TicketSection({ children, width, title, selectable = false }: { children: ReactNode; width?: number; title?: string; selectable?: boolean }) {
@@ -28,6 +34,16 @@ export function TicketOrderHeadline({ model: m, large = false }: { model: Ticket
     <FigureText part={large ? "value" : "sub"} style={large ? undefined : { fontSize: "var(--gloom-type-heading)", fontWeight: "var(--gloom-weight-bold)" }}>{`${ticketNumber(draft?.quantity)} ${m.symbol}`}</FigureText>
   </Box>;
 }
+/** A bracket's exits as review and the receipt name them. They trade the other way, for the same quantity. */
+export function TicketExits({ model: m, width, currency }: { model: TicketViewModel; width: number; currency: string }) {
+  const draft = m.draft;
+  if (draft?.orderClass !== "bracket") return null;
+  const exit = (value: number | undefined) => value === undefined ? "None" : ticketMoney(value, currency);
+  return <Box flexDirection="column">
+    <TicketReceiptRow label="Take profit" value={exit(draft.takeProfitPrice)} width={width} />
+    <TicketReceiptRow label="Stop loss" value={exit(draft.stopLossPrice)} width={width} />
+  </Box>;
+}
 /** A spread's legs as they fill: side, contracts across all spreads, contract, and each leg's mid at this broker. */
 /** `inset`: in the order form, the legs line up with the fields' labels. */
 export function TicketLegs({ model: m, width, inset = false }: { model: TicketViewModel; width: number; inset?: boolean }) {
@@ -62,7 +78,13 @@ export function TicketOrderSummary({ model: m, width, compact = false, receipt =
   const positionAfter = !strategy && m.position !== undefined && draft ? m.position + (draft.action === "SELL" ? -draft.quantity : draft.quantity) : undefined;
   const powerAfter = m.preview?.buyingPowerAfter;
   const sideColor = draft?.action === "SELL" ? c.negative : c.positive;
-  if (compact && receipt) return <Box flexDirection="column">
+  // A broker that names its preview's source reports cash, credited to whoever gave the figures.
+  const cash = m.preview?.impactSource ? m.preview : undefined;
+  const cashTitle = `Cash · ${cash?.impactSourceLabel ?? "broker preview"}`;
+  if (compact && receipt) return cash ? <Box flexDirection="column">
+    <Text fg={c.textDim}>{cashTitle}</Text>
+    <TicketReceiptRow label="After order" value={ticketImpactMoney(cash, cash.cashAfter, currency)} width={width} />
+  </Box> : <Box flexDirection="column">
     <Text fg={c.textDim}>Buying power · broker preview</Text>
     <TicketReceiptRow label={powerAfter === undefined ? "Impact" : "After order"} value={ticketMoney(powerAfter ?? m.preview?.buyingPowerImpact, currency)} width={width} />
   </Box>;
@@ -78,14 +100,21 @@ export function TicketOrderSummary({ model: m, width, compact = false, receipt =
       <TicketReceiptRow label="Current position" value={ticketNumber(m.position)} width={rowWidth} />
       <TicketReceiptRow label="Order quantity" value={`${draft?.action === "SELL" ? "−" : "+"}${ticketNumber(draft?.quantity)}`} color={sideColor} width={rowWidth} />
     </>}
-    <Box marginTop={1}><SectionHeading title="Buying power · broker preview" /></Box>
-    <TicketReceiptRow label="Before order" value={ticketMoney(m.preview?.buyingPowerBefore ?? account?.buyingPower, currency)} width={rowWidth} />
-    <TicketReceiptRow label="Broker impact" value={ticketMoney(m.preview?.buyingPowerImpact, currency)} width={rowWidth} />
-    <TicketReceiptRow label="After order" value={ticketMoney(m.preview?.buyingPowerAfter, currency)} width={rowWidth} />
+    {cash ? <>
+      <Box marginTop={1}><SectionHeading title={cashTitle} /></Box>
+      <TicketReceiptRow label="Before order" value={ticketMoney(cash.cashBefore, currency)} width={rowWidth} />
+      <TicketReceiptRow label="Broker impact" value={ticketImpactMoney(cash, cash.cashBefore !== undefined && cash.cashAfter !== undefined ? cash.cashAfter - cash.cashBefore : undefined, currency)} width={rowWidth} />
+      <TicketReceiptRow label="After order" value={ticketImpactMoney(cash, cash.cashAfter, currency)} width={rowWidth} />
+    </> : <>
+      <Box marginTop={1}><SectionHeading title="Buying power · broker preview" /></Box>
+      <TicketReceiptRow label="Before order" value={ticketMoney(m.preview?.buyingPowerBefore ?? account?.buyingPower, currency)} width={rowWidth} />
+      <TicketReceiptRow label="Broker impact" value={ticketMoney(m.preview?.buyingPowerImpact, currency)} width={rowWidth} />
+      <TicketReceiptRow label="After order" value={ticketMoney(m.preview?.buyingPowerAfter, currency)} width={rowWidth} />
+    </>}
   </TicketSection>;
   return <TicketSection width={width} title="Order summary" selectable>
     <TicketOrderHeadline model={m} large />
-    <Text fg={c.textDim}>{`${ticketTypeName[draft?.orderType ?? "LMT"]} · ${ticketTifName[draft?.tif ?? "DAY"] ?? draft?.tif}${draft?.outsideRth ? " · Outside RTH" : ""}`}</Text>
+    <Text fg={c.textDim}>{`${draft?.orderClass === "oco" ? "OCO" : ticketTypeName[draft?.orderType ?? "LMT"]}${draft?.orderClass === "bracket" ? " with take profit / stop loss" : ""} · ${ticketTifName[draft?.tif ?? "DAY"] ?? draft?.tif}${draft?.outsideRth ? " · Outside RTH" : ""}`}</Text>
     <Box flexDirection="column" paddingY={1}><Text fg={c.textDim}>Estimated order value</Text><FigureText>{ticketMoney(total, currency)}</FigureText></Box>
     {strategy ? <TicketLegs model={m} width={rowWidth} /> : null}
     <TicketReceiptRow label="Quantity" value={`${ticketNumber(draft?.quantity)} ${unit}`} width={rowWidth} />