gloomberb 0.18.2 → 0.18.4

package/src/renderers/electrobun/bun/desktop/backend-requests.ts

@@ -12,6 +12,7 @@ import type {
   DesktopCoreRequest,
 } from "../../shared/protocol";
 import { encodeRpcValue } from "../../shared/rpc-codec";
+import { desktopBootFramePath, removeDesktopBootFrame } from "../window/boot-frame";
 import { paneIdFromDetachedRpcKey } from "../window/focus";
 import type { DesktopBackend, DesktopRpc } from "./backend";
 import { createElectrobunDesktopUpdater } from "./update";
@@ -80,7 +81,9 @@ export async function handleDesktopBackendRequest(
     }
     case "config.resetAllData":
       closeDesktopSession(backend);
+      // No config, no session: a frame the closing window still sends is dropped.
       backend.config = null;
+      removeDesktopBootFrame(desktopBootFramePath());
       await resetAllData(request.payload.dataDir);
       return null;
     case "config.export":

package/src/renderers/electrobun/bun/desktop/backend.ts

@@ -1,4 +1,5 @@
 import { ApplicationMenu, BrowserView, Utils, type BrowserWindow } from "electrobun/bun";
+import { homedir } from "os";
 import { createAppServices, type AppServices } from "../../../../core/app-services";
 import { syncConfigActiveLayoutState, type PaneRuntimeState } from "../../../../core/state/app/state";
 import {
@@ -15,7 +16,11 @@ import { startRemoteControlServer, type RemoteControlServer } from "../../../../
 import type { RemoteControlRequest, RemoteControlResponse } from "../../../../remote/types";
 import { installCrashReporter } from "../../../../telemetry/crash-reports";
 import { createNodeCrashReporterHost } from "../../../../telemetry/crash-reports-node";
+import { installUpdateFailureReporter, reviewLastUpdateAttempt } from "../../../../telemetry/update-failures";
+import { createNodeUpdateFailureHost } from "../../../../telemetry/update-failures-node";
 import type { AppConfig } from "../../../../types/config";
+import { linkDesktopCommands } from "../../../../updater/command-names";
+import { debugLog } from "../../../../utils/debug-log";
 import type { DesktopSharedStateSnapshot } from "../../../../types/desktop-window";
 import type {
   ContextMenuSelectMessage,
@@ -31,18 +36,20 @@ import { registerElectrobunCoreCapabilities } from "../core-capabilities";
 import {
   activateExternalPlugin,
   bundleExternalPluginDirectory,
-  collectExternalPluginBundles,
   deactivateExternalPlugin,
   desktopPluginManager,
+  prefetchExternalPluginBundles,
+  takeExternalPluginBundles,
 } from "../external-plugins";
 import { MAIN_WINDOW_RPC_KEY } from "../window/focus";
 import { handleDesktopBackendRequest } from "./backend-requests";
+import { detectDesktopInstallKind, removeUpdateAsides } from "./update";
 import { DesktopCapabilityBridge } from "./capability-bridge";
 import { DesktopDetachedWindowManager } from "./detached-windows";
 import { handleDesktopHostRequest } from "./host-requests";
 import { handleHttpFetch } from "./http-fetch";
 import { DesktopHttpStreamBridge } from "./http-stream";
-import { initializeDesktopBackend } from "./initialization";
+import { initializeDesktopBackend, joinDesktopBackendLaunch } from "./initialization";
 import { applyMacosDockIcon } from "./macos-dock-icon";
 import { handleDesktopPluginStateRequest } from "./plugin-state";
 import { scheduleDesktopRelaunch } from "./relaunch";
@@ -55,6 +62,8 @@ export type DesktopRpc = ReturnType<typeof BrowserView.defineRPC<ElectrobunDeskt
 
 /** How long a quit waits for the view to flush and exit on its own. */
 const QUIT_FALLBACK_MS = 2_500;
+/** How long after the main window is up the app looks for its `gloomberb` command to add `gloom` beside it. */
+const COMMAND_LINK_DELAY_MS = 10_000;
 const MAX_PENDING_DEEP_LINKS = 20;
 
 function summarizeError(error: unknown): string {
@@ -111,6 +120,7 @@ export class DesktopBackend {
   private crashReporterInstalled = false;
   private restartInProgress = false;
   private pluginAutoUpdatesStarted = false;
+  private commandLinksScheduled = false;
   private remoteControlServer: RemoteControlServer | null = null;
   private readonly pendingDeepLinks: string[] = [];
   private readonly contextMenuRequestRpcs = new Map<string, DesktopRpc>();
@@ -138,6 +148,13 @@ export class DesktopBackend {
     if (!this.crashReporterInstalled) {
       this.crashReporterInstalled = true;
       installCrashReporter(createNodeCrashReporterHost({ surface: "desktop", getConfig: () => this.config }));
+      // This process runs the desktop update, so it reports how the last one ended and any that fail.
+      installUpdateFailureReporter(createNodeUpdateFailureHost({
+        installKind: detectDesktopInstallKind(),
+        getDataDir: () => this.config?.dataDir ?? null,
+      }));
+      reviewLastUpdateAttempt();
+      void removeUpdateAsides();
     }
     // The native menu shows the same accelerators the keys use, so a rebind
     // rebuilds it.
@@ -182,6 +199,11 @@ export class DesktopBackend {
     return { config, services };
   }
 
+  /** Compiles the view's plugins ahead of its first `plugins.listExternal`. */
+  prefetchExternalPluginBundles(): void {
+    prefetchExternalPluginBundles();
+  }
+
   teardownServices(): void {
     this.stopRemoteControlServer();
     this.capabilityBridge.disposeAll();
@@ -382,10 +404,36 @@ export class DesktopBackend {
         console.error("[remote] desktop control endpoint failed", summarizeError(error));
       });
       this.ensurePluginAutoUpdates();
+      this.scheduleCommandLinks();
     }
     return init;
   }
 
+  /**
+   * An install from before the rename updates its bundle in place and keeps
+   * only the `gloomberb` command its installer linked, so the app adds `gloom`
+   * beside it. That looks through PATH, which can hold a slow network folder,
+   * so it runs a while after the main window is up and never in its way.
+   */
+  private scheduleCommandLinks(): void {
+    if (this.commandLinksScheduled) return;
+    this.commandLinksScheduled = true;
+    const log = debugLog.createLogger("desktop-command");
+    const timer = setTimeout(() => {
+      void linkDesktopCommands({
+        platform: process.platform,
+        homeDir: homedir(),
+        pathEnv: process.env.PATH ?? "",
+        localAppData: process.env.LOCALAPPDATA,
+      }).then((added) => {
+        if (added.length > 0) log.info(`Added the gloom command in ${added.length} folder(s)`);
+      }, (error: unknown) => {
+        log.warn("Could not add the gloom command", summarizeError(error));
+      });
+    }, COMMAND_LINK_DELAY_MS);
+    timer.unref?.();
+  }
+
   private flushPendingDeepLinks(): void {
     if (this.pendingDeepLinks.length === 0) return;
     const urls = this.pendingDeepLinks.splice(0);
@@ -475,7 +523,11 @@ export class DesktopBackend {
       case "pluginState.delete":
         return handleDesktopPluginStateRequest(this.requireServices().persistence.pluginState, request);
       case "plugins.listExternal":
-        return collectExternalPluginBundles();
+        // The view asks beside `init`. Waiting for a launch in flight takes
+        // the bundles it compiles, and keeps a second load of the plugins
+        // from running beside the one the services do. It never starts a
+        // launch of its own: that is `init`'s.
+        return joinDesktopBackendLaunch(this).then(takeExternalPluginBundles);
       case "plugins.install":
         return desktopPluginManager.install(request.payload.ref, request.payload.pin);
       case "plugins.update":
@@ -501,6 +553,7 @@ export class DesktopBackend {
       case "host.saveTextFile":
       case "host.notify":
       case "host.showContextMenu":
+      case "host.saveBootFrame":
       case "host.setAppBadge":
         return handleDesktopHostRequest(this, rpc, request);
       case "update.check":

package/src/renderers/electrobun/bun/desktop/detached-windows.ts

@@ -131,7 +131,7 @@ export class DesktopDetachedWindowManager {
   private resolveTitle(instanceId: string): string {
     const config = this.backend.config;
     const instance = config ? findPaneInstance(config.layout, instanceId) : null;
-    if (!instance) return "Gloomberb";
+    if (!instance) return "Gloom";
     return instance.title?.trim() || instance.paneId;
   }
 

package/src/renderers/electrobun/bun/desktop/host-requests.ts

@@ -12,6 +12,7 @@ import { MAIN_WINDOW_RPC_KEY } from "../window/focus";
 import { applyDesktopWindowControl } from "../window/controls";
 import { saveTextFileToDownloads } from "../../../../utils/save-text-file";
 import { setAppBadge } from "./app-badge";
+import { desktopBootFramePath, saveDesktopBootFrame } from "../window/boot-frame";
 import type { DesktopBackend, DesktopRpc } from "./backend";
 
 function normalizeText(value: unknown): string | undefined {
@@ -114,8 +115,7 @@ export async function handleDesktopHostRequest(
         throw new Error("host.openExternal requires a URL.");
       }
       const externalUrl = safeExternalUrl(request.payload.url);
-      if (externalUrl) Utils.openExternal(externalUrl);
-      return null;
+      return externalUrl ? Utils.openExternal(externalUrl) !== false : false;
     }
     case "host.copyText":
       Utils.clipboardWriteText(normalizeText(request.payload.text) ?? "");
@@ -142,7 +142,7 @@ export async function handleDesktopHostRequest(
     case "host.notify":
       playNotificationSound(normalizeText(request.payload.sound));
       Utils.showNotification({
-        title: normalizeText(request.payload.title) ?? "Gloomberb",
+        title: normalizeText(request.payload.title) ?? "Gloom",
         body: normalizeText(request.payload.body),
         subtitle: normalizeText(request.payload.subtitle),
         silent: true,
@@ -156,6 +156,12 @@ export async function handleDesktopHostRequest(
       ContextMenu.showContextMenu(menu as never);
       return true;
     }
+    case "host.saveBootFrame":
+      saveDesktopBootFrame(desktopBootFramePath(), request.payload.frame, {
+        mainWindow: backend.rpcs.getRpcWindowKey(rpc) === MAIN_WINDOW_RPC_KEY,
+        session: backend.config !== null,
+      });
+      return null;
     case "host.setAppBadge":
       // One badge for the app, from the main window; a popped-out pane's view
       // has its own chat state and must not overwrite it.

package/src/renderers/electrobun/bun/desktop/initialization.ts

@@ -3,6 +3,7 @@ import { homedir, hostname } from "os";
 import { getGloomberbDirs } from "../../../../data/config/home";
 import type { AppServices } from "../../../../core/app-services";
 import { restoreExtractedPlugins } from "../../../../cli/restore-plugins";
+import { takePluginSeedNotice } from "../../../../plugins/seed-notice";
 import {
   getDataDir,
   initDataDir,
@@ -72,6 +73,8 @@ function buildInitializationPayload(
   services: AppServices,
   windowTarget: DesktopWindowTarget,
 ): ElectrobunBackendInit {
+  // The main window says once what the launch's seed could not install.
+  const pluginSeedNotice = windowTarget.kind === "main" ? takePluginSeedNotice() : null;
   return {
     config,
     sessionSnapshot: backend.getSessionSnapshot(),
@@ -84,6 +87,7 @@ function buildInitializationPayload(
     hostName: hostname(),
     windowKind: windowTarget.kind,
     paneId: windowTarget.paneId,
+    ...(pluginSeedNotice ? { pluginSeedNotice } : {}),
     telemetry: {
       installId: readOrCreateInstallId(config.dataDir),
       os: describeNodeOs(),
@@ -101,6 +105,77 @@ async function resolveDesktopDataDir(): Promise<string> {
   return dataDir;
 }
 
+/** The launch work, in order. Injected so a test can watch the order without a data folder. */
+export interface DesktopLaunchSteps {
+  readConfig(): Promise<AppConfig>;
+  /** Installs plugins that moved into their own repositories; returns the seed record to merge. */
+  restorePlugins(): Promise<Partial<AppConfig> | null>;
+  startServices(config: AppConfig): Promise<unknown>;
+  /** Starts compiling the plugins for the view; not awaited. */
+  prefetchPluginBundles(): void;
+}
+
+function desktopLaunchSteps(backend: DesktopBackend): DesktopLaunchSteps {
+  return {
+    readConfig: async () => initDataDir(await resolveDesktopDataDir()),
+    // Restore plugins that moved into their own repositories before the
+    // catalog is read, the same as the terminal does at startup. Without it a
+    // desktop-only user silently loses a feature the day it is extracted,
+    // since nothing else installs it for them.
+    restorePlugins: restoreExtractedPlugins,
+    startServices: (config) => backend.startServices(config),
+    prefetchPluginBundles: () => backend.prefetchExternalPluginBundles(),
+  };
+}
+
+const launches = new WeakMap<object, Promise<void>>();
+
+/**
+ * Opens the data folder and starts the services every window shares: the
+ * config, restored plugins, and every plugin registered. That takes most of
+ * a second, and it used to wait for the view to load its bundle and ask for
+ * `init`. Started when the process starts, it runs while the window opens
+ * and the view loads, and `init` finds it done or nearly so. The plugins the
+ * view runs then start compiling, still before the view asks for them, and
+ * after the services imported them, so two loads never link one plugin at once.
+ *
+ * Callers share a run in flight. With the services up it does nothing; after
+ * they were torn down (all data reset) or a run failed, it starts over.
+ */
+export function startDesktopBackend(
+  backend: DesktopBackend,
+  steps: DesktopLaunchSteps = desktopLaunchSteps(backend),
+): Promise<void> {
+  const running = launches.get(backend);
+  if (running) return running;
+  if (backend.config && backend.services) return Promise.resolve();
+  const launch = (async () => {
+    const initialConfig = await steps.readConfig();
+    const seed = await steps.restorePlugins();
+    await steps.startServices(seed ? { ...initialConfig, ...seed } : initialConfig);
+    steps.prefetchPluginBundles();
+  })();
+  launches.set(backend, launch);
+  const settled = () => {
+    if (launches.get(backend) === launch) launches.delete(backend);
+  };
+  // The caller that awaits the launch reports a failure; this only lets the next one start over.
+  launch.then(settled, settled);
+  return launch;
+}
+
+/**
+ * Waits for a launch in flight, and starts none: for a request that wants
+ * what the launch makes but must not start the services itself. Only `init`
+ * (and the process start) launches, so services torn down by a config import
+ * or a reset are not brought up twice. Settles either way; a failed launch
+ * is for `init` to report.
+ */
+export function joinDesktopBackendLaunch(backend: DesktopBackend): Promise<void> {
+  const running = launches.get(backend);
+  return running ? running.then(() => {}, () => {}) : Promise.resolve();
+}
+
 export async function initializeDesktopBackend(
   backend: DesktopBackend,
   rpc: DesktopRpc,
@@ -110,24 +185,12 @@ export async function initializeDesktopBackend(
   backend.rpcs.markWindowRpcReady(rpc);
   backend.stateBroadcaster.forgetWindowState(rpc);
 
-  const currentConfig = backend.config;
-  const currentServices = backend.services;
-  if (currentConfig && currentServices) {
-    if (!backend.workspace) {
-      backend.workspace = createDesktopWorkspace(currentConfig, backend.getSessionSnapshot());
-      backend.detachedWindows.reconcile();
-    }
-    return buildInitializationPayload(backend, currentConfig, currentServices, windowTarget);
+  await startDesktopBackend(backend);
+  const config = backend.requireConfig();
+  const services = backend.requireServices();
+  if (!backend.workspace) {
+    backend.workspace = createDesktopWorkspace(config, backend.getSessionSnapshot());
+    backend.detachedWindows.reconcile();
   }
-
-  const initialConfig = await initDataDir(await resolveDesktopDataDir());
-  // Restore plugins that moved into their own repositories before the catalog
-  // is read, the same as the terminal does at startup. Without it a
-  // desktop-only user silently loses a feature the day it is extracted, since
-  // nothing else installs it for them.
-  const seededPlugins = await restoreExtractedPlugins();
-  const { config, services } = await backend.startServices(
-    seededPlugins ? { ...initialConfig, seededPlugins } : initialConfig,
-  );
   return buildInitializationPayload(backend, config, services, windowTarget);
 }