gloomberb 0.18.2 → 0.18.4

package/src/components/command-bar/workflow/collection-actions.ts

@@ -16,6 +16,7 @@ import { connectSignedInBrokerProfile } from "../../../brokers/signed-in/connect
 import {
   addTickerToPortfolio,
   adoptFirstPositionCurrency,
+  LotCostFxMergeError,
   createManualPortfolio as createManualPortfolioConfig,
   deleteManualPortfolio,
   deleteWatchlist as deleteWatchlistConfig,
@@ -27,6 +28,14 @@ import {
   validatePositionShares,
 } from "../../../portfolio/mutations";
 import { loadFuturesEntrySize } from "../../../portfolio/futures-terms";
+import {
+  FORM_COST_FX_WORDING, PositionCostFxError, readCostFxRate, readPurchaseDate, resolvePositionCostFx,
+} from "../../../portfolio/cost-fx";
+import { getManualPortfolioPositionPrefill } from "../../../portfolio/manual-lots";
+import { resolvePortfolioTotalsCurrency } from "../../../portfolio/totals-currency";
+import { createBaseConverter } from "../../../cli/base-converter";
+import { heldCurrencyUnit } from "../../../utils/currency-units";
+import { positionCostTermsPrefill } from "./portfolio-position";
 import { wholeUnitQuantityProblem } from "../../../portfolio/position-quantity";
 import type { CommandBarFieldValue } from "./types";
 import type { WorkflowStringValues } from "./broker";
@@ -126,6 +135,7 @@ export function createCommandBarCollectionWorkflowActions(options: {
       const connected = await connectSignedInBrokerProfile(broker, {
         getConfig: () => pluginRegistry.getConfig(),
         createBrokerInstance: (brokerType, label, values) => pluginRegistry.createBrokerInstance(brokerType, label, values),
+        enableBrokerInstance: (instanceId) => pluginRegistry.updateBrokerInstance(instanceId, {}, { enabled: true }),
         syncBrokerInstance: (instanceId) => pluginRegistry.syncBrokerInstance(instanceId),
         requestSignIn: requestBrokerSignIn,
       });
@@ -271,16 +281,45 @@ export function createCommandBarCollectionWorkflowActions(options: {
         currentState.config.baseCurrency,
         size?.currency,
       );
-      const result = setManualPortfolioPosition(ticker, portfolio.id, {
-        shares,
-        avgCost,
-        currency,
-        ...(size ? { multiplier: size.multiplier } : {}),
-      });
+      // Purchase Date and Cost FX behave as `position set --date/--cost-fx`. A field left as it opened keeps
+      // what the lots have; one emptied clears it; a new date reads that day's FX close unless a rate is typed.
       const firstPosition = !hasOpenPortfolioPositions(portfolio.id, getState().tickers.values());
+      const adopted = firstPosition ? adoptFirstPositionCurrency(getState().config, portfolio.id, currency) : null;
+      const valued = adopted ?? getState().config;
+      const portfolioCurrency = resolvePortfolioTotalsCurrency(
+        valued.portfolios.find((entry) => entry.id === portfolio.id) ?? portfolio, valued.baseCurrency);
+      const opened = positionCostTermsPrefill(getManualPortfolioPositionPrefill(ticker, portfolio.id).position, portfolioCurrency);
+      const dateText = coerceFieldString(values.dateAcquired).trim();
+      const rateText = coerceFieldString(values.costFx).trim();
+      const dateAcquired = dateText === opened.dateAcquired ? undefined : dateText ? readPurchaseDate(dateText, FORM_COST_FX_WORDING) : null;
+      const typedRate = rateText && rateText !== opened.costFx ? readCostFxRate(rateText, FORM_COST_FX_WORDING) : undefined;
+      const toPortfolio = createBaseConverter(dataProvider, heldCurrencyUnit(portfolioCurrency).currency);
+      let result: ReturnType<typeof setManualPortfolioPosition>;
+      try {
+        const bought = await resolvePositionCostFx({
+          date: dateAcquired ?? undefined, costFx: typedRate, history: apiClient,
+          currency, portfolioCurrency, listing: ticker.metadata.ticker, wording: FORM_COST_FX_WORDING,
+          // Today's rate, in the units the lot is held in: what a typed rate is checked against.
+          todaysRate: async () => (await toPortfolio(1, heldCurrencyUnit(currency).currency))
+            / heldCurrencyUnit(currency).divisor * heldCurrencyUnit(portfolioCurrency).divisor,
+        });
+        const costFx = bought ? bought.costFx : !rateText && opened.costFx ? null : undefined;
+        result = setManualPortfolioPosition(ticker, portfolio.id, {
+          shares,
+          avgCost,
+          currency,
+          ...(size ? { multiplier: size.multiplier } : {}),
+          ...(dateAcquired !== undefined ? { dateAcquired } : {}),
+          ...(costFx !== undefined ? { costFx } : {}),
+        });
+      } catch (error) {
+        // The form shows one message: what is wrong, then what to give instead.
+        if (error instanceof PositionCostFxError && error.details) throw new Error(`${error.message} ${error.details}`);
+        if (error instanceof LotCostFxMergeError) throw new Error(`${error.message} Give its Cost FX or Purchase Date.`);
+        throw error;
+      }
       await tickerRepository.saveTicker(result.ticker);
       dispatch({ type: "UPDATE_TICKER", ticker: result.ticker });
-      const adopted = firstPosition ? adoptFirstPositionCurrency(getState().config, portfolio.id, currency) : null;
       if (adopted) {
         dispatch({ type: "SET_CONFIG", config: adopted });
         persistConfig(adopted);

package/src/components/command-bar/workflow/collection-ticker.ts

@@ -1,7 +1,7 @@
 import type { TickerRecord } from "../../../types/ticker";
-import { canonicalExchange, parsePublicTickerKey } from "../../../utils/exchanges";
+import { canonicalExchange, parsePublicTickerKey, publicTickerKey } from "../../../utils/exchanges";
 import { resolveCurrencyUnit } from "../../../utils/currency-units";
-import { tickerHasListingSuffix, listingSuffixConflictsWithExchange, listingSuffixExchange } from "../../../sources/listing-symbols";
+import { tickerHasListingSuffix, listingSuffixConflictsWithExchange, listingSuffixExchange, listingSuffixVenue } from "../../../sources/listing-symbols";
 import { classifyInstrumentKind } from "../../../tickers/search/ranking";
 import { searchContractKey } from "../../../tickers/search/identity";
 import type { CollectionKind } from "./tickers";
@@ -42,6 +42,34 @@ function ownsCollection(ticker: TickerRecord, kind: CollectionKind, collectionId
     || (kind === "portfolio" && ticker.metadata.positions.some((position) => !collectionId || position.portfolio === collectionId));
 }
 
+/**
+ * The row a research alias under a vendor's suffixed key (GARAN.IS, opened
+ * from a link) joins a collection as: its listing's own row, saved under the
+ * key GARAN:BIST is saved under, or a new one there. Null for any other row.
+ */
+function listingRow(
+  ticker: TickerRecord,
+  equivalent: readonly TickerRecord[],
+  tickers: ReadonlyMap<string, TickerRecord>,
+): TickerRecord | null {
+  if ((ticker.metadata.broker_contracts ?? []).length > 0) return null;
+  const parsed = parsePublicTickerKey(ticker.metadata.ticker);
+  const venue = listingSuffixVenue(parsed.symbol, parsed.exchange ?? ticker.metadata.exchange);
+  if (!venue) return null;
+  const own = equivalent.find((candidate) => !tickerHasListingSuffix(parsePublicTickerKey(candidate.metadata.ticker).symbol));
+  if (own) return own;
+  const onVenue = (row: TickerRecord | undefined) => !!row && canonicalExchange(row.metadata.exchange) === venue.exchange;
+  const bare = tickers.get(venue.symbol);
+  const venueKey = publicTickerKey(venue.symbol, venue.exchange);
+  if (onVenue(bare)) return bare!;
+  if (onVenue(tickers.get(venueKey))) return tickers.get(venueKey)!;
+  // A new row takes the key adding GARAN:BIST takes: the bare symbol while it is free.
+  const key = bare ? venueKey : venue.symbol;
+  if (tickers.has(key)) return null;
+  const { mergedLots: _lots, ...metadata } = ticker.metadata;
+  return { metadata: { ...metadata, ticker: key, exchange: venue.exchange, portfolios: [], watchlists: [], positions: [], tags: [], custom: {} } };
+}
+
 /** Research aliases must not hide or duplicate the saved record that owns a holding. */
 export function resolveCollectionTicker(
   ticker: TickerRecord,
@@ -51,7 +79,7 @@ export function resolveCollectionTicker(
 ): TickerRecord {
   ticker = tickers.get(ticker.metadata.ticker) ?? ticker;
   const identity = listingIdentity(ticker);
-  if (!identity) return ticker;
+  if (!identity) return listingRow(ticker, [], tickers) ?? ticker;
   const equivalent = [...new Map([...tickers, [ticker.metadata.ticker, ticker]]).values()]
     .filter((candidate) => listingIdentity(candidate) === identity);
   const owners = equivalent.filter((candidate) => ownsCollection(candidate, kind, collectionId));
@@ -61,5 +89,5 @@ export function resolveCollectionTicker(
   // If existing records own different collections, the requested empty record
   // can join a new collection without changing either existing owner.
   const otherOwners = collectionId ? equivalent.filter((candidate) => ownsCollection(candidate, kind)) : [];
-  return otherOwners.length === 1 ? otherOwners[0]! : ticker;
+  return otherOwners.length === 1 ? otherOwners[0]! : listingRow(ticker, equivalent, tickers) ?? ticker;
 }

package/src/components/command-bar/workflow/fields.ts

@@ -47,6 +47,12 @@ export function keysClearedByChange(
   return clearOnChange && !Object.is(previous, next) ? clearOnChange : [];
 }
 
+/** A wizard step's condition as the workflow field's list: one answer, or every one of several. */
+function wizardDependencies(dependsOn: WizardStep["dependsOn"]): FieldDependency[] | undefined {
+  if (!dependsOn) return undefined;
+  return (Array.isArray(dependsOn) ? dependsOn : [dependsOn]).map(({ key, value }) => ({ key, value }));
+}
+
 /** The answer a wizard step starts on: its default, else a select's first option. */
 function wizardStepInitialValue(step: WizardStep): string | undefined {
   if (step.defaultValue) return step.defaultValue;
@@ -175,7 +181,7 @@ export function normalizeWizardFields(steps: WizardStep[]): {
         placeholder: step.placeholder,
         description: step.body?.[0],
         required: step.required !== false,
-        dependsOn: step.dependsOn ? [{ key: step.dependsOn.key, value: step.dependsOn.value }] : undefined,
+        dependsOn: wizardDependencies(step.dependsOn),
         clearOnChange: step.clearOnChange,
       });
       continue;
@@ -188,7 +194,7 @@ export function normalizeWizardFields(steps: WizardStep[]): {
       placeholder: step.placeholder,
       description: step.body?.[0],
       required: step.required !== false,
-      dependsOn: step.dependsOn ? [{ key: step.dependsOn.key, value: step.dependsOn.value }] : undefined,
+      dependsOn: wizardDependencies(step.dependsOn),
       clearOnChange: step.clearOnChange,
     });
   }

package/src/components/command-bar/workflow/ops.ts

@@ -1,6 +1,7 @@
 import { type LayoutConfig, type PaneBinding, type PaneInstanceConfig } from "../../../types/config";
 import type { PaneSettingField, PaneTemplateContext, PaneTemplateCreateOptions, PaneTemplateInstanceConfig, PaneTemplateDef } from "../../../types/plugin";
 import { getFocusedCollectionId, getFocusedTickerSymbol } from "../../../state/app/context";
+import { commandPromptTicker } from "../../../layout/selected-ticker";
 import { resolveInstrumentForPane, resolveListingForPane } from "../../../core/state/app/instrument";
 import { resolveTickerOpenTarget, tickerOpenFailureMessage } from "../../../tickers/open-target";
 import { instrumentFromTicker } from "../../../market-data/request-types";
@@ -20,7 +21,7 @@ import {
   buildRelationshipGraphPaneTitle,
 } from "../../../plugins/builtin/correlation/relationship/model";
 import { buildQuoteMonitorPaneTitle } from "../../../plugins/builtin/ticker-detail/settings";
-import { getPaneTemplateDisplayLabel } from "../pane-templates/items";
+import { getPaneTemplateDisplayLabel, paneTemplateArgError } from "../pane-templates/items";
 import { automationActive, describeUsageFunction, recordFunctionOpen } from "../../../telemetry/usage-counts";
 import { attentionActionForPane, captureAttentionAction } from "../../../telemetry/attention-counts";
 import { publicTickerKey } from "../../../utils/exchanges";
@@ -101,13 +102,20 @@ async function resolvePaneTemplateOptions(
   resolvedOptions: PaneTemplateCreateOptions | undefined;
 }> {
   const state = deps.getState();
+  const focusedSymbol = getFocusedTickerSymbol(state);
+  // A required ticker follows the prompt, including a linked desk the focused
+  // pane does not hold. An optional ticker stays unbound unless one was named.
+  const requiresTicker = (template.shortcut?.argPlaceholder === "ticker" || template.shortcut?.argKind === "ticker")
+    && !template.shortcut?.argOptional;
+  const prompt = requiresTicker ? commandPromptTicker(state) : null;
+  const tickerRootId = prompt?.rootInstanceId ?? state.focusedPaneId;
   const baseContext: PaneTemplateContext = {
     config: state.config,
     layout: state.config.layout,
     focusedPaneId: state.focusedPaneId,
-    activeTicker: getFocusedTickerSymbol(state),
-    activeInstrument: state.focusedPaneId ? resolveInstrumentForPane(state, state.focusedPaneId)?.instrument : undefined,
-    activeListing: state.focusedPaneId ? resolveListingForPane(state, state.focusedPaneId) : undefined,
+    activeTicker: prompt?.symbol ?? focusedSymbol,
+    activeInstrument: tickerRootId ? resolveInstrumentForPane(state, tickerRootId)?.instrument : undefined,
+    activeListing: tickerRootId ? resolveListingForPane(state, tickerRootId) : undefined,
     activeCollectionId: getFocusedCollectionId(state),
   };
 
@@ -226,6 +234,12 @@ export async function createPaneTemplateOrThrow(
 
   const { context, resolvedOptions } = await resolvePaneTemplateOptions(template, options, deps);
 
+  // A name the function knows nothing of opens nothing, rather than its default view.
+  const argError = paneTemplateArgError(template, resolvedOptions?.arg, context);
+  if (argError) {
+    throw new Error(argError.detail ? `${argError.message}. ${argError.detail}.` : `${argError.message}.`);
+  }
+
   if (template.canCreate && !template.canCreate(context, resolvedOptions)) {
     throw new Error(uncoveredTemplateMessage(template, deps.pluginRegistry, resolvedOptions)
       ?? `Can't create ${getPaneTemplateDisplayLabel(template).toLowerCase()} right now.`);

package/src/components/command-bar/workflow/portfolio-position.ts

@@ -5,6 +5,10 @@ import { t, tf } from "../../../i18n";
 import { getManualPortfolioPositionPrefill, type ManualPortfolioPositionPrefill } from "../../../portfolio/manual-lots";
 import { isManualPortfolio, positionQuantityLabel, resolveManualPositionCurrency } from "../../../portfolio/mutations";
 import { futuresLotCurrency, isFuturesTicker } from "../../../portfolio/futures-positions";
+import { sameCurrency } from "../../../portfolio/position-metrics";
+import { resolvePortfolioTotalsCurrency } from "../../../portfolio/totals-currency";
+import type { TickerPosition } from "../../../types/ticker";
+import { DATE_FIELD_EXAMPLES } from "../../../utils/calendar-date";
 import { US_CENTS } from "../../../utils/currency-units";
 
 export interface SetPortfolioPositionWorkflowState {
@@ -24,12 +28,29 @@ interface ManualPortfolioPositionWorkflowOptions {
   hidePortfolioFieldWhenSingleOption?: boolean;
 }
 
+/**
+ * What the Purchase Date and Cost FX fields start from for a holding: its
+ * date (several lots, their earliest) and the rate its cost was bought at
+ * into the portfolio's currency (several, weighted by cost). Saving them
+ * unchanged keeps what the lots have; a rate into another currency is kept
+ * without being shown.
+ */
+export function positionCostTermsPrefill(position: TickerPosition | null | undefined, portfolioCurrency: string): { dateAcquired: string; costFx: string } {
+  const rate = position?.costFxRate;
+  const shown = typeof rate === "number" && Number.isFinite(rate) && rate > 0 && position?.costFxCurrency?.trim().toUpperCase() === portfolioCurrency;
+  // A cross rate carries float noise (0.012625500000000001): shown to ten digits, kept exact when left as it opened.
+  return { dateAcquired: position?.dateAcquired ?? "", costFx: shown ? String(Number(rate.toPrecision(10))) : "" };
+}
+
 /** Several lots become one position on save: say so, and what the fields hold. */
 function lotsReplacementHint(prefill: ManualPortfolioPositionPrefill, portfolioName: string): string | undefined {
   if (prefill.lotCount < 2) return undefined;
   const params = { count: prefill.lotCount, portfolio: portfolioName };
+  if (prefill.position && prefill.costFxConflict) {
+    return tf("Totals of your {count} lots in \"{portfolio}\", bought at FX rates one position cannot keep: give its Cost FX or Purchase Date. Saving replaces them with one position.", params);
+  }
   if (prefill.position) {
-    return tf("Totals of your {count} lots in \"{portfolio}\". Saving replaces them with one position and clears their acquisition dates.", params);
+    return tf("Totals of your {count} lots in \"{portfolio}\". Saving replaces them with one position, dated by the earliest.", params);
   }
   return prefill.currencies
     ? tf("{count} lots in \"{portfolio}\" are in different currencies ({currencies}), so none is filled in. Saving replaces them with one position.", {
@@ -56,6 +77,13 @@ function buildManualPortfolioPositionWorkflow(
   // A future's cost is typed as it is quoted, which for corn is cents: what a blank currency then saves.
   const contractCurrency = options.ticker && isFuturesTicker(options.ticker)
     && options.quoteCurrency?.trim().toUpperCase() === US_CENTS ? US_CENTS : undefined;
+  // What a blank currency saves, and the currency the portfolio values it in: the rate's units.
+  const blankCurrency = options.ticker
+    ? resolveManualPositionCurrency(undefined, options.ticker, preferredPortfolio, config.baseCurrency, contractCurrency)
+    : undefined;
+  const portfolioCurrency = resolvePortfolioTotalsCurrency(preferredPortfolio, config.baseCurrency);
+  const heldCurrency = (preferredPosition ? futuresLotCurrency(preferredPosition, contractCurrency) : undefined) ?? blankCurrency;
+  const costTerms = positionCostTermsPrefill(preferredPosition, portfolioCurrency);
 
   const fields: CommandBarWorkflowField[] = [
     ...(showPortfolioField ? [{
@@ -98,9 +126,28 @@ function buildManualPortfolioPositionWorkflow(
       type: "text",
       // What a blank field saves: the ticker's own currency before the
       // portfolio's. Without a ticker yet there is nothing true to show.
-      placeholder: options.ticker
-        ? resolveManualPositionCurrency(undefined, options.ticker, preferredPortfolio, config.baseCurrency, contractCurrency)
-        : undefined,
+      placeholder: blankCurrency,
+      required: false,
+    },
+    {
+      id: "dateAcquired",
+      label: "Purchase Date",
+      type: "text",
+      placeholder: DATE_FIELD_EXAMPLES,
+      required: false,
+    },
+    {
+      id: "costFx",
+      label: "Cost FX",
+      type: "number",
+      // What a blank field saves, as `position set` without --cost-fx does.
+      placeholder: t("The purchase date's close, else today's rate"),
+      // The rate's units, in context: the portfolio's currency per unit of the holding's.
+      description: heldCurrency && sameCurrency(heldCurrency, portfolioCurrency)
+        ? t("Only for a holding in another currency than the portfolio's.")
+        : heldCurrency
+          ? tf("{portfolio} per {holding} when bought.", { portfolio: portfolioCurrency, holding: heldCurrency })
+          : tf("{portfolio} per unit of the holding's currency when bought.", { portfolio: portfolioCurrency }),
       required: false,
     },
   ];
@@ -116,6 +163,8 @@ function buildManualPortfolioPositionWorkflow(
         : "",
     // A corn lot saved before contract sizes, in dollars, is read in cents: saving the form unchanged keeps it so.
     currency: (preferredPosition ? futuresLotCurrency(preferredPosition, contractCurrency) : undefined) ?? "",
+    dateAcquired: costTerms.dateAcquired,
+    costFx: costTerms.costFx,
   };
 
   return {

package/src/components/command-bar/workflow/submit.ts

@@ -158,8 +158,9 @@ export async function submitCommandBarWorkflow(options: {
           break;
         }
         case "add-portfolio": {
-          const shares = coerceFieldString(route.values.shares).trim();
-          if (!shares) {
+          // A purchase date or rate typed without a size is a position to set, whose missing size is then refused.
+          const position = ["shares", "dateAcquired", "costFx"].some((id) => coerceFieldString(route.values[id]).trim());
+          if (!position) {
             await collectionWorkflowActions.addTickerMembershipFromWorkflow(route.values);
           } else {
             await collectionWorkflowActions.setPortfolioPositionFromWorkflow(route.values);

package/src/components/command-bar/workflow/tickers.ts

@@ -1,3 +1,4 @@
+import { indexRootSuggestion } from "../../../tickers/index-roots";
 import type { Dispatch } from "react";
 import type { AppAction, AppState } from "../../../state/app/context";
 import type { AppTickerRepositoryPort } from "../../../core/app-service-ports";
@@ -203,7 +204,10 @@ export async function resolveTickerInputOrThrow(
 ): Promise<ResolvedTickerInput> {
   const resolved = await resolveTickerInput(rawInput, activeTicker, collectionId, deps, { ...options, throwUnresolved: true });
   if (!resolved) {
-    throw new Error(`No ticker match found for "${rawInput ?? activeTicker ?? ""}".`);
+    const typed = rawInput ?? activeTicker ?? "";
+    // A bare index root (VIX) is quoted as ^VIX, which the message offers.
+    const suggestion = indexRootSuggestion(typed.trim());
+    throw new Error(`No ticker match found for "${typed}".${suggestion ? ` ${suggestion}` : ""}`);
   }
   return resolved;
 }

package/src/components/company-logo.tsx

@@ -1,8 +1,11 @@
+import { createElement } from "react";
 import { Box, ImageSurface, Text, TextAttributes, useUiCapabilities } from "../ui";
 import { cloudLogoPath, type CloudLogoKind } from "../api-client/paths";
 import { getCloudApiBaseUrl } from "../api-client/request";
 import { resolveAssetDisplayKind } from "../market-data/market/format";
 import { colors } from "../theme/colors";
+import type { DataTableCell } from "./ui/data-table";
+import { LogoMark, type LogoMarkProps } from "./ui/logo-mark";
 
 export function resolveCompanyLogoSrc(input: {
   symbol: string;
@@ -14,6 +17,42 @@ export function resolveCompanyLogoSrc(input: {
   return path ? `${getCloudApiBaseUrl()}${path}` : null;
 }
 
+/** What a row's logo stands for: a company's listing or a coin. */
+export interface CompanyLogoSubject {
+  symbol: string;
+  /** `CRYPTO` draws the coin's logo; any other listing but cash and contracts, the company's. */
+  assetCategory?: string;
+  /** Its initial stands in while there is no logo; the symbol's without a name. */
+  name?: string | null;
+}
+
+/**
+ * A company's or a coin's logo on a `LogoMark` tile, on the desktop and the
+ * web: the logo Gloom Cloud serves for its ticker, and its initial on the
+ * same tile when there is none, so a missing logo moves nothing.
+ */
+export function CompanyLogoMark({ symbol, assetCategory, name, size }: CompanyLogoSubject & Pick<LogoMarkProps, "size">) {
+  return createElement(LogoMark, {
+    src: resolveCompanyLogoSrc({ symbol, assetCategory }),
+    name: name?.trim() || symbol,
+    size,
+    plate: true,
+  });
+}
+
+/**
+ * The cell that names a company or a coin in a table, led by its logo on the
+ * desktop and the web (docs/pane-conventions.md, "Company and coin logos").
+ * The terminal gets the cell as it was, and exports read only its text.
+ */
+export function withCompanyLogo(cell: DataTableCell, subject: CompanyLogoSubject | null | undefined, desktop: boolean): DataTableCell {
+  if (!desktop || !subject?.symbol) return cell;
+  return {
+    ...cell,
+    leading: createElement(CompanyLogoMark, { symbol: subject.symbol, assetCategory: subject.assetCategory, name: subject.name ?? cell.text }),
+  };
+}
+
 export function CompanyLogo({
   symbol,
   assetCategory,

package/src/components/data-table/sections.ts

@@ -12,6 +12,8 @@ import type { DataTableSectionHeader } from "../ui/data-table";
 
 export interface TableSection<T> {
   label: string;
+  /** Tells apart two sections under one label (a month split by today); the label by default. */
+  key?: string;
   items: T[];
   /** Kept even with no items, to show the section exists. */
   emptyLabel?: string;
@@ -32,9 +34,9 @@ export function buildSectionedRows<T>(
   return sections.flatMap((section) => {
     if (section.items.length === 0 && !section.emptyLabel) return [];
     return [
-      { kind: "section" as const, key: `section:${section.label}`, label: section.label, count: section.items.length },
+      { kind: "section" as const, key: `section:${section.key ?? section.label}`, label: section.label, count: section.items.length },
       ...(section.items.length === 0
-        ? [{ kind: "empty" as const, key: `empty:${section.label}`, label: section.emptyLabel! }]
+        ? [{ kind: "empty" as const, key: `empty:${section.key ?? section.label}`, label: section.emptyLabel! }]
         : section.items.map((item) => ({ kind: "item" as const, key: getItemKey(item), item }))),
     ];
   });

package/src/components/data-table/view.tsx

@@ -11,7 +11,7 @@ import {
 import type { ScrollBoxRenderable } from "../../ui";
 import { useBeforeShortcut, useShortcut } from "../../react/input";
 import { isPlainKey, isPlainKeyboardEvent } from "../../utils/keyboard";
-import { DataTable, type DataTableColumn, type DataTableProps } from "../ui";
+import { DataTable, PaneStatusBody, type DataTableColumn, type DataTableProps, type PaneStatusBodyProps } from "../ui";
 import { useDataTableSortMenu } from "./sort-menu";
 import {
   TableViewFrame,
@@ -89,6 +89,19 @@ export type DataTableSelection<T> =
       ) => void;
     };
 
+/**
+ * What the table's body shows instead of rows while it has none to show: its
+ * first page loading after a tab or filter change, a failed load, a state
+ * with nothing to list. The same states `PaneStatusBody` draws, in the
+ * table's place under `rootBefore`, so the query bar and figures above stay
+ * on screen (and a search field keeps its focus) while the body waits.
+ */
+export type DataTableBodyStatus = Omit<PaneStatusBodyProps, "children" | "width" | "height" | "align">;
+
+function bodyStatusShown(status: DataTableBodyStatus | undefined): status is DataTableBodyStatus {
+  return !!status && (!!status.error || status.loading === true || status.empty === true);
+}
+
 interface SelectionCommitTarget {
   index: number;
   id?: string;
@@ -124,6 +137,12 @@ export interface DataTableViewProps<
   isNavigable?: (item: T, index: number) => boolean;
   rootBefore?: ReactNode;
   rootAfter?: ReactNode;
+  /**
+   * Replaces the table (header and rows) with a loading, error or empty
+   * state while `rootBefore` stays. Precedence is the caller's, as with
+   * `PaneStatusBody`: pass `loading` only while there is nothing to show.
+   */
+  status?: DataTableBodyStatus;
   rootWidth?: number;
   rootHeight?: number;
   rootBackgroundColor?: string;
@@ -165,6 +184,7 @@ export function DataTableView<
   isNavigable,
   rootBefore,
   rootAfter,
+  status,
   rootWidth,
   rootHeight,
   rootBackgroundColor,
@@ -728,7 +748,7 @@ export function DataTableView<
       before={rootBefore}
       after={rootAfter}
     >
-      <DataTable<T, C>
+      {bodyStatusShown(status) ? <PaneStatusBody {...status} /> : <DataTable<T, C>
         {...tableProps}
         headerScrollRef={effectiveHeaderScrollRef}
         scrollRef={effectiveScrollRef}
@@ -741,7 +761,7 @@ export function DataTableView<
         onActivate={handleTableActivate}
         onRowMouseDown={handleRowMouseDown}
         onRowContextMenu={handleRowContextMenu}
-      />
+      />}
     </TableViewFrame>
   );
 }

package/src/components/form-modal/confirm.tsx

@@ -74,7 +74,8 @@ export function ConfirmModalContent({
       pendingRef.current = false;
       if (!mountedRef.current) {
         // Closed while it ran: the inline error has nowhere to go.
-        runtime.getDeps().pluginRegistry.notify({ body: errorMessage(failure), type: "error" });
+        if (confirm.onFailureAfterClose) confirm.onFailureAfterClose(failure);
+        else runtime.getDeps().pluginRegistry.notify({ body: errorMessage(failure), type: "error" });
         return;
       }
       setPending(false);

package/src/components/form-modal/request.ts

@@ -24,6 +24,11 @@ export interface ConfirmModalOptions {
    * when the confirm was closed before the work finished.
    */
   onSuccess?: () => void;
+  /**
+   * Says what `onConfirm` threw once the confirm was closed and cannot say it
+   * inline: on the row it concerns, say. A toast when missing.
+   */
+  onFailureAfterClose?: (failure: unknown) => void;
 }
 
 /**

package/src/components/form-modal/routes.ts

@@ -7,6 +7,7 @@ import {
   getFocusedTickerSymbol,
   type AppState,
 } from "../../state/app/context";
+import { commandPromptTicker } from "../../layout/selected-ticker";
 import type { CommandDef, PaneTemplateCreateOptions } from "../../types/plugin";
 import type { TickerRecord } from "../../types/ticker";
 import { buildPaneTemplateWorkflowRoute } from "../command-bar/pane-templates/workflow-route";
@@ -142,8 +143,10 @@ export function buildPaneTemplateFormRoute(
 ): FormRouteResult {
   const template = pluginRegistry.paneTemplates.get(templateId);
   if (!template) return { kind: "none" };
+  const requiresTicker = (template.shortcut?.argPlaceholder === "ticker" || template.shortcut?.argKind === "ticker")
+    && !template.shortcut?.argOptional;
   const route = buildPaneTemplateWorkflowRoute({
-    activeTicker: getFocusedTickerSymbol(state),
+    activeTicker: (requiresTicker ? commandPromptTicker(state)?.symbol : null) ?? getFocusedTickerSymbol(state),
     arg,
     template,
   });

package/src/components/index.ts

@@ -12,11 +12,11 @@ export { CompositeChart, pricePointsToResolvedSeries } from "./chart/composite";
 // Figures, then a chart, then a table: the header zone, its size rule at every
 // pane size, and the selection the chart and the table share.
 export {
-  ChartStrip, ChartTableHeader, chartTableChromeRows, chartTableLayout, formatBpAxis, formatPercentAxis,
-  spanAxisFormatter, spanDigits, useChartTableLayout, useChartTableSelection,
+  ChartRead, ChartStrip, ChartTableHeader, chartTableChromeRows, chartTableLayout, formatBpAxis, formatPercentAxis,
+  spanAxisFormatter, spanDigits, useChartReadRows, useChartTableLayout, useChartTableSelection,
 } from "./chart-table";
 export type {
-  ChartBandMode, ChartStripSpec, ChartTableChart, ChartTableHeaderProps, ChartTableLayout,
+  ChartBandMode, ChartReadProps, ChartStripSpec, ChartTableChart, ChartTableHeaderProps, ChartTableLayout,
   ChartTableSelection,
 } from "./chart-table";
 export { scalarPoint, stackedSeries, staticSeries, type StackedLayer } from "./chart/static/series";
@@ -67,6 +67,7 @@ export { usePagedRows } from "./paged-rows";
 export type { PageLoader, PageRequest, PagedRows, PagedRowsOptions, RowPage } from "./paged-rows";
 export { DataTableView } from "./data-table/view";
 export type {
+  DataTableBodyStatus,
   DataTableKeyEvent,
   DataTableRootKeyContext,
   DataTableSelectionChangeReason,
@@ -86,6 +87,11 @@ export { DataTableStackView } from "./data-table/stack-view";
 // table re-render on selection or scroll does not redo all of it.
 export { createRowValueCache } from "./ui/row-value-cache";
 export type { RowValueCache } from "./ui/row-value-cache";
+// What the last action on one row came to, kept for that row until the next
+// action on it or until its own status moves on (docs/pane-conventions.md,
+// "Row messages"): its status cell says it, never the footer or a toast.
+export { useRowNotes } from "./ui/row-notes";
+export type { RowNotes } from "./ui/row-notes";
 export { FeedDataTableStackView } from "./feed-data-table/stack-view";
 export type { FeedDataTableItem } from "./feed-data-table/stack-view";
 export { activeStackIndex, sortStackItems } from "./feed-stack-controller";
@@ -127,7 +133,8 @@ export { MarkdownText } from "./markdown-text";
 // this file is the public `gloomberb/components` surface: a kit component
 // reaches plugins only once it is added here.
 export {
-  ActionRow, Badge, BulletList, Button, ButtonActionScope, Card, Checkbox, ChoiceDialog, ColumnGrid, ColumnGridPair, ConfirmDialog, confirmDialog, DataTable,
+  ActionRow, Badge, BulletList, Button, ButtonActionScope, Card, Checkbox, ChoiceDialog, ColumnGrid, ColumnGridPair, ConfirmDialog, confirmDialog,
+  COUNTRY_FLAG_CELLS, CountryFlag, CountryFlagLead, DataTable,
   DetailScrollBody, DialogFrame, DisclosureMarker, Divider, EmptyState, ExternalLink, ExternalLinkText, FieldGrid, FieldLabel,
   fieldFrameStyle, fieldGridColumns, FRAMED_TEXTAREA_DESKTOP_STYLE, fieldGridRows, FigureList, getMessageComposerBlockHeight, GridFieldView, Icon, ICON_GLYPHS,
   IconButton, InlineQuickAddRow, KeyValueRow, ListView, loadingText, Menu, MenuPopover,
@@ -135,11 +142,11 @@ export {
   NumberPromptDialog, openUrl, PageStackView, PaneLinkMenu, PaneStatusBody, Popover, Prose,
   QueryBar, RangeTrack, RatioBar, READING_WIDTH, RemoteImage, Section, SectionHeading, SegmentedControl, SelectButton, ShortcutHint,
   Spinner, StatGrid, statGridColumns, statGridRows, Tabs, TextField, TextPromptDialog, unavailableText,
-  useFieldRing, usePaneLinkMenuEntry, useQueryBarSearch,
+  useFieldRing, usePaneLinkMenuEntry, useQueryBarSearch, withCountryFlag, withFlagRoom,
 } from "./ui";
 export type {
   ActionRowProps, BadgeProps, BulletListProps, ButtonProps, ButtonVariant, CardProps, CheckboxProps, ChoiceDialogChoice, ColumnGridCell,
-  ColumnGridColumn, ColumnGridPairProps, ColumnGridProps, ConfirmDialogOptions,
+  ColumnGridColumn, ColumnGridLink, ColumnGridPairProps, ColumnGridProps, ConfirmDialogOptions, CountryFlagProps,
   DataTableCell, DataTableColumn, DataTableProps, DataTableVisibleRange, DetailScrollBodyProps, DialogFrameProps,
   DisclosureMarkerProps, DividerProps, EmptyStateProps, FieldGridProps, FieldLabelProps, FieldRing, FieldRingOptions,
   FigureListItem, FigureListProps, GridField,

package/src/components/layout/detached-pane-shell.tsx

@@ -441,6 +441,7 @@ export function DetachedPaneShell({ pluginRegistry, desktopWindowBridge }: Detac
                 onMouseDown: () => toggleQuickSetting(setting.key),
               }))}
               tabs={headerTabs}
+              bodyBackground={background}
               titleBar={{
                 rows: headerHeightRows,
                 overlay: titleBarOverlay === true,

package/src/components/layout/floating-pane.tsx

@@ -143,6 +143,7 @@ export function FloatingPaneWrapper({
         showActions={showActions}
         quickSettings={quickSettings}
         tabs={headerTabs}
+        bodyBackground={bg}
         topRule
         onHeaderMouseMove={onHeaderMouseMove}
         onHeaderMouseDown={onHeaderMouseDown}