gloomberb 0.18.2 → 0.18.4

package/src/plugins/builtin/backtest/rules.ts

@@ -14,9 +14,11 @@ export interface BacktestBar {
 export type Operand =
   | { kind: "number"; value: number }
   | { kind: "field"; field: "close" | "open" | "high" | "low" }
+  | { kind: "calendar"; name: CalendarName }
   | { kind: "indicator"; name: IndicatorName; args: number[] };
 type IndicatorName = "sma" | "ema" | "rsi" | "macd" | "macd_signal" | "bb_upper" | "bb_lower" | "highest" | "lowest";
-type Comparator = ">" | "<" | ">=" | "<=" | "crosses above" | "crosses below";
+type CalendarName = "weekday" | "day_of_month";
+type Comparator = ">" | "<" | ">=" | "<=" | "==" | "!=" | "crosses above" | "crosses below";
 interface Condition { left: Operand; comparator: Comparator; right: Operand }
 /** Conditions are ANDed. */
 export type Rule = Condition[];
@@ -35,6 +37,11 @@ const INDICATORS: Record<IndicatorName, IndicatorSpec> = {
   lowest: { defaults: [20], bounds: [PERIOD], usage: "lowest(n)" },
 };
 const FIELDS = new Set(["close", "open", "high", "low"]);
+/** The session's UTC calendar date as a number, so a rule can trade a day of the week or of the month. */
+const CALENDAR: Record<CalendarName, { min: number; max: number; values: string; of: (date: Date) => number }> = {
+  weekday: { min: 1, max: 7, values: "1 Monday to 7 Sunday", of: (date) => (date.getUTCDay() + 6) % 7 + 1 },
+  day_of_month: { min: 1, max: 31, values: "1 to 31", of: (date) => date.getUTCDate() },
+};
 const COMPARATORS: Array<[RegExp, Comparator]> = [
   [/^crosses\s+above$/, "crosses above"],
   [/^crosses\s+below$/, "crosses below"],
@@ -42,16 +49,29 @@ const COMPARATORS: Array<[RegExp, Comparator]> = [
   [/^(<|below)$/, "<"],
   [/^>=$/, ">="],
   [/^<=$/, "<="],
+  [/^==?$/, "=="],
+  [/^!=$/, "!="],
 ];
 
+/** Every operand a rule takes, as an error and `--help` list them. */
+const RULE_OPERANDS = [
+  "close", "open", "high", "low", "a number",
+  ...Object.entries(CALENDAR).map(([name, entry]) => `${name} (${entry.values})`),
+  ...Object.values(INDICATORS).map((entry) => entry.usage),
+].join(", ");
+const RULE_COMPARISONS = ">, <, >=, <=, ==, !=, crosses above, crosses below";
+/** What a rule is written from, for a message that sends the reader back to the syntax. */
+export const RULE_SYNTAX = `Operands: ${RULE_OPERANDS}. Comparisons: ${RULE_COMPARISONS}. Join conditions with "and".`;
+
 function parseOperand(text: string): Operand {
   const value = text.trim().toLowerCase();
   if (/^[+-]?(\d+(\.\d*)?|\.\d+)$/.test(value)) return { kind: "number", value: Number(value) };
   if (FIELDS.has(value)) return { kind: "field", field: value as "close" };
+  if (Object.hasOwn(CALENDAR, value)) return { kind: "calendar", name: value as CalendarName };
   const match = /^([a-z_]+)\s*(?:\(([^)]*)\))?$/.exec(value);
   const name = match?.[1] as IndicatorName | undefined;
   const spec = name ? INDICATORS[name] : undefined;
-  if (!match || !name || !spec) throw new Error(`Unknown operand "${text.trim()}". Use close, open, high, low, a number or ${Object.values(INDICATORS).map((entry) => entry.usage).join(", ")}.`);
+  if (!match || !name || !spec) throw new Error(`Unknown operand "${text.trim()}". Use ${RULE_OPERANDS}.`);
   const given = match[2]?.trim() ? match[2].split(",").map((part) => part.trim()) : [];
   if (given.length > spec.defaults.length) throw new Error(`${spec.usage} takes at most ${spec.defaults.length} values.`);
   const args = spec.defaults.map((fallback, index) => {
@@ -72,12 +92,19 @@ export function parseRule(text: string): Rule {
   const source = text.trim();
   if (!source) throw new Error("Enter a rule, for example: sma(50) crosses above sma(200)");
   return source.split(/\s+and\s+/i).map((part) => {
-    const match = /^(.+?)\s+(crosses\s+above|crosses\s+below|>=|<=|>|<|above|below)\s+(.+)$/i.exec(part.trim());
-    if (!match) throw new Error(`Cannot read "${part.trim()}". Write <operand> <comparison> <operand>, for example close > sma(200).`);
+    const match = /^(.+?)\s+(crosses\s+above|crosses\s+below|>=|<=|==|!=|=|>|<|above|below)\s+(.+)$/i.exec(part.trim());
+    if (!match) throw new Error(`Cannot read "${part.trim()}". Write <operand> <comparison> <operand>, for example close > sma(200). ${RULE_SYNTAX}`);
     const comparator = COMPARATORS.find(([pattern]) => pattern.test(match[2]!.toLowerCase().replace(/\s+/g, " ")))![1];
     const left = parseOperand(match[1]!);
     const right = parseOperand(match[3]!);
-    if (left.kind === "number" && right.kind === "number") throw new Error("Compare at least one price or indicator.");
+    if (left.kind === "number" && right.kind === "number") throw new Error("Compare at least one price, date or indicator.");
+    for (const [calendar, other] of [[left, right], [right, left]] as const) {
+      if (calendar.kind !== "calendar" || other.kind !== "number") continue;
+      const { min, max, values } = CALENDAR[calendar.name];
+      if (!Number.isInteger(other.value) || other.value < min || other.value > max) {
+        throw new Error(`${calendar.name} is ${values}, not ${other.value}.`);
+      }
+    }
     return { left, comparator, right };
   });
 }
@@ -105,6 +132,13 @@ export function evaluateOperand(operand: Operand, bars: readonly BacktestBar[]):
   const length = bars.length;
   if (operand.kind === "number") return new Float64Array(length).fill(operand.value);
   if (operand.kind === "field") return Float64Array.from(bars, (bar) => bar[operand.field] ?? Number.NaN);
+  if (operand.kind === "calendar") {
+    // A session's date is its UTC calendar day; a bar without a readable one has no weekday.
+    return Float64Array.from(bars, (bar) => {
+      const time = Date.parse(`${bar.date.slice(0, 10)}T00:00:00Z`);
+      return Number.isFinite(time) ? CALENDAR[operand.name].of(new Date(time)) : Number.NaN;
+    });
+  }
   const closes = bars.map((bar) => bar.close);
   const [a = 0, b = 0, c = 0] = operand.args;
   switch (operand.name) {
@@ -161,6 +195,8 @@ export function evaluateRule(rule: Rule, bars: readonly BacktestBar[]): boolean[
       else if (condition.comparator === "<") met = l < r;
       else if (condition.comparator === ">=") met = l >= r;
       else if (condition.comparator === "<=") met = l <= r;
+      else if (condition.comparator === "==") met = l === r;
+      else if (condition.comparator === "!=") met = l !== r;
       else {
         const pl = left[index - 1], pr = right[index - 1];
         met = pl !== undefined && pr !== undefined && !Number.isNaN(pl) && !Number.isNaN(pr)

package/src/plugins/builtin/broker-manager/add-flow.tsx

@@ -2,6 +2,7 @@ import { useCallback, useEffect, useMemo, useRef, useState, useSyncExternalStore
 import { apiClient } from "../../../api-client";
 import {
   brokerMethodLabel,
+  brokerDirectorySummary,
   brokerMethodSummary,
   buildBrokerDirectory,
   type BrokerDirectoryEntry,
@@ -39,7 +40,7 @@ import { isPlainKey } from "../../../utils/keyboard";
 import { usePluginAppActions, usePluginBrokerActions } from "../../runtime";
 import { BrokerProfileForm, profileFieldWidth, type BrokerEditKey } from "./detail";
 import { useBrokerManagerKeyboard } from "./keyboard";
-import type { BrokerManagerMessage } from "./pane-actions";
+import type { BrokerManagerMessage, BrokerRowNote } from "./pane-actions";
 
 /**
  * Adding a profile, one step at a time in the pane's detail: the broker, how
@@ -84,10 +85,13 @@ let attemptSequence = 0;
 export function useBrokerAddFlow({
   setBusy,
   setMessage,
+  setRowNote,
   onProfileAdded,
 }: {
   setBusy: (busy: string | null) => void;
   setMessage: (message: BrokerManagerMessage | null) => void;
+  /** Says on the new profile's row why its first sync failed. */
+  setRowNote: (profileId: string, note: BrokerRowNote | null) => void;
   /** Lands the pane on the profile the flow made, with the flow closed. */
   onProfileAdded: (instanceId: string) => void;
 }) {
@@ -95,7 +99,7 @@ export function useBrokerAddFlow({
   const dispatch = useAppDispatch();
   const getState = useAppGetState();
   const { notify } = usePluginAppActions();
-  const { listBrokerAdapters, createBrokerInstance, syncBrokerInstance } = usePluginBrokerActions();
+  const { listBrokerAdapters, createBrokerInstance, updateBrokerInstance, syncBrokerInstance } = usePluginBrokerActions();
   const [flow, setFlowState] = useState<BrokerAddFlowState | null>(null);
   // Async work reads the flow as it is now, not as it was when it started.
   const flowRef = useRef<BrokerAddFlowState | null>(null);
@@ -165,13 +169,13 @@ export function useBrokerAddFlow({
       if (portfolio) showCollectionInPortfolioPane(state, dispatch, portfolio.id);
       notify({ body: t("Connected! Positions will sync automatically."), type: "success" });
     } catch (error) {
-      // The profile stays: its detail and the footer say why it did not sync.
+      // The profile stays: its row says why it did not sync.
       land();
-      setMessage({ tone: "error", text: errorText(error, tf("Failed to sync {label}.", { label })) });
+      setRowNote(instanceId, { tone: "error", status: t("Sync failed"), text: errorText(error, tf("Failed to sync {label}.", { label })) });
     } finally {
       setBusy(null);
     }
-  }, [dispatch, getState, notify, onProfileAdded, setBusy, setFlow, setMessage, syncBrokerInstance]);
+  }, [dispatch, getState, notify, onProfileAdded, setBusy, setFlow, setRowNote, syncBrokerInstance]);
 
   const connectDevice = useCallback(async () => {
     const current = flowRef.current;
@@ -240,6 +244,7 @@ export function useBrokerAddFlow({
         connected = await connectSignedInBrokerProfile(broker, {
           getConfig: () => getState().config,
           createBrokerInstance,
+          enableBrokerInstance: (instanceId) => updateBrokerInstance(instanceId, {}, { enabled: true }),
           // The first sync runs below, with its progress in the pane.
           syncBrokerInstance: async () => {},
           // Gloom's sign-in over the pane when needed, again after a session Gloom refused.
@@ -278,7 +283,7 @@ export function useBrokerAddFlow({
     } finally {
       if (committing) committingRef.current = false;
     }
-  }, [createBrokerInstance, dialog, getState, setMessage, setStep, showAttempt, syncNewProfile]);
+  }, [createBrokerInstance, dialog, getState, setMessage, setStep, showAttempt, syncNewProfile, updateBrokerInstance]);
 
   const chooseMethod = useCallback((entry: BrokerDirectoryEntry, method: BrokerMethod) => {
     const current = flowRef.current;
@@ -384,7 +389,7 @@ export function BrokerAddFlowContent({
           label: entry.name,
           // The desktop says how it connects under the name, beside its logo.
           ...(desktop
-            ? { description: brokerMethodSummary(entry), leading: <LogoMark src={brokerDirectoryLogo(entry, getBrokerLogo)} name={entry.name} size="lead" /> }
+            ? { description: brokerDirectorySummary(entry), leading: <LogoMark src={brokerDirectoryLogo(entry, getBrokerLogo)} name={entry.name} size="lead" /> }
             : { detail: brokerMethodSummary(entry) }),
         }))}
         rowDescriptions={desktop}

package/src/plugins/builtin/broker-manager/detail.tsx

@@ -1,6 +1,7 @@
-import { useRef } from "react";
+import { useEffect, useRef, type Ref } from "react";
 import { Box, ScrollBox, Text, TextAttributes, type BoxRenderable, type ScrollBoxRenderable } from "../../../ui";
 import { Button, FieldLabel, NumberField, SectionHeading, SegmentedControl, TextField, useFieldRing } from "../../../components";
+import { afterLayout, revealInScrollBox } from "../../../components/ui/reveal-in-scroll-box";
 import {
   PRESERVED_PASSWORD_HINT,
   type BrokerProfileDraft,
@@ -13,9 +14,9 @@ import { formatRelativeAge } from "../../../utils/datetime-format";
 import { formatCurrency, truncateToDisplayWidth } from "../../../utils/format";
 import { t, tf } from "../../../i18n";
 import type { BrokerProfileRow } from "./model";
-import type { BrokerManagerMessage } from "./pane-actions";
+import type { BrokerRowActivity } from "./pane-actions";
 import { signInEndNote } from "./sign-in-end";
-import { stateColor } from "./table";
+import { brokerRowStatus } from "./table";
 
 export type BrokerEditKey = "label" | "enabled" | "localOnly" | string;
 
@@ -88,9 +89,10 @@ function BrokerConfigFieldEditor({
   );
 }
 
+/** An account by the name its broker gives it, as its portfolio is named; its id when it has none. */
 function accountDetail(account: BrokerAccount): string {
   const parts = [
-    account.accountId,
+    account.name?.trim() || account.accountId,
     account.netLiquidation != null ? tf("{value} net liq", { value: formatCurrency(account.netLiquidation, account.currency || "") }) : null,
     account.buyingPower != null ? tf("{value} buying power", { value: formatCurrency(account.buyingPower, account.currency || "") }) : null,
   ];
@@ -112,6 +114,8 @@ export function BrokerProfileForm({
   scope,
   paneFocused,
   submitLabel,
+  error,
+  actionsRef,
   rowRef,
   onActiveKeyChange,
   onLabelChange,
@@ -134,6 +138,10 @@ export function BrokerProfileForm({
   /** The form's fields take keys only while the pane has the keyboard. */
   paneFocused: boolean;
   submitLabel: string;
+  /** What stopped the last submit, said beside the buttons. */
+  error?: string | null;
+  /** The error and the buttons, for the detail to scroll into view when the error shows. */
+  actionsRef?: Ref<BoxRenderable>;
   /** Each field's outer box, for the form's field ring to scroll into view. */
   rowRef: (key: BrokerEditKey) => RowRef;
   onActiveKeyChange: (key: BrokerEditKey) => void;
@@ -209,9 +217,12 @@ export function BrokerProfileForm({
           </Text>
         ) : null}
       </Box>
-      <Box flexDirection="row" gap={1}>
-        <Button label={submitLabel} shortcut="Enter" variant="primary" onPress={onSubmit} disabled={!!busy} />
-        <Button label={t("Cancel")} shortcut="Esc" variant="secondary" onPress={onCancel} disabled={!!busy} />
+      <Box ref={actionsRef} flexDirection="column">
+        {error ? <Text fg={colors.negative} width={width} wrapText>{error}</Text> : null}
+        <Box flexDirection="row" gap={1}>
+          <Button label={submitLabel} shortcut="Enter" variant="primary" onPress={onSubmit} disabled={!!busy} />
+          <Button label={t("Cancel")} shortcut="Esc" variant="secondary" onPress={onCancel} disabled={!!busy} />
+        </Box>
       </Box>
     </>
   );
@@ -230,7 +241,8 @@ export function BrokerDetailContent({
   activeEditKey,
   editKeys,
   busy,
-  message,
+  activity,
+  editError,
   width,
   editScope,
   paneFocused,
@@ -250,7 +262,10 @@ export function BrokerDetailContent({
   /** The edit form's fields in Tab order. */
   editKeys: readonly BrokerEditKey[];
   busy: string | null;
-  message: BrokerManagerMessage | null;
+  /** The pane's action running on this profile, and what the last one came to. */
+  activity: BrokerRowActivity;
+  /** What stops the edit form from saving. */
+  editError: string | null;
   width: number;
   /** The edit form's shortcut scope, shared with the pane's field ring. */
   editScope: string;
@@ -276,29 +291,40 @@ export function BrokerDetailContent({
     wrap: true,
     scrollRef,
   });
+  // Enter saves from any field, so what stopped the save can be below the
+  // fold; bring it and the buttons into view.
+  const actionsRef = useRef<BoxRenderable | null>(null);
+  useEffect(() => {
+    if (!editError) return;
+    return afterLayout(() => revealInScrollBox(scrollRef.current, actionsRef.current));
+  }, [editError]);
 
   if (!row) return <Box flexGrow={1} />;
 
-  // A failed action outranks the profile's own status until the next action.
-  const actionError = message?.tone === "error" ? message.text : null;
-  const detailStatusMessage = actionError ?? (row.message || t("No status message."));
+  // The row's STATUS, and in full what the last action on the profile came to,
+  // which outranks the profile's own status message until it is news no more.
+  // The sign-in's end has a line of its own below.
+  const status = brokerRowStatus({ ...row, signInEndsAt: null }, activity);
+  const note = activity.note ?? null;
+  const detailStatusMessage = note?.text ?? (row.message || t("No status message."));
+  const statusMessageColor = note
+    ? note.tone === "error" ? colors.negative : colors.textDim
+    : row.state === "error" ? colors.negative
+      : row.state === "sign-in" || row.state === "disabled" ? colors.warning
+        : colors.textDim;
   const editAdapter = row.adapter;
 
   return (
     <ScrollBox ref={scrollRef} flexGrow={1} scrollY>
       <Box flexDirection="column" paddingX={1}>
         {/* The stack title already names the profile; the body starts with its state. */}
-        <Text fg={stateColor(row.state)} attributes={TextAttributes.BOLD}>
-          {truncateToDisplayWidth(row.stateLabel, width)}
+        <Text fg={status.color} attributes={TextAttributes.BOLD}>
+          {truncateToDisplayWidth(status.text, width)}
         </Text>
         <Text fg={colors.textDim}>
           {truncateToDisplayWidth(`${row.brokerName} · ${row.mode} · ${row.id}`, width)}
         </Text>
-        <Text
-          fg={actionError || row.state === "error" ? colors.negative : colors.textDim}
-          width={width}
-          wrapText
-        >
+        <Text fg={statusMessageColor} width={width} wrapText>
           {detailStatusMessage}
         </Text>
         {row.signInEndsAt !== null && (
@@ -323,6 +349,8 @@ export function BrokerDetailContent({
               scope={editScope}
               paneFocused={paneFocused}
               submitLabel={t("Save")}
+              error={editError}
+              actionsRef={actionsRef}
               rowRef={rowRef}
               onActiveKeyChange={onActiveEditKeyChange}
               onLabelChange={onDraftLabelChange}

package/src/plugins/builtin/broker-manager/footer.ts

@@ -1,9 +1,11 @@
 import { useMemo, useRef } from "react";
 import { usePaneFooter, type PaneFooterSegment, type PaneHint } from "../../../components";
+import { enableBrokerHint } from "../shared/broker-reconnect";
 import type { BrokerManagerMessage } from "./pane-actions";
 
 interface BrokerManagerFooterActions {
   connectSelected: () => Promise<void>;
+  enableSelected: () => Promise<void>;
   startAdd: () => void;
   openProfileAction: () => void;
   removeSelected: () => void;
@@ -15,21 +17,30 @@ interface BrokerManagerFooterActions {
 export function useBrokerManagerFooter({
   actions,
   busy,
+  paneBusy,
   canOpenSelectedAction,
   canRemoveSelected,
   canUseSelectedBroker,
+  disabledSelected,
   editing,
   message,
 }: {
   actions: BrokerManagerFooterActions;
   /** What is running right now, or null. */
   busy: string | null;
+  /** What is running that has no row to show it on: adding a profile. */
+  paneBusy: string | null;
   canOpenSelectedAction: boolean;
   canRemoveSelected: boolean;
   canUseSelectedBroker: boolean;
+  /**
+   * The selected profile is turned off, so it is never connected or synced:
+   * its broker's name for `[b] enable`, which turns it back on.
+   */
+  disabledSelected: string | null;
   /** Editing a profile or adding one. */
   editing: boolean;
-  /** The last result of an action, or null. */
+  /** The last result that is the whole pane's, or null. */
   message: BrokerManagerMessage | null;
 }) {
   const actionsRef = useRef(actions);
@@ -44,11 +55,16 @@ export function useBrokerManagerFooter({
       { id: "add", key: "a", label: "dd", onPress: () => actionsRef.current.startAdd() },
     ];
     if (canUseSelectedBroker) {
-      hints.push(
-        { id: "edit", key: "e", label: "dit", onPress: () => actionsRef.current.startEdit() },
-        { id: "connect", key: "c", label: "onnect", onPress: () => actionsRef.current.connectSelected().catch(() => {}) },
-        { id: "sync", key: "s", label: "ync", onPress: () => actionsRef.current.syncSelected().catch(() => {}) },
-      );
+      hints.push({ id: "edit", key: "e", label: "dit", onPress: () => actionsRef.current.startEdit() });
+      if (disabledSelected === null) {
+        hints.push(
+          { id: "connect", key: "c", label: "onnect", onPress: () => actionsRef.current.connectSelected().catch(() => {}) },
+          { id: "sync", key: "s", label: "ync", onPress: () => actionsRef.current.syncSelected().catch(() => {}) },
+        );
+      }
+    }
+    if (disabledSelected !== null && !busy) {
+      hints.push(enableBrokerHint(disabledSelected, () => { void actionsRef.current.enableSelected(); }));
     }
     if (canOpenSelectedAction) {
       hints.push({ id: "open", key: "o", label: "pen", onPress: () => actionsRef.current.openProfileAction() });
@@ -57,14 +73,14 @@ export function useBrokerManagerFooter({
       hints.push({ id: "disconnect", key: "d", label: "isconnect", onPress: () => actionsRef.current.removeSelected() });
     }
     return hints;
-  }, [canOpenSelectedAction, canRemoveSelected, canUseSelectedBroker, editing]);
+  }, [busy, canOpenSelectedAction, canRemoveSelected, canUseSelectedBroker, disabledSelected, editing]);
 
-  // The pane's rows already say which profiles exist and how they are doing,
-  // so the footer carries only what changes: the running action and its result.
+  // An action on one profile, and what it came to, is said on that profile's
+  // row. The footer carries only the pane's own: adding a profile.
   const info = useMemo<PaneFooterSegment[]>(() => [
-    ...(busy ? [{ id: "busy", parts: [{ text: busy, tone: "muted" as const }] }] : []),
+    ...(paneBusy ? [{ id: "busy", parts: [{ text: paneBusy, tone: "muted" as const }] }] : []),
     ...(message ? [{ id: "message", parts: [{ text: message.text, tone: message.tone === "error" ? "negative" as const : "muted" as const }] }] : []),
-  ], [busy, message]);
+  ], [message, paneBusy]);
 
   usePaneFooter("broker-manager", () => ({
     info,

package/src/plugins/builtin/broker-manager/index.tsx

@@ -118,17 +118,24 @@ export function BrokersPane({ focused, width, height }: PaneProps) {
 
   const {
     busy,
+    paneBusy,
     message,
+    editError,
+    rowActivity,
     setBusy,
     setMessage,
+    setRowNote,
     startEdit,
+    cancelEdit,
     saveEdit,
     connectSelected,
+    enableSelected,
     syncSelected,
     selectedProfileActions,
     openProfileAction,
     removeSelected,
   } = useBrokerManagerActions({
+    rows,
     selectedRow,
     editDraft,
     setEditDraft,
@@ -143,7 +150,7 @@ export function BrokersPane({ focused, width, height }: PaneProps) {
     setEditDraft(null);
     setDetailOpen(false);
   }, [setDetailOpen, setSelectedId]);
-  const addFlow = useBrokerAddFlow({ setBusy, setMessage, onProfileAdded: selectAddedProfile });
+  const addFlow = useBrokerAddFlow({ setBusy, setMessage, setRowNote, onProfileAdded: selectAddedProfile });
   const adding = addFlow.flow !== null;
   const { start: startAddFlow } = addFlow;
   const startAdd = useCallback(() => {
@@ -180,13 +187,14 @@ export function BrokersPane({ focused, width, height }: PaneProps) {
   const canUseSelectedBroker = selectedHasAdapter && !busy;
   const canOpenSelectedAction = selectedProfileActions.some((action) => !action.disabled && action.paneId);
   const canRemoveSelected = hasSelectedRow && !busy;
-  const cancelEdit = useCallback(() => setEditDraft(null), []);
 
   useBrokerManagerFooter({
     busy,
+    paneBusy,
     message,
     actions: {
       connectSelected,
+      enableSelected,
       openProfileAction,
       removeSelected,
       saveEdit,
@@ -197,6 +205,7 @@ export function BrokersPane({ focused, width, height }: PaneProps) {
     canOpenSelectedAction,
     canRemoveSelected,
     canUseSelectedBroker,
+    disabledSelected: selectedRow?.instance.enabled === false ? selectedRow.brokerName : null,
     editing: !!editDraft || adding,
   });
 
@@ -231,22 +240,20 @@ export function BrokersPane({ focused, width, height }: PaneProps) {
   const columns = useMemo(() => buildBrokerColumns(tableWidth), [language, tableWidth]);
 
   const renderCell = useCallback(
-    (row: BrokerProfileRow, column: BrokerColumn) => renderBrokerCell(row, column, desktop),
-    [desktop],
+    (row: BrokerProfileRow, column: BrokerColumn) => renderBrokerCell(row, column, desktop, rowActivity(row)),
+    [desktop, rowActivity],
   );
 
   const openSelectedDetail = useCallback((_index: number, row: BrokerProfileRow) => {
     setSelectedId(row.id);
-    setEditDraft(null);
+    cancelEdit();
     setDetailOpen(true);
-  }, [setDetailOpen, setSelectedId]);
+  }, [cancelEdit, setDetailOpen, setSelectedId]);
 
   const selectBrokerRow = useCallback((_index: number, row: BrokerProfileRow) => {
     setSelectedId(row.id);
-    if (selectedRow?.id !== row.id) {
-      setEditDraft(null);
-    }
-  }, [selectedRow?.id, setSelectedId]);
+    if (selectedRow?.id !== row.id) cancelEdit();
+  }, [cancelEdit, selectedRow?.id, setSelectedId]);
 
   const updateDraftValue = useCallback((key: string, value: string) => {
     setEditDraft((current) => current
@@ -291,7 +298,8 @@ export function BrokersPane({ focused, width, height }: PaneProps) {
       activeEditKey={activeEditKey}
       editKeys={editKeys}
       busy={busy}
-      message={message}
+      activity={selectedRow ? rowActivity(selectedRow) : {}}
+      editError={editError}
       width={detailContentWidth}
       editScope={editScope}
       paneFocused={focused}
@@ -312,7 +320,7 @@ export function BrokersPane({ focused, width, height }: PaneProps) {
           focused={focused}
           detailOpen={adding || (detailOpen && !!selectedRow)}
           onBack={adding ? addFlow.leave : () => {
-            setEditDraft(null);
+            cancelEdit();
             setDetailOpen(false);
           }}
           detailContent={detailContent}
@@ -352,6 +360,7 @@ export const brokerManagerModule: PluginModule = {
       personalData: "account",
       icon: "B",
       component: BrokersPane,
+      reportFreshness: { status: "not-a-feed", basis: "broker connections" },
       defaultPosition: "right",
       defaultMode: "floating",
       defaultFloatingSize: { width: 92, height: 24 },

package/src/plugins/builtin/broker-manager/keyboard.ts

@@ -4,7 +4,7 @@ import type { BrokerEditKey } from "./detail";
 
 /**
  * The edit form's keys beside its field ring (the detail's useFieldRing walks
- * the fields). The list and detail actions (a, e, c, s, o, d) are footer
+ * the fields). The list and detail actions (a, e, c, s, b, o, d) are footer
  * hints, which bind their own keys, and the table opens a row on Enter, so
  * only editing needs keys of its own.
  *

package/src/plugins/builtin/broker-manager/model.ts

@@ -10,6 +10,8 @@ export type BrokerDisplayState =
   | "disabled"
   | "unavailable"
   | "configured"
+  /** An error only a new sign-in clears. */
+  | "sign-in"
   | BrokerConnectionStatus["state"];
 
 export interface BrokerProfileRow {
@@ -78,7 +80,12 @@ function resolveState(
   status: BrokerConnectionStatus | null,
 ): { state: BrokerDisplayState; label: string; message: string; updatedAt: number } {
   if (instance.enabled === false) {
-    return { state: "disabled", label: t("Disabled"), message: t("Profile is disabled"), updatedAt: 0 };
+    return {
+      state: "disabled",
+      label: t("Disabled"),
+      message: t("Gloom does not connect or sync this profile while it is disabled."),
+      updatedAt: 0,
+    };
   }
   if (!adapter) {
     return { state: "unavailable", label: t("Unavailable"), message: t("Broker plugin is not available"), updatedAt: 0 };
@@ -95,6 +102,9 @@ function resolveState(
     return { state: "configured", label: t("Configured"), message: t("Ready to test or sync"), updatedAt: 0 };
   }
 
+  if (status.state === "error" && status.needsSignIn) {
+    return { state: "sign-in", label: t("Sign-in needed"), message: status.message || "", updatedAt: status.updatedAt };
+  }
   const labels: Record<BrokerConnectionStatus["state"], string> = {
     disconnected: t("Disconnected"),
     connecting: t("Connecting"),
@@ -148,7 +158,7 @@ export function buildBrokerProfileRows(
       accountSummary: summarizeBrokerAccounts(accounts),
       accountIds: accounts.map((account) => account.accountId),
       // Say nothing next to a failure or a profile that does not connect.
-      signInEndsAt: state.state === "error" || state.state === "disabled" || state.state === "unavailable"
+      signInEndsAt: state.state === "error" || state.state === "sign-in" || state.state === "disabled" || state.state === "unavailable"
         ? null
         : signInEnds.get(instance.id) ?? null,
       logo: brokerProfileLogo(instance, adapter, pluginLogo),