eslint 8.39.0 → 8.47.0

package/lib/rules/no-implicit-globals.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow declarations in the global scope",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-implicit-globals"
+            url: "https://eslint.org/docs/latest/rules/no-implicit-globals"
         },
 
         schema: [{
@@ -43,7 +43,7 @@ module.exports = {
     create(context) {
 
         const checkLexicalBindings = context.options[0] && context.options[0].lexicalBindings === true;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports the node.

package/lib/rules/no-implied-eval.js

@@ -24,7 +24,7 @@ module.exports = {
         docs: {
             description: "Disallow the use of `eval()`-like methods",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-implied-eval"
+            url: "https://eslint.org/docs/latest/rules/no-implied-eval"
         },
 
         schema: [],
@@ -37,7 +37,7 @@ module.exports = {
     create(context) {
         const GLOBAL_CANDIDATES = Object.freeze(["global", "window", "globalThis"]);
         const EVAL_LIKE_FUNC_PATTERN = /^(?:set(?:Interval|Timeout)|execScript)$/u;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Checks whether a node is evaluated as a string or not.

package/lib/rules/no-import-assign.js

@@ -182,7 +182,7 @@ module.exports = {
         docs: {
             description: "Disallow assigning to imported bindings",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-import-assign"
+            url: "https://eslint.org/docs/latest/rules/no-import-assign"
         },
 
         schema: [],
@@ -194,7 +194,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             ImportDeclaration(node) {

package/lib/rules/no-inline-comments.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Disallow inline comments after code",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-inline-comments"
+            url: "https://eslint.org/docs/latest/rules/no-inline-comments"
         },
 
         schema: [
@@ -39,7 +39,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const options = context.options[0];
         let customIgnoreRegExp;
 

package/lib/rules/no-inner-declarations.js

@@ -50,7 +50,7 @@ module.exports = {
         docs: {
             description: "Disallow variable or `function` declarations in nested blocks",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-inner-declarations"
+            url: "https://eslint.org/docs/latest/rules/no-inner-declarations"
         },
 
         schema: [

package/lib/rules/no-invalid-regexp.js

@@ -10,7 +10,7 @@
 
 const RegExpValidator = require("@eslint-community/regexpp").RegExpValidator;
 const validator = new RegExpValidator();
-const validFlags = /[dgimsuy]/gu;
+const validFlags = /[dgimsuvy]/gu;
 const undefined1 = void 0;
 
 //------------------------------------------------------------------------------
@@ -25,7 +25,7 @@ module.exports = {
         docs: {
             description: "Disallow invalid regular expression strings in `RegExp` constructors",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-invalid-regexp"
+            url: "https://eslint.org/docs/latest/rules/no-invalid-regexp"
         },
 
         schema: [{
@@ -108,12 +108,14 @@ module.exports = {
         /**
          * Check syntax error in a given pattern.
          * @param {string} pattern The RegExp pattern to validate.
-         * @param {boolean} uFlag The Unicode flag.
+         * @param {Object} flags The RegExp flags to validate.
+         * @param {boolean} [flags.unicode] The Unicode flag.
+         * @param {boolean} [flags.unicodeSets] The UnicodeSets flag.
          * @returns {string|null} The syntax error.
          */
-        function validateRegExpPattern(pattern, uFlag) {
+        function validateRegExpPattern(pattern, flags) {
             try {
-                validator.validatePattern(pattern, undefined1, undefined1, uFlag);
+                validator.validatePattern(pattern, undefined1, undefined1, flags);
                 return null;
             } catch (err) {
                 return err.message;
@@ -131,10 +133,19 @@ module.exports = {
             }
             try {
                 validator.validateFlags(flags);
-                return null;
             } catch {
                 return `Invalid flags supplied to RegExp constructor '${flags}'`;
             }
+
+            /*
+             * `regexpp` checks the combination of `u` and `v` flags when parsing `Pattern` according to `ecma262`,
+             * but this rule may check only the flag when the pattern is unidentifiable, so check it here.
+             * https://tc39.es/ecma262/multipage/text-processing.html#sec-parsepattern
+             */
+            if (flags.includes("u") && flags.includes("v")) {
+                return "Regex 'u' and 'v' flags cannot be used together";
+            }
+            return null;
         }
 
         return {
@@ -166,8 +177,12 @@ module.exports = {
 
                     // If flags are unknown, report the regex only if its pattern is invalid both with and without the "u" flag
                     flags === null
-                        ? validateRegExpPattern(pattern, true) && validateRegExpPattern(pattern, false)
-                        : validateRegExpPattern(pattern, flags.includes("u"))
+                        ? (
+                            validateRegExpPattern(pattern, { unicode: true, unicodeSets: false }) &&
+                            validateRegExpPattern(pattern, { unicode: false, unicodeSets: true }) &&
+                            validateRegExpPattern(pattern, { unicode: false, unicodeSets: false })
+                        )
+                        : validateRegExpPattern(pattern, { unicode: flags.includes("u"), unicodeSets: flags.includes("v") })
                 );
 
                 if (message) {

package/lib/rules/no-invalid-this.js

@@ -38,7 +38,7 @@ module.exports = {
         docs: {
             description: "Disallow use of `this` in contexts where the value of `this` is `undefined`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-invalid-this"
+            url: "https://eslint.org/docs/latest/rules/no-invalid-this"
         },
 
         schema: [
@@ -63,7 +63,7 @@ module.exports = {
         const options = context.options[0] || {};
         const capIsConstructor = options.capIsConstructor !== false;
         const stack = [],
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
 
         /**
          * Gets the current checking context.

package/lib/rules/no-irregular-whitespace.js

@@ -33,7 +33,7 @@ module.exports = {
         docs: {
             description: "Disallow irregular whitespace",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-irregular-whitespace"
+            url: "https://eslint.org/docs/latest/rules/no-irregular-whitespace"
         },
 
         schema: [
@@ -55,6 +55,10 @@ module.exports = {
                     skipRegExps: {
                         type: "boolean",
                         default: false
+                    },
+                    skipJSXText: {
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false
@@ -77,8 +81,9 @@ module.exports = {
         const skipStrings = options.skipStrings !== false;
         const skipRegExps = !!options.skipRegExps;
         const skipTemplates = !!options.skipTemplates;
+        const skipJSXText = !!options.skipJSXText;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const commentNodes = sourceCode.getAllComments();
 
         /**
@@ -100,12 +105,12 @@ module.exports = {
         }
 
         /**
-         * Checks identifier or literal nodes for errors that we are choosing to ignore and calls the relevant methods to remove the errors
+         * Checks literal nodes for errors that we are choosing to ignore and calls the relevant methods to remove the errors
          * @param {ASTNode} node to check for matching errors.
          * @returns {void}
          * @private
          */
-        function removeInvalidNodeErrorsInIdentifierOrLiteral(node) {
+        function removeInvalidNodeErrorsInLiteral(node) {
             const shouldCheckStrings = skipStrings && (typeof node.value === "string");
             const shouldCheckRegExps = skipRegExps && Boolean(node.regex);
 
@@ -144,6 +149,18 @@ module.exports = {
             }
         }
 
+        /**
+         * Checks JSX nodes for errors that we are choosing to ignore and calls the relevant methods to remove the errors
+         * @param {ASTNode} node to check for matching errors.
+         * @returns {void}
+         * @private
+         */
+        function removeInvalidNodeErrorsInJSXText(node) {
+            if (ALL_IRREGULARS.test(node.raw)) {
+                removeWhitespaceError(node);
+            }
+        }
+
         /**
          * Checks the program source for irregular whitespace
          * @param {ASTNode} node The program node
@@ -237,9 +254,9 @@ module.exports = {
                 checkForIrregularLineTerminators(node);
             };
 
-            nodes.Identifier = removeInvalidNodeErrorsInIdentifierOrLiteral;
-            nodes.Literal = removeInvalidNodeErrorsInIdentifierOrLiteral;
+            nodes.Literal = removeInvalidNodeErrorsInLiteral;
             nodes.TemplateElement = skipTemplates ? removeInvalidNodeErrorsInTemplateLiteral : noop;
+            nodes.JSXText = skipJSXText ? removeInvalidNodeErrorsInJSXText : noop;
             nodes["Program:exit"] = function() {
                 if (skipComments) {
 

package/lib/rules/no-iterator.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Disallow the use of the `__iterator__` property",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-iterator"
+            url: "https://eslint.org/docs/latest/rules/no-iterator"
         },
 
         schema: [],

package/lib/rules/no-label-var.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Disallow labels that share a name with a variable",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-label-var"
+            url: "https://eslint.org/docs/latest/rules/no-label-var"
         },
 
         schema: [],
@@ -34,7 +34,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //--------------------------------------------------------------------------
         // Helpers

package/lib/rules/no-labels.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Disallow labeled statements",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-labels"
+            url: "https://eslint.org/docs/latest/rules/no-labels"
         },
 
         schema: [

package/lib/rules/no-lone-blocks.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary nested blocks",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-lone-blocks"
+            url: "https://eslint.org/docs/latest/rules/no-lone-blocks"
         },
 
         schema: [],
@@ -33,7 +33,7 @@ module.exports = {
         // A stack of lone blocks to be checked for block-level bindings
         const loneBlocks = [];
         let ruleDef;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports a node as invalid.

package/lib/rules/no-lonely-if.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Disallow `if` statements as the only statement in `else` blocks",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-lonely-if"
+            url: "https://eslint.org/docs/latest/rules/no-lonely-if"
         },
 
         schema: [],
@@ -28,7 +28,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             IfStatement(node) {

package/lib/rules/no-loop-func.js

@@ -156,7 +156,7 @@ module.exports = {
         docs: {
             description: "Disallow function declarations that contain unsafe references inside loop statements",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-loop-func"
+            url: "https://eslint.org/docs/latest/rules/no-loop-func"
         },
 
         schema: [],
@@ -168,7 +168,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports functions which match the following condition:
@@ -186,7 +186,7 @@ module.exports = {
             }
 
             const references = sourceCode.getScope(node).through;
-            const unsafeRefs = references.filter(r => !isSafe(loopNode, r)).map(r => r.identifier.name);
+            const unsafeRefs = references.filter(r => r.resolved && !isSafe(loopNode, r)).map(r => r.identifier.name);
 
             if (unsafeRefs.length > 0) {
                 context.report({

package/lib/rules/no-loss-of-precision.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow literal numbers that lose precision",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-loss-of-precision"
+            url: "https://eslint.org/docs/latest/rules/no-loss-of-precision"
         },
         schema: [],
         messages: {
@@ -83,7 +83,7 @@ module.exports = {
          * @returns {string} the numeric string with a decimal point in the proper place
          */
         function addDecimalPointToNumber(stringNumber) {
-            return `${stringNumber.slice(0, 1)}.${stringNumber.slice(1)}`;
+            return `${stringNumber[0]}.${stringNumber.slice(1)}`;
         }
 
         /**
@@ -92,7 +92,12 @@ module.exports = {
          * @returns {string} the stripped string
          */
         function removeLeadingZeros(numberAsString) {
-            return numberAsString.replace(/^0*/u, "");
+            for (let i = 0; i < numberAsString.length; i++) {
+                if (numberAsString[i] !== "0") {
+                    return numberAsString.slice(i);
+                }
+            }
+            return numberAsString;
         }
 
         /**
@@ -101,7 +106,12 @@ module.exports = {
          * @returns {string} the stripped string
          */
         function removeTrailingZeros(numberAsString) {
-            return numberAsString.replace(/0*$/u, "");
+            for (let i = numberAsString.length - 1; i >= 0; i--) {
+                if (numberAsString[i] !== "0") {
+                    return numberAsString.slice(0, i + 1);
+                }
+            }
+            return numberAsString;
         }
 
         /**
@@ -128,7 +138,7 @@ module.exports = {
             const trimmedFloat = removeLeadingZeros(stringFloat);
 
             if (trimmedFloat.startsWith(".")) {
-                const decimalDigits = trimmedFloat.split(".").pop();
+                const decimalDigits = trimmedFloat.slice(1);
                 const significantDigits = removeLeadingZeros(decimalDigits);
 
                 return {
@@ -144,7 +154,6 @@ module.exports = {
             };
         }
 
-
         /**
          * Converts a base ten number to proper scientific notation
          * @param {string} stringNumber the string representation of the base ten number to be converted
@@ -160,7 +169,6 @@ module.exports = {
                 : normalizedNumber.magnitude;
 
             return `${normalizedCoefficient}e${magnitude}`;
-
         }
 
         /**

package/lib/rules/no-magic-numbers.js

@@ -34,7 +34,7 @@ module.exports = {
         docs: {
             description: "Disallow magic numbers",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-magic-numbers"
+            url: "https://eslint.org/docs/latest/rules/no-magic-numbers"
         },
 
         schema: [{

package/lib/rules/no-misleading-character-class.js

@@ -18,7 +18,7 @@ const { isValidWithUnicodeFlag } = require("./utils/regular-expressions");
  *
  * CharacterClassRange syntax can steal a part of character sequence,
  * so this function reverts CharacterClassRange syntax and restore the sequence.
- * @param {regexpp.AST.CharacterClassElement[]} nodes The node list to iterate character sequences.
+ * @param {import('@eslint-community/regexpp').AST.CharacterClassElement[]} nodes The node list to iterate character sequences.
  * @returns {IterableIterator<number[]>} The list of character sequences.
  */
 function *iterateCharacterSequence(nodes) {
@@ -37,6 +37,9 @@ function *iterateCharacterSequence(nodes) {
                 break;
 
             case "CharacterSet":
+            case "CharacterClass": // [[]] nesting character class
+            case "ClassStringDisjunction": // \q{...}
+            case "ExpressionCharacterClass": // [A--B]
                 if (seq.length > 0) {
                     yield seq;
                     seq = [];
@@ -108,7 +111,7 @@ module.exports = {
         docs: {
             description: "Disallow characters which are made with multiple code points in character class syntax",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-misleading-character-class"
+            url: "https://eslint.org/docs/latest/rules/no-misleading-character-class"
         },
 
         hasSuggestions: true,
@@ -125,7 +128,7 @@ module.exports = {
         }
     },
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const parser = new RegExpParser();
 
         /**
@@ -144,7 +147,10 @@ module.exports = {
                     pattern,
                     0,
                     pattern.length,
-                    flags.includes("u")
+                    {
+                        unicode: flags.includes("u"),
+                        unicodeSets: flags.includes("v")
+                    }
                 );
             } catch {
 

package/lib/rules/no-mixed-operators.js

@@ -90,7 +90,7 @@ module.exports = {
         docs: {
             description: "Disallow mixed binary operators",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-mixed-operators"
+            url: "https://eslint.org/docs/latest/rules/no-mixed-operators"
         },
 
         schema: [
@@ -122,7 +122,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const options = normalizeOptions(context.options[0]);
 
         /**

package/lib/rules/no-mixed-requires.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Disallow `require` calls to be mixed with regular variable declarations",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-mixed-requires"
+            url: "https://eslint.org/docs/latest/rules/no-mixed-requires"
         },
 
         schema: [

package/lib/rules/no-mixed-spaces-and-tabs.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Disallow mixed spaces and tabs for indentation",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-mixed-spaces-and-tabs"
+            url: "https://eslint.org/docs/latest/rules/no-mixed-spaces-and-tabs"
         },
 
         schema: [
@@ -31,7 +31,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         let smartTabs;
 

package/lib/rules/no-multi-assign.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Disallow use of chained assignment expressions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-multi-assign"
+            url: "https://eslint.org/docs/latest/rules/no-multi-assign"
         },
 
         schema: [{

package/lib/rules/no-multi-spaces.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Disallow multiple spaces",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-multi-spaces"
+            url: "https://eslint.org/docs/latest/rules/no-multi-spaces"
         },
 
         fixable: "whitespace",
@@ -52,7 +52,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const options = context.options[0] || {};
         const ignoreEOLComments = options.ignoreEOLComments;
         const exceptions = Object.assign({ Property: true }, options.exceptions);

package/lib/rules/no-multi-str.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Disallow multiline strings",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-multi-str"
+            url: "https://eslint.org/docs/latest/rules/no-multi-str"
         },
 
         schema: [],

package/lib/rules/no-multiple-empty-lines.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow multiple empty lines",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-multiple-empty-lines"
+            url: "https://eslint.org/docs/latest/rules/no-multiple-empty-lines"
         },
 
         fixable: "whitespace",
@@ -64,7 +64,7 @@ module.exports = {
             maxBOF = typeof context.options[0].maxBOF !== "undefined" ? context.options[0].maxBOF : max;
         }
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         // Swallow the final newline, as some editors add it automatically and we don't want it to cause an issue
         const allLines = sourceCode.lines[sourceCode.lines.length - 1] === "" ? sourceCode.lines.slice(0, -1) : sourceCode.lines;

package/lib/rules/no-native-reassign.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Disallow assignments to native objects or read-only global variables",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-native-reassign"
+            url: "https://eslint.org/docs/latest/rules/no-native-reassign"
         },
 
         deprecated: true,
@@ -47,7 +47,7 @@ module.exports = {
     create(context) {
         const config = context.options[0];
         const exceptions = (config && config.exceptions) || [];
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports write references.

package/lib/rules/no-negated-condition.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Disallow negated conditions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-negated-condition"
+            url: "https://eslint.org/docs/latest/rules/no-negated-condition"
         },
 
         schema: [],

package/lib/rules/no-negated-in-lhs.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Disallow negating the left operand in `in` expressions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-negated-in-lhs"
+            url: "https://eslint.org/docs/latest/rules/no-negated-in-lhs"
         },
 
         replacedBy: ["no-unsafe-negation"],

package/lib/rules/no-nested-ternary.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow nested ternary expressions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-nested-ternary"
+            url: "https://eslint.org/docs/latest/rules/no-nested-ternary"
         },
 
         schema: [],

package/lib/rules/no-new-func.js

@@ -29,7 +29,7 @@ module.exports = {
         docs: {
             description: "Disallow `new` operators with the `Function` object",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-new-func"
+            url: "https://eslint.org/docs/latest/rules/no-new-func"
         },
 
         schema: [],
@@ -40,7 +40,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             "Program:exit"(node) {