eslint 8.39.0 → 8.47.0

package/lib/rules/no-shadow.js

@@ -32,7 +32,7 @@ module.exports = {
         docs: {
             description: "Disallow variable declarations from shadowing variables declared in the outer scope",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-shadow"
+            url: "https://eslint.org/docs/latest/rules/no-shadow"
         },
 
         schema: [
@@ -67,7 +67,7 @@ module.exports = {
             allow: (context.options[0] && context.options[0].allow) || [],
             ignoreOnInitialization: context.options[0] && context.options[0].ignoreOnInitialization
         };
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Checks whether or not a given location is inside of the range of a given node.

package/lib/rules/no-spaced-func.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Disallow spacing between function identifiers and their applications (deprecated)",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-spaced-func"
+            url: "https://eslint.org/docs/latest/rules/no-spaced-func"
         },
 
         deprecated: true,
@@ -35,7 +35,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Check if open space is present in a function name

package/lib/rules/no-sparse-arrays.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Disallow sparse arrays",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-sparse-arrays"
+            url: "https://eslint.org/docs/latest/rules/no-sparse-arrays"
         },
 
         schema: [],

package/lib/rules/no-sync.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Disallow synchronous methods",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-sync"
+            url: "https://eslint.org/docs/latest/rules/no-sync"
         },
 
         schema: [

package/lib/rules/no-tabs.js

@@ -24,7 +24,7 @@ module.exports = {
         docs: {
             description: "Disallow all tabs",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-tabs"
+            url: "https://eslint.org/docs/latest/rules/no-tabs"
         },
         schema: [{
             type: "object",
@@ -43,7 +43,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const allowIndentationTabs = context.options && context.options[0] && context.options[0].allowIndentationTabs;
 
         return {

package/lib/rules/no-template-curly-in-string.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Disallow template literal placeholder syntax in regular strings",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-template-curly-in-string"
+            url: "https://eslint.org/docs/latest/rules/no-template-curly-in-string"
         },
 
         schema: [],

package/lib/rules/no-ternary.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow ternary operators",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-ternary"
+            url: "https://eslint.org/docs/latest/rules/no-ternary"
         },
 
         schema: [],

package/lib/rules/no-this-before-super.js

@@ -42,7 +42,7 @@ module.exports = {
         docs: {
             description: "Disallow `this`/`super` before calling `super()` in constructors",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-this-before-super"
+            url: "https://eslint.org/docs/latest/rules/no-this-before-super"
         },
 
         schema: [],

package/lib/rules/no-throw-literal.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Disallow throwing literals as exceptions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-throw-literal"
+            url: "https://eslint.org/docs/latest/rules/no-throw-literal"
         },
 
         schema: [],

package/lib/rules/no-trailing-spaces.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Disallow trailing whitespace at the end of lines",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-trailing-spaces"
+            url: "https://eslint.org/docs/latest/rules/no-trailing-spaces"
         },
 
         fixable: "whitespace",
@@ -50,7 +50,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         const BLANK_CLASS = "[ \t\u00a0\u2000-\u200b\u3000]",
             SKIP_BLANK = `^${BLANK_CLASS}*$`,

package/lib/rules/no-undef-init.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Disallow initializing variables to `undefined`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-undef-init"
+            url: "https://eslint.org/docs/latest/rules/no-undef-init"
         },
 
         schema: [],
@@ -32,7 +32,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
 

package/lib/rules/no-undef.js

@@ -31,7 +31,7 @@ module.exports = {
         docs: {
             description: "Disallow the use of undeclared variables unless mentioned in `/*global */` comments",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-undef"
+            url: "https://eslint.org/docs/latest/rules/no-undef"
         },
 
         schema: [
@@ -54,7 +54,7 @@ module.exports = {
     create(context) {
         const options = context.options[0];
         const considerTypeOf = options && options.typeof === true || false;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             "Program:exit"(node) {

package/lib/rules/no-undefined.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Disallow the use of `undefined` as an identifier",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-undefined"
+            url: "https://eslint.org/docs/latest/rules/no-undefined"
         },
 
         schema: [],
@@ -28,7 +28,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Report an invalid "undefined" identifier node.

package/lib/rules/no-underscore-dangle.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow dangling underscores in identifiers",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-underscore-dangle"
+            url: "https://eslint.org/docs/latest/rules/no-underscore-dangle"
         },
 
         schema: [
@@ -84,7 +84,7 @@ module.exports = {
         const allowFunctionParams = typeof options.allowFunctionParams !== "undefined" ? options.allowFunctionParams : true;
         const allowInArrayDestructuring = typeof options.allowInArrayDestructuring !== "undefined" ? options.allowInArrayDestructuring : true;
         const allowInObjectDestructuring = typeof options.allowInObjectDestructuring !== "undefined" ? options.allowInObjectDestructuring : true;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //-------------------------------------------------------------------------
         // Helpers

package/lib/rules/no-unexpected-multiline.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Disallow confusing multiline expressions",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-unexpected-multiline"
+            url: "https://eslint.org/docs/latest/rules/no-unexpected-multiline"
         },
 
         schema: [],
@@ -38,7 +38,7 @@ module.exports = {
 
         const REGEX_FLAG_MATCHER = /^[gimsuy]+$/u;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Check to see if there is a newline between the node and the following open bracket

package/lib/rules/no-unmodified-loop-condition.js

@@ -164,7 +164,7 @@ module.exports = {
         docs: {
             description: "Disallow unmodified loop conditions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-unmodified-loop-condition"
+            url: "https://eslint.org/docs/latest/rules/no-unmodified-loop-condition"
         },
 
         schema: [],
@@ -175,7 +175,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         let groupMap = null;
 
         /**

package/lib/rules/no-unneeded-ternary.js

@@ -31,7 +31,7 @@ module.exports = {
         docs: {
             description: "Disallow ternary operators when simpler alternatives exist",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-unneeded-ternary"
+            url: "https://eslint.org/docs/latest/rules/no-unneeded-ternary"
         },
 
         schema: [
@@ -58,7 +58,7 @@ module.exports = {
     create(context) {
         const options = context.options[0] || {};
         const defaultAssignment = options.defaultAssignment !== false;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Test if the node is a boolean literal

package/lib/rules/no-unreachable-loop.js

@@ -61,7 +61,7 @@ module.exports = {
         docs: {
             description: "Disallow loops with a body that allows only one iteration",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-unreachable-loop"
+            url: "https://eslint.org/docs/latest/rules/no-unreachable-loop"
         },
 
         schema: [{

package/lib/rules/no-unreachable.js

@@ -113,7 +113,7 @@ module.exports = {
         docs: {
             description: "Disallow unreachable code after `return`, `throw`, `continue`, and `break` statements",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-unreachable"
+            url: "https://eslint.org/docs/latest/rules/no-unreachable"
         },
 
         schema: [],
@@ -130,7 +130,7 @@ module.exports = {
         let constructorInfo = null;
 
         /** @type {ConsecutiveRange} */
-        const range = new ConsecutiveRange(context.getSourceCode());
+        const range = new ConsecutiveRange(context.sourceCode);
 
         /**
          * Reports a given node if it's unreachable.

package/lib/rules/no-unsafe-finally.js

@@ -26,7 +26,7 @@ module.exports = {
         docs: {
             description: "Disallow control flow statements in `finally` blocks",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-unsafe-finally"
+            url: "https://eslint.org/docs/latest/rules/no-unsafe-finally"
         },
 
         schema: [],

package/lib/rules/no-unsafe-negation.js

@@ -54,7 +54,7 @@ module.exports = {
         docs: {
             description: "Disallow negating the left operand of relational operators",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-unsafe-negation"
+            url: "https://eslint.org/docs/latest/rules/no-unsafe-negation"
         },
 
         hasSuggestions: true,
@@ -82,7 +82,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const options = context.options[0] || {};
         const enforceForOrderingRelations = options.enforceForOrderingRelations === true;
 

package/lib/rules/no-unsafe-optional-chaining.js

@@ -26,7 +26,7 @@ module.exports = {
         docs: {
             description: "Disallow use of optional chaining in contexts where the `undefined` value is not allowed",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-unsafe-optional-chaining"
+            url: "https://eslint.org/docs/latest/rules/no-unsafe-optional-chaining"
         },
         schema: [{
             type: "object",

package/lib/rules/no-unused-expressions.js

@@ -4,6 +4,8 @@
  */
 "use strict";
 
+const astUtils = require("./utils/ast-utils");
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -32,7 +34,7 @@ module.exports = {
         docs: {
             description: "Disallow unused expressions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-unused-expressions"
+            url: "https://eslint.org/docs/latest/rules/no-unused-expressions"
         },
 
         schema: [
@@ -112,8 +114,6 @@ module.exports = {
          * @returns {boolean} whether the given node is considered a directive in its current position
          */
         function isDirective(node) {
-            const parent = node.parent,
-                grandparent = parent.parent;
 
             /**
              * https://tc39.es/ecma262/#directive-prologue
@@ -121,9 +121,7 @@ module.exports = {
              * Only `FunctionBody`, `ScriptBody` and `ModuleBody` can have directive prologue.
              * Class static blocks do not have directive prologue.
              */
-            return (parent.type === "Program" || parent.type === "BlockStatement" &&
-                    (/Function/u.test(grandparent.type))) &&
-                    directives(parent).includes(node);
+            return astUtils.isTopLevelExpressionStatement(node) && directives(node.parent).includes(node);
         }
 
         /**

package/lib/rules/no-unused-labels.js

@@ -5,6 +5,12 @@
 
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const astUtils = require("./utils/ast-utils");
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -17,7 +23,7 @@ module.exports = {
         docs: {
             description: "Disallow unused labels",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-unused-labels"
+            url: "https://eslint.org/docs/latest/rules/no-unused-labels"
         },
 
         schema: [],
@@ -30,7 +36,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         let scopeInfo = null;
 
         /**
@@ -46,6 +52,45 @@ module.exports = {
             };
         }
 
+        /**
+         * Checks if a `LabeledStatement` node is fixable.
+         * For a node to be fixable, there must be no comments between the label and the body.
+         * Furthermore, is must be possible to remove the label without turning the body statement into a
+         * directive after other fixes are applied.
+         * @param {ASTNode} node The node to evaluate.
+         * @returns {boolean} Whether or not the node is fixable.
+         */
+        function isFixable(node) {
+
+            /*
+             * Only perform a fix if there are no comments between the label and the body. This will be the case
+             * when there is exactly one token/comment (the ":") between the label and the body.
+             */
+            if (sourceCode.getTokenAfter(node.label, { includeComments: true }) !==
+                sourceCode.getTokenBefore(node.body, { includeComments: true })) {
+                return false;
+            }
+
+            // Looking for the node's deepest ancestor which is not a `LabeledStatement`.
+            let ancestor = node.parent;
+
+            while (ancestor.type === "LabeledStatement") {
+                ancestor = ancestor.parent;
+            }
+
+            if (ancestor.type === "Program" ||
+                (ancestor.type === "BlockStatement" && astUtils.isFunction(ancestor.parent))) {
+                const { body } = node;
+
+                if (body.type === "ExpressionStatement" &&
+                    ((body.expression.type === "Literal" && typeof body.expression.value === "string") ||
+                    astUtils.isStaticTemplateLiteral(body.expression))) {
+                    return false; // potential directive
+                }
+            }
+            return true;
+        }
+
         /**
          * Removes the top of the stack.
          * At the same time, this reports the label if it's never used.
@@ -58,19 +103,7 @@ module.exports = {
                     node: node.label,
                     messageId: "unused",
                     data: node.label,
-                    fix(fixer) {
-
-                        /*
-                         * Only perform a fix if there are no comments between the label and the body. This will be the case
-                         * when there is exactly one token/comment (the ":") between the label and the body.
-                         */
-                        if (sourceCode.getTokenAfter(node.label, { includeComments: true }) ===
-                                sourceCode.getTokenBefore(node.body, { includeComments: true })) {
-                            return fixer.removeRange([node.range[0], node.body.range[0]]);
-                        }
-
-                        return null;
-                    }
+                    fix: isFixable(node) ? fixer => fixer.removeRange([node.range[0], node.body.range[0]]) : null
                 });
             }
 

package/lib/rules/no-unused-private-class-members.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow unused private class members",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-unused-private-class-members"
+            url: "https://eslint.org/docs/latest/rules/no-unused-private-class-members"
         },
 
         schema: [],

package/lib/rules/no-unused-vars.js

@@ -35,7 +35,7 @@ module.exports = {
         docs: {
             description: "Disallow unused variables",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-unused-vars"
+            url: "https://eslint.org/docs/latest/rules/no-unused-vars"
         },
 
         schema: [
@@ -84,7 +84,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         const REST_PROPERTY_TYPE = /^(?:RestElement|(?:Experimental)?RestProperty)$/u;
 
@@ -466,7 +466,8 @@ module.exports = {
                     (
                         parent.type === "AssignmentExpression" &&
                         parent.left === id &&
-                        isUnusedExpression(parent)
+                        isUnusedExpression(parent) &&
+                        !astUtils.isLogicalAssignmentOperator(parent.operator)
                     ) ||
                     (
                         parent.type === "UpdateExpression" &&

package/lib/rules/no-use-before-define.js

@@ -228,7 +228,7 @@ module.exports = {
         docs: {
             description: "Disallow the use of variables before they are defined",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-use-before-define"
+            url: "https://eslint.org/docs/latest/rules/no-use-before-define"
         },
 
         schema: [
@@ -258,7 +258,7 @@ module.exports = {
 
     create(context) {
         const options = parseOptions(context.options[0]);
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Determines whether a given reference should be checked.

package/lib/rules/no-useless-backreference.js

@@ -66,7 +66,7 @@ module.exports = {
         docs: {
             description: "Disallow useless backreferences in regular expressions",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-useless-backreference"
+            url: "https://eslint.org/docs/latest/rules/no-useless-backreference"
         },
 
         schema: [],
@@ -82,7 +82,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Checks and reports useless backreferences in the given regular expression.
@@ -95,7 +95,7 @@ module.exports = {
             let regExpAST;
 
             try {
-                regExpAST = parser.parsePattern(pattern, 0, pattern.length, flags.includes("u"));
+                regExpAST = parser.parsePattern(pattern, 0, pattern.length, { unicode: flags.includes("u"), unicodeSets: flags.includes("v") });
             } catch {
 
                 // Ignore regular expressions with syntax errors

package/lib/rules/no-useless-call.js

@@ -57,7 +57,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary calls to `.call()` and `.apply()`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-useless-call"
+            url: "https://eslint.org/docs/latest/rules/no-useless-call"
         },
 
         schema: [],
@@ -68,7 +68,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             CallExpression(node) {

package/lib/rules/no-useless-catch.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary `catch` clauses",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-useless-catch"
+            url: "https://eslint.org/docs/latest/rules/no-useless-catch"
         },
 
         schema: [],

package/lib/rules/no-useless-computed-key.js

@@ -93,7 +93,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary computed property keys in objects and classes",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-useless-computed-key"
+            url: "https://eslint.org/docs/latest/rules/no-useless-computed-key"
         },
 
         schema: [{
@@ -113,7 +113,7 @@ module.exports = {
         }
     },
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const enforceForClassMembers = context.options[0] && context.options[0].enforceForClassMembers;
 
         /**

package/lib/rules/no-useless-concat.js

@@ -72,7 +72,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary concatenation of literals or template literals",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-useless-concat"
+            url: "https://eslint.org/docs/latest/rules/no-useless-concat"
         },
 
         schema: [],
@@ -83,7 +83,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             BinaryExpression(node) {

package/lib/rules/no-useless-constructor.js

@@ -140,7 +140,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary constructors",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-useless-constructor"
+            url: "https://eslint.org/docs/latest/rules/no-useless-constructor"
         },
 
         schema: [],