eslint 8.39.0 → 8.47.0

package/lib/rules/operator-linebreak.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent linebreak style for operators",
             recommended: false,
-            url: "https://eslint.org/docs/rules/operator-linebreak"
+            url: "https://eslint.org/docs/latest/rules/operator-linebreak"
         },
 
         schema: [
@@ -69,7 +69,7 @@ module.exports = {
             styleOverrides[":"] = "before";
         }
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //--------------------------------------------------------------------------
         // Helpers

package/lib/rules/padded-blocks.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Require or disallow padding within blocks",
             recommended: false,
-            url: "https://eslint.org/docs/rules/padded-blocks"
+            url: "https://eslint.org/docs/latest/rules/padded-blocks"
         },
 
         fixable: "whitespace",
@@ -96,7 +96,7 @@ module.exports = {
             options.allowSingleLineBlocks = exceptOptions.allowSingleLineBlocks === true;
         }
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Gets the open brace token from a given node.

package/lib/rules/padding-line-between-statements.js

@@ -130,49 +130,6 @@ function isBlockLikeStatement(sourceCode, node) {
     );
 }
 
-/**
- * Check whether the given node is a directive or not.
- * @param {ASTNode} node The node to check.
- * @param {SourceCode} sourceCode The source code object to get tokens.
- * @returns {boolean} `true` if the node is a directive.
- */
-function isDirective(node, sourceCode) {
-    return (
-        node.type === "ExpressionStatement" &&
-        (
-            node.parent.type === "Program" ||
-            (
-                node.parent.type === "BlockStatement" &&
-                astUtils.isFunction(node.parent.parent)
-            )
-        ) &&
-        node.expression.type === "Literal" &&
-        typeof node.expression.value === "string" &&
-        !astUtils.isParenthesised(sourceCode, node.expression)
-    );
-}
-
-/**
- * Check whether the given node is a part of directive prologue or not.
- * @param {ASTNode} node The node to check.
- * @param {SourceCode} sourceCode The source code object to get tokens.
- * @returns {boolean} `true` if the node is a part of directive prologue.
- */
-function isDirectivePrologue(node, sourceCode) {
-    if (isDirective(node, sourceCode)) {
-        for (const sibling of node.parent.body) {
-            if (sibling === node) {
-                break;
-            }
-            if (!isDirective(sibling, sourceCode)) {
-                return false;
-            }
-        }
-        return true;
-    }
-    return false;
-}
-
 /**
  * Gets the actual last token.
  *
@@ -253,7 +210,7 @@ function verifyForNever(context, _, nextNode, paddingLines) {
             const nextToken = paddingLines[0][1];
             const start = prevToken.range[1];
             const end = nextToken.range[0];
-            const text = context.getSourceCode().text
+            const text = context.sourceCode.text
                 .slice(start, end)
                 .replace(PADDING_LINE_SEQUENCE, replacerToRemovePaddingLines);
 
@@ -284,7 +241,7 @@ function verifyForAlways(context, prevNode, nextNode, paddingLines) {
         node: nextNode,
         messageId: "expectedBlankLine",
         fix(fixer) {
-            const sourceCode = context.getSourceCode();
+            const sourceCode = context.sourceCode;
             let prevToken = getActualLastToken(sourceCode, prevNode);
             const nextToken = sourceCode.getFirstTokenBetween(
                 prevToken,
@@ -366,12 +323,10 @@ const StatementTypes = {
             CJS_IMPORT.test(sourceCode.getText(node.declarations[0].init))
     },
     directive: {
-        test: isDirectivePrologue
+        test: astUtils.isDirective
     },
     expression: {
-        test: (node, sourceCode) =>
-            node.type === "ExpressionStatement" &&
-            !isDirectivePrologue(node, sourceCode)
+        test: node => node.type === "ExpressionStatement" && !astUtils.isDirective(node)
     },
     iife: {
         test: isIIFEStatement
@@ -382,10 +337,10 @@ const StatementTypes = {
             isBlockLikeStatement(sourceCode, node)
     },
     "multiline-expression": {
-        test: (node, sourceCode) =>
+        test: node =>
             node.loc.start.line !== node.loc.end.line &&
             node.type === "ExpressionStatement" &&
-            !isDirectivePrologue(node, sourceCode)
+            !astUtils.isDirective(node)
     },
 
     "multiline-const": newMultilineKeywordTester("const"),
@@ -433,7 +388,7 @@ module.exports = {
         docs: {
             description: "Require or disallow padding lines between statements",
             recommended: false,
-            url: "https://eslint.org/docs/rules/padding-line-between-statements"
+            url: "https://eslint.org/docs/latest/rules/padding-line-between-statements"
         },
 
         fixable: "whitespace",
@@ -475,7 +430,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const configureList = context.options || [];
         let scopeInfo = null;
 

package/lib/rules/prefer-arrow-callback.js

@@ -153,7 +153,7 @@ module.exports = {
         docs: {
             description: "Require using arrow functions for callbacks",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-arrow-callback"
+            url: "https://eslint.org/docs/latest/rules/prefer-arrow-callback"
         },
 
         schema: [
@@ -185,7 +185,7 @@ module.exports = {
 
         const allowUnboundThis = options.allowUnboundThis !== false; // default to true
         const allowNamedFunctions = options.allowNamedFunctions;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /*
          * {Array<{this: boolean, super: boolean, meta: boolean}>}

package/lib/rules/prefer-const.js

@@ -334,7 +334,7 @@ module.exports = {
         docs: {
             description: "Require `const` declarations for variables that are never reassigned after declared",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-const"
+            url: "https://eslint.org/docs/latest/rules/prefer-const"
         },
 
         fixable: "code",
@@ -356,7 +356,7 @@ module.exports = {
 
     create(context) {
         const options = context.options[0] || {};
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const shouldMatchAnyDestructuredVariable = options.destructuring !== "all";
         const ignoreReadBeforeAssign = options.ignoreReadBeforeAssign === true;
         const variables = [];

package/lib/rules/prefer-destructuring.js

@@ -28,7 +28,7 @@ module.exports = {
         docs: {
             description: "Require destructuring from arrays and/or objects",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-destructuring"
+            url: "https://eslint.org/docs/latest/rules/prefer-destructuring"
         },
 
         fixable: "code",
@@ -190,7 +190,7 @@ module.exports = {
          */
         function fixIntoObjectDestructuring(fixer, node) {
             const rightNode = node.init;
-            const sourceCode = context.getSourceCode();
+            const sourceCode = context.sourceCode;
 
             // Don't fix if that would remove any comments. Only comments inside `rightNode.object` can be preserved.
             if (sourceCode.getCommentsInside(node).length > sourceCode.getCommentsInside(rightNode.object).length) {

package/lib/rules/prefer-exponentiation-operator.js

@@ -55,11 +55,12 @@ function doesExponentNeedParens(exponent) {
 function doesExponentiationExpressionNeedParens(node, sourceCode) {
     const parent = node.parent.type === "ChainExpression" ? node.parent.parent : node.parent;
 
+    const parentPrecedence = astUtils.getPrecedence(parent);
     const needsParens = (
         parent.type === "ClassDeclaration" ||
         (
             parent.type.endsWith("Expression") &&
-            astUtils.getPrecedence(parent) >= PRECEDENCE_OF_EXPONENTIATION_EXPR &&
+            (parentPrecedence === -1 || parentPrecedence >= PRECEDENCE_OF_EXPONENTIATION_EXPR) &&
             !(parent.type === "BinaryExpression" && parent.operator === "**" && parent.right === node) &&
             !((parent.type === "CallExpression" || parent.type === "NewExpression") && parent.arguments.includes(node)) &&
             !(parent.type === "MemberExpression" && parent.computed && parent.property === node) &&
@@ -92,7 +93,7 @@ module.exports = {
         docs: {
             description: "Disallow the use of `Math.pow` in favor of the `**` operator",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-exponentiation-operator"
+            url: "https://eslint.org/docs/latest/rules/prefer-exponentiation-operator"
         },
 
         schema: [],
@@ -104,7 +105,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports the given node.

package/lib/rules/prefer-named-capture-group.js

@@ -90,7 +90,7 @@ module.exports = {
         docs: {
             description: "Enforce using named capture group in regular expression",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-named-capture-group"
+            url: "https://eslint.org/docs/latest/rules/prefer-named-capture-group"
         },
 
         hasSuggestions: true,
@@ -105,21 +105,24 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Function to check regular expression.
          * @param {string} pattern The regular expression pattern to be checked.
          * @param {ASTNode} node AST node which contains the regular expression or a call/new expression.
          * @param {ASTNode} regexNode AST node which contains the regular expression.
-         * @param {boolean} uFlag Flag indicates whether unicode mode is enabled or not.
+         * @param {string|null} flags The regular expression flags to be checked.
          * @returns {void}
          */
-        function checkRegex(pattern, node, regexNode, uFlag) {
+        function checkRegex(pattern, node, regexNode, flags) {
             let ast;
 
             try {
-                ast = parser.parsePattern(pattern, 0, pattern.length, uFlag);
+                ast = parser.parsePattern(pattern, 0, pattern.length, {
+                    unicode: Boolean(flags && flags.includes("u")),
+                    unicodeSets: Boolean(flags && flags.includes("v"))
+                });
             } catch {
 
                 // ignore regex syntax errors
@@ -148,7 +151,7 @@ module.exports = {
         return {
             Literal(node) {
                 if (node.regex) {
-                    checkRegex(node.regex.pattern, node, node, node.regex.flags.includes("u"));
+                    checkRegex(node.regex.pattern, node, node, node.regex.flags);
                 }
             },
             Program(node) {
@@ -166,7 +169,7 @@ module.exports = {
                     const flags = getStringIfConstant(refNode.arguments[1]);
 
                     if (regex) {
-                        checkRegex(regex, refNode, refNode.arguments[0], flags && flags.includes("u"));
+                        checkRegex(regex, refNode, refNode.arguments[0], flags);
                     }
                 }
             }

package/lib/rules/prefer-numeric-literals.js

@@ -47,7 +47,7 @@ module.exports = {
         docs: {
             description: "Disallow `parseInt()` and `Number.parseInt()` in favor of binary, octal, and hexadecimal literals",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-numeric-literals"
+            url: "https://eslint.org/docs/latest/rules/prefer-numeric-literals"
         },
 
         schema: [],
@@ -60,7 +60,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //----------------------------------------------------------------------
         // Public

package/lib/rules/prefer-object-has-own.js

@@ -52,7 +52,7 @@ module.exports = {
             description:
                 "Disallow use of `Object.prototype.hasOwnProperty.call()` and prefer use of `Object.hasOwn()`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-object-has-own"
+            url: "https://eslint.org/docs/latest/rules/prefer-object-has-own"
         },
         schema: [],
         messages: {
@@ -62,7 +62,7 @@ module.exports = {
     },
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             CallExpression(node) {

package/lib/rules/prefer-object-spread.js

@@ -248,7 +248,7 @@ module.exports = {
             description:
                 "Disallow using Object.assign with an object literal as the first argument and prefer the use of object spread instead",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-object-spread"
+            url: "https://eslint.org/docs/latest/rules/prefer-object-spread"
         },
 
         schema: [],
@@ -261,7 +261,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             Program(node) {

package/lib/rules/prefer-promise-reject-errors.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Require using Error objects as Promise rejection reasons",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-promise-reject-errors"
+            url: "https://eslint.org/docs/latest/rules/prefer-promise-reject-errors"
         },
 
         fixable: null,
@@ -41,7 +41,7 @@ module.exports = {
     create(context) {
 
         const ALLOW_EMPTY_REJECT = context.options.length && context.options[0].allowEmptyReject;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //----------------------------------------------------------------------
         // Helpers

package/lib/rules/prefer-reflect.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Require `Reflect` methods where applicable",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-reflect"
+            url: "https://eslint.org/docs/latest/rules/prefer-reflect"
         },
 
         deprecated: true,

package/lib/rules/prefer-regex-literals.js

@@ -37,15 +37,6 @@ function isRegexLiteral(node) {
     return node.type === "Literal" && Object.prototype.hasOwnProperty.call(node, "regex");
 }
 
-/**
- * Determines whether the given node is a template literal without expressions.
- * @param {ASTNode} node Node to check.
- * @returns {boolean} True if the node is a template literal without expressions.
- */
-function isStaticTemplateLiteral(node) {
-    return node.type === "TemplateLiteral" && node.expressions.length === 0;
-}
-
 const validPrecedingTokens = new Set([
     "(",
     ";",
@@ -124,7 +115,7 @@ module.exports = {
         docs: {
             description: "Disallow use of the `RegExp` constructor in favor of regular expression literals",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-regex-literals"
+            url: "https://eslint.org/docs/latest/rules/prefer-regex-literals"
         },
 
         hasSuggestions: true,
@@ -154,7 +145,7 @@ module.exports = {
 
     create(context) {
         const [{ disallowRedundantWrapping = false } = {}] = context.options;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Determines whether the given identifier node is a reference to a global variable.
@@ -178,7 +169,7 @@ module.exports = {
             return node.type === "TaggedTemplateExpression" &&
                 astUtils.isSpecificMemberAccess(node.tag, "String", "raw") &&
                 isGlobalReference(astUtils.skipChainExpression(node.tag).object) &&
-                isStaticTemplateLiteral(node.quasi);
+                astUtils.isStaticTemplateLiteral(node.quasi);
         }
 
         /**
@@ -191,7 +182,7 @@ module.exports = {
                 return node.value;
             }
 
-            if (isStaticTemplateLiteral(node)) {
+            if (astUtils.isStaticTemplateLiteral(node)) {
                 return node.quasis[0].value.cooked;
             }
 
@@ -209,7 +200,7 @@ module.exports = {
          */
         function isStaticString(node) {
             return isStringLiteral(node) ||
-                isStaticTemplateLiteral(node) ||
+                astUtils.isStaticTemplateLiteral(node) ||
                 isStringRawTaggedStaticTemplateLiteral(node);
         }
 
@@ -250,7 +241,7 @@ module.exports = {
         /**
          * Returns a ecmaVersion compatible for regexpp.
          * @param {number} ecmaVersion The ecmaVersion to convert.
-         * @returns {import("regexpp/ecma-versions").EcmaVersion} The resulting ecmaVersion compatible for regexpp.
+         * @returns {import("@eslint-community/regexpp/ecma-versions").EcmaVersion} The resulting ecmaVersion compatible for regexpp.
          */
         function getRegexppEcmaVersion(ecmaVersion) {
             if (ecmaVersion <= 5) {
@@ -306,7 +297,10 @@ module.exports = {
             const validator = new RegExpValidator({ ecmaVersion: regexppEcmaVersion });
 
             try {
-                validator.validatePattern(pattern, 0, pattern.length, flags ? flags.includes("u") : false);
+                validator.validatePattern(pattern, 0, pattern.length, {
+                    unicode: flags ? flags.includes("u") : false,
+                    unicodeSets: flags ? flags.includes("v") : false
+                });
                 if (flags) {
                     validator.validateFlags(flags);
                 }
@@ -470,7 +464,10 @@ module.exports = {
                         if (regexContent && !noFix) {
                             let charIncrease = 0;
 
-                            const ast = new RegExpParser({ ecmaVersion: regexppEcmaVersion }).parsePattern(regexContent, 0, regexContent.length, flags ? flags.includes("u") : false);
+                            const ast = new RegExpParser({ ecmaVersion: regexppEcmaVersion }).parsePattern(regexContent, 0, regexContent.length, {
+                                unicode: flags ? flags.includes("u") : false,
+                                unicodeSets: flags ? flags.includes("v") : false
+                            });
 
                             visitRegExpAST(ast, {
                                 onCharacterEnter(characterNode) {

package/lib/rules/prefer-rest-params.js

@@ -67,7 +67,7 @@ module.exports = {
         docs: {
             description: "Require rest parameters instead of `arguments`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-rest-params"
+            url: "https://eslint.org/docs/latest/rules/prefer-rest-params"
         },
 
         schema: [],
@@ -79,7 +79,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports a given reference.

package/lib/rules/prefer-spread.js

@@ -51,7 +51,7 @@ module.exports = {
         docs: {
             description: "Require spread operators instead of `.apply()`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-spread"
+            url: "https://eslint.org/docs/latest/rules/prefer-spread"
         },
 
         schema: [],
@@ -63,7 +63,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             CallExpression(node) {

package/lib/rules/prefer-template.js

@@ -130,7 +130,7 @@ module.exports = {
         docs: {
             description: "Require template literals instead of string concatenation",
             recommended: false,
-            url: "https://eslint.org/docs/rules/prefer-template"
+            url: "https://eslint.org/docs/latest/rules/prefer-template"
         },
 
         schema: [],
@@ -142,7 +142,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         let done = Object.create(null);
 
         /**

package/lib/rules/quote-props.js

@@ -24,7 +24,7 @@ module.exports = {
         docs: {
             description: "Require quotes around object literal property names",
             recommended: false,
-            url: "https://eslint.org/docs/rules/quote-props"
+            url: "https://eslint.org/docs/latest/rules/quote-props"
         },
 
         schema: {
@@ -86,7 +86,7 @@ module.exports = {
             CHECK_UNNECESSARY = !context.options[1] || context.options[1].unnecessary !== false,
             NUMBERS = context.options[1] && context.options[1].numbers,
 
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
 
 
         /**

package/lib/rules/quotes.js

@@ -82,7 +82,7 @@ module.exports = {
         docs: {
             description: "Enforce the consistent use of either backticks, double, or single quotes",
             recommended: false,
-            url: "https://eslint.org/docs/rules/quotes"
+            url: "https://eslint.org/docs/latest/rules/quotes"
         },
 
         fixable: "code",
@@ -123,7 +123,7 @@ module.exports = {
             settings = QUOTE_SETTINGS[quoteOption || "double"],
             options = context.options[1],
             allowTemplateLiterals = options && options.allowTemplateLiterals === true,
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
         let avoidEscape = options && options.avoidEscape === true;
 
         // deprecated
@@ -157,7 +157,8 @@ module.exports = {
 
         /**
          * Checks whether or not a given node is a directive.
-         * The directive is a `ExpressionStatement` which has only a string literal.
+         * The directive is a `ExpressionStatement` which has only a string literal not surrounded by
+         * parentheses.
          * @param {ASTNode} node A node to check.
          * @returns {boolean} Whether or not the node is a directive.
          * @private
@@ -166,23 +167,23 @@ module.exports = {
             return (
                 node.type === "ExpressionStatement" &&
                 node.expression.type === "Literal" &&
-                typeof node.expression.value === "string"
+                typeof node.expression.value === "string" &&
+                !astUtils.isParenthesised(sourceCode, node.expression)
             );
         }
 
         /**
-         * Checks whether or not a given node is a part of directive prologues.
-         * See also: http://www.ecma-international.org/ecma-262/6.0/#sec-directive-prologues-and-the-use-strict-directive
+         * Checks whether a specified node is either part of, or immediately follows a (possibly empty) directive prologue.
+         * @see {@link http://www.ecma-international.org/ecma-262/6.0/#sec-directive-prologues-and-the-use-strict-directive}
          * @param {ASTNode} node A node to check.
-         * @returns {boolean} Whether or not the node is a part of directive prologues.
+         * @returns {boolean} Whether a specified node is either part of, or immediately follows a (possibly empty) directive prologue.
          * @private
          */
-        function isPartOfDirectivePrologue(node) {
-            const block = node.parent.parent;
-
-            if (block.type !== "Program" && (block.type !== "BlockStatement" || !astUtils.isFunction(block.parent))) {
+        function isExpressionInOrJustAfterDirectivePrologue(node) {
+            if (!astUtils.isTopLevelExpressionStatement(node.parent)) {
                 return false;
             }
+            const block = node.parent.parent;
 
             // Check the node is at a prologue.
             for (let i = 0; i < block.body.length; ++i) {
@@ -212,7 +213,7 @@ module.exports = {
 
                 // Directive Prologues.
                 case "ExpressionStatement":
-                    return isPartOfDirectivePrologue(node);
+                    return !astUtils.isParenthesised(sourceCode, node) && isExpressionInOrJustAfterDirectivePrologue(node);
 
                 // LiteralPropertyName.
                 case "Property":
@@ -328,12 +329,11 @@ module.exports = {
                         description: settings.description
                     },
                     fix(fixer) {
-                        if (isPartOfDirectivePrologue(node)) {
+                        if (astUtils.isTopLevelExpressionStatement(node.parent) && !astUtils.isParenthesised(sourceCode, node)) {
 
                             /*
-                             * TemplateLiterals in a directive prologue aren't actually directives, but if they're
-                             * in the directive prologue, then fixing them might turn them into directives and change
-                             * the behavior of the code.
+                             * TemplateLiterals aren't actually directives, but fixing them might turn
+                             * them into directives and change the behavior of the code.
                              */
                             return null;
                         }

package/lib/rules/radix.js

@@ -82,7 +82,7 @@ module.exports = {
         docs: {
             description: "Enforce the consistent use of the radix argument when using `parseInt()`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/radix"
+            url: "https://eslint.org/docs/latest/rules/radix"
         },
 
         hasSuggestions: true,
@@ -104,7 +104,7 @@ module.exports = {
 
     create(context) {
         const mode = context.options[0] || MODE_ALWAYS;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Checks the arguments of a given CallExpression node and reports it if it