eslint 8.39.0 → 8.47.0

package/lib/rules/no-dupe-keys.js

@@ -90,7 +90,7 @@ module.exports = {
         docs: {
             description: "Disallow duplicate keys in object literals",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-dupe-keys"
+            url: "https://eslint.org/docs/latest/rules/no-dupe-keys"
         },
 
         schema: [],

package/lib/rules/no-duplicate-case.js

@@ -24,7 +24,7 @@ module.exports = {
         docs: {
             description: "Disallow duplicate case labels",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-duplicate-case"
+            url: "https://eslint.org/docs/latest/rules/no-duplicate-case"
         },
 
         schema: [],
@@ -35,7 +35,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Determines whether the two given nodes are considered to be equal.

package/lib/rules/no-duplicate-imports.js

@@ -235,7 +235,7 @@ module.exports = {
         docs: {
             description: "Disallow duplicate module imports",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-duplicate-imports"
+            url: "https://eslint.org/docs/latest/rules/no-duplicate-imports"
         },
 
         schema: [

package/lib/rules/no-else-return.js

@@ -24,7 +24,7 @@ module.exports = {
         docs: {
             description: "Disallow `else` blocks after `return` statements in `if` statements",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-else-return"
+            url: "https://eslint.org/docs/latest/rules/no-else-return"
         },
 
         schema: [{
@@ -47,7 +47,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //--------------------------------------------------------------------------
         // Helpers

package/lib/rules/no-empty-character-class.js

@@ -5,20 +5,18 @@
 
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const { RegExpParser, visitRegExpAST } = require("@eslint-community/regexpp");
+
 //------------------------------------------------------------------------------
 // Helpers
 //------------------------------------------------------------------------------
 
-/*
- * plain-English description of the following regexp:
- * 0. `^` fix the match at the beginning of the string
- * 1. `([^\\[]|\\.|\[([^\\\]]|\\.)+\])*`: regexp contents; 0 or more of the following
- * 1.0. `[^\\[]`: any character that's not a `\` or a `[` (anything but escape sequences and character classes)
- * 1.1. `\\.`: an escape sequence
- * 1.2. `\[([^\\\]]|\\.)+\]`: a character class that isn't empty
- * 2. `$`: fix the match at the end of the string
- */
-const regex = /^([^\\[]|\\.|\[([^\\\]]|\\.)+\])*$/u;
+const parser = new RegExpParser();
+const QUICK_TEST_REGEX = /\[\]/u;
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -32,7 +30,7 @@ module.exports = {
         docs: {
             description: "Disallow empty character classes in regular expressions",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-empty-character-class"
+            url: "https://eslint.org/docs/latest/rules/no-empty-character-class"
         },
 
         schema: [],
@@ -45,9 +43,32 @@ module.exports = {
     create(context) {
         return {
             "Literal[regex]"(node) {
-                if (!regex.test(node.regex.pattern)) {
-                    context.report({ node, messageId: "unexpected" });
+                const { pattern, flags } = node.regex;
+
+                if (!QUICK_TEST_REGEX.test(pattern)) {
+                    return;
                 }
+
+                let regExpAST;
+
+                try {
+                    regExpAST = parser.parsePattern(pattern, 0, pattern.length, {
+                        unicode: flags.includes("u"),
+                        unicodeSets: flags.includes("v")
+                    });
+                } catch {
+
+                    // Ignore regular expressions that regexpp cannot parse
+                    return;
+                }
+
+                visitRegExpAST(regExpAST, {
+                    onCharacterClassEnter(characterClass) {
+                        if (!characterClass.negate && characterClass.elements.length === 0) {
+                            context.report({ node, messageId: "unexpected" });
+                        }
+                    }
+                });
             }
         };
 

package/lib/rules/no-empty-function.js

@@ -97,7 +97,7 @@ module.exports = {
         docs: {
             description: "Disallow empty functions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-empty-function"
+            url: "https://eslint.org/docs/latest/rules/no-empty-function"
         },
 
         schema: [
@@ -123,7 +123,7 @@ module.exports = {
         const options = context.options[0] || {};
         const allowed = options.allow || [];
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports a given function node if the node matches the following patterns.

package/lib/rules/no-empty-pattern.js

@@ -4,6 +4,8 @@
  */
 "use strict";
 
+const astUtils = require("./utils/ast-utils");
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -16,10 +18,21 @@ module.exports = {
         docs: {
             description: "Disallow empty destructuring patterns",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-empty-pattern"
+            url: "https://eslint.org/docs/latest/rules/no-empty-pattern"
         },
 
-        schema: [],
+        schema: [
+            {
+                type: "object",
+                properties: {
+                    allowObjectPatternsAsParameters: {
+                        type: "boolean",
+                        default: false
+                    }
+                },
+                additionalProperties: false
+            }
+        ],
 
         messages: {
             unexpected: "Unexpected empty {{type}} pattern."
@@ -27,11 +40,33 @@ module.exports = {
     },
 
     create(context) {
+        const options = context.options[0] || {},
+            allowObjectPatternsAsParameters = options.allowObjectPatternsAsParameters || false;
+
         return {
             ObjectPattern(node) {
-                if (node.properties.length === 0) {
-                    context.report({ node, messageId: "unexpected", data: { type: "object" } });
+
+                if (node.properties.length > 0) {
+                    return;
                 }
+
+                // Allow {} and {} = {} empty object patterns as parameters when allowObjectPatternsAsParameters is true
+                if (
+                    allowObjectPatternsAsParameters &&
+                    (
+                        astUtils.isFunction(node.parent) ||
+                        (
+                            node.parent.type === "AssignmentPattern" &&
+                            astUtils.isFunction(node.parent.parent) &&
+                            node.parent.right.type === "ObjectExpression" &&
+                            node.parent.right.properties.length === 0
+                        )
+                    )
+                ) {
+                    return;
+                }
+
+                context.report({ node, messageId: "unexpected", data: { type: "object" } });
             },
             ArrayPattern(node) {
                 if (node.elements.length === 0) {

package/lib/rules/no-empty-static-block.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Disallow empty static blocks",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-empty-static-block"
+            url: "https://eslint.org/docs/latest/rules/no-empty-static-block"
         },
 
         schema: [],
@@ -27,7 +27,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             StaticBlock(node) {

package/lib/rules/no-empty.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Disallow empty block statements",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-empty"
+            url: "https://eslint.org/docs/latest/rules/no-empty"
         },
 
         schema: [
@@ -49,7 +49,7 @@ module.exports = {
         const options = context.options[0] || {},
             allowEmptyCatch = options.allowEmptyCatch || false;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             BlockStatement(node) {

package/lib/rules/no-eq-null.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Disallow `null` comparisons without type-checking operators",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-eq-null"
+            url: "https://eslint.org/docs/latest/rules/no-eq-null"
         },
 
         schema: [],

package/lib/rules/no-eval.js

@@ -45,7 +45,7 @@ module.exports = {
         docs: {
             description: "Disallow the use of `eval()`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-eval"
+            url: "https://eslint.org/docs/latest/rules/no-eval"
         },
 
         schema: [
@@ -68,7 +68,7 @@ module.exports = {
             context.options[0] &&
             context.options[0].allowIndirect
         );
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         let funcInfo = null;
 
         /**

package/lib/rules/no-ex-assign.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Disallow reassigning exceptions in `catch` clauses",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-ex-assign"
+            url: "https://eslint.org/docs/latest/rules/no-ex-assign"
         },
 
         schema: [],
@@ -31,7 +31,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Finds and reports references that are non initializer and writable.

package/lib/rules/no-extend-native.js

@@ -24,7 +24,7 @@ module.exports = {
         docs: {
             description: "Disallow extending native types",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-extend-native"
+            url: "https://eslint.org/docs/latest/rules/no-extend-native"
         },
 
         schema: [
@@ -51,7 +51,7 @@ module.exports = {
     create(context) {
 
         const config = context.options[0] || {};
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const exceptions = new Set(config.exceptions || []);
         const modifiedBuiltins = new Set(
             Object.keys(globals.builtin)

package/lib/rules/no-extra-bind.js

@@ -28,7 +28,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary calls to `.bind()`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-extra-bind"
+            url: "https://eslint.org/docs/latest/rules/no-extra-bind"
         },
 
         schema: [],
@@ -40,7 +40,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         let scopeInfo = null;
 
         /**

package/lib/rules/no-extra-boolean-cast.js

@@ -26,7 +26,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary boolean casts",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-extra-boolean-cast"
+            url: "https://eslint.org/docs/latest/rules/no-extra-boolean-cast"
         },
 
         schema: [{
@@ -48,7 +48,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         // Node types which have a test which will coerce values to booleans.
         const BOOLEAN_NODE_TYPES = new Set([

package/lib/rules/no-extra-label.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary labels",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-extra-label"
+            url: "https://eslint.org/docs/latest/rules/no-extra-label"
         },
 
         schema: [],
@@ -35,7 +35,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         let scopeInfo = null;
 
         /**

package/lib/rules/no-extra-parens.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary parentheses",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-extra-parens"
+            url: "https://eslint.org/docs/latest/rules/no-extra-parens"
         },
 
         fixable: "code",
@@ -46,6 +46,7 @@ module.exports = {
                             type: "object",
                             properties: {
                                 conditionalAssign: { type: "boolean" },
+                                ternaryOperandBinaryExpressions: { type: "boolean" },
                                 nestedBinaryExpressions: { type: "boolean" },
                                 returnAssign: { type: "boolean" },
                                 ignoreJSX: { enum: ["none", "all", "single-line", "multi-line"] },
@@ -70,12 +71,13 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         const tokensToIgnore = new WeakSet();
         const precedence = astUtils.getPrecedence;
         const ALL_NODES = context.options[0] !== "functions";
         const EXCEPT_COND_ASSIGN = ALL_NODES && context.options[1] && context.options[1].conditionalAssign === false;
+        const EXCEPT_COND_TERNARY = ALL_NODES && context.options[1] && context.options[1].ternaryOperandBinaryExpressions === false;
         const NESTED_BINARY = ALL_NODES && context.options[1] && context.options[1].nestedBinaryExpressions === false;
         const EXCEPT_RETURN_ASSIGN = ALL_NODES && context.options[1] && context.options[1].returnAssign === false;
         const IGNORE_JSX = ALL_NODES && context.options[1] && context.options[1].ignoreJSX;
@@ -386,6 +388,30 @@ module.exports = {
             return node && (node.type === "Identifier" || node.type === "MemberExpression");
         }
 
+        /**
+         * Checks if a node is fixable.
+         * A node is fixable if removing a single pair of surrounding parentheses does not turn it
+         * into a directive after fixing other nodes.
+         * Almost all nodes are fixable, except if all of the following conditions are met:
+         * The node is a string Literal
+         * It has a single pair of parentheses
+         * It is the only child of an ExpressionStatement
+         * @param {ASTNode} node The node to evaluate.
+         * @returns {boolean} Whether or not the node is fixable.
+         * @private
+         */
+        function isFixable(node) {
+
+            // if it's not a string literal it can be autofixed
+            if (node.type !== "Literal" || typeof node.value !== "string") {
+                return true;
+            }
+            if (isParenthesisedTwice(node)) {
+                return true;
+            }
+            return !astUtils.isTopLevelExpressionStatement(node.parent);
+        }
+
         /**
          * Report the node
          * @param {ASTNode} node node to evaluate
@@ -429,14 +455,16 @@ module.exports = {
                     node,
                     loc: leftParenToken.loc,
                     messageId: "unexpected",
-                    fix(fixer) {
-                        const parenthesizedSource = sourceCode.text.slice(leftParenToken.range[1], rightParenToken.range[0]);
-
-                        return fixer.replaceTextRange([
-                            leftParenToken.range[0],
-                            rightParenToken.range[1]
-                        ], (requiresLeadingSpace(node) ? " " : "") + parenthesizedSource + (requiresTrailingSpace(node) ? " " : ""));
-                    }
+                    fix: isFixable(node)
+                        ? fixer => {
+                            const parenthesizedSource = sourceCode.text.slice(leftParenToken.range[1], rightParenToken.range[0]);
+
+                            return fixer.replaceTextRange([
+                                leftParenToken.range[0],
+                                rightParenToken.range[1]
+                            ], (requiresLeadingSpace(node) ? " " : "") + parenthesizedSource + (requiresTrailingSpace(node) ? " " : ""));
+                        }
+                        : null
                 });
             }
 
@@ -860,18 +888,26 @@ module.exports = {
                 if (isReturnAssignException(node)) {
                     return;
                 }
+
+                const availableTypes = new Set(["BinaryExpression", "LogicalExpression"]);
+
                 if (
+                    !(EXCEPT_COND_TERNARY && availableTypes.has(node.test.type)) &&
                     !isCondAssignException(node) &&
                     hasExcessParensWithPrecedence(node.test, precedence({ type: "LogicalExpression", operator: "||" }))
                 ) {
                     report(node.test);
                 }
 
-                if (hasExcessParensWithPrecedence(node.consequent, PRECEDENCE_OF_ASSIGNMENT_EXPR)) {
+                if (
+                    !(EXCEPT_COND_TERNARY && availableTypes.has(node.consequent.type)) &&
+                    hasExcessParensWithPrecedence(node.consequent, PRECEDENCE_OF_ASSIGNMENT_EXPR)) {
                     report(node.consequent);
                 }
 
-                if (hasExcessParensWithPrecedence(node.alternate, PRECEDENCE_OF_ASSIGNMENT_EXPR)) {
+                if (
+                    !(EXCEPT_COND_TERNARY && availableTypes.has(node.alternate.type)) &&
+                    hasExcessParensWithPrecedence(node.alternate, PRECEDENCE_OF_ASSIGNMENT_EXPR)) {
                     report(node.alternate);
                 }
             },

package/lib/rules/no-extra-semi.js

@@ -24,7 +24,7 @@ module.exports = {
         docs: {
             description: "Disallow unnecessary semicolons",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-extra-semi"
+            url: "https://eslint.org/docs/latest/rules/no-extra-semi"
         },
 
         fixable: "code",
@@ -36,7 +36,24 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
+
+        /**
+         * Checks if a node or token is fixable.
+         * A node is fixable if it can be removed without turning a subsequent statement into a directive after fixing other nodes.
+         * @param {Token} nodeOrToken The node or token to check.
+         * @returns {boolean} Whether or not the node is fixable.
+         */
+        function isFixable(nodeOrToken) {
+            const nextToken = sourceCode.getTokenAfter(nodeOrToken);
+
+            if (!nextToken || nextToken.type !== "String") {
+                return true;
+            }
+            const stringNode = sourceCode.getNodeByRangeIndex(nextToken.range[0]);
+
+            return !astUtils.isTopLevelExpressionStatement(stringNode.parent);
+        }
 
         /**
          * Reports an unnecessary semicolon error.
@@ -47,17 +64,18 @@ module.exports = {
             context.report({
                 node: nodeOrToken,
                 messageId: "unexpected",
-                fix(fixer) {
-
-                    /*
-                     * Expand the replacement range to include the surrounding
-                     * tokens to avoid conflicting with semi.
-                     * https://github.com/eslint/eslint/issues/7928
-                     */
-                    return new FixTracker(fixer, context.getSourceCode())
-                        .retainSurroundingTokens(nodeOrToken)
-                        .remove(nodeOrToken);
-                }
+                fix: isFixable(nodeOrToken)
+                    ? fixer =>
+
+                        /*
+                         * Expand the replacement range to include the surrounding
+                         * tokens to avoid conflicting with semi.
+                         * https://github.com/eslint/eslint/issues/7928
+                         */
+                        new FixTracker(fixer, context.sourceCode)
+                            .retainSurroundingTokens(nodeOrToken)
+                            .remove(nodeOrToken)
+                    : null
             });
         }
 

package/lib/rules/no-fallthrough.js

@@ -35,7 +35,7 @@ function isFallThroughComment(comment, fallthroughCommentPattern) {
  * @returns {boolean} `true` if the case has a valid fallthrough comment.
  */
 function hasFallthroughComment(caseWhichFallsThrough, subsequentCase, context, fallthroughCommentPattern) {
-    const sourceCode = context.getSourceCode();
+    const sourceCode = context.sourceCode;
 
     if (caseWhichFallsThrough.consequent.length === 1 && caseWhichFallsThrough.consequent[0].type === "BlockStatement") {
         const trailingCloseBrace = sourceCode.getLastToken(caseWhichFallsThrough.consequent[0]);
@@ -82,7 +82,7 @@ module.exports = {
         docs: {
             description: "Disallow fallthrough of `case` statements",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-fallthrough"
+            url: "https://eslint.org/docs/latest/rules/no-fallthrough"
         },
 
         schema: [
@@ -110,7 +110,7 @@ module.exports = {
     create(context) {
         const options = context.options[0] || {};
         let currentCodePath = null;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const allowEmptyCase = options.allowEmptyCase || false;
 
         /*

package/lib/rules/no-floating-decimal.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Disallow leading or trailing decimal points in numeric literals",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-floating-decimal"
+            url: "https://eslint.org/docs/latest/rules/no-floating-decimal"
         },
 
         schema: [],
@@ -35,7 +35,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             Literal(node) {

package/lib/rules/no-func-assign.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Disallow reassigning `function` declarations",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-func-assign"
+            url: "https://eslint.org/docs/latest/rules/no-func-assign"
         },
 
         schema: [],
@@ -31,7 +31,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports a reference if is non initializer and writable.

package/lib/rules/no-global-assign.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Disallow assignments to native objects or read-only global variables",
             recommended: true,
-            url: "https://eslint.org/docs/rules/no-global-assign"
+            url: "https://eslint.org/docs/latest/rules/no-global-assign"
         },
 
         schema: [
@@ -41,7 +41,7 @@ module.exports = {
 
     create(context) {
         const config = context.options[0];
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const exceptions = (config && config.exceptions) || [];
 
         /**

package/lib/rules/no-implicit-coercion.js

@@ -193,7 +193,7 @@ module.exports = {
         docs: {
             description: "Disallow shorthand type conversions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-implicit-coercion"
+            url: "https://eslint.org/docs/latest/rules/no-implicit-coercion"
         },
 
         fixable: "code",
@@ -235,7 +235,7 @@ module.exports = {
 
     create(context) {
         const options = parseOptions(context.options[0] || {});
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports an error and autofixes the node