eslint 8.39.0 → 8.47.0

package/lib/linter/report-translator.js

@@ -17,6 +17,8 @@ const interpolate = require("./interpolate");
 // Typedefs
 //------------------------------------------------------------------------------
 
+/** @typedef {import("../shared/types").LintMessage} LintMessage */
+
 /**
  * An error message description
  * @typedef {Object} MessageDescriptor
@@ -29,23 +31,6 @@ const interpolate = require("./interpolate");
  * @property {Array<{desc?: string, messageId?: string, fix: Function}>} suggest Suggestion descriptions and functions to create a the associated fixes.
  */
 
-/**
- * Information about the report
- * @typedef {Object} ReportInfo
- * @property {string} ruleId The rule ID
- * @property {(0|1|2)} severity Severity of the error
- * @property {(string|undefined)} message The message
- * @property {(string|undefined)} [messageId] The message ID
- * @property {number} line The line number
- * @property {number} column The column number
- * @property {(number|undefined)} [endLine] The ending line number
- * @property {(number|undefined)} [endColumn] The ending column number
- * @property {(string|null)} nodeType Type of node
- * @property {string} source Source text
- * @property {({text: string, range: (number[]|null)}|null)} [fix] The fix object
- * @property {Array<{text: string, range: (number[]|null)}|null>} [suggestions] Suggestion info
- */
-
 //------------------------------------------------------------------------------
 // Module Definition
 //------------------------------------------------------------------------------
@@ -115,6 +100,22 @@ function normalizeReportLoc(descriptor) {
     return descriptor.node.loc;
 }
 
+/**
+ * Clones the given fix object.
+ * @param {Fix|null} fix The fix to clone.
+ * @returns {Fix|null} Deep cloned fix object or `null` if `null` or `undefined` was passed in.
+ */
+function cloneFix(fix) {
+    if (!fix) {
+        return null;
+    }
+
+    return {
+        range: [fix.range[0], fix.range[1]],
+        text: fix.text
+    };
+}
+
 /**
  * Check that a fix has a valid range.
  * @param {Fix|null} fix The fix to validate.
@@ -152,7 +153,7 @@ function mergeFixes(fixes, sourceCode) {
         return null;
     }
     if (fixes.length === 1) {
-        return fixes[0];
+        return cloneFix(fixes[0]);
     }
 
     fixes.sort(compareFixesByRange);
@@ -198,7 +199,7 @@ function normalizeFixes(descriptor, sourceCode) {
     }
 
     assertValidFix(fix);
-    return fix;
+    return cloneFix(fix);
 }
 
 /**
@@ -239,7 +240,7 @@ function mapSuggestions(descriptor, sourceCode, messages) {
  * @param {{start: SourceLocation, end: (SourceLocation|null)}} options.loc Start and end location
  * @param {{text: string, range: (number[]|null)}} options.fix The fix object
  * @param {Array<{text: string, range: (number[]|null)}>} options.suggestions The array of suggestions objects
- * @returns {function(...args): ReportInfo} Function that returns information about the report
+ * @returns {LintMessage} Information about the report
  */
 function createProblem(options) {
     const problem = {
@@ -314,7 +315,7 @@ function validateSuggestions(suggest, messages) {
  * problem for the Node.js API.
  * @param {{ruleId: string, severity: number, sourceCode: SourceCode, messageIds: Object, disableFixes: boolean}} metadata Metadata for the reported problem
  * @param {SourceCode} sourceCode The `SourceCode` instance for the text being linted
- * @returns {function(...args): ReportInfo} Function that returns information about the report
+ * @returns {function(...args): LintMessage} Function that returns information about the report
  */
 
 module.exports = function createReportTranslator(metadata) {

package/lib/rule-tester/flat-rule-tester.js

@@ -33,7 +33,7 @@ const { ConfigArraySymbol } = require("@humanwhocodes/config-array");
 /** @typedef {import("../shared/types").Parser} Parser */
 /** @typedef {import("../shared/types").LanguageOptions} LanguageOptions */
 
-/* eslint-disable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
+
 /**
  * A test case that is expected to pass lint.
  * @typedef {Object} ValidTestCase
@@ -72,7 +72,6 @@ const { ConfigArraySymbol } = require("@humanwhocodes/config-array");
  * @property {number} [endLine] The 1-based line number of the reported end location.
  * @property {number} [endColumn] The 1-based column number of the reported end location.
  */
-/* eslint-enable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
 
 //------------------------------------------------------------------------------
 // Private Members

package/lib/rule-tester/rule-tester.js

@@ -63,7 +63,7 @@ const { SourceCode } = require("../source-code");
 
 /** @typedef {import("../shared/types").Parser} Parser */
 
-/* eslint-disable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
+
 /**
  * A test case that is expected to pass lint.
  * @typedef {Object} ValidTestCase
@@ -108,7 +108,6 @@ const { SourceCode } = require("../source-code");
  * @property {number} [endLine] The 1-based line number of the reported end location.
  * @property {number} [endColumn] The 1-based column number of the reported end location.
  */
-/* eslint-enable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
 
 //------------------------------------------------------------------------------
 // Private Members

package/lib/rules/accessor-pairs.js

@@ -142,7 +142,7 @@ module.exports = {
         docs: {
             description: "Enforce getter and setter pairs in objects and classes",
             recommended: false,
-            url: "https://eslint.org/docs/rules/accessor-pairs"
+            url: "https://eslint.org/docs/latest/rules/accessor-pairs"
         },
 
         schema: [{
@@ -178,7 +178,7 @@ module.exports = {
         const checkGetWithoutSet = config.getWithoutSet === true;
         const checkSetWithoutGet = config.setWithoutGet !== false;
         const enforceForClassMembers = config.enforceForClassMembers !== false;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports the given node.
@@ -223,43 +223,6 @@ module.exports = {
             }
         }
 
-        /**
-         * Creates a new `AccessorData` object for the given getter or setter node.
-         * @param {ASTNode} node A getter or setter node.
-         * @returns {AccessorData} New `AccessorData` object that contains the given node.
-         * @private
-         */
-        function createAccessorData(node) {
-            const name = astUtils.getStaticPropertyName(node);
-            const key = (name !== null) ? name : sourceCode.getTokens(node.key);
-
-            return {
-                key,
-                getters: node.kind === "get" ? [node] : [],
-                setters: node.kind === "set" ? [node] : []
-            };
-        }
-
-        /**
-         * Merges the given `AccessorData` object into the given accessors list.
-         * @param {AccessorData[]} accessors The list to merge into.
-         * @param {AccessorData} accessorData The object to merge.
-         * @returns {AccessorData[]} The same instance with the merged object.
-         * @private
-         */
-        function mergeAccessorData(accessors, accessorData) {
-            const equalKeyElement = accessors.find(a => areEqualKeys(a.key, accessorData.key));
-
-            if (equalKeyElement) {
-                equalKeyElement.getters.push(...accessorData.getters);
-                equalKeyElement.setters.push(...accessorData.setters);
-            } else {
-                accessors.push(accessorData);
-            }
-
-            return accessors;
-        }
-
         /**
          * Checks accessor pairs in the given list of nodes.
          * @param {ASTNode[]} nodes The list to check.
@@ -267,10 +230,39 @@ module.exports = {
          * @private
          */
         function checkList(nodes) {
-            const accessors = nodes
-                .filter(isAccessorKind)
-                .map(createAccessorData)
-                .reduce(mergeAccessorData, []);
+            const accessors = [];
+            let found = false;
+
+            for (let i = 0; i < nodes.length; i++) {
+                const node = nodes[i];
+
+                if (isAccessorKind(node)) {
+
+                    // Creates a new `AccessorData` object for the given getter or setter node.
+                    const name = astUtils.getStaticPropertyName(node);
+                    const key = (name !== null) ? name : sourceCode.getTokens(node.key);
+
+                    // Merges the given `AccessorData` object into the given accessors list.
+                    for (let j = 0; j < accessors.length; j++) {
+                        const accessor = accessors[j];
+
+                        if (areEqualKeys(accessor.key, key)) {
+                            accessor.getters.push(...node.kind === "get" ? [node] : []);
+                            accessor.setters.push(...node.kind === "set" ? [node] : []);
+                            found = true;
+                            break;
+                        }
+                    }
+                    if (!found) {
+                        accessors.push({
+                            key,
+                            getters: node.kind === "get" ? [node] : [],
+                            setters: node.kind === "set" ? [node] : []
+                        });
+                    }
+                    found = false;
+                }
+            }
 
             for (const { getters, setters } of accessors) {
                 if (checkSetWithoutGet && setters.length && !getters.length) {

package/lib/rules/array-bracket-newline.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Enforce linebreaks after opening and before closing array brackets",
             recommended: false,
-            url: "https://eslint.org/docs/rules/array-bracket-newline"
+            url: "https://eslint.org/docs/latest/rules/array-bracket-newline"
         },
 
         fixable: "whitespace",
@@ -56,7 +56,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
 
         //----------------------------------------------------------------------

package/lib/rules/array-bracket-spacing.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing inside array brackets",
             recommended: false,
-            url: "https://eslint.org/docs/rules/array-bracket-spacing"
+            url: "https://eslint.org/docs/latest/rules/array-bracket-spacing"
         },
 
         fixable: "whitespace",
@@ -53,7 +53,7 @@ module.exports = {
     },
     create(context) {
         const spaced = context.options[0] === "always",
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
 
         /**
          * Determines whether an option is set, relative to the spacing option.

package/lib/rules/array-callback-return.js

@@ -141,7 +141,7 @@ module.exports = {
         docs: {
             description: "Enforce `return` statements in callbacks of array methods",
             recommended: false,
-            url: "https://eslint.org/docs/rules/array-callback-return"
+            url: "https://eslint.org/docs/latest/rules/array-callback-return"
         },
 
         schema: [
@@ -172,7 +172,7 @@ module.exports = {
     create(context) {
 
         const options = context.options[0] || { allowImplicit: false, checkForEach: false };
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         let funcInfo = {
             arrayMethodName: null,

package/lib/rules/array-element-newline.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Enforce line breaks after each array element",
             recommended: false,
-            url: "https://eslint.org/docs/rules/array-element-newline"
+            url: "https://eslint.org/docs/latest/rules/array-element-newline"
         },
 
         fixable: "whitespace",
@@ -79,7 +79,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //----------------------------------------------------------------------
         // Helpers
@@ -240,19 +240,25 @@ module.exports = {
                     .some(element => element.loc.start.line !== element.loc.end.line);
             }
 
-            const linebreaksCount = node.elements.map((element, i) => {
+            let linebreaksCount = 0;
+
+            for (let i = 0; i < node.elements.length; i++) {
+                const element = node.elements[i];
+
                 const previousElement = elements[i - 1];
 
                 if (i === 0 || element === null || previousElement === null) {
-                    return false;
+                    continue;
                 }
 
                 const commaToken = sourceCode.getFirstTokenBetween(previousElement, element, astUtils.isCommaToken);
                 const lastTokenOfPreviousElement = sourceCode.getTokenBefore(commaToken);
                 const firstTokenOfCurrentElement = sourceCode.getTokenAfter(commaToken);
 
-                return !astUtils.isTokenOnSameLine(lastTokenOfPreviousElement, firstTokenOfCurrentElement);
-            }).filter(isBreak => isBreak === true).length;
+                if (!astUtils.isTokenOnSameLine(lastTokenOfPreviousElement, firstTokenOfCurrentElement)) {
+                    linebreaksCount++;
+                }
+            }
 
             const needsLinebreaks = (
                 elements.length >= options.minItems ||

package/lib/rules/arrow-body-style.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Require braces around arrow function bodies",
             recommended: false,
-            url: "https://eslint.org/docs/rules/arrow-body-style"
+            url: "https://eslint.org/docs/latest/rules/arrow-body-style"
         },
 
         schema: {
@@ -74,7 +74,7 @@ module.exports = {
         const asNeeded = !options[0] || options[0] === "as-needed";
         const never = options[0] === "never";
         const requireReturnForObjectLiteral = options[1] && options[1].requireReturnForObjectLiteral;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         let funcInfo = null;
 
         /**

package/lib/rules/arrow-parens.js

@@ -35,7 +35,7 @@ module.exports = {
         docs: {
             description: "Require parentheses around arrow function arguments",
             recommended: false,
-            url: "https://eslint.org/docs/rules/arrow-parens"
+            url: "https://eslint.org/docs/latest/rules/arrow-parens"
         },
 
         fixable: "code",
@@ -69,7 +69,7 @@ module.exports = {
         const asNeeded = context.options[0] === "as-needed";
         const requireForBlockBody = asNeeded && context.options[1] && context.options[1].requireForBlockBody === true;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Finds opening paren of parameters for the given arrow function, if it exists.

package/lib/rules/arrow-spacing.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing before and after the arrow in arrow functions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/arrow-spacing"
+            url: "https://eslint.org/docs/latest/rules/arrow-spacing"
         },
 
         fixable: "whitespace",
@@ -61,7 +61,7 @@ module.exports = {
         rule.before = rule.before !== false;
         rule.after = rule.after !== false;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Get tokens of arrow(`=>`) and before/after arrow.

package/lib/rules/block-scoped-var.js

@@ -16,19 +16,19 @@ module.exports = {
         docs: {
             description: "Enforce the use of variables within the scope they are defined",
             recommended: false,
-            url: "https://eslint.org/docs/rules/block-scoped-var"
+            url: "https://eslint.org/docs/latest/rules/block-scoped-var"
         },
 
         schema: [],
 
         messages: {
-            outOfScope: "'{{name}}' used outside of binding context."
+            outOfScope: "'{{name}}' declared on line {{definitionLine}} column {{definitionColumn}} is used outside of binding context."
         }
     },
 
     create(context) {
         let stack = [];
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Makes a block scope.
@@ -50,12 +50,22 @@ module.exports = {
         /**
          * Reports a given reference.
          * @param {eslint-scope.Reference} reference A reference to report.
+         * @param {eslint-scope.Definition} definition A definition for which to report reference.
          * @returns {void}
          */
-        function report(reference) {
+        function report(reference, definition) {
             const identifier = reference.identifier;
-
-            context.report({ node: identifier, messageId: "outOfScope", data: { name: identifier.name } });
+            const definitionPosition = definition.name.loc.start;
+
+            context.report({
+                node: identifier,
+                messageId: "outOfScope",
+                data: {
+                    name: identifier.name,
+                    definitionLine: definitionPosition.line,
+                    definitionColumn: definitionPosition.column + 1
+                }
+            });
         }
 
         /**
@@ -92,7 +102,7 @@ module.exports = {
                 variables[i]
                     .references
                     .filter(isOutsideOfScope)
-                    .forEach(report);
+                    .forEach(ref => report(ref, variables[i].defs.find(def => def.parent === node)));
             }
         }
 

package/lib/rules/block-spacing.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Disallow or enforce spaces inside of blocks after opening block and before closing block",
             recommended: false,
-            url: "https://eslint.org/docs/rules/block-spacing"
+            url: "https://eslint.org/docs/latest/rules/block-spacing"
         },
 
         fixable: "whitespace",
@@ -37,7 +37,7 @@ module.exports = {
     create(context) {
         const always = (context.options[0] !== "never"),
             messageId = always ? "missing" : "extra",
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
 
         /**
          * Gets the open brace token from a given node.

package/lib/rules/brace-style.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent brace style for blocks",
             recommended: false,
-            url: "https://eslint.org/docs/rules/brace-style"
+            url: "https://eslint.org/docs/latest/rules/brace-style"
         },
 
         schema: [
@@ -53,7 +53,7 @@ module.exports = {
     create(context) {
         const style = context.options[0] || "1tbs",
             params = context.options[1] || {},
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
 
         //--------------------------------------------------------------------------
         // Helpers

package/lib/rules/callback-return.js

@@ -21,7 +21,7 @@ module.exports = {
         docs: {
             description: "Require `return` statements after callbacks",
             recommended: false,
-            url: "https://eslint.org/docs/rules/callback-return"
+            url: "https://eslint.org/docs/latest/rules/callback-return"
         },
 
         schema: [{
@@ -37,7 +37,7 @@ module.exports = {
     create(context) {
 
         const callbacks = context.options[0] || ["callback", "cb", "next"],
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
 
         //--------------------------------------------------------------------------
         // Helpers

package/lib/rules/camelcase.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Enforce camelcase naming convention",
             recommended: false,
-            url: "https://eslint.org/docs/rules/camelcase"
+            url: "https://eslint.org/docs/latest/rules/camelcase"
         },
 
         schema: [
@@ -73,7 +73,7 @@ module.exports = {
         const ignoreImports = options.ignoreImports;
         const ignoreGlobals = options.ignoreGlobals;
         const allow = options.allow || [];
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //--------------------------------------------------------------------------
         // Helpers

package/lib/rules/capitalized-comments.js

@@ -107,7 +107,7 @@ module.exports = {
         docs: {
             description: "Enforce or disallow capitalization of the first letter of a comment",
             recommended: false,
-            url: "https://eslint.org/docs/rules/capitalized-comments"
+            url: "https://eslint.org/docs/latest/rules/capitalized-comments"
         },
 
         fixable: "code",
@@ -139,7 +139,7 @@ module.exports = {
 
         const capitalize = context.options[0] || "always",
             normalizedOptions = getAllNormalizedOptions(context.options[1]),
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
 
         createRegExpForIgnorePatterns(normalizedOptions);
 

package/lib/rules/class-methods-use-this.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Enforce that class methods utilize `this`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/class-methods-use-this"
+            url: "https://eslint.org/docs/latest/rules/class-methods-use-this"
         },
 
         schema: [{
@@ -133,7 +133,7 @@ module.exports = {
             if (isIncludedInstanceMethod(node.parent) && !methodUsesThis) {
                 context.report({
                     node,
-                    loc: astUtils.getFunctionHeadLoc(node, context.getSourceCode()),
+                    loc: astUtils.getFunctionHeadLoc(node, context.sourceCode),
                     messageId: "missingThis",
                     data: {
                         name: astUtils.getFunctionNameWithKind(node)

package/lib/rules/comma-dangle.js

@@ -78,7 +78,7 @@ module.exports = {
         docs: {
             description: "Require or disallow trailing commas",
             recommended: false,
-            url: "https://eslint.org/docs/rules/comma-dangle"
+            url: "https://eslint.org/docs/latest/rules/comma-dangle"
         },
 
         fixable: "code",
@@ -136,7 +136,7 @@ module.exports = {
     create(context) {
         const options = normalizeOptions(context.options[0], context.languageOptions.ecmaVersion);
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Gets the last item of the given node.

package/lib/rules/comma-spacing.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing before and after commas",
             recommended: false,
-            url: "https://eslint.org/docs/rules/comma-spacing"
+            url: "https://eslint.org/docs/latest/rules/comma-spacing"
         },
 
         fixable: "whitespace",
@@ -48,7 +48,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const tokensAndComments = sourceCode.tokensAndComments;
 
         const options = {

package/lib/rules/comma-style.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent comma style",
             recommended: false,
-            url: "https://eslint.org/docs/rules/comma-style"
+            url: "https://eslint.org/docs/latest/rules/comma-style"
         },
 
         fixable: "code",
@@ -51,7 +51,7 @@ module.exports = {
 
     create(context) {
         const style = context.options[0] || "last",
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
         const exceptions = {
             ArrayPattern: true,
             ArrowFunctionExpression: true,

package/lib/rules/complexity.js

@@ -25,7 +25,7 @@ module.exports = {
         docs: {
             description: "Enforce a maximum cyclomatic complexity allowed in a program",
             recommended: false,
-            url: "https://eslint.org/docs/rules/complexity"
+            url: "https://eslint.org/docs/latest/rules/complexity"
         },
 
         schema: [

package/lib/rules/computed-property-spacing.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing inside computed property brackets",
             recommended: false,
-            url: "https://eslint.org/docs/rules/computed-property-spacing"
+            url: "https://eslint.org/docs/latest/rules/computed-property-spacing"
         },
 
         fixable: "whitespace",
@@ -49,7 +49,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const propertyNameMustBeSpaced = context.options[0] === "always"; // default is "never"
         const enforceForClassMembers = !context.options[1] || context.options[1].enforceForClassMembers;