eslint 8.39.0 → 8.47.0

package/lib/rules/require-atomic-updates.js

@@ -173,7 +173,7 @@ module.exports = {
         docs: {
             description: "Disallow assignments that can lead to race conditions due to usage of `await` or `yield`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/require-atomic-updates"
+            url: "https://eslint.org/docs/latest/rules/require-atomic-updates"
         },
 
         fixable: null,
@@ -198,7 +198,7 @@ module.exports = {
     create(context) {
         const allowProperties = !!context.options[0] && context.options[0].allowProperties;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const assignmentReferences = new Map();
         const segmentInfo = new SegmentInfo();
         let stack = null;

package/lib/rules/require-await.js

@@ -36,7 +36,7 @@ module.exports = {
         docs: {
             description: "Disallow async functions which have no `await` expression",
             recommended: false,
-            url: "https://eslint.org/docs/rules/require-await"
+            url: "https://eslint.org/docs/latest/rules/require-await"
         },
 
         schema: [],
@@ -47,7 +47,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         let scopeInfo = null;
 
         /**

package/lib/rules/require-jsdoc.js

@@ -13,7 +13,7 @@ module.exports = {
         docs: {
             description: "Require JSDoc comments",
             recommended: false,
-            url: "https://eslint.org/docs/rules/require-jsdoc"
+            url: "https://eslint.org/docs/latest/rules/require-jsdoc"
         },
 
         schema: [
@@ -61,7 +61,7 @@ module.exports = {
     },
 
     create(context) {
-        const source = context.getSourceCode();
+        const source = context.sourceCode;
         const DEFAULT_OPTIONS = {
             FunctionDeclaration: true,
             MethodDefinition: false,

package/lib/rules/require-unicode-regexp.js

@@ -28,9 +28,9 @@ module.exports = {
         type: "suggestion",
 
         docs: {
-            description: "Enforce the use of `u` flag on RegExp",
+            description: "Enforce the use of `u` or `v` flag on RegExp",
             recommended: false,
-            url: "https://eslint.org/docs/rules/require-unicode-regexp"
+            url: "https://eslint.org/docs/latest/rules/require-unicode-regexp"
         },
 
         hasSuggestions: true,
@@ -45,13 +45,13 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             "Literal[regex]"(node) {
                 const flags = node.regex.flags || "";
 
-                if (!flags.includes("u")) {
+                if (!flags.includes("u") && !flags.includes("v")) {
                     context.report({
                         messageId: "requireUFlag",
                         node,
@@ -85,7 +85,7 @@ module.exports = {
                     const pattern = getStringIfConstant(patternNode, scope);
                     const flags = getStringIfConstant(flagsNode, scope);
 
-                    if (!flagsNode || (typeof flags === "string" && !flags.includes("u"))) {
+                    if (!flagsNode || (typeof flags === "string" && !flags.includes("u") && !flags.includes("v"))) {
                         context.report({
                             messageId: "requireUFlag",
                             node: refNode,

package/lib/rules/require-yield.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Require generator functions to contain `yield`",
             recommended: true,
-            url: "https://eslint.org/docs/rules/require-yield"
+            url: "https://eslint.org/docs/latest/rules/require-yield"
         },
 
         schema: [],

package/lib/rules/rest-spread-spacing.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Enforce spacing between rest and spread operators and their expressions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/rest-spread-spacing"
+            url: "https://eslint.org/docs/latest/rules/rest-spread-spacing"
         },
 
         fixable: "whitespace",
@@ -35,7 +35,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode(),
+        const sourceCode = context.sourceCode,
             alwaysSpace = context.options[0] === "always";
 
         //--------------------------------------------------------------------------

package/lib/rules/semi-spacing.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing before and after semicolons",
             recommended: false,
-            url: "https://eslint.org/docs/rules/semi-spacing"
+            url: "https://eslint.org/docs/latest/rules/semi-spacing"
         },
 
         fixable: "whitespace",
@@ -52,7 +52,7 @@ module.exports = {
     create(context) {
 
         const config = context.options[0],
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
         let requireSpaceBefore = false,
             requireSpaceAfter = true;
 

package/lib/rules/semi-style.js

@@ -75,7 +75,7 @@ module.exports = {
         docs: {
             description: "Enforce location of semicolons",
             recommended: false,
-            url: "https://eslint.org/docs/rules/semi-style"
+            url: "https://eslint.org/docs/latest/rules/semi-style"
         },
 
         schema: [{ enum: ["last", "first"] }],
@@ -87,7 +87,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const option = context.options[0] || "last";
 
         /**

package/lib/rules/semi.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Require or disallow semicolons instead of ASI",
             recommended: false,
-            url: "https://eslint.org/docs/rules/semi"
+            url: "https://eslint.org/docs/latest/rules/semi"
         },
 
         fixable: "code",
@@ -58,7 +58,8 @@ module.exports = {
                         {
                             type: "object",
                             properties: {
-                                omitLastInOneLineBlock: { type: "boolean" }
+                                omitLastInOneLineBlock: { type: "boolean" },
+                                omitLastInOneLineClassBody: { type: "boolean" }
                             },
                             additionalProperties: false
                         }
@@ -83,8 +84,9 @@ module.exports = {
         const options = context.options[1];
         const never = context.options[0] === "never";
         const exceptOneLine = Boolean(options && options.omitLastInOneLineBlock);
+        const exceptOneLineClassBody = Boolean(options && options.omitLastInOneLineClassBody);
         const beforeStatementContinuationChars = options && options.beforeStatementContinuationChars || "any";
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //--------------------------------------------------------------------------
         // Helpers
@@ -334,6 +336,27 @@ module.exports = {
             return false;
         }
 
+        /**
+         * Checks a node to see if it's the last item in a one-liner `ClassBody` node.
+         * ClassBody is a one-liner if its braces (and consequently everything between them) are on the same line.
+         * @param {ASTNode} node The node to check.
+         * @returns {boolean} whether the node is the last item in a one-liner ClassBody.
+         */
+        function isLastInOneLinerClassBody(node) {
+            const parent = node.parent;
+            const nextToken = sourceCode.getTokenAfter(node);
+
+            if (!nextToken || nextToken.value !== "}") {
+                return false;
+            }
+
+            if (parent.type === "ClassBody") {
+                return parent.loc.start.line === parent.loc.end.line;
+            }
+
+            return false;
+        }
+
         /**
          * Checks a node to see if it's followed by a semicolon.
          * @param {ASTNode} node The node to check.
@@ -354,10 +377,12 @@ module.exports = {
                 }
             } else {
                 const oneLinerBlock = (exceptOneLine && isLastInOneLinerBlock(node));
+                const oneLinerClassBody = (exceptOneLineClassBody && isLastInOneLinerClassBody(node));
+                const oneLinerBlockOrClassBody = oneLinerBlock || oneLinerClassBody;
 
-                if (isSemi && oneLinerBlock) {
+                if (isSemi && oneLinerBlockOrClassBody) {
                     report(node, true);
-                } else if (!isSemi && !oneLinerBlock) {
+                } else if (!isSemi && !oneLinerBlockOrClassBody) {
                     report(node);
                 }
             }

package/lib/rules/sort-imports.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Enforce sorted import declarations within modules",
             recommended: false,
-            url: "https://eslint.org/docs/rules/sort-imports"
+            url: "https://eslint.org/docs/latest/rules/sort-imports"
         },
 
         schema: [
@@ -71,7 +71,7 @@ module.exports = {
             ignoreMemberSort = configuration.ignoreMemberSort || false,
             memberSyntaxSortOrder = configuration.memberSyntaxSortOrder || ["none", "all", "multiple", "single"],
             allowSeparatedGroups = configuration.allowSeparatedGroups || false,
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
         let previousDeclaration = null;
 
         /**

package/lib/rules/sort-keys.js

@@ -83,7 +83,7 @@ module.exports = {
         docs: {
             description: "Require object keys to be sorted",
             recommended: false,
-            url: "https://eslint.org/docs/rules/sort-keys"
+            url: "https://eslint.org/docs/latest/rules/sort-keys"
         },
 
         schema: [
@@ -135,7 +135,7 @@ module.exports = {
 
         // The stack to save the previous property's name for each object literals.
         let stack = null;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             ObjectExpression(node) {

package/lib/rules/sort-vars.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Require variables within the same declaration block to be sorted",
             recommended: false,
-            url: "https://eslint.org/docs/rules/sort-vars"
+            url: "https://eslint.org/docs/latest/rules/sort-vars"
         },
 
         schema: [
@@ -44,7 +44,7 @@ module.exports = {
 
         const configuration = context.options[0] || {},
             ignoreCase = configuration.ignoreCase || false,
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
 
         return {
             VariableDeclaration(node) {

package/lib/rules/space-before-blocks.js

@@ -42,7 +42,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing before blocks",
             recommended: false,
-            url: "https://eslint.org/docs/rules/space-before-blocks"
+            url: "https://eslint.org/docs/latest/rules/space-before-blocks"
         },
 
         fixable: "whitespace",
@@ -80,7 +80,7 @@ module.exports = {
 
     create(context) {
         const config = context.options[0],
-            sourceCode = context.getSourceCode();
+            sourceCode = context.sourceCode;
         let alwaysFunctions = true,
             alwaysKeywords = true,
             alwaysClasses = true,

package/lib/rules/space-before-function-paren.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing before `function` definition opening parenthesis",
             recommended: false,
-            url: "https://eslint.org/docs/rules/space-before-function-paren"
+            url: "https://eslint.org/docs/latest/rules/space-before-function-paren"
         },
 
         fixable: "whitespace",
@@ -59,7 +59,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const baseConfig = typeof context.options[0] === "string" ? context.options[0] : "always";
         const overrideConfig = typeof context.options[0] === "object" ? context.options[0] : {};
 

package/lib/rules/space-in-parens.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing inside parentheses",
             recommended: false,
-            url: "https://eslint.org/docs/rules/space-in-parens"
+            url: "https://eslint.org/docs/latest/rules/space-in-parens"
         },
 
         fixable: "whitespace",
@@ -102,7 +102,7 @@ module.exports = {
         //--------------------------------------------------------------------------
         // Helpers
         //--------------------------------------------------------------------------
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Determines if a token is one of the exceptions for the opener paren

package/lib/rules/space-infix-ops.js

@@ -18,7 +18,7 @@ module.exports = {
         docs: {
             description: "Require spacing around infix operators",
             recommended: false,
-            url: "https://eslint.org/docs/rules/space-infix-ops"
+            url: "https://eslint.org/docs/latest/rules/space-infix-ops"
         },
 
         fixable: "whitespace",
@@ -43,7 +43,7 @@ module.exports = {
 
     create(context) {
         const int32Hint = context.options[0] ? context.options[0].int32Hint === true : false;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Returns the first token which violates the rule

package/lib/rules/space-unary-ops.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing before or after unary operators",
             recommended: false,
-            url: "https://eslint.org/docs/rules/space-unary-ops"
+            url: "https://eslint.org/docs/latest/rules/space-unary-ops"
         },
 
         fixable: "whitespace",
@@ -62,7 +62,7 @@ module.exports = {
     create(context) {
         const options = context.options[0] || { words: true, nonwords: false };
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         //--------------------------------------------------------------------------
         // Helpers

package/lib/rules/spaced-comment.js

@@ -154,7 +154,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing after the `//` or `/*` in a comment",
             recommended: false,
-            url: "https://eslint.org/docs/rules/spaced-comment"
+            url: "https://eslint.org/docs/latest/rules/spaced-comment"
         },
 
         fixable: "whitespace",
@@ -235,7 +235,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         // Unless the first option is never, require a space
         const requireSpace = context.options[0] !== "never";

package/lib/rules/strict.js

@@ -71,7 +71,7 @@ module.exports = {
         docs: {
             description: "Require or disallow strict mode directives",
             recommended: false,
-            url: "https://eslint.org/docs/rules/strict"
+            url: "https://eslint.org/docs/latest/rules/strict"
         },
 
         schema: [

package/lib/rules/switch-colon-spacing.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Enforce spacing around colons of switch statements",
             recommended: false,
-            url: "https://eslint.org/docs/rules/switch-colon-spacing"
+            url: "https://eslint.org/docs/latest/rules/switch-colon-spacing"
         },
 
         schema: [
@@ -46,7 +46,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const options = context.options[0] || {};
         const beforeSpacing = options.before === true; // false by default
         const afterSpacing = options.after !== false; // true by default

package/lib/rules/symbol-description.js

@@ -24,7 +24,7 @@ module.exports = {
         docs: {
             description: "Require symbol descriptions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/symbol-description"
+            url: "https://eslint.org/docs/latest/rules/symbol-description"
         },
         fixable: null,
         schema: [],
@@ -35,7 +35,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports if node does not conform the rule in case rule is set to

package/lib/rules/template-curly-spacing.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Require or disallow spacing around embedded expressions of template strings",
             recommended: false,
-            url: "https://eslint.org/docs/rules/template-curly-spacing"
+            url: "https://eslint.org/docs/latest/rules/template-curly-spacing"
         },
 
         fixable: "whitespace",
@@ -40,7 +40,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const always = context.options[0] === "always";
 
         /**

package/lib/rules/template-tag-spacing.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Require or disallow spacing between template tags and their literals",
             recommended: false,
-            url: "https://eslint.org/docs/rules/template-tag-spacing"
+            url: "https://eslint.org/docs/latest/rules/template-tag-spacing"
         },
 
         fixable: "whitespace",
@@ -33,7 +33,7 @@ module.exports = {
 
     create(context) {
         const never = context.options[0] !== "always";
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Check if a space is present between a template tag and its literal

package/lib/rules/unicode-bom.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Require or disallow Unicode byte order mark (BOM)",
             recommended: false,
-            url: "https://eslint.org/docs/rules/unicode-bom"
+            url: "https://eslint.org/docs/latest/rules/unicode-bom"
         },
 
         fixable: "whitespace",
@@ -42,7 +42,7 @@ module.exports = {
 
             Program: function checkUnicodeBOM(node) {
 
-                const sourceCode = context.getSourceCode(),
+                const sourceCode = context.sourceCode,
                     location = { column: 0, line: 1 },
                     requireBOM = context.options[0] || "never";
 

package/lib/rules/use-isnan.js

@@ -39,7 +39,7 @@ module.exports = {
         docs: {
             description: "Require calls to `isNaN()` when checking for `NaN`",
             recommended: true,
-            url: "https://eslint.org/docs/rules/use-isnan"
+            url: "https://eslint.org/docs/latest/rules/use-isnan"
         },
 
         schema: [

package/lib/rules/utils/ast-utils.js

@@ -9,6 +9,7 @@
 // Requirements
 //------------------------------------------------------------------------------
 
+const { KEYS: eslintVisitorKeys } = require("eslint-visitor-keys");
 const esutils = require("esutils");
 const espree = require("espree");
 const escapeRegExp = require("escape-string-regexp");
@@ -25,8 +26,8 @@ const {
 
 const anyFunctionPattern = /^(?:Function(?:Declaration|Expression)|ArrowFunctionExpression)$/u;
 const anyLoopPattern = /^(?:DoWhile|For|ForIn|ForOf|While)Statement$/u;
+const arrayMethodWithThisArgPattern = /^(?:every|filter|find(?:Last)?(?:Index)?|flatMap|forEach|map|some)$/u;
 const arrayOrTypedArrayPattern = /Array$/u;
-const arrayMethodPattern = /^(?:every|filter|find|findIndex|forEach|map|some)$/u;
 const bindOrCallOrApplyPattern = /^(?:bind|call|apply)$/u;
 const thisTagPattern = /^[\s*]*@this/mu;
 
@@ -466,12 +467,12 @@ function isArrayFromMethod(node) {
 }
 
 /**
- * Checks whether or not a node is a method which has `thisArg`.
+ * Checks whether or not a node is a method which expects a function as a first argument, and `thisArg` as a second argument.
  * @param {ASTNode} node A node to check.
- * @returns {boolean} Whether or not the node is a method which has `thisArg`.
+ * @returns {boolean} Whether or not the node is a method which expects a function as a first argument, and `thisArg` as a second argument.
  */
 function isMethodWhichHasThisArg(node) {
-    return isSpecificMemberAccess(node, null, arrayMethodPattern);
+    return isSpecificMemberAccess(node, null, arrayMethodWithThisArgPattern);
 }
 
 /**
@@ -986,6 +987,34 @@ function isConstant(scope, node, inBooleanPosition) {
     return false;
 }
 
+/**
+ * Checks whether a node is an ExpressionStatement at the top level of a file or function body.
+ * A top-level ExpressionStatement node is a directive if it contains a single unparenthesized
+ * string literal and if it occurs either as the first sibling or immediately after another
+ * directive.
+ * @param {ASTNode} node The node to check.
+ * @returns {boolean} Whether or not the node is an ExpressionStatement at the top level of a
+ * file or function body.
+ */
+function isTopLevelExpressionStatement(node) {
+    if (node.type !== "ExpressionStatement") {
+        return false;
+    }
+    const parent = node.parent;
+
+    return parent.type === "Program" || (parent.type === "BlockStatement" && isFunction(parent.parent));
+
+}
+
+/**
+ * Check whether the given node is a part of a directive prologue or not.
+ * @param {ASTNode} node The node to check.
+ * @returns {boolean} `true` if the node is a part of directive prologue.
+ */
+function isDirective(node) {
+    return node.type === "ExpressionStatement" && typeof node.directive === "string";
+}
+
 //------------------------------------------------------------------------------
 // Public Interface
 //------------------------------------------------------------------------------
@@ -1442,7 +1471,16 @@ module.exports = {
                 return 19;
 
             default:
-                return 20;
+                if (node.type in eslintVisitorKeys) {
+                    return 20;
+                }
+
+                /*
+                 * if the node is not a standard node that we know about, then assume it has the lowest precedence
+                 * this will mean that rules will wrap unknown nodes in parentheses where applicable instead of
+                 * unwrapping them and potentially changing the meaning of the code or introducing a syntax error.
+                 */
+                return -1;
         }
     },
 
@@ -1501,7 +1539,6 @@ module.exports = {
         return directives;
     },
 
-
     /**
      * Determines whether this node is a decimal integer literal. If a node is a decimal integer literal, a dot added
      * after the node will be parsed as a decimal point, rather than a property-access dot.
@@ -2105,6 +2142,15 @@ module.exports = {
         return OCTAL_OR_NON_OCTAL_DECIMAL_ESCAPE_PATTERN.test(rawString);
     },
 
+    /**
+     * Determines whether the given node is a template literal without expressions.
+     * @param {ASTNode} node Node to check.
+     * @returns {boolean} True if the node is a template literal without expressions.
+     */
+    isStaticTemplateLiteral(node) {
+        return node.type === "TemplateLiteral" && node.expressions.length === 0;
+    },
+
     isReferenceToGlobalVariable,
     isLogicalExpression,
     isCoalesceExpression,
@@ -2120,5 +2166,7 @@ module.exports = {
     isLogicalAssignmentOperator,
     getSwitchCaseColonToken,
     getModuleExportName,
-    isConstant
+    isConstant,
+    isTopLevelExpressionStatement,
+    isDirective
 };

package/lib/rules/utils/regular-expressions.js

@@ -8,7 +8,7 @@
 
 const { RegExpValidator } = require("@eslint-community/regexpp");
 
-const REGEXPP_LATEST_ECMA_VERSION = 2022;
+const REGEXPP_LATEST_ECMA_VERSION = 2024;
 
 /**
  * Checks if the given regular expression pattern would be valid with the `u` flag.
@@ -28,7 +28,7 @@ function isValidWithUnicodeFlag(ecmaVersion, pattern) {
     });
 
     try {
-        validator.validatePattern(pattern, void 0, void 0, /* uFlag = */ true);
+        validator.validatePattern(pattern, void 0, void 0, { unicode: /* uFlag = */ true });
     } catch {
         return false;
     }