chrome-devtools-frontend 1.0.1386602 → 1.0.1402249

package/front_end/core/host/AidaClient.ts

@@ -9,10 +9,13 @@ import {InspectorFrontendHostInstance} from './InspectorFrontendHost.js';
 import type {AidaClientResult, SyncInformation} from './InspectorFrontendHostAPI.js';
 import {bindOutputStream} from './ResourceLoader.js';
 
-export enum Entity {
-  UNKNOWN = 0,
+export enum Role {
+  // Unspecified role.
+  ROLE_UNSPECIFIED = 0,
+  // The user.
   USER = 1,
-  SYSTEM = 2,
+  // The model.
+  MODEL = 2,
 }
 
 export const enum Rating {
@@ -21,9 +24,80 @@ export const enum Rating {
   NEGATIVE = 'NEGATIVE',
 }
 
-export interface HistoryChunk {
-  text: string;
-  entity: Entity;
+// A `Content` represents a single turn message.
+export interface Content {
+  parts: Part[];
+  // The producer of the content.
+  role: Role;
+}
+
+export type Part = {
+  text: string,
+}|{
+  functionCall: {
+    name: string,
+    args: Record<string, unknown>,
+  },
+}|{
+  functionResponse: {
+    name: string,
+    response: Record<string, unknown>,
+  },
+}|{
+  // Inline media bytes.
+  inlineData: MediaBlob,
+};
+
+export const enum ParametersTypes {
+  STRING = 1,
+  NUMBER = 2,
+  INTEGER = 3,
+  BOOLEAN = 4,
+  ARRAY = 5,
+  OBJECT = 6,
+}
+
+interface BaseFunctionParam {
+  description: string;
+  nullable?: boolean;
+}
+
+export interface FunctionPrimitiveParams extends BaseFunctionParam {
+  type: ParametersTypes.BOOLEAN|ParametersTypes.INTEGER|ParametersTypes.STRING|ParametersTypes.BOOLEAN;
+}
+
+interface FunctionArrayParam extends BaseFunctionParam {
+  type: ParametersTypes.ARRAY;
+  items: FunctionPrimitiveParams;
+}
+
+export interface FunctionObjectParam extends BaseFunctionParam {
+  type: ParametersTypes.OBJECT;
+  // TODO: this can be also be ObjectParams
+  properties: {[Key in string]: FunctionPrimitiveParams|FunctionArrayParam};
+}
+
+/**
+ * More about function declaration can be read at
+ * https://ai.google.dev/gemini-api/docs/function-calling
+ */
+export interface FunctionDeclaration {
+  name: string;
+  /**
+   * A description for the LLM to understand what the specific function will do once called.
+   */
+  description: string;
+  parameters: FunctionObjectParam|FunctionPrimitiveParams|FunctionArrayParam;
+}
+
+// Raw media bytes.
+export interface MediaBlob {
+  // The IANA standard MIME type of the source data.
+  // Currently supported types are: image/png, image/jpeg.
+  // Format: base64-encoded
+  // For reference: google3/google/x/pitchfork/aida/v1/content.proto
+  mimeType: string;
+  data: string;
 }
 
 export enum FunctionalityType {
@@ -33,6 +107,7 @@ export enum FunctionalityType {
   CHAT = 1,
   // The explain error functionality.
   EXPLAIN_ERROR = 2,
+  AGENTIC_CHAT = 5,
 }
 
 export enum ClientFeature {
@@ -40,14 +115,16 @@ export enum ClientFeature {
   CLIENT_FEATURE_UNSPECIFIED = 0,
   // Chrome console insights feature.
   CHROME_CONSOLE_INSIGHTS = 1,
-  // Chrome freestyler.
-  CHROME_FREESTYLER = 2,
-  // Chrome DrJones Network Agent.
-  CHROME_DRJONES_NETWORK_AGENT = 7,
-  // Chrome DrJones Performance Agent.
-  CHROME_DRJONES_PERFORMANCE_AGENT = 8,
-  // Chrome DrJones File Agent.
-  CHROME_DRJONES_FILE_AGENT = 9,
+  // Chrome AI Assistance Styling Agent.
+  CHROME_STYLING_AGENT = 2,
+  // Chrome AI Assistance Network Agent.
+  CHROME_NETWORK_AGENT = 7,
+  // Chrome AI Assistance Performance Agent.
+  CHROME_PERFORMANCE_AGENT = 8,
+  // Chrome AI Assistance File Agent.
+  CHROME_FILE_AGENT = 9,
+  // Chrome AI Patch Agent.
+  CHROME_PATCH_AGENT = 12,
 }
 
 export enum UserTier {
@@ -61,12 +138,17 @@ export enum UserTier {
   PUBLIC = 3,
 }
 
+export type RpcGlobalId = string|number;
+
 export interface AidaRequest {
-  input: string;
+  client: string;
+  // eslint-disable-next-line @typescript-eslint/naming-convention
+  current_message: Content;
   preamble?: string;
   // eslint-disable-next-line @typescript-eslint/naming-convention
-  chat_history?: HistoryChunk[];
-  client: string;
+  historical_contexts?: Content[];
+  // eslint-disable-next-line @typescript-eslint/naming-convention
+  function_declarations?: FunctionDeclaration[];
   options?: {
     temperature?: number,
     // eslint-disable-next-line @typescript-eslint/naming-convention
@@ -88,7 +170,7 @@ export interface AidaRequest {
 
 export interface AidaDoConversationClientEvent {
   // eslint-disable-next-line @typescript-eslint/naming-convention
-  corresponding_aida_rpc_global_id: number;
+  corresponding_aida_rpc_global_id: RpcGlobalId;
   // eslint-disable-next-line @typescript-eslint/naming-convention
   disable_user_content_logging: boolean;
   // eslint-disable-next-line @typescript-eslint/naming-convention
@@ -123,14 +205,29 @@ export interface AttributionMetadata {
   citations: Citation[];
 }
 
+export interface AidaFunctionCallResponse {
+  name: string;
+  args: Record<string, unknown>;
+}
+
+export interface FactualityFact {
+  sourceUri?: string;
+}
+
+export interface FactualityMetadata {
+  facts: FactualityFact[];
+}
+
 export interface AidaResponseMetadata {
-  rpcGlobalId?: number;
-  attributionMetadata?: AttributionMetadata[];
+  rpcGlobalId?: RpcGlobalId;
+  attributionMetadata?: AttributionMetadata;
+  factualityMetadata?: FactualityMetadata;
 }
 
 export interface AidaResponse {
   explanation: string;
   metadata: AidaResponseMetadata;
+  functionCalls?: [AidaFunctionCallResponse, ...AidaFunctionCallResponse[]];
   completed: boolean;
 }
 
@@ -148,11 +245,12 @@ export const CLIENT_NAME = 'CHROME_DEVTOOLS';
 const CODE_CHUNK_SEPARATOR = '\n`````\n';
 
 export class AidaAbortError extends Error {}
+export class AidaBlockError extends Error {}
 
 export class AidaClient {
   static buildConsoleInsightsRequest(input: string): AidaRequest {
     const request: AidaRequest = {
-      input,
+      current_message: {parts: [{text: input}], role: Role.USER},
       client: CLIENT_NAME,
       functionality_type: FunctionalityType.EXPLAIN_ERROR,
       client_feature: ClientFeature.CHROME_CONSOLE_INSIGHTS,
@@ -238,7 +336,8 @@ export class AidaClient {
     let chunk;
     const text = [];
     let inCodeChunk = false;
-    const metadata: AidaResponseMetadata = {rpcGlobalId: 0};
+    const functionCalls: AidaFunctionCallResponse[] = [];
+    let metadata: AidaResponseMetadata = {rpcGlobalId: 0};
     while ((chunk = await stream.read())) {
       let textUpdated = false;
       // The AIDA response is a JSON array of objects, split at the object
@@ -267,12 +366,9 @@ export class AidaClient {
 
       for (const result of results) {
         if ('metadata' in result) {
-          metadata.rpcGlobalId = result.metadata.rpcGlobalId;
-          if ('attributionMetadata' in result.metadata) {
-            if (!metadata.attributionMetadata) {
-              metadata.attributionMetadata = [];
-            }
-            metadata.attributionMetadata.push(result.metadata.attributionMetadata);
+          metadata = result.metadata;
+          if (metadata?.attributionMetadata?.attributionAction === RecitationAction.BLOCK) {
+            throw new AidaBlockError();
           }
         }
         if ('textChunk' in result) {
@@ -289,6 +385,11 @@ export class AidaClient {
           }
           text.push(result.codeChunk.code);
           textUpdated = true;
+        } else if ('functionCallChunk' in result) {
+          functionCalls.push({
+            name: result.functionCallChunk.functionCall.name,
+            args: result.functionCallChunk.functionCall.args,
+          });
         } else if ('error' in result) {
           throw new Error(`Server responded: ${JSON.stringify(result)}`);
         } else {
@@ -306,6 +407,8 @@ export class AidaClient {
     yield {
       explanation: text.join('') + (inCodeChunk ? CODE_CHUNK_SEPARATOR : ''),
       metadata,
+      functionCalls: functionCalls.length ? functionCalls as [AidaFunctionCallResponse, ...AidaFunctionCallResponse[]] :
+                                            undefined,
       completed: true,
     };
   }

package/front_end/core/host/InspectorFrontendHost.ts

@@ -411,6 +411,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
         blockedByEnterprisePolicy: false,
         blockedByGeo: false,
         disallowLogging: true,
+        enterprisePolicyValue: 0,
       },
       devToolsConsoleInsights: {
         modelId: '',
@@ -433,7 +434,16 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
         portBindingEnabled: false,
         schemeBindingEnabled: false,
       },
+      devToolsAnimationStylesInStylesTab: {
+        enabled: false,
+      },
       isOffTheRecord: false,
+      thirdPartyCookieControls: {
+        thirdPartyCookieRestrictionEnabled: false,
+        thirdPartyCookieMetadataEnabled: true,
+        thirdPartyCookieHeuristicsEnabled: true,
+        managedBlockThirdPartyCookies: 'Unset',
+      },
     };
     if ('hostConfigForTesting' in globalThis) {
       const {hostConfigForTesting} = (globalThis as unknown as {hostConfigForTesting: Root.Runtime.HostConfig});
@@ -559,7 +569,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   }
 }
 
-// @ts-ignore Global injected by devtools-compatibility.js
+// @ts-ignore Global injected by devtools_compatibility.js
 // eslint-disable-next-line @typescript-eslint/naming-convention
 export let InspectorFrontendHostInstance: InspectorFrontendHostStub = globalThis.InspectorFrontendHost;
 
@@ -607,7 +617,7 @@ function initializeInspectorFrontendHost(): void {
   let proto;
   if (!InspectorFrontendHostInstance) {
     // Instantiate stub for web-hosted mode if necessary.
-    // @ts-ignore Global injected by devtools-compatibility.js
+    // @ts-ignore Global injected by devtools_compatibility.js
     globalThis.InspectorFrontendHost = InspectorFrontendHostInstance = new InspectorFrontendHostStub();
   } else {
     // Otherwise add stubs for missing methods that are declared in the interface.
@@ -616,13 +626,13 @@ function initializeInspectorFrontendHost(): void {
       // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
       // @ts-expect-error
       const stub = proto[name];
-      // @ts-ignore Global injected by devtools-compatibility.js
+      // @ts-ignore Global injected by devtools_compatibility.js
       if (typeof stub !== 'function' || InspectorFrontendHostInstance[name]) {
         continue;
       }
 
       console.error(`Incompatible embedder: method Host.InspectorFrontendHost.${name} is missing. Using stub instead.`);
-      // @ts-ignore Global injected by devtools-compatibility.js
+      // @ts-ignore Global injected by devtools_compatibility.js
       InspectorFrontendHostInstance[name] = stub;
     }
   }
@@ -634,7 +644,7 @@ function initializeInspectorFrontendHost(): void {
 // FIXME: This file is included into both apps, since the devtools_app needs the InspectorFrontendHostAPI only,
 // so the host instance should not be initialized there.
 initializeInspectorFrontendHost();
-// @ts-ignore Global injected by devtools-compatibility.js
+// @ts-ignore Global injected by devtools_compatibility.js
 globalThis.InspectorFrontendAPI = new InspectorFrontendAPIImpl();
 })();
 

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -478,6 +478,7 @@ export const enum EnumeratedHistogram {
   SourcesPanelFileDebugged = 'DevTools.SourcesPanelFileDebugged',
   SourcesPanelFileOpened = 'DevTools.SourcesPanelFileOpened',
   NetworkPanelResponsePreviewOpened = 'DevTools.NetworkPanelResponsePreviewOpened',
+  TimelineNavigationSettingState = 'DevTools.TimelineNavigationSettingState',
   StyleTextCopied = 'DevTools.StyleTextCopied',
   CSSHintShown = 'DevTools.CSSHintShown',
   LighthouseModeRun = 'DevTools.LighthouseModeRun',
@@ -486,9 +487,5 @@ export const enum EnumeratedHistogram {
   SwatchActivated = 'DevTools.SwatchActivated',
   AnimationPlaybackRateChanged = 'DevTools.AnimationPlaybackRateChanged',
   AnimationPointDragged = 'DevTools.AnimationPointDragged',
-  LegacyResourceTypeFilterNumberOfSelectedChanged = 'DevTools.LegacyResourceTypeFilterNumberOfSelectedChanged',
-  LegacyResourceTypeFilterItemSelected = 'DevTools.LegacyResourceTypeFilterItemSelected',
-  ResourceTypeFilterNumberOfSelectedChanged = 'DevTools.ResourceTypeFilterNumberOfSelectedChanged',
-  ResourceTypeFilterItemSelected = 'DevTools.ResourceTypeFilterItemSelected',
   /* eslint-disable @typescript-eslint/naming-convention -- Shadows a legacy enum */
 }

package/front_end/core/host/UserMetrics.ts

@@ -182,6 +182,11 @@ export class UserMetrics {
         EnumeratedHistogram.ExperimentEnabledAtLaunch, experiment, DevtoolsExperiments.MAX_VALUE);
   }
 
+  navigationSettingAtFirstTimelineLoad(state: TimelineNavigationSetting): void {
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(
+        EnumeratedHistogram.TimelineNavigationSettingState, state, TimelineNavigationSetting.MAX_VALUE);
+  }
+
   experimentDisabledAtLaunch(experimentId: string): void {
     const experiment = DevtoolsExperiments[experimentId as keyof typeof DevtoolsExperiments];
     if (experiment === undefined) {
@@ -335,36 +340,6 @@ export class UserMetrics {
         'DevTools.VisualLogging.ProcessingTime', timeInMilliseconds);
   }
 
-  legacyResourceTypeFilterNumberOfSelectedChanged(itemCount: number): void {
-    const boundItemCount = Math.max(Math.min(itemCount, ResourceType.MAX_VALUE - 1), 1);
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.LegacyResourceTypeFilterNumberOfSelectedChanged, boundItemCount, ResourceType.MAX_VALUE);
-  }
-
-  legacyResourceTypeFilterItemSelected(resourceTypeName: string): void {
-    const resourceType = ResourceType[resourceTypeName as keyof typeof ResourceType];
-    if (resourceType === undefined) {
-      return;
-    }
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.LegacyResourceTypeFilterItemSelected, resourceType, ResourceType.MAX_VALUE);
-  }
-
-  resourceTypeFilterNumberOfSelectedChanged(itemCount: number): void {
-    const boundItemCount = Math.max(Math.min(itemCount, ResourceType.MAX_VALUE - 1), 1);
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.ResourceTypeFilterNumberOfSelectedChanged, boundItemCount, ResourceType.MAX_VALUE);
-  }
-
-  resourceTypeFilterItemSelected(resourceTypeName: string): void {
-    const resourceType = ResourceType[resourceTypeName as keyof typeof ResourceType];
-    if (resourceType === undefined) {
-      return;
-    }
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.ResourceTypeFilterItemSelected, resourceType, ResourceType.MAX_VALUE);
-  }
-
   freestylerQueryLength(numberOfCharacters: number): void {
     InspectorFrontendHostInstance.recordCountHistogram(
         'DevTools.Freestyler.QueryLength', numberOfCharacters, 0, 100_000, 100);
@@ -533,8 +508,8 @@ export enum Action {
   AnimationGroupSelected = 142,
   ScrollDrivenAnimationGroupSelected = 143,
   ScrollDrivenAnimationGroupScrubbed = 144,
-  FreestylerOpenedFromElementsPanel = 145,
-  FreestylerOpenedFromStylesTab = 146,
+  AiAssistanceOpenedFromElementsPanel = 145,
+  AiAssistanceOpenedFromStylesTab = 146,
   ConsoleFilterByContext = 147,
   ConsoleFilterBySource = 148,
   ConsoleFilterByUrl = 149,
@@ -557,12 +532,12 @@ export enum Action {
   InsightsReminderTeaserSettingsLinkClicked = 166,
   InsightsReminderTeaserAbortedInSettings = 167,
   GeneratingInsightWithoutDisclaimer = 168,
-  FreestylerOpenedFromElementsPanelFloatingButton = 169,
-  DrJonesOpenedFromNetworkPanel = 170,
-  DrJonesOpenedFromSourcesPanel = 171,
-  DrJonesOpenedFromSourcesPanelFloatingButton = 172,
-  DrJonesOpenedFromPerformancePanel = 173,
-  DrJonesOpenedFromNetworkPanelFloatingButton = 174,
+  AiAssistanceOpenedFromElementsPanelFloatingButton = 169,
+  AiAssistanceOpenedFromNetworkPanel = 170,
+  AiAssistanceOpenedFromSourcesPanel = 171,
+  AiAssistanceOpenedFromSourcesPanelFloatingButton = 172,
+  AiAssistanceOpenedFromPerformancePanel = 173,
+  AiAssistanceOpenedFromNetworkPanelFloatingButton = 174,
   AiAssistancePanelOpened = 175,
   AiAssistanceQuerySubmitted = 176,
   AiAssistanceAnswerReceived = 177,
@@ -967,8 +942,9 @@ export enum KeyboardShortcutAction {
   'elements.refresh-event-listeners' = 115,
   'coverage.clear' = 116,
   'coverage.export' = 117,
+  'timeline.dim-third-parties' = 118,
   /* eslint-enable @typescript-eslint/naming-convention */
-  MAX_VALUE = 118,
+  MAX_VALUE = 119,
 }
 
 export const enum IssueOpener {
@@ -1013,18 +989,16 @@ export enum DevtoolsExperiments {
   'timeline-enhanced-traces' = 90,
   'timeline-compiled-sources' = 91,
   'timeline-debug-mode' = 93,
-  'perf-panel-annotations' = 94,
-  'timeline-rpp-sidebar' = 95,
-  'timeline-observations' = 96,
   'timeline-server-timings' = 98,
   'floating-entry-points-for-ai-assistance' = 101,
   'timeline-experimental-insights' = 102,
   'timeline-dim-unrelated-events' = 103,
   'timeline-alternative-navigation' = 104,
+  'timeline-third-party-dependencies' = 106,
   /* eslint-enable @typescript-eslint/naming-convention */
 
   // Increment this when new experiments are added.
-  MAX_VALUE = 105,
+  MAX_VALUE = 107,
 }
 
 export const enum CSSPropertyDocumentation {
@@ -1180,24 +1154,6 @@ export const enum DeveloperResourceScheme {
   MAX_VALUE = 9,
 }
 
-export enum ResourceType {
-  /* eslint-disable @typescript-eslint/naming-convention -- Used by web_tests. */
-  all = 0,
-  Document = 1,
-  JavaScript = 2,
-  'Fetch and XHR' = 3,
-  CSS = 4,
-  Font = 5,
-  Image = 6,
-  Media = 7,
-  Manifest = 8,
-  WebSocket = 9,
-  WebAssembly = 10,
-  Other = 11,
-  /* eslint-enable @typescript-eslint/naming-convention */
-  MAX_VALUE = 12,
-}
-
 export enum Language {
   /* eslint-disable @typescript-eslint/naming-convention */
   'af' = 1,
@@ -1481,3 +1437,13 @@ export const enum AnimationPointDragType {
   OTHER = 4,
   MAX_VALUE = 5,
 }
+
+export const enum TimelineNavigationSetting {
+  // Setting is set to classic when the first trace of the session is recorded or loaded.
+  CLASSIC_AT_SESSION_FIRST_TRACE = 0,
+  // Setting is set to modern when the first trace of the session is recorded or loaded.
+  MODERN_AT_SESSION_FIRST_TRACE = 1,
+  SWITCHED_TO_CLASSIC = 2,
+  SWITCHED_TO_MODERN = 3,
+  MAX_VALUE = 4,
+}

package/front_end/core/i18n/i18n.test.ts

@@ -79,6 +79,14 @@ describe('getLocalizedLanguageRegion', () => {
 describe('getFormatLocalizedString', () => {
   let i18nInstance: i18nRaw.I18n.I18n;
   beforeEach(() => {
+    i18n.DevToolsLocale.DevToolsLocale.instance({
+      create: true,
+      data: {
+        navigatorLanguage: 'en-US',
+        settingLanguage: 'en-US',
+        lookupClosestDevToolsLocale: () => 'en-US',
+      },
+    });
     i18nInstance = new i18nRaw.I18n.I18n(['en-US'], 'en-US');
     i18nInstance.registerLocaleData('en-US', {});  // Always fall back to UIStrings.
   });
@@ -118,6 +126,43 @@ describe('getFormatLocalizedString', () => {
   });
 });
 
+describe('falling back when a locale errors', () => {
+  it('reverts to using the UIStrings directly', async () => {
+    i18n.DevToolsLocale.DevToolsLocale.instance({
+      create: true,
+      data: {
+        // Create the locale and set en-GB to default. This test is going to
+        // assert that when there is an error with the en-GB string that we
+        // fallback.
+        navigatorLanguage: 'en-GB',
+        settingLanguage: 'en-GB',
+        lookupClosestDevToolsLocale: () => 'en-GB',
+      },
+    });
+    const i18nInstance = new i18nRaw.I18n.I18n(['en-GB', 'en-US'], 'en-US');
+
+    // Recreate the bug that can happen in Canary: the en-US translation is up
+    // to date (no PH1 placeholder), but the en-GB translation is out of date.
+    // We expect that in this instance we should fallback to en-US.
+    i18nInstance.registerLocaleData('en-US', {
+      'test.ts | placeholder': {message: 'US: hello world'},
+    });
+    // Register the (outdated) en-GB string.
+    i18nInstance.registerLocaleData('en-GB', {
+      'test.ts | placeholder': {message: 'GB: hello {PH1}'},
+    });
+
+    const uiStrings = {placeholder: 'US: hello world'};
+    const registeredStrings = i18nInstance.registerFileStrings('test.ts', uiStrings);
+
+    // We should see "hello world" because we don't pass the placeholder value,
+    // and that means the en-GB translations are invalid, and we fallback to
+    // the UIStrings.
+    const output = i18n.i18n.getLocalizedString(registeredStrings, uiStrings.placeholder);
+    assert.strictEqual(output, 'US: hello world');
+  });
+});
+
 describe('fetchAndRegisterLocaleData', () => {
   let fetchStub: sinon.SinonStub;
 

package/front_end/core/i18n/time-utilities.ts

@@ -160,6 +160,23 @@ export function preciseMillisToString(ms: number, precision = 0): string {
   return formatter.format(ms);
 }
 
+const preciseSecondsToStringFormattersCache = new Map<number, NumberFormatter>();
+
+export function preciseSecondsToString(ms: number, precision = 0): string {
+  let formatter = preciseSecondsToStringFormattersCache.get(precision);
+  if (!formatter) {
+    formatter = defineFormatter({
+      style: 'unit',
+      unit: 'second',
+      unitDisplay: 'narrow',
+      minimumFractionDigits: precision,
+      maximumFractionDigits: precision,
+    });
+    preciseSecondsToStringFormattersCache.set(precision, formatter);
+  }
+  return formatter.format(ms);
+}
+
 export function secondsToString(seconds: number, higherResolution?: boolean): string {
   if (!isFinite(seconds)) {
     return '-';

package/front_end/core/platform/ArrayUtilities.test.ts

@@ -27,12 +27,11 @@ describe('ArrayUtilities', () => {
         const actualFirstOnlyTrue = [...testCase.input];
 
         Platform.ArrayUtilities.removeElement(actualFirstOnlyTrue, 2, true);
-        assert.deepStrictEqual(actualFirstOnlyTrue, testCase.expectedFirstOnlyTrue, 'Removing firstOnly (true) failed');
+        assert.deepEqual(actualFirstOnlyTrue, testCase.expectedFirstOnlyTrue, 'Removing firstOnly (true) failed');
 
         const actualFirstOnlyFalse = [...testCase.input];
         Platform.ArrayUtilities.removeElement(actualFirstOnlyFalse, 2, false);
-        assert.deepStrictEqual(
-            actualFirstOnlyFalse, testCase.expectedFirstOnlyFalse, 'Removing firstOnly (false) failed');
+        assert.deepEqual(actualFirstOnlyFalse, testCase.expectedFirstOnlyFalse, 'Removing firstOnly (false) failed');
       }
     });
   });
@@ -54,20 +53,20 @@ describe('ArrayUtilities', () => {
             for (let count = 1, k = right - first + 1; count <= k; ++count) {
               const actual = fixture.slice(0);
               Platform.ArrayUtilities.sortRange(actual, comparator, left, right, first, first + count - 1);
-              assert.deepStrictEqual(
+              assert.deepEqual(
                   fixture.slice(0, left), actual.slice(0, left), 'left ' + left + ' ' + right + ' ' + count);
-              assert.deepStrictEqual(
+              assert.deepEqual(
                   fixture.slice(right + 1), actual.slice(right + 1), 'right ' + left + ' ' + right + ' ' + count);
 
               const middle = fixture.slice(left, right + 1);
               middle.sort(comparator);
-              assert.deepStrictEqual(
+              assert.deepEqual(
                   middle.slice(first - left, first - left + count), actual.slice(first, first + count),
                   'sorted ' + left + ' ' + right + ' ' + first + ' ' + count);
 
               const actualRest = actual.slice(first + count, right + 1);
               actualRest.sort(comparator);
-              assert.deepStrictEqual(
+              assert.deepEqual(
                   middle.slice(first - left + count), actualRest,
                   'unsorted ' + left + ' ' + right + ' ' + first + ' ' + count);
             }
@@ -137,7 +136,7 @@ describe('ArrayUtilities', () => {
         }
 
         const shallowCopy = [...actual];
-        assert.deepStrictEqual(actual.sort(), shallowCopy, 'Result array is ordered');
+        assert.deepEqual(actual.sort(), shallowCopy, 'Result array is ordered');
       }
 
       const fixtures = new Map([

package/front_end/core/platform/MapUtilities.ts

@@ -85,7 +85,7 @@ export class Multimap<K, V> {
 export function getWithDefault<K extends {}, V>(
     map: WeakMap<K, V>|Map<K, V>, key: K, defaultValueFactory: (key?: K) => V): V {
   let value = map.get(key);
-  if (!value) {
+  if (value === undefined || value === null) {
     value = defaultValueFactory(key);
     map.set(key, value);
   }

package/front_end/core/platform/StringUtilities.test.ts

@@ -249,7 +249,7 @@ describe('StringUtilities', () => {
   describe('createSearchRegex', () => {
     it('returns a case sensitive regex if the call states it is case sensitive', () => {
       const regex = Platform.StringUtilities.createSearchRegex('foo', true, false);
-      assert.strictEqual(regex.ignoreCase, false);
+      assert.isFalse(regex.ignoreCase);
       assert.strictEqual(regex.source, 'foo');
     });
 

package/front_end/core/platform/TypedArrayUtilities.test.ts

@@ -8,17 +8,17 @@ describe('TypedArrayUtilities', () => {
   describe('BigUint32Array', () => {
     it('can be expandable', () => {
       const array = Platform.TypedArrayUtilities.createExpandableBigUint32Array();
-      assert.strictEqual(array.length, 0);
+      assert.lengthOf(array, 0);
       array.setValue(0, 33);
       array.setValue(1, 44);
-      assert.strictEqual(array.length, 2);
+      assert.lengthOf(array, 2);
       assert.strictEqual(array.getValue(0), 33);
       assert.strictEqual(array.getValue(1), 44);
       assert.strictEqual(array.asArrayOrFail() as Object, array);
     });
     it('can act as a Uint32Array', () => {
       const array = Platform.TypedArrayUtilities.createFixedBigUint32Array(15);
-      assert.strictEqual(array.length, 15);
+      assert.lengthOf(array, 15);
       assert.strictEqual(array.getValue(7), 0);
       array.setValue(7, 77);
       assert.strictEqual(array.getValue(7), 77);
@@ -26,7 +26,7 @@ describe('TypedArrayUtilities', () => {
     });
     it('can be bigger than a Uint32Array', () => {
       const array = Platform.TypedArrayUtilities.createFixedBigUint32Array(12_345_678, /* maxLengthForTesting=*/ 2e6);
-      assert.strictEqual(array.length, 12_345_678);
+      assert.lengthOf(array, 12_345_678);
       assert.strictEqual(array.getValue(0), 0);
       assert.strictEqual(array.getValue(500_000), 0);
       assert.strictEqual(array.getValue(5_000_000), 0);
@@ -39,8 +39,8 @@ describe('TypedArrayUtilities', () => {
       assert.strictEqual(array.getValue(500_000), 99);
       assert.strictEqual(array.getValue(5_000_000), 999);
       assert.strictEqual(array.getValue(12_345_677), 9999);
-      assert.isFalse(array instanceof Array);
-      assert.isFalse(array instanceof Uint32Array);
+      assert.notInstanceOf(array, Array);
+      assert.notInstanceOf(array, Uint32Array);
     });
   });