bmalph 1.0.0 → 2.2.1

package/bmad/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md

@@ -1,106 +1,104 @@
----
-name: 'step-05-adversarial-review'
-description: 'Construct diff and invoke adversarial review task'
-
-workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev'
-thisStepFile: './step-05-adversarial-review.md'
-nextStepFile: './step-06-resolve-findings.md'
----
-
-# Step 5: Adversarial Code Review
-
-**Goal:** Construct diff of all changes, invoke adversarial review task, present findings.
-
----
-
-## AVAILABLE STATE
-
-From previous steps:
-
-- `{baseline_commit}` - Git HEAD at workflow start (CRITICAL for diff)
-- `{execution_mode}` - "tech-spec" or "direct"
-- `{tech_spec_path}` - Tech-spec file (if Mode A)
-
----
-
-### 1. Construct Diff
-
-Build complete diff of all changes since workflow started.
-
-### If `{baseline_commit}` is a Git commit hash:
-
-**Tracked File Changes:**
-
-```bash
-git diff {baseline_commit}
-```
-
-**New Untracked Files:**
-Only include untracked files that YOU created during this workflow (steps 2-4).
-Do not include pre-existing untracked files.
-For each new file created, include its full content as a "new file" addition.
-
-### If `{baseline_commit}` is "NO_GIT":
-
-Use best-effort diff construction:
-
-- List all files you modified during steps 2-4
-- For each file, show the changes you made (before/after if you recall, or just current state)
-- Include any new files you created with their full content
-- Note: This is less precise than Git diff but still enables meaningful review
-
-### Capture as {diff_output}
-
-Merge all changes into `{diff_output}`.
-
-**Note:** Do NOT `git add` anything - this is read-only inspection.
-
----
-
-### 2. Invoke Adversarial Review
-
-With `{diff_output}` constructed, invoke the review task. If possible, use information asymmetry: run this step, and only it, in a separate subagent or process with read access to the project, but no context except the `{diff_output}`.
-
-```xml
-<invoke-task>Review {diff_output} using {project-root}/_bmad/core/tasks/review-adversarial-general.xml</invoke-task>
-```
-
-**Platform fallback:** If task invocation not available, load the task file and execute its instructions inline, passing `{diff_output}` as the content.
-
-The task should: review `{diff_output}` and return a list of findings.
-
----
-
-### 3. Process Findings
-
-Capture the findings from the task output.
-**If zero findings:** HALT - this is suspicious. Re-analyze or request user guidance.
-Evaluate severity (Critical, High, Medium, Low) and validity (real, noise, undecided).
-DO NOT exclude findings based on severity or validity unless explicitly asked to do so.
-Order findings by severity.
-Number the ordered findings (F1, F2, F3, etc.).
-If TodoWrite or similar tool is available, turn each finding into a TODO, include ID, severity, validity, and description in the TODO; otherwise present findings as a table with columns: ID, Severity, Validity, Description
-
----
-
-## NEXT STEP
-
-With findings in hand, load `step-06-resolve-findings.md` for user to choose resolution approach.
-
----
-
-## SUCCESS METRICS
-
-- Diff constructed from baseline_commit
-- New files included in diff
-- Task invoked with diff as input
-- Findings received
-- Findings processed into TODOs or table and presented to user
-
-## FAILURE MODES
-
-- Missing baseline_commit (can't construct accurate diff)
-- Not including new untracked files in diff
-- Invoking task without providing diff input
-- Accepting zero findings without questioning
-- Presenting fewer findings than the review task returned without explicit instruction to do so
+---
+name: 'step-05-adversarial-review'
+description: 'Construct diff and invoke adversarial review task'
+
+nextStepFile: './step-06-resolve-findings.md'
+---
+
+# Step 5: Adversarial Code Review
+
+**Goal:** Construct diff of all changes, invoke adversarial review task, present findings.
+
+---
+
+## AVAILABLE STATE
+
+From previous steps:
+
+- `{baseline_commit}` - Git HEAD at workflow start (CRITICAL for diff)
+- `{execution_mode}` - "tech-spec" or "direct"
+- `{tech_spec_path}` - Tech-spec file (if Mode A)
+
+---
+
+### 1. Construct Diff
+
+Build complete diff of all changes since workflow started.
+
+### If `{baseline_commit}` is a Git commit hash:
+
+**Tracked File Changes:**
+
+```bash
+git diff {baseline_commit}
+```
+
+**New Untracked Files:**
+Only include untracked files that YOU created during this workflow (steps 2-4).
+Do not include pre-existing untracked files.
+For each new file created, include its full content as a "new file" addition.
+
+### If `{baseline_commit}` is "NO_GIT":
+
+Use best-effort diff construction:
+
+- List all files you modified during steps 2-4
+- For each file, show the changes you made (before/after if you recall, or just current state)
+- Include any new files you created with their full content
+- Note: This is less precise than Git diff but still enables meaningful review
+
+### Capture as {diff_output}
+
+Merge all changes into `{diff_output}`.
+
+**Note:** Do NOT `git add` anything - this is read-only inspection.
+
+---
+
+### 2. Invoke Adversarial Review
+
+With `{diff_output}` constructed, load and follow the review task. If possible, use information asymmetry: load this step, and only it, in a separate subagent or process with read access to the project, but no context except the `{diff_output}`.
+
+```xml
+<invoke-task>Review {diff_output} using {project-root}/_bmad/core/tasks/review-adversarial-general.xml</invoke-task>
+```
+
+**Platform fallback:** If task invocation not available, load the task file and follow its instructions inline, passing `{diff_output}` as the content.
+
+The task should: review `{diff_output}` and return a list of findings.
+
+---
+
+### 3. Process Findings
+
+Capture the findings from the task output.
+**If zero findings:** HALT - this is suspicious. Re-analyze or request user guidance.
+Evaluate severity (Critical, High, Medium, Low) and validity (real, noise, undecided).
+DO NOT exclude findings based on severity or validity unless explicitly asked to do so.
+Order findings by severity.
+Number the ordered findings (F1, F2, F3, etc.).
+If TodoWrite or similar tool is available, turn each finding into a TODO, include ID, severity, validity, and description in the TODO; otherwise present findings as a table with columns: ID, Severity, Validity, Description
+
+---
+
+## NEXT STEP
+
+With findings in hand, read fully and follow: `step-06-resolve-findings.md` for user to choose resolution approach.
+
+---
+
+## SUCCESS METRICS
+
+- Diff constructed from baseline_commit
+- New files included in diff
+- Task invoked with diff as input
+- Findings received
+- Findings processed into TODOs or table and presented to user
+
+## FAILURE MODES
+
+- Missing baseline_commit (can't construct accurate diff)
+- Not including new untracked files in diff
+- Invoking task without providing diff input
+- Accepting zero findings without questioning
+- Presenting fewer findings than the review task returned without explicit instruction to do so

package/bmad/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-06-resolve-findings.md

@@ -1,140 +1,146 @@
----
-name: 'step-06-resolve-findings'
-description: 'Handle review findings interactively, apply fixes, update tech-spec with final status'
-
-workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev'
-thisStepFile: './step-06-resolve-findings.md'
----
-
-# Step 6: Resolve Findings
-
-**Goal:** Handle adversarial review findings interactively, apply fixes, finalize tech-spec.
-
----
-
-## AVAILABLE STATE
-
-From previous steps:
-
-- `{baseline_commit}` - Git HEAD at workflow start
-- `{execution_mode}` - "tech-spec" or "direct"
-- `{tech_spec_path}` - Tech-spec file (if Mode A)
-- Findings table from step-05
-
----
-
-## RESOLUTION OPTIONS
-
-Present choice to user:
-
-```
-How would you like to handle these findings?
-
-**[1] Walk through** - Discuss each finding individually
-**[2] Auto-fix** - Automatically fix issues classified as "real"
-**[3] Skip** - Acknowledge and proceed to commit
-```
-
----
-
-## OPTION 1: WALK THROUGH
-
-For each finding in order:
-
-1. Present the finding with context
-2. Ask: **fix now / skip / discuss**
-3. If fix: Apply the fix immediately
-4. If skip: Note as acknowledged, continue
-5. If discuss: Provide more context, re-ask
-6. Move to next finding
-
-After all findings processed, summarize what was fixed/skipped.
-
----
-
-## OPTION 2: AUTO-FIX
-
-1. Filter findings to only those classified as "real"
-2. Apply fixes for each real finding
-3. Report what was fixed:
-
-```
-**Auto-fix Applied:**
-- F1: {description of fix}
-- F3: {description of fix}
-...
-
-Skipped (noise/uncertain): F2, F4
-```
-
----
-
-## OPTION 3: SKIP
-
-1. Acknowledge all findings were reviewed
-2. Note that user chose to proceed without fixes
-3. Continue to completion
-
----
-
-## UPDATE TECH-SPEC (Mode A only)
-
-If `{execution_mode}` is "tech-spec":
-
-1. Load `{tech_spec_path}`
-2. Update status to "Completed"
-3. Add review notes:
-   ```
-   ## Review Notes
-   - Adversarial review completed
-   - Findings: {count} total, {fixed} fixed, {skipped} skipped
-   - Resolution approach: {walk-through/auto-fix/skip}
-   ```
-4. Save changes
-
----
-
-## COMPLETION OUTPUT
-
-```
-**Review complete. Ready to commit.**
-
-**Implementation Summary:**
-- {what was implemented}
-- Files modified: {count}
-- Tests: {status}
-- Review findings: {X} addressed, {Y} skipped
-
-{Explain what was implemented based on user_skill_level}
-```
-
----
-
-## WORKFLOW COMPLETE
-
-This is the final step. The Quick Dev workflow is now complete.
-
-User can:
-
-- Commit changes
-- Run additional tests
-- Start new Quick Dev session
-
----
-
-## SUCCESS METRICS
-
-- User presented with resolution options
-- Chosen approach executed correctly
-- Fixes applied cleanly (if applicable)
-- Tech-spec updated with final status (Mode A)
-- Completion summary provided
-- User understands what was implemented
-
-## FAILURE MODES
-
-- Not presenting resolution options
-- Auto-fixing "noise" or "uncertain" findings
-- Not updating tech-spec after resolution (Mode A)
-- No completion summary
-- Leaving user unclear on next steps
+---
+name: 'step-06-resolve-findings'
+description: 'Handle review findings interactively, apply fixes, update tech-spec with final status'
+---
+
+# Step 6: Resolve Findings
+
+**Goal:** Handle adversarial review findings interactively, apply fixes, finalize tech-spec.
+
+---
+
+## AVAILABLE STATE
+
+From previous steps:
+
+- `{baseline_commit}` - Git HEAD at workflow start
+- `{execution_mode}` - "tech-spec" or "direct"
+- `{tech_spec_path}` - Tech-spec file (if Mode A)
+- Findings table from step-05
+
+---
+
+## RESOLUTION OPTIONS
+
+Present: "How would you like to handle these findings?"
+
+Display:
+
+**[W] Walk through** - Discuss each finding individually
+**[F] Fix automatically** - Automatically fix issues classified as "real"
+**[S] Skip** - Acknowledge and proceed to commit
+
+### Menu Handling Logic:
+
+- IF W: Execute WALK THROUGH section below
+- IF F: Execute FIX AUTOMATICALLY section below
+- IF S: Execute SKIP section below
+
+### EXECUTION RULES:
+
+- ALWAYS halt and wait for user input after presenting menu
+- ONLY proceed when user makes a selection
+
+---
+
+## WALK THROUGH [W]
+
+For each finding in order:
+
+1. Present the finding with context
+2. Ask: **fix now / skip / discuss**
+3. If fix: Apply the fix immediately
+4. If skip: Note as acknowledged, continue
+5. If discuss: Provide more context, re-ask
+6. Move to next finding
+
+After all findings processed, summarize what was fixed/skipped.
+
+---
+
+## FIX AUTOMATICALLY [F]
+
+1. Filter findings to only those classified as "real"
+2. Apply fixes for each real finding
+3. Report what was fixed:
+
+```
+**Auto-fix Applied:**
+- F1: {description of fix}
+- F3: {description of fix}
+...
+
+Skipped (noise/uncertain): F2, F4
+```
+
+---
+
+## SKIP [S]
+
+1. Acknowledge all findings were reviewed
+2. Note that user chose to proceed without fixes
+3. Continue to completion
+
+---
+
+## UPDATE TECH-SPEC (Mode A only)
+
+If `{execution_mode}` is "tech-spec":
+
+1. Load `{tech_spec_path}`
+2. Update status to "Completed"
+3. Add review notes:
+   ```
+   ## Review Notes
+   - Adversarial review completed
+   - Findings: {count} total, {fixed} fixed, {skipped} skipped
+   - Resolution approach: {walk-through/auto-fix/skip}
+   ```
+4. Save changes
+
+---
+
+## COMPLETION OUTPUT
+
+```
+**Review complete. Ready to commit.**
+
+**Implementation Summary:**
+- {what was implemented}
+- Files modified: {count}
+- Tests: {status}
+- Review findings: {X} addressed, {Y} skipped
+
+{Explain what was implemented based on user_skill_level}
+```
+
+---
+
+## WORKFLOW COMPLETE
+
+This is the final step. The Quick Dev workflow is now complete.
+
+User can:
+
+- Commit changes
+- Run additional tests
+- Start new Quick Dev session
+
+---
+
+## SUCCESS METRICS
+
+- User presented with resolution options
+- Chosen approach executed correctly
+- Fixes applied cleanly (if applicable)
+- Tech-spec updated with final status (Mode A)
+- Completion summary provided
+- User understands what was implemented
+
+## FAILURE MODES
+
+- Not presenting resolution options
+- Auto-fixing "noise" or "uncertain" findings
+- Not updating tech-spec after resolution (Mode A)
+- No completion summary
+- Leaving user unclear on next steps

package/bmad/bmm/workflows/bmad-quick-flow/quick-dev/workflow.md

@@ -1,50 +1,50 @@
----
-name: quick-dev
-description: 'Flexible development - execute tech-specs OR direct instructions with optional planning.'
----
-
-# Quick Dev Workflow
-
-**Goal:** Execute implementation tasks efficiently, either from a tech-spec or direct user instructions.
-
-**Your Role:** You are an elite full-stack developer executing tasks autonomously. Follow patterns, ship code, run tests. Every response moves the project forward.
-
----
-
-## WORKFLOW ARCHITECTURE
-
-This uses **step-file architecture** for focused execution:
-
-- Each step loads fresh to combat "lost in the middle"
-- State persists via variables: `{baseline_commit}`, `{execution_mode}`, `{tech_spec_path}`
-- Sequential progression through implementation phases
-
----
-
-## INITIALIZATION
-
-### Configuration Loading
-
-Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
-
-- `user_name`, `communication_language`, `user_skill_level`
-- `output_folder`, `planning_artifacts`,  `implementation_artifacts`
-- `date` as system-generated current datetime
-- ✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the config `{communication_language}`
-
-### Paths
-
-- `installed_path` = `{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev`
-- `project_context` = `**/project-context.md` (load if exists)
-
-### Related Workflows
-
-- `quick_spec_workflow` = `{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-spec/workflow.md`
-- `party_mode_exec` = `{project-root}/_bmad/core/workflows/party-mode/workflow.md`
-- `advanced_elicitation` = `{project-root}/_bmad/core/workflows/advanced-elicitation/workflow.xml`
-
----
-
-## EXECUTION
-
-Load and execute `steps/step-01-mode-detection.md` to begin the workflow.
+---
+name: quick-dev
+description: 'Flexible development - execute tech-specs OR direct instructions with optional planning.'
+---
+
+# Quick Dev Workflow
+
+**Goal:** Execute implementation tasks efficiently, either from a tech-spec or direct user instructions.
+
+**Your Role:** You are an elite full-stack developer executing tasks autonomously. Follow patterns, ship code, run tests. Every response moves the project forward.
+
+---
+
+## WORKFLOW ARCHITECTURE
+
+This uses **step-file architecture** for focused execution:
+
+- Each step loads fresh to combat "lost in the middle"
+- State persists via variables: `{baseline_commit}`, `{execution_mode}`, `{tech_spec_path}`
+- Sequential progression through implementation phases
+
+---
+
+## INITIALIZATION
+
+### Configuration Loading
+
+Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
+
+- `user_name`, `communication_language`, `user_skill_level`
+- `planning_artifacts`, `implementation_artifacts`
+- `date` as system-generated current datetime
+- ✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the config `{communication_language}`
+
+### Paths
+
+- `installed_path` = `{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev`
+- `project_context` = `**/project-context.md` (load if exists)
+
+### Related Workflows
+
+- `quick_spec_workflow` = `{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-spec/workflow.md`
+- `party_mode_exec` = `{project-root}/_bmad/core/workflows/party-mode/workflow.md`
+- `advanced_elicitation` = `{project-root}/_bmad/core/workflows/advanced-elicitation/workflow.xml`
+
+---
+
+## EXECUTION
+
+Read fully and follow: `steps/step-01-mode-detection.md` to begin the workflow.