@sapui5/sap.fe.core 1.102.2 → 1.104.1

package/src/sap/fe/core/controllerextensions/collaboration/Manage.ts

@@ -1,18 +1,19 @@
-import { CollaborationUtils, User } from "sap/fe/core/controllerextensions/collaboration/CollaborationCommon";
-import { InternalModelContext } from "sap/fe/core/helpers/ModelHelper";
-import Dialog from "sap/m/Dialog";
-import Input from "sap/m/Input";
+import type { User } from "sap/fe/core/controllerextensions/collaboration/CollaborationCommon";
+import { CollaborationUtils } from "sap/fe/core/controllerextensions/collaboration/CollaborationCommon";
+import type { InternalModelContext } from "sap/fe/core/helpers/ModelHelper";
+import type Dialog from "sap/m/Dialog";
+import type Input from "sap/m/Input";
 import MessageToast from "sap/m/MessageToast";
-import Popover from "sap/m/Popover";
-import Table from "sap/m/Table";
-import Event from "sap/ui/base/Event";
-import Control from "sap/ui/core/Control";
+import type Popover from "sap/m/Popover";
+import type Table from "sap/m/Table";
+import type Event from "sap/ui/base/Event";
+import type Control from "sap/ui/core/Control";
 import Core from "sap/ui/core/Core";
 import Fragment from "sap/ui/core/Fragment";
-import View from "sap/ui/core/mvc/View";
-import Context from "sap/ui/model/odata/v4/Context";
-import ODataListBinding from "sap/ui/model/odata/v4/ODataListBinding";
-import ODataModel from "sap/ui/model/odata/v4/ODataModel";
+import type View from "sap/ui/core/mvc/View";
+import type Context from "sap/ui/model/odata/v4/Context";
+import type ODataListBinding from "sap/ui/model/odata/v4/ODataListBinding";
+import type ODataModel from "sap/ui/model/odata/v4/ODataModel";
 
 export const openManageDialog = async function (view: View) {
 	let dialog: any = byId("dialog");
@@ -81,7 +82,7 @@ function readInvitedUsers(view: View) {
 					const isMe: boolean = me?.id === userData.UserID;
 					let userDescription = userData.UserDescription || userData.UserID;
 					const initials = CollaborationUtils.formatInitials(userDescription);
-					userDescription += isMe ? " (" + CollaborationUtils.getText("C_COLLABORATIONDRAFT_YOU") + ")" : "";
+					userDescription += isMe ? ` (${CollaborationUtils.getText("C_COLLABORATIONDRAFT_YOU")})` : "";
 
 					const user: User = {
 						id: userData.UserID,
@@ -119,9 +120,7 @@ function addUser(event: any) {
 		role: internalModelContext.getProperty("UserRole")
 	};
 
-	if (invitedUsers.findIndex((user) => user.id === newUser.id) > -1 || (newUser.id === newUser.name && newUser.id === "")) {
-		return;
-	} else {
+	if (!(invitedUsers.findIndex((user) => user.id === newUser.id) > -1 || (newUser.id === newUser.name && newUser.id === ""))) {
 		newUser.name = newUser.name || newUser.id;
 		newUser.initials = CollaborationUtils.formatInitials(newUser.name);
 		newUser.color = CollaborationUtils.getUserColor(newUser.id, activeUsers, invitedUsers);
@@ -174,7 +173,7 @@ function removeUserFromList(item: any) {
 }
 
 function byId(id: string): any {
-	return Core.byId("manageCollaborationDraft--" + id);
+	return Core.byId(`manageCollaborationDraft--${id}`);
 }
 
 function closeDialog() {
@@ -231,11 +230,11 @@ export async function showUserDetails(event: Event, view: View) {
 }
 
 async function createUserDetailsPopover(view: View) {
-	const popover: Promise<any> = Fragment.load({
+	const popoverPromise: Promise<any> = Fragment.load({
 		id: "manageCollaborationDraft", // todo should be view id
 		name: "sap.fe.core.controllerextensions.collaboration.UserDetails"
 	});
-	return popover
+	return popoverPromise
 		.then(function (popover: any) {
 			view.addDependent(popover);
 			return popover;