@sap/open.fe 1.97.0 → 1.98.0

package/packages/sap.fe.core/test/sap/fe/core/jest/converters/Table.spec.ts

@@ -1,24 +1,19 @@
 import {
-	getCreateVisible,
 	getSelectionMode,
 	getTableActions,
 	getTableColumns,
 	getTableManifestConfiguration,
 	TableCapabilityRestriction,
 	TableControlConfiguration,
-	getVisibilityMassEdit,
-	getEnablementMassEdit,
-	getDeleteVisible,
-	splitPath,
-	isFilteringCaseSensitive
+	isFilteringCaseSensitive,
+	AnnotationTableColumn
 } from "sap/fe/core/converters/controls/Common/Table";
 
 import { TableHelper } from "sap/fe/macros/table";
 import path from "path";
 import { convertTypes } from "sap/fe/core/converters/MetaModelConverter";
-import { compileCDS, getConverterContextForTest, getMetaModel, getTemplatedXML } from "sap/fe/test/JestTemplatingHelper";
+import { compileCDS, getConverterContextForTest, getMetaModel } from "sap/fe/test/JestTemplatingHelper";
 import {
-	CreationMode,
 	HorizontalAlign,
 	SelectionMode,
 	ListReportManifestSettings,
@@ -27,8 +22,7 @@ import {
 	TemplateType
 } from "sap/fe/core/converters/ManifestSettings";
 import { ConverterOutput, LineItem, UIAnnotationTerms } from "@sap-ux/vocabularies-types";
-import { bindingExpression, Expression, compileBinding, constant } from "sap/fe/core/helpers/BindingExpression";
-import { UI } from "sap/fe/core/converters/helpers/BindingHelper";
+import { bindingExpression, Expression, constant } from "sap/fe/core/helpers/BindingExpression";
 import ConverterContext from "sap/fe/core/converters/ConverterContext";
 import { Placement } from "sap/fe/core/converters/helpers/ConfigurableObject";
 import { ObjectPageManifestSettings } from "sap/fe/core/converters/ManifestSettings";
@@ -40,6 +34,7 @@ let convertedTypesAnalyticalService: ConverterOutput;
 let convertedTypesOaTrue: ConverterOutput;
 let convertedTypesOaFalse: ConverterOutput;
 let convertedTypesSelectionMode: ConverterOutput;
+let convertedTypesTooltips: ConverterOutput;
 
 beforeAll(async function() {
 	const sMetadataUrl = compileCDS(path.join(__dirname, "../data/Table.cds"));
@@ -65,6 +60,10 @@ beforeAll(async function() {
 	const sMetadataUrlOaFalse = compileCDS(path.join(__dirname, "../data/TableNewActionOperationAvailableFalse.cds"));
 	const metaModelOaFalse = await getMetaModel(sMetadataUrlOaFalse);
 	convertedTypesOaFalse = convertTypes(metaModelOaFalse);
+
+	const sMetadataUrlTooltips = compileCDS(path.join(__dirname, "../data/TableTooltips.cds"));
+	const metaModelTooltips = await getMetaModel(sMetadataUrlTooltips);
+	convertedTypesTooltips = convertTypes(metaModelTooltips);
 });
 const getTableConfigurationForTest = (
 	manifestSettings: ListReportManifestSettings | ObjectPageManifestSettings,
@@ -312,288 +311,90 @@ describe("Table Converter - #getTableManifestConfiguration ", function() {
 		});
 		expect(tableConfiguration.multiSelectMode).toEqual("ClearAll");
 	});
-});
-
-describe("Table Converter - #getCreateVisible", function() {
-	const IS_INSERTABLE_FALSE = constant(false);
-	const IS_INSERTABLE_TRUE = constant(true);
-	const IS_INSERTABLE_DYNAMIC = bindingExpression("SomeDynamicExpression");
-	let BASIC_CONTEXT_LR: ConverterContext;
-	let BASIC_CONTEXT_OP: ConverterContext;
-	let HIDDEN_CONTEXT_LR: ConverterContext;
-	let HIDDEN_CONTEXT_OP: ConverterContext;
-	let DYNAMIC_HIDDEN_CONTEXT_LR: ConverterContext;
-	let DYNAMIC_HIDDEN_CONTEXT_OP: ConverterContext;
-	let NEW_ACTION_NO_OA: ConverterContext;
-	let NEW_ACTION_OA_TRUE: ConverterContext;
-	let NEW_ACTION_OA_FALSE: ConverterContext;
 
-	beforeAll(function() {
-		BASIC_CONTEXT_LR = getConverterContextForTest(convertedTypes, {
-			entitySet: "TestEntity",
-			converterType: TemplateType.ListReport
-		});
-		BASIC_CONTEXT_OP = getConverterContextForTest(convertedTypes, {
-			entitySet: "TestEntity",
-			converterType: TemplateType.ObjectPage
-		});
-		HIDDEN_CONTEXT_LR = getConverterContextForTest(convertedTypes, {
-			entitySet: "CreateHiddenEntity",
-			converterType: TemplateType.ListReport
-		});
-		HIDDEN_CONTEXT_OP = getConverterContextForTest(convertedTypes, {
-			entitySet: "CreateHiddenEntity",
-			converterType: TemplateType.ObjectPage
-		});
-		DYNAMIC_HIDDEN_CONTEXT_LR = getConverterContextForTest(convertedTypes, {
-			entitySet: "CreateHiddenDynamicEntity",
-			converterType: TemplateType.ListReport
-		});
-		DYNAMIC_HIDDEN_CONTEXT_OP = getConverterContextForTest(convertedTypes, {
-			entitySet: "CreateHiddenDynamicEntity",
-			converterType: TemplateType.ObjectPage
-		});
-		NEW_ACTION_NO_OA = getConverterContextForTest(convertedTypesNoOa, {
-			entitySet: "TestEntity",
-			converterType: TemplateType.ListReport
-		});
-		NEW_ACTION_OA_TRUE = getConverterContextForTest(convertedTypesOaTrue, {
-			entitySet: "TestEntity",
-			converterType: TemplateType.ListReport
-		});
-		NEW_ACTION_OA_FALSE = getConverterContextForTest(convertedTypesOaFalse, {
+	it("Default for enableFullScreen (desktop or tablet)", () => {
+		// The default for desktop/tablet is false
+		const manifestSettings = {
 			entitySet: "TestEntity",
-			converterType: TemplateType.ListReport
-		});
-	});
-
-	it("If it's statically not insertable -> create is not visible", () => {
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_LR, CreationMode.CreationRow, IS_INSERTABLE_FALSE))).toEqual("false");
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_LR, "External", IS_INSERTABLE_FALSE))).toEqual("false");
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_OP, CreationMode.CreationRow, IS_INSERTABLE_FALSE))).toEqual("false");
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_OP, "External", IS_INSERTABLE_FALSE))).toEqual("false");
-	});
-
-	it("If create is statically hidden -> create is not visible", () => {
-		expect(compileBinding(getCreateVisible(HIDDEN_CONTEXT_LR, CreationMode.CreationRow, IS_INSERTABLE_TRUE))).toEqual("false");
-		expect(compileBinding(getCreateVisible(HIDDEN_CONTEXT_LR, "External", IS_INSERTABLE_TRUE))).toEqual("false");
-		expect(compileBinding(getCreateVisible(HIDDEN_CONTEXT_OP, CreationMode.CreationRow, IS_INSERTABLE_TRUE))).toEqual("false");
-		expect(compileBinding(getCreateVisible(HIDDEN_CONTEXT_OP, "External", IS_INSERTABLE_TRUE))).toEqual("false");
-	});
-
-	it("Otherwise if the create mode is external -> create is visible", () => {
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_LR, "External", IS_INSERTABLE_TRUE))).toEqual("true");
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_OP, "External", IS_INSERTABLE_TRUE))).toEqual("true");
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_LR, "External", IS_INSERTABLE_DYNAMIC))).toEqual("true");
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_OP, "External", IS_INSERTABLE_DYNAMIC))).toEqual("true");
-		expect(compileBinding(getCreateVisible(DYNAMIC_HIDDEN_CONTEXT_LR, "External", IS_INSERTABLE_TRUE))).toEqual("true");
-		expect(compileBinding(getCreateVisible(DYNAMIC_HIDDEN_CONTEXT_OP, "External", IS_INSERTABLE_TRUE))).toEqual("true");
-		expect(compileBinding(getCreateVisible(DYNAMIC_HIDDEN_CONTEXT_LR, "External", IS_INSERTABLE_DYNAMIC))).toEqual("true");
-		expect(compileBinding(getCreateVisible(DYNAMIC_HIDDEN_CONTEXT_OP, "External", IS_INSERTABLE_DYNAMIC))).toEqual("true");
-	});
-
-	it("If we're on the list report -> create is visible", () => {
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_LR, CreationMode.CreationRow, IS_INSERTABLE_TRUE))).toEqual("true");
-		expect(compileBinding(getCreateVisible(DYNAMIC_HIDDEN_CONTEXT_LR, CreationMode.CreationRow, IS_INSERTABLE_TRUE))).toEqual(
-			"{= !%{hiddenCreate}}"
-		);
-		expect(compileBinding(getCreateVisible(BASIC_CONTEXT_LR, CreationMode.CreationRow, IS_INSERTABLE_DYNAMIC))).toEqual("true");
-		expect(compileBinding(getCreateVisible(DYNAMIC_HIDDEN_CONTEXT_LR, CreationMode.CreationRow, IS_INSERTABLE_DYNAMIC))).toEqual(
-			"{= !%{hiddenCreate}}"
-		);
-	});
-
-	it("Otherwise this depends on the value of the the UI.IsEditable", () => {
-		expect(getCreateVisible(BASIC_CONTEXT_OP, CreationMode.CreationRow, IS_INSERTABLE_TRUE)).toEqual(UI.IsEditable);
-		expect(getCreateVisible(BASIC_CONTEXT_OP, CreationMode.CreationRow, IS_INSERTABLE_DYNAMIC)).toEqual(UI.IsEditable);
-		expect(compileBinding(getCreateVisible(DYNAMIC_HIDDEN_CONTEXT_OP, CreationMode.CreationRow, IS_INSERTABLE_TRUE))).toEqual(
-			"{= (!%{hiddenCreate} && %{ui>/isEditable})}"
-		);
-		expect(compileBinding(getCreateVisible(DYNAMIC_HIDDEN_CONTEXT_OP, CreationMode.CreationRow, IS_INSERTABLE_DYNAMIC))).toEqual(
-			"{= (!%{hiddenCreate} && %{ui>/isEditable})}"
-		);
+			converterType: TemplateType.ListReport,
+			isPhone: false
+		};
+		const tableConfiguration = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfiguration.enableFullScreen).toBe(false);
+		manifestSettings.converterType = TemplateType.ObjectPage;
+		const tableConfigurationOP = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfigurationOP.enableFullScreen).toBe(false);
 	});
 
-	it("If a New Action exists create depends on the Core.OperationAvailable annotation", () => {
-		expect(compileBinding(getCreateVisible(NEW_ACTION_NO_OA, CreationMode.CreationRow, IS_INSERTABLE_TRUE))).toEqual("true");
-		expect(compileBinding(getCreateVisible(NEW_ACTION_NO_OA, CreationMode.CreationRow, IS_INSERTABLE_FALSE))).toEqual("true");
-
-		expect(compileBinding(getCreateVisible(NEW_ACTION_OA_TRUE, CreationMode.CreationRow, IS_INSERTABLE_TRUE))).toEqual("true");
-		expect(compileBinding(getCreateVisible(NEW_ACTION_OA_TRUE, CreationMode.CreationRow, IS_INSERTABLE_FALSE))).toEqual("true");
-
-		expect(compileBinding(getCreateVisible(NEW_ACTION_OA_FALSE, CreationMode.CreationRow, IS_INSERTABLE_TRUE))).toEqual("false");
-		expect(compileBinding(getCreateVisible(NEW_ACTION_OA_FALSE, CreationMode.CreationRow, IS_INSERTABLE_FALSE))).toEqual("false");
+	it("Default for enableFullScreen (phone)", () => {
+		// The default for phone is true
+		const manifestSettings = {
+			entitySet: "TestEntity",
+			converterType: TemplateType.ListReport,
+			isPhone: true
+		};
+		const tableConfiguration = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfiguration.enableFullScreen).toBe(true);
+		manifestSettings.converterType = TemplateType.ObjectPage;
+		const tableConfigurationOP = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfigurationOP.enableFullScreen).toBe(true);
 	});
-});
 
-describe("Table Converter - #getVisibilityMassEdit", function() {
-	let BASIC_CONTEXT_LR: ConverterContext;
-	let BASIC_CONTEXT_OP: ConverterContext;
-	let BASIC_CONTEXT_OP_UPDATEHIDDEN: ConverterContext;
-	let BASIC_CONTEXT_OP_UPDATEHIDDEN1: ConverterContext;
-	let BASIC_CONTEXT_OP_UPDATEHIDDEN_PATH: ConverterContext;
-	const tableManifestConfigurationWithMassEdit: any = {
-		enableMassEdit: true
-	};
-	const tableManifestConfigurationWithoutMassEdit: any = {
-		enableMassEdit: false
-	};
-	const tableConfWithMassEditSelectionLimit: any = {
-		enableMassEdit: false,
-		selectionLimit: 1
-	};
-	beforeAll(function() {
-		BASIC_CONTEXT_LR = getConverterContextForTest(convertedTypes, {
-			entitySet: "TestEntity",
-			converterType: TemplateType.ListReport
-		});
-		BASIC_CONTEXT_OP = getConverterContextForTest(convertedTypes, {
+	it("Influence enableFullScreen (desktop or tablet)", () => {
+		// If defined, then the value should be equal to the provided setting, excpept for ListReport it is false
+		const manifestSettings = {
 			entitySet: "TestEntity",
-			converterType: TemplateType.ObjectPage
-		});
-		BASIC_CONTEXT_OP_UPDATEHIDDEN = getConverterContextForTest(convertedTypes, {
-			entitySet: "UpdateHiddenEntity",
-			converterType: TemplateType.ObjectPage
-		});
-		BASIC_CONTEXT_OP_UPDATEHIDDEN1 = getConverterContextForTest(convertedTypes, {
-			entitySet: "UpdateHiddenEntity1",
-			converterType: TemplateType.ObjectPage
-		});
-		BASIC_CONTEXT_OP_UPDATEHIDDEN_PATH = getConverterContextForTest(convertedTypes, {
-			entitySet: "MassEditUpdateHiddenDynamicEntity",
-			converterType: TemplateType.ObjectPage
-		});
-	});
+			converterType: TemplateType.ListReport,
+			controlConfiguration: {
+				"@com.sap.vocabularies.UI.v1.LineItem": {
+					tableSettings: {
+						enableFullScreen: true
+					}
+				}
+			}
+		};
+		const tableConfiguration = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfiguration.enableFullScreen).toBe(false); // switched to false for ListReport
+		manifestSettings.converterType = TemplateType.ObjectPage;
+		const tableConfigurationOP = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfigurationOP.enableFullScreen).toBe(true);
 
-	it("For list report Mass edit should not be visible in any case.", () => {
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_LR,
-				tableManifestConfigurationWithMassEdit,
-				{ isUpdatable: true, isDeletable: true },
-				undefined
-			)
-		).toEqual(false);
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_LR,
-				tableManifestConfigurationWithoutMassEdit,
-				{ isUpdatable: true, isDeletable: true },
-				undefined
-			)
-		).toEqual(false);
+		manifestSettings.converterType = TemplateType.ListReport;
+		manifestSettings.controlConfiguration["@com.sap.vocabularies.UI.v1.LineItem"].tableSettings.enableFullScreen = false;
+		const tableConfiguration2 = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfiguration2.enableFullScreen).toBe(false);
+		manifestSettings.converterType = TemplateType.ObjectPage;
+		const tableConfigurationOP2 = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfigurationOP2.enableFullScreen).toBe(false);
 	});
 
-	it("Different cases of mass edit visibility in object page.", () => {
-		//Mass Edit is enabled from manifest, entity set updatable is static false => Mass edit should not be visible.
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_OP,
-				tableManifestConfigurationWithMassEdit,
-				{ isUpdatable: false, isDeletable: true },
-				undefined
-			)
-		).toEqual(false);
-		//Mass Edit is disabled from manifest, entity set updatable is static true => Mass edit should not be visible.
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_OP,
-				tableManifestConfigurationWithoutMassEdit,
-				{ isUpdatable: true, isDeletable: true },
-				undefined
-			)
-		).toEqual(false);
-		//Mass Edit is enabled from manifest, entity set updatable is static true for List Report context => Mass edit should not be visible.
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_LR,
-				tableManifestConfigurationWithMassEdit,
-				{ isUpdatable: true, isDeletable: true },
-				undefined
-			)
-		).toEqual(false);
-		//Mass Edit is enabled from manifest, entity set updatable is static true for object page context => Mass edit should be visible if object page is in edit mode.
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_OP,
-				tableManifestConfigurationWithMassEdit,
-				{ isUpdatable: true, isDeletable: true },
-				undefined
-			)
-		).toEqual("{ui>/isEditable}");
-		//Mass Edit is enabled from manifest, entity set updatable is static true for object page context, selection mode is singal => Mass edit should not be visible.
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_OP,
-				tableManifestConfigurationWithMassEdit,
-				{ isUpdatable: true, isDeletable: true },
-				"Single"
-			)
-		).toEqual(false);
-		//Mass Edit is enabled from manifest, entity set updatable is static true for object page context, selection limit is set to 1 => Mass edit should not be visible.
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_OP,
-				tableConfWithMassEditSelectionLimit,
-				{ isUpdatable: true, isDeletable: true },
-				undefined
-			)
-		).toEqual(false);
-		//Mass Edit is enabled from manifest, entity set updatable is static true for object page context, update hidden annotation is true => Mass edit should not be visible.
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_OP_UPDATEHIDDEN,
-				tableManifestConfigurationWithMassEdit,
-				{ isUpdatable: true, isDeletable: true },
-				undefined
-			)
-		).toEqual(false);
-		//Mass Edit is enabled from manifest, entity set updatable is static true for object page context, update hidden annotation is path based => Mass edit should be visible if the path value is false and object page is in edit mode.
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_OP_UPDATEHIDDEN_PATH,
-				tableManifestConfigurationWithMassEdit,
-				{ isUpdatable: true, isDeletable: true },
-				undefined
-			)
-		).toEqual("{= (%{ui>/isEditable} === true && %{updateHidden} === false)}");
-
-		//Mass Edit is enabled from manifest, entity set updatable is static true for object page context, update hidden annotation is false => Mass edit should be visible if object page is in edit mode.
-		expect(
-			getVisibilityMassEdit(
-				BASIC_CONTEXT_OP_UPDATEHIDDEN1,
-				tableManifestConfigurationWithMassEdit,
-				{ isUpdatable: true, isDeletable: true },
-				undefined
-			)
-		).toEqual("{ui>/isEditable}");
-	});
-});
+	it("Influence enableFullScreen (phone)", () => {
+		// If defined, then the value should be equal to the provided setting
+		const manifestSettings = {
+			entitySet: "TestEntity",
+			converterType: TemplateType.ListReport,
+			controlConfiguration: {
+				"@com.sap.vocabularies.UI.v1.LineItem": {
+					tableSettings: {
+						enableFullScreen: true
+					}
+				}
+			},
+			isPhone: true
+		};
+		const tableConfiguration = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfiguration.enableFullScreen).toBe(true);
+		manifestSettings.converterType = TemplateType.ObjectPage;
+		const tableConfigurationOP = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfigurationOP.enableFullScreen).toBe(true);
 
-describe("Table Converter - #getEnablementMassEdit", function() {
-	let BASIC_CONTEXT_OP_PATH_BASED_UPDATE_RESTRICTION: ConverterContext;
-	let BASIC_CONTEXT_OP_STATIC_UPDATE_RESTRICTION: ConverterContext;
-	beforeAll(function() {
-		BASIC_CONTEXT_OP_PATH_BASED_UPDATE_RESTRICTION = getConverterContextForTest(convertedTypes, {
-			entitySet: "EntitySetWithPathBasedUpdateRestriction",
-			converterType: TemplateType.ObjectPage
-		});
-		BASIC_CONTEXT_OP_STATIC_UPDATE_RESTRICTION = getConverterContextForTest(convertedTypes, {
-			entitySet: "EntitySetWithStaticUpdateRestriction",
-			converterType: TemplateType.ObjectPage
-		});
-	});
-	//This scenario will be handled in tablehelper returning false from converter in this case
-	it("The mass edit is visible, and update restrictions are set to a path value of current entity set.", () => {
-		expect(getEnablementMassEdit(BASIC_CONTEXT_OP_PATH_BASED_UPDATE_RESTRICTION, true)).toEqual(false);
-	});
-	it("The mass edit is visible, and update restrictions are set to static true.", () => {
-		expect(getEnablementMassEdit(BASIC_CONTEXT_OP_STATIC_UPDATE_RESTRICTION, true)).toEqual(
-			"{= %{internal>numberOfSelectedContexts} >= 2 && true}"
-		);
-	});
-	it("The mass edit is not visible as update restrictions are set to static false.", () => {
-		expect(getEnablementMassEdit(BASIC_CONTEXT_OP_STATIC_UPDATE_RESTRICTION, false)).toEqual(false);
+		manifestSettings.converterType = TemplateType.ListReport;
+		manifestSettings.controlConfiguration["@com.sap.vocabularies.UI.v1.LineItem"].tableSettings.enableFullScreen = false;
+		const tableConfiguration2 = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfiguration2.enableFullScreen).toBe(false);
+		manifestSettings.converterType = TemplateType.ObjectPage;
+		const tableConfigurationOP2 = getTableConfigurationForTest(manifestSettings);
+		expect(tableConfigurationOP2.enableFullScreen).toBe(false);
 	});
 });
 
@@ -615,7 +416,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 		);
 	};
 
-	it("For a service that is neither Draft enabled, nor Sticky-Session supported, neither is it containment-enabled, if the selectionMode is explicitly set to 'None': The LR tableSelectionMode is 'None'", () => {
+	it("If the bound entity is deletable then the LR table selectionMode is ignored", () => {
 		const basicContext_LR = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "NoDeleteButtonEntity",
 			converterType: TemplateType.ListReport,
@@ -627,11 +428,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 				}
 			}
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(true);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: true, isUpdatable: false },
@@ -639,10 +436,10 @@ describe("Table Converter - #getSelectionMode ", function() {
 			"@com.sap.vocabularies.UI.v1.LineItem",
 			isDeleteButtonVisible
 		);
-		expect(result).toEqual("None");
+		expect(result).toEqual("Multi");
 	});
 
-	it("For a service that is neither Draft enabled, nor Sticky-Session supported, neither is it containment-enabled, if the selectionMode is explicitly set to 'None': The OP tableSelectionMode is 'None'", () => {
+	it("If the bound entity is deletable then the OP table selectionMode is ignored in edit mode", () => {
 		const basicContext_OP = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "NoDeleteButtonEntity",
 			converterType: TemplateType.ObjectPage,
@@ -654,11 +451,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 				}
 			}
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_OP,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = bindingExpression("dummyOPExpression");
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: true, isUpdatable: false },
@@ -666,18 +459,14 @@ describe("Table Converter - #getSelectionMode ", function() {
 			"@com.sap.vocabularies.UI.v1.LineItem",
 			isDeleteButtonVisible
 		);
-		expect(result).toEqual("None");
+		expect(result).toEqual("{= %{dummyOPExpression} ? 'Multi' : 'None'}");
 	});
-	it("For a service that is neither Draft enabled/Sticky-Session/containment-enabled, the selectionMode is not set, there is no action and the entity is deletable : The OP tableSelectionMode is 'None'", () => {
+	it("If there is no action and the bound entity is deletable : The OP table selectionMode is 'Multi' in edit mode", () => {
 		const basicContext_OP = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "NoDeleteButtonEntity",
 			converterType: TemplateType.ObjectPage
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_OP,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = bindingExpression("dummyOPExpression");
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: true, isUpdatable: false },
@@ -685,7 +474,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			"@com.sap.vocabularies.UI.v1.LineItem",
 			isDeleteButtonVisible
 		);
-		expect(result).toEqual("None");
+		expect(result).toEqual("{= (%{ui>/editMode} === 'Editable' && %{dummyOPExpression}) ? 'Multi' : 'None'}");
 	});
 
 	it("If the selectionMode is explicitly set to 'None' : The LR tableSelectionMode is 'None' when the delete button is statically hidden", () => {
@@ -700,11 +489,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 				}
 			}
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(false);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: true, isUpdatable: false },
@@ -727,11 +512,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 				}
 			}
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_OP,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(false);
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: true, isUpdatable: false },
@@ -754,11 +535,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 				}
 			}
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = bindingExpression("dummyLRExpression");
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: true, isUpdatable: false },
@@ -766,7 +543,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			"@com.sap.vocabularies.UI.v1.LineItem",
 			isDeleteButtonVisible
 		);
-		expect(result).toEqual("{= %{isDeleteHidden} ? 'None' : 'Multi'}");
+		expect(result).toEqual("{= %{dummyLRExpression} ? 'Multi' : 'None'}");
 	});
 
 	it("If the selectionMode is explicitly set to 'None' : The OP tableSelectionMode is overridden in Edit Mode when the delete button is not statically hidden", () => {
@@ -781,11 +558,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 				}
 			}
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_OP,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = bindingExpression("dummyOPExpression");
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: true, isUpdatable: false },
@@ -793,18 +566,14 @@ describe("Table Converter - #getSelectionMode ", function() {
 			"@com.sap.vocabularies.UI.v1.LineItem",
 			isDeleteButtonVisible
 		);
-		expect(result).toEqual("{= (%{ui>/editMode} === 'Editable' && !%{isDeleteHidden}) ? 'Multi' : 'None'}");
+		expect(result).toEqual("{= %{dummyOPExpression} ? 'Multi' : 'None'}");
 	});
 	it("If the Entity is not deletable and the LR table has not action : the tableSelectionMode is 'None' ", () => {
 		const basicContext_LR = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "EntityWithoutActionOnTable",
 			converterType: TemplateType.ListReport
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(true);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
@@ -819,11 +588,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithoutActionOnTable",
 			converterType: TemplateType.ListReport
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(true);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: true, isUpdatable: false },
@@ -833,16 +598,12 @@ describe("Table Converter - #getSelectionMode ", function() {
 		);
 		expect(result).toEqual("Multi");
 	});
-	it("If the Entity is deletable, the LR table has not action and the service is neither Draft enabled/Sticky-Session/containment-enabled : the tableSelectionMode is 'None' ", () => {
+	it("If the bound entity is deletable: the LR table selectionMode is 'Multi' ", () => {
 		const basicContext_LR = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "NoDeleteButtonEntity",
 			converterType: TemplateType.ListReport
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(true);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: true, isUpdatable: false },
@@ -850,18 +611,14 @@ describe("Table Converter - #getSelectionMode ", function() {
 			"@com.sap.vocabularies.UI.v1.LineItem",
 			isDeleteButtonVisible
 		);
-		expect(result).toEqual("None");
+		expect(result).toEqual("Multi");
 	});
 	it("If the Entity is not deletable and the LR table has at least 1 bound action : the tableSelectionMode is 'Multi' ", () => {
 		const basicContext_LR = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "EntityWithBoundActionOnTable",
 			converterType: TemplateType.ListReport
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(false);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
@@ -876,11 +633,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithUnBoundActionOnTable",
 			converterType: TemplateType.ListReport
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(false);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
@@ -895,11 +648,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithBoundActionOnTable",
 			converterType: TemplateType.ListReport
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(false);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
@@ -914,11 +663,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithActionRequingContextOnTable",
 			converterType: TemplateType.ListReport
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_LR,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(false);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
@@ -1016,11 +761,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithoutActionOnTable",
 			converterType: TemplateType.ObjectPage
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_OP,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(false);
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: false, isUpdatable: false },
@@ -1035,11 +776,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithoutActionOnTable",
 			converterType: TemplateType.ObjectPage
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_OP,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(false);
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: true, isUpdatable: false },
@@ -1091,11 +828,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithBoundActionNotBoundOnTheTable",
 			converterType: TemplateType.ObjectPage
 		});
-		const isDeleteButtonVisible = getDeleteVisible(
-			basicContext_OP,
-			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
-			true
-		);
+		const isDeleteButtonVisible = constant(false);
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: false, isUpdatable: false },
@@ -1798,6 +1531,53 @@ describe("Table Converter - #getTableColumns", function() {
 			expect(columns[10].key).toBe("Property::name");
 		}
 	);
+
+	it(
+		"gets tooltip values",
+		{
+			"references": [
+				{
+					"type": "BCP",
+					"ID": "2170309258"
+				}
+			]
+		},
+		function() {
+			const converterContext = getConverterContextForTest(convertedTypesTooltips, {
+				converterType: TemplateType.ListReport,
+				entitySet: "TestEntity"
+			});
+			const columns = getTableColumns(
+				(converterContext.getEntityType().annotations?.UI as any)["LineItem"] as LineItem,
+				"@" + UIAnnotationTerms.LineItem,
+				converterContext,
+				{}
+			) as AnnotationTableColumn[];
+
+			expect(columns.length).toBe(13);
+
+			expect(columns[0].key).toBe("DataField::amount2");
+			expect(columns[0].tooltip).toBe("Tooltip for amount2");
+
+			expect(columns[1].key).toBe("DataField::currency");
+			expect(columns[1].tooltip).toBeUndefined();
+
+			expect(columns[2].key).toBe("DataField::ID");
+			expect(columns[2].tooltip).toBe("Tooltip for ID");
+
+			expect(columns[3].key).toBe("DataField::name");
+			expect(columns[3].tooltip).toBe("Tooltip for name");
+
+			expect(columns[4].key).toBe("DataField::amount");
+			expect(columns[4].tooltip).toBe("Tooltip for amount");
+
+			expect(columns[5].key).toBe("DataFieldForAnnotation::DataPoint::forAmount");
+			expect(columns[5].tooltip).toBe("Tooltip for amount");
+
+			expect(columns[6].key).toBe("DataFieldWithUrl::description");
+			expect(columns[6].tooltip).toBeUndefined();
+		}
+	);
 });
 
 describe("Table Converter - #isFilteringCaseSensitive", function() {