@sap/open.fe 1.97.0 → 1.98.0

package/packages/sap.fe.templates/test/sap/fe/templates/jest/RootContainer/RootContainerBaseController.spec.ts

@@ -0,0 +1,157 @@
+import { RootContainerBaseController } from "sap/fe/templates/RootContainer/controller";
+import { compileCDS, getMetaModel } from "sap/fe/test/JestTemplatingHelper";
+import path from "path";
+import { MockContext } from "sap/fe/test/UI5MockHelper";
+
+class MockView {
+	getParent() {
+		return {
+			_getPageTitleInformation: function() {
+				return {
+					title: "Page-Title",
+					subtitle: "Page-Subtitle",
+					intent: "",
+					icon: ""
+				};
+			}
+		};
+	}
+
+	public getBindingContext = jest.fn();
+}
+
+const mockShellService = {
+	setHierarchy: jest.fn(),
+	setTitle: jest.fn()
+};
+
+const mockAppComponent = {
+	getMetadata: function() {
+		return {
+			getManifestEntry: function() {
+				return {
+					title: "MyAppTitle",
+					appSubTitle: "MyAppSubtitle"
+				};
+			}
+		};
+	},
+	getShellServices: function() {
+		return mockShellService;
+	},
+	getMetaModel: jest.fn()
+};
+
+class TestableRootContainerBaseController extends RootContainerBaseController {
+	public _getTargetTypeFromHash = jest.fn();
+	public _getAppSpecificHash() {
+		return "#myApp-view&/";
+	}
+	public _getHash = jest.fn();
+	public getAppComponent() {
+		return mockAppComponent;
+	}
+	public _fetchTitleValue = jest.fn((sPath: string) => {
+		return Promise.resolve("Title for " + sPath);
+	});
+}
+
+const aTestData = [
+	{
+		desc: "builds hierarchy for a listReport",
+		startsWithLR: true,
+		currentHash: ""
+	},
+	{
+		desc: "builds hierarchy for an objectPage",
+		startsWithLR: true,
+		currentHash: "SalesOrder(123)"
+	},
+	{
+		desc: "builds hierarchy for a sub-objectPage",
+		startsWithLR: true,
+		currentHash: "SalesOrder(123)/_Item(456)"
+	},
+	{
+		desc: "builds hierarchy for a level-3 objectPage",
+		startsWithLR: true,
+		currentHash: "SalesOrder(123)/_Item(456)/_Material(789)"
+	},
+	{
+		desc: "builds hierarchy for a level-3 objectPage without ListReport",
+		startsWithLR: false,
+		currentHash: "SalesOrder(123)/_Item(456)/_Material(789)"
+	},
+	{
+		desc: "builds hierarchy with parametrized entity",
+		startsWithLR: true,
+		currentHash: "Category(123)/_Product(456)"
+	}
+];
+
+describe("RootContainerBaseController - #computeTitleHierarchy", () => {
+	let controller: TestableRootContainerBaseController;
+	let mockView: MockView;
+	let metaModel: any;
+
+	beforeAll(async () => {
+		const sMetadataUrl = compileCDS(path.join(__dirname, "../data/RootContainerBaseController.cds"));
+		metaModel = await getMetaModel(sMetadataUrl);
+	});
+
+	beforeEach(() => {
+		jest.resetAllMocks();
+		controller = new TestableRootContainerBaseController();
+		mockView = new MockView();
+		mockAppComponent.getMetaModel.mockReturnValue(metaModel);
+	});
+
+	it.each(aTestData)("$desc", async ({ startsWithLR, currentHash }) => {
+		if (startsWithLR) {
+			controller._getTargetTypeFromHash.mockReturnValue("sap.fe.templates.ListReport");
+		} else {
+			controller._getTargetTypeFromHash.mockReturnValue("sap.fe.templates.ObjectPage");
+		}
+		controller._getHash.mockReturnValue(currentHash);
+		if (currentHash) {
+			mockView.getBindingContext.mockReturnValue(new MockContext({ $path: "/" + currentHash }));
+		}
+		const computed = await controller._computeTitleHierarchy(mockView);
+
+		expect(mockShellService.setTitle).toBeCalledWith("Page-Title");
+		expect(mockShellService.setHierarchy.mock.calls).toHaveLength(1);
+		expect(mockShellService.setHierarchy.mock.calls[0][0]).toMatchSnapshot();
+		expect(controller._getTitleHierarchyCache()).toMatchSnapshot();
+	});
+
+	it(
+		"uses cache with subsequent navigations",
+		{
+			references: [
+				{
+					"type": "JIRA",
+					"ID": "FIORITECHP1-11956"
+				}
+			]
+		},
+		async () => {
+			controller._getTargetTypeFromHash.mockReturnValue("sap.fe.templates.ListReport");
+			controller._getHash
+				.mockReturnValueOnce("")
+				.mockReturnValueOnce("SalesOrder(123)")
+				.mockReturnValueOnce("SalesOrder(123)/_Item(456)");
+			mockView.getBindingContext
+				.mockReturnValueOnce(undefined)
+				.mockReturnValueOnce(new MockContext({ $path: "/SalesOrder(123)" }))
+				.mockReturnValueOnce(new MockContext({ $path: "/SalesOrder(123)/_Item(456)" }));
+
+			const computed1 = await controller._computeTitleHierarchy(mockView);
+			const computed2 = await controller._computeTitleHierarchy(mockView);
+			const computed3 = await controller._computeTitleHierarchy(mockView);
+			expect(mockShellService.setHierarchy.mock.calls).toHaveLength(3);
+			expect(mockShellService.setHierarchy.mock.calls[2][0]).toMatchSnapshot();
+			expect(controller._getTitleHierarchyCache()).toMatchSnapshot();
+			expect(controller._fetchTitleValue.mock.calls).toHaveLength(0); // All hierarchy entries should be built as we navigate forward
+		}
+	);
+});

package/packages/sap.fe.templates/test/sap/fe/templates/jest/RootContainer/__snapshots__/RootContainerBaseController.spec.ts.snap

@@ -0,0 +1,218 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 1`] = `Array []`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 2`] = `
+Object {
+  "#myApp-view&/": Object {
+    "icon": "",
+    "intent": "#myApp-view&/?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+}
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 3`] = `
+Array [
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/?restoreHistory=true",
+    "subtitle": "MyAppSubtitle",
+    "title": "MyAppTitle",
+  },
+]
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 4`] = `
+Object {
+  "/SalesOrder(123)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+}
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 5`] = `
+Array [
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)",
+    "title": "Sales Order",
+  },
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/?restoreHistory=true",
+    "subtitle": "MyAppSubtitle",
+    "title": "MyAppTitle",
+  },
+]
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 6`] = `
+Object {
+  "/SalesOrder(123)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)",
+    "title": "Sales Order",
+  },
+  "/SalesOrder(123)/_Item(456)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)/_Item(456)?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+}
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 7`] = `
+Array [
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)/_Item(456)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)/_Item(456)",
+    "title": "Sales Order Item",
+  },
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)",
+    "title": "Sales Order",
+  },
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/?restoreHistory=true",
+    "subtitle": "MyAppSubtitle",
+    "title": "MyAppTitle",
+  },
+]
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 8`] = `
+Object {
+  "/SalesOrder(123)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)",
+    "title": "Sales Order",
+  },
+  "/SalesOrder(123)/_Item(456)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)/_Item(456)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)/_Item(456)",
+    "title": "Sales Order Item",
+  },
+  "/SalesOrder(123)/_Item(456)/_Material(789)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)/_Item(456)/_Material(789)?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+}
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 9`] = `
+Array [
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)/_Item(456)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)/_Item(456)",
+    "title": "Sales Order Item",
+  },
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)",
+    "title": "Sales Order",
+  },
+]
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 10`] = `
+Object {
+  "/SalesOrder(123)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)",
+    "title": "Sales Order",
+  },
+  "/SalesOrder(123)/_Item(456)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)/_Item(456)?restoreHistory=true",
+    "subtitle": "Title for /SalesOrder(123)/_Item(456)",
+    "title": "Sales Order Item",
+  },
+  "/SalesOrder(123)/_Item(456)/_Material(789)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)/_Item(456)/_Material(789)?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+}
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 11`] = `
+Array [
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/?restoreHistory=true",
+    "subtitle": "MyAppSubtitle",
+    "title": "MyAppTitle",
+  },
+]
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy $desc 12`] = `
+Object {
+  "/Category(123)/_Product(456)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/Category(123)/_Product(456)?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+}
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy uses cache with subsequent navigations 1`] = `
+Array [
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+  Object {
+    "icon": "",
+    "intent": "#myApp-view&/?restoreHistory=true",
+    "subtitle": "MyAppSubtitle",
+    "title": "MyAppTitle",
+  },
+]
+`;
+
+exports[`RootContainerBaseController - #computeTitleHierarchy uses cache with subsequent navigations 2`] = `
+Object {
+  "#myApp-view&/": Object {
+    "icon": "",
+    "intent": "#myApp-view&/?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+  "/SalesOrder(123)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+  "/SalesOrder(123)/_Item(456)": Object {
+    "icon": "",
+    "intent": "#myApp-view&/SalesOrder(123)/_Item(456)?restoreHistory=true",
+    "subtitle": "Page-Subtitle",
+    "title": "Page-Title",
+  },
+}
+`;

package/packages/sap.fe.templates/test/sap/fe/templates/jest/data/RootContainerBaseController.cds

@@ -0,0 +1,64 @@
+namespace sap.fe.test;
+
+service JestService {
+    entity SalesOrder {
+        key ID             : Integer;
+            SalesOrderName : String;
+            _Item          : Composition of many Item;
+    };
+
+    entity Item {
+        key ItemID    : UUID;
+            ItemName  : String;
+            OrderID   : Integer;
+            _Material : Composition of many Material;
+    };
+
+    entity Material {
+        key MaterialID  : UUID;
+            MaterialRef : Integer;
+    };
+
+    @Common : { ResultContext }
+    entity Category {
+        key ID: UUID;
+            _Products : Association to many Product;
+    };
+
+    entity Product {
+        key ID: UUID;
+            productName: String;
+    }
+}
+
+annotate sap.fe.test.JestService.SalesOrder with @UI : { 
+    HeaderInfo  : {
+        $Type : 'UI.HeaderInfoType',
+        TypeName : 'Sales Order',
+        TypeNamePlural : 'Sales Orders',
+    }
+};
+
+annotate sap.fe.test.JestService.Item with @UI : { 
+    HeaderInfo  : {
+        $Type : 'UI.HeaderInfoType',
+        TypeName : 'Sales Order Item',
+        TypeNamePlural : 'Sales Order Items',
+    }
+};
+
+annotate sap.fe.test.JestService.Material with @UI : { 
+    HeaderInfo  : {
+        $Type : 'UI.HeaderInfoType',
+        TypeName : 'Material in Item',
+        TypeNamePlural : 'Materials in Item',
+    }
+};
+
+annotate sap.fe.test.JestService.Product with @UI : { 
+    HeaderInfo  : {
+        $Type : 'UI.HeaderInfoType',
+        TypeName : 'Product in a category',
+        TypeNamePlural : 'Products in a category',
+    }
+};

package/packages/sap.fe.templates/test/sap/fe/templates/relnotes/changes-1.98.json

@@ -0,0 +1,201 @@
+{
+  "1.98.0": {
+    "date": "January 2022",
+    "notes": [
+      {
+        "id": "b158f1fa896b996a89e61aef58346df2ef5cb545",
+        "type": "FEATURE",
+        "text": " Applications can now use the Mass Edit feature in list reports"
+      },
+      {
+        "id": "0a761a6c13501a6c4fef37773cb4fe8300e1e056",
+        "type": "FIX",
+        "text": " The link in the MessagePopover now triggers the focus on the field containing the error",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2180433207"
+          }
+        ]
+      },
+      {
+        "id": "d82b032a5440637f3dd848b2e9c3c6e3e24c7a3c",
+        "type": "FIX",
+        "text": " The property \"Initials\" is now supported in the title of an object page",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170323402"
+          }
+        ]
+      },
+      {
+        "id": "60700b5920d48582e43c3ee907792ca9bb57fe32",
+        "type": "FIX",
+        "text": " The shared email link for cFLP apps is now fixed",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170230319"
+          }
+        ]
+      },
+      {
+        "id": "5b8c1469acab1cc98e70c59cb9cc6aa5a59419ca",
+        "type": "FIX",
+        "text": " A wrong annotation column key referenced in the manifest no longer prevents the application from starting",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2180406547"
+          }
+        ]
+      },
+      {
+        "id": "e7d0738e032786a03ac1d096b05dafae4a412c98",
+        "type": "FIX",
+        "text": " Facet hidden annotation are now set correctly",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170316605"
+          }
+        ]
+      },
+      {
+        "id": "7033df36d65ededd70a12afb42de4524d65a01e0",
+        "type": "FEATURE",
+        "text": " Navigation to a semantic object has been enabled for DataPoints on the object page"
+      },
+      {
+        "id": "110e34e93df15ae151b97f2c1056065e095dcdac",
+        "type": "FIX",
+        "text": " The support of dynamic expressions in facets is set now correctly",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170282639"
+          }
+        ]
+      },
+      {
+        "id": "7ed82642885065a7a8de177f30b8982a456551ca",
+        "type": "FEATURE",
+        "text": " The getBindingContext is now available in the ExtensionAPI for the object page"
+      },
+      {
+        "id": "ac6c9ff21f4ec50b3d560e0cbdb492c90167745b",
+        "type": "FEATURE",
+        "text": " The list report now stores/restores the table personalization into the iAppState"
+      },
+      {
+        "id": "cf0c4356aab04cdcaf5f0edc58c00dc9d6b19247",
+        "type": "FIX",
+        "text": " Based on the settings you make in the SAP Fiori launchpad, external navigation now opens in a new tab",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "002075129500007350822021"
+          }
+        ]
+      },
+      {
+        "id": "db014b00f0c174862cbcc9548156b15ef42f9620",
+        "type": "FIX",
+        "text": " The issue related to the duplication of a newly created item in flexible column mode has been fixed",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170219776"
+          }
+        ]
+      },
+      {
+        "id": "be1117510cd4ee273eb2f9579a459463180df829",
+        "type": "FEATURE",
+        "text": " SAP Fiori elements now enables you to navigate to a different internal target"
+      },
+      {
+        "id": "5f9ad0add514a92470be64bd6ac4c854caa48b91",
+        "type": "FIX",
+        "text": " Applications can now define an individual title for action dialogs using the preferredMode create/createWith parameter",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170326311"
+          }
+        ]
+      },
+      {
+        "id": "cea6e821da62fffded3800767bb2426735d164be",
+        "type": "FEATURE",
+        "text": " In the list report, the search field is now also available when you use an analytical table"
+      },
+      {
+        "id": "05b51e9d945e2f4c5673209f1ffa0f785f811d9a",
+        "type": "FIX",
+        "text": " The default alignment of dates and currencies has been changed to \"sap.ui.core.HorizontalAlign.Right\"",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170227320"
+          }
+        ]
+      },
+      {
+        "id": "3f8b8e0efb820a3a08bdd760ce779c3118b26bf6",
+        "type": "FEATURE",
+        "text": " The number of items is now displayed in the table toolbar in analytical cases"
+      },
+      {
+        "id": "f88f62cf49a8f94be8d60bac0ec295b702bc45a6",
+        "type": "FIX",
+        "text": " SAP Fiori elements now updates the IconTabBar counts on a list report when a new entity is created",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170328178"
+          }
+        ]
+      },
+      {
+        "id": "668d11663be5d65df70d9fd69389909c720e3557",
+        "type": "FIX",
+        "text": " SAP Fiori elements now disables the quick filters on the table only when the FilterBar conditions are changed",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170312585"
+          }
+        ]
+      },
+      {
+        "id": "2d72cf999be1c361a8072b9e42b8e7bd660f0a78",
+        "type": "FEATURE",
+        "text": " Navigation to an app by clicking on the header of a KPI card is now supported"
+      },
+      {
+        "id": "279c23061aaa126378e4998cf4935071bef52dfa",
+        "type": "FIX",
+        "text": " The Create Button on the List Report table is now visible if insertion is switched off and external creation is maintained",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170323614"
+          }
+        ]
+      },
+      {
+        "id": "9d0f27019e9b5ce00ad91dcace905826acc44981",
+        "type": "FIX",
+        "text": " When you discard a newly created draft in a list report, the navigation now works correctly",
+        "references": [
+          {
+            "type": "BCP",
+            "reference": "2170246068"
+          }
+        ]
+      }
+    ]
+  }
+}

package/packages/sap.fe.test/src/sap/fe/test/.library

@@ -6,7 +6,7 @@
     <copyright>SAP UI development toolkit for HTML5 (SAPUI5)
         (c) Copyright 2009-2021 SAP SE. All rights reserved
     </copyright>
-    <version>1.97.0</version>
+    <version>1.98.0</version>
 
     <documentation>UI5 library: sap.fe.test</documentation>
 

package/packages/sap.fe.test/src/sap/fe/test/.theming

@@ -1,6 +1,6 @@
 {
   "sEntity": "Library",
   "sId": "sap/fe/test",
-  "sVersion": "1.97.0",
+  "sVersion": "1.98.0",
   "bIgnore": true
 }

package/packages/sap.fe.test/src/sap/fe/test/JourneyRunner-dbg.js

@@ -71,7 +71,9 @@ sap.ui.define(
 			 * @param {object} [mSettings.launchParameters] The URL launch parameters
 			 * @param {boolean} [mSettings.async] If false (default), only one JourneyRunner is executed at a time
 			 * @param {Function[] | string[]} vJourneys The journeys to be executed. If a journey is represented as a string, it will be interpreted
-			 * as a module path to the file that should be loaded. Else it is expected to be a function
+			 * as a module path to the file that should be loaded. Else it is expected to be a function.
+			 * Alternatively, instead of being wrapped in an array, the journeys can also be given as separate parameters: 
+			 * <pre>.run(mSettings, Journey1, Journey2, ...)</pre>
 			 * @returns {object} A <code>Promise</code> that is resolved after all tests have been executed
 			 *
 			 * @function
@@ -87,8 +89,11 @@ sap.ui.define(
 					mSettings = Utils.mergeObjects(this._mInstanceSettings, mSettings);
 				}
 
-				var aJourneys = Utils.getParametersArray(iJourneyParameterIndex, arguments),
-					bAsync = mSettings.async,
+				var aJourneys = Array.prototype.slice.call(arguments, iJourneyParameterIndex); // journey-related parameter(s) as array
+				if (aJourneys && aJourneys.length && Array.isArray(aJourneys[0])) { // if the first journey parameter is an array...
+					aJourneys = aJourneys[0]; // ...then unwrap it, to use this array itself
+				}
+				var bAsync = mSettings.async,
 					pSyncPromise;
 
 				if (bAsync) {