@remit/backend 0.0.143 → 0.0.145

package/src/handlers/outbox.ts

@@ -1,258 +0,0 @@
-import type {
-	CreateOutboxMessageInput,
-	OutboxMessageResponse,
-	UpdateOutboxMessageInput,
-} from "@remit/api-openapi-types";
-import type {
-	OutboxAttachmentItem,
-	OutboxMessageItem,
-} from "@remit/data-ports";
-import { ForbiddenError } from "@remit/data-ports/errors";
-import type { APIGatewayProxyEvent } from "aws-lambda";
-import type { Context } from "openapi-backend";
-import { getAccountConfigIdFromEvent } from "../auth.js";
-import { getClient } from "../service/data-client.js";
-import type {
-	OperationHandler,
-	OutboxAttachmentOperationIds,
-	OutboxDetailOperationIds,
-	OutboxOperationIds,
-} from "../types.js";
-import {
-	completeOutboxAttachment,
-	mintOutboxAttachment,
-	toOutboxAttachmentResponse,
-} from "./outbox-attachment.js";
-
-const toOutboxMessageResponse = (
-	item: OutboxMessageItem,
-	attachments: OutboxAttachmentItem[] = [],
-): OutboxMessageResponse => ({
-	attachments: attachments.map(toOutboxAttachmentResponse),
-	outboxMessageId: item.outboxMessageId,
-	accountId: item.accountId,
-	fromAddress: item.fromAddress,
-	fromName: item.fromName,
-	toAddresses: item.toAddresses,
-	ccAddresses: item.ccAddresses ?? [],
-	bccAddresses: item.bccAddresses ?? [],
-	subject: item.subject,
-	textBody: item.textBody,
-	htmlBody: item.htmlBody,
-	inReplyTo: item.inReplyTo,
-	references: item.references ?? [],
-	status: item.status,
-	lastError: item.lastError,
-	sentAt: item.sentAt,
-	createdAt: item.createdAt,
-	updatedAt: item.updatedAt,
-});
-
-export const OutboxOperations: Record<
-	OutboxOperationIds,
-	OperationHandler<OutboxOperationIds>
-> = {
-	OutboxOperations_createOutboxMessage: async (
-		_context: Context,
-		...args: unknown[]
-	): Promise<OutboxMessageResponse> => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const input = JSON.parse(event.body ?? "{}") as CreateOutboxMessageInput;
-
-		const client = await getClient();
-
-		const account = await client.account.get(input.accountId);
-		if (account.accountConfigId !== accountConfigId) {
-			throw new ForbiddenError(
-				`Account ${input.accountId} not in account config`,
-			);
-		}
-
-		const fromAddress = account.email;
-
-		if (input.sendImmediately) {
-			const outbox = await client.outboxQueue.createAndSend({
-				accountId: input.accountId,
-				accountConfigId,
-				fromAddress,
-
-				toAddresses: input.toAddresses,
-				ccAddresses: input.ccAddresses,
-				bccAddresses: input.bccAddresses,
-				subject: input.subject,
-				textBody: input.textBody,
-				htmlBody: input.htmlBody,
-				inReplyTo: input.inReplyTo,
-				references: input.references,
-			});
-			return toOutboxMessageResponse(outbox);
-		}
-
-		const outbox = await client.outboxQueue.createDraft({
-			accountId: input.accountId,
-			accountConfigId,
-			fromAddress,
-
-			toAddresses: input.toAddresses,
-			ccAddresses: input.ccAddresses,
-			bccAddresses: input.bccAddresses,
-			subject: input.subject,
-			textBody: input.textBody,
-			htmlBody: input.htmlBody,
-			inReplyTo: input.inReplyTo,
-			references: input.references,
-		});
-		return toOutboxMessageResponse(outbox);
-	},
-
-	OutboxOperations_listOutboxMessages: async (
-		context: Context,
-		...args: unknown[]
-	) => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { continuationToken } = context.request.query as {
-			continuationToken?: string;
-		};
-
-		const client = await getClient();
-
-		const accounts =
-			await client.account.listAllByAccountConfig(accountConfigId);
-		if (accounts.length === 0) {
-			return { items: [], continuationToken: null };
-		}
-
-		const result = await client.outboxMessage.listByAccounts(
-			accounts.map((account) => account.accountId),
-			{ continuationToken },
-		);
-
-		return {
-			items: result.items.map((item) => toOutboxMessageResponse(item)),
-			continuationToken: result.continuationToken,
-		};
-	},
-};
-
-export const OutboxDetailOperations: Record<
-	OutboxDetailOperationIds,
-	OperationHandler<OutboxDetailOperationIds>
-> = {
-	OutboxDetailOperations_getOutboxMessage: async (
-		context: Context,
-		...args: unknown[]
-	): Promise<OutboxMessageResponse> => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { outboxMessageId } = context.request.params as {
-			outboxMessageId: string;
-		};
-
-		const client = await getClient();
-		// Default mode "read": the scoped get refuses a foreign message with
-		// NotFound (404, no existence leak) — no separate check needed.
-		const outbox = await client.outboxMessage.get(
-			accountConfigId,
-			outboxMessageId,
-		);
-		return toOutboxMessageResponse(
-			outbox,
-			await client.outboxAttachment.listFor(accountConfigId, outboxMessageId),
-		);
-	},
-
-	OutboxDetailOperations_updateOutboxMessage: async (
-		context: Context,
-		...args: unknown[]
-	): Promise<OutboxMessageResponse> => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { outboxMessageId } = context.request.params as {
-			outboxMessageId: string;
-		};
-		const input = context.request.requestBody as UpdateOutboxMessageInput;
-
-		const client = await getClient();
-		// updateDraft's own scoped get uses mode "act": a foreign message is
-		// denied with Forbidden (403), not feigned as NotFound.
-		const updated = await client.outboxQueue.updateDraft(
-			accountConfigId,
-			outboxMessageId,
-			{
-				toAddresses: input.toAddresses,
-				ccAddresses: input.ccAddresses,
-				bccAddresses: input.bccAddresses,
-				subject: input.subject,
-				textBody: input.textBody,
-				htmlBody: input.htmlBody,
-				inReplyTo: input.inReplyTo,
-				references: input.references,
-			},
-		);
-
-		// Absent means "leave the files alone" — a body that only carries a subject
-		// must not strip them. Present states exactly what the draft keeps, so an
-		// empty list is a real instruction to remove them all.
-		if (input.attachmentIds !== undefined) {
-			await client.outboxAttachment.retainOnly(
-				accountConfigId,
-				updated.accountId,
-				outboxMessageId,
-				input.attachmentIds,
-			);
-		}
-
-		return toOutboxMessageResponse(
-			updated,
-			await client.outboxAttachment.listFor(accountConfigId, outboxMessageId),
-		);
-	},
-
-	OutboxDetailOperations_deleteOutboxMessage: async (
-		context: Context,
-		...args: unknown[]
-	) => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { outboxMessageId } = context.request.params as {
-			outboxMessageId: string;
-		};
-
-		const client = await getClient();
-		// deleteDraft's own scoped get uses mode "act": a foreign message is
-		// denied with Forbidden (403), not feigned as NotFound.
-		await client.outboxQueue.deleteDraft(accountConfigId, outboxMessageId);
-		return { statusCode: 204 };
-	},
-
-	OutboxDetailOperations_sendOutboxMessage: async (
-		context: Context,
-		...args: unknown[]
-	): Promise<OutboxMessageResponse> => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { outboxMessageId } = context.request.params as {
-			outboxMessageId: string;
-		};
-
-		const client = await getClient();
-		// send's own scoped get uses mode "act": a foreign message is denied
-		// with Forbidden (403), not feigned as NotFound.
-		const sent = await client.outboxQueue.send(
-			accountConfigId,
-			outboxMessageId,
-		);
-		return toOutboxMessageResponse(sent);
-	},
-
-	OutboxDetailOperations_mintOutboxAttachment: mintOutboxAttachment,
-};
-
-export const OutboxAttachmentOperations: Record<
-	OutboxAttachmentOperationIds,
-	OperationHandler<OutboxAttachmentOperationIds>
-> = {
-	OutboxAttachmentOperations_completeOutboxAttachment: completeOutboxAttachment,
-};

package/src/handlers/search.test.ts

@@ -1,161 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import type {
-	SearchParams,
-	SearchResult,
-	SearchService,
-} from "@remit/search-service";
-import { toResponse } from "./search.js";
-
-interface CapturedSearch {
-	calls: SearchParams[];
-}
-
-const buildFakeSearch = (
-	results: SearchResult[],
-): { service: SearchService; captured: CapturedSearch } => {
-	const captured: CapturedSearch = { calls: [] };
-	const service: SearchService = {
-		index: async () => {},
-		prepareVectors: async () => [],
-		upsertVectors: async () => ({ upserted: 0, skipped: 0 }),
-		indexIncremental: async () => ({ upserted: 0, skipped: 0 }),
-		delete: async () => {},
-		search: async (params) => {
-			captured.calls.push(params);
-			return results;
-		},
-	};
-	return { service, captured };
-};
-
-describe("SemanticSearch handler response mapping", () => {
-	it("maps SearchResult into SemanticSearchResult preserving all fields", () => {
-		const item: SearchResult = {
-			messageId: "msg-alice",
-			threadId: "thread-a",
-			score: 0.87,
-			matchedChunkType: "sender",
-			mailboxIds: ["mb-inbox", "mb-archive"],
-			sentDate: 1_700_000_000,
-		};
-		const out = toResponse(item);
-		assert.equal(out.messageId, "msg-alice");
-		assert.equal(out.threadId, "thread-a");
-		assert.equal(out.score, 0.87);
-		assert.equal(out.matchedChunkType, "sender");
-		assert.deepEqual(out.mailboxIds, ["mb-inbox", "mb-archive"]);
-		assert.equal(out.sentDate, 1_700_000_000);
-	});
-
-	it("includes fromName and subject when present in SearchResult", () => {
-		const item: SearchResult = {
-			messageId: "msg-bob",
-			threadId: "thread-b",
-			score: 0.72,
-			matchedChunkType: "body",
-			mailboxIds: ["mb-inbox"],
-			sentDate: 1_700_001_000,
-			fromName: "Bob Smith",
-			subject: "Weekly sync",
-		};
-		const out = toResponse(item);
-		assert.equal(out.fromName, "Bob Smith");
-		assert.equal(out.subject, "Weekly sync");
-		assert.equal(out.sentDate, 1_700_001_000);
-	});
-
-	it("echoes category back when present in SearchResult", () => {
-		const item: SearchResult = {
-			messageId: "msg-news",
-			threadId: "thread-news",
-			score: 0.81,
-			matchedChunkType: "body",
-			mailboxIds: ["mb-inbox"],
-			sentDate: 1_700_003_000,
-			category: "newsletter",
-		};
-		const out = toResponse(item);
-		assert.equal(out.category, "newsletter");
-	});
-
-	it("omits category when absent (pre-enrichment vectors)", () => {
-		const item: SearchResult = {
-			messageId: "msg-legacy",
-			threadId: "thread-legacy",
-			score: 0.4,
-			matchedChunkType: "body",
-			mailboxIds: ["mb-archive"],
-			sentDate: 1_600_000_000,
-		};
-		const out = toResponse(item);
-		assert.equal(out.category, undefined);
-	});
-
-	it("omits fromName when it is null (sender has no display name)", () => {
-		const item: SearchResult = {
-			messageId: "msg-carol",
-			threadId: "thread-c",
-			score: 0.6,
-			matchedChunkType: "sender",
-			mailboxIds: ["mb-inbox"],
-			sentDate: 1_700_002_000,
-			fromName: null,
-			subject: "No-name sender",
-		};
-		const out = toResponse(item);
-		assert.equal(out.fromName, undefined);
-		assert.equal(out.subject, "No-name sender");
-	});
-
-	it("omits fromName and subject when absent (pre-enrichment vectors)", () => {
-		const item: SearchResult = {
-			messageId: "msg-legacy",
-			threadId: "thread-legacy",
-			score: 0.5,
-			matchedChunkType: "body",
-			mailboxIds: ["mb-archive"],
-			sentDate: 1_600_000_000,
-		};
-		const out = toResponse(item);
-		assert.equal(out.fromName, undefined);
-		assert.equal(out.subject, undefined);
-		assert.equal(out.sentDate, 1_600_000_000);
-	});
-});
-
-describe("SemanticSearch handler search invocation", () => {
-	it("forwards filters from the request to the search service", async () => {
-		const { service, captured } = buildFakeSearch([
-			{
-				messageId: "msg-bob",
-				threadId: "thread-b",
-				score: 0.5,
-				matchedChunkType: "body",
-				mailboxIds: ["mb-inbox"],
-				sentDate: 1_700_000_000,
-			},
-		]);
-
-		const results = await service.search({
-			query: "alice",
-			accountConfigId: "acct-1",
-			mailboxId: "mb-inbox",
-			sentDateRange: { from: 100, to: 200 },
-			hasAttachment: true,
-			category: "newsletter",
-			limit: 10,
-		});
-
-		assert.equal(results.length, 1);
-		assert.equal(captured.calls.length, 1);
-		const call = captured.calls[0];
-		assert.equal(call.query, "alice");
-		assert.equal(call.accountConfigId, "acct-1");
-		assert.equal(call.mailboxId, "mb-inbox");
-		assert.deepEqual(call.sentDateRange, { from: 100, to: 200 });
-		assert.equal(call.hasAttachment, true);
-		assert.equal(call.category, "newsletter");
-		assert.equal(call.limit, 10);
-	});
-});

package/src/handlers/search.ts

@@ -1,105 +0,0 @@
-import type {
-	MessageCategory,
-	SemanticSearchResult,
-} from "@remit/api-openapi-types";
-import type { SearchResult } from "@remit/search-service";
-import type { APIGatewayProxyEvent } from "aws-lambda";
-import type { Context } from "openapi-backend";
-import { getAccountConfigIdFromEvent } from "../auth.js";
-import { getClient } from "../service/data-client.js";
-import {
-	isSemanticSearchUnavailable,
-	noteSemanticCapabilityAbsence,
-} from "../service/semantic-capability.js";
-import type { OperationHandler, SemanticSearchOperationIds } from "../types.js";
-
-const DEFAULT_LIMIT = 25;
-
-export const toResponse = (item: SearchResult): SemanticSearchResult => {
-	const result: SemanticSearchResult = {
-		messageId: item.messageId,
-		threadId: item.threadId,
-		score: item.score,
-		matchedChunkType: item.matchedChunkType,
-		mailboxIds: item.mailboxIds,
-		sentDate: item.sentDate,
-	};
-	// fromName is null for messages with no sender name; exclude undefined (absent from old vectors)
-	if (item.fromName !== undefined) {
-		result.fromName = item.fromName ?? undefined;
-	}
-	if (item.subject !== undefined) {
-		result.subject = item.subject;
-	}
-	if (item.category !== undefined) {
-		result.category = item.category;
-	}
-	return result;
-};
-
-export const SemanticSearchOperations: Record<
-	SemanticSearchOperationIds,
-	OperationHandler<SemanticSearchOperationIds>
-> = {
-	SemanticSearchOperations_semanticSearch: async (
-		context: Context,
-		...args: unknown[]
-	) => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const {
-			query,
-			mailboxId,
-			sentDateFrom,
-			sentDateTo,
-			hasAttachment,
-			hasStars,
-			isRead,
-			category,
-			limit,
-		} = context.request.query as {
-			query: string;
-			mailboxId?: string;
-			sentDateFrom?: number;
-			sentDateTo?: number;
-			hasAttachment?: boolean;
-			hasStars?: boolean;
-			isRead?: boolean;
-			category?: MessageCategory;
-			limit?: number;
-		};
-
-		const sentDateRange =
-			sentDateFrom !== undefined || sentDateTo !== undefined
-				? { from: sentDateFrom, to: sentDateTo }
-				: undefined;
-
-		// Capability gate for the self-host compose profiles, whose backend
-		// image cannot run the semantic pipeline — see semantic-capability.ts.
-		if (isSemanticSearchUnavailable()) {
-			return { items: [] };
-		}
-
-		let results: SearchResult[];
-		try {
-			results = await (await getClient()).search.search({
-				query,
-				accountConfigId,
-				mailboxId,
-				sentDateRange,
-				hasAttachment,
-				hasStars,
-				isRead,
-				category,
-				limit: limit ?? DEFAULT_LIMIT,
-			});
-		} catch (error) {
-			if (!noteSemanticCapabilityAbsence(error)) throw error;
-			return { items: [] };
-		}
-
-		return {
-			items: results.map(toResponse),
-		};
-	},
-};