@remit/backend 0.0.143 → 0.0.145

package/src/handlers/label.ts

@@ -1,210 +0,0 @@
-import type {
-	CreateLabelInput as CreateLabelRequestBody,
-	LabelResponse,
-	UpdateLabelInput as UpdateLabelRequestBody,
-} from "@remit/api-openapi-types";
-import type {
-	CreateLabelInput,
-	FilterItem,
-	LabelItem,
-	UpdateLabelInput,
-} from "@remit/data-ports";
-import type { APIGatewayProxyEvent } from "aws-lambda";
-import { getAccountConfigIdFromEvent } from "../auth.js";
-import { getClient } from "../service/data-client.js";
-import type {
-	LabelDetailOperationIds,
-	LabelOperationIds,
-	OperationHandler,
-} from "../types.js";
-import { assertAccountOwnership } from "./account-ownership.js";
-
-/**
- * Minimal label-service surface the CRUD handlers need — declared as a `Pick`
- * so tests can stub it without a live table.
- */
-export interface LabelCrudDeps {
-	label: {
-		create(input: CreateLabelInput): Promise<LabelItem>;
-		get(accountConfigId: string, labelId: string): Promise<LabelItem>;
-		update(
-			accountConfigId: string,
-			labelId: string,
-			input: UpdateLabelInput,
-		): Promise<LabelItem>;
-		delete(accountConfigId: string, labelId: string): Promise<void>;
-		listPageByAccountConfig(
-			accountConfigId: string,
-			options?: { limit?: number; continuationToken?: string },
-		): Promise<{ items: LabelItem[]; continuationToken: string | undefined }>;
-	};
-	filter: {
-		listByAccountConfig(accountConfigId: string): Promise<FilterItem[]>;
-		delete(accountConfigId: string, filterId: string): Promise<void>;
-	};
-	messageLabel: {
-		removeAllByLabelId(accountConfigId: string, labelId: string): Promise<void>;
-	};
-}
-
-/**
- * Every filter in the account whose action applies this label (issue #26). The
- * count backs `LabelResponse.filterCount`; the list backs the cascade delete.
- */
-export const findFiltersForLabel = async (
-	deps: Pick<LabelCrudDeps, "filter">,
-	accountConfigId: string,
-	labelId: string,
-): Promise<FilterItem[]> => {
-	const filters = await deps.filter.listByAccountConfig(accountConfigId);
-	return filters.filter((filter) => filter.actionLabelId === labelId);
-};
-
-/**
- * `filterCount` is computed here, not stored (issue #26) — every other field
- * comes straight off the `LabelItem` row.
- */
-const toLabelResponse = (
-	item: LabelItem,
-	filterCount: number,
-): LabelResponse => ({
-	labelId: item.labelId,
-	accountConfigId: item.accountConfigId,
-	name: item.name,
-	color: item.color,
-	filterCount,
-	createdAt: item.createdAt,
-	updatedAt: item.updatedAt,
-});
-
-/**
- * Delete a label and cascade in both directions (issue #26): every filter
- * whose `actionLabelId` is this label is deleted outright — never left
- * dangling, never blocking the delete — and every `MessageLabel` row for it is
- * removed. The label row itself is deleted last so a failure mid-cascade never
- * leaves the label gone while its filters or applied-to-messages still exist.
- */
-export const deleteLabelWithCascade = async (
-	deps: LabelCrudDeps,
-	accountConfigId: string,
-	labelId: string,
-): Promise<void> => {
-	const filters = await findFiltersForLabel(deps, accountConfigId, labelId);
-	for (const filter of filters) {
-		await deps.filter.delete(accountConfigId, filter.filterId);
-	}
-	await deps.messageLabel.removeAllByLabelId(accountConfigId, labelId);
-	await deps.label.delete(accountConfigId, labelId);
-};
-
-export const LabelOperations: Record<
-	LabelOperationIds,
-	OperationHandler<LabelOperationIds>
-> = {
-	LabelOperations_listLabels: async (context, ...args: unknown[]) => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { accountId } = context.request.params as { accountId: string };
-		const { continuationToken } = context.request.query as {
-			continuationToken?: string;
-		};
-
-		const client = await getClient();
-		const account = await client.account.get(accountId);
-		assertAccountOwnership(account, accountConfigId, "read");
-
-		const page = await client.label.listPageByAccountConfig(accountConfigId, {
-			continuationToken,
-		});
-		const filters = await client.filter.listByAccountConfig(accountConfigId);
-		const filterCountByLabelId = new Map<string, number>();
-		for (const filter of filters) {
-			const labelId = filter.actionLabelId;
-			filterCountByLabelId.set(
-				labelId,
-				(filterCountByLabelId.get(labelId) ?? 0) + 1,
-			);
-		}
-
-		return {
-			items: page.items.map((item) =>
-				toLabelResponse(item, filterCountByLabelId.get(item.labelId) ?? 0),
-			),
-			continuationToken: page.continuationToken,
-		};
-	},
-
-	LabelOperations_createLabel: async (context, ...args: unknown[]) => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { accountId } = context.request.params as { accountId: string };
-		const input = context.request.requestBody as CreateLabelRequestBody;
-
-		const client = await getClient();
-		const account = await client.account.get(accountId);
-		assertAccountOwnership(account, accountConfigId, "act");
-
-		const label = await client.label.create({
-			accountConfigId,
-			name: input.name,
-			color: input.color,
-		});
-		return toLabelResponse(label, 0);
-	},
-};
-
-export const LabelDetailOperations: Record<
-	LabelDetailOperationIds,
-	OperationHandler<LabelDetailOperationIds>
-> = {
-	LabelDetailOperations_getLabel: async (context, ...args: unknown[]) => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { accountId, labelId } = context.request.params as {
-			accountId: string;
-			labelId: string;
-		};
-
-		const client = await getClient();
-		const account = await client.account.get(accountId);
-		assertAccountOwnership(account, accountConfigId, "read");
-
-		const label = await client.label.get(accountConfigId, labelId);
-		const filters = await findFiltersForLabel(client, accountConfigId, labelId);
-		return toLabelResponse(label, filters.length);
-	},
-
-	LabelDetailOperations_updateLabel: async (context, ...args: unknown[]) => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { accountId, labelId } = context.request.params as {
-			accountId: string;
-			labelId: string;
-		};
-		const body = context.request.requestBody as Partial<UpdateLabelRequestBody>;
-
-		const client = await getClient();
-		const account = await client.account.get(accountId);
-		assertAccountOwnership(account, accountConfigId, "act");
-
-		const updated = await client.label.update(accountConfigId, labelId, body);
-		const filters = await findFiltersForLabel(client, accountConfigId, labelId);
-		return toLabelResponse(updated, filters.length);
-	},
-
-	LabelDetailOperations_deleteLabel: async (context, ...args: unknown[]) => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { accountId, labelId } = context.request.params as {
-			accountId: string;
-			labelId: string;
-		};
-
-		const client = await getClient();
-		const account = await client.account.get(accountId);
-		assertAccountOwnership(account, accountConfigId, "act");
-
-		await deleteLabelWithCascade(client, accountConfigId, labelId);
-		return { statusCode: 204 };
-	},
-};

package/src/handlers/mailbox-bindings.ts

@@ -1,111 +0,0 @@
-import type {
-	FilterItem,
-	IAccountSettingRepository,
-	IFilterRepository,
-	MailboxItem,
-} from "@remit/data-ports";
-import { FILTER_NO_ACTION } from "@remit/data-ports";
-import { BadRequestError } from "@remit/data-ports/errors";
-import type { CanonicalMailboxRoleValue } from "@remit/data-ports/folder-role";
-import { loadFolderAppointmentsForAccount } from "./folder-role-appointments.js";
-
-/**
- * What a folder is bound to: the filters that move mail into it, and the
- * canonical roles it has been appointed to.
- */
-export interface MailboxBindings {
-	filterNames: string[];
-	roles: CanonicalMailboxRoleValue[];
-}
-
-/**
- * `filter.actionMailboxId` has no reverse index, so the filters are listed for
- * the account config and matched — they are few and per-config, so this is not
- * a mailbox scan. Role appointments are `account_setting` rows whose *value* is
- * a mailboxId, which a `mailbox_id` column scan cannot find, so the existing
- * per-account appointment map answers for them.
- */
-export const loadMailboxBindings = async (
-	client: {
-		filter: Pick<IFilterRepository, "listByAccountConfig">;
-		accountSetting: Pick<IAccountSettingRepository, "get">;
-	},
-	accountConfigId: string,
-	accountId: string,
-	mailboxId: string,
-): Promise<MailboxBindings> => {
-	const [filters, appointments] = await Promise.all([
-		client.filter.listByAccountConfig(accountConfigId),
-		loadFolderAppointmentsForAccount(
-			client.accountSetting,
-			accountConfigId,
-			accountId,
-		),
-	]);
-
-	const filterNames = filters
-		.filter(
-			(filter: FilterItem) =>
-				filter.actionMailboxId !== FILTER_NO_ACTION &&
-				filter.actionMailboxId === mailboxId,
-		)
-		.map((filter: FilterItem) => filter.name);
-
-	const roles: CanonicalMailboxRoleValue[] = [];
-	for (const [role, appointment] of appointments) {
-		if (appointment.mailboxId === mailboxId) {
-			roles.push(role as CanonicalMailboxRoleValue);
-		}
-	}
-
-	return { filterNames, roles };
-};
-
-const asList = (items: readonly string[]): string =>
-	items.length === 1
-		? items[0]
-		: `${items.slice(0, -1).join(", ")} and ${items[items.length - 1]}`;
-
-/**
- * Refuse a delete while any durable reference is bound to the folder (D16).
- *
- * This is what makes the settled-target rule total: a binding is only created
- * against a settled folder and only removed by the user, so a `mailboxId` that
- * names nothing never exists and no reader of a filter's `actionMailboxId` or a
- * role appointment needs a missing-target branch. It removes code rather than
- * adding a check.
- *
- * The alternatives both cost more than they look. `Filter` has no enabled flag
- * and its `actionMailboxId` sentinel means "no move action", so clearing the
- * target silently turns a move-filter into one that does something else;
- * deleting the user's filters outright is not a decision a folder delete gets
- * to make.
- *
- * The message **names** each binding rather than counting them, because a count
- * is not actionable — and this fires on ordinary configurations, since pointing
- * a filter at a folder is what filters are for.
- */
-export const assertNoBindings = (
-	mailbox: Pick<MailboxItem, "fullPath">,
-	bindings: MailboxBindings,
-): void => {
-	const clauses: string[] = [];
-	if (bindings.filterNames.length > 0) {
-		clauses.push(
-			`the ${bindings.filterNames.length === 1 ? "filter" : "filters"} ${asList(
-				bindings.filterNames.map((name) => `“${name}”`),
-			)}`,
-		);
-	}
-	if (bindings.roles.length > 0) {
-		clauses.push(
-			`the ${asList(bindings.roles)} ${
-				bindings.roles.length === 1 ? "role" : "roles"
-			}`,
-		);
-	}
-	if (clauses.length === 0) return;
-	throw new BadRequestError(
-		`“${mailbox.fullPath}” is used by ${asList(clauses)}.`,
-	);
-};

package/src/handlers/mailbox-rename-refusal.test.ts

@@ -1,247 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import type { MailboxItem } from "@remit/data-ports";
-import { MailboxSyncStatus } from "@remit/domain-enums";
-import { applyMailboxPatch, type MailboxPatchClient } from "./mailbox.js";
-
-const ACCOUNT_ID = "acc-1";
-const CONFIG_ID = "cfg-1";
-
-const mailbox = (over: Partial<MailboxItem> = {}): MailboxItem =>
-	({
-		mailboxId: "mbx-1",
-		accountId: ACCOUNT_ID,
-		fullPath: "Work",
-		hierarchyDelimiter: "/",
-		syncStatus: MailboxSyncStatus.synced,
-		...over,
-	}) as MailboxItem;
-
-const clientOver = (
-	row: MailboxItem,
-	others: MailboxItem[] = [],
-): {
-	client: MailboxPatchClient;
-	renames: { mailboxId: string; newPath: string }[];
-	dismissals: string[];
-	settings: string[];
-} => {
-	const renames: { mailboxId: string; newPath: string }[] = [];
-	const dismissals: string[] = [];
-	const settings: string[] = [];
-	const client: MailboxPatchClient = {
-		mailbox: {
-			get: async () => row,
-			listAllByAccount: async () => [row, ...others],
-		},
-		mailboxQueue: {
-			renameMailbox: async (mailboxId, newPath) => {
-				renames.push({ mailboxId, newPath });
-				return mailbox({ pendingPath: newPath });
-			},
-			dismissMailboxIntent: async (mailboxId) => {
-				dismissals.push(mailboxId);
-				return mailbox();
-			},
-		},
-		accountSetting: {
-			get: async () => null,
-			upsert: async (item) => {
-				settings.push(item.name);
-				return item as never;
-			},
-			delete: async (_configId, name) => {
-				settings.push(name);
-			},
-		},
-	};
-	return { client, renames, dismissals, settings };
-};
-
-const patch = (
-	client: MailboxPatchClient,
-	body: Record<string, unknown>,
-): Promise<MailboxItem> =>
-	applyMailboxPatch(client, CONFIG_ID, "mbx-1", ACCOUNT_ID, body);
-
-const refusedWith = (message: string) => (error: unknown) =>
-	(error as { statusCode?: number }).statusCode === 400 &&
-	(error as Error).message === message;
-
-describe("applyMailboxPatch — renames that can never succeed (D4, D5)", () => {
-	it("refuses to rename the inbox", async () => {
-		const { client, renames } = clientOver(mailbox({ fullPath: "INBOX" }));
-
-		await assert.rejects(
-			patch(client, { fullPath: "Postvak" }),
-			refusedWith("The inbox can't be renamed."),
-		);
-		assert.equal(renames.length, 0);
-	});
-
-	it("refuses a target that canonicalizes to the inbox", async () => {
-		const { client, renames } = clientOver(mailbox());
-
-		await assert.rejects(
-			patch(client, { fullPath: "inbox" }),
-			refusedWith("“INBOX” is reserved for the inbox."),
-		);
-		assert.equal(renames.length, 0);
-	});
-
-	it("refuses an empty target", async () => {
-		const { client, renames } = clientOver(mailbox());
-
-		await assert.rejects(
-			patch(client, { fullPath: "   " }),
-			refusedWith("A folder needs a name."),
-		);
-		assert.equal(renames.length, 0);
-	});
-
-	it("refuses a target another folder already holds", async () => {
-		const { client, renames } = clientOver(mailbox(), [
-			mailbox({ mailboxId: "mbx-2", fullPath: "Projects" }),
-		]);
-
-		await assert.rejects(
-			patch(client, { fullPath: "Projects" }),
-			refusedWith("A folder named “Projects” is already there."),
-		);
-		assert.equal(renames.length, 0);
-	});
-
-	/**
-	 * The sweep reads a folder whose leaf name is a role's conventional name but
-	 * which lacks the server's flag as a duplicate, and deletes its row — under
-	 * D8, with the folder's mail — as soon as another folder holds the flag. A
-	 * rename to one of those settles `synced` and is then reaped.
-	 */
-	for (const [name, leaf] of [
-		["Archive", "Archive"],
-		["Trash", "Trash"],
-		["Drafts", "Drafts"],
-		["Sent", "Sent"],
-		["Junk", "Spam"],
-	] as const) {
-		it(`refuses a rename to the reserved ${name} name`, async () => {
-			const { client, renames } = clientOver(mailbox());
-
-			await assert.rejects(
-				patch(client, { fullPath: `Work/${leaf}` }),
-				refusedWith(
-					`“${leaf}” is reserved for a system folder. Pick another name.`,
-				),
-			);
-			assert.equal(renames.length, 0);
-		});
-	}
-
-	it("refuses a target another rename is already on its way to", async () => {
-		// A path a rename is aiming at is as taken as one a folder sits at (D2).
-		// Two renames onto one target both settle, both write it, and the sweep
-		// then reaps one row — with its mail — and inserts a duplicate.
-		const { client, renames } = clientOver(mailbox(), [
-			mailbox({
-				mailboxId: "mbx-2",
-				fullPath: "Admin",
-				syncStatus: MailboxSyncStatus.pending,
-				pendingPath: "Projects",
-			}),
-		]);
-
-		await assert.rejects(
-			patch(client, { fullPath: "Projects" }),
-			refusedWith("“Admin” is already being renamed to “Projects”."),
-		);
-		assert.equal(renames.length, 0);
-	});
-
-	it("lets a failed rename's stale target go to somebody else", async () => {
-		// `failed` keeps its target so the client can name what the rename was
-		// aiming at and offer a retry (T6), and nothing clears it until the user
-		// retries or dismisses. Honouring that claim would tell everyone else the
-		// path is taken by a rename that is not happening, with nothing to wait
-		// for and no way to find out.
-		const { client, renames } = clientOver(mailbox(), [
-			mailbox({
-				mailboxId: "mbx-2",
-				fullPath: "Admin",
-				syncStatus: MailboxSyncStatus.failed,
-				pendingPath: "Projects",
-			}),
-		]);
-
-		await patch(client, { fullPath: "Projects" });
-
-		assert.deepEqual(renames, [{ mailboxId: "mbx-1", newPath: "Projects" }]);
-	});
-
-	it("lets a retry aim at the target its own failed rename recorded", async () => {
-		const { client, renames } = clientOver(
-			mailbox({
-				syncStatus: MailboxSyncStatus.failed,
-				pendingPath: "Projects",
-			}),
-		);
-
-		await patch(client, { fullPath: "Projects" });
-
-		assert.deepEqual(renames, [{ mailboxId: "mbx-1", newPath: "Projects" }]);
-	});
-
-	it("records the intent for an ordinary target", async () => {
-		const { client, renames } = clientOver(mailbox());
-
-		const renamed = await patch(client, { fullPath: "Projects" });
-
-		assert.deepEqual(renames, [{ mailboxId: "mbx-1", newPath: "Projects" }]);
-		assert.equal(renamed.pendingPath, "Projects");
-	});
-});
-
-describe("applyMailboxPatch — dismissing a failed intent (T10, T11)", () => {
-	it("reads a target equal to the confirmed path as a dismissal, not a rename", async () => {
-		const { client, renames, dismissals } = clientOver(
-			mailbox({
-				syncStatus: MailboxSyncStatus.failed,
-				pendingPath: "Projects",
-			}),
-		);
-
-		const dismissed = await patch(client, { fullPath: "Work" });
-
-		assert.deepEqual(dismissals, ["mbx-1"]);
-		assert.equal(renames.length, 0, "nothing is enqueued for a dismissal");
-		assert.equal(dismissed.syncStatus, MailboxSyncStatus.synced);
-	});
-
-	it("dismisses even where the folder's own name is reserved", async () => {
-		// The refusals gate a rename's target. Keeping the name a folder already
-		// has is not one, and a folder called `Archive` must still be able to
-		// dismiss a rename that failed.
-		const { client, dismissals } = clientOver(
-			mailbox({ fullPath: "Archive", syncStatus: MailboxSyncStatus.failed }),
-		);
-
-		await patch(client, { fullPath: "Archive" });
-
-		assert.deepEqual(dismissals, ["mbx-1"]);
-	});
-});
-
-describe("applyMailboxPatch — an override-only PATCH", () => {
-	it("touches no mutation state", async () => {
-		const { client, renames, dismissals, settings } = clientOver(mailbox());
-
-		await patch(client, { muted: true });
-
-		assert.equal(renames.length, 0);
-		assert.equal(dismissals.length, 0);
-		assert.equal(
-			settings.length > 0,
-			true,
-			"the override row is still written",
-		);
-	});
-});