@remit/backend 0.0.143 → 0.0.145

package/src/handlers/folder-role-labels.ts

@@ -1,63 +0,0 @@
-import type { IAccountSettingRepository } from "@remit/data-ports";
-import {
-	type CanonicalMailboxRoleValue,
-	composeFolderRoleAppointmentLabelName,
-} from "@remit/data-ports/folder-role";
-import { rebaseMailboxPath } from "@remit/data-ports/mailbox-name";
-import { loadFolderAppointmentsForAccount } from "./folder-role-appointments.js";
-
-/**
- * The label row beside each role appointment records the path its folder had at
- * the time (#887), so a folder another client later deletes can still be named
- * back to the user. It is display only, and it lives here rather than beside
- * the appointment writer because that writer is guarded as the only writer of
- * the appointment row itself.
- *
- * A rename keeps every mailboxId, so an appointment survives it — but the path
- * recorded beside it still names where the folder was. Move the labels with the
- * branch, or a later third-party delete names a path the user has not seen
- * since the rename.
- *
- * Driven by the settle, not by the intent: under D2 the row keeps the path the
- * mail server holds until the rename lands, so a label moved when the intent
- * was recorded would name a path that does not exist — permanently, if the
- * rename then fails.
- *
- * The renamed folder is matched by id; its descendants are matched by the path
- * each label already holds.
- */
-export const refreshFolderAppointmentLabels = async (
-	accountSetting: Pick<IAccountSettingRepository, "get" | "upsert">,
-	accountConfigId: string,
-	accountId: string,
-	renamed: { mailboxId: string; oldPath: string; newPath: string },
-	delimiter: string,
-): Promise<void> => {
-	const persisted = await loadFolderAppointmentsForAccount(
-		accountSetting,
-		accountConfigId,
-		accountId,
-	);
-	for (const [role, appointment] of persisted) {
-		const moved =
-			appointment.mailboxId === renamed.mailboxId
-				? renamed.newPath
-				: appointment.lastKnownPath === undefined
-					? undefined
-					: rebaseMailboxPath(
-							appointment.lastKnownPath,
-							renamed.oldPath,
-							renamed.newPath,
-							delimiter,
-						);
-		if (moved === undefined || moved === appointment.lastKnownPath) continue;
-		await accountSetting.upsert({
-			accountConfigId,
-			name: composeFolderRoleAppointmentLabelName(
-				accountId,
-				role as CanonicalMailboxRoleValue,
-			),
-			value: { kind: "String", value: moved },
-		});
-	}
-};

package/src/handlers/folder-role.test.ts

@@ -1,209 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import type { AccountSettingItem, MailboxItem } from "@remit/data-ports";
-import { isPublicApiError } from "@remit/data-ports/errors";
-import { composeFolderRoleAppointmentLabelName } from "@remit/data-ports/folder-role";
-import { CanonicalMailboxRole, MailboxSyncStatus } from "@remit/domain-enums";
-import { refreshFolderAppointmentLabels } from "./folder-role-labels.js";
-import { assertMailboxSettled } from "./mailbox.js";
-
-const mailbox = (over: Partial<MailboxItem>): MailboxItem =>
-	({
-		mailboxId: "mb-1",
-		fullPath: "INBOX/Prullenbak",
-		hierarchyDelimiter: "/",
-		...over,
-	}) as unknown as MailboxItem;
-
-const caught = (run: () => void): unknown => {
-	let thrown: unknown;
-	assert.throws(run, (error: unknown) => {
-		thrown = error;
-		return true;
-	});
-	return thrown;
-};
-
-const publicErrorOf = (error: unknown) => {
-	if (typeof error !== "object" || error === null) return undefined;
-	const { publicApiError } = error as { publicApiError?: unknown };
-	return isPublicApiError(publicApiError) ? publicApiError : undefined;
-};
-
-describe("assertMailboxSettled", () => {
-	it("refuses a folder the mail server has not created yet", () => {
-		const error = caught(() =>
-			assertMailboxSettled(mailbox({ syncStatus: MailboxSyncStatus.pending })),
-		);
-		assert.equal(publicErrorOf(error)?.code, "mailbox_not_settled");
-	});
-
-	it("refuses a folder on its way out", () => {
-		const error = caught(() =>
-			assertMailboxSettled(mailbox({ syncStatus: MailboxSyncStatus.deleting })),
-		);
-		assert.equal(publicErrorOf(error)?.code, "mailbox_not_settled");
-	});
-
-	it("carries the mailbox and its state, so the client words a wait", () => {
-		const error = caught(() =>
-			assertMailboxSettled(
-				mailbox({ mailboxId: "mb-9", syncStatus: MailboxSyncStatus.pending }),
-			),
-		);
-		assert.deepEqual(publicErrorOf(error)?.details, {
-			mailboxId: "mb-9",
-			syncStatus: "pending",
-		});
-	});
-
-	it("refuses a folder whose last change failed", () => {
-		// `failed` means the folder exists at `fullPath` and the last rename or
-		// delete did not land, so it is exactly as unready to be bound to as a
-		// folder mid-mutation — and the user has a retry or a dismissal to make
-		// before anything should point at it.
-		const error = caught(() =>
-			assertMailboxSettled(mailbox({ syncStatus: MailboxSyncStatus.failed })),
-		);
-		assert.equal(publicErrorOf(error)?.code, "mailbox_not_settled");
-	});
-
-	it("answers 422, not 409", () => {
-		// 409 already means "this folder is being changed right now, refresh".
-		// This means "the folder you are pointing at has not settled yet", which
-		// is different copy and a different remedy (D4).
-		const error = caught(() =>
-			assertMailboxSettled(mailbox({ syncStatus: MailboxSyncStatus.pending })),
-		);
-		assert.equal((error as { statusCode?: number }).statusCode, 422);
-	});
-
-	it("words each state differently, because each has its own remedy", () => {
-		const messageFor = (syncStatus: MailboxItem["syncStatus"]) =>
-			(caught(() => assertMailboxSettled(mailbox({ syncStatus }))) as Error)
-				.message;
-
-		assert.match(messageFor(MailboxSyncStatus.pending), /hasn.t confirmed it/);
-		assert.match(messageFor(MailboxSyncStatus.deleting), /being deleted/);
-		assert.match(messageFor(MailboxSyncStatus.failed), /Retry or dismiss/);
-	});
-
-	it("allows a settled folder", () => {
-		assert.doesNotThrow(() =>
-			assertMailboxSettled(mailbox({ syncStatus: MailboxSyncStatus.synced })),
-		);
-	});
-});
-
-describe("refreshFolderAppointmentLabels — the label follows a settled rename", () => {
-	const labelName = composeFolderRoleAppointmentLabelName(
-		"acc-1",
-		CanonicalMailboxRole.Trash,
-	);
-	const sentLabelName = composeFolderRoleAppointmentLabelName(
-		"acc-1",
-		CanonicalMailboxRole.Sent,
-	);
-	const appointmentName = (role: string) =>
-		`FolderRoleAppointment#acc-1#${role}`;
-
-	const settingsFor = (
-		rows: Record<string, string>,
-	): {
-		store: Record<string, string>;
-		accountSetting: Parameters<typeof refreshFolderAppointmentLabels>[0];
-	} => {
-		const store: Record<string, string> = { ...rows };
-		const accountSetting = {
-			get: async (_configId: string, name: string) =>
-				store[name] === undefined
-					? undefined
-					: ({
-							name,
-							value: { kind: "String", value: store[name] },
-						} as AccountSettingItem),
-			upsert: async (item: AccountSettingItem) => {
-				if (item.value.kind === "String") store[item.name] = item.value.value;
-				return item;
-			},
-		} as unknown as Parameters<typeof refreshFolderAppointmentLabels>[0];
-		return { store, accountSetting };
-	};
-
-	const settle = (
-		accountSetting: Parameters<typeof refreshFolderAppointmentLabels>[0],
-		renamed: { mailboxId: string; oldPath: string; newPath: string },
-	) =>
-		refreshFolderAppointmentLabels(
-			accountSetting,
-			"cfg-1",
-			"acc-1",
-			renamed,
-			"/",
-		);
-
-	it("rewrites the recorded path for the folder that was renamed", async () => {
-		const { store, accountSetting } = settingsFor({
-			[appointmentName(CanonicalMailboxRole.Trash)]: "mb-1",
-			[labelName]: "INBOX/Prullenbak",
-		});
-
-		await settle(accountSetting, {
-			mailboxId: "mb-1",
-			oldPath: "INBOX/Prullenbak",
-			newPath: "INBOX/Verwijderd",
-		});
-
-		assert.equal(store[labelName], "INBOX/Verwijderd");
-	});
-
-	// IMAP RENAME moves the subtree in one command, so every label under the
-	// branch moves with it.
-	it("carries every appointed folder under the renamed branch with it", async () => {
-		const { store, accountSetting } = settingsFor({
-			[appointmentName(CanonicalMailboxRole.Trash)]: "mb-trash",
-			[labelName]: "INBOX/Prullenbak",
-			[appointmentName(CanonicalMailboxRole.Sent)]: "mb-sent",
-			[sentLabelName]: "INBOX/Verzonden",
-		});
-
-		await settle(accountSetting, {
-			mailboxId: "mb-1",
-			oldPath: "INBOX",
-			newPath: "Mail",
-		});
-
-		assert.equal(store[labelName], "Mail/Prullenbak");
-		assert.equal(store[sentLabelName], "Mail/Verzonden");
-	});
-
-	it("leaves a folder outside the renamed branch alone", async () => {
-		const { store, accountSetting } = settingsFor({
-			[appointmentName(CanonicalMailboxRole.Trash)]: "mb-trash",
-			[labelName]: "Archief/Prullenbak",
-		});
-
-		await settle(accountSetting, {
-			mailboxId: "mb-1",
-			oldPath: "INBOX",
-			newPath: "Mail",
-		});
-
-		assert.equal(store[labelName], "Archief/Prullenbak");
-	});
-
-	it("never rebases a sibling that merely shares the prefix", async () => {
-		const { store, accountSetting } = settingsFor({
-			[appointmentName(CanonicalMailboxRole.Trash)]: "mb-trash",
-			[labelName]: "INBOXES/Prullenbak",
-		});
-
-		await settle(accountSetting, {
-			mailboxId: "mb-1",
-			oldPath: "INBOX",
-			newPath: "Mail",
-		});
-
-		assert.equal(store[labelName], "INBOXES/Prullenbak");
-	});
-});

package/src/handlers/folder-role.ts

@@ -1,80 +0,0 @@
-import type {
-	AppointFolderRoleInput,
-	CanonicalMailboxRole,
-} from "@remit/api-openapi-types";
-import type { APIGatewayProxyEvent } from "aws-lambda";
-import { getAccountConfigIdFromEvent } from "../auth.js";
-import { getClient } from "../service/data-client.js";
-import type { FolderRoleOperationIds, OperationHandler } from "../types.js";
-import { toAccountResponse } from "./account-guards.js";
-import { loadAccountOverrides } from "./account-overrides.js";
-import { assertAccountOwnership } from "./account-ownership.js";
-import { loadSignatureForAccount } from "./account-signature.js";
-import {
-	resolveAccountFolderAppointments,
-	writeFolderRoleAppointment,
-} from "./folder-role-appointments.js";
-import { assertMailboxInAccount, assertMailboxSettled } from "./mailbox.js";
-
-/**
- * RFC 032 exclusive-folder-appointment (#976): the single write operation for
- * the per-account role map. `appoint(role, mailboxId)` sets `map[role]` —
- * there is no second place a duplicate appointment could live, so writing a
- * role replaces whichever mailbox previously held it. `mailboxId: null` clears
- * the role back to unfilled.
- */
-export const FolderRoleOperations: Record<
-	FolderRoleOperationIds,
-	OperationHandler<FolderRoleOperationIds>
-> = {
-	FolderRoleOperations_appointFolderRole: async (
-		context,
-		...args: unknown[]
-	) => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const { accountId, role } = context.request.params as {
-			accountId: string;
-			role: CanonicalMailboxRole;
-		};
-		const body = context.request.requestBody as AppointFolderRoleInput;
-
-		const { account, accountSetting, mailbox } = await getClient();
-		const existing = await account.get(accountId);
-		assertAccountOwnership(existing, accountConfigId, "act");
-
-		let lastKnownPath: string | undefined;
-		if (body.mailboxId) {
-			const target = await mailbox.get(accountId, body.mailboxId);
-			assertMailboxInAccount(target, accountId, "act");
-			assertMailboxSettled(target);
-			lastKnownPath = target.fullPath;
-		}
-
-		await writeFolderRoleAppointment(
-			accountSetting,
-			accountConfigId,
-			accountId,
-			role,
-			body.mailboxId ?? null,
-			lastKnownPath,
-		);
-
-		const [signature, overrides, folderAppointments] = await Promise.all([
-			loadSignatureForAccount(accountSetting, accountConfigId, accountId),
-			loadAccountOverrides(accountSetting, accountConfigId, accountId),
-			resolveAccountFolderAppointments(
-				{ mailbox, accountSetting },
-				accountConfigId,
-				accountId,
-			),
-		]);
-
-		return toAccountResponse(
-			existing,
-			signature,
-			overrides,
-			folderAppointments,
-		);
-	},
-};

package/src/handlers/index.ts

@@ -1,83 +0,0 @@
-import type { OperationHandler, OperationIds } from "../types.js";
-import { AccountDetailOperations, AccountOperations } from "./account.js";
-import { MicrosoftOAuthOperations } from "./account-oauth.js";
-import { AddressDetailOperations, AddressOperations } from "./address.js";
-import { CalendarDetailOperations, CalendarOperations } from "./calendar.js";
-import {
-	CalendarEventDetailOperations,
-	CalendarEventOperations,
-	CalendarFreeBusyOperations,
-} from "./calendar-event.js";
-import {
-	CalendarFeedDetailOperations,
-	CalendarFeedOperations,
-} from "./calendar-feed.js";
-import {
-	CalendarSuggestionActionOperations,
-	CalendarSuggestionOperations,
-	MessageCalendarSuggestionOperations,
-} from "./calendar-suggestion.js";
-import { ConfigOperations } from "./config.js";
-import { FilterDetailOperations, FilterOperations } from "./filter.js";
-import { FolderRoleOperations } from "./folder-role.js";
-import { LabelDetailOperations, LabelOperations } from "./label.js";
-import {
-	MailboxDetailOperations,
-	MailboxOperations,
-	TrashOperations,
-} from "./mailbox.js";
-import { MeOperations } from "./me.js";
-import { MessageBulkOperations, MessageOperations } from "./message.js";
-import { OrganizeJobDetailOperations, OrganizeOperations } from "./organize.js";
-import {
-	OutboxAttachmentOperations,
-	OutboxDetailOperations,
-	OutboxOperations,
-} from "./outbox.js";
-import { SemanticSearchOperations } from "./search.js";
-import { SyncOperations } from "./sync.js";
-import { SystemOperations } from "./system-update.js";
-import { ThreadDetailOperations, ThreadOperations } from "./thread.js";
-import { UnifiedThreadOperations } from "./unified-threads.js";
-
-// biome-ignore lint/suspicious/noExplicitAny: Types are narrowed downstream
-export const handlers: Record<OperationIds, OperationHandler<any>> = {
-	...MeOperations,
-	...ConfigOperations,
-	...SystemOperations,
-	...AccountOperations,
-	...AccountDetailOperations,
-	...MicrosoftOAuthOperations,
-	...MailboxOperations,
-	...MailboxDetailOperations,
-	...FolderRoleOperations,
-	...FilterOperations,
-	...FilterDetailOperations,
-	...LabelOperations,
-	...LabelDetailOperations,
-	...OrganizeOperations,
-	...OrganizeJobDetailOperations,
-	...CalendarOperations,
-	...CalendarDetailOperations,
-	...CalendarFeedDetailOperations,
-	...CalendarFeedOperations,
-	...CalendarEventOperations,
-	...CalendarEventDetailOperations,
-	...CalendarFreeBusyOperations,
-	...TrashOperations,
-	...SyncOperations,
-	...ThreadDetailOperations,
-	...UnifiedThreadOperations,
-	...ThreadOperations,
-	...MessageOperations,
-	...MessageBulkOperations,
-	...OutboxOperations,
-	...OutboxDetailOperations,
-	...OutboxAttachmentOperations,
-	...AddressOperations,
-	...AddressDetailOperations,
-	...SemanticSearchOperations,
-	...CalendarSuggestionOperations,
-	...MessageCalendarSuggestionOperations,
-	...CalendarSuggestionActionOperations,
-};

package/src/handlers/label.test.ts

@@ -1,112 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, test } from "node:test";
-import type { FilterItem, LabelItem } from "@remit/data-ports";
-import {
-	deleteLabelWithCascade,
-	findFiltersForLabel,
-	type LabelCrudDeps,
-} from "./label.js";
-
-const filter = (filterId: string, actionLabelId: string): FilterItem =>
-	({ filterId, actionLabelId }) as unknown as FilterItem;
-
-const label = (labelId: string): LabelItem =>
-	({
-		labelId,
-		accountConfigId: "acc-1",
-		name: "x",
-		color: "Default",
-	}) as LabelItem;
-
-const buildDeps = (filters: FilterItem[]) => {
-	const deletedFilterIds: string[] = [];
-	const removedLabelIds: string[] = [];
-	const deletedLabelIds: string[] = [];
-
-	const deps: LabelCrudDeps = {
-		label: {
-			create: async () => label("unused"),
-			get: async (_accountConfigId: string, labelId: string) => label(labelId),
-			update: async (_accountConfigId: string, labelId: string) =>
-				label(labelId),
-			delete: async (_accountConfigId: string, labelId: string) => {
-				deletedLabelIds.push(labelId);
-			},
-			listPageByAccountConfig: async () => ({
-				items: [],
-				continuationToken: undefined,
-			}),
-		},
-		filter: {
-			listByAccountConfig: async () => filters,
-			delete: async (_accountConfigId: string, filterId: string) => {
-				deletedFilterIds.push(filterId);
-			},
-		},
-		messageLabel: {
-			removeAllByLabelId: async (_accountConfigId: string, labelId: string) => {
-				removedLabelIds.push(labelId);
-			},
-		},
-	};
-
-	return { deps, deletedFilterIds, removedLabelIds, deletedLabelIds };
-};
-
-describe("findFiltersForLabel", () => {
-	test("returns only the filters whose actionLabelId matches", async () => {
-		const filters = [
-			filter("f1", "label-1"),
-			filter("f2", "label-2"),
-			filter("f3", "label-1"),
-		];
-		const { deps } = buildDeps(filters);
-
-		const found = await findFiltersForLabel(deps, "acc-1", "label-1");
-		assert.deepEqual(found.map((f) => f.filterId).sort(), ["f1", "f3"]);
-	});
-
-	test("returns an empty list when no filter uses the label", async () => {
-		const { deps } = buildDeps([filter("f1", "label-2")]);
-		const found = await findFiltersForLabel(deps, "acc-1", "label-1");
-		assert.deepEqual(found, []);
-	});
-});
-
-describe("deleteLabelWithCascade", () => {
-	test("deletes every filter referencing the label, clears applied messages, then deletes the label", async () => {
-		const filters = [
-			filter("f1", "label-1"),
-			filter("f2", "label-2"),
-			filter("f3", "label-1"),
-		];
-		const { deps, deletedFilterIds, removedLabelIds, deletedLabelIds } =
-			buildDeps(filters);
-
-		await deleteLabelWithCascade(deps, "acc-1", "label-1");
-
-		assert.deepEqual(deletedFilterIds.sort(), ["f1", "f3"]);
-		assert.deepEqual(removedLabelIds, ["label-1"]);
-		assert.deepEqual(deletedLabelIds, ["label-1"]);
-	});
-
-	test("never touches a filter that references a different label", async () => {
-		const filters = [filter("f1", "label-2")];
-		const { deps, deletedFilterIds } = buildDeps(filters);
-
-		await deleteLabelWithCascade(deps, "acc-1", "label-1");
-
-		assert.deepEqual(deletedFilterIds, []);
-	});
-
-	test("is a no-op on the filter/messageLabel side when nothing references the label", async () => {
-		const { deps, deletedFilterIds, removedLabelIds, deletedLabelIds } =
-			buildDeps([]);
-
-		await deleteLabelWithCascade(deps, "acc-1", "label-1");
-
-		assert.deepEqual(deletedFilterIds, []);
-		assert.deepEqual(removedLabelIds, ["label-1"]);
-		assert.deepEqual(deletedLabelIds, ["label-1"]);
-	});
-});