@remit/backend 0.0.143 → 0.0.145

package/src/handlers/calendar-feed-validators.test.ts

@@ -1,228 +0,0 @@
-/**
- * Issue #1067: which timestamp a feed's validators are taken from.
- *
- * Driven against a store rather than through the API, because the decision only
- * shows when the collection and the events in it carry times a test running
- * inside one second cannot produce: here the calendar is stamped an hour after
- * its newest surviving event, which is the shape a delete leaves behind.
- */
-
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import {
-	hashCalendarFeedToken,
-	mintCalendarFeedToken,
-	putCalendarObject,
-} from "@remit/calendar-service";
-import { MemoryCalendarStore } from "@remit/calendar-service/memory-store";
-import type { CalendarDeps } from "./calendar.js";
-import { serveCalendarFeed } from "./calendar-feed.js";
-
-const ACCOUNT_CONFIG_ID = "feed-validators-account";
-const EVENT_WRITTEN_AT = Date.UTC(2026, 8, 7, 9, 0, 0);
-const CALENDAR_TOUCHED_AT = Date.UTC(2026, 8, 7, 10, 0, 0);
-
-const ICAL = [
-	"BEGIN:VCALENDAR",
-	"VERSION:2.0",
-	"PRODID:-//test//test//EN",
-	"BEGIN:VEVENT",
-	"UID:kept@test",
-	"DTSTAMP:20260907T090000Z",
-	"DTSTART:20260907T090000Z",
-	"DTEND:20260907T100000Z",
-	"SUMMARY:Kept",
-	"END:VEVENT",
-	"END:VCALENDAR",
-].join("\r\n");
-
-const depsOf = (store: MemoryCalendarStore): Promise<CalendarDeps> =>
-	store.transaction(async (repos) => ({
-		...repos,
-		calendarUnitOfWork: store,
-	}));
-
-const tokenFor = async (
-	store: MemoryCalendarStore,
-	calendarId: string,
-): Promise<string> => {
-	const minted = mintCalendarFeedToken();
-	await store.transaction(async (repos) =>
-		repos.calendarFeedToken.put({
-			accountConfigId: ACCOUNT_CONFIG_ID,
-			calendarId,
-			tokenHash: minted.tokenHash,
-		}),
-	);
-	return minted.token;
-};
-
-interface Fixture {
-	deps: CalendarDeps;
-	token: string;
-	readonly listedCollections: number;
-}
-
-const fixture = async (): Promise<Fixture> => {
-	const store = new MemoryCalendarStore();
-	const deps = await depsOf(store);
-
-	const collection = await store.transaction(async (repos) =>
-		repos.calendarCollection.create({
-			accountConfigId: ACCOUNT_CONFIG_ID,
-			urlSegment: "work",
-			displayName: "Work",
-		}),
-	);
-
-	const written = await putCalendarObject(store, {
-		accountConfigId: ACCOUNT_CONFIG_ID,
-		calendarId: collection.calendarId,
-		resourceName: "kept.ics",
-		icalData: ICAL,
-	});
-	assert.ok(written.ok, "the fixture's own event has to be storable");
-
-	// The shape a delete leaves: the calendar was stamped by the delete, and every
-	// event still in it is older than that.
-	store.objects.set(written.value.calendarObjectId, {
-		...written.value,
-		updatedAt: EVENT_WRITTEN_AT,
-	});
-	const bumped = store.collections.get(collection.calendarId);
-	assert.ok(bumped, "the write should have stamped the collection");
-	store.collections.set(collection.calendarId, {
-		...bumped,
-		updatedAt: CALENDAR_TOUCHED_AT,
-	});
-
-	const token = await tokenFor(store, collection.calendarId);
-
-	let listedCollections = 0;
-	const counted: CalendarDeps = {
-		...deps,
-		calendarCollection: {
-			...deps.calendarCollection,
-			listByAccountConfig: async (accountConfigId: string) => {
-				listedCollections += 1;
-				return deps.calendarCollection.listByAccountConfig(accountConfigId);
-			},
-		},
-	};
-
-	return {
-		deps: counted,
-		token,
-		get listedCollections() {
-			return listedCollections;
-		},
-	};
-};
-
-const NO_CONDITIONS = { ifNoneMatch: undefined, ifModifiedSince: undefined };
-
-describe("the validators a feed serves", () => {
-	it("dates the calendar by its own last change, not by its newest event", async () => {
-		const { deps, token } = await fixture();
-
-		const served = await serveCalendarFeed(deps, token, NO_CONDITIONS);
-
-		assert.equal(served.statusCode, 200);
-		assert.match(served.body, /SUMMARY:Kept/);
-		assert.equal(
-			served.headers["Last-Modified"],
-			new Date(CALENDAR_TOUCHED_AT).toUTCString(),
-			"a delete takes the newest event, so every survivor is older than the change",
-		);
-	});
-
-	it("is unchanged for the date it served and changed for the one before it", async () => {
-		const { deps, token } = await fixture();
-		const served = await serveCalendarFeed(deps, token, NO_CONDITIONS);
-		const lastModified = served.headers["Last-Modified"];
-
-		const unchanged = await serveCalendarFeed(deps, token, {
-			ifNoneMatch: undefined,
-			ifModifiedSince: lastModified,
-		});
-		const stale = await serveCalendarFeed(deps, token, {
-			ifNoneMatch: undefined,
-			ifModifiedSince: new Date(CALENDAR_TOUCHED_AT - 1000).toUTCString(),
-		});
-
-		assert.equal(unchanged.statusCode, 304);
-		assert.equal(unchanged.body, "");
-		assert.equal(unchanged.headers["Last-Modified"], lastModified);
-		assert.equal(unchanged.headers.ETag, served.headers.ETag);
-		assert.equal(stale.statusCode, 200);
-	});
-
-	it("lets a tag that arrives settle the answer on its own", async () => {
-		// RFC 9110 13.2.2: the date is not consulted when a tag is present, so a
-		// tag nobody served re-sends the calendar however current the date is.
-		const { deps, token } = await fixture();
-		const served = await serveCalendarFeed(deps, token, NO_CONDITIONS);
-
-		const overridden = await serveCalendarFeed(deps, token, {
-			ifNoneMatch: '"not-the-tag"',
-			ifModifiedSince: served.headers["Last-Modified"],
-		});
-
-		assert.equal(overridden.statusCode, 200);
-		assert.match(overridden.body, /SUMMARY:Kept/);
-	});
-
-	it("reads the one collection it needs rather than every collection there is", async () => {
-		const found = await fixture();
-
-		await serveCalendarFeed(found.deps, found.token, NO_CONDITIONS);
-
-		assert.equal(
-			found.listedCollections,
-			0,
-			"a feed poll is the hot path and the token already names its collection",
-		);
-	});
-
-	it("is absent when the token outlives the calendar it named", async () => {
-		const store = new MemoryCalendarStore();
-		const deps = await depsOf(store);
-		const token = await tokenFor(store, "a-calendar-that-is-gone");
-
-		const served = await serveCalendarFeed(deps, token, NO_CONDITIONS);
-
-		assert.equal(served.statusCode, 404);
-		assert.equal(
-			served.body.includes("BEGIN:VCALENDAR"),
-			false,
-			"a blank calendar would be worse than saying nothing",
-		);
-	});
-
-	it("is absent for an unknown, a malformed and an oversize token alike", async () => {
-		const store = new MemoryCalendarStore();
-		const deps = await depsOf(store);
-
-		const unknown = await serveCalendarFeed(
-			deps,
-			mintCalendarFeedToken().token,
-			NO_CONDITIONS,
-		);
-		const malformed = await serveCalendarFeed(deps, "nope", NO_CONDITIONS);
-		const oversize = await serveCalendarFeed(
-			deps,
-			"z".repeat(600),
-			NO_CONDITIONS,
-		);
-
-		for (const served of [unknown, malformed, oversize]) {
-			assert.equal(served.statusCode, 404);
-			assert.equal(served.body, unknown.body);
-		}
-		assert.equal(
-			hashCalendarFeedToken("nope").length,
-			64,
-			"the digest is what the store is asked about, never the token",
-		);
-	});
-});

package/src/handlers/calendar-feed.test.ts

@@ -1,439 +0,0 @@
-/**
- * Issue #1067: subscribing to a calendar by its secret .ics address.
- *
- * Driven through the real OpenAPI document, so what is asserted is the routing,
- * the status code, the headers and the bytes a subscribed Apple Calendar or
- * Thunderbird receives — including that the feed answers with no session while
- * the management sub-resource refuses without one. The store is the SQLite
- * composition a self-host deployment boots, over the committed migrations.
- */
-
-import assert from "node:assert/strict";
-import { after, before, describe, it } from "node:test";
-import type { APIGatewayProxyEvent, APIGatewayProxyResult } from "aws-lambda";
-import {
-	_resetForTest,
-	type RemitClient,
-	setClient,
-} from "../service/data-client.js";
-import { createCalendarSqliteClient } from "./calendar-sqlite-fixture.js";
-
-let handler: (
-	event: APIGatewayProxyEvent,
-	context: unknown,
-) => Promise<APIGatewayProxyResult>;
-let client: RemitClient;
-let cleanup: () => void;
-let mintedAccounts = 0;
-
-interface Requested {
-	method: string;
-	path: string;
-	sub?: string;
-	body?: Record<string, unknown>;
-	headers?: Record<string, string>;
-	query?: Record<string, string>;
-}
-
-const request = async ({
-	method,
-	path,
-	sub,
-	body,
-	headers,
-	query,
-}: Requested): Promise<APIGatewayProxyResult> => {
-	const event = {
-		httpMethod: method,
-		path,
-		headers: headers ?? {},
-		queryStringParameters: query ?? null,
-		body: body === undefined ? null : JSON.stringify(body),
-		requestContext: sub ? { authorizer: { claims: { sub } } } : {},
-	} as unknown as APIGatewayProxyEvent;
-
-	return handler(event, { awsRequestId: `req-${path}`, functionName: "test" });
-};
-
-const json = (response: APIGatewayProxyResult): Record<string, unknown> =>
-	JSON.parse(response.body) as Record<string, unknown>;
-
-const headerOf = (
-	response: APIGatewayProxyResult,
-	name: string,
-): string | undefined => {
-	for (const [key, value] of Object.entries(response.headers ?? {})) {
-		if (key.toLowerCase() === name) return String(value);
-	}
-	return undefined;
-};
-
-/** One caller, their calendar, and an event in it. */
-class Subscriber {
-	readonly sub: string;
-
-	constructor() {
-		mintedAccounts += 1;
-		this.sub = `calendar-feed-sub-${mintedAccounts}`;
-	}
-
-	async calendar(displayName = "Work"): Promise<string> {
-		const created = await request({
-			method: "POST",
-			path: "/calendars",
-			sub: this.sub,
-			body: { urlSegment: `work-${mintedAccounts}`, displayName },
-		});
-		assert.equal(created.statusCode, 200, created.body);
-		return json(created).calendarId as string;
-	}
-
-	async event(calendarId: string, summary: string, recurrenceRule = "") {
-		const created = await request({
-			method: "POST",
-			path: "/calendar-events",
-			sub: this.sub,
-			body: {
-				calendarId,
-				summary,
-				start: "2026-09-07T09:00:00+00:00",
-				end: "2026-09-07T10:00:00+00:00",
-				recurrenceRule,
-			},
-		});
-		assert.equal(created.statusCode, 200, created.body);
-		return json(created);
-	}
-
-	async deleteEvent(calendarId: string, calendarObjectId: string) {
-		const removed = await request({
-			method: "DELETE",
-			path: `/calendar-events/${calendarObjectId}`,
-			sub: this.sub,
-			query: { calendarId },
-		});
-		assert.equal(removed.statusCode, 204, removed.body);
-	}
-
-	async mintFeed(calendarId: string): Promise<string> {
-		const minted = await request({
-			method: "PUT",
-			path: `/calendars/${calendarId}/feed`,
-			sub: this.sub,
-		});
-		assert.equal(minted.statusCode, 200, minted.body);
-		return json(minted).feedToken as string;
-	}
-}
-
-const fetchFeed = (
-	feedToken: string,
-	headers?: Record<string, string>,
-): Promise<APIGatewayProxyResult> =>
-	request({
-		method: "GET",
-		path: `/feeds/calendar/${feedToken}.ics`,
-		headers,
-	});
-
-before(async () => {
-	_resetForTest();
-	// The self-host gate, so the feed's exemption from it is exercised rather
-	// than assumed. Set before the module loads: it reads the flag per request,
-	// but the boot-time bypass assertion reads NODE_ENV at import.
-	process.env.DATA_BACKEND = "sqlite";
-	({ client, cleanup } = await createCalendarSqliteClient());
-	setClient(client);
-	({ handler } = (await import("../index.js")) as unknown as {
-		handler: typeof handler;
-	});
-});
-
-after(() => {
-	_resetForTest();
-	cleanup();
-});
-
-describe("the feed a subscriber polls", () => {
-	it("serves the calendar as iCalendar text with no session at all", async () => {
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar("Team");
-		await owner.event(calendarId, "Stand-up");
-		const feedToken = await owner.mintFeed(calendarId);
-
-		const feed = await fetchFeed(feedToken);
-
-		assert.equal(feed.statusCode, 200, feed.body);
-		assert.equal(
-			headerOf(feed, "content-type"),
-			"text/calendar; charset=utf-8",
-		);
-		assert.match(feed.body, /^BEGIN:VCALENDAR/);
-		assert.match(feed.body, /END:VCALENDAR\r\n$/);
-		assert.match(feed.body, /X-WR-CALNAME:Team/);
-		assert.match(feed.body, /SUMMARY:Stand-up/);
-		assert.ok(headerOf(feed, "etag"), "a poller needs a tag to send back");
-		assert.ok(headerOf(feed, "last-modified"));
-	});
-
-	it("carries a recurring event as its master and rule, not as occurrences", async () => {
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-		await owner.event(calendarId, "Weekly", "FREQ=WEEKLY;COUNT=5");
-		const feedToken = await owner.mintFeed(calendarId);
-
-		const feed = await fetchFeed(feedToken);
-
-		assert.equal(feed.body.match(/BEGIN:VEVENT/g)?.length, 1);
-		assert.match(feed.body, /RRULE:FREQ=WEEKLY;COUNT=5/);
-		assert.equal(
-			feed.body.includes("RECURRENCE-ID"),
-			false,
-			"expanding the series would end it at whatever horizon this server chose",
-		);
-	});
-
-	it("answers 304 to the tag it just served, and re-serves a changed calendar", async () => {
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-		await owner.event(calendarId, "Stand-up");
-		const feedToken = await owner.mintFeed(calendarId);
-		const first = await fetchFeed(feedToken);
-		const etag = headerOf(first, "etag") as string;
-
-		const unchanged = await fetchFeed(feedToken, { "If-None-Match": etag });
-
-		assert.equal(unchanged.statusCode, 304);
-		assert.equal(unchanged.body, "");
-		assert.equal(headerOf(unchanged, "etag"), etag);
-		assert.equal(
-			headerOf(unchanged, "last-modified"),
-			headerOf(first, "last-modified"),
-			"a 304 carries the validators a 200 would have carried",
-		);
-
-		await owner.event(calendarId, "Retro");
-		const changed = await fetchFeed(feedToken, { "If-None-Match": etag });
-
-		assert.equal(changed.statusCode, 200);
-		assert.match(changed.body, /SUMMARY:Retro/);
-		assert.match(changed.body, /SUMMARY:Stand-up/);
-		assert.equal(changed.body.match(/BEGIN:VEVENT/g)?.length, 2);
-		assert.notEqual(headerOf(changed, "etag"), etag);
-	});
-
-	it("does not serve the feed at an address the token only starts", async () => {
-		// The route is built by substituting the token into the literal path, which
-		// leaves the dot of ".ics" matching any character, so /feeds/calendar/
-		// <token>Xics reaches the feed operation with the token intact. Asserted at
-		// both layers that refuse it: the public-route gate does not recognise the
-		// address, and the handler re-derives the token from the raw path rather
-		// than trusting what the router captured — so a caller who does hold a
-		// session gets the same 404 rather than somebody's calendar.
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-		await owner.event(calendarId, "Stand-up");
-		const feedToken = await owner.mintFeed(calendarId);
-		const nearlyPath = `/feeds/calendar/${feedToken}Xics`;
-
-		const served = await fetchFeed(feedToken);
-		const unauthenticated = await request({ method: "GET", path: nearlyPath });
-		const authenticated = await request({
-			method: "GET",
-			path: nearlyPath,
-			sub: owner.sub,
-		});
-
-		assert.equal(served.statusCode, 200, served.body);
-		assert.equal(unauthenticated.statusCode, 401);
-		assert.equal(authenticated.statusCode, 404);
-		for (const response of [unauthenticated, authenticated]) {
-			assert.equal(
-				response.body.includes("BEGIN:VCALENDAR"),
-				false,
-				"an address that is not the one handed out must not serve the calendar",
-			);
-		}
-	});
-
-	it("answers an oversize token the same 404 as an unknown one", async () => {
-		// Not a 400: a length the spec enforces makes an oversize address
-		// distinguishable from a wrong one, and error-logs the path it refused.
-		const unknown = await fetchFeed("z".repeat(43));
-		const oversize = await fetchFeed("z".repeat(600));
-
-		assert.equal(oversize.statusCode, 404);
-		assert.equal(oversize.body, unknown.body);
-		assert.equal(
-			headerOf(oversize, "content-type"),
-			headerOf(unknown, "content-type"),
-		);
-	});
-
-	it("keeps Last-Modified moving forward when an event is deleted", async () => {
-		// The newest surviving event is not when the calendar last changed: deleting
-		// the newest one leaves every survivor older than the delete, and a
-		// validator that moved backwards would tell a subscriber its stale copy is
-		// still current.
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-		await owner.event(calendarId, "Stand-up");
-		const retro = await owner.event(calendarId, "Retro");
-		const feedToken = await owner.mintFeed(calendarId);
-		const full = await fetchFeed(feedToken);
-		const before = Date.parse(headerOf(full, "last-modified") as string);
-
-		await owner.deleteEvent(calendarId, retro.calendarObjectId as string);
-		const shrunk = await fetchFeed(feedToken);
-
-		assert.equal(shrunk.statusCode, 200, shrunk.body);
-		assert.equal(shrunk.body.includes("SUMMARY:Retro"), false);
-		assert.ok(
-			Date.parse(headerOf(shrunk, "last-modified") as string) >= before,
-			"the calendar changed, so its modification time cannot have gone back",
-		);
-	});
-
-	it("answers 304 to the date it just served, and lets the tag override it", async () => {
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-		await owner.event(calendarId, "Stand-up");
-		const feedToken = await owner.mintFeed(calendarId);
-		const first = await fetchFeed(feedToken);
-		const lastModified = headerOf(first, "last-modified") as string;
-
-		const unchanged = await fetchFeed(feedToken, {
-			"If-Modified-Since": lastModified,
-		});
-
-		assert.equal(unchanged.statusCode, 304);
-		assert.equal(headerOf(unchanged, "etag"), headerOf(first, "etag"));
-		assert.equal(headerOf(unchanged, "last-modified"), lastModified);
-
-		// RFC 9110 13.2.2: a tag that arrives is the whole condition, and the date
-		// is not consulted. Sending a tag nobody served alongside a date that would
-		// have earned a 304 has to re-serve the calendar.
-		const overridden = await fetchFeed(feedToken, {
-			"If-None-Match": '"not-the-tag"',
-			"If-Modified-Since": lastModified,
-		});
-
-		assert.equal(overridden.statusCode, 200);
-		assert.match(overridden.body, /SUMMARY:Stand-up/);
-	});
-	it("answers the same plain 404 to an unknown and to a malformed token", async () => {
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-		await owner.mintFeed(calendarId);
-
-		const unknown = await fetchFeed("z".repeat(43));
-		const malformed = await fetchFeed("not-a-token");
-
-		assert.equal(unknown.statusCode, 404);
-		assert.equal(malformed.statusCode, 404);
-		assert.equal(
-			headerOf(unknown, "content-type"),
-			"text/plain; charset=utf-8",
-		);
-		assert.equal(unknown.body, malformed.body);
-		assert.equal(
-			unknown.body.includes("calendar"),
-			true,
-			"the body says nothing about which of the two it was",
-		);
-	});
-});
-
-describe("the feed a person manages", () => {
-	it("hands out the token once and rotates the address on a second write", async () => {
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-		await owner.event(calendarId, "Stand-up");
-		const first = await owner.mintFeed(calendarId);
-
-		const second = await owner.mintFeed(calendarId);
-
-		assert.notEqual(second, first);
-		assert.equal((await fetchFeed(first)).statusCode, 404);
-		assert.equal((await fetchFeed(second)).statusCode, 200);
-
-		const state = await request({
-			method: "GET",
-			path: `/calendars/${calendarId}/feed`,
-			sub: owner.sub,
-		});
-		assert.equal(state.statusCode, 200);
-		assert.equal(json(state).feedToken, undefined);
-		assert.ok((json(state).rotatedAt as number) > 0);
-	});
-
-	it("stops the address resolving when it is revoked", async () => {
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-		const feedToken = await owner.mintFeed(calendarId);
-
-		const revoked = await request({
-			method: "DELETE",
-			path: `/calendars/${calendarId}/feed`,
-			sub: owner.sub,
-		});
-
-		assert.equal(revoked.statusCode, 204);
-		assert.equal((await fetchFeed(feedToken)).statusCode, 404);
-		assert.equal(
-			(
-				await request({
-					method: "DELETE",
-					path: `/calendars/${calendarId}/feed`,
-					sub: owner.sub,
-				})
-			).statusCode,
-			404,
-			"revoking a feed that is not there is not something to confirm",
-		);
-	});
-
-	it("takes the address with the calendar it belonged to", async () => {
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-		const feedToken = await owner.mintFeed(calendarId);
-
-		const removed = await request({
-			method: "DELETE",
-			path: `/calendars/${calendarId}`,
-			sub: owner.sub,
-		});
-
-		assert.equal(removed.statusCode, 204);
-		assert.equal((await fetchFeed(feedToken)).statusCode, 404);
-	});
-
-	it("is absent for a calendar the caller does not own", async () => {
-		const owner = new Subscriber();
-		const stranger = new Subscriber();
-		const calendarId = await owner.calendar();
-		await owner.mintFeed(calendarId);
-
-		for (const method of ["GET", "PUT", "DELETE"]) {
-			const response = await request({
-				method,
-				path: `/calendars/${calendarId}/feed`,
-				sub: stranger.sub,
-			});
-			assert.equal(response.statusCode, 404, `${method} ${response.body}`);
-		}
-	});
-
-	it("refuses to mint or revoke without a session", async () => {
-		const owner = new Subscriber();
-		const calendarId = await owner.calendar();
-
-		for (const method of ["GET", "PUT", "DELETE"]) {
-			const response = await request({
-				method,
-				path: `/calendars/${calendarId}/feed`,
-			});
-			assert.equal(response.statusCode, 401, `${method} ${response.body}`);
-		}
-	});
-});