@remit/backend 0.0.143 → 0.0.145

package/src/handlers/me.ts

@@ -1,203 +0,0 @@
-import { SendMessageCommand } from "@aws-sdk/client-sqs";
-import type {
-	AccountExportRequestResponse,
-	CreateExportResponse,
-	DeleteAccountConfigResponse,
-	DeleteMeInput,
-	QuarantineListResponse,
-	VipSuggestionsResponse,
-} from "@remit/api-openapi-types";
-import { BadRequestError, NotFoundError } from "@remit/data-ports/errors";
-import { logger } from "@remit/logger-lambda";
-import type { APIGatewayProxyEvent } from "aws-lambda";
-import { env } from "expect-env";
-import type { Context } from "openapi-backend";
-import { getAccountConfigIdFromEvent, getSubFromEvent } from "../auth.js";
-import { getClient } from "../service/data-client.js";
-import { sqsClient } from "../service/sqs.js";
-import type { MeOperationIds, OperationHandler } from "../types.js";
-import { toVipSuggestionEntry } from "./vip-suggestions.js";
-
-const DOWNLOAD_URL_TTL_SECONDS = 60 * 60;
-
-export const MeOperations: Record<
-	MeOperationIds,
-	OperationHandler<MeOperationIds>
-> = {
-	MeOperations_listVipSuggestions: async (
-		_context: Context,
-		...args: unknown[]
-	): Promise<VipSuggestionsResponse> => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-
-		const { address } = await getClient();
-		const items = await address.listSuggestedVips({ accountConfigId });
-
-		return { suggestions: items.map(toVipSuggestionEntry) };
-	},
-	MeOperations_listQuarantine: async (
-		_context: Context,
-		...args: unknown[]
-	): Promise<QuarantineListResponse> => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-
-		const { quarantine } = await getClient();
-		const entries = await quarantine.listByAccountConfigId(accountConfigId);
-
-		return { entries };
-	},
-	MeOperations_deleteMe: async (
-		_context: Context,
-		...args: unknown[]
-	): Promise<DeleteAccountConfigResponse> => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-
-		const { confirmEmail } = JSON.parse(
-			event.body ?? "{}",
-		) as Partial<DeleteMeInput>;
-		const callerEmail = event.requestContext?.authorizer?.claims?.email as
-			| string
-			| undefined;
-
-		if (typeof confirmEmail !== "string" || confirmEmail.trim() === "") {
-			throw new BadRequestError("confirmEmail is required");
-		}
-
-		if (!callerEmail) {
-			throw new BadRequestError("Account email claim missing from token");
-		}
-
-		if (confirmEmail.toLowerCase() !== callerEmail.toLowerCase()) {
-			throw new BadRequestError(
-				"confirmEmail does not match your account email",
-			);
-		}
-
-		const { accountConfig } = await getClient();
-
-		try {
-			await accountConfig.update(accountConfigId, {
-				state: "deleting",
-				deletedAt: Date.now(),
-			});
-		} catch (err: unknown) {
-			// If already in "deleting" state, treat as idempotent
-			if (
-				err instanceof Error &&
-				(err.name === "ConditionalCheckFailedException" ||
-					err.message.includes("ConditionalCheckFailed"))
-			) {
-				return {
-					statusCode: 202,
-					message: "Account deletion already in progress",
-				};
-			}
-			throw err;
-		}
-
-		const queueUrl = env.SQS_QUEUE_URL_ACCOUNT_FANOUT;
-
-		await sqsClient.send(
-			new SendMessageCommand({
-				QueueUrl: queueUrl,
-				MessageBody: JSON.stringify({
-					type: "AccountDelete",
-					accountConfigId,
-				}),
-			}),
-		);
-
-		// biome-ignore lint/plugin/no-logger-info: account deletion is an audit-grade signal
-		logger.info({ accountConfigId }, "Account deletion initiated");
-
-		return {
-			statusCode: 202,
-			message: "Account deletion initiated",
-		};
-	},
-	MeOperations_createExport: async (
-		_context: Context,
-		...args: unknown[]
-	): Promise<CreateExportResponse> => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const userId = getSubFromEvent(event);
-
-		if (!userId) {
-			throw new Error(
-				"Missing Cognito `sub`: cannot attribute an export request to a user",
-			);
-		}
-
-		const { accountExportRequest } = await getClient();
-		const exportRequest = await accountExportRequest.create({
-			accountConfigId,
-			userId,
-			state: "Pending",
-		});
-
-		await sqsClient.send(
-			new SendMessageCommand({
-				QueueUrl: env.SQS_QUEUE_URL_ACCOUNT_FANOUT,
-				MessageBody: JSON.stringify({
-					type: "AccountExport",
-					accountConfigId,
-					accountExportRequestId: exportRequest.accountExportRequestId,
-				}),
-			}),
-		);
-
-		// biome-ignore lint/plugin/no-logger-info: account export is an audit-grade signal
-		logger.info(
-			{
-				accountConfigId,
-				accountExportRequestId: exportRequest.accountExportRequestId,
-			},
-			"Account export initiated",
-		);
-
-		return {
-			statusCode: 202,
-			exportId: exportRequest.accountExportRequestId,
-		};
-	},
-	MeOperations_getExport: async (
-		context: Context,
-		...args: unknown[]
-	): Promise<AccountExportRequestResponse> => {
-		const event = args[0] as APIGatewayProxyEvent;
-		const accountConfigId = getAccountConfigIdFromEvent(event);
-		const exportId = context.request.params.exportId as string;
-
-		const { accountExportRequest, storage } = await getClient();
-		const exportRequest = await accountExportRequest.get(exportId);
-
-		if (exportRequest.accountConfigId !== accountConfigId) {
-			throw new NotFoundError(`Export not found: ${exportId}`);
-		}
-
-		const downloadUrl =
-			exportRequest.state === "Ready" && exportRequest.objectKey
-				? await storage.getPresignedDownloadUrl(
-						exportRequest.objectKey,
-						DOWNLOAD_URL_TTL_SECONDS,
-					)
-				: undefined;
-
-		return {
-			accountExportRequestId: exportRequest.accountExportRequestId,
-			accountConfigId: exportRequest.accountConfigId,
-			userId: exportRequest.userId,
-			state: exportRequest.state,
-			createdAt: exportRequest.createdAt,
-			updatedAt: exportRequest.updatedAt,
-			objectKey: exportRequest.objectKey,
-			downloadUrl,
-			expiresAt: exportRequest.expiresAt,
-			errorMessage: exportRequest.errorMessage,
-		};
-	},
-};

package/src/handlers/message-read-backfill.test.ts

@@ -1,103 +0,0 @@
-import assert from "node:assert/strict";
-import { afterEach, describe, it } from "node:test";
-import type { APIGatewayProxyEvent } from "aws-lambda";
-import type { Context } from "openapi-backend";
-import {
-	_resetForTest,
-	type RemitClient,
-	setClient,
-} from "../service/data-client.js";
-import { MessageOperations } from "./message.js";
-
-type Handler = (
-	context: Context,
-	event: APIGatewayProxyEvent,
-) => Promise<unknown>;
-
-const describeMessage =
-	MessageOperations.MessageOperations_describeMessage as unknown as Handler;
-const getRawMessage =
-	MessageOperations.MessageOperations_getRawMessage as unknown as Handler;
-
-const MESSAGE_ID = "msg-1";
-const MAILBOX_ID = "mb-1";
-const ACCOUNT_ID = "acc-1";
-
-const event = {
-	requestContext: { authorizer: { claims: { sub: "sub-610" } } },
-} as unknown as APIGatewayProxyEvent;
-
-const context = {
-	request: { params: { messageId: MESSAGE_ID } },
-} as unknown as Context;
-
-const unstoredMessage = {
-	messageId: MESSAGE_ID,
-	mailboxId: MAILBOX_ID,
-	uid: 7,
-	internalDate: 1,
-	status: "active",
-	syncStatus: "synced",
-};
-
-const mailboxRow = {
-	mailboxId: MAILBOX_ID,
-	accountId: ACCOUNT_ID,
-	fullPath: "Junk",
-	cursorState: "normal",
-};
-
-const clientWithFailingFolderLookup = (opened: string[]): RemitClient =>
-	({
-		message: {
-			get: async () => unstoredMessage,
-			describe: async () => ({
-				message: [unstoredMessage],
-				envelope: [],
-				envelopeAddress: [],
-				messageFlag: [],
-				bodyPart: [],
-				messageReference: [],
-			}),
-		},
-		messageLabel: { listByMessageId: async () => [] },
-		account: {
-			listAllByAccountConfig: async () => [{ accountId: ACCOUNT_ID }],
-		},
-		mailbox: {
-			get: async (_accountId: string, ids: string | string[]) =>
-				Array.isArray(ids) ? [mailboxRow] : mailboxRow,
-		},
-		storage: { bodyPartExists: async () => false },
-		mailboxSpecialUse: {
-			findJunkMailbox: async () => {
-				throw new Error("special-use lookup timed out");
-			},
-			findInboxMailbox: async () => null,
-		},
-		createConnectionScope: async (accountId: string) => {
-			opened.push(accountId);
-			return {
-				getConnection: async () => ({}),
-				disconnect: async () => {},
-			};
-		},
-	}) as unknown as RemitClient;
-
-describe("reading an unstored message when the folder lookup fails", () => {
-	afterEach(() => _resetForTest());
-
-	for (const [name, handler] of [
-		["describeMessage", describeMessage],
-		["getRawMessage", getRawMessage],
-	] as const) {
-		it(`${name} opens no IMAP connection`, async () => {
-			const opened: string[] = [];
-			setClient(clientWithFailingFolderLookup(opened));
-
-			await assert.rejects(handler(context, event), /special-use lookup/);
-
-			assert.deepEqual(opened, []);
-		});
-	}
-});

package/src/handlers/message.test.ts

@@ -1,131 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import { MessagePlacementUnsettledError } from "@remit/data-ports/errors";
-import {
-	MoveNotSettledError,
-	NoJunkMailboxError,
-} from "@remit/mailbox-service";
-import { GENERIC_FAILURE_REASON, settleSpamReportBulk } from "./message.js";
-
-describe("settleSpamReportBulk", () => {
-	it("aggregates successes and failures, surfacing the one allowlisted reason verbatim", async () => {
-		const outcome = await settleSpamReportBulk(
-			["msg-1", "msg-2", "msg-3"],
-			async (messageId) => {
-				if (messageId === "msg-2") {
-					throw new MoveNotSettledError(messageId);
-				}
-			},
-		);
-
-		assert.equal(outcome.successCount, 2);
-		assert.equal(outcome.failureCount, 1);
-		assert.deepEqual(outcome.failures, [
-			{
-				messageId: "msg-2",
-				reason:
-					"Message msg-2's move to Junk has not settled yet; try again in a moment.",
-			},
-		]);
-	});
-
-	it("tells the user to create the missing Junk folder rather than to try again", async () => {
-		// Retrying cannot resolve this one, so the generic retry copy would be a
-		// dead end. The service's own text names the folder and the fix.
-		const outcome = await settleSpamReportBulk(["msg-1"], async () => {
-			throw new NoJunkMailboxError();
-		});
-
-		const reason = outcome.failures?.[0].reason ?? "";
-		assert.match(reason, /no Junk folder/);
-		assert.match(reason, /Create one/);
-		assert.notEqual(reason, GENERIC_FAILURE_REASON);
-	});
-
-	// A refusal the move gate raises used to collapse to the generic retry copy,
-	// which is a dead end (#665). One reason reaches it now — a mutation still in
-	// flight — and it words the wait rather than the server's sentence.
-	it("words a placement refusal from its reason, never from the server's sentence", async () => {
-		const outcome = await settleSpamReportBulk(
-			["msg-1", "msg-2"],
-			async (messageId) => {
-				throw new MessagePlacementUnsettledError(
-					`Message ${messageId} was not acted on: its folder and uid do not name the same message`,
-					"acc-1",
-					messageId,
-					"in_flight",
-				);
-			},
-		);
-
-		const reasons = outcome.failures?.map((f) => f.reason) ?? [];
-		assert.equal(reasons.length, 2);
-		for (const reason of reasons) {
-			assert.match(reason ?? "", /try again in a moment/i);
-			assert.notEqual(reason, GENERIC_FAILURE_REASON);
-			assert.doesNotMatch(reason ?? "", /folder and uid/);
-			assert.doesNotMatch(reason ?? "", /acc-1/);
-		}
-	});
-
-	it("omits failures entirely when every message succeeds", async () => {
-		const outcome = await settleSpamReportBulk(
-			["msg-1", "msg-2"],
-			async () => {},
-		);
-
-		assert.equal(outcome.successCount, 2);
-		assert.equal(outcome.failureCount, 0);
-		assert.equal(outcome.failures, undefined);
-	});
-
-	// The response is user-facing (the field is documented as shown as-is) and
-	// this is a 200, not an error path guarded by error.ts's own flattening —
-	// so this is the one place a raw internal message could otherwise leak: an
-	// account id in "No Junk mailbox found for account <id>", a message id in
-	// "has no From address to act on", or an AWS SDK message naming a queue
-	// URL or ECONNREFUSED host:port on an SQS failure.
-	it("never puts an arbitrary error's raw text in the response — only the allowlisted reason ships", async () => {
-		const outcome = await settleSpamReportBulk(
-			["msg-leaky-error", "msg-leaky-string", "msg-settled-ok"],
-			async (messageId) => {
-				if (messageId === "msg-leaky-error") {
-					throw new Error(
-						"No Junk mailbox found for account acc-super-secret-internal-id",
-					);
-				}
-				if (messageId === "msg-leaky-string") {
-					return Promise.reject("ECONNREFUSED sqs.us-east-1.amazonaws.com:443");
-				}
-			},
-		);
-
-		assert.equal(outcome.failureCount, 2);
-		const reasons = outcome.failures?.map((f) => f.reason) ?? [];
-		assert.deepEqual(reasons, [GENERIC_FAILURE_REASON, GENERIC_FAILURE_REASON]);
-
-		const leaked = reasons.some(
-			(reason) =>
-				reason.includes("acc-super-secret-internal-id") ||
-				reason.includes("ECONNREFUSED") ||
-				reason.includes("amazonaws.com"),
-		);
-		assert.equal(leaked, false, "no internal detail may reach the response");
-	});
-
-	it("runs every message concurrently — total time is one wait, not N waits", async () => {
-		const WAIT_MS = 60;
-		const start = Date.now();
-
-		await settleSpamReportBulk(
-			Array.from({ length: 10 }, (_, i) => `msg-${i}`),
-			() => new Promise((resolve) => setTimeout(resolve, WAIT_MS)),
-		);
-
-		const elapsed = Date.now() - start;
-		assert.ok(
-			elapsed < WAIT_MS * 5,
-			`expected roughly one wait (~${WAIT_MS}ms), took ${elapsed}ms — looks sequential`,
-		);
-	});
-});