@remit/backend 0.0.143 → 0.0.145

package/src/derive/contentUrl.ts

@@ -1,86 +0,0 @@
-/**
- * Build the public CloudFront URL that fetches a single body part for a
- * message. The path layout is what the Lambda@Edge JWT verifier expects
- * (PR 1 of #224): `/content/accounts/{accountConfigId}/{accountId}/messages/
- * {messageId}/parts/{partPath}`.
- *
- * The function is intentionally pure — domain comes from configuration so
- * tests can pin the output without env vars. `partPath` is passed through
- * `encodeURIComponent` because IMAP section paths are dot-separated digits
- * (e.g. `1`, `1.2`, `2.1.3`) but a defensive encode keeps the builder safe
- * if the path ever carries unexpected characters.
- */
-import type { ContentSigner } from "./contentSignature.js";
-
-export interface BuildContentUrlInput {
-	domain: string;
-	accountConfigId: string;
-	accountId: string;
-	messageId: string;
-	partPath: string;
-	/**
-	 * When present (self-host stack), append an `exp`/`sig` signature scoped to
-	 * this account's storage path. Absent on AWS, where Lambda@Edge guards the
-	 * URL and the path stays unsigned. See `contentSignature.ts`.
-	 */
-	sign?: ContentSigner;
-}
-
-export interface BuildStorageContentUrlInput {
-	domain: string;
-	storageKey: string;
-	sign?: ContentSigner;
-}
-
-export const buildStorageContentUrl = (
-	input: BuildStorageContentUrlInput,
-): string => {
-	const { domain, storageKey, sign } = input;
-	const normalizedDomain = domain.replace(/\/+$/, "");
-	const base = normalizedDomain.startsWith("http")
-		? normalizedDomain
-		: `https://${normalizedDomain}`;
-	// The signed message is the decoded, account-scoped storage path — the same
-	// value the `/content` route recomputes from `req.path`. Keep it in lockstep
-	// with the verifier's `req.path.replace(/^\/content\//, "")`.
-	const safeKey = storageKey
-		.split("/")
-		.map((segment) => encodeURIComponent(segment))
-		.join("/");
-	const url = `${base}/content/${safeKey}`;
-	if (!sign) return url;
-	const { exp, sig } = sign(storageKey);
-	return `${url}?exp=${exp}&sig=${encodeURIComponent(sig)}`;
-};
-
-export const buildContentUrl = (input: BuildContentUrlInput): string => {
-	const { domain, accountConfigId, accountId, messageId, partPath, sign } =
-		input;
-	return buildStorageContentUrl({
-		domain,
-		storageKey: `accounts/${accountConfigId}/${accountId}/messages/${messageId}/parts/${partPath}`,
-		sign,
-	});
-};
-
-/**
- * Read the CloudFront distribution domain from the environment. The CDK
- * wires `CONTENT_DELIVERY_DOMAIN` onto the API Lambda from the
- * ContentDelivery stack's published SSM parameter (`/{stage}/Remit/frontendUrl`).
- *
- * Throws when the env var is missing or empty. `BodyPartResponse.contentUrl`
- * is required + URL-formatted in the API contract, so silently emitting a
- * placeholder string would ship a contract lie to clients. Failing loud here
- * surfaces the missing wire-up as a 500 the deploy team can act on (#299).
- * Production synth hard-codes a syntactically-valid placeholder URL via
- * `infra/bin/infra.ts` so this only fires when the env is actually unset.
- */
-export const getContentDeliveryDomain = (): string => {
-	const value = process.env.CONTENT_DELIVERY_DOMAIN;
-	if (!value || value.length === 0) {
-		throw new Error(
-			"CONTENT_DELIVERY_DOMAIN is not set; BodyPartResponse.contentUrl cannot be built. Wire the CloudFront distribution domain via the API Lambda env (see infra/bin/infra.ts).",
-		);
-	}
-	return value;
-};

package/src/derive/deriveMuted.test.ts

@@ -1,34 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import type { AddressFlags } from "@remit/api-openapi-types";
-import { deriveMuted } from "./deriveMuted.js";
-
-const SET_AT = 1_700_000_000_000;
-
-describe("deriveMuted", () => {
-	it("returns false when flags is undefined", () => {
-		assert.equal(deriveMuted(undefined), false);
-	});
-
-	it("returns false for an empty flags object", () => {
-		assert.equal(deriveMuted({}), false);
-	});
-
-	it("returns false when muted.value is false", () => {
-		const flags: AddressFlags = { muted: { value: false, setAt: SET_AT } };
-		assert.equal(deriveMuted(flags), false);
-	});
-
-	it("returns true when muted.value is true", () => {
-		const flags: AddressFlags = { muted: { value: true, setAt: SET_AT } };
-		assert.equal(deriveMuted(flags), true);
-	});
-
-	it("ignores other flags (orthogonal axis)", () => {
-		const flags: AddressFlags = {
-			vip: { value: true, setAt: SET_AT },
-			wellknown: { value: true, setAt: SET_AT },
-		};
-		assert.equal(deriveMuted(flags), false);
-	});
-});

package/src/derive/enrichThreadRows.test.ts

@@ -1,360 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, test } from "node:test";
-import type {
-	AddressItem,
-	LabelItem,
-	MessageItem,
-	MessageLabelItem,
-	ThreadMessageItem,
-} from "@remit/data-ports";
-import { deriveAddressId } from "@remit/data-ports/id";
-import { hasAbandonedDelete } from "@remit/data-ports/message-settlement";
-import {
-	MessageMutation,
-	MessageStatus,
-	MessageSyncStatus,
-} from "@remit/domain-enums";
-import { type EnrichClient, enrichThreadRows } from "./enrichThreadRows.js";
-
-const threadRow = (
-	threadMessageId: string,
-	messageId: string,
-	fromEmail?: string,
-): ThreadMessageItem =>
-	({
-		threadMessageId,
-		threadId: "th-1",
-		messageId,
-		accountConfigId: "acc-1",
-		mailboxId: "mbx-1",
-		fromEmail,
-		sentDate: 1,
-		isRead: true,
-		hasAttachment: false,
-		hasStars: false,
-		isDeleted: false,
-		createdAt: 1,
-		updatedAt: 1,
-	}) as unknown as ThreadMessageItem;
-
-const buildClient = (
-	messageLabels: MessageLabelItem[],
-	labels: LabelItem[],
-	addresses: AddressItem[] = [],
-): EnrichClient => ({
-	message: { get: async () => [] as MessageItem[] },
-	address: { getAddress: async () => addresses },
-	messageLabel: {
-		listByMessageIds: async (messageIds: string[]) =>
-			messageLabels.filter((row) => messageIds.includes(row.messageId)),
-	},
-	label: {
-		listByAccountConfig: async () => labels,
-	},
-});
-
-describe("enrichThreadRows — labels", () => {
-	test("attaches every label applied to a message", async () => {
-		const rows = [threadRow("tm-1", "msg-1")];
-		const messageLabels = [
-			{
-				messageLabelId: "ml-1",
-				messageId: "msg-1",
-				labelId: "lbl-1",
-				accountConfigId: "acc-1",
-				createdAt: 1,
-				updatedAt: 1,
-			},
-			{
-				messageLabelId: "ml-2",
-				messageId: "msg-1",
-				labelId: "lbl-2",
-				accountConfigId: "acc-1",
-				createdAt: 1,
-				updatedAt: 1,
-			},
-		] as unknown as MessageLabelItem[];
-		const labels = [
-			{
-				labelId: "lbl-1",
-				accountConfigId: "acc-1",
-				name: "Receipts",
-				normalizedName: "receipts",
-				color: "Blue",
-				createdAt: 1,
-				updatedAt: 1,
-			},
-			{
-				labelId: "lbl-2",
-				accountConfigId: "acc-1",
-				name: "Travel",
-				normalizedName: "travel",
-				color: "Green",
-				createdAt: 1,
-				updatedAt: 1,
-			},
-		] as unknown as LabelItem[];
-
-		const [result] = await enrichThreadRows(
-			rows,
-			buildClient(messageLabels, labels),
-			"acc-1",
-		);
-
-		assert.deepEqual(result?.labels?.map((l) => l.labelId).sort(), [
-			"lbl-1",
-			"lbl-2",
-		]);
-		assert.deepEqual(
-			result?.labels?.find((l) => l.labelId === "lbl-1"),
-			{ labelId: "lbl-1", name: "Receipts", color: "Blue" },
-		);
-	});
-
-	test("omits labels entirely when the message has none", async () => {
-		const rows = [threadRow("tm-1", "msg-1")];
-		const [result] = await enrichThreadRows(rows, buildClient([], []), "acc-1");
-		assert.equal(result?.labels, undefined);
-	});
-
-	test("skips a MessageLabel row whose Label was deleted out from under it", async () => {
-		const rows = [threadRow("tm-1", "msg-1")];
-		const messageLabels = [
-			{
-				messageLabelId: "ml-1",
-				messageId: "msg-1",
-				labelId: "gone",
-				accountConfigId: "acc-1",
-				createdAt: 1,
-				updatedAt: 1,
-			},
-		] as unknown as MessageLabelItem[];
-
-		const [result] = await enrichThreadRows(
-			rows,
-			buildClient(messageLabels, []),
-			"acc-1",
-		);
-		assert.equal(result?.labels, undefined);
-	});
-
-	test("never cross-wires labels between rows for different messages", async () => {
-		const rows = [threadRow("tm-1", "msg-1"), threadRow("tm-2", "msg-2")];
-		const messageLabels = [
-			{
-				messageLabelId: "ml-1",
-				messageId: "msg-1",
-				labelId: "lbl-1",
-				accountConfigId: "acc-1",
-				createdAt: 1,
-				updatedAt: 1,
-			},
-		] as unknown as MessageLabelItem[];
-		const labels = [
-			{
-				labelId: "lbl-1",
-				accountConfigId: "acc-1",
-				name: "Receipts",
-				normalizedName: "receipts",
-				color: "Blue",
-				createdAt: 1,
-				updatedAt: 1,
-			},
-		] as unknown as LabelItem[];
-
-		const [first, second] = await enrichThreadRows(
-			rows,
-			buildClient(messageLabels, labels),
-			"acc-1",
-		);
-		assert.equal(first?.labels?.length, 1);
-		assert.equal(second?.labels, undefined);
-	});
-});
-
-describe("enrichThreadRows — spamReport", () => {
-	test("projects spamReport straight from the Message row", async () => {
-		const rows = [threadRow("tm-1", "msg-1")];
-		const client: EnrichClient = {
-			message: {
-				get: async () =>
-					[
-						{
-							messageId: "msg-1",
-							spamReport: { reportedAt: 1_700_000_000_000 },
-						},
-					] as unknown as MessageItem[],
-			},
-			address: { getAddress: async () => [] },
-			messageLabel: { listByMessageIds: async () => [] },
-			label: { listByAccountConfig: async () => [] },
-		};
-
-		const [result] = await enrichThreadRows(rows, client, "acc-1");
-		assert.deepEqual(result?.spamReport, { reportedAt: 1_700_000_000_000 });
-	});
-
-	test("omits spamReport when the Message has never been reported", async () => {
-		const rows = [threadRow("tm-1", "msg-1")];
-		const [result] = await enrichThreadRows(rows, buildClient([], []), "acc-1");
-		assert.equal(result?.spamReport, undefined);
-	});
-});
-
-describe("enrichThreadRows — muted", () => {
-	const SET_AT = 1_700_000_000_000;
-
-	test("sets muted true from the batch-fetched Address's flags, no extra query", async () => {
-		const fromEmail = "muted@example.com";
-		const addressId = deriveAddressId("acc-1", fromEmail);
-		const rows = [threadRow("tm-1", "msg-1", fromEmail)];
-		const addresses = [
-			{
-				addressId,
-				accountConfigId: "acc-1",
-				flags: { muted: { value: true, setAt: SET_AT } },
-			},
-		] as unknown as AddressItem[];
-
-		let addressCalls = 0;
-		const client: EnrichClient = {
-			message: { get: async () => [] as MessageItem[] },
-			address: {
-				getAddress: async () => {
-					addressCalls += 1;
-					return addresses;
-				},
-			},
-			messageLabel: { listByMessageIds: async () => [] },
-			label: { listByAccountConfig: async () => [] },
-		};
-
-		const [result] = await enrichThreadRows(rows, client, "acc-1");
-		assert.equal(result?.muted, true);
-		assert.equal(addressCalls, 1);
-	});
-
-	test("defaults muted to false when the Address has no muted flag", async () => {
-		const fromEmail = "not-muted@example.com";
-		const addressId = deriveAddressId("acc-1", fromEmail);
-		const rows = [threadRow("tm-1", "msg-1", fromEmail)];
-		const addresses = [
-			{ addressId, accountConfigId: "acc-1", flags: {} },
-		] as unknown as AddressItem[];
-
-		const [result] = await enrichThreadRows(
-			rows,
-			buildClient([], [], addresses),
-			"acc-1",
-		);
-		assert.equal(result?.muted, false);
-	});
-
-	test("defaults muted to false when no Address row resolves", async () => {
-		const rows = [threadRow("tm-1", "msg-1")];
-		const [result] = await enrichThreadRows(rows, buildClient([], []), "acc-1");
-		assert.equal(result?.muted, false);
-	});
-});
-
-describe("enrichThreadRows — the mutation pair", () => {
-	const withMessage = (message: Partial<MessageItem>): EnrichClient => ({
-		message: {
-			get: async () =>
-				[{ messageId: "msg-1", ...message }] as unknown as MessageItem[],
-		},
-		address: { getAddress: async () => [] },
-		messageLabel: { listByMessageIds: async () => [] },
-		label: { listByAccountConfig: async () => [] },
-	});
-
-	const project = async (message: Partial<MessageItem>) => {
-		const [result] = await enrichThreadRows(
-			[threadRow("tm-1", "msg-1")],
-			withMessage(message),
-			"acc-1",
-		);
-		return result;
-	};
-
-	test("projects the pair an abandoned delete leaves behind, and what it gave up on", async () => {
-		const result = await project({
-			status: MessageStatus.active,
-			syncStatus: MessageSyncStatus.abandoned,
-			abandonedMutation: MessageMutation.delete,
-		});
-		assert.equal(result?.status, MessageStatus.active);
-		assert.equal(result?.syncStatus, MessageSyncStatus.abandoned);
-		assert.equal(result?.abandonedMutation, MessageMutation.delete);
-		assert.equal(
-			hasAbandonedDelete({
-				status: result?.status,
-				syncStatus: result?.syncStatus,
-				abandonedMutation: result?.abandonedMutation,
-			}),
-			true,
-		);
-	});
-
-	// Issue #1229. Both give-ups leave the same `status`/`syncStatus` pair, so
-	// the projection has to carry the third field or the client cannot tell a
-	// move that handed back from a delete that was refused.
-	test("projects a move that gave up as a move, never as a delete", async () => {
-		const result = await project({
-			status: MessageStatus.active,
-			syncStatus: MessageSyncStatus.abandoned,
-			abandonedMutation: MessageMutation.move,
-		});
-		assert.equal(result?.abandonedMutation, MessageMutation.move);
-		assert.equal(
-			hasAbandonedDelete({
-				status: result?.status,
-				syncStatus: result?.syncStatus,
-				abandonedMutation: result?.abandonedMutation,
-			}),
-			false,
-		);
-	});
-
-	test("projects a move mid-retry without calling it a give-up", async () => {
-		const result = await project({
-			status: MessageStatus.moving,
-			syncStatus: MessageSyncStatus.failed,
-		});
-		assert.equal(result?.status, MessageStatus.moving);
-		assert.equal(result?.syncStatus, MessageSyncStatus.failed);
-		assert.equal(
-			hasAbandonedDelete({
-				status: result?.status,
-				syncStatus: result?.syncStatus,
-				abandonedMutation: result?.abandonedMutation,
-			}),
-			false,
-		);
-	});
-
-	test("projects an ordinary inbound row", async () => {
-		const result = await project({
-			status: MessageStatus.active,
-			syncStatus: MessageSyncStatus.pending,
-		});
-		assert.equal(result?.status, MessageStatus.active);
-		assert.equal(result?.syncStatus, MessageSyncStatus.pending);
-	});
-
-	test("a row whose Message row is missing claims no mutation", async () => {
-		const [result] = await enrichThreadRows(
-			[threadRow("tm-1", "msg-1")],
-			buildClient([], []),
-			"acc-1",
-		);
-		assert.equal(
-			hasAbandonedDelete({
-				status: result?.status,
-				syncStatus: result?.syncStatus,
-				abandonedMutation: result?.abandonedMutation,
-			}),
-			false,
-		);
-	});
-});