@openui5/sap.ui.rta 1.136.4 → 1.139.0

package/src/sap/ui/rta/util/adaptationStarter.js

@@ -5,9 +5,7 @@
  */
 sap.ui.define([
 	"sap/base/Log",
-	"sap/ui/core/Control",
 	"sap/ui/core/Lib",
-	"sap/ui/core/UIComponent",
 	"sap/ui/fl/initial/api/InitialFlexAPI",
 	"sap/ui/fl/write/api/PersistenceWriteAPI",
 	"sap/ui/fl/Layer",
@@ -16,9 +14,7 @@ sap.ui.define([
 	"sap/ui/rta/RuntimeAuthoring"
 ], function(
 	Log,
-	Control,
 	Lib,
-	UIComponent,
 	InitialFlexAPI,
 	PersistenceWriteAPI,
 	Layer,
@@ -28,30 +24,27 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	function checkKeyUser(sLayer) {
+	async function checkKeyUser(sLayer) {
 		if (Layer.CUSTOMER === sLayer) {
-			return InitialFlexAPI.isKeyUser()
-			.then(function(bIsKeyUser) {
-				if (!bIsKeyUser) {
-					var oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
-					var oError = new Error(oRtaResourceBundle.getText("MSG_NO_KEY_USER_RIGHTS_ERROR_MESSAGE"));
-					oError.reason = "isKeyUser";
-					throw oError;
-				}
-			});
+			const bIsKeyUser = await InitialFlexAPI.isKeyUser();
+			if (!bIsKeyUser) {
+				const oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
+				const oError = new Error(oRtaResourceBundle.getText("MSG_NO_KEY_USER_RIGHTS_ERROR_MESSAGE"));
+				oError.reason = "isKeyUser";
+				throw oError;
+			}
 		}
-		return Promise.resolve();
 	}
 
 	function checkFlexEnabled(oAppComponent) {
 		// fiori tools is always a developer scenario where the flexEnabled flag should not be evaluated
-		var sFioriToolsMode = new URLSearchParams(window.location.search).get("fiori-tools-rta-mode");
+		const sFioriToolsMode = new URLSearchParams(window.location.search).get("fiori-tools-rta-mode");
 		if (!sFioriToolsMode || sFioriToolsMode === "false") {
-			var oManifest = oAppComponent.getManifest() || {};
-			var vFlexEnabled = oManifest["sap.ui5"] && oManifest["sap.ui5"].flexEnabled;
+			const oManifest = oAppComponent.getManifest() || {};
+			const vFlexEnabled = oManifest["sap.ui5"] && oManifest["sap.ui5"].flexEnabled;
 
 			if (vFlexEnabled === false) {
-				var oError = Error("This app is not enabled for key user adaptation");
+				const oError = Error("This app is not enabled for key user adaptation");
 				oError.reason = "flexEnabled";
 				throw oError;
 			}
@@ -62,8 +55,7 @@ sap.ui.define([
 		// pseudo app variants are not supported
 		const oComponentData = oAppComponent.getComponentData?.();
 		if (oComponentData?.startupParameters && Array.isArray(oComponentData.startupParameters["sap-app-id"])) {
-			const oManifest = oAppComponent.getManifest();
-			const sACHComponent = oManifest["sap.app"]?.ach;
+			const sACHComponent = oAppComponent.getManifest()["sap.app"]?.ach;
 			const oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
 			const sErrorMessage = oRtaResourceBundle.getText("MSG_PSEUDO_APP_VARIANT_ERROR_MESSAGE", [sACHComponent]);
 			const oError = Error(sErrorMessage);
@@ -81,54 +73,46 @@ sap.ui.define([
 	 *
 	 * @param {object} mOptions - Object with properties
 	 * @param {sap.ui.core.Control|sap.ui.core.UIComponent} mOptions.rootControl - Control instance to get the AppComponent. This then is used to start UI adaptation.
-	 * @param {function} [loadPlugins] - Callback function that enables the modification of the default plugin list of UI adaptation. UI adaptation is passed to this function and it should return a promise
-	 * @param {function} [onStart] - Event handler function called on start event
-	 * @param {function} [onFailed] - Event handler function called on failed event
-	 * @param {function} [onStop] - Event handler function called on stop event
+	 * @param {function} [fnLoadPlugins] - Callback function that enables the modification of the default plugin list of UI adaptation. UI adaptation is passed to this function and it should return a promise
+	 * @param {function} [fnOnStart] - Event handler function called on start event
+	 * @param {function} [fnOnFailed] - Event handler function called on failed event
+	 * @param {function} [fnOnStop] - Event handler function called on stop event
 	 * @returns {Promise} Resolves when UI adaptation was successfully started with adaptation instance.
 	 * @private
 	 */
-	function adaptationStarter(mOptions, loadPlugins, onStart, onFailed, onStop) {
-		var oRta;
+	async function adaptationStarter(mOptions, fnLoadPlugins, fnOnStart, fnOnFailed, fnOnStop) {
+		const oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
 
-		return Promise.resolve().then(function() {
-			if (!(mOptions.rootControl instanceof Control) && !(mOptions.rootControl instanceof UIComponent)) {
-				var oError = Error("An invalid root control was passed");
+		try {
+			if (!(mOptions.rootControl?.isA("sap.ui.core.Control")) && !(mOptions.rootControl?.isA("sap.ui.core.UIComponent"))) {
+				const oError = Error("An invalid root control was passed");
 				oError.reason = "rootControl";
 				throw oError;
 			}
 			mOptions.rootControl = FlexUtils.getAppComponentForControl(mOptions.rootControl);
-		})
-		.then(checkKeyUser.bind(undefined, mOptions.flexSettings.layer))
-		.then(function() {
-			return checkFlexEnabled(mOptions.rootControl);
-		})
-		.then(checkPseudoAppVariant.bind(undefined, mOptions.rootControl))
-		.then(function() {
-			oRta = new RuntimeAuthoring(mOptions);
 
-			if (onStart) {
-				oRta.attachEvent("start", onStart);
+			await checkKeyUser(mOptions.flexSettings.layer);
+			checkFlexEnabled(mOptions.rootControl);
+			checkPseudoAppVariant(mOptions.rootControl);
+
+			const oRta = new RuntimeAuthoring(mOptions);
+			if (fnOnStart) {
+				oRta.attachEvent("start", fnOnStart);
 			}
-			if (onFailed) {
-				oRta.attachEvent("failed", onFailed);
+			if (fnOnFailed) {
+				oRta.attachEvent("failed", fnOnFailed);
 			}
-			var fnOnStop = onStop || function() {
+			oRta.attachEvent("stop", fnOnStop || function() {
 				oRta.destroy();
-			};
-			oRta.attachEvent("stop", fnOnStop);
+			});
 
-			if (loadPlugins) {
-				return loadPlugins(oRta);
+			if (fnLoadPlugins) {
+				await fnLoadPlugins(oRta);
 			}
-			return undefined;
-		})
-		.then(function() {
-			return oRta.start();
-		})
-		.then(function() {
+			await oRta.start();
+
 			if (mOptions.flexSettings.layer === "CUSTOMER") {
-				var mPropertyBag = {
+				const mPropertyBag = {
 					oComponent: mOptions.rootControl,
 					selector: mOptions.rootControl,
 					invalidateCache: false,
@@ -136,38 +120,33 @@ sap.ui.define([
 					currentLayer: Layer.CUSTOMER
 				};
 
-				PersistenceWriteAPI.getChangesWarning(mPropertyBag)
-				.then(function(oWarningMessage) {
-					if (oWarningMessage.showWarning) {
-						var oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
-						var oMessageProps = oWarningMessage.warningType === "mixedChangesWarning"
-							? {
-								text: "MSG_ADAPTATION_STARTER_MIXED_CHANGES_WARNING",
-								title: "TIT_ADAPTATION_STARTER_MIXED_CHANGES_TITLE"
-							}
-							: {
-								text: "MSG_ADAPTATION_STARTER_NO_CHANGES_IN_P_WARNING",
-								title: "TIT_ADAPTATION_STARTER_NO_CHANGES_IN_P_TITLE"
-							};
+				const oWarningMessage = await PersistenceWriteAPI.getChangesWarning(mPropertyBag);
+				if (oWarningMessage.showWarning) {
+					const oMessageProps = oWarningMessage.warningType === "mixedChangesWarning"
+						? {
+							text: "MSG_ADAPTATION_STARTER_MIXED_CHANGES_WARNING",
+							title: "TIT_ADAPTATION_STARTER_MIXED_CHANGES_TITLE"
+						}
+						: {
+							text: "MSG_ADAPTATION_STARTER_NO_CHANGES_IN_P_WARNING",
+							title: "TIT_ADAPTATION_STARTER_NO_CHANGES_IN_P_TITLE"
+						};
 
-						showMessageBox(
-							oRtaResourceBundle.getText(oMessageProps.text),
-							{
-								title: oRtaResourceBundle.getText(oMessageProps.title)
-							},
-							"warning"
-						);
-					}
-				});
+					showMessageBox(
+						oRtaResourceBundle.getText(oMessageProps.text),
+						{
+							title: oRtaResourceBundle.getText(oMessageProps.title)
+						},
+						"warning"
+					);
+				}
 			}
 			return oRta;
-		})
-		.catch(function(vError) {
+		} catch (vError) {
 			if (
 				vError.message !== "Reload triggered"
 				&& !(FlexUtils.getUshellContainer() && vError.reason === "flexEnabled") // FLP Plugin already handles this error
 			) {
-				var oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
 				if (vError.reason === "isKeyUser" || vError.reason === "pseudoAppVariant") {
 					showMessageBox(
 						vError.message,
@@ -184,7 +163,7 @@ sap.ui.define([
 				Log.error("UI Adaptation could not be started", vError.message);
 			}
 			throw vError;
-		});
+		}
 	}
 	return adaptationStarter;
 });

package/src/sap/ui/rta/util/changeVisualization/ChangeCategories.js

@@ -11,12 +11,12 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var ChangeCategories = {};
+	const ChangeCategories = {};
 
 	ChangeCategories.ALL = "all";
 
 	// Assignment of commands to change categories
-	var COMMANDS = {};
+	const COMMANDS = {};
 	COMMANDS[FlChangeCategories.ADD] = [
 		"createContainer",
 		"addDelegateProperty",
@@ -29,7 +29,7 @@ sap.ui.define([
 	COMMANDS[FlChangeCategories.REMOVE] = ["remove"];
 	COMMANDS[FlChangeCategories.OTHER] = [];
 
-	var CATEGORY_ICONS = {};
+	const CATEGORY_ICONS = {};
 	CATEGORY_ICONS[ChangeCategories.ALL] = "sap-icon://show";
 	CATEGORY_ICONS[FlChangeCategories.ADD] = "sap-icon://add";
 	CATEGORY_ICONS[FlChangeCategories.MOVE] = "sap-icon://move";

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js

@@ -46,7 +46,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.136.4
+	 * @version 1.139.0
 	 * @private
 	 */
 	const ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js

@@ -37,7 +37,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry
 	 * @author SAP SE
 	 * @since 1.86.0
-	 * @version 1.136.4
+	 * @version 1.139.0
 	 * @private
 	 */
 	const ChangeIndicatorRegistry = ManagedObject.extend("sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry", {
@@ -293,10 +293,11 @@ sap.ui.define([
 
 	/**
 	 * Waits for the registered indicators to be rendered.
-	 * @returns {Promise} Resolves when all registered indicators are rendered.
+	 * @returns {Promise} Resolves when all visible indicators are rendered.
 	 */
 	ChangeIndicatorRegistry.prototype.waitForIndicatorRendering = function() {
-		return Promise.all(this.getChangeIndicators().map((oIndicator) => oIndicator.waitForRendering()));
+		const aVisibleIndicators = this.getChangeIndicators().filter((oIndicator) => oIndicator.getVisible());
+		return Promise.all(aVisibleIndicators.map((oIndicator) => oIndicator.waitForRendering()));
 	};
 
 	/**
@@ -348,4 +349,4 @@ sap.ui.define([
 	};
 
 	return ChangeIndicatorRegistry;
-});
+});

package/src/sap/ui/rta/util/changeVisualization/ChangeStates.js

@@ -4,12 +4,10 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
-sap.ui.define([
-], function(
-) {
+sap.ui.define([], function() {
 	"use strict";
 
-	var ChangeStates = {};
+	const ChangeStates = {};
 
 	ChangeStates.ALL = "all";
 	ChangeStates.DRAFT = "draft";

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js

@@ -84,7 +84,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeVisualization
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.136.4
+	 * @version 1.139.0
 	 * @private
 	 */
 	const ChangeVisualization = Control.extend("sap.ui.rta.util.changeVisualization.ChangeVisualization", {
@@ -133,7 +133,6 @@ sap.ui.define([
 			});
 			this._oChangeVisualizationModel.setDefaultBindingMode("TwoWay");
 			this._sSelectedChangeCategory = ChangeCategories.ALL;
-			this._bSetModeChanged = false;
 
 			// For the event handlers to work, the function instance has to remain stable
 			this._fnOnClickHandler = _onClick.bind(this);
@@ -266,10 +265,7 @@ sap.ui.define([
 
 		// Filter allRegisteredChanges for independent changes and get the ids
 		const aRegisteredIndependentChanges = aAllRegisteredChanges.filter(function(oChange) {
-			if (!oChange.dependent) {
-				return true;
-			}
-			return false;
+			return !oChange.dependent;
 		});
 
 		const oSortedChanges = this._determineChangeVisibility(
@@ -336,29 +332,21 @@ sap.ui.define([
 		return `${sBaseText} (${sStateText})`;
 	};
 
-	ChangeVisualization.prototype.openChangeCategorySelectionPopover = function(oEvent) {
+	ChangeVisualization.prototype.openChangeCategorySelectionPopover = async function(oEvent) {
 		// Event bubbled through the toolbar, get original source
-		this._oToolbarButton ||= Element.getElementById(oEvent.getParameter("id"));
-		const oPopover = this.getPopover();
+		this._oToolbarButton ||= Element.getElementById(oEvent?.getParameter("id"));
+		const oPopover = this.getPopover?.();
 
 		if (!oPopover) {
-			Fragment.load({
+			const oPopover = await Fragment.load({
 				name: "sap.ui.rta.util.changeVisualization.ChangeIndicatorCategorySelection",
 				id: `${this._oToolbarButton.sId}--ChangeIndicatorCategorySelection`,
 				controller: this
-			})
-			.then(function(oPopover) {
-				this._oToolbarButton.addDependent(oPopover);
-				oPopover.setModel(this._oChangeVisualizationModel, "visualizationModel");
-				oPopover.openBy(this._oToolbarButton);
-				this.setPopover(oPopover);
-				// Currently required because of an binding issue from the control
-				// At the first opening of the popover the controls don't get updated when the bound
-				// model changes. With the reopening this Problem gets fixed
-				// TODO Remove once control owners have fixed the issue
-				oPopover.close();
-				oPopover.openBy(this._oToolbarButton);
-			}.bind(this));
+			});
+			this._oToolbarButton.addDependent(oPopover);
+			oPopover.setModel(this._oChangeVisualizationModel, "visualizationModel");
+			oPopover.openBy(this._oToolbarButton);
+			this.setPopover(oPopover);
 			return;
 		}
 
@@ -633,7 +621,7 @@ sap.ui.define([
 		// Set the tabindex according the sorting
 		// Focus the first visible indicator
 		await this._oChangeIndicatorRegistry.waitForIndicatorRendering();
-		const aVisibleIndicators = [];
+
 		this._oChangeIndicatorRegistry.getChangeIndicators().forEach((oIndicator) => {
 			const oOverlay = OverlayRegistry.getOverlay(oIndicator.getOverlayId());
 			// As setting the focus happens asynchronously after rendering,
@@ -643,12 +631,12 @@ sap.ui.define([
 			}
 			if (oIndicator.getVisible()) {
 				oOverlay.setFocusable(true);
-				aVisibleIndicators.push(oIndicator);
 			} else {
 				oOverlay.setFocusable(false);
 			}
 		});
 
+		const aVisibleIndicators = this._oChangeIndicatorRegistry.getChangeIndicators().filter((oIndicator) => oIndicator.getVisible());
 		if (aVisibleIndicators.length > 0) {
 			aVisibleIndicators.sort(function(oIndicator1, oIndicator2) {
 				const iDeltaY = oIndicator1.getPosY() - oIndicator2.getPosY();

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualizationUtils.js

@@ -4,12 +4,10 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
-sap.ui.define([
-], function(
-) {
+sap.ui.define([], function() {
 	"use strict";
 
-	var ChangeVisualizationUtils = {};
+	const ChangeVisualizationUtils = {};
 
 	/**
 	 *
@@ -24,10 +22,10 @@ sap.ui.define([
 		if (!sString) {
 			return null;
 		}
-		var iStringLength = sString.length;
+		const iStringLength = sString.length;
 		if (iStringLength > 60) {
-			var sFirstPart = sString.substring(0, 27);
-			var sLastPart = sString.substring(iStringLength - 27);
+			const sFirstPart = sString.substring(0, 27);
+			const sLastPart = sString.substring(iStringLength - 27);
 			sString = `${sFirstPart}(...)${sLastPart}`;
 		}
 		return sString;

package/src/sap/ui/rta/util/changeVisualization/commands/CombineVisualization.js

@@ -19,9 +19,9 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
+	const oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
 
-	var CombineVisualization = {};
+	const CombineVisualization = {};
 
 	/**
 	 * Creates a localized description for combine changes based on the provided
@@ -35,7 +35,7 @@ sap.ui.define([
 	 * @returns {object} Map containing localized description text and tooltip
 	 */
 	CombineVisualization.getDescription = function(mPayload, sLabel, mPropertyBag) {
-		var iOriginalSelectorCount = (mPayload.originalSelectors || []).length;
+		const iOriginalSelectorCount = (mPayload.originalSelectors || []).length;
 		if (iOriginalSelectorCount < 2) {
 			// Fallback if no payload was provided
 			return {
@@ -50,14 +50,14 @@ sap.ui.define([
 			};
 		}
 
-		var oAppComponent = mPropertyBag.appComponent;
-		var aOriginalSelectors = mPayload.originalSelectors;
-		var aLabels = aOriginalSelectors.map(function(oSelector) {
-			var sId = JsControlTreeModifier.getControlIdBySelector(oSelector, oAppComponent);
-			var oControl = Element.getElementById(sId);
+		const oAppComponent = mPropertyBag.appComponent;
+		const aOriginalSelectors = mPayload.originalSelectors;
+		const aLabels = aOriginalSelectors.map(function(oSelector) {
+			const sId = JsControlTreeModifier.getControlIdBySelector(oSelector, oAppComponent);
+			const oControl = Element.getElementById(sId);
 			return oControl ? ElementUtil.getLabelForElement(oControl) : sId;
 		});
-		var aShortLabels = aLabels.map(ChangeVisualizationUtils.shortenString);
+		const aShortLabels = aLabels.map(ChangeVisualizationUtils.shortenString);
 
 		if (iOriginalSelectorCount === 2) {
 			return {

package/src/sap/ui/rta/util/changeVisualization/commands/CreateContainerVisualization.js

@@ -13,7 +13,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var CreateContainerVisualization = {};
+	const CreateContainerVisualization = {};
 
 	/**
 	 * Creates a localized description for create container, based on the provided
@@ -25,10 +25,10 @@ sap.ui.define([
 	 * @returns {object} Map containing localized description text and tooltip
 	 */
 	CreateContainerVisualization.getDescription = function(mPayload, sLabel) {
-		var oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
-		var sElementLabel = mPayload.originalLabel || sLabel;
-		var sShortenedElementLabel = ChangeVisualizationUtils.shortenString(sElementLabel);
-		var sTextKey = "TXT_CHANGEVISUALIZATION_CHANGE_CREATECONTAINER";
+		const oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
+		const sElementLabel = mPayload.originalLabel || sLabel;
+		const sShortenedElementLabel = ChangeVisualizationUtils.shortenString(sElementLabel);
+		const sTextKey = "TXT_CHANGEVISUALIZATION_CHANGE_CREATECONTAINER";
 		return {
 			descriptionText: oRtaResourceBundle.getText(sTextKey, [sShortenedElementLabel]),
 			descriptionTooltip: oRtaResourceBundle.getText(sTextKey, [sElementLabel])

package/src/sap/ui/rta/util/changeVisualization/commands/MoveVisualization.js

@@ -15,7 +15,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var MoveVisualization = {};
+	const MoveVisualization = {};
 
 	/**
 	 * Creates a localized description and button text for move changes based on the provided
@@ -29,17 +29,17 @@ sap.ui.define([
 	 * @returns {object} Localized description text and button text
 	 */
 	MoveVisualization.getDescription = function(mPayload, sLabel, mPropertyBag) {
-		var oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
-		var sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE_WITHIN", [ChangeVisualizationUtils.shortenString(sLabel)]);
-		var sDescriptionTooltip = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE_WITHIN", [sLabel]);
-		var sButtonText;
-		var oAppComponent = mPropertyBag.appComponent;
+		const oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
+		let sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE_WITHIN", [ChangeVisualizationUtils.shortenString(sLabel)]);
+		let sDescriptionTooltip = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE_WITHIN", [sLabel]);
+		let sButtonText;
+		const oAppComponent = mPropertyBag.appComponent;
 
-		var sSourceId = (
+		const sSourceId = (
 			mPayload.sourceContainer
 			&& JsControlTreeModifier.getControlIdBySelector(mPayload.sourceContainer, oAppComponent)
 		);
-		var sTargetId = (
+		const sTargetId = (
 			mPayload.targetContainer
 			&& JsControlTreeModifier.getControlIdBySelector(mPayload.targetContainer, oAppComponent)
 		);

package/src/sap/ui/rta/util/changeVisualization/commands/RenameVisualization.js

@@ -13,7 +13,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var RenameVisualization = {};
+	const RenameVisualization = {};
 
 	/**
 	 * Creates a localized description for rename changes based on the provided
@@ -26,18 +26,18 @@ sap.ui.define([
 	 * @returns {object} Localized description
 	 */
 	RenameVisualization.getDescription = function(mPayload, sFallbackLabel) {
-		var oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
-		var sKey = mPayload.originalLabel
+		const oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
+		const sKey = mPayload.originalLabel
 			? "TXT_CHANGEVISUALIZATION_CHANGE_RENAME_FROM_TO"
 			: "TXT_CHANGEVISUALIZATION_CHANGE_RENAME_TO";
-		var sDescriptionText = oRtaResourceBundle.getText(
+		const sDescriptionText = oRtaResourceBundle.getText(
 			sKey,
 			[
 				ChangeVisualizationUtils.shortenString(mPayload.newLabel) || sFallbackLabel,
 				ChangeVisualizationUtils.shortenString(mPayload.originalLabel)
 			]
 		);
-		var sDescriptionTooltip = oRtaResourceBundle.getText(
+		const sDescriptionTooltip = oRtaResourceBundle.getText(
 			sKey,
 			[
 				mPayload.newLabel || sFallbackLabel,

package/src/sap/ui/rta/util/changeVisualization/commands/SplitVisualization.js

@@ -13,7 +13,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var SplitVisualization = {};
+	const SplitVisualization = {};
 
 	/**
 	 * Creates a localized description and button text for split changes based on the provided
@@ -24,10 +24,10 @@ sap.ui.define([
 	 * @returns {object} Localized description text and button text
 	 */
 	SplitVisualization.getDescription = function(mPayload, sLabel) {
-		var oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
-		var sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_SPLIT", [ChangeVisualizationUtils.shortenString(sLabel)]);
-		var sDescriptionTooltip = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_SPLIT", [sLabel]);
-		var sButtonText = oRtaResourceBundle.getText("BTN_CHANGEVISUALIZATION_SHOW_DEPENDENT_CONTAINER_SPLIT");
+		const oRtaResourceBundle = Lib.getResourceBundleFor("sap.ui.rta");
+		const sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_SPLIT", [ChangeVisualizationUtils.shortenString(sLabel)]);
+		const sDescriptionTooltip = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_SPLIT", [sLabel]);
+		const sButtonText = oRtaResourceBundle.getText("BTN_CHANGEVISUALIZATION_SHOW_DEPENDENT_CONTAINER_SPLIT");
 		return { descriptionText: sDescriptionText, descriptionTooltip: sDescriptionTooltip, buttonText: sButtonText};
 	};
 

package/src/sap/ui/rta/util/changeVisualization/commands/getCommandVisualization.js

@@ -19,7 +19,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var mCommands = {
+	const mCommands = {
 		rename: RenameVisualization,
 		move: MoveVisualization,
 		combine: CombineVisualization,
@@ -28,7 +28,7 @@ sap.ui.define([
 	};
 
 	return function(mIndicatorInformation) {
-		var sCommandName = mIndicatorInformation.commandName;
+		let sCommandName = mIndicatorInformation.commandName;
 
 		// Settings commands can be assigned to existing categories
 		// (e.g. "move" to display the "Show Source" button)