@heyai-rules/pilo-masterkit 2.1.0 → 3.1.0

package/.agent/workflows/rust-build.md

@@ -1,187 +1,187 @@
----
-description: Fix Rust build errors, borrow checker issues, and dependency problems incrementally. Invokes the rust-build-resolver agent for minimal, surgical fixes.
----
-
-# Rust Build and Fix
-
-This command invokes the **rust-build-resolver** agent to incrementally fix Rust build errors with minimal changes.
-
-## What This Command Does
-
-1. **Run Diagnostics**: Execute `cargo check`, `cargo clippy`, `cargo fmt --check`
-2. **Parse Errors**: Identify error codes and affected files
-3. **Fix Incrementally**: One error at a time
-4. **Verify Each Fix**: Re-run `cargo check` after each change
-5. **Report Summary**: Show what was fixed and what remains
-
-## When to Use
-
-Use `/rust-build` when:
-- `cargo build` or `cargo check` fails with errors
-- `cargo clippy` reports warnings
-- Borrow checker or lifetime errors block compilation
-- Cargo dependency resolution fails
-- After pulling changes that break the build
-
-## Diagnostic Commands Run
-
-```bash
-# Primary build check
-cargo check 2>&1
-
-# Lints and suggestions
-cargo clippy -- -D warnings 2>&1
-
-# Formatting check
-cargo fmt --check 2>&1
-
-# Dependency issues
-cargo tree --duplicates
-
-# Security audit (if available)
-if command -v cargo-audit >/dev/null; then cargo audit; else echo "cargo-audit not installed"; fi
-```
-
-## Example Session
-
-````text
-User: /rust-build
-
-Agent:
-# Rust Build Resolution
-
-## Initial Diagnostics
-
-```bash
-$ cargo check
-error[E0502]: cannot borrow `map` as mutable because it is also borrowed as immutable
-  --> src/service/cache.rs:25:5
-error[E0308]: mismatched types
-  --> src/handler/api.rs:42:12
-error[E0425]: cannot find value `db` in this scope
-  --> src/handler/api.rs:58:9
-```
-
-Errors found: 3
-
-## Fix 1: Borrow Checker Error
-
-File: src/service/cache.rs:25
-Error: E0502 — cannot borrow `map` as mutable because also borrowed as immutable
-Cause: Immutable borrow still active during mutable insert
-
-```rust
-// Changed: restructured to end immutable borrow before mutable access
-if !map.contains_key("key") {
-    map.insert("key".into(), default);
-}
-```
-
-```bash
-$ cargo check
-# 2 errors remaining
-```
-
-## Fix 2: Type Mismatch
-
-File: src/handler/api.rs:42
-Error: E0308 — mismatched types: expected `usize`, found `&str`
-
-```rust
-// Changed
-let count = params.get("count");
-// To
-let count: usize = params.get("count")
-    .and_then(|s| s.parse().ok())
-    .unwrap_or(0);
-```
-
-```bash
-$ cargo check
-# 1 error remaining
-```
-
-## Fix 3: Unresolved Name
-
-File: src/handler/api.rs:58
-Error: E0425 — cannot find value `db` in this scope
-Cause: Missing import
-
-```rust
-// Added
-use crate::db;
-```
-
-```bash
-$ cargo check
-# Build successful!
-```
-
-## Final Verification
-
-```bash
-$ cargo clippy -- -D warnings
-# No warnings
-
-$ cargo test
-running 6 tests
-test service::cache::tests::test_insert ... ok
-test service::cache::tests::test_get ... ok
-test handler::api::tests::test_parse_count ... ok
-test handler::api::tests::test_missing_count ... ok
-test handler::api::tests::test_db_import ... ok
-test handler::api::tests::test_response ... ok
-
-test result: ok. 6 passed; 0 failed; 0 ignored
-```
-
-## Summary
-
-| Metric | Count |
-|--------|-------|
-| Build errors fixed | 3 |
-| Clippy warnings fixed | 0 |
-| Files modified | 2 |
-| Remaining issues | 0 |
-
-Build Status: SUCCESS
-````
-
-## Common Errors Fixed
-
-| Error | Typical Fix |
-|-------|-------------|
-| `cannot borrow as mutable` | Restructure to end immutable borrow first; clone only if justified |
-| `does not live long enough` | Use owned type or add lifetime annotation |
-| `cannot move out of` | Restructure to take ownership; clone only as last resort |
-| `mismatched types` | Add `.into()`, `as`, or explicit conversion |
-| `trait X not implemented` | Add `#[derive(Trait)]` or implement manually |
-| `unresolved import` | Add to Cargo.toml or fix `use` path |
-| `cannot find value` | Add import or fix path |
-
-## Fix Strategy
-
-1. **Build errors first** - Code must compile
-2. **Clippy warnings second** - Fix suspicious constructs
-3. **Formatting third** - `cargo fmt` compliance
-4. **One fix at a time** - Verify each change
-5. **Minimal changes** - Don't refactor, just fix
-
-## Stop Conditions
-
-The agent will stop and report if:
-- Same error persists after 3 attempts
-- Fix introduces more errors
-- Requires architectural changes
-- Borrow checker error requires redesigning data ownership
-
-## Related Commands
-
-- `/rust-test` - Run tests after build succeeds
-- `/rust-review` - Review code quality
-- `/verify` - Full verification loop
-
-## Related
-
-- Agent: `agents/rust-build-resolver.md`
-- Skill: `skills/rust-patterns/`
+---
+description: Fix Rust build errors, borrow checker issues, and dependency problems incrementally. Invokes the rust-build-resolver agent for minimal, surgical fixes.
+---
+
+# Rust Build and Fix
+
+This command invokes the **rust-build-resolver** agent to incrementally fix Rust build errors with minimal changes.
+
+## What This Command Does
+
+1. **Run Diagnostics**: Execute `cargo check`, `cargo clippy`, `cargo fmt --check`
+2. **Parse Errors**: Identify error codes and affected files
+3. **Fix Incrementally**: One error at a time
+4. **Verify Each Fix**: Re-run `cargo check` after each change
+5. **Report Summary**: Show what was fixed and what remains
+
+## When to Use
+
+Use `/rust-build` when:
+- `cargo build` or `cargo check` fails with errors
+- `cargo clippy` reports warnings
+- Borrow checker or lifetime errors block compilation
+- Cargo dependency resolution fails
+- After pulling changes that break the build
+
+## Diagnostic Commands Run
+
+```bash
+# Primary build check
+cargo check 2>&1
+
+# Lints and suggestions
+cargo clippy -- -D warnings 2>&1
+
+# Formatting check
+cargo fmt --check 2>&1
+
+# Dependency issues
+cargo tree --duplicates
+
+# Security audit (if available)
+if command -v cargo-audit >/dev/null; then cargo audit; else echo "cargo-audit not installed"; fi
+```
+
+## Example Session
+
+````text
+User: /rust-build
+
+Agent:
+# Rust Build Resolution
+
+## Initial Diagnostics
+
+```bash
+$ cargo check
+error[E0502]: cannot borrow `map` as mutable because it is also borrowed as immutable
+  --> src/service/cache.rs:25:5
+error[E0308]: mismatched types
+  --> src/handler/api.rs:42:12
+error[E0425]: cannot find value `db` in this scope
+  --> src/handler/api.rs:58:9
+```
+
+Errors found: 3
+
+## Fix 1: Borrow Checker Error
+
+File: src/service/cache.rs:25
+Error: E0502 — cannot borrow `map` as mutable because also borrowed as immutable
+Cause: Immutable borrow still active during mutable insert
+
+```rust
+// Changed: restructured to end immutable borrow before mutable access
+if !map.contains_key("key") {
+    map.insert("key".into(), default);
+}
+```
+
+```bash
+$ cargo check
+# 2 errors remaining
+```
+
+## Fix 2: Type Mismatch
+
+File: src/handler/api.rs:42
+Error: E0308 — mismatched types: expected `usize`, found `&str`
+
+```rust
+// Changed
+let count = params.get("count");
+// To
+let count: usize = params.get("count")
+    .and_then(|s| s.parse().ok())
+    .unwrap_or(0);
+```
+
+```bash
+$ cargo check
+# 1 error remaining
+```
+
+## Fix 3: Unresolved Name
+
+File: src/handler/api.rs:58
+Error: E0425 — cannot find value `db` in this scope
+Cause: Missing import
+
+```rust
+// Added
+use crate::db;
+```
+
+```bash
+$ cargo check
+# Build successful!
+```
+
+## Final Verification
+
+```bash
+$ cargo clippy -- -D warnings
+# No warnings
+
+$ cargo test
+running 6 tests
+test service::cache::tests::test_insert ... ok
+test service::cache::tests::test_get ... ok
+test handler::api::tests::test_parse_count ... ok
+test handler::api::tests::test_missing_count ... ok
+test handler::api::tests::test_db_import ... ok
+test handler::api::tests::test_response ... ok
+
+test result: ok. 6 passed; 0 failed; 0 ignored
+```
+
+## Summary
+
+| Metric | Count |
+|--------|-------|
+| Build errors fixed | 3 |
+| Clippy warnings fixed | 0 |
+| Files modified | 2 |
+| Remaining issues | 0 |
+
+Build Status: SUCCESS
+````
+
+## Common Errors Fixed
+
+| Error | Typical Fix |
+|-------|-------------|
+| `cannot borrow as mutable` | Restructure to end immutable borrow first; clone only if justified |
+| `does not live long enough` | Use owned type or add lifetime annotation |
+| `cannot move out of` | Restructure to take ownership; clone only as last resort |
+| `mismatched types` | Add `.into()`, `as`, or explicit conversion |
+| `trait X not implemented` | Add `#[derive(Trait)]` or implement manually |
+| `unresolved import` | Add to Cargo.toml or fix `use` path |
+| `cannot find value` | Add import or fix path |
+
+## Fix Strategy
+
+1. **Build errors first** - Code must compile
+2. **Clippy warnings second** - Fix suspicious constructs
+3. **Formatting third** - `cargo fmt` compliance
+4. **One fix at a time** - Verify each change
+5. **Minimal changes** - Don't refactor, just fix
+
+## Stop Conditions
+
+The agent will stop and report if:
+- Same error persists after 3 attempts
+- Fix introduces more errors
+- Requires architectural changes
+- Borrow checker error requires redesigning data ownership
+
+## Related Commands
+
+- `/rust-test` - Run tests after build succeeds
+- `/rust-review` - Review code quality
+- `/verify` - Full verification loop
+
+## Related
+
+- Agent: `agents/rust-build-resolver.md`
+- Skill: `skills/rust-patterns/`

package/.agent/workflows/rust-review.md

@@ -1,142 +1,142 @@
----
-description: Comprehensive Rust code review for ownership, lifetimes, error handling, unsafe usage, and idiomatic patterns. Invokes the rust-reviewer agent.
----
-
-# Rust Code Review
-
-This command invokes the **rust-reviewer** agent for comprehensive Rust-specific code review.
-
-## What This Command Does
-
-1. **Verify Automated Checks**: Run `cargo check`, `cargo clippy -- -D warnings`, `cargo fmt --check`, and `cargo test` — stop if any fail
-2. **Identify Rust Changes**: Find modified `.rs` files via `git diff HEAD~1` (or `git diff main...HEAD` for PRs)
-3. **Run Security Audit**: Execute `cargo audit` if available
-4. **Security Scan**: Check for unsafe usage, command injection, hardcoded secrets
-5. **Ownership Review**: Analyze unnecessary clones, lifetime issues, borrowing patterns
-6. **Generate Report**: Categorize issues by severity
-
-## When to Use
-
-Use `/rust-review` when:
-- After writing or modifying Rust code
-- Before committing Rust changes
-- Reviewing pull requests with Rust code
-- Onboarding to a new Rust codebase
-- Learning idiomatic Rust patterns
-
-## Review Categories
-
-### CRITICAL (Must Fix)
-- Unchecked `unwrap()`/`expect()` in production code paths
-- `unsafe` without `// SAFETY:` comment documenting invariants
-- SQL injection via string interpolation in queries
-- Command injection via unvalidated input in `std::process::Command`
-- Hardcoded credentials
-- Use-after-free via raw pointers
-
-### HIGH (Should Fix)
-- Unnecessary `.clone()` to satisfy borrow checker
-- `String` parameter where `&str` or `impl AsRef<str>` suffices
-- Blocking in async context (`std::thread::sleep`, `std::fs`)
-- Missing `Send`/`Sync` bounds on shared types
-- Wildcard `_ =>` match on business-critical enums
-- Large functions (>50 lines)
-
-### MEDIUM (Consider)
-- Unnecessary allocation in hot paths
-- Missing `with_capacity` when size is known
-- Suppressed clippy warnings without justification
-- Public API without `///` documentation
-- Consider `#[must_use]` on non-`must_use` return types where ignoring values is likely a bug
-
-## Automated Checks Run
-
-```bash
-# Build gate (must pass before review)
-cargo check
-
-# Lints and suggestions
-cargo clippy -- -D warnings
-
-# Formatting
-cargo fmt --check
-
-# Tests
-cargo test
-
-# Security audit (if available)
-if command -v cargo-audit >/dev/null; then cargo audit; else echo "cargo-audit not installed"; fi
-```
-
-## Example Usage
-
-````text
-User: /rust-review
-
-Agent:
-# Rust Code Review Report
-
-## Files Reviewed
-- src/service/user.rs (modified)
-- src/handler/api.rs (modified)
-
-## Static Analysis Results
-- Build: Successful
-- Clippy: No warnings
-- Formatting: Passed
-- Tests: All passing
-
-## Issues Found
-
-[CRITICAL] Unchecked unwrap in Production Path
-File: src/service/user.rs:28
-Issue: Using `.unwrap()` on database query result
-```rust
-let user = db.find_by_id(id).unwrap();  // Panics on missing user
-```
-Fix: Propagate error with context
-```rust
-let user = db.find_by_id(id)
-    .context("failed to fetch user")?;
-```
-
-[HIGH] Unnecessary Clone
-File: src/handler/api.rs:45
-Issue: Cloning String to satisfy borrow checker
-```rust
-let name = user.name.clone();
-process(&user, &name);
-```
-Fix: Restructure to avoid clone
-```rust
-let result = process_name(&user.name);
-use_user(&user, result);
-```
-
-## Summary
-- CRITICAL: 1
-- HIGH: 1
-- MEDIUM: 0
-
-Recommendation: Block merge until CRITICAL issue is fixed
-````
-
-## Approval Criteria
-
-| Status | Condition |
-|--------|-----------|
-| Approve | No CRITICAL or HIGH issues |
-| Warning | Only MEDIUM issues (merge with caution) |
-| Block | CRITICAL or HIGH issues found |
-
-## Integration with Other Commands
-
-- Use `/rust-test` first to ensure tests pass
-- Use `/rust-build` if build errors occur
-- Use `/rust-review` before committing
-- Use `/code-review` for non-Rust-specific concerns
-
-## Related
-
-- Agent: `agents/rust-reviewer.md`
-- Skills: `skills/rust-patterns/`, `skills/rust-testing/`
+---
+description: Comprehensive Rust code review for ownership, lifetimes, error handling, unsafe usage, and idiomatic patterns. Invokes the rust-reviewer agent.
+---
+
+# Rust Code Review
+
+This command invokes the **rust-reviewer** agent for comprehensive Rust-specific code review.
+
+## What This Command Does
+
+1. **Verify Automated Checks**: Run `cargo check`, `cargo clippy -- -D warnings`, `cargo fmt --check`, and `cargo test` — stop if any fail
+2. **Identify Rust Changes**: Find modified `.rs` files via `git diff HEAD~1` (or `git diff main...HEAD` for PRs)
+3. **Run Security Audit**: Execute `cargo audit` if available
+4. **Security Scan**: Check for unsafe usage, command injection, hardcoded secrets
+5. **Ownership Review**: Analyze unnecessary clones, lifetime issues, borrowing patterns
+6. **Generate Report**: Categorize issues by severity
+
+## When to Use
+
+Use `/rust-review` when:
+- After writing or modifying Rust code
+- Before committing Rust changes
+- Reviewing pull requests with Rust code
+- Onboarding to a new Rust codebase
+- Learning idiomatic Rust patterns
+
+## Review Categories
+
+### CRITICAL (Must Fix)
+- Unchecked `unwrap()`/`expect()` in production code paths
+- `unsafe` without `// SAFETY:` comment documenting invariants
+- SQL injection via string interpolation in queries
+- Command injection via unvalidated input in `std::process::Command`
+- Hardcoded credentials
+- Use-after-free via raw pointers
+
+### HIGH (Should Fix)
+- Unnecessary `.clone()` to satisfy borrow checker
+- `String` parameter where `&str` or `impl AsRef<str>` suffices
+- Blocking in async context (`std::thread::sleep`, `std::fs`)
+- Missing `Send`/`Sync` bounds on shared types
+- Wildcard `_ =>` match on business-critical enums
+- Large functions (>50 lines)
+
+### MEDIUM (Consider)
+- Unnecessary allocation in hot paths
+- Missing `with_capacity` when size is known
+- Suppressed clippy warnings without justification
+- Public API without `///` documentation
+- Consider `#[must_use]` on non-`must_use` return types where ignoring values is likely a bug
+
+## Automated Checks Run
+
+```bash
+# Build gate (must pass before review)
+cargo check
+
+# Lints and suggestions
+cargo clippy -- -D warnings
+
+# Formatting
+cargo fmt --check
+
+# Tests
+cargo test
+
+# Security audit (if available)
+if command -v cargo-audit >/dev/null; then cargo audit; else echo "cargo-audit not installed"; fi
+```
+
+## Example Usage
+
+````text
+User: /rust-review
+
+Agent:
+# Rust Code Review Report
+
+## Files Reviewed
+- src/service/user.rs (modified)
+- src/handler/api.rs (modified)
+
+## Static Analysis Results
+- Build: Successful
+- Clippy: No warnings
+- Formatting: Passed
+- Tests: All passing
+
+## Issues Found
+
+[CRITICAL] Unchecked unwrap in Production Path
+File: src/service/user.rs:28
+Issue: Using `.unwrap()` on database query result
+```rust
+let user = db.find_by_id(id).unwrap();  // Panics on missing user
+```
+Fix: Propagate error with context
+```rust
+let user = db.find_by_id(id)
+    .context("failed to fetch user")?;
+```
+
+[HIGH] Unnecessary Clone
+File: src/handler/api.rs:45
+Issue: Cloning String to satisfy borrow checker
+```rust
+let name = user.name.clone();
+process(&user, &name);
+```
+Fix: Restructure to avoid clone
+```rust
+let result = process_name(&user.name);
+use_user(&user, result);
+```
+
+## Summary
+- CRITICAL: 1
+- HIGH: 1
+- MEDIUM: 0
+
+Recommendation: Block merge until CRITICAL issue is fixed
+````
+
+## Approval Criteria
+
+| Status | Condition |
+|--------|-----------|
+| Approve | No CRITICAL or HIGH issues |
+| Warning | Only MEDIUM issues (merge with caution) |
+| Block | CRITICAL or HIGH issues found |
+
+## Integration with Other Commands
+
+- Use `/rust-test` first to ensure tests pass
+- Use `/rust-build` if build errors occur
+- Use `/rust-review` before committing
+- Use `/code-review` for non-Rust-specific concerns
+
+## Related
+
+- Agent: `agents/rust-reviewer.md`
+- Skills: `skills/rust-patterns/`, `skills/rust-testing/`