@dizzlkheinz/ynab-mcpb 0.18.3 → 0.19.0

package/src/server/__tests__/resources.template.test.ts

@@ -1,198 +1,209 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { ResourceManager } from '../resources.js';
-import type { CacheManager } from '../cacheManager.js';
-import type * as ynab from 'ynab';
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import type * as ynab from "ynab";
+import type { CacheManager } from "../cacheManager.js";
+import { ResourceManager } from "../resources.js";
 
 // Mock YNAB API
 const mockYnabAPI = {
-  budgets: {
-    getBudgets: vi.fn(),
-    getBudgetById: vi.fn(),
-  },
-  accounts: {
-    getAccounts: vi.fn(),
-    getAccountById: vi.fn(),
-  },
-  user: {
-    getUser: vi.fn(),
-  },
+	budgets: {
+		getBudgets: vi.fn(),
+		getBudgetById: vi.fn(),
+	},
+	accounts: {
+		getAccounts: vi.fn(),
+		getAccountById: vi.fn(),
+	},
+	user: {
+		getUser: vi.fn(),
+	},
 } as unknown as ynab.API;
 
 // Mock Response Formatter
 const mockResponseFormatter = {
-  format: vi.fn((data) => JSON.stringify(data)),
+	format: vi.fn((data) => JSON.stringify(data)),
 };
 
 const mockCacheManager = {
-  wrap: vi.fn(async (_key, { loader }) => loader()),
+	wrap: vi.fn(async (_key, { loader }) => loader()),
 } as unknown as CacheManager;
 
-describe('ResourceManager Templates', () => {
-  let resourceManager: ResourceManager;
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-    resourceManager = new ResourceManager({
-      ynabAPI: mockYnabAPI,
-      responseFormatter: mockResponseFormatter,
-      cacheManager: mockCacheManager,
-    });
-  });
-
-  it('should list resource templates', () => {
-    const templates = resourceManager.listResourceTemplates();
-    expect(templates.resourceTemplates.length).toBeGreaterThan(0);
-    expect(templates.resourceTemplates).toEqual(
-      expect.arrayContaining([
-        expect.objectContaining({
-          uriTemplate: 'ynab://budgets/{budget_id}',
-          name: 'Budget Details',
-        }),
-        expect.objectContaining({
-          uriTemplate: 'ynab://budgets/{budget_id}/accounts',
-          name: 'Budget Accounts',
-        }),
-      ]),
-    );
-  });
-
-  it('should match and handle budget details template', async () => {
-    const budgetId = 'test-budget-id';
-    const mockBudget = { id: budgetId, name: 'Test Budget' };
-
-    (mockYnabAPI.budgets.getBudgetById as any).mockResolvedValue({
-      data: { budget: mockBudget },
-    });
-
-    const uri = `ynab://budgets/${budgetId}`;
-    const result = await resourceManager.readResource(uri);
-
-    expect(mockYnabAPI.budgets.getBudgetById).toHaveBeenCalledWith(budgetId);
-    expect(result.contents).toHaveLength(1);
-    expect(result.contents[0].uri).toBe(uri);
-    expect(JSON.parse(result.contents[0].text)).toEqual(mockBudget);
-  });
-
-  it('should match and handle budget accounts template', async () => {
-    const budgetId = 'test-budget-id';
-    const mockAccounts = [{ id: 'acc1', name: 'Checking' }];
-
-    (mockYnabAPI.accounts.getAccounts as any).mockResolvedValue({
-      data: { accounts: mockAccounts },
-    });
-
-    const uri = `ynab://budgets/${budgetId}/accounts`;
-    const result = await resourceManager.readResource(uri);
-
-    expect(mockYnabAPI.accounts.getAccounts).toHaveBeenCalledWith(budgetId);
-    expect(result.contents).toHaveLength(1);
-    expect(JSON.parse(result.contents[0].text)).toEqual(mockAccounts);
-  });
-
-  it('should match and handle specific account template', async () => {
-    const budgetId = 'test-budget-id';
-    const accountId = 'test-account-id';
-    const mockAccount = { id: accountId, name: 'Savings' };
-
-    (mockYnabAPI.accounts.getAccountById as any).mockResolvedValue({
-      data: { account: mockAccount },
-    });
-
-    const uri = `ynab://budgets/${budgetId}/accounts/${accountId}`;
-    const result = await resourceManager.readResource(uri);
-
-    expect(mockYnabAPI.accounts.getAccountById).toHaveBeenCalledWith(budgetId, accountId);
-    expect(result.contents).toHaveLength(1);
-    expect(JSON.parse(result.contents[0].text)).toEqual(mockAccount);
-  });
-
-  it('should fallback to throwing error for unknown URIs', async () => {
-    const uri = 'ynab://unknown/resource';
-    await expect(resourceManager.readResource(uri)).rejects.toThrow(
-      'Resource not found: ynab://unknown/resource',
-    );
-  });
-
-  it('should prefer static resources over templates when both match (though unlikely with current design)', async () => {
-    // Assuming 'ynab://budgets' is a static resource
-    const mockBudgetsList = [{ id: 'b1', name: 'B1' }];
-    (mockYnabAPI.budgets.getBudgets as any).mockResolvedValue({
-      data: { budgets: mockBudgetsList },
-    });
-
-    const uri = 'ynab://budgets';
-    const result = await resourceManager.readResource(uri);
-
-    // Should call getBudgets (static), not getBudgetById (template)
-    expect(mockYnabAPI.budgets.getBudgets).toHaveBeenCalled();
-    expect(mockYnabAPI.budgets.getBudgetById).not.toHaveBeenCalled();
-    expect(JSON.parse(result.contents[0].text)).toEqual({ budgets: expect.any(Array) });
-  });
-
-  // Error handling tests
-  describe('Error Handling', () => {
-    it('should handle API errors gracefully for template resources', async () => {
-      (mockYnabAPI.budgets.getBudgetById as any).mockRejectedValue(new Error('Budget not found'));
-
-      await expect(resourceManager.readResource('ynab://budgets/invalid-id')).rejects.toThrow(
-        'Failed to read resource ynab://budgets/invalid-id: Failed to fetch budget invalid-id: Budget not found',
-      );
-    });
-
-    it('should handle API errors for account templates', async () => {
-      (mockYnabAPI.accounts.getAccountById as any).mockRejectedValue(
-        new Error('Account not found'),
-      );
-
-      await expect(
-        resourceManager.readResource('ynab://budgets/budget-id/accounts/invalid-account'),
-      ).rejects.toThrow(
-        'Failed to read resource ynab://budgets/budget-id/accounts/invalid-account: Failed to fetch account invalid-account in budget budget-id: Account not found',
-      );
-    });
-
-    it('should reject URIs with backslash characters', async () => {
-      await expect(resourceManager.readResource('ynab://budgets/test\\bad')).rejects.toThrow(
-        'Invalid parameter value',
-      );
-    });
-
-    it('should reject URIs with double-dot sequences in parameters', async () => {
-      await expect(resourceManager.readResource('ynab://budgets/test../accounts')).rejects.toThrow(
-        'Invalid parameter value',
-      );
-    });
-  });
-
-  // Template validation tests
-  describe('Template Validation', () => {
-    it('should validate template format when registering', async () => {
-      // This test verifies that malformed templates are caught
-      const maliciousTemplate = {
-        uriTemplate: 'ynab://budgets/{budget_id}$(malicious)',
-        name: 'Malicious Template',
-        description: 'Should be rejected',
-        mimeType: 'application/json',
-        handler: async () => [],
-      };
-
-      expect(() => resourceManager.registerTemplate(maliciousTemplate)).toThrow(
-        'Invalid template format: contains unsafe characters',
-      );
-    });
-
-    it('should reject template registration with invalid parameter names', () => {
-      const invalidParamTemplate = {
-        uriTemplate: 'ynab://budgets/{Budget-Id}',
-        name: 'Invalid Param Template',
-        description: 'Should be rejected due to invalid param casing',
-        mimeType: 'application/json',
-        handler: async () => [],
-      };
-
-      expect(() => resourceManager.registerTemplate(invalidParamTemplate)).toThrow(
-        "Invalid template parameter name 'Budget-Id'",
-      );
-    });
-  });
+describe("ResourceManager Templates", () => {
+	let resourceManager: ResourceManager;
+
+	beforeEach(() => {
+		vi.clearAllMocks();
+		resourceManager = new ResourceManager({
+			ynabAPI: mockYnabAPI,
+			responseFormatter: mockResponseFormatter,
+			cacheManager: mockCacheManager,
+		});
+	});
+
+	it("should list resource templates", () => {
+		const templates = resourceManager.listResourceTemplates();
+		expect(templates.resourceTemplates.length).toBeGreaterThan(0);
+		expect(templates.resourceTemplates).toEqual(
+			expect.arrayContaining([
+				expect.objectContaining({
+					uriTemplate: "ynab://budgets/{budget_id}",
+					name: "Budget Details",
+				}),
+				expect.objectContaining({
+					uriTemplate: "ynab://budgets/{budget_id}/accounts",
+					name: "Budget Accounts",
+				}),
+			]),
+		);
+	});
+
+	it("should match and handle budget details template", async () => {
+		const budgetId = "test-budget-id";
+		const mockBudget = { id: budgetId, name: "Test Budget" };
+
+		(mockYnabAPI.budgets.getBudgetById as any).mockResolvedValue({
+			data: { budget: mockBudget },
+		});
+
+		const uri = `ynab://budgets/${budgetId}`;
+		const result = await resourceManager.readResource(uri);
+
+		expect(mockYnabAPI.budgets.getBudgetById).toHaveBeenCalledWith(budgetId);
+		expect(result.contents).toHaveLength(1);
+		expect(result.contents[0].uri).toBe(uri);
+		expect(JSON.parse(result.contents[0].text)).toEqual(mockBudget);
+	});
+
+	it("should match and handle budget accounts template", async () => {
+		const budgetId = "test-budget-id";
+		const mockAccounts = [{ id: "acc1", name: "Checking" }];
+
+		(mockYnabAPI.accounts.getAccounts as any).mockResolvedValue({
+			data: { accounts: mockAccounts },
+		});
+
+		const uri = `ynab://budgets/${budgetId}/accounts`;
+		const result = await resourceManager.readResource(uri);
+
+		expect(mockYnabAPI.accounts.getAccounts).toHaveBeenCalledWith(budgetId);
+		expect(result.contents).toHaveLength(1);
+		expect(JSON.parse(result.contents[0].text)).toEqual(mockAccounts);
+	});
+
+	it("should match and handle specific account template", async () => {
+		const budgetId = "test-budget-id";
+		const accountId = "test-account-id";
+		const mockAccount = { id: accountId, name: "Savings" };
+
+		(mockYnabAPI.accounts.getAccountById as any).mockResolvedValue({
+			data: { account: mockAccount },
+		});
+
+		const uri = `ynab://budgets/${budgetId}/accounts/${accountId}`;
+		const result = await resourceManager.readResource(uri);
+
+		expect(mockYnabAPI.accounts.getAccountById).toHaveBeenCalledWith(
+			budgetId,
+			accountId,
+		);
+		expect(result.contents).toHaveLength(1);
+		expect(JSON.parse(result.contents[0].text)).toEqual(mockAccount);
+	});
+
+	it("should fallback to throwing error for unknown URIs", async () => {
+		const uri = "ynab://unknown/resource";
+		await expect(resourceManager.readResource(uri)).rejects.toThrow(
+			"Resource not found: ynab://unknown/resource",
+		);
+	});
+
+	it("should prefer static resources over templates when both match (though unlikely with current design)", async () => {
+		// Assuming 'ynab://budgets' is a static resource
+		const mockBudgetsList = [{ id: "b1", name: "B1" }];
+		(mockYnabAPI.budgets.getBudgets as any).mockResolvedValue({
+			data: { budgets: mockBudgetsList },
+		});
+
+		const uri = "ynab://budgets";
+		const result = await resourceManager.readResource(uri);
+
+		// Should call getBudgets (static), not getBudgetById (template)
+		expect(mockYnabAPI.budgets.getBudgets).toHaveBeenCalled();
+		expect(mockYnabAPI.budgets.getBudgetById).not.toHaveBeenCalled();
+		expect(JSON.parse(result.contents[0].text)).toEqual({
+			budgets: expect.any(Array),
+		});
+	});
+
+	// Error handling tests
+	describe("Error Handling", () => {
+		it("should handle API errors gracefully for template resources", async () => {
+			(mockYnabAPI.budgets.getBudgetById as any).mockRejectedValue(
+				new Error("Budget not found"),
+			);
+
+			await expect(
+				resourceManager.readResource("ynab://budgets/invalid-id"),
+			).rejects.toThrow(
+				"Failed to read resource ynab://budgets/invalid-id: Failed to fetch budget invalid-id: Budget not found",
+			);
+		});
+
+		it("should handle API errors for account templates", async () => {
+			(mockYnabAPI.accounts.getAccountById as any).mockRejectedValue(
+				new Error("Account not found"),
+			);
+
+			await expect(
+				resourceManager.readResource(
+					"ynab://budgets/budget-id/accounts/invalid-account",
+				),
+			).rejects.toThrow(
+				"Failed to read resource ynab://budgets/budget-id/accounts/invalid-account: Failed to fetch account invalid-account in budget budget-id: Account not found",
+			);
+		});
+
+		it("should reject URIs with backslash characters", async () => {
+			await expect(
+				resourceManager.readResource("ynab://budgets/test\\bad"),
+			).rejects.toThrow("Invalid parameter value");
+		});
+
+		it("should reject URIs with double-dot sequences in parameters", async () => {
+			await expect(
+				resourceManager.readResource("ynab://budgets/test../accounts"),
+			).rejects.toThrow("Invalid parameter value");
+		});
+	});
+
+	// Template validation tests
+	describe("Template Validation", () => {
+		it("should validate template format when registering", async () => {
+			// This test verifies that malformed templates are caught
+			const maliciousTemplate = {
+				uriTemplate: "ynab://budgets/{budget_id}$(malicious)",
+				name: "Malicious Template",
+				description: "Should be rejected",
+				mimeType: "application/json",
+				handler: async () => [],
+			};
+
+			expect(() => resourceManager.registerTemplate(maliciousTemplate)).toThrow(
+				"Invalid template format: contains unsafe characters",
+			);
+		});
+
+		it("should reject template registration with invalid parameter names", () => {
+			const invalidParamTemplate = {
+				uriTemplate: "ynab://budgets/{Budget-Id}",
+				name: "Invalid Param Template",
+				description: "Should be rejected due to invalid param casing",
+				mimeType: "application/json",
+				handler: async () => [],
+			};
+
+			expect(() =>
+				resourceManager.registerTemplate(invalidParamTemplate),
+			).toThrow("Invalid template parameter name 'Budget-Id'");
+		});
+	});
 });