@dizzlkheinz/ynab-mcpb 0.18.3 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (346) hide show
  1. package/CHANGELOG.md +17 -0
  2. package/CLAUDE.md +87 -8
  3. package/bin/ynab-mcp-server.cjs +2 -2
  4. package/bin/ynab-mcp-server.js +3 -3
  5. package/biome.json +39 -0
  6. package/dist/bundle/index.cjs +67 -67
  7. package/dist/index.d.ts +1 -1
  8. package/dist/index.js +27 -27
  9. package/dist/server/YNABMCPServer.d.ts +3 -4
  10. package/dist/server/YNABMCPServer.js +111 -116
  11. package/dist/server/budgetResolver.d.ts +6 -5
  12. package/dist/server/budgetResolver.js +46 -36
  13. package/dist/server/cacheKeys.js +6 -6
  14. package/dist/server/cacheManager.js +14 -11
  15. package/dist/server/completions.d.ts +2 -2
  16. package/dist/server/completions.js +20 -15
  17. package/dist/server/config.d.ts +10 -5
  18. package/dist/server/config.js +24 -7
  19. package/dist/server/deltaCache.d.ts +2 -2
  20. package/dist/server/deltaCache.js +22 -16
  21. package/dist/server/deltaCache.merge.d.ts +2 -2
  22. package/dist/server/diagnostics.d.ts +4 -4
  23. package/dist/server/diagnostics.js +38 -32
  24. package/dist/server/errorHandler.d.ts +5 -12
  25. package/dist/server/errorHandler.js +219 -217
  26. package/dist/server/prompts.d.ts +2 -2
  27. package/dist/server/prompts.js +45 -45
  28. package/dist/server/rateLimiter.js +4 -4
  29. package/dist/server/requestLogger.d.ts +1 -1
  30. package/dist/server/requestLogger.js +40 -35
  31. package/dist/server/resources.d.ts +3 -3
  32. package/dist/server/resources.js +55 -52
  33. package/dist/server/responseFormatter.js +6 -6
  34. package/dist/server/securityMiddleware.d.ts +2 -2
  35. package/dist/server/securityMiddleware.js +22 -20
  36. package/dist/server/serverKnowledgeStore.js +1 -1
  37. package/dist/server/toolRegistry.d.ts +3 -3
  38. package/dist/server/toolRegistry.js +47 -40
  39. package/dist/tools/__tests__/deltaTestUtils.d.ts +3 -3
  40. package/dist/tools/__tests__/deltaTestUtils.js +2 -2
  41. package/dist/tools/accountTools.d.ts +9 -8
  42. package/dist/tools/accountTools.js +47 -47
  43. package/dist/tools/adapters.d.ts +13 -8
  44. package/dist/tools/adapters.js +21 -11
  45. package/dist/tools/budgetTools.d.ts +8 -7
  46. package/dist/tools/budgetTools.js +22 -22
  47. package/dist/tools/categoryTools.d.ts +9 -8
  48. package/dist/tools/categoryTools.js +68 -59
  49. package/dist/tools/compareTransactions/formatter.d.ts +3 -3
  50. package/dist/tools/compareTransactions/formatter.js +9 -9
  51. package/dist/tools/compareTransactions/index.d.ts +6 -6
  52. package/dist/tools/compareTransactions/index.js +58 -43
  53. package/dist/tools/compareTransactions/matcher.d.ts +1 -1
  54. package/dist/tools/compareTransactions/matcher.js +28 -15
  55. package/dist/tools/compareTransactions/parser.d.ts +2 -2
  56. package/dist/tools/compareTransactions/parser.js +144 -138
  57. package/dist/tools/compareTransactions/types.d.ts +4 -4
  58. package/dist/tools/compareTransactions.d.ts +1 -1
  59. package/dist/tools/compareTransactions.js +1 -1
  60. package/dist/tools/deltaFetcher.d.ts +2 -2
  61. package/dist/tools/deltaFetcher.js +16 -15
  62. package/dist/tools/deltaSupport.d.ts +4 -4
  63. package/dist/tools/deltaSupport.js +35 -41
  64. package/dist/tools/exportTransactions.d.ts +5 -4
  65. package/dist/tools/exportTransactions.js +61 -59
  66. package/dist/tools/monthTools.d.ts +7 -6
  67. package/dist/tools/monthTools.js +31 -29
  68. package/dist/tools/payeeTools.d.ts +7 -6
  69. package/dist/tools/payeeTools.js +28 -28
  70. package/dist/tools/reconcileAdapter.d.ts +2 -2
  71. package/dist/tools/reconcileAdapter.js +21 -11
  72. package/dist/tools/reconciliation/analyzer.d.ts +4 -4
  73. package/dist/tools/reconciliation/analyzer.js +136 -57
  74. package/dist/tools/reconciliation/csvParser.d.ts +3 -3
  75. package/dist/tools/reconciliation/csvParser.js +128 -104
  76. package/dist/tools/reconciliation/executor.d.ts +4 -4
  77. package/dist/tools/reconciliation/executor.js +148 -109
  78. package/dist/tools/reconciliation/index.d.ts +10 -10
  79. package/dist/tools/reconciliation/index.js +96 -83
  80. package/dist/tools/reconciliation/matcher.d.ts +3 -3
  81. package/dist/tools/reconciliation/matcher.js +17 -16
  82. package/dist/tools/reconciliation/payeeNormalizer.js +19 -8
  83. package/dist/tools/reconciliation/recommendationEngine.d.ts +1 -1
  84. package/dist/tools/reconciliation/recommendationEngine.js +40 -40
  85. package/dist/tools/reconciliation/reportFormatter.d.ts +2 -2
  86. package/dist/tools/reconciliation/reportFormatter.js +79 -54
  87. package/dist/tools/reconciliation/signDetector.d.ts +1 -1
  88. package/dist/tools/reconciliation/types.d.ts +19 -16
  89. package/dist/tools/reconciliation/ynabAdapter.d.ts +2 -2
  90. package/dist/tools/schemas/common.d.ts +1 -1
  91. package/dist/tools/schemas/common.js +1 -1
  92. package/dist/tools/schemas/outputs/accountOutputs.d.ts +1 -1
  93. package/dist/tools/schemas/outputs/accountOutputs.js +24 -18
  94. package/dist/tools/schemas/outputs/budgetOutputs.d.ts +1 -1
  95. package/dist/tools/schemas/outputs/budgetOutputs.js +14 -11
  96. package/dist/tools/schemas/outputs/categoryOutputs.d.ts +1 -1
  97. package/dist/tools/schemas/outputs/categoryOutputs.js +49 -29
  98. package/dist/tools/schemas/outputs/comparisonOutputs.d.ts +1 -1
  99. package/dist/tools/schemas/outputs/comparisonOutputs.js +12 -12
  100. package/dist/tools/schemas/outputs/index.d.ts +14 -14
  101. package/dist/tools/schemas/outputs/index.js +14 -14
  102. package/dist/tools/schemas/outputs/monthOutputs.d.ts +1 -1
  103. package/dist/tools/schemas/outputs/monthOutputs.js +56 -41
  104. package/dist/tools/schemas/outputs/payeeOutputs.d.ts +1 -1
  105. package/dist/tools/schemas/outputs/payeeOutputs.js +10 -10
  106. package/dist/tools/schemas/outputs/reconciliationOutputs.d.ts +2 -2
  107. package/dist/tools/schemas/outputs/reconciliationOutputs.js +45 -45
  108. package/dist/tools/schemas/outputs/transactionMutationOutputs.d.ts +1 -1
  109. package/dist/tools/schemas/outputs/transactionMutationOutputs.js +28 -22
  110. package/dist/tools/schemas/outputs/transactionOutputs.d.ts +1 -1
  111. package/dist/tools/schemas/outputs/transactionOutputs.js +43 -35
  112. package/dist/tools/schemas/outputs/utilityOutputs.d.ts +1 -1
  113. package/dist/tools/schemas/outputs/utilityOutputs.js +5 -3
  114. package/dist/tools/schemas/shared/commonOutputs.d.ts +1 -1
  115. package/dist/tools/schemas/shared/commonOutputs.js +15 -9
  116. package/dist/tools/transactionReadTools.d.ts +11 -0
  117. package/dist/tools/transactionReadTools.js +202 -0
  118. package/dist/tools/transactionSchemas.d.ts +309 -0
  119. package/dist/tools/transactionSchemas.js +235 -0
  120. package/dist/tools/transactionTools.d.ts +6 -302
  121. package/dist/tools/transactionTools.js +7 -2054
  122. package/dist/tools/transactionUtils.d.ts +31 -0
  123. package/dist/tools/transactionUtils.js +364 -0
  124. package/dist/tools/transactionWriteTools.d.ts +20 -0
  125. package/dist/tools/transactionWriteTools.js +1342 -0
  126. package/dist/tools/utilityTools.d.ts +5 -4
  127. package/dist/tools/utilityTools.js +11 -11
  128. package/dist/types/index.d.ts +7 -7
  129. package/dist/types/index.js +6 -6
  130. package/dist/types/reconciliation.d.ts +1 -1
  131. package/dist/types/toolRegistration.d.ts +14 -12
  132. package/dist/utils/amountUtils.js +1 -1
  133. package/dist/utils/dateUtils.js +4 -4
  134. package/dist/utils/errors.d.ts +3 -3
  135. package/dist/utils/errors.js +4 -4
  136. package/dist/utils/money.d.ts +2 -2
  137. package/dist/utils/money.js +8 -8
  138. package/dist/utils/validationError.d.ts +1 -1
  139. package/dist/utils/validationError.js +1 -1
  140. package/docs/assets/examples/reconciliation-with-recommendations.json +66 -66
  141. package/docs/assets/schemas/reconciliation-v2.json +360 -336
  142. package/docs/plans/2025-12-25-transaction-tools-refactor-design.md +211 -0
  143. package/docs/plans/2025-12-25-transaction-tools-refactor.md +905 -0
  144. package/esbuild.config.mjs +53 -50
  145. package/meta.json +12548 -12548
  146. package/package.json +98 -109
  147. package/scripts/analyze-bundle.mjs +33 -30
  148. package/scripts/create-pr-description.js +169 -120
  149. package/scripts/run-all-tests.js +205 -0
  150. package/scripts/run-domain-integration-tests.js +28 -18
  151. package/scripts/run-generate-mcpb.js +19 -17
  152. package/scripts/run-throttled-integration-tests.js +92 -83
  153. package/scripts/test-delta-params.mjs +149 -120
  154. package/scripts/test-recommendations.ts +36 -32
  155. package/scripts/tmpTransaction.ts +80 -43
  156. package/scripts/validate-env.js +98 -91
  157. package/scripts/verify-build.js +78 -76
  158. package/src/__tests__/comprehensive.integration.test.ts +1281 -1154
  159. package/src/__tests__/performance.test.ts +723 -671
  160. package/src/__tests__/setup.ts +442 -395
  161. package/src/__tests__/smoke.e2e.test.ts +41 -39
  162. package/src/__tests__/testRunner.ts +314 -295
  163. package/src/__tests__/testUtils.ts +456 -364
  164. package/src/__tests__/tools/reconciliation/csvParser.integration.test.ts +109 -107
  165. package/src/__tests__/tools/reconciliation/real-world.integration.test.ts +41 -41
  166. package/src/index.ts +68 -59
  167. package/src/server/CLAUDE.md +480 -0
  168. package/src/server/YNABMCPServer.ts +821 -794
  169. package/src/server/__tests__/YNABMCPServer.integration.test.ts +929 -893
  170. package/src/server/__tests__/YNABMCPServer.test.ts +903 -899
  171. package/src/server/__tests__/budgetResolver.test.ts +466 -423
  172. package/src/server/__tests__/cacheManager.test.ts +891 -874
  173. package/src/server/__tests__/completions.integration.test.ts +115 -106
  174. package/src/server/__tests__/completions.test.ts +334 -313
  175. package/src/server/__tests__/config.test.ts +98 -86
  176. package/src/server/__tests__/deltaCache.merge.test.ts +774 -703
  177. package/src/server/__tests__/deltaCache.swr.test.ts +198 -153
  178. package/src/server/__tests__/deltaCache.test.ts +946 -759
  179. package/src/server/__tests__/diagnostics.test.ts +825 -792
  180. package/src/server/__tests__/errorHandler.integration.test.ts +512 -462
  181. package/src/server/__tests__/errorHandler.test.ts +402 -397
  182. package/src/server/__tests__/prompts.test.ts +424 -347
  183. package/src/server/__tests__/rateLimiter.test.ts +313 -309
  184. package/src/server/__tests__/requestLogger.test.ts +443 -403
  185. package/src/server/__tests__/resources.template.test.ts +196 -185
  186. package/src/server/__tests__/resources.test.ts +294 -288
  187. package/src/server/__tests__/security.integration.test.ts +487 -421
  188. package/src/server/__tests__/securityMiddleware.test.ts +519 -444
  189. package/src/server/__tests__/server-startup.integration.test.ts +509 -490
  190. package/src/server/__tests__/serverKnowledgeStore.test.ts +174 -173
  191. package/src/server/__tests__/toolRegistration.test.ts +239 -210
  192. package/src/server/__tests__/toolRegistry.test.ts +907 -845
  193. package/src/server/budgetResolver.ts +221 -181
  194. package/src/server/cacheKeys.ts +6 -6
  195. package/src/server/cacheManager.ts +498 -484
  196. package/src/server/completions.ts +267 -243
  197. package/src/server/config.ts +35 -14
  198. package/src/server/deltaCache.merge.ts +146 -128
  199. package/src/server/deltaCache.ts +352 -309
  200. package/src/server/diagnostics.ts +257 -242
  201. package/src/server/errorHandler.ts +747 -744
  202. package/src/server/prompts.ts +181 -176
  203. package/src/server/rateLimiter.ts +131 -129
  204. package/src/server/requestLogger.ts +350 -322
  205. package/src/server/resources.ts +442 -374
  206. package/src/server/responseFormatter.ts +41 -37
  207. package/src/server/securityMiddleware.ts +223 -205
  208. package/src/server/serverKnowledgeStore.ts +67 -67
  209. package/src/server/toolRegistry.ts +508 -474
  210. package/src/tools/CLAUDE.md +604 -0
  211. package/src/tools/__tests__/accountTools.delta.integration.test.ts +128 -111
  212. package/src/tools/__tests__/accountTools.integration.test.ts +129 -111
  213. package/src/tools/__tests__/accountTools.test.ts +685 -638
  214. package/src/tools/__tests__/adapters.test.ts +142 -108
  215. package/src/tools/__tests__/budgetTools.delta.integration.test.ts +73 -73
  216. package/src/tools/__tests__/budgetTools.integration.test.ts +132 -124
  217. package/src/tools/__tests__/budgetTools.test.ts +442 -413
  218. package/src/tools/__tests__/categoryTools.delta.integration.test.ts +76 -68
  219. package/src/tools/__tests__/categoryTools.integration.test.ts +314 -288
  220. package/src/tools/__tests__/categoryTools.test.ts +656 -625
  221. package/src/tools/__tests__/compareTransactions/formatter.test.ts +535 -462
  222. package/src/tools/__tests__/compareTransactions/index.test.ts +378 -358
  223. package/src/tools/__tests__/compareTransactions/matcher.test.ts +497 -398
  224. package/src/tools/__tests__/compareTransactions/parser.test.ts +765 -747
  225. package/src/tools/__tests__/compareTransactions.test.ts +352 -332
  226. package/src/tools/__tests__/compareTransactions.window.test.ts +150 -146
  227. package/src/tools/__tests__/deltaFetcher.scheduled.integration.test.ts +69 -65
  228. package/src/tools/__tests__/deltaFetcher.test.ts +325 -265
  229. package/src/tools/__tests__/deltaSupport.test.ts +211 -184
  230. package/src/tools/__tests__/deltaTestUtils.ts +37 -33
  231. package/src/tools/__tests__/exportTransactions.test.ts +205 -200
  232. package/src/tools/__tests__/monthTools.delta.integration.test.ts +68 -68
  233. package/src/tools/__tests__/monthTools.integration.test.ts +178 -166
  234. package/src/tools/__tests__/monthTools.test.ts +561 -512
  235. package/src/tools/__tests__/payeeTools.delta.integration.test.ts +68 -68
  236. package/src/tools/__tests__/payeeTools.integration.test.ts +158 -142
  237. package/src/tools/__tests__/payeeTools.test.ts +486 -434
  238. package/src/tools/__tests__/transactionSchemas.test.ts +1204 -0
  239. package/src/tools/__tests__/transactionTools.integration.test.ts +875 -825
  240. package/src/tools/__tests__/transactionTools.test.ts +4923 -4366
  241. package/src/tools/__tests__/transactionUtils.test.ts +1016 -0
  242. package/src/tools/__tests__/utilityTools.integration.test.ts +32 -32
  243. package/src/tools/__tests__/utilityTools.test.ts +68 -58
  244. package/src/tools/accountTools.ts +293 -271
  245. package/src/tools/adapters.ts +120 -63
  246. package/src/tools/budgetTools.ts +121 -116
  247. package/src/tools/categoryTools.ts +379 -339
  248. package/src/tools/compareTransactions/formatter.ts +131 -119
  249. package/src/tools/compareTransactions/index.ts +249 -214
  250. package/src/tools/compareTransactions/matcher.ts +259 -209
  251. package/src/tools/compareTransactions/parser.ts +517 -487
  252. package/src/tools/compareTransactions/types.ts +38 -38
  253. package/src/tools/compareTransactions.ts +1 -1
  254. package/src/tools/deltaFetcher.ts +281 -260
  255. package/src/tools/deltaSupport.ts +264 -259
  256. package/src/tools/exportTransactions.ts +230 -218
  257. package/src/tools/monthTools.ts +180 -165
  258. package/src/tools/payeeTools.ts +152 -140
  259. package/src/tools/reconcileAdapter.ts +297 -246
  260. package/src/tools/reconciliation/CLAUDE.md +506 -0
  261. package/src/tools/reconciliation/__tests__/adapter.causes.test.ts +135 -112
  262. package/src/tools/reconciliation/__tests__/adapter.test.ts +249 -227
  263. package/src/tools/reconciliation/__tests__/analyzer.test.ts +408 -335
  264. package/src/tools/reconciliation/__tests__/csvParser.test.ts +71 -69
  265. package/src/tools/reconciliation/__tests__/executor.integration.test.ts +348 -323
  266. package/src/tools/reconciliation/__tests__/executor.progress.test.ts +503 -457
  267. package/src/tools/reconciliation/__tests__/executor.test.ts +898 -831
  268. package/src/tools/reconciliation/__tests__/matcher.test.ts +667 -663
  269. package/src/tools/reconciliation/__tests__/payeeNormalizer.test.ts +296 -276
  270. package/src/tools/reconciliation/__tests__/recommendationEngine.integration.test.ts +692 -624
  271. package/src/tools/reconciliation/__tests__/recommendationEngine.test.ts +1008 -986
  272. package/src/tools/reconciliation/__tests__/reconciliation.delta.integration.test.ts +187 -146
  273. package/src/tools/reconciliation/__tests__/reportFormatter.test.ts +583 -530
  274. package/src/tools/reconciliation/__tests__/scenarios/adapterCurrency.scenario.test.ts +75 -71
  275. package/src/tools/reconciliation/__tests__/scenarios/extremes.scenario.test.ts +70 -58
  276. package/src/tools/reconciliation/__tests__/scenarios/repeatAmount.scenario.test.ts +102 -88
  277. package/src/tools/reconciliation/__tests__/schemaUrl.test.ts +58 -43
  278. package/src/tools/reconciliation/__tests__/signDetector.test.ts +209 -206
  279. package/src/tools/reconciliation/__tests__/ynabAdapter.test.ts +66 -60
  280. package/src/tools/reconciliation/analyzer.ts +582 -406
  281. package/src/tools/reconciliation/csvParser.ts +656 -609
  282. package/src/tools/reconciliation/executor.ts +1290 -1128
  283. package/src/tools/reconciliation/index.ts +580 -528
  284. package/src/tools/reconciliation/matcher.ts +256 -240
  285. package/src/tools/reconciliation/payeeNormalizer.ts +92 -78
  286. package/src/tools/reconciliation/recommendationEngine.ts +357 -345
  287. package/src/tools/reconciliation/reportFormatter.ts +349 -276
  288. package/src/tools/reconciliation/signDetector.ts +89 -83
  289. package/src/tools/reconciliation/types.ts +164 -153
  290. package/src/tools/reconciliation/ynabAdapter.ts +17 -15
  291. package/src/tools/schemas/CLAUDE.md +546 -0
  292. package/src/tools/schemas/common.ts +1 -1
  293. package/src/tools/schemas/outputs/__tests__/accountOutputs.test.ts +410 -409
  294. package/src/tools/schemas/outputs/__tests__/budgetOutputs.test.ts +305 -299
  295. package/src/tools/schemas/outputs/__tests__/categoryOutputs.test.ts +431 -430
  296. package/src/tools/schemas/outputs/__tests__/comparisonOutputs.test.ts +510 -495
  297. package/src/tools/schemas/outputs/__tests__/dateValidation.test.ts +179 -153
  298. package/src/tools/schemas/outputs/__tests__/discrepancyDirection.test.ts +293 -254
  299. package/src/tools/schemas/outputs/__tests__/monthOutputs.test.ts +457 -457
  300. package/src/tools/schemas/outputs/__tests__/payeeOutputs.test.ts +362 -356
  301. package/src/tools/schemas/outputs/__tests__/reconciliationOutputs.test.ts +402 -399
  302. package/src/tools/schemas/outputs/__tests__/transactionMutationSchemas.test.ts +225 -211
  303. package/src/tools/schemas/outputs/__tests__/transactionOutputs.test.ts +457 -454
  304. package/src/tools/schemas/outputs/__tests__/utilityOutputs.test.ts +316 -315
  305. package/src/tools/schemas/outputs/accountOutputs.ts +40 -34
  306. package/src/tools/schemas/outputs/budgetOutputs.ts +24 -19
  307. package/src/tools/schemas/outputs/categoryOutputs.ts +76 -56
  308. package/src/tools/schemas/outputs/comparisonOutputs.ts +192 -169
  309. package/src/tools/schemas/outputs/index.ts +163 -163
  310. package/src/tools/schemas/outputs/monthOutputs.ts +95 -80
  311. package/src/tools/schemas/outputs/payeeOutputs.ts +18 -18
  312. package/src/tools/schemas/outputs/reconciliationOutputs.ts +386 -373
  313. package/src/tools/schemas/outputs/transactionMutationOutputs.ts +259 -231
  314. package/src/tools/schemas/outputs/transactionOutputs.ts +81 -71
  315. package/src/tools/schemas/outputs/utilityOutputs.ts +90 -84
  316. package/src/tools/schemas/shared/commonOutputs.ts +27 -19
  317. package/src/tools/toolCategories.ts +114 -114
  318. package/src/tools/transactionReadTools.ts +327 -0
  319. package/src/tools/transactionSchemas.ts +484 -0
  320. package/src/tools/transactionTools.ts +107 -2990
  321. package/src/tools/transactionUtils.ts +621 -0
  322. package/src/tools/transactionWriteTools.ts +2110 -0
  323. package/src/tools/utilityTools.ts +46 -41
  324. package/src/types/CLAUDE.md +477 -0
  325. package/src/types/__tests__/index.test.ts +51 -51
  326. package/src/types/index.ts +43 -39
  327. package/src/types/integration-tests.d.ts +26 -26
  328. package/src/types/reconciliation.ts +29 -29
  329. package/src/types/toolAnnotations.ts +30 -30
  330. package/src/types/toolRegistration.ts +43 -32
  331. package/src/utils/CLAUDE.md +508 -0
  332. package/src/utils/__tests__/dateUtils.test.ts +174 -168
  333. package/src/utils/__tests__/money.test.ts +193 -187
  334. package/src/utils/amountUtils.ts +5 -5
  335. package/src/utils/baseError.ts +5 -5
  336. package/src/utils/dateUtils.ts +29 -26
  337. package/src/utils/errors.ts +14 -14
  338. package/src/utils/money.ts +66 -52
  339. package/src/utils/validationError.ts +1 -1
  340. package/tsconfig.json +29 -29
  341. package/tsconfig.prod.json +16 -16
  342. package/vitest-reporters/split-json-reporter.ts +247 -204
  343. package/vitest.config.ts +99 -95
  344. package/.prettierignore +0 -10
  345. package/.prettierrc.json +0 -10
  346. package/eslint.config.js +0 -49
@@ -1,445 +1,497 @@
1
- import { describe, it, expect, vi, beforeEach } from 'vitest';
2
- import * as ynab from 'ynab';
1
+ import { beforeEach, describe, expect, it, vi } from "vitest";
2
+ import type * as ynab from "ynab";
3
3
  import {
4
- handleListPayees,
5
- handleGetPayee,
6
- ListPayeesSchema,
7
- GetPayeeSchema,
8
- } from '../payeeTools.js';
9
- import { createDeltaFetcherMock, createRejectingDeltaFetcherMock } from './deltaTestUtils.js';
4
+ GetPayeeSchema,
5
+ ListPayeesSchema,
6
+ handleGetPayee,
7
+ handleListPayees,
8
+ } from "../payeeTools.js";
9
+ import {
10
+ createDeltaFetcherMock,
11
+ createRejectingDeltaFetcherMock,
12
+ } from "./deltaTestUtils.js";
10
13
 
11
14
  // Mock the cache manager
12
- vi.mock('../../server/cacheManager.js', () => ({
13
- cacheManager: {
14
- wrap: vi.fn(),
15
- has: vi.fn(),
16
- delete: vi.fn(),
17
- deleteMany: vi.fn(),
18
- deleteByPrefix: vi.fn(),
19
- deleteByBudgetId: vi.fn(),
20
- clear: vi.fn(),
21
- },
22
- CacheManager: {
23
- generateKey: vi.fn(),
24
- },
25
- CACHE_TTLS: {
26
- PAYEES: 300000,
27
- },
15
+ vi.mock("../../server/cacheManager.js", () => ({
16
+ cacheManager: {
17
+ wrap: vi.fn(),
18
+ has: vi.fn(),
19
+ delete: vi.fn(),
20
+ deleteMany: vi.fn(),
21
+ deleteByPrefix: vi.fn(),
22
+ deleteByBudgetId: vi.fn(),
23
+ clear: vi.fn(),
24
+ },
25
+ CacheManager: {
26
+ generateKey: vi.fn(),
27
+ },
28
+ CACHE_TTLS: {
29
+ PAYEES: 300000,
30
+ },
28
31
  }));
29
32
 
30
33
  // Mock the YNAB API
31
34
  const mockYnabAPI = {
32
- payees: {
33
- getPayees: vi.fn(),
34
- getPayeeById: vi.fn(),
35
- },
35
+ payees: {
36
+ getPayees: vi.fn(),
37
+ getPayeeById: vi.fn(),
38
+ },
36
39
  } as unknown as ynab.API;
37
40
 
38
41
  // Import mocked cache manager
39
- const { cacheManager, CacheManager, CACHE_TTLS } = await import('../../server/cacheManager.js');
40
-
41
- describe('Payee Tools', () => {
42
- beforeEach(() => {
43
- vi.resetAllMocks();
44
- // Reset NODE_ENV to test to ensure cache bypassing in tests
45
- process.env['NODE_ENV'] = 'test';
46
- // Mock cache.wrap to call the loader directly (bypass cache)
47
- (cacheManager.wrap as ReturnType<typeof vi.fn>).mockImplementation(
48
- async (
49
- _key: string,
50
- options: {
51
- loader: () => Promise<unknown>;
52
- },
53
- ) => {
54
- return await options.loader();
55
- },
56
- );
57
- (cacheManager.has as ReturnType<typeof vi.fn>).mockReturnValue(false);
58
- (CacheManager.generateKey as ReturnType<typeof vi.fn>).mockImplementation(
59
- (prefix: string, ...parts: (string | number | boolean | undefined)[]) =>
60
- [prefix, ...parts.filter((part) => part !== undefined)].join(':'),
61
- );
62
- });
63
-
64
- describe('handleListPayees', () => {
65
- it('should include cache metadata from delta fetcher results', async () => {
66
- const mockPayees = [
67
- {
68
- id: 'payee-1',
69
- name: 'Grocery Store',
70
- transfer_account_id: null,
71
- deleted: false,
72
- },
73
- {
74
- id: 'payee-2',
75
- name: 'Gas Station',
76
- transfer_account_id: null,
77
- deleted: false,
78
- },
79
- ];
80
- const { fetcher, resolved } = createDeltaFetcherMock('fetchPayees', {
81
- data: mockPayees,
82
- wasCached: true,
83
- usedDelta: true,
84
- });
85
-
86
- const result = await handleListPayees(mockYnabAPI, fetcher, { budget_id: 'budget-1' });
87
-
88
- const parsedContent = JSON.parse(result.content[0].text);
89
- expect(parsedContent.cached).toBe(resolved.wasCached);
90
- expect(parsedContent.cache_info).toContain('delta merge applied');
91
- expect(parsedContent.payees).toHaveLength(2);
92
- });
93
-
94
- it.skip('should use cache when NODE_ENV is not test - obsolete test, caching now handled by DeltaFetcher', async () => {
95
- // Temporarily set NODE_ENV to non-test
96
- process.env['NODE_ENV'] = 'development';
97
-
98
- const mockPayees = [
99
- {
100
- id: 'payee-1',
101
- name: 'Grocery Store',
102
- transfer_account_id: null,
103
- deleted: false,
104
- },
105
- ];
106
-
107
- const mockCacheKey = 'payees:list:budget-1:generated-key';
108
- (CacheManager.generateKey as any).mockReturnValue(mockCacheKey);
109
- (cacheManager.wrap as any).mockResolvedValue(mockPayees);
110
- (cacheManager.has as any).mockReturnValue(true);
111
-
112
- const result = await handleListPayees(mockYnabAPI, { budget_id: 'budget-1' });
113
-
114
- // Verify cache was used
115
- expect(CacheManager.generateKey).toHaveBeenCalledWith('payees', 'list', 'budget-1');
116
- expect(cacheManager.wrap).toHaveBeenCalledWith(mockCacheKey, {
117
- ttl: CACHE_TTLS.PAYEES,
118
- loader: expect.any(Function),
119
- });
120
- expect(cacheManager.has).toHaveBeenCalledWith(mockCacheKey);
121
-
122
- const parsedContent = JSON.parse(result.content[0].text);
123
- expect(parsedContent.cached).toBe(true);
124
- expect(parsedContent.cache_info).toBe('Data retrieved from cache for improved performance');
125
-
126
- // Reset NODE_ENV
127
- process.env['NODE_ENV'] = 'test';
128
- });
129
-
130
- it('should return formatted payee list on success', async () => {
131
- const mockPayees = [
132
- {
133
- id: 'payee-1',
134
- name: 'Grocery Store',
135
- transfer_account_id: null,
136
- deleted: false,
137
- },
138
- {
139
- id: 'payee-2',
140
- name: 'Gas Station',
141
- transfer_account_id: null,
142
- deleted: false,
143
- },
144
- {
145
- id: 'payee-3',
146
- name: 'Transfer : Savings',
147
- transfer_account_id: 'account-2',
148
- deleted: false,
149
- },
150
- ];
151
- const { fetcher, resolved } = createDeltaFetcherMock('fetchPayees', {
152
- data: mockPayees,
153
- wasCached: false,
154
- });
155
-
156
- const result = await handleListPayees(mockYnabAPI, fetcher, { budget_id: 'budget-1' });
157
-
158
- expect(result.content).toHaveLength(1);
159
- expect(result.content[0].type).toBe('text');
160
-
161
- const parsedContent = JSON.parse(result.content[0].text);
162
- expect(parsedContent.payees).toHaveLength(3);
163
- expect(parsedContent.cached).toBe(resolved.wasCached);
164
- expect(parsedContent.cache_info).toBe('Fresh data retrieved from YNAB API');
165
- expect(parsedContent.payees[0]).toEqual({
166
- id: 'payee-1',
167
- name: 'Grocery Store',
168
- transfer_account_id: null,
169
- deleted: false,
170
- });
171
- expect(parsedContent.payees[2]).toEqual({
172
- id: 'payee-3',
173
- name: 'Transfer : Savings',
174
- transfer_account_id: 'account-2',
175
- deleted: false,
176
- });
177
- });
178
-
179
- it('should handle authentication errors', async () => {
180
- const { fetcher } = createRejectingDeltaFetcherMock(
181
- 'fetchPayees',
182
- new Error('401 Unauthorized'),
183
- );
184
-
185
- const result = await handleListPayees(mockYnabAPI, fetcher, { budget_id: 'budget-1' });
186
-
187
- expect(result.content).toHaveLength(1);
188
- const parsedContent = JSON.parse(result.content[0].text);
189
- expect(parsedContent.error.message).toBe('Invalid or expired YNAB access token');
190
- });
191
-
192
- it('should handle forbidden errors', async () => {
193
- const { fetcher } = createRejectingDeltaFetcherMock(
194
- 'fetchPayees',
195
- new Error('403 Forbidden'),
196
- );
197
-
198
- const result = await handleListPayees(mockYnabAPI, fetcher, { budget_id: 'budget-1' });
199
-
200
- expect(result.content).toHaveLength(1);
201
- const parsedContent = JSON.parse(result.content[0].text);
202
- expect(parsedContent.error.message).toBe('Insufficient permissions to access YNAB data');
203
- });
204
-
205
- it('should handle not found errors', async () => {
206
- const { fetcher } = createRejectingDeltaFetcherMock(
207
- 'fetchPayees',
208
- new Error('404 Not Found'),
209
- );
210
-
211
- const result = await handleListPayees(mockYnabAPI, fetcher, { budget_id: 'invalid-budget' });
212
-
213
- expect(result.content).toHaveLength(1);
214
- const parsedContent = JSON.parse(result.content[0].text);
215
- expect(parsedContent.error.message).toBe('Budget or payee not found');
216
- });
217
-
218
- it('should handle rate limit errors', async () => {
219
- const { fetcher } = createRejectingDeltaFetcherMock(
220
- 'fetchPayees',
221
- new Error('429 Too Many Requests'),
222
- );
223
-
224
- const result = await handleListPayees(mockYnabAPI, fetcher, { budget_id: 'budget-1' });
225
-
226
- expect(result.content).toHaveLength(1);
227
- const parsedContent = JSON.parse(result.content[0].text);
228
- expect(parsedContent.error.message).toBe('Rate limit exceeded. Please try again later');
229
- });
230
-
231
- it('should handle server errors', async () => {
232
- const { fetcher } = createRejectingDeltaFetcherMock(
233
- 'fetchPayees',
234
- new Error('500 Internal Server Error'),
235
- );
236
-
237
- const result = await handleListPayees(mockYnabAPI, fetcher, { budget_id: 'budget-1' });
238
-
239
- expect(result.content).toHaveLength(1);
240
- const parsedContent = JSON.parse(result.content[0].text);
241
- expect(parsedContent.error.message).toBe('YNAB service is currently unavailable');
242
- });
243
-
244
- it('should handle generic errors', async () => {
245
- const { fetcher } = createRejectingDeltaFetcherMock(
246
- 'fetchPayees',
247
- new Error('Network error'),
248
- );
249
-
250
- const result = await handleListPayees(mockYnabAPI, fetcher, { budget_id: 'budget-1' });
251
-
252
- expect(result.content).toHaveLength(1);
253
- const parsedContent = JSON.parse(result.content[0].text);
254
- expect(parsedContent.error.message).toBe('Failed to list payees');
255
- });
256
- });
257
-
258
- describe('handleGetPayee', () => {
259
- it.skip('should use cache when NODE_ENV is not test - obsolete test, caching now handled by DeltaFetcher', async () => {
260
- // Temporarily set NODE_ENV to non-test
261
- process.env['NODE_ENV'] = 'development';
262
-
263
- const mockPayee = {
264
- id: 'payee-1',
265
- name: 'Grocery Store',
266
- transfer_account_id: null,
267
- deleted: false,
268
- };
269
-
270
- const mockCacheKey = 'payee:get:budget-1:payee-1:generated-key';
271
- (CacheManager.generateKey as any).mockReturnValue(mockCacheKey);
272
- (cacheManager.wrap as any).mockResolvedValue(mockPayee);
273
- (cacheManager.has as any).mockReturnValue(true);
274
-
275
- const result = await handleGetPayee(mockYnabAPI, {
276
- budget_id: 'budget-1',
277
- payee_id: 'payee-1',
278
- });
279
-
280
- // Verify cache was used
281
- expect(CacheManager.generateKey).toHaveBeenCalledWith('payee', 'get', 'budget-1', 'payee-1');
282
- expect(cacheManager.wrap).toHaveBeenCalledWith(mockCacheKey, {
283
- ttl: CACHE_TTLS.PAYEES,
284
- loader: expect.any(Function),
285
- });
286
-
287
- const parsedContent = JSON.parse(result.content[0].text);
288
- expect(parsedContent.cached).toBe(true);
289
- expect(parsedContent.cache_info).toBe('Data retrieved from cache for improved performance');
290
-
291
- // Reset NODE_ENV
292
- process.env['NODE_ENV'] = 'test';
293
- });
294
-
295
- it('should return detailed payee information on success', async () => {
296
- const mockPayee = {
297
- id: 'payee-1',
298
- name: 'Grocery Store',
299
- transfer_account_id: null,
300
- deleted: false,
301
- };
302
-
303
- (mockYnabAPI.payees.getPayeeById as any).mockResolvedValue({
304
- data: { payee: mockPayee },
305
- });
306
-
307
- const result = await handleGetPayee(mockYnabAPI, {
308
- budget_id: 'budget-1',
309
- payee_id: 'payee-1',
310
- });
311
-
312
- expect(result.content).toHaveLength(1);
313
- expect(result.content[0].type).toBe('text');
314
-
315
- const parsedContent = JSON.parse(result.content[0].text);
316
- expect(parsedContent.payee).toEqual({
317
- id: 'payee-1',
318
- name: 'Grocery Store',
319
- transfer_account_id: null,
320
- deleted: false,
321
- });
322
- });
323
-
324
- it('should return transfer payee information on success', async () => {
325
- const mockPayee = {
326
- id: 'payee-2',
327
- name: 'Transfer : Savings',
328
- transfer_account_id: 'account-2',
329
- deleted: false,
330
- };
331
-
332
- (mockYnabAPI.payees.getPayeeById as any).mockResolvedValue({
333
- data: { payee: mockPayee },
334
- });
335
-
336
- const result = await handleGetPayee(mockYnabAPI, {
337
- budget_id: 'budget-1',
338
- payee_id: 'payee-2',
339
- });
340
-
341
- expect(result.content).toHaveLength(1);
342
- const parsedContent = JSON.parse(result.content[0].text);
343
- expect(parsedContent.payee.transfer_account_id).toBe('account-2');
344
- });
345
-
346
- it('should handle 404 not found errors', async () => {
347
- (mockYnabAPI.payees.getPayeeById as any).mockRejectedValue(new Error('404 Not Found'));
348
-
349
- const result = await handleGetPayee(mockYnabAPI, {
350
- budget_id: 'budget-1',
351
- payee_id: 'invalid-payee',
352
- });
353
-
354
- expect(result.content).toHaveLength(1);
355
- const parsedContent = JSON.parse(result.content[0].text);
356
- expect(parsedContent.error.message).toBe('Budget or payee not found');
357
- });
358
-
359
- it('should handle authentication errors', async () => {
360
- (mockYnabAPI.payees.getPayeeById as any).mockRejectedValue(new Error('401 Unauthorized'));
361
-
362
- const result = await handleGetPayee(mockYnabAPI, {
363
- budget_id: 'budget-1',
364
- payee_id: 'payee-1',
365
- });
366
-
367
- expect(result.content).toHaveLength(1);
368
- const parsedContent = JSON.parse(result.content[0].text);
369
- expect(parsedContent.error.message).toBe('Invalid or expired YNAB access token');
370
- });
371
- });
372
-
373
- describe('ListPayeesSchema', () => {
374
- it('should validate valid budget_id', () => {
375
- const result = ListPayeesSchema.parse({ budget_id: 'valid-budget-id' });
376
- expect(result.budget_id).toBe('valid-budget-id');
377
- });
378
-
379
- it('should reject empty budget_id', () => {
380
- expect(() => ListPayeesSchema.parse({ budget_id: '' })).toThrow();
381
- });
382
-
383
- it('should reject missing budget_id', () => {
384
- expect(() => ListPayeesSchema.parse({})).toThrow();
385
- });
386
-
387
- it('should reject non-string budget_id', () => {
388
- expect(() => ListPayeesSchema.parse({ budget_id: 123 })).toThrow();
389
- });
390
- });
391
-
392
- describe('GetPayeeSchema', () => {
393
- it('should validate valid parameters', () => {
394
- const result = GetPayeeSchema.parse({
395
- budget_id: 'valid-budget-id',
396
- payee_id: 'valid-payee-id',
397
- });
398
- expect(result.budget_id).toBe('valid-budget-id');
399
- expect(result.payee_id).toBe('valid-payee-id');
400
- });
401
-
402
- it('should reject empty budget_id', () => {
403
- expect(() =>
404
- GetPayeeSchema.parse({
405
- budget_id: '',
406
- payee_id: 'valid-payee-id',
407
- }),
408
- ).toThrow();
409
- });
410
-
411
- it('should reject empty payee_id', () => {
412
- expect(() =>
413
- GetPayeeSchema.parse({
414
- budget_id: 'valid-budget-id',
415
- payee_id: '',
416
- }),
417
- ).toThrow();
418
- });
419
-
420
- it('should reject missing budget_id', () => {
421
- expect(() =>
422
- GetPayeeSchema.parse({
423
- payee_id: 'valid-payee-id',
424
- }),
425
- ).toThrow();
426
- });
427
-
428
- it('should reject missing payee_id', () => {
429
- expect(() =>
430
- GetPayeeSchema.parse({
431
- budget_id: 'valid-budget-id',
432
- }),
433
- ).toThrow();
434
- });
435
-
436
- it('should reject non-string parameters', () => {
437
- expect(() =>
438
- GetPayeeSchema.parse({
439
- budget_id: 123,
440
- payee_id: 456,
441
- }),
442
- ).toThrow();
443
- });
444
- });
42
+ const { cacheManager, CacheManager, CACHE_TTLS } = await import(
43
+ "../../server/cacheManager.js"
44
+ );
45
+
46
+ describe("Payee Tools", () => {
47
+ beforeEach(() => {
48
+ vi.resetAllMocks();
49
+ // Reset NODE_ENV to test to ensure cache bypassing in tests
50
+ process.env.NODE_ENV = "test";
51
+ // Mock cache.wrap to call the loader directly (bypass cache)
52
+ (cacheManager.wrap as ReturnType<typeof vi.fn>).mockImplementation(
53
+ async (
54
+ _key: string,
55
+ options: {
56
+ loader: () => Promise<unknown>;
57
+ },
58
+ ) => {
59
+ return await options.loader();
60
+ },
61
+ );
62
+ (cacheManager.has as ReturnType<typeof vi.fn>).mockReturnValue(false);
63
+ (CacheManager.generateKey as ReturnType<typeof vi.fn>).mockImplementation(
64
+ (prefix: string, ...parts: (string | number | boolean | undefined)[]) =>
65
+ [prefix, ...parts.filter((part) => part !== undefined)].join(":"),
66
+ );
67
+ });
68
+
69
+ describe("handleListPayees", () => {
70
+ it("should include cache metadata from delta fetcher results", async () => {
71
+ const mockPayees = [
72
+ {
73
+ id: "payee-1",
74
+ name: "Grocery Store",
75
+ transfer_account_id: null,
76
+ deleted: false,
77
+ },
78
+ {
79
+ id: "payee-2",
80
+ name: "Gas Station",
81
+ transfer_account_id: null,
82
+ deleted: false,
83
+ },
84
+ ];
85
+ const { fetcher, resolved } = createDeltaFetcherMock("fetchPayees", {
86
+ data: mockPayees,
87
+ wasCached: true,
88
+ usedDelta: true,
89
+ });
90
+
91
+ const result = await handleListPayees(mockYnabAPI, fetcher, {
92
+ budget_id: "budget-1",
93
+ });
94
+
95
+ const parsedContent = JSON.parse(result.content[0].text);
96
+ expect(parsedContent.cached).toBe(resolved.wasCached);
97
+ expect(parsedContent.cache_info).toContain("delta merge applied");
98
+ expect(parsedContent.payees).toHaveLength(2);
99
+ });
100
+
101
+ it.skip("should use cache when NODE_ENV is not test - obsolete test, caching now handled by DeltaFetcher", async () => {
102
+ // Temporarily set NODE_ENV to non-test
103
+ process.env.NODE_ENV = "development";
104
+
105
+ const mockPayees = [
106
+ {
107
+ id: "payee-1",
108
+ name: "Grocery Store",
109
+ transfer_account_id: null,
110
+ deleted: false,
111
+ },
112
+ ];
113
+
114
+ const mockCacheKey = "payees:list:budget-1:generated-key";
115
+ (CacheManager.generateKey as any).mockReturnValue(mockCacheKey);
116
+ (cacheManager.wrap as any).mockResolvedValue(mockPayees);
117
+ (cacheManager.has as any).mockReturnValue(true);
118
+
119
+ const result = await handleListPayees(mockYnabAPI, {
120
+ budget_id: "budget-1",
121
+ });
122
+
123
+ // Verify cache was used
124
+ expect(CacheManager.generateKey).toHaveBeenCalledWith(
125
+ "payees",
126
+ "list",
127
+ "budget-1",
128
+ );
129
+ expect(cacheManager.wrap).toHaveBeenCalledWith(mockCacheKey, {
130
+ ttl: CACHE_TTLS.PAYEES,
131
+ loader: expect.any(Function),
132
+ });
133
+ expect(cacheManager.has).toHaveBeenCalledWith(mockCacheKey);
134
+
135
+ const parsedContent = JSON.parse(result.content[0].text);
136
+ expect(parsedContent.cached).toBe(true);
137
+ expect(parsedContent.cache_info).toBe(
138
+ "Data retrieved from cache for improved performance",
139
+ );
140
+
141
+ // Reset NODE_ENV
142
+ process.env.NODE_ENV = "test";
143
+ });
144
+
145
+ it("should return formatted payee list on success", async () => {
146
+ const mockPayees = [
147
+ {
148
+ id: "payee-1",
149
+ name: "Grocery Store",
150
+ transfer_account_id: null,
151
+ deleted: false,
152
+ },
153
+ {
154
+ id: "payee-2",
155
+ name: "Gas Station",
156
+ transfer_account_id: null,
157
+ deleted: false,
158
+ },
159
+ {
160
+ id: "payee-3",
161
+ name: "Transfer : Savings",
162
+ transfer_account_id: "account-2",
163
+ deleted: false,
164
+ },
165
+ ];
166
+ const { fetcher, resolved } = createDeltaFetcherMock("fetchPayees", {
167
+ data: mockPayees,
168
+ wasCached: false,
169
+ });
170
+
171
+ const result = await handleListPayees(mockYnabAPI, fetcher, {
172
+ budget_id: "budget-1",
173
+ });
174
+
175
+ expect(result.content).toHaveLength(1);
176
+ expect(result.content[0].type).toBe("text");
177
+
178
+ const parsedContent = JSON.parse(result.content[0].text);
179
+ expect(parsedContent.payees).toHaveLength(3);
180
+ expect(parsedContent.cached).toBe(resolved.wasCached);
181
+ expect(parsedContent.cache_info).toBe(
182
+ "Fresh data retrieved from YNAB API",
183
+ );
184
+ expect(parsedContent.payees[0]).toEqual({
185
+ id: "payee-1",
186
+ name: "Grocery Store",
187
+ transfer_account_id: null,
188
+ deleted: false,
189
+ });
190
+ expect(parsedContent.payees[2]).toEqual({
191
+ id: "payee-3",
192
+ name: "Transfer : Savings",
193
+ transfer_account_id: "account-2",
194
+ deleted: false,
195
+ });
196
+ });
197
+
198
+ it("should handle authentication errors", async () => {
199
+ const { fetcher } = createRejectingDeltaFetcherMock(
200
+ "fetchPayees",
201
+ new Error("401 Unauthorized"),
202
+ );
203
+
204
+ const result = await handleListPayees(mockYnabAPI, fetcher, {
205
+ budget_id: "budget-1",
206
+ });
207
+
208
+ expect(result.content).toHaveLength(1);
209
+ const parsedContent = JSON.parse(result.content[0].text);
210
+ expect(parsedContent.error.message).toBe(
211
+ "Invalid or expired YNAB access token",
212
+ );
213
+ });
214
+
215
+ it("should handle forbidden errors", async () => {
216
+ const { fetcher } = createRejectingDeltaFetcherMock(
217
+ "fetchPayees",
218
+ new Error("403 Forbidden"),
219
+ );
220
+
221
+ const result = await handleListPayees(mockYnabAPI, fetcher, {
222
+ budget_id: "budget-1",
223
+ });
224
+
225
+ expect(result.content).toHaveLength(1);
226
+ const parsedContent = JSON.parse(result.content[0].text);
227
+ expect(parsedContent.error.message).toBe(
228
+ "Insufficient permissions to access YNAB data",
229
+ );
230
+ });
231
+
232
+ it("should handle not found errors", async () => {
233
+ const { fetcher } = createRejectingDeltaFetcherMock(
234
+ "fetchPayees",
235
+ new Error("404 Not Found"),
236
+ );
237
+
238
+ const result = await handleListPayees(mockYnabAPI, fetcher, {
239
+ budget_id: "invalid-budget",
240
+ });
241
+
242
+ expect(result.content).toHaveLength(1);
243
+ const parsedContent = JSON.parse(result.content[0].text);
244
+ expect(parsedContent.error.message).toBe("Budget or payee not found");
245
+ });
246
+
247
+ it("should handle rate limit errors", async () => {
248
+ const { fetcher } = createRejectingDeltaFetcherMock(
249
+ "fetchPayees",
250
+ new Error("429 Too Many Requests"),
251
+ );
252
+
253
+ const result = await handleListPayees(mockYnabAPI, fetcher, {
254
+ budget_id: "budget-1",
255
+ });
256
+
257
+ expect(result.content).toHaveLength(1);
258
+ const parsedContent = JSON.parse(result.content[0].text);
259
+ expect(parsedContent.error.message).toBe(
260
+ "Rate limit exceeded. Please try again later",
261
+ );
262
+ });
263
+
264
+ it("should handle server errors", async () => {
265
+ const { fetcher } = createRejectingDeltaFetcherMock(
266
+ "fetchPayees",
267
+ new Error("500 Internal Server Error"),
268
+ );
269
+
270
+ const result = await handleListPayees(mockYnabAPI, fetcher, {
271
+ budget_id: "budget-1",
272
+ });
273
+
274
+ expect(result.content).toHaveLength(1);
275
+ const parsedContent = JSON.parse(result.content[0].text);
276
+ expect(parsedContent.error.message).toBe(
277
+ "YNAB service is currently unavailable",
278
+ );
279
+ });
280
+
281
+ it("should handle generic errors", async () => {
282
+ const { fetcher } = createRejectingDeltaFetcherMock(
283
+ "fetchPayees",
284
+ new Error("Network error"),
285
+ );
286
+
287
+ const result = await handleListPayees(mockYnabAPI, fetcher, {
288
+ budget_id: "budget-1",
289
+ });
290
+
291
+ expect(result.content).toHaveLength(1);
292
+ const parsedContent = JSON.parse(result.content[0].text);
293
+ expect(parsedContent.error.message).toBe("Failed to list payees");
294
+ });
295
+ });
296
+
297
+ describe("handleGetPayee", () => {
298
+ it.skip("should use cache when NODE_ENV is not test - obsolete test, caching now handled by DeltaFetcher", async () => {
299
+ // Temporarily set NODE_ENV to non-test
300
+ process.env.NODE_ENV = "development";
301
+
302
+ const mockPayee = {
303
+ id: "payee-1",
304
+ name: "Grocery Store",
305
+ transfer_account_id: null,
306
+ deleted: false,
307
+ };
308
+
309
+ const mockCacheKey = "payee:get:budget-1:payee-1:generated-key";
310
+ (CacheManager.generateKey as any).mockReturnValue(mockCacheKey);
311
+ (cacheManager.wrap as any).mockResolvedValue(mockPayee);
312
+ (cacheManager.has as any).mockReturnValue(true);
313
+
314
+ const result = await handleGetPayee(mockYnabAPI, {
315
+ budget_id: "budget-1",
316
+ payee_id: "payee-1",
317
+ });
318
+
319
+ // Verify cache was used
320
+ expect(CacheManager.generateKey).toHaveBeenCalledWith(
321
+ "payee",
322
+ "get",
323
+ "budget-1",
324
+ "payee-1",
325
+ );
326
+ expect(cacheManager.wrap).toHaveBeenCalledWith(mockCacheKey, {
327
+ ttl: CACHE_TTLS.PAYEES,
328
+ loader: expect.any(Function),
329
+ });
330
+
331
+ const parsedContent = JSON.parse(result.content[0].text);
332
+ expect(parsedContent.cached).toBe(true);
333
+ expect(parsedContent.cache_info).toBe(
334
+ "Data retrieved from cache for improved performance",
335
+ );
336
+
337
+ // Reset NODE_ENV
338
+ process.env.NODE_ENV = "test";
339
+ });
340
+
341
+ it("should return detailed payee information on success", async () => {
342
+ const mockPayee = {
343
+ id: "payee-1",
344
+ name: "Grocery Store",
345
+ transfer_account_id: null,
346
+ deleted: false,
347
+ };
348
+
349
+ (mockYnabAPI.payees.getPayeeById as any).mockResolvedValue({
350
+ data: { payee: mockPayee },
351
+ });
352
+
353
+ const result = await handleGetPayee(mockYnabAPI, {
354
+ budget_id: "budget-1",
355
+ payee_id: "payee-1",
356
+ });
357
+
358
+ expect(result.content).toHaveLength(1);
359
+ expect(result.content[0].type).toBe("text");
360
+
361
+ const parsedContent = JSON.parse(result.content[0].text);
362
+ expect(parsedContent.payee).toEqual({
363
+ id: "payee-1",
364
+ name: "Grocery Store",
365
+ transfer_account_id: null,
366
+ deleted: false,
367
+ });
368
+ });
369
+
370
+ it("should return transfer payee information on success", async () => {
371
+ const mockPayee = {
372
+ id: "payee-2",
373
+ name: "Transfer : Savings",
374
+ transfer_account_id: "account-2",
375
+ deleted: false,
376
+ };
377
+
378
+ (mockYnabAPI.payees.getPayeeById as any).mockResolvedValue({
379
+ data: { payee: mockPayee },
380
+ });
381
+
382
+ const result = await handleGetPayee(mockYnabAPI, {
383
+ budget_id: "budget-1",
384
+ payee_id: "payee-2",
385
+ });
386
+
387
+ expect(result.content).toHaveLength(1);
388
+ const parsedContent = JSON.parse(result.content[0].text);
389
+ expect(parsedContent.payee.transfer_account_id).toBe("account-2");
390
+ });
391
+
392
+ it("should handle 404 not found errors", async () => {
393
+ (mockYnabAPI.payees.getPayeeById as any).mockRejectedValue(
394
+ new Error("404 Not Found"),
395
+ );
396
+
397
+ const result = await handleGetPayee(mockYnabAPI, {
398
+ budget_id: "budget-1",
399
+ payee_id: "invalid-payee",
400
+ });
401
+
402
+ expect(result.content).toHaveLength(1);
403
+ const parsedContent = JSON.parse(result.content[0].text);
404
+ expect(parsedContent.error.message).toBe("Budget or payee not found");
405
+ });
406
+
407
+ it("should handle authentication errors", async () => {
408
+ (mockYnabAPI.payees.getPayeeById as any).mockRejectedValue(
409
+ new Error("401 Unauthorized"),
410
+ );
411
+
412
+ const result = await handleGetPayee(mockYnabAPI, {
413
+ budget_id: "budget-1",
414
+ payee_id: "payee-1",
415
+ });
416
+
417
+ expect(result.content).toHaveLength(1);
418
+ const parsedContent = JSON.parse(result.content[0].text);
419
+ expect(parsedContent.error.message).toBe(
420
+ "Invalid or expired YNAB access token",
421
+ );
422
+ });
423
+ });
424
+
425
+ describe("ListPayeesSchema", () => {
426
+ it("should validate valid budget_id", () => {
427
+ const result = ListPayeesSchema.parse({ budget_id: "valid-budget-id" });
428
+ expect(result.budget_id).toBe("valid-budget-id");
429
+ });
430
+
431
+ it("should reject empty budget_id", () => {
432
+ expect(() => ListPayeesSchema.parse({ budget_id: "" })).toThrow();
433
+ });
434
+
435
+ it("should reject missing budget_id", () => {
436
+ expect(() => ListPayeesSchema.parse({})).toThrow();
437
+ });
438
+
439
+ it("should reject non-string budget_id", () => {
440
+ expect(() => ListPayeesSchema.parse({ budget_id: 123 })).toThrow();
441
+ });
442
+ });
443
+
444
+ describe("GetPayeeSchema", () => {
445
+ it("should validate valid parameters", () => {
446
+ const result = GetPayeeSchema.parse({
447
+ budget_id: "valid-budget-id",
448
+ payee_id: "valid-payee-id",
449
+ });
450
+ expect(result.budget_id).toBe("valid-budget-id");
451
+ expect(result.payee_id).toBe("valid-payee-id");
452
+ });
453
+
454
+ it("should reject empty budget_id", () => {
455
+ expect(() =>
456
+ GetPayeeSchema.parse({
457
+ budget_id: "",
458
+ payee_id: "valid-payee-id",
459
+ }),
460
+ ).toThrow();
461
+ });
462
+
463
+ it("should reject empty payee_id", () => {
464
+ expect(() =>
465
+ GetPayeeSchema.parse({
466
+ budget_id: "valid-budget-id",
467
+ payee_id: "",
468
+ }),
469
+ ).toThrow();
470
+ });
471
+
472
+ it("should reject missing budget_id", () => {
473
+ expect(() =>
474
+ GetPayeeSchema.parse({
475
+ payee_id: "valid-payee-id",
476
+ }),
477
+ ).toThrow();
478
+ });
479
+
480
+ it("should reject missing payee_id", () => {
481
+ expect(() =>
482
+ GetPayeeSchema.parse({
483
+ budget_id: "valid-budget-id",
484
+ }),
485
+ ).toThrow();
486
+ });
487
+
488
+ it("should reject non-string parameters", () => {
489
+ expect(() =>
490
+ GetPayeeSchema.parse({
491
+ budget_id: 123,
492
+ payee_id: 456,
493
+ }),
494
+ ).toThrow();
495
+ });
496
+ });
445
497
  });