@dizzlkheinz/ynab-mcpb 0.18.3 → 0.19.0

package/src/tools/reconciliation/__tests__/scenarios/adapterCurrency.scenario.test.ts

@@ -1,78 +1,82 @@
-import { describe, it, expect } from 'vitest';
-import type { ReconciliationAnalysis, TransactionMatch } from '../../types.js';
-import { buildReconciliationPayload } from '../../../reconcileAdapter.js';
+import { describe, expect, it } from "vitest";
+import { buildReconciliationPayload } from "../../../reconcileAdapter.js";
+import type { ReconciliationAnalysis, TransactionMatch } from "../../types.js";
 
-const makeMoney = (value: number, currency = 'USD') => ({
-  value_milliunits: Math.round(value * 1000),
-  value: value,
-  value_display: value < 0 ? `-$${Math.abs(value).toFixed(2)}` : `$${value.toFixed(2)}`,
-  currency,
-  direction: value === 0 ? 'balanced' : value > 0 ? 'credit' : 'debit',
+const makeMoney = (value: number, currency = "USD") => ({
+	value_milliunits: Math.round(value * 1000),
+	value: value,
+	value_display:
+		value < 0 ? `-$${Math.abs(value).toFixed(2)}` : `$${value.toFixed(2)}`,
+	currency,
+	direction: value === 0 ? "balanced" : value > 0 ? "credit" : "debit",
 });
 
-const buildAnalysis = (currency = 'USD'): ReconciliationAnalysis => ({
-  success: true,
-  phase: 'analysis',
-  summary: {
-    statement_date_range: '2025-10-01 to 2025-10-31',
-    bank_transactions_count: 1,
-    ynab_transactions_count: 1,
-    auto_matched: 0,
-    suggested_matches: 1,
-    unmatched_bank: 0,
-    unmatched_ynab: 0,
-    current_cleared_balance: makeMoney(-899.02, currency),
-    target_statement_balance: makeMoney(-899.02, currency),
-    discrepancy: makeMoney(0, currency),
-    discrepancy_explanation: 'Balanced',
-  },
-  auto_matches: [] as TransactionMatch[],
-  suggested_matches: [] as TransactionMatch[],
-  unmatched_bank: [],
-  unmatched_ynab: [],
-  balance_info: {
-    current_cleared: makeMoney(-899.02, currency),
-    current_uncleared: makeMoney(0, currency),
-    current_total: makeMoney(-899.02, currency),
-    target_statement: makeMoney(-899.02, currency),
-    discrepancy: makeMoney(0, currency),
-    on_track: true,
-  },
-  next_steps: ['Nothing to do'],
-  insights: [],
+const buildAnalysis = (currency = "USD"): ReconciliationAnalysis => ({
+	success: true,
+	phase: "analysis",
+	summary: {
+		statement_date_range: "2025-10-01 to 2025-10-31",
+		bank_transactions_count: 1,
+		ynab_transactions_count: 1,
+		ynab_in_range_count: 1,
+		ynab_outside_range_count: 0,
+		auto_matched: 0,
+		suggested_matches: 1,
+		unmatched_bank: 0,
+		unmatched_ynab: 0,
+		current_cleared_balance: makeMoney(-899.02, currency),
+		target_statement_balance: makeMoney(-899.02, currency),
+		discrepancy: makeMoney(0, currency),
+		discrepancy_explanation: "Balanced",
+	},
+	auto_matches: [] as TransactionMatch[],
+	suggested_matches: [] as TransactionMatch[],
+	unmatched_bank: [],
+	unmatched_ynab: [],
+	ynab_outside_date_range: [],
+	balance_info: {
+		current_cleared: makeMoney(-899.02, currency),
+		current_uncleared: makeMoney(0, currency),
+		current_total: makeMoney(-899.02, currency),
+		target_statement: makeMoney(-899.02, currency),
+		discrepancy: makeMoney(0, currency),
+		on_track: true,
+	},
+	next_steps: ["Nothing to do"],
+	insights: [],
 });
 
-describe('scenario: non-USD formatting in adapter payload', () => {
-  it('emits CAD currency values and csv_format metadata when provided', () => {
-    const payload = buildReconciliationPayload(buildAnalysis('CAD'), {
-      accountName: 'CAD VISA',
-      accountId: 'acct-123',
-      currencyCode: 'CAD',
-      csvFormat: {
-        delimiter: ';',
-        decimal_separator: ',',
-        thousands_separator: ' ',
-        date_format: 'DD/MM/YYYY',
-        header_row: true,
-        date_column: 'Date',
-        amount_column: 'Montant',
-        payee_column: 'Description',
-      },
-    });
+describe("scenario: non-USD formatting in adapter payload", () => {
+	it("emits CAD currency values and csv_format metadata when provided", () => {
+		const payload = buildReconciliationPayload(buildAnalysis("CAD"), {
+			accountName: "CAD VISA",
+			accountId: "acct-123",
+			currencyCode: "CAD",
+			csvFormat: {
+				delimiter: ";",
+				decimal_separator: ",",
+				thousands_separator: " ",
+				date_format: "DD/MM/YYYY",
+				header_row: true,
+				date_column: "Date",
+				amount_column: "Montant",
+				payee_column: "Description",
+			},
+		});
 
-    const structured = payload.structured as Record<string, any>;
-    expect(structured.balance.current_cleared.currency).toBe('CAD');
-    expect(structured.summary.current_cleared_balance.currency).toBe('CAD');
-    expect(structured.csv_format).toEqual({
-      delimiter: ';',
-      decimal_separator: ',',
-      thousands_separator: ' ',
-      date_format: 'DD/MM/YYYY',
-      header_row: true,
-      date_column: 'Date',
-      amount_column: 'Montant',
-      payee_column: 'Description',
-    });
-    expect(payload.human).toContain('CAD');
-  });
+		const structured = payload.structured as Record<string, any>;
+		expect(structured.balance.current_cleared.currency).toBe("CAD");
+		expect(structured.summary.current_cleared_balance.currency).toBe("CAD");
+		expect(structured.csv_format).toEqual({
+			delimiter: ";",
+			decimal_separator: ",",
+			thousands_separator: " ",
+			date_format: "DD/MM/YYYY",
+			header_row: true,
+			date_column: "Date",
+			amount_column: "Montant",
+			payee_column: "Description",
+		});
+		expect(payload.human).toContain("CAD");
+	});
 });

package/src/tools/reconciliation/__tests__/scenarios/extremes.scenario.test.ts

@@ -1,66 +1,78 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { analyzeReconciliation } from '../../analyzer.js';
-import type { TransactionDetail } from 'ynab';
-import * as csvParser from '../../csvParser.js';
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import type { TransactionDetail } from "ynab";
+import { analyzeReconciliation } from "../../analyzer.js";
+import * as csvParser from "../../csvParser.js";
 
-vi.mock('../../csvParser.js', () => ({
-  parseCSV: vi.fn(),
+vi.mock("../../csvParser.js", () => ({
+	parseCSV: vi.fn(),
 }));
 
-describe('scenario: zero, negative, and large statements', () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-  });
+describe("scenario: zero, negative, and large statements", () => {
+	beforeEach(() => {
+		vi.clearAllMocks();
+	});
 
-  it('handles zero and negative statement balances with mixed unmatched items', () => {
-    vi.mocked(csvParser.parseCSV).mockReturnValue({
-      transactions: [
-        {
-          id: 'b1',
-          date: '2025-11-01',
-          amount: 0,
-          payee: 'Zero Adjustment',
-          memo: '',
-          sourceRow: 2,
-          raw: { date: '2025-11-01', amount: '0', description: 'Zero Adjustment' },
-        },
-        {
-          id: 'b2',
-          date: '2025-11-02',
-          amount: 2500000,
-          payee: 'Interest',
-          memo: '',
-          sourceRow: 3,
-          raw: { date: '2025-11-02', amount: '2500.00', description: 'Interest' },
-        },
-      ],
-      errors: [],
-      warnings: [],
-      meta: {
-        detectedDelimiter: ',',
-        detectedColumns: ['Date', 'Description', 'Amount'],
-        totalRows: 2,
-        validRows: 2,
-        skippedRows: 0,
-      },
-    });
+	it("handles zero and negative statement balances with mixed unmatched items", () => {
+		vi.mocked(csvParser.parseCSV).mockReturnValue({
+			transactions: [
+				{
+					id: "b1",
+					date: "2025-11-01",
+					amount: 0,
+					payee: "Zero Adjustment",
+					memo: "",
+					sourceRow: 2,
+					raw: {
+						date: "2025-11-01",
+						amount: "0",
+						description: "Zero Adjustment",
+					},
+				},
+				{
+					id: "b2",
+					date: "2025-11-02",
+					amount: 2500000,
+					payee: "Interest",
+					memo: "",
+					sourceRow: 3,
+					raw: {
+						date: "2025-11-02",
+						amount: "2500.00",
+						description: "Interest",
+					},
+				},
+			],
+			errors: [],
+			warnings: [],
+			meta: {
+				detectedDelimiter: ",",
+				detectedColumns: ["Date", "Description", "Amount"],
+				totalRows: 2,
+				validRows: 2,
+				skippedRows: 0,
+			},
+		});
 
-    const ynabTxns: TransactionDetail[] = [
-      {
-        id: 'yn-neg',
-        date: '2025-10-31',
-        amount: -1000000,
-        payee_name: 'Mortgage',
-        category_name: 'Housing',
-        cleared: 'cleared',
-        approved: true,
-      } as TransactionDetail,
-    ];
+		const ynabTxns: TransactionDetail[] = [
+			{
+				id: "yn-neg",
+				date: "2025-10-31",
+				amount: -1000000,
+				payee_name: "Mortgage",
+				category_name: "Housing",
+				cleared: "cleared",
+				approved: true,
+			} as TransactionDetail,
+		];
 
-    const result = analyzeReconciliation('csv', undefined, ynabTxns, 0);
+		const result = analyzeReconciliation("csv", undefined, ynabTxns, 0);
 
-    expect(result.summary.unmatched_bank).toBeGreaterThan(0);
-    expect(result.summary.unmatched_ynab).toBeGreaterThan(0);
-    expect(result.balance_info.discrepancy).not.toBeNaN();
-  });
+		expect(result.summary.unmatched_bank).toBeGreaterThan(0);
+		// The YNAB transaction from Oct 31 is within the 7-day tolerance buffer
+		// of the statement period (Nov 1-2), so it's included for matching.
+		// Since it doesn't match any bank transactions, it goes to unmatched_ynab.
+		expect(result.summary.ynab_in_range_count).toBe(1);
+		expect(result.summary.unmatched_ynab).toBe(1);
+		expect(result.balance_info.discrepancy).not.toBeNaN();
+	});
 });

package/src/tools/reconciliation/__tests__/scenarios/repeatAmount.scenario.test.ts

@@ -1,96 +1,110 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { analyzeReconciliation } from '../../analyzer.js';
-import type { TransactionDetail } from 'ynab';
-import * as csvParser from '../../csvParser.js';
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import type { TransactionDetail } from "ynab";
+import { analyzeReconciliation } from "../../analyzer.js";
+import * as csvParser from "../../csvParser.js";
 
-vi.mock('../../csvParser.js', () => ({
-  parseCSV: vi.fn(),
+vi.mock("../../csvParser.js", () => ({
+	parseCSV: vi.fn(),
 }));
 
-describe('scenario: repeat amount collisions', () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-  });
+describe("scenario: repeat amount collisions", () => {
+	beforeEach(() => {
+		vi.clearAllMocks();
+	});
 
-  it('prioritizes repeat-amount insight when multiple bank rows share totals', () => {
-    vi.mocked(csvParser.parseCSV).mockReturnValue({
-      transactions: [
-        // Three -22.22 transactions in milliunits: one will match YNAB, two will remain unmatched
-        {
-          id: 'b1',
-          date: '2025-10-20',
-          amount: -22220,
-          payee: 'RideShare',
-          memo: '',
-          sourceRow: 2,
-          raw: { date: '2025-10-20', amount: '-22.22', description: 'RideShare' },
-        },
-        {
-          id: 'b2',
-          date: '2025-10-21',
-          amount: -22220,
-          payee: 'RideShare',
-          memo: '',
-          sourceRow: 3,
-          raw: { date: '2025-10-21', amount: '-22.22', description: 'RideShare' },
-        },
-        {
-          id: 'b3',
-          date: '2025-10-25',
-          amount: -22220,
-          payee: 'RideShare',
-          memo: '',
-          sourceRow: 4,
-          raw: { date: '2025-10-25', amount: '-22.22', description: 'RideShare' },
-        },
-        {
-          id: 'b4',
-          date: '2025-10-23',
-          amount: -15000,
-          payee: 'Cafe',
-          memo: '',
-          sourceRow: 5,
-          raw: { date: '2025-10-23', amount: '-15.00', description: 'Cafe' },
-        },
-      ],
-      errors: [],
-      warnings: [],
-      meta: {
-        detectedDelimiter: ',',
-        detectedColumns: ['Date', 'Description', 'Amount'],
-        totalRows: 4,
-        validRows: 4,
-        skippedRows: 0,
-      },
-    });
+	it("prioritizes repeat-amount insight when multiple bank rows share totals", () => {
+		vi.mocked(csvParser.parseCSV).mockReturnValue({
+			transactions: [
+				// Three -22.22 transactions in milliunits: one will match YNAB, two will remain unmatched
+				{
+					id: "b1",
+					date: "2025-10-20",
+					amount: -22220,
+					payee: "RideShare",
+					memo: "",
+					sourceRow: 2,
+					raw: {
+						date: "2025-10-20",
+						amount: "-22.22",
+						description: "RideShare",
+					},
+				},
+				{
+					id: "b2",
+					date: "2025-10-21",
+					amount: -22220,
+					payee: "RideShare",
+					memo: "",
+					sourceRow: 3,
+					raw: {
+						date: "2025-10-21",
+						amount: "-22.22",
+						description: "RideShare",
+					},
+				},
+				{
+					id: "b3",
+					date: "2025-10-25",
+					amount: -22220,
+					payee: "RideShare",
+					memo: "",
+					sourceRow: 4,
+					raw: {
+						date: "2025-10-25",
+						amount: "-22.22",
+						description: "RideShare",
+					},
+				},
+				{
+					id: "b4",
+					date: "2025-10-23",
+					amount: -15000,
+					payee: "Cafe",
+					memo: "",
+					sourceRow: 5,
+					raw: { date: "2025-10-23", amount: "-15.00", description: "Cafe" },
+				},
+			],
+			errors: [],
+			warnings: [],
+			meta: {
+				detectedDelimiter: ",",
+				detectedColumns: ["Date", "Description", "Amount"],
+				totalRows: 4,
+				validRows: 4,
+				skippedRows: 0,
+			},
+		});
 
-    const ynabTxns: TransactionDetail[] = [
-      {
-        id: 'yn-1',
-        date: '2025-10-19',
-        amount: -22220,
-        payee_name: 'RideShare',
-        category_name: 'Transport',
-        cleared: 'uncleared',
-        approved: true,
-      } as TransactionDetail,
-      {
-        id: 'yn-2',
-        date: '2025-10-22',
-        amount: -15000,
-        payee_name: 'Cafe',
-        category_name: 'Dining',
-        cleared: 'uncleared',
-        approved: true,
-      } as TransactionDetail,
-    ];
+		const ynabTxns: TransactionDetail[] = [
+			{
+				id: "yn-1",
+				date: "2025-10-19",
+				amount: -22220,
+				payee_name: "RideShare",
+				category_name: "Transport",
+				cleared: "uncleared",
+				approved: true,
+			} as TransactionDetail,
+			{
+				id: "yn-2",
+				date: "2025-10-22",
+				amount: -15000,
+				payee_name: "Cafe",
+				category_name: "Dining",
+				cleared: "uncleared",
+				approved: true,
+			} as TransactionDetail,
+		];
 
-    // Statement balance now accounts for 3 x -22.22 + 1 x -15.00 = -81.66
-    const result = analyzeReconciliation('csv', undefined, ynabTxns, -81.66);
+		// Statement balance now accounts for 3 x -22.22 + 1 x -15.00 = -81.66
+		const result = analyzeReconciliation("csv", undefined, ynabTxns, -81.66);
 
-    const repeatInsight = result.insights.find((insight) => insight.id.startsWith('repeat--22220')); // amount in milliunits, double dash for negative
-    expect(repeatInsight).toBeDefined();
-    expect(repeatInsight?.severity).toBe('warning');
-    expect(result.summary.unmatched_bank).toBeGreaterThan(0);
-  });
+		const repeatInsight = result.insights.find((insight) =>
+			insight.id.startsWith("repeat--22220"),
+		); // amount in milliunits, double dash for negative
+		expect(repeatInsight).toBeDefined();
+		expect(repeatInsight?.severity).toBe("warning");
+		expect(result.summary.unmatched_bank).toBeGreaterThan(0);
+	});
 });

package/src/tools/reconciliation/__tests__/schemaUrl.test.ts

@@ -1,49 +1,64 @@
-import { describe, it, expect } from 'vitest';
-import type { ReconciliationAnalysis } from '../types.js';
-import { buildReconciliationPayload } from '../../reconcileAdapter.js';
+import { describe, expect, it } from "vitest";
+import { buildReconciliationPayload } from "../../reconcileAdapter.js";
+import type { ReconciliationAnalysis } from "../types.js";
+
+const makeMoney = (value: number, currency = "USD") => ({
+	value_milliunits: Math.round(value * 1000),
+	value,
+	value_display:
+		value < 0 ? `-$${Math.abs(value).toFixed(2)}` : `$${value.toFixed(2)}`,
+	currency,
+	direction: (value === 0 ? "balanced" : value > 0 ? "credit" : "debit") as
+		| "balanced"
+		| "credit"
+		| "debit",
+});
 
 const minimalAnalysis: ReconciliationAnalysis = {
-  success: true,
-  phase: 'analysis',
-  summary: {
-    statement_date_range: '2025-10-01 to 2025-10-31',
-    bank_transactions_count: 0,
-    ynab_transactions_count: 0,
-    auto_matched: 0,
-    suggested_matches: 0,
-    unmatched_bank: 0,
-    unmatched_ynab: 0,
-    current_cleared_balance: 0,
-    target_statement_balance: 0,
-    discrepancy: 0,
-    discrepancy_explanation: 'Balanced',
-  },
-  auto_matches: [],
-  suggested_matches: [],
-  unmatched_bank: [],
-  unmatched_ynab: [],
-  balance_info: {
-    current_cleared: 0,
-    current_uncleared: 0,
-    current_total: 0,
-    target_statement: 0,
-    discrepancy: 0,
-    on_track: true,
-  },
-  next_steps: [],
-  insights: [],
+	success: true,
+	phase: "analysis",
+	summary: {
+		statement_date_range: "2025-10-01 to 2025-10-31",
+		bank_transactions_count: 0,
+		ynab_transactions_count: 0,
+		ynab_in_range_count: 0,
+		ynab_outside_range_count: 0,
+		auto_matched: 0,
+		suggested_matches: 0,
+		unmatched_bank: 0,
+		unmatched_ynab: 0,
+		current_cleared_balance: makeMoney(0),
+		target_statement_balance: makeMoney(0),
+		discrepancy: makeMoney(0),
+		discrepancy_explanation: "Balanced",
+	},
+	auto_matches: [],
+	suggested_matches: [],
+	unmatched_bank: [],
+	unmatched_ynab: [],
+	ynab_outside_date_range: [],
+	balance_info: {
+		current_cleared: makeMoney(0),
+		current_uncleared: makeMoney(0),
+		current_total: makeMoney(0),
+		target_statement: makeMoney(0),
+		discrepancy: makeMoney(0),
+		on_track: true,
+	},
+	next_steps: [],
+	insights: [],
 };
 
-describe('buildReconciliationPayload schema reference', () => {
-  it('points to the master branch schema file on raw.githubusercontent.com', () => {
-    const { structured } = buildReconciliationPayload(minimalAnalysis, {
-      accountId: 'acct-id',
-      accountName: 'Checking',
-      currencyCode: 'USD',
-    });
+describe("buildReconciliationPayload schema reference", () => {
+	it("points to the master branch schema file on raw.githubusercontent.com", () => {
+		const { structured } = buildReconciliationPayload(minimalAnalysis, {
+			accountId: "acct-id",
+			accountName: "Checking",
+			currencyCode: "USD",
+		});
 
-    const schemaUrl = (structured as Record<string, unknown>).schema_url;
-    expect(schemaUrl).toContain('raw.githubusercontent.com');
-    expect(schemaUrl).toContain('/docs/schemas/reconciliation-v2.json');
-  });
+		const schemaUrl = (structured as Record<string, unknown>).schema_url;
+		expect(schemaUrl).toContain("raw.githubusercontent.com");
+		expect(schemaUrl).toContain("/docs/schemas/reconciliation-v2.json");
+	});
 });