@dizzlkheinz/ynab-mcpb 0.18.3 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (346) hide show
  1. package/CHANGELOG.md +17 -0
  2. package/CLAUDE.md +87 -8
  3. package/bin/ynab-mcp-server.cjs +2 -2
  4. package/bin/ynab-mcp-server.js +3 -3
  5. package/biome.json +39 -0
  6. package/dist/bundle/index.cjs +67 -67
  7. package/dist/index.d.ts +1 -1
  8. package/dist/index.js +27 -27
  9. package/dist/server/YNABMCPServer.d.ts +3 -4
  10. package/dist/server/YNABMCPServer.js +111 -116
  11. package/dist/server/budgetResolver.d.ts +6 -5
  12. package/dist/server/budgetResolver.js +46 -36
  13. package/dist/server/cacheKeys.js +6 -6
  14. package/dist/server/cacheManager.js +14 -11
  15. package/dist/server/completions.d.ts +2 -2
  16. package/dist/server/completions.js +20 -15
  17. package/dist/server/config.d.ts +10 -5
  18. package/dist/server/config.js +24 -7
  19. package/dist/server/deltaCache.d.ts +2 -2
  20. package/dist/server/deltaCache.js +22 -16
  21. package/dist/server/deltaCache.merge.d.ts +2 -2
  22. package/dist/server/diagnostics.d.ts +4 -4
  23. package/dist/server/diagnostics.js +38 -32
  24. package/dist/server/errorHandler.d.ts +5 -12
  25. package/dist/server/errorHandler.js +219 -217
  26. package/dist/server/prompts.d.ts +2 -2
  27. package/dist/server/prompts.js +45 -45
  28. package/dist/server/rateLimiter.js +4 -4
  29. package/dist/server/requestLogger.d.ts +1 -1
  30. package/dist/server/requestLogger.js +40 -35
  31. package/dist/server/resources.d.ts +3 -3
  32. package/dist/server/resources.js +55 -52
  33. package/dist/server/responseFormatter.js +6 -6
  34. package/dist/server/securityMiddleware.d.ts +2 -2
  35. package/dist/server/securityMiddleware.js +22 -20
  36. package/dist/server/serverKnowledgeStore.js +1 -1
  37. package/dist/server/toolRegistry.d.ts +3 -3
  38. package/dist/server/toolRegistry.js +47 -40
  39. package/dist/tools/__tests__/deltaTestUtils.d.ts +3 -3
  40. package/dist/tools/__tests__/deltaTestUtils.js +2 -2
  41. package/dist/tools/accountTools.d.ts +9 -8
  42. package/dist/tools/accountTools.js +47 -47
  43. package/dist/tools/adapters.d.ts +13 -8
  44. package/dist/tools/adapters.js +21 -11
  45. package/dist/tools/budgetTools.d.ts +8 -7
  46. package/dist/tools/budgetTools.js +22 -22
  47. package/dist/tools/categoryTools.d.ts +9 -8
  48. package/dist/tools/categoryTools.js +68 -59
  49. package/dist/tools/compareTransactions/formatter.d.ts +3 -3
  50. package/dist/tools/compareTransactions/formatter.js +9 -9
  51. package/dist/tools/compareTransactions/index.d.ts +6 -6
  52. package/dist/tools/compareTransactions/index.js +58 -43
  53. package/dist/tools/compareTransactions/matcher.d.ts +1 -1
  54. package/dist/tools/compareTransactions/matcher.js +28 -15
  55. package/dist/tools/compareTransactions/parser.d.ts +2 -2
  56. package/dist/tools/compareTransactions/parser.js +144 -138
  57. package/dist/tools/compareTransactions/types.d.ts +4 -4
  58. package/dist/tools/compareTransactions.d.ts +1 -1
  59. package/dist/tools/compareTransactions.js +1 -1
  60. package/dist/tools/deltaFetcher.d.ts +2 -2
  61. package/dist/tools/deltaFetcher.js +16 -15
  62. package/dist/tools/deltaSupport.d.ts +4 -4
  63. package/dist/tools/deltaSupport.js +35 -41
  64. package/dist/tools/exportTransactions.d.ts +5 -4
  65. package/dist/tools/exportTransactions.js +61 -59
  66. package/dist/tools/monthTools.d.ts +7 -6
  67. package/dist/tools/monthTools.js +31 -29
  68. package/dist/tools/payeeTools.d.ts +7 -6
  69. package/dist/tools/payeeTools.js +28 -28
  70. package/dist/tools/reconcileAdapter.d.ts +2 -2
  71. package/dist/tools/reconcileAdapter.js +21 -11
  72. package/dist/tools/reconciliation/analyzer.d.ts +4 -4
  73. package/dist/tools/reconciliation/analyzer.js +136 -57
  74. package/dist/tools/reconciliation/csvParser.d.ts +3 -3
  75. package/dist/tools/reconciliation/csvParser.js +128 -104
  76. package/dist/tools/reconciliation/executor.d.ts +4 -4
  77. package/dist/tools/reconciliation/executor.js +148 -109
  78. package/dist/tools/reconciliation/index.d.ts +10 -10
  79. package/dist/tools/reconciliation/index.js +96 -83
  80. package/dist/tools/reconciliation/matcher.d.ts +3 -3
  81. package/dist/tools/reconciliation/matcher.js +17 -16
  82. package/dist/tools/reconciliation/payeeNormalizer.js +19 -8
  83. package/dist/tools/reconciliation/recommendationEngine.d.ts +1 -1
  84. package/dist/tools/reconciliation/recommendationEngine.js +40 -40
  85. package/dist/tools/reconciliation/reportFormatter.d.ts +2 -2
  86. package/dist/tools/reconciliation/reportFormatter.js +79 -54
  87. package/dist/tools/reconciliation/signDetector.d.ts +1 -1
  88. package/dist/tools/reconciliation/types.d.ts +19 -16
  89. package/dist/tools/reconciliation/ynabAdapter.d.ts +2 -2
  90. package/dist/tools/schemas/common.d.ts +1 -1
  91. package/dist/tools/schemas/common.js +1 -1
  92. package/dist/tools/schemas/outputs/accountOutputs.d.ts +1 -1
  93. package/dist/tools/schemas/outputs/accountOutputs.js +24 -18
  94. package/dist/tools/schemas/outputs/budgetOutputs.d.ts +1 -1
  95. package/dist/tools/schemas/outputs/budgetOutputs.js +14 -11
  96. package/dist/tools/schemas/outputs/categoryOutputs.d.ts +1 -1
  97. package/dist/tools/schemas/outputs/categoryOutputs.js +49 -29
  98. package/dist/tools/schemas/outputs/comparisonOutputs.d.ts +1 -1
  99. package/dist/tools/schemas/outputs/comparisonOutputs.js +12 -12
  100. package/dist/tools/schemas/outputs/index.d.ts +14 -14
  101. package/dist/tools/schemas/outputs/index.js +14 -14
  102. package/dist/tools/schemas/outputs/monthOutputs.d.ts +1 -1
  103. package/dist/tools/schemas/outputs/monthOutputs.js +56 -41
  104. package/dist/tools/schemas/outputs/payeeOutputs.d.ts +1 -1
  105. package/dist/tools/schemas/outputs/payeeOutputs.js +10 -10
  106. package/dist/tools/schemas/outputs/reconciliationOutputs.d.ts +2 -2
  107. package/dist/tools/schemas/outputs/reconciliationOutputs.js +45 -45
  108. package/dist/tools/schemas/outputs/transactionMutationOutputs.d.ts +1 -1
  109. package/dist/tools/schemas/outputs/transactionMutationOutputs.js +28 -22
  110. package/dist/tools/schemas/outputs/transactionOutputs.d.ts +1 -1
  111. package/dist/tools/schemas/outputs/transactionOutputs.js +43 -35
  112. package/dist/tools/schemas/outputs/utilityOutputs.d.ts +1 -1
  113. package/dist/tools/schemas/outputs/utilityOutputs.js +5 -3
  114. package/dist/tools/schemas/shared/commonOutputs.d.ts +1 -1
  115. package/dist/tools/schemas/shared/commonOutputs.js +15 -9
  116. package/dist/tools/transactionReadTools.d.ts +11 -0
  117. package/dist/tools/transactionReadTools.js +202 -0
  118. package/dist/tools/transactionSchemas.d.ts +309 -0
  119. package/dist/tools/transactionSchemas.js +235 -0
  120. package/dist/tools/transactionTools.d.ts +6 -302
  121. package/dist/tools/transactionTools.js +7 -2054
  122. package/dist/tools/transactionUtils.d.ts +31 -0
  123. package/dist/tools/transactionUtils.js +364 -0
  124. package/dist/tools/transactionWriteTools.d.ts +20 -0
  125. package/dist/tools/transactionWriteTools.js +1342 -0
  126. package/dist/tools/utilityTools.d.ts +5 -4
  127. package/dist/tools/utilityTools.js +11 -11
  128. package/dist/types/index.d.ts +7 -7
  129. package/dist/types/index.js +6 -6
  130. package/dist/types/reconciliation.d.ts +1 -1
  131. package/dist/types/toolRegistration.d.ts +14 -12
  132. package/dist/utils/amountUtils.js +1 -1
  133. package/dist/utils/dateUtils.js +4 -4
  134. package/dist/utils/errors.d.ts +3 -3
  135. package/dist/utils/errors.js +4 -4
  136. package/dist/utils/money.d.ts +2 -2
  137. package/dist/utils/money.js +8 -8
  138. package/dist/utils/validationError.d.ts +1 -1
  139. package/dist/utils/validationError.js +1 -1
  140. package/docs/assets/examples/reconciliation-with-recommendations.json +66 -66
  141. package/docs/assets/schemas/reconciliation-v2.json +360 -336
  142. package/docs/plans/2025-12-25-transaction-tools-refactor-design.md +211 -0
  143. package/docs/plans/2025-12-25-transaction-tools-refactor.md +905 -0
  144. package/esbuild.config.mjs +53 -50
  145. package/meta.json +12548 -12548
  146. package/package.json +98 -109
  147. package/scripts/analyze-bundle.mjs +33 -30
  148. package/scripts/create-pr-description.js +169 -120
  149. package/scripts/run-all-tests.js +205 -0
  150. package/scripts/run-domain-integration-tests.js +28 -18
  151. package/scripts/run-generate-mcpb.js +19 -17
  152. package/scripts/run-throttled-integration-tests.js +92 -83
  153. package/scripts/test-delta-params.mjs +149 -120
  154. package/scripts/test-recommendations.ts +36 -32
  155. package/scripts/tmpTransaction.ts +80 -43
  156. package/scripts/validate-env.js +98 -91
  157. package/scripts/verify-build.js +78 -76
  158. package/src/__tests__/comprehensive.integration.test.ts +1281 -1154
  159. package/src/__tests__/performance.test.ts +723 -671
  160. package/src/__tests__/setup.ts +442 -395
  161. package/src/__tests__/smoke.e2e.test.ts +41 -39
  162. package/src/__tests__/testRunner.ts +314 -295
  163. package/src/__tests__/testUtils.ts +456 -364
  164. package/src/__tests__/tools/reconciliation/csvParser.integration.test.ts +109 -107
  165. package/src/__tests__/tools/reconciliation/real-world.integration.test.ts +41 -41
  166. package/src/index.ts +68 -59
  167. package/src/server/CLAUDE.md +480 -0
  168. package/src/server/YNABMCPServer.ts +821 -794
  169. package/src/server/__tests__/YNABMCPServer.integration.test.ts +929 -893
  170. package/src/server/__tests__/YNABMCPServer.test.ts +903 -899
  171. package/src/server/__tests__/budgetResolver.test.ts +466 -423
  172. package/src/server/__tests__/cacheManager.test.ts +891 -874
  173. package/src/server/__tests__/completions.integration.test.ts +115 -106
  174. package/src/server/__tests__/completions.test.ts +334 -313
  175. package/src/server/__tests__/config.test.ts +98 -86
  176. package/src/server/__tests__/deltaCache.merge.test.ts +774 -703
  177. package/src/server/__tests__/deltaCache.swr.test.ts +198 -153
  178. package/src/server/__tests__/deltaCache.test.ts +946 -759
  179. package/src/server/__tests__/diagnostics.test.ts +825 -792
  180. package/src/server/__tests__/errorHandler.integration.test.ts +512 -462
  181. package/src/server/__tests__/errorHandler.test.ts +402 -397
  182. package/src/server/__tests__/prompts.test.ts +424 -347
  183. package/src/server/__tests__/rateLimiter.test.ts +313 -309
  184. package/src/server/__tests__/requestLogger.test.ts +443 -403
  185. package/src/server/__tests__/resources.template.test.ts +196 -185
  186. package/src/server/__tests__/resources.test.ts +294 -288
  187. package/src/server/__tests__/security.integration.test.ts +487 -421
  188. package/src/server/__tests__/securityMiddleware.test.ts +519 -444
  189. package/src/server/__tests__/server-startup.integration.test.ts +509 -490
  190. package/src/server/__tests__/serverKnowledgeStore.test.ts +174 -173
  191. package/src/server/__tests__/toolRegistration.test.ts +239 -210
  192. package/src/server/__tests__/toolRegistry.test.ts +907 -845
  193. package/src/server/budgetResolver.ts +221 -181
  194. package/src/server/cacheKeys.ts +6 -6
  195. package/src/server/cacheManager.ts +498 -484
  196. package/src/server/completions.ts +267 -243
  197. package/src/server/config.ts +35 -14
  198. package/src/server/deltaCache.merge.ts +146 -128
  199. package/src/server/deltaCache.ts +352 -309
  200. package/src/server/diagnostics.ts +257 -242
  201. package/src/server/errorHandler.ts +747 -744
  202. package/src/server/prompts.ts +181 -176
  203. package/src/server/rateLimiter.ts +131 -129
  204. package/src/server/requestLogger.ts +350 -322
  205. package/src/server/resources.ts +442 -374
  206. package/src/server/responseFormatter.ts +41 -37
  207. package/src/server/securityMiddleware.ts +223 -205
  208. package/src/server/serverKnowledgeStore.ts +67 -67
  209. package/src/server/toolRegistry.ts +508 -474
  210. package/src/tools/CLAUDE.md +604 -0
  211. package/src/tools/__tests__/accountTools.delta.integration.test.ts +128 -111
  212. package/src/tools/__tests__/accountTools.integration.test.ts +129 -111
  213. package/src/tools/__tests__/accountTools.test.ts +685 -638
  214. package/src/tools/__tests__/adapters.test.ts +142 -108
  215. package/src/tools/__tests__/budgetTools.delta.integration.test.ts +73 -73
  216. package/src/tools/__tests__/budgetTools.integration.test.ts +132 -124
  217. package/src/tools/__tests__/budgetTools.test.ts +442 -413
  218. package/src/tools/__tests__/categoryTools.delta.integration.test.ts +76 -68
  219. package/src/tools/__tests__/categoryTools.integration.test.ts +314 -288
  220. package/src/tools/__tests__/categoryTools.test.ts +656 -625
  221. package/src/tools/__tests__/compareTransactions/formatter.test.ts +535 -462
  222. package/src/tools/__tests__/compareTransactions/index.test.ts +378 -358
  223. package/src/tools/__tests__/compareTransactions/matcher.test.ts +497 -398
  224. package/src/tools/__tests__/compareTransactions/parser.test.ts +765 -747
  225. package/src/tools/__tests__/compareTransactions.test.ts +352 -332
  226. package/src/tools/__tests__/compareTransactions.window.test.ts +150 -146
  227. package/src/tools/__tests__/deltaFetcher.scheduled.integration.test.ts +69 -65
  228. package/src/tools/__tests__/deltaFetcher.test.ts +325 -265
  229. package/src/tools/__tests__/deltaSupport.test.ts +211 -184
  230. package/src/tools/__tests__/deltaTestUtils.ts +37 -33
  231. package/src/tools/__tests__/exportTransactions.test.ts +205 -200
  232. package/src/tools/__tests__/monthTools.delta.integration.test.ts +68 -68
  233. package/src/tools/__tests__/monthTools.integration.test.ts +178 -166
  234. package/src/tools/__tests__/monthTools.test.ts +561 -512
  235. package/src/tools/__tests__/payeeTools.delta.integration.test.ts +68 -68
  236. package/src/tools/__tests__/payeeTools.integration.test.ts +158 -142
  237. package/src/tools/__tests__/payeeTools.test.ts +486 -434
  238. package/src/tools/__tests__/transactionSchemas.test.ts +1204 -0
  239. package/src/tools/__tests__/transactionTools.integration.test.ts +875 -825
  240. package/src/tools/__tests__/transactionTools.test.ts +4923 -4366
  241. package/src/tools/__tests__/transactionUtils.test.ts +1016 -0
  242. package/src/tools/__tests__/utilityTools.integration.test.ts +32 -32
  243. package/src/tools/__tests__/utilityTools.test.ts +68 -58
  244. package/src/tools/accountTools.ts +293 -271
  245. package/src/tools/adapters.ts +120 -63
  246. package/src/tools/budgetTools.ts +121 -116
  247. package/src/tools/categoryTools.ts +379 -339
  248. package/src/tools/compareTransactions/formatter.ts +131 -119
  249. package/src/tools/compareTransactions/index.ts +249 -214
  250. package/src/tools/compareTransactions/matcher.ts +259 -209
  251. package/src/tools/compareTransactions/parser.ts +517 -487
  252. package/src/tools/compareTransactions/types.ts +38 -38
  253. package/src/tools/compareTransactions.ts +1 -1
  254. package/src/tools/deltaFetcher.ts +281 -260
  255. package/src/tools/deltaSupport.ts +264 -259
  256. package/src/tools/exportTransactions.ts +230 -218
  257. package/src/tools/monthTools.ts +180 -165
  258. package/src/tools/payeeTools.ts +152 -140
  259. package/src/tools/reconcileAdapter.ts +297 -246
  260. package/src/tools/reconciliation/CLAUDE.md +506 -0
  261. package/src/tools/reconciliation/__tests__/adapter.causes.test.ts +135 -112
  262. package/src/tools/reconciliation/__tests__/adapter.test.ts +249 -227
  263. package/src/tools/reconciliation/__tests__/analyzer.test.ts +408 -335
  264. package/src/tools/reconciliation/__tests__/csvParser.test.ts +71 -69
  265. package/src/tools/reconciliation/__tests__/executor.integration.test.ts +348 -323
  266. package/src/tools/reconciliation/__tests__/executor.progress.test.ts +503 -457
  267. package/src/tools/reconciliation/__tests__/executor.test.ts +898 -831
  268. package/src/tools/reconciliation/__tests__/matcher.test.ts +667 -663
  269. package/src/tools/reconciliation/__tests__/payeeNormalizer.test.ts +296 -276
  270. package/src/tools/reconciliation/__tests__/recommendationEngine.integration.test.ts +692 -624
  271. package/src/tools/reconciliation/__tests__/recommendationEngine.test.ts +1008 -986
  272. package/src/tools/reconciliation/__tests__/reconciliation.delta.integration.test.ts +187 -146
  273. package/src/tools/reconciliation/__tests__/reportFormatter.test.ts +583 -530
  274. package/src/tools/reconciliation/__tests__/scenarios/adapterCurrency.scenario.test.ts +75 -71
  275. package/src/tools/reconciliation/__tests__/scenarios/extremes.scenario.test.ts +70 -58
  276. package/src/tools/reconciliation/__tests__/scenarios/repeatAmount.scenario.test.ts +102 -88
  277. package/src/tools/reconciliation/__tests__/schemaUrl.test.ts +58 -43
  278. package/src/tools/reconciliation/__tests__/signDetector.test.ts +209 -206
  279. package/src/tools/reconciliation/__tests__/ynabAdapter.test.ts +66 -60
  280. package/src/tools/reconciliation/analyzer.ts +582 -406
  281. package/src/tools/reconciliation/csvParser.ts +656 -609
  282. package/src/tools/reconciliation/executor.ts +1290 -1128
  283. package/src/tools/reconciliation/index.ts +580 -528
  284. package/src/tools/reconciliation/matcher.ts +256 -240
  285. package/src/tools/reconciliation/payeeNormalizer.ts +92 -78
  286. package/src/tools/reconciliation/recommendationEngine.ts +357 -345
  287. package/src/tools/reconciliation/reportFormatter.ts +349 -276
  288. package/src/tools/reconciliation/signDetector.ts +89 -83
  289. package/src/tools/reconciliation/types.ts +164 -153
  290. package/src/tools/reconciliation/ynabAdapter.ts +17 -15
  291. package/src/tools/schemas/CLAUDE.md +546 -0
  292. package/src/tools/schemas/common.ts +1 -1
  293. package/src/tools/schemas/outputs/__tests__/accountOutputs.test.ts +410 -409
  294. package/src/tools/schemas/outputs/__tests__/budgetOutputs.test.ts +305 -299
  295. package/src/tools/schemas/outputs/__tests__/categoryOutputs.test.ts +431 -430
  296. package/src/tools/schemas/outputs/__tests__/comparisonOutputs.test.ts +510 -495
  297. package/src/tools/schemas/outputs/__tests__/dateValidation.test.ts +179 -153
  298. package/src/tools/schemas/outputs/__tests__/discrepancyDirection.test.ts +293 -254
  299. package/src/tools/schemas/outputs/__tests__/monthOutputs.test.ts +457 -457
  300. package/src/tools/schemas/outputs/__tests__/payeeOutputs.test.ts +362 -356
  301. package/src/tools/schemas/outputs/__tests__/reconciliationOutputs.test.ts +402 -399
  302. package/src/tools/schemas/outputs/__tests__/transactionMutationSchemas.test.ts +225 -211
  303. package/src/tools/schemas/outputs/__tests__/transactionOutputs.test.ts +457 -454
  304. package/src/tools/schemas/outputs/__tests__/utilityOutputs.test.ts +316 -315
  305. package/src/tools/schemas/outputs/accountOutputs.ts +40 -34
  306. package/src/tools/schemas/outputs/budgetOutputs.ts +24 -19
  307. package/src/tools/schemas/outputs/categoryOutputs.ts +76 -56
  308. package/src/tools/schemas/outputs/comparisonOutputs.ts +192 -169
  309. package/src/tools/schemas/outputs/index.ts +163 -163
  310. package/src/tools/schemas/outputs/monthOutputs.ts +95 -80
  311. package/src/tools/schemas/outputs/payeeOutputs.ts +18 -18
  312. package/src/tools/schemas/outputs/reconciliationOutputs.ts +386 -373
  313. package/src/tools/schemas/outputs/transactionMutationOutputs.ts +259 -231
  314. package/src/tools/schemas/outputs/transactionOutputs.ts +81 -71
  315. package/src/tools/schemas/outputs/utilityOutputs.ts +90 -84
  316. package/src/tools/schemas/shared/commonOutputs.ts +27 -19
  317. package/src/tools/toolCategories.ts +114 -114
  318. package/src/tools/transactionReadTools.ts +327 -0
  319. package/src/tools/transactionSchemas.ts +484 -0
  320. package/src/tools/transactionTools.ts +107 -2990
  321. package/src/tools/transactionUtils.ts +621 -0
  322. package/src/tools/transactionWriteTools.ts +2110 -0
  323. package/src/tools/utilityTools.ts +46 -41
  324. package/src/types/CLAUDE.md +477 -0
  325. package/src/types/__tests__/index.test.ts +51 -51
  326. package/src/types/index.ts +43 -39
  327. package/src/types/integration-tests.d.ts +26 -26
  328. package/src/types/reconciliation.ts +29 -29
  329. package/src/types/toolAnnotations.ts +30 -30
  330. package/src/types/toolRegistration.ts +43 -32
  331. package/src/utils/CLAUDE.md +508 -0
  332. package/src/utils/__tests__/dateUtils.test.ts +174 -168
  333. package/src/utils/__tests__/money.test.ts +193 -187
  334. package/src/utils/amountUtils.ts +5 -5
  335. package/src/utils/baseError.ts +5 -5
  336. package/src/utils/dateUtils.ts +29 -26
  337. package/src/utils/errors.ts +14 -14
  338. package/src/utils/money.ts +66 -52
  339. package/src/utils/validationError.ts +1 -1
  340. package/tsconfig.json +29 -29
  341. package/tsconfig.prod.json +16 -16
  342. package/vitest-reporters/split-json-reporter.ts +247 -204
  343. package/vitest.config.ts +99 -95
  344. package/.prettierignore +0 -10
  345. package/.prettierrc.json +0 -10
  346. package/eslint.config.js +0 -49
@@ -1,724 +1,795 @@
1
- import { describe, expect, it } from 'vitest';
2
- import * as ynab from 'ynab';
3
- import { mergeCategories, mergeFlatEntities, mergeTransactions } from '../deltaCache.merge.js';
4
-
5
- const buildCategory = (overrides: Partial<ynab.Category> = {}): ynab.Category => ({
6
- id: overrides.id ?? 'cat-1',
7
- category_group_id: overrides.category_group_id ?? 'group-1',
8
- category_group_name: overrides.category_group_name,
9
- name: overrides.name ?? 'Category 1',
10
- hidden: overrides.hidden ?? false,
11
- original_category_group_id: overrides.original_category_group_id ?? null,
12
- note: overrides.note ?? null,
13
- budgeted: overrides.budgeted ?? 0,
14
- activity: overrides.activity ?? 0,
15
- balance: overrides.balance ?? 0,
16
- goal_type: overrides.goal_type ?? null,
17
- goal_needs_whole_amount: overrides.goal_needs_whole_amount ?? null,
18
- goal_day: overrides.goal_day ?? null,
19
- goal_cadence: overrides.goal_cadence ?? null,
20
- goal_cadence_frequency: overrides.goal_cadence_frequency ?? null,
21
- goal_creation_month: overrides.goal_creation_month ?? null,
22
- goal_target: overrides.goal_target ?? null,
23
- goal_target_month: overrides.goal_target_month ?? null,
24
- goal_percentage_complete: overrides.goal_percentage_complete ?? null,
25
- goal_months_to_budget: overrides.goal_months_to_budget ?? null,
26
- goal_under_funded: overrides.goal_under_funded ?? null,
27
- goal_overall_funded: overrides.goal_overall_funded ?? null,
28
- goal_overall_left: overrides.goal_overall_left ?? null,
29
- goal_snoozed_at: overrides.goal_snoozed_at ?? null,
30
- deleted: overrides.deleted ?? false,
1
+ import { describe, expect, it } from "vitest";
2
+ import * as ynab from "ynab";
3
+ import {
4
+ mergeCategories,
5
+ mergeFlatEntities,
6
+ mergeTransactions,
7
+ } from "../deltaCache.merge.js";
8
+
9
+ const buildCategory = (
10
+ overrides: Partial<ynab.Category> = {},
11
+ ): ynab.Category => ({
12
+ id: overrides.id ?? "cat-1",
13
+ category_group_id: overrides.category_group_id ?? "group-1",
14
+ category_group_name: overrides.category_group_name,
15
+ name: overrides.name ?? "Category 1",
16
+ hidden: overrides.hidden ?? false,
17
+ original_category_group_id: overrides.original_category_group_id ?? null,
18
+ note: overrides.note ?? null,
19
+ budgeted: overrides.budgeted ?? 0,
20
+ activity: overrides.activity ?? 0,
21
+ balance: overrides.balance ?? 0,
22
+ goal_type: overrides.goal_type ?? null,
23
+ goal_needs_whole_amount: overrides.goal_needs_whole_amount ?? null,
24
+ goal_day: overrides.goal_day ?? null,
25
+ goal_cadence: overrides.goal_cadence ?? null,
26
+ goal_cadence_frequency: overrides.goal_cadence_frequency ?? null,
27
+ goal_creation_month: overrides.goal_creation_month ?? null,
28
+ goal_target: overrides.goal_target ?? null,
29
+ goal_target_month: overrides.goal_target_month ?? null,
30
+ goal_percentage_complete: overrides.goal_percentage_complete ?? null,
31
+ goal_months_to_budget: overrides.goal_months_to_budget ?? null,
32
+ goal_under_funded: overrides.goal_under_funded ?? null,
33
+ goal_overall_funded: overrides.goal_overall_funded ?? null,
34
+ goal_overall_left: overrides.goal_overall_left ?? null,
35
+ goal_snoozed_at: overrides.goal_snoozed_at ?? null,
36
+ deleted: overrides.deleted ?? false,
31
37
  });
32
38
 
33
39
  const buildCategoryGroup = (
34
- overrides: Partial<ynab.CategoryGroupWithCategories> = {},
40
+ overrides: Partial<ynab.CategoryGroupWithCategories> = {},
35
41
  ): ynab.CategoryGroupWithCategories => ({
36
- id: overrides.id ?? 'group-1',
37
- name: overrides.name ?? 'Group 1',
38
- hidden: overrides.hidden ?? false,
39
- deleted: overrides.deleted ?? false,
40
- categories: overrides.categories
41
- ? overrides.categories.map((category) => ({ ...category }))
42
- : [buildCategory()],
42
+ id: overrides.id ?? "group-1",
43
+ name: overrides.name ?? "Group 1",
44
+ hidden: overrides.hidden ?? false,
45
+ deleted: overrides.deleted ?? false,
46
+ categories: overrides.categories
47
+ ? overrides.categories.map((category) => ({ ...category }))
48
+ : [buildCategory()],
43
49
  });
44
50
 
45
51
  const buildSubTransaction = (
46
- overrides: Partial<ynab.SubTransaction> = {},
52
+ overrides: Partial<ynab.SubTransaction> = {},
47
53
  ): ynab.SubTransaction => ({
48
- id: overrides.id ?? 'sub-1',
49
- transaction_id: overrides.transaction_id ?? 'txn-1',
50
- amount: overrides.amount ?? 500,
51
- memo: overrides.memo ?? null,
52
- payee_id: overrides.payee_id ?? null,
53
- payee_name: overrides.payee_name ?? null,
54
- category_id: overrides.category_id ?? null,
55
- category_name: overrides.category_name ?? null,
56
- transfer_account_id: overrides.transfer_account_id ?? null,
57
- transfer_transaction_id: overrides.transfer_transaction_id ?? null,
58
- deleted: overrides.deleted ?? false,
54
+ id: overrides.id ?? "sub-1",
55
+ transaction_id: overrides.transaction_id ?? "txn-1",
56
+ amount: overrides.amount ?? 500,
57
+ memo: overrides.memo ?? null,
58
+ payee_id: overrides.payee_id ?? null,
59
+ payee_name: overrides.payee_name ?? null,
60
+ category_id: overrides.category_id ?? null,
61
+ category_name: overrides.category_name ?? null,
62
+ transfer_account_id: overrides.transfer_account_id ?? null,
63
+ transfer_transaction_id: overrides.transfer_transaction_id ?? null,
64
+ deleted: overrides.deleted ?? false,
59
65
  });
60
66
 
61
67
  const buildTransaction = (
62
- overrides: Partial<ynab.TransactionDetail> = {},
68
+ overrides: Partial<ynab.TransactionDetail> = {},
63
69
  ): ynab.TransactionDetail => ({
64
- id: overrides.id ?? 'txn-1',
65
- date: overrides.date ?? '2024-01-01',
66
- amount: overrides.amount ?? 1000,
67
- memo: overrides.memo ?? null,
68
- cleared: overrides.cleared ?? ynab.TransactionClearedStatus.Cleared,
69
- approved: overrides.approved ?? true,
70
- flag_color: overrides.flag_color ?? null,
71
- flag_name: overrides.flag_name ?? null,
72
- account_id: overrides.account_id ?? 'account-1',
73
- payee_id: overrides.payee_id ?? null,
74
- category_id: overrides.category_id ?? null,
75
- transfer_account_id: overrides.transfer_account_id ?? null,
76
- transfer_transaction_id: overrides.transfer_transaction_id ?? null,
77
- matched_transaction_id: overrides.matched_transaction_id ?? null,
78
- import_id: overrides.import_id ?? null,
79
- import_payee_name: overrides.import_payee_name ?? null,
80
- import_payee_name_original: overrides.import_payee_name_original ?? null,
81
- debt_transaction_type: overrides.debt_transaction_type ?? null,
82
- deleted: overrides.deleted ?? false,
83
- account_name: overrides.account_name ?? 'Checking',
84
- payee_name: overrides.payee_name ?? null,
85
- category_name: overrides.category_name ?? null,
86
- subtransactions: overrides.subtransactions
87
- ? overrides.subtransactions.map((sub) => ({ ...sub }))
88
- : [],
70
+ id: overrides.id ?? "txn-1",
71
+ date: overrides.date ?? "2024-01-01",
72
+ amount: overrides.amount ?? 1000,
73
+ memo: overrides.memo ?? null,
74
+ cleared: overrides.cleared ?? ynab.TransactionClearedStatus.Cleared,
75
+ approved: overrides.approved ?? true,
76
+ flag_color: overrides.flag_color ?? null,
77
+ flag_name: overrides.flag_name ?? null,
78
+ account_id: overrides.account_id ?? "account-1",
79
+ payee_id: overrides.payee_id ?? null,
80
+ category_id: overrides.category_id ?? null,
81
+ transfer_account_id: overrides.transfer_account_id ?? null,
82
+ transfer_transaction_id: overrides.transfer_transaction_id ?? null,
83
+ matched_transaction_id: overrides.matched_transaction_id ?? null,
84
+ import_id: overrides.import_id ?? null,
85
+ import_payee_name: overrides.import_payee_name ?? null,
86
+ import_payee_name_original: overrides.import_payee_name_original ?? null,
87
+ debt_transaction_type: overrides.debt_transaction_type ?? null,
88
+ deleted: overrides.deleted ?? false,
89
+ account_name: overrides.account_name ?? "Checking",
90
+ payee_name: overrides.payee_name ?? null,
91
+ category_name: overrides.category_name ?? null,
92
+ subtransactions: overrides.subtransactions
93
+ ? overrides.subtransactions.map((sub) => ({ ...sub }))
94
+ : [],
89
95
  });
90
96
 
91
- describe('mergeFlatEntities', () => {
92
- it('should merge new entities into snapshot', () => {
93
- const snapshot = [{ id: '1' }];
94
- const delta = [{ id: '2' }];
95
-
96
- const result = mergeFlatEntities(snapshot, delta);
97
- expect(result).toEqual([{ id: '1' }, { id: '2' }]);
98
- });
99
-
100
- it('should update existing entities with latest data', () => {
101
- const snapshot = [{ id: '1', name: 'old' }];
102
- const delta = [{ id: '1', name: 'new' }];
103
-
104
- const result = mergeFlatEntities(snapshot, delta);
105
- expect(result).toEqual([{ id: '1', name: 'new' }]);
106
- });
107
-
108
- it('should delete entities when delta marks them deleted', () => {
109
- const snapshot = [{ id: '1' }, { id: '2' }];
110
- const delta = [{ id: '1', deleted: true }];
111
-
112
- const result = mergeFlatEntities(snapshot, delta);
113
- expect(result).toEqual([{ id: '2' }]);
114
- });
115
-
116
- it('should preserve deleted entities when preserveDeleted enabled', () => {
117
- const snapshot = [{ id: '1' }];
118
- const delta = [{ id: '1', deleted: true, name: 'archived' }];
119
-
120
- const result = mergeFlatEntities(snapshot, delta, { preserveDeleted: true });
121
- expect(result).toEqual([{ id: '1', deleted: true, name: 'archived' }]);
122
- });
123
-
124
- it('should handle empty snapshot gracefully', () => {
125
- const result = mergeFlatEntities([], [{ id: '1' }]);
126
- expect(result).toEqual([{ id: '1' }]);
127
- });
128
-
129
- it('should handle empty delta by returning snapshot', () => {
130
- const snapshot = [{ id: '1' }];
131
- expect(mergeFlatEntities(snapshot, [])).toEqual(snapshot);
132
- });
133
-
134
- it('should handle both arrays empty', () => {
135
- expect(mergeFlatEntities([], [])).toEqual([]);
136
- });
137
-
138
- it('should process multiple operations in single delta batch', () => {
139
- const snapshot = [
140
- { id: '1', status: 'keep' },
141
- { id: '2', status: 'update-me' },
142
- { id: '3', status: 'delete-me' },
143
- ];
144
- const delta = [
145
- { id: '2', status: 'updated' },
146
- { id: '3', deleted: true },
147
- { id: '4', status: 'new' },
148
- ];
149
-
150
- const result = mergeFlatEntities(snapshot, delta);
151
- expect(result).toEqual([
152
- { id: '1', status: 'keep' },
153
- { id: '2', status: 'updated' },
154
- { id: '4', status: 'new' },
155
- ]);
156
- });
157
-
158
- it('should maintain insertion order for unchanged entities', () => {
159
- const snapshot = [{ id: '1' }, { id: '2' }];
160
- const delta = [{ id: '2', name: 'updated' }];
161
-
162
- const result = mergeFlatEntities(snapshot, delta);
163
- expect(result).toEqual([{ id: '1' }, { id: '2', name: 'updated' }]);
164
- });
165
-
166
- it('should keep additional fields intact', () => {
167
- const snapshot = [{ id: '1', extra: { nested: true } }];
168
- const delta = [{ id: '1', extra: { nested: false }, label: 'v2' }];
169
-
170
- const result = mergeFlatEntities(snapshot, delta);
171
- expect(result).toEqual([{ id: '1', extra: { nested: false }, label: 'v2' }]);
172
- });
97
+ describe("mergeFlatEntities", () => {
98
+ it("should merge new entities into snapshot", () => {
99
+ const snapshot = [{ id: "1" }];
100
+ const delta = [{ id: "2" }];
101
+
102
+ const result = mergeFlatEntities(snapshot, delta);
103
+ expect(result).toEqual([{ id: "1" }, { id: "2" }]);
104
+ });
105
+
106
+ it("should update existing entities with latest data", () => {
107
+ const snapshot = [{ id: "1", name: "old" }];
108
+ const delta = [{ id: "1", name: "new" }];
109
+
110
+ const result = mergeFlatEntities(snapshot, delta);
111
+ expect(result).toEqual([{ id: "1", name: "new" }]);
112
+ });
113
+
114
+ it("should delete entities when delta marks them deleted", () => {
115
+ const snapshot = [{ id: "1" }, { id: "2" }];
116
+ const delta = [{ id: "1", deleted: true }];
117
+
118
+ const result = mergeFlatEntities(snapshot, delta);
119
+ expect(result).toEqual([{ id: "2" }]);
120
+ });
121
+
122
+ it("should preserve deleted entities when preserveDeleted enabled", () => {
123
+ const snapshot = [{ id: "1" }];
124
+ const delta = [{ id: "1", deleted: true, name: "archived" }];
125
+
126
+ const result = mergeFlatEntities(snapshot, delta, {
127
+ preserveDeleted: true,
128
+ });
129
+ expect(result).toEqual([{ id: "1", deleted: true, name: "archived" }]);
130
+ });
131
+
132
+ it("should handle empty snapshot gracefully", () => {
133
+ const result = mergeFlatEntities([], [{ id: "1" }]);
134
+ expect(result).toEqual([{ id: "1" }]);
135
+ });
136
+
137
+ it("should handle empty delta by returning snapshot", () => {
138
+ const snapshot = [{ id: "1" }];
139
+ expect(mergeFlatEntities(snapshot, [])).toEqual(snapshot);
140
+ });
141
+
142
+ it("should handle both arrays empty", () => {
143
+ expect(mergeFlatEntities([], [])).toEqual([]);
144
+ });
145
+
146
+ it("should process multiple operations in single delta batch", () => {
147
+ const snapshot = [
148
+ { id: "1", status: "keep" },
149
+ { id: "2", status: "update-me" },
150
+ { id: "3", status: "delete-me" },
151
+ ];
152
+ const delta = [
153
+ { id: "2", status: "updated" },
154
+ { id: "3", deleted: true },
155
+ { id: "4", status: "new" },
156
+ ];
157
+
158
+ const result = mergeFlatEntities(snapshot, delta);
159
+ expect(result).toEqual([
160
+ { id: "1", status: "keep" },
161
+ { id: "2", status: "updated" },
162
+ { id: "4", status: "new" },
163
+ ]);
164
+ });
165
+
166
+ it("should maintain insertion order for unchanged entities", () => {
167
+ const snapshot = [{ id: "1" }, { id: "2" }];
168
+ const delta = [{ id: "2", name: "updated" }];
169
+
170
+ const result = mergeFlatEntities(snapshot, delta);
171
+ expect(result).toEqual([{ id: "1" }, { id: "2", name: "updated" }]);
172
+ });
173
+
174
+ it("should keep additional fields intact", () => {
175
+ const snapshot = [{ id: "1", extra: { nested: true } }];
176
+ const delta = [{ id: "1", extra: { nested: false }, label: "v2" }];
177
+
178
+ const result = mergeFlatEntities(snapshot, delta);
179
+ expect(result).toEqual([
180
+ { id: "1", extra: { nested: false }, label: "v2" },
181
+ ]);
182
+ });
173
183
  });
174
184
 
175
- describe('mergeCategories', () => {
176
- it('should merge new category groups into snapshot', () => {
177
- const snapshot = [buildCategoryGroup({ id: 'group-1' })];
178
- const delta = [buildCategoryGroup({ id: 'group-2', name: 'Group 2' })];
179
-
180
- const result = mergeCategories(snapshot, delta);
181
- expect(result.map((group) => group.id)).toEqual(['group-1', 'group-2']);
182
- });
183
-
184
- it('should update existing group metadata', () => {
185
- const snapshot = [buildCategoryGroup({ id: 'group-1', name: 'Original' })];
186
- const delta = [buildCategoryGroup({ id: 'group-1', name: 'Renamed' })];
187
-
188
- const result = mergeCategories(snapshot, delta);
189
- expect(result[0].name).toBe('Renamed');
190
- });
191
-
192
- it('should delete groups flagged as deleted', () => {
193
- const snapshot = [buildCategoryGroup({ id: 'group-1' }), buildCategoryGroup({ id: 'group-2' })];
194
- const delta = [buildCategoryGroup({ id: 'group-2', deleted: true })];
195
-
196
- const result = mergeCategories(snapshot, delta);
197
- expect(result.map((group) => group.id)).toEqual(['group-1']);
198
- });
199
-
200
- it('should preserve deleted groups when preserveDeleted is true', () => {
201
- const snapshot = [buildCategoryGroup({ id: 'group-1' })];
202
- const delta = [buildCategoryGroup({ id: 'group-1', deleted: true })];
203
-
204
- const result = mergeCategories(snapshot, delta, { preserveDeleted: true });
205
- expect(result[0].deleted).toBe(true);
206
- });
207
-
208
- it('should merge new categories within existing group', () => {
209
- const snapshot = [
210
- buildCategoryGroup({
211
- id: 'group-1',
212
- categories: [buildCategory({ id: 'cat-1', name: 'Existing' })],
213
- }),
214
- ];
215
- const delta = [
216
- buildCategoryGroup({
217
- id: 'group-1',
218
- categories: [buildCategory({ id: 'cat-2', name: 'New' })],
219
- }),
220
- ];
221
-
222
- const result = mergeCategories(snapshot, delta);
223
- expect(result[0].categories.map((cat) => cat.id)).toEqual(['cat-1', 'cat-2']);
224
- });
225
-
226
- it('should update existing categories during merge', () => {
227
- const snapshot = [
228
- buildCategoryGroup({
229
- id: 'group-1',
230
- categories: [buildCategory({ id: 'cat-1', name: 'Old' })],
231
- }),
232
- ];
233
- const delta = [
234
- buildCategoryGroup({
235
- id: 'group-1',
236
- categories: [buildCategory({ id: 'cat-1', name: 'New Name' })],
237
- }),
238
- ];
239
-
240
- const result = mergeCategories(snapshot, delta);
241
- expect(result[0].categories[0].name).toBe('New Name');
242
- });
243
-
244
- it('should delete categories marked as deleted', () => {
245
- const snapshot = [
246
- buildCategoryGroup({
247
- id: 'group-1',
248
- categories: [buildCategory({ id: 'cat-1' }), buildCategory({ id: 'cat-2' })],
249
- }),
250
- ];
251
- const delta = [
252
- buildCategoryGroup({
253
- id: 'group-1',
254
- categories: [buildCategory({ id: 'cat-2', deleted: true })],
255
- }),
256
- ];
257
-
258
- const result = mergeCategories(snapshot, delta);
259
- expect(result[0].categories.map((cat) => cat.id)).toEqual(['cat-1']);
260
- });
261
-
262
- it('should preserve deleted categories when preserveDeleted is true', () => {
263
- const snapshot = [
264
- buildCategoryGroup({
265
- id: 'group-1',
266
- categories: [buildCategory({ id: 'cat-1' })],
267
- }),
268
- ];
269
- const delta = [
270
- buildCategoryGroup({
271
- id: 'group-1',
272
- categories: [buildCategory({ id: 'cat-1', deleted: true })],
273
- }),
274
- ];
275
-
276
- const result = mergeCategories(snapshot, delta, { preserveDeleted: true });
277
- expect(result[0].categories[0].deleted).toBe(true);
278
- });
279
-
280
- it('should handle groups with empty category lists', () => {
281
- const snapshot = [
282
- buildCategoryGroup({
283
- id: 'group-1',
284
- categories: [],
285
- }),
286
- ];
287
- const delta = [buildCategoryGroup({ id: 'group-1', categories: [] })];
288
-
289
- const result = mergeCategories(snapshot, delta);
290
- expect(result[0].categories).toEqual([]);
291
- });
292
-
293
- it('should handle metadata-only updates (no categories provided)', () => {
294
- const snapshot = [
295
- buildCategoryGroup({
296
- id: 'group-1',
297
- name: 'Original',
298
- categories: [buildCategory({ id: 'cat-1' })],
299
- }),
300
- ];
301
- const delta = [
302
- {
303
- id: 'group-1',
304
- name: 'Updated',
305
- hidden: true,
306
- deleted: false,
307
- categories: [],
308
- },
309
- ];
310
-
311
- const result = mergeCategories(snapshot, delta);
312
- expect(result[0].name).toBe('Updated');
313
- expect(result[0].categories).toEqual([buildCategory({ id: 'cat-1' })]);
314
- });
315
-
316
- it('should apply nested updates to metadata and categories simultaneously', () => {
317
- const snapshot = [
318
- buildCategoryGroup({
319
- id: 'group-1',
320
- name: 'Old',
321
- categories: [
322
- buildCategory({ id: 'cat-1', name: 'Old Cat' }),
323
- buildCategory({ id: 'cat-2', name: 'Keep' }),
324
- ],
325
- }),
326
- ];
327
- const delta = [
328
- buildCategoryGroup({
329
- id: 'group-1',
330
- name: 'New',
331
- categories: [
332
- buildCategory({ id: 'cat-1', name: 'New Cat' }),
333
- buildCategory({ id: 'cat-3', name: 'Added' }),
334
- ],
335
- }),
336
- ];
337
-
338
- const result = mergeCategories(snapshot, delta);
339
- expect(result[0].name).toBe('New');
340
- expect(result[0].categories.map((cat) => cat.id)).toEqual(['cat-1', 'cat-2', 'cat-3']);
341
- });
342
-
343
- it('should maintain category order after merges', () => {
344
- const snapshot = [
345
- buildCategoryGroup({
346
- id: 'group-1',
347
- categories: [
348
- buildCategory({ id: 'cat-1', name: 'First' }),
349
- buildCategory({ id: 'cat-2', name: 'Second' }),
350
- ],
351
- }),
352
- ];
353
- const delta = [
354
- buildCategoryGroup({
355
- id: 'group-1',
356
- categories: [buildCategory({ id: 'cat-3', name: 'Third' })],
357
- }),
358
- ];
359
-
360
- const result = mergeCategories(snapshot, delta);
361
- expect(result[0].categories.map((cat) => cat.name)).toEqual(['First', 'Second', 'Third']);
362
- });
363
-
364
- it('should handle multiple groups with multiple category updates', () => {
365
- const snapshot = [
366
- buildCategoryGroup({
367
- id: 'group-1',
368
- categories: [buildCategory({ id: 'cat-1' })],
369
- }),
370
- buildCategoryGroup({
371
- id: 'group-2',
372
- categories: [buildCategory({ id: 'cat-2', category_group_id: 'group-2' })],
373
- }),
374
- ];
375
- const delta = [
376
- buildCategoryGroup({
377
- id: 'group-1',
378
- categories: [buildCategory({ id: 'cat-3' })],
379
- }),
380
- buildCategoryGroup({
381
- id: 'group-2',
382
- categories: [buildCategory({ id: 'cat-2', deleted: true })],
383
- }),
384
- ];
385
-
386
- const result = mergeCategories(snapshot, delta);
387
- expect(result.find((group) => group.id === 'group-1')?.categories.map((cat) => cat.id)).toEqual(
388
- ['cat-1', 'cat-3'],
389
- );
390
- expect(result.find((group) => group.id === 'group-2')?.categories).toEqual([]);
391
- });
392
-
393
- it('should keep nested structures immutable', () => {
394
- const snapshot = [
395
- buildCategoryGroup({
396
- id: 'group-1',
397
- categories: [buildCategory({ id: 'cat-1', name: 'Original' })],
398
- }),
399
- ];
400
- const delta = [
401
- buildCategoryGroup({
402
- id: 'group-1',
403
- categories: [buildCategory({ id: 'cat-1', name: 'Updated' })],
404
- }),
405
- ];
406
-
407
- const result = mergeCategories(snapshot, delta);
408
- expect(snapshot[0].categories[0].name).toBe('Original');
409
- expect(result[0].categories[0].name).toBe('Updated');
410
- });
185
+ describe("mergeCategories", () => {
186
+ it("should merge new category groups into snapshot", () => {
187
+ const snapshot = [buildCategoryGroup({ id: "group-1" })];
188
+ const delta = [buildCategoryGroup({ id: "group-2", name: "Group 2" })];
189
+
190
+ const result = mergeCategories(snapshot, delta);
191
+ expect(result.map((group) => group.id)).toEqual(["group-1", "group-2"]);
192
+ });
193
+
194
+ it("should update existing group metadata", () => {
195
+ const snapshot = [buildCategoryGroup({ id: "group-1", name: "Original" })];
196
+ const delta = [buildCategoryGroup({ id: "group-1", name: "Renamed" })];
197
+
198
+ const result = mergeCategories(snapshot, delta);
199
+ expect(result[0].name).toBe("Renamed");
200
+ });
201
+
202
+ it("should delete groups flagged as deleted", () => {
203
+ const snapshot = [
204
+ buildCategoryGroup({ id: "group-1" }),
205
+ buildCategoryGroup({ id: "group-2" }),
206
+ ];
207
+ const delta = [buildCategoryGroup({ id: "group-2", deleted: true })];
208
+
209
+ const result = mergeCategories(snapshot, delta);
210
+ expect(result.map((group) => group.id)).toEqual(["group-1"]);
211
+ });
212
+
213
+ it("should preserve deleted groups when preserveDeleted is true", () => {
214
+ const snapshot = [buildCategoryGroup({ id: "group-1" })];
215
+ const delta = [buildCategoryGroup({ id: "group-1", deleted: true })];
216
+
217
+ const result = mergeCategories(snapshot, delta, { preserveDeleted: true });
218
+ expect(result[0].deleted).toBe(true);
219
+ });
220
+
221
+ it("should merge new categories within existing group", () => {
222
+ const snapshot = [
223
+ buildCategoryGroup({
224
+ id: "group-1",
225
+ categories: [buildCategory({ id: "cat-1", name: "Existing" })],
226
+ }),
227
+ ];
228
+ const delta = [
229
+ buildCategoryGroup({
230
+ id: "group-1",
231
+ categories: [buildCategory({ id: "cat-2", name: "New" })],
232
+ }),
233
+ ];
234
+
235
+ const result = mergeCategories(snapshot, delta);
236
+ expect(result[0].categories.map((cat) => cat.id)).toEqual([
237
+ "cat-1",
238
+ "cat-2",
239
+ ]);
240
+ });
241
+
242
+ it("should update existing categories during merge", () => {
243
+ const snapshot = [
244
+ buildCategoryGroup({
245
+ id: "group-1",
246
+ categories: [buildCategory({ id: "cat-1", name: "Old" })],
247
+ }),
248
+ ];
249
+ const delta = [
250
+ buildCategoryGroup({
251
+ id: "group-1",
252
+ categories: [buildCategory({ id: "cat-1", name: "New Name" })],
253
+ }),
254
+ ];
255
+
256
+ const result = mergeCategories(snapshot, delta);
257
+ expect(result[0].categories[0].name).toBe("New Name");
258
+ });
259
+
260
+ it("should delete categories marked as deleted", () => {
261
+ const snapshot = [
262
+ buildCategoryGroup({
263
+ id: "group-1",
264
+ categories: [
265
+ buildCategory({ id: "cat-1" }),
266
+ buildCategory({ id: "cat-2" }),
267
+ ],
268
+ }),
269
+ ];
270
+ const delta = [
271
+ buildCategoryGroup({
272
+ id: "group-1",
273
+ categories: [buildCategory({ id: "cat-2", deleted: true })],
274
+ }),
275
+ ];
276
+
277
+ const result = mergeCategories(snapshot, delta);
278
+ expect(result[0].categories.map((cat) => cat.id)).toEqual(["cat-1"]);
279
+ });
280
+
281
+ it("should preserve deleted categories when preserveDeleted is true", () => {
282
+ const snapshot = [
283
+ buildCategoryGroup({
284
+ id: "group-1",
285
+ categories: [buildCategory({ id: "cat-1" })],
286
+ }),
287
+ ];
288
+ const delta = [
289
+ buildCategoryGroup({
290
+ id: "group-1",
291
+ categories: [buildCategory({ id: "cat-1", deleted: true })],
292
+ }),
293
+ ];
294
+
295
+ const result = mergeCategories(snapshot, delta, { preserveDeleted: true });
296
+ expect(result[0].categories[0].deleted).toBe(true);
297
+ });
298
+
299
+ it("should handle groups with empty category lists", () => {
300
+ const snapshot = [
301
+ buildCategoryGroup({
302
+ id: "group-1",
303
+ categories: [],
304
+ }),
305
+ ];
306
+ const delta = [buildCategoryGroup({ id: "group-1", categories: [] })];
307
+
308
+ const result = mergeCategories(snapshot, delta);
309
+ expect(result[0].categories).toEqual([]);
310
+ });
311
+
312
+ it("should handle metadata-only updates (no categories provided)", () => {
313
+ const snapshot = [
314
+ buildCategoryGroup({
315
+ id: "group-1",
316
+ name: "Original",
317
+ categories: [buildCategory({ id: "cat-1" })],
318
+ }),
319
+ ];
320
+ const delta = [
321
+ {
322
+ id: "group-1",
323
+ name: "Updated",
324
+ hidden: true,
325
+ deleted: false,
326
+ categories: [],
327
+ },
328
+ ];
329
+
330
+ const result = mergeCategories(snapshot, delta);
331
+ expect(result[0].name).toBe("Updated");
332
+ expect(result[0].categories).toEqual([buildCategory({ id: "cat-1" })]);
333
+ });
334
+
335
+ it("should apply nested updates to metadata and categories simultaneously", () => {
336
+ const snapshot = [
337
+ buildCategoryGroup({
338
+ id: "group-1",
339
+ name: "Old",
340
+ categories: [
341
+ buildCategory({ id: "cat-1", name: "Old Cat" }),
342
+ buildCategory({ id: "cat-2", name: "Keep" }),
343
+ ],
344
+ }),
345
+ ];
346
+ const delta = [
347
+ buildCategoryGroup({
348
+ id: "group-1",
349
+ name: "New",
350
+ categories: [
351
+ buildCategory({ id: "cat-1", name: "New Cat" }),
352
+ buildCategory({ id: "cat-3", name: "Added" }),
353
+ ],
354
+ }),
355
+ ];
356
+
357
+ const result = mergeCategories(snapshot, delta);
358
+ expect(result[0].name).toBe("New");
359
+ expect(result[0].categories.map((cat) => cat.id)).toEqual([
360
+ "cat-1",
361
+ "cat-2",
362
+ "cat-3",
363
+ ]);
364
+ });
365
+
366
+ it("should maintain category order after merges", () => {
367
+ const snapshot = [
368
+ buildCategoryGroup({
369
+ id: "group-1",
370
+ categories: [
371
+ buildCategory({ id: "cat-1", name: "First" }),
372
+ buildCategory({ id: "cat-2", name: "Second" }),
373
+ ],
374
+ }),
375
+ ];
376
+ const delta = [
377
+ buildCategoryGroup({
378
+ id: "group-1",
379
+ categories: [buildCategory({ id: "cat-3", name: "Third" })],
380
+ }),
381
+ ];
382
+
383
+ const result = mergeCategories(snapshot, delta);
384
+ expect(result[0].categories.map((cat) => cat.name)).toEqual([
385
+ "First",
386
+ "Second",
387
+ "Third",
388
+ ]);
389
+ });
390
+
391
+ it("should handle multiple groups with multiple category updates", () => {
392
+ const snapshot = [
393
+ buildCategoryGroup({
394
+ id: "group-1",
395
+ categories: [buildCategory({ id: "cat-1" })],
396
+ }),
397
+ buildCategoryGroup({
398
+ id: "group-2",
399
+ categories: [
400
+ buildCategory({ id: "cat-2", category_group_id: "group-2" }),
401
+ ],
402
+ }),
403
+ ];
404
+ const delta = [
405
+ buildCategoryGroup({
406
+ id: "group-1",
407
+ categories: [buildCategory({ id: "cat-3" })],
408
+ }),
409
+ buildCategoryGroup({
410
+ id: "group-2",
411
+ categories: [buildCategory({ id: "cat-2", deleted: true })],
412
+ }),
413
+ ];
414
+
415
+ const result = mergeCategories(snapshot, delta);
416
+ expect(
417
+ result
418
+ .find((group) => group.id === "group-1")
419
+ ?.categories.map((cat) => cat.id),
420
+ ).toEqual(["cat-1", "cat-3"]);
421
+ expect(result.find((group) => group.id === "group-2")?.categories).toEqual(
422
+ [],
423
+ );
424
+ });
425
+
426
+ it("should keep nested structures immutable", () => {
427
+ const snapshot = [
428
+ buildCategoryGroup({
429
+ id: "group-1",
430
+ categories: [buildCategory({ id: "cat-1", name: "Original" })],
431
+ }),
432
+ ];
433
+ const delta = [
434
+ buildCategoryGroup({
435
+ id: "group-1",
436
+ categories: [buildCategory({ id: "cat-1", name: "Updated" })],
437
+ }),
438
+ ];
439
+
440
+ const result = mergeCategories(snapshot, delta);
441
+ expect(snapshot[0].categories[0].name).toBe("Original");
442
+ expect(result[0].categories[0].name).toBe("Updated");
443
+ });
411
444
  });
412
445
 
413
- describe('mergeTransactions', () => {
414
- it('should merge new transactions into snapshot', () => {
415
- const snapshot = [buildTransaction({ id: 'txn-1' })];
416
- const delta = [buildTransaction({ id: 'txn-2' })];
417
-
418
- const result = mergeTransactions(snapshot, delta);
419
- expect(result.map((txn) => txn.id)).toEqual(['txn-1', 'txn-2']);
420
- });
421
-
422
- it('should update existing transactions', () => {
423
- const snapshot = [buildTransaction({ id: 'txn-1', memo: 'old' })];
424
- const delta = [buildTransaction({ id: 'txn-1', memo: 'new' })];
425
-
426
- const result = mergeTransactions(snapshot, delta);
427
- expect(result[0].memo).toBe('new');
428
- });
429
-
430
- it('should delete transactions marked as deleted', () => {
431
- const snapshot = [buildTransaction({ id: 'txn-1' }), buildTransaction({ id: 'txn-2' })];
432
- const delta = [buildTransaction({ id: 'txn-2', deleted: true })];
433
-
434
- const result = mergeTransactions(snapshot, delta);
435
- expect(result.map((txn) => txn.id)).toEqual(['txn-1']);
436
- });
437
-
438
- it('should preserve deleted transactions when preserveDeleted is true', () => {
439
- const snapshot = [buildTransaction({ id: 'txn-1' })];
440
- const delta = [buildTransaction({ id: 'txn-1', deleted: true })];
441
-
442
- const result = mergeTransactions(snapshot, delta, { preserveDeleted: true });
443
- expect(result[0].deleted).toBe(true);
444
- });
445
-
446
- it('should merge new subtransactions into existing transaction', () => {
447
- const snapshot = [
448
- buildTransaction({
449
- id: 'txn-1',
450
- subtransactions: [buildSubTransaction({ id: 'sub-1', transaction_id: 'txn-1' })],
451
- }),
452
- ];
453
- const delta = [
454
- buildTransaction({
455
- id: 'txn-1',
456
- subtransactions: [buildSubTransaction({ id: 'sub-2', transaction_id: 'txn-1' })],
457
- }),
458
- ];
459
-
460
- const result = mergeTransactions(snapshot, delta);
461
- expect(result[0].subtransactions.map((sub) => sub.id)).toEqual(['sub-1', 'sub-2']);
462
- });
463
-
464
- it('should update existing subtransactions', () => {
465
- const snapshot = [
466
- buildTransaction({
467
- id: 'txn-1',
468
- subtransactions: [buildSubTransaction({ id: 'sub-1', amount: 100 })],
469
- }),
470
- ];
471
- const delta = [
472
- buildTransaction({
473
- id: 'txn-1',
474
- subtransactions: [buildSubTransaction({ id: 'sub-1', amount: 200 })],
475
- }),
476
- ];
477
-
478
- const result = mergeTransactions(snapshot, delta);
479
- expect(result[0].subtransactions[0].amount).toBe(200);
480
- });
481
-
482
- it('should delete subtransactions when flagged deleted', () => {
483
- const snapshot = [
484
- buildTransaction({
485
- id: 'txn-1',
486
- subtransactions: [
487
- buildSubTransaction({ id: 'sub-1' }),
488
- buildSubTransaction({ id: 'sub-2' }),
489
- ],
490
- }),
491
- ];
492
- const delta = [
493
- buildTransaction({
494
- id: 'txn-1',
495
- subtransactions: [buildSubTransaction({ id: 'sub-2', deleted: true })],
496
- }),
497
- ];
498
-
499
- const result = mergeTransactions(snapshot, delta);
500
- expect(result[0].subtransactions.map((sub) => sub.id)).toEqual(['sub-1']);
501
- });
502
-
503
- it('should preserve deleted subtransactions when preserveDeleted is true', () => {
504
- const snapshot = [
505
- buildTransaction({
506
- id: 'txn-1',
507
- subtransactions: [buildSubTransaction({ id: 'sub-1' })],
508
- }),
509
- ];
510
- const delta = [
511
- buildTransaction({
512
- id: 'txn-1',
513
- subtransactions: [buildSubTransaction({ id: 'sub-1', deleted: true })],
514
- }),
515
- ];
516
-
517
- const result = mergeTransactions(snapshot, delta, { preserveDeleted: true });
518
- expect(result[0].subtransactions[0].deleted).toBe(true);
519
- });
520
-
521
- it('should handle transactions without subtransactions arrays', () => {
522
- const snapshot = [buildTransaction({ id: 'txn-1', subtransactions: [] })];
523
- const delta = [buildTransaction({ id: 'txn-1', memo: 'updated', subtransactions: [] })];
524
-
525
- const result = mergeTransactions(snapshot, delta);
526
- expect(result[0].memo).toBe('updated');
527
- });
528
-
529
- it('should handle delta updates without subtransactions list', () => {
530
- const snapshot = [buildTransaction({ id: 'txn-1', subtransactions: [buildSubTransaction()] })];
531
- const delta = [
532
- {
533
- id: 'txn-1',
534
- date: '2024-02-01',
535
- amount: 2000,
536
- cleared: ynab.TransactionClearedStatus.Cleared,
537
- approved: true,
538
- account_id: 'account-1',
539
- deleted: false,
540
- account_name: 'Checking',
541
- subtransactions: [],
542
- },
543
- ];
544
-
545
- const result = mergeTransactions(snapshot, delta);
546
- expect(result[0].date).toBe('2024-02-01');
547
- expect(result[0].subtransactions.length).toBe(1);
548
- });
549
-
550
- it('should apply nested operations to transaction and subtransactions', () => {
551
- const snapshot = [
552
- buildTransaction({
553
- id: 'txn-1',
554
- memo: 'old',
555
- subtransactions: [buildSubTransaction({ id: 'sub-1', amount: 50 })],
556
- }),
557
- ];
558
- const delta = [
559
- buildTransaction({
560
- id: 'txn-1',
561
- memo: 'new',
562
- subtransactions: [
563
- buildSubTransaction({ id: 'sub-1', amount: 75 }),
564
- buildSubTransaction({ id: 'sub-2', amount: 100 }),
565
- ],
566
- }),
567
- ];
568
-
569
- const result = mergeTransactions(snapshot, delta);
570
- expect(result[0].memo).toBe('new');
571
- expect(result[0].subtransactions.map((sub) => sub.id)).toEqual(['sub-1', 'sub-2']);
572
- });
573
-
574
- it('should maintain subtransaction order', () => {
575
- const snapshot = [
576
- buildTransaction({
577
- id: 'txn-1',
578
- subtransactions: [
579
- buildSubTransaction({ id: 'sub-1' }),
580
- buildSubTransaction({ id: 'sub-2' }),
581
- ],
582
- }),
583
- ];
584
- const delta = [
585
- buildTransaction({
586
- id: 'txn-1',
587
- subtransactions: [buildSubTransaction({ id: 'sub-3' })],
588
- }),
589
- ];
590
-
591
- const result = mergeTransactions(snapshot, delta);
592
- expect(result[0].subtransactions.map((sub) => sub.id)).toEqual(['sub-1', 'sub-2', 'sub-3']);
593
- });
594
-
595
- it('should handle multiple transactions with distinct updates', () => {
596
- const snapshot = [
597
- buildTransaction({ id: 'txn-1', memo: 'keep' }),
598
- buildTransaction({ id: 'txn-2', memo: 'replace' }),
599
- ];
600
- const delta = [
601
- buildTransaction({ id: 'txn-2', memo: 'updated' }),
602
- buildTransaction({ id: 'txn-3', memo: 'new' }),
603
- ];
604
-
605
- const result = mergeTransactions(snapshot, delta);
606
- expect(result.map((txn) => txn.id)).toEqual(['txn-1', 'txn-2', 'txn-3']);
607
- expect(result.find((txn) => txn.id === 'txn-2')?.memo).toBe('updated');
608
- });
609
-
610
- it('should avoid mutating input arrays', () => {
611
- const snapshot = [buildTransaction({ id: 'txn-1', memo: 'old' })];
612
- const delta = [buildTransaction({ id: 'txn-1', memo: 'new' })];
613
-
614
- mergeTransactions(snapshot, delta);
615
- expect(snapshot[0].memo).toBe('old');
616
- expect(delta[0].memo).toBe('new');
617
- });
446
+ describe("mergeTransactions", () => {
447
+ it("should merge new transactions into snapshot", () => {
448
+ const snapshot = [buildTransaction({ id: "txn-1" })];
449
+ const delta = [buildTransaction({ id: "txn-2" })];
450
+
451
+ const result = mergeTransactions(snapshot, delta);
452
+ expect(result.map((txn) => txn.id)).toEqual(["txn-1", "txn-2"]);
453
+ });
454
+
455
+ it("should update existing transactions", () => {
456
+ const snapshot = [buildTransaction({ id: "txn-1", memo: "old" })];
457
+ const delta = [buildTransaction({ id: "txn-1", memo: "new" })];
458
+
459
+ const result = mergeTransactions(snapshot, delta);
460
+ expect(result[0].memo).toBe("new");
461
+ });
462
+
463
+ it("should delete transactions marked as deleted", () => {
464
+ const snapshot = [
465
+ buildTransaction({ id: "txn-1" }),
466
+ buildTransaction({ id: "txn-2" }),
467
+ ];
468
+ const delta = [buildTransaction({ id: "txn-2", deleted: true })];
469
+
470
+ const result = mergeTransactions(snapshot, delta);
471
+ expect(result.map((txn) => txn.id)).toEqual(["txn-1"]);
472
+ });
473
+
474
+ it("should preserve deleted transactions when preserveDeleted is true", () => {
475
+ const snapshot = [buildTransaction({ id: "txn-1" })];
476
+ const delta = [buildTransaction({ id: "txn-1", deleted: true })];
477
+
478
+ const result = mergeTransactions(snapshot, delta, {
479
+ preserveDeleted: true,
480
+ });
481
+ expect(result[0].deleted).toBe(true);
482
+ });
483
+
484
+ it("should merge new subtransactions into existing transaction", () => {
485
+ const snapshot = [
486
+ buildTransaction({
487
+ id: "txn-1",
488
+ subtransactions: [
489
+ buildSubTransaction({ id: "sub-1", transaction_id: "txn-1" }),
490
+ ],
491
+ }),
492
+ ];
493
+ const delta = [
494
+ buildTransaction({
495
+ id: "txn-1",
496
+ subtransactions: [
497
+ buildSubTransaction({ id: "sub-2", transaction_id: "txn-1" }),
498
+ ],
499
+ }),
500
+ ];
501
+
502
+ const result = mergeTransactions(snapshot, delta);
503
+ expect(result[0].subtransactions.map((sub) => sub.id)).toEqual([
504
+ "sub-1",
505
+ "sub-2",
506
+ ]);
507
+ });
508
+
509
+ it("should update existing subtransactions", () => {
510
+ const snapshot = [
511
+ buildTransaction({
512
+ id: "txn-1",
513
+ subtransactions: [buildSubTransaction({ id: "sub-1", amount: 100 })],
514
+ }),
515
+ ];
516
+ const delta = [
517
+ buildTransaction({
518
+ id: "txn-1",
519
+ subtransactions: [buildSubTransaction({ id: "sub-1", amount: 200 })],
520
+ }),
521
+ ];
522
+
523
+ const result = mergeTransactions(snapshot, delta);
524
+ expect(result[0].subtransactions[0].amount).toBe(200);
525
+ });
526
+
527
+ it("should delete subtransactions when flagged deleted", () => {
528
+ const snapshot = [
529
+ buildTransaction({
530
+ id: "txn-1",
531
+ subtransactions: [
532
+ buildSubTransaction({ id: "sub-1" }),
533
+ buildSubTransaction({ id: "sub-2" }),
534
+ ],
535
+ }),
536
+ ];
537
+ const delta = [
538
+ buildTransaction({
539
+ id: "txn-1",
540
+ subtransactions: [buildSubTransaction({ id: "sub-2", deleted: true })],
541
+ }),
542
+ ];
543
+
544
+ const result = mergeTransactions(snapshot, delta);
545
+ expect(result[0].subtransactions.map((sub) => sub.id)).toEqual(["sub-1"]);
546
+ });
547
+
548
+ it("should preserve deleted subtransactions when preserveDeleted is true", () => {
549
+ const snapshot = [
550
+ buildTransaction({
551
+ id: "txn-1",
552
+ subtransactions: [buildSubTransaction({ id: "sub-1" })],
553
+ }),
554
+ ];
555
+ const delta = [
556
+ buildTransaction({
557
+ id: "txn-1",
558
+ subtransactions: [buildSubTransaction({ id: "sub-1", deleted: true })],
559
+ }),
560
+ ];
561
+
562
+ const result = mergeTransactions(snapshot, delta, {
563
+ preserveDeleted: true,
564
+ });
565
+ expect(result[0].subtransactions[0].deleted).toBe(true);
566
+ });
567
+
568
+ it("should handle transactions without subtransactions arrays", () => {
569
+ const snapshot = [buildTransaction({ id: "txn-1", subtransactions: [] })];
570
+ const delta = [
571
+ buildTransaction({ id: "txn-1", memo: "updated", subtransactions: [] }),
572
+ ];
573
+
574
+ const result = mergeTransactions(snapshot, delta);
575
+ expect(result[0].memo).toBe("updated");
576
+ });
577
+
578
+ it("should handle delta updates without subtransactions list", () => {
579
+ const snapshot = [
580
+ buildTransaction({
581
+ id: "txn-1",
582
+ subtransactions: [buildSubTransaction()],
583
+ }),
584
+ ];
585
+ const delta = [
586
+ {
587
+ id: "txn-1",
588
+ date: "2024-02-01",
589
+ amount: 2000,
590
+ cleared: ynab.TransactionClearedStatus.Cleared,
591
+ approved: true,
592
+ account_id: "account-1",
593
+ deleted: false,
594
+ account_name: "Checking",
595
+ subtransactions: [],
596
+ },
597
+ ];
598
+
599
+ const result = mergeTransactions(snapshot, delta);
600
+ expect(result[0].date).toBe("2024-02-01");
601
+ expect(result[0].subtransactions.length).toBe(1);
602
+ });
603
+
604
+ it("should apply nested operations to transaction and subtransactions", () => {
605
+ const snapshot = [
606
+ buildTransaction({
607
+ id: "txn-1",
608
+ memo: "old",
609
+ subtransactions: [buildSubTransaction({ id: "sub-1", amount: 50 })],
610
+ }),
611
+ ];
612
+ const delta = [
613
+ buildTransaction({
614
+ id: "txn-1",
615
+ memo: "new",
616
+ subtransactions: [
617
+ buildSubTransaction({ id: "sub-1", amount: 75 }),
618
+ buildSubTransaction({ id: "sub-2", amount: 100 }),
619
+ ],
620
+ }),
621
+ ];
622
+
623
+ const result = mergeTransactions(snapshot, delta);
624
+ expect(result[0].memo).toBe("new");
625
+ expect(result[0].subtransactions.map((sub) => sub.id)).toEqual([
626
+ "sub-1",
627
+ "sub-2",
628
+ ]);
629
+ });
630
+
631
+ it("should maintain subtransaction order", () => {
632
+ const snapshot = [
633
+ buildTransaction({
634
+ id: "txn-1",
635
+ subtransactions: [
636
+ buildSubTransaction({ id: "sub-1" }),
637
+ buildSubTransaction({ id: "sub-2" }),
638
+ ],
639
+ }),
640
+ ];
641
+ const delta = [
642
+ buildTransaction({
643
+ id: "txn-1",
644
+ subtransactions: [buildSubTransaction({ id: "sub-3" })],
645
+ }),
646
+ ];
647
+
648
+ const result = mergeTransactions(snapshot, delta);
649
+ expect(result[0].subtransactions.map((sub) => sub.id)).toEqual([
650
+ "sub-1",
651
+ "sub-2",
652
+ "sub-3",
653
+ ]);
654
+ });
655
+
656
+ it("should handle multiple transactions with distinct updates", () => {
657
+ const snapshot = [
658
+ buildTransaction({ id: "txn-1", memo: "keep" }),
659
+ buildTransaction({ id: "txn-2", memo: "replace" }),
660
+ ];
661
+ const delta = [
662
+ buildTransaction({ id: "txn-2", memo: "updated" }),
663
+ buildTransaction({ id: "txn-3", memo: "new" }),
664
+ ];
665
+
666
+ const result = mergeTransactions(snapshot, delta);
667
+ expect(result.map((txn) => txn.id)).toEqual(["txn-1", "txn-2", "txn-3"]);
668
+ expect(result.find((txn) => txn.id === "txn-2")?.memo).toBe("updated");
669
+ });
670
+
671
+ it("should avoid mutating input arrays", () => {
672
+ const snapshot = [buildTransaction({ id: "txn-1", memo: "old" })];
673
+ const delta = [buildTransaction({ id: "txn-1", memo: "new" })];
674
+
675
+ mergeTransactions(snapshot, delta);
676
+ expect(snapshot[0].memo).toBe("old");
677
+ expect(delta[0].memo).toBe("new");
678
+ });
618
679
  });
619
680
 
620
- describe('Merge Edge Cases', () => {
621
- it('should handle duplicate IDs in delta with last write winning', () => {
622
- const snapshot = [{ id: '1', name: 'original' }];
623
- const delta = [
624
- { id: '1', name: 'first' },
625
- { id: '1', name: 'second' },
626
- ];
627
-
628
- const result = mergeFlatEntities(snapshot, delta);
629
- expect(result[0].name).toBe('second');
630
- });
631
-
632
- it('should handle null and undefined optional fields', () => {
633
- const snapshot = [buildTransaction({ id: 'txn-1', memo: 'existing' })];
634
- const delta = [
635
- buildTransaction({
636
- id: 'txn-1',
637
- memo: undefined,
638
- payee_name: null,
639
- subtransactions: [],
640
- }),
641
- ];
642
-
643
- const result = mergeTransactions(snapshot, delta);
644
- expect(result[0].memo).toBeNull();
645
- });
646
-
647
- it('should efficiently handle large snapshots', () => {
648
- const largeSnapshot = Array.from({ length: 1200 }, (_, index) => ({ id: `id-${index}` }));
649
- const delta = [{ id: 'new-id' }];
650
- const result = mergeFlatEntities(largeSnapshot, delta);
651
-
652
- expect(result.length).toBe(1201);
653
- expect(result[result.length - 1]).toEqual({ id: 'new-id' });
654
- });
655
-
656
- it('should efficiently handle large delta payloads', () => {
657
- const snapshot = [{ id: 'base' }];
658
- const largeDelta = Array.from({ length: 1000 }, (_, index) => ({ id: `delta-${index}` }));
659
- const result = mergeFlatEntities(snapshot, largeDelta);
660
-
661
- expect(result.length).toBe(1001);
662
- });
663
-
664
- it('should handle deeply nested category structures', () => {
665
- const snapshot = [
666
- buildCategoryGroup({
667
- id: 'group-1',
668
- categories: Array.from({ length: 10 }, (_, index) => buildCategory({ id: `cat-${index}` })),
669
- }),
670
- ];
671
- const delta = [
672
- buildCategoryGroup({
673
- id: 'group-1',
674
- categories: Array.from({ length: 10 }, (_, index) =>
675
- buildCategory({ id: `cat-${index}`, name: `Updated ${index}` }),
676
- ),
677
- }),
678
- ];
679
-
680
- const result = mergeCategories(snapshot, delta);
681
- expect(result[0].categories.every((cat) => cat.name?.startsWith('Updated'))).toBe(true);
682
- });
683
-
684
- it('should handle transactions with many subtransactions', () => {
685
- const snapshot = [
686
- buildTransaction({
687
- id: 'txn-1',
688
- subtransactions: Array.from({ length: 10 }, (_, index) =>
689
- buildSubTransaction({ id: `sub-${index}` }),
690
- ),
691
- }),
692
- ];
693
- const delta = [
694
- buildTransaction({
695
- id: 'txn-1',
696
- subtransactions: [
697
- buildSubTransaction({ id: 'sub-3', amount: 999 }),
698
- buildSubTransaction({ id: 'sub-11', amount: 100 }),
699
- ],
700
- }),
701
- ];
702
-
703
- const result = mergeTransactions(snapshot, delta);
704
- expect(result[0].subtransactions.length).toBe(11);
705
- expect(result[0].subtransactions.find((sub) => sub.id === 'sub-3')?.amount).toBe(999);
706
- });
707
-
708
- it('should not mutate snapshot or delta arrays', () => {
709
- const snapshot = [buildCategoryGroup({ id: 'group-1', name: 'Old' })];
710
- const delta = [buildCategoryGroup({ id: 'group-1', name: 'New' })];
711
-
712
- mergeCategories(snapshot, delta);
713
- expect(snapshot[0].name).toBe('Old');
714
- expect(delta[0].name).toBe('New');
715
- });
716
-
717
- it('should handle special characters in IDs and names', () => {
718
- const snapshot = [{ id: 'payee:ä', name: 'Old' }];
719
- const delta = [{ id: 'payee:ä', name: 'New' }];
720
-
721
- const result = mergeFlatEntities(snapshot, delta);
722
- expect(result[0].name).toBe('New');
723
- });
681
+ describe("Merge Edge Cases", () => {
682
+ it("should handle duplicate IDs in delta with last write winning", () => {
683
+ const snapshot = [{ id: "1", name: "original" }];
684
+ const delta = [
685
+ { id: "1", name: "first" },
686
+ { id: "1", name: "second" },
687
+ ];
688
+
689
+ const result = mergeFlatEntities(snapshot, delta);
690
+ expect(result[0].name).toBe("second");
691
+ });
692
+
693
+ it("should handle null and undefined optional fields", () => {
694
+ const snapshot = [buildTransaction({ id: "txn-1", memo: "existing" })];
695
+ const delta = [
696
+ buildTransaction({
697
+ id: "txn-1",
698
+ memo: undefined,
699
+ payee_name: null,
700
+ subtransactions: [],
701
+ }),
702
+ ];
703
+
704
+ const result = mergeTransactions(snapshot, delta);
705
+ expect(result[0].memo).toBeNull();
706
+ });
707
+
708
+ it("should efficiently handle large snapshots", () => {
709
+ const largeSnapshot = Array.from({ length: 1200 }, (_, index) => ({
710
+ id: `id-${index}`,
711
+ }));
712
+ const delta = [{ id: "new-id" }];
713
+ const result = mergeFlatEntities(largeSnapshot, delta);
714
+
715
+ expect(result.length).toBe(1201);
716
+ expect(result[result.length - 1]).toEqual({ id: "new-id" });
717
+ });
718
+
719
+ it("should efficiently handle large delta payloads", () => {
720
+ const snapshot = [{ id: "base" }];
721
+ const largeDelta = Array.from({ length: 1000 }, (_, index) => ({
722
+ id: `delta-${index}`,
723
+ }));
724
+ const result = mergeFlatEntities(snapshot, largeDelta);
725
+
726
+ expect(result.length).toBe(1001);
727
+ });
728
+
729
+ it("should handle deeply nested category structures", () => {
730
+ const snapshot = [
731
+ buildCategoryGroup({
732
+ id: "group-1",
733
+ categories: Array.from({ length: 10 }, (_, index) =>
734
+ buildCategory({ id: `cat-${index}` }),
735
+ ),
736
+ }),
737
+ ];
738
+ const delta = [
739
+ buildCategoryGroup({
740
+ id: "group-1",
741
+ categories: Array.from({ length: 10 }, (_, index) =>
742
+ buildCategory({ id: `cat-${index}`, name: `Updated ${index}` }),
743
+ ),
744
+ }),
745
+ ];
746
+
747
+ const result = mergeCategories(snapshot, delta);
748
+ expect(
749
+ result[0].categories.every((cat) => cat.name?.startsWith("Updated")),
750
+ ).toBe(true);
751
+ });
752
+
753
+ it("should handle transactions with many subtransactions", () => {
754
+ const snapshot = [
755
+ buildTransaction({
756
+ id: "txn-1",
757
+ subtransactions: Array.from({ length: 10 }, (_, index) =>
758
+ buildSubTransaction({ id: `sub-${index}` }),
759
+ ),
760
+ }),
761
+ ];
762
+ const delta = [
763
+ buildTransaction({
764
+ id: "txn-1",
765
+ subtransactions: [
766
+ buildSubTransaction({ id: "sub-3", amount: 999 }),
767
+ buildSubTransaction({ id: "sub-11", amount: 100 }),
768
+ ],
769
+ }),
770
+ ];
771
+
772
+ const result = mergeTransactions(snapshot, delta);
773
+ expect(result[0].subtransactions.length).toBe(11);
774
+ expect(
775
+ result[0].subtransactions.find((sub) => sub.id === "sub-3")?.amount,
776
+ ).toBe(999);
777
+ });
778
+
779
+ it("should not mutate snapshot or delta arrays", () => {
780
+ const snapshot = [buildCategoryGroup({ id: "group-1", name: "Old" })];
781
+ const delta = [buildCategoryGroup({ id: "group-1", name: "New" })];
782
+
783
+ mergeCategories(snapshot, delta);
784
+ expect(snapshot[0].name).toBe("Old");
785
+ expect(delta[0].name).toBe("New");
786
+ });
787
+
788
+ it("should handle special characters in IDs and names", () => {
789
+ const snapshot = [{ id: "payee:ä", name: "Old" }];
790
+ const delta = [{ id: "payee:ä", name: "New" }];
791
+
792
+ const result = mergeFlatEntities(snapshot, delta);
793
+ expect(result[0].name).toBe("New");
794
+ });
724
795
  });