@dizzlkheinz/ynab-mcpb 0.18.3 → 0.19.0

package/dist/tools/compareTransactions/index.js

@@ -1,15 +1,14 @@
-import { z } from 'zod/v4';
-import { withToolErrorHandling } from '../../types/index.js';
-import { parseBankCSV, readCSVFile, autoDetectCSVFormat } from './parser.js';
-import { findMatches } from './matcher.js';
-import { buildComparisonResult } from './formatter.js';
+import { z } from "zod/v4";
+import { withToolErrorHandling } from "../../types/index.js";
+import { buildComparisonResult } from "./formatter.js";
+import { findMatches } from "./matcher.js";
+import { autoDetectCSVFormat, parseBankCSV, readCSVFile } from "./parser.js";
 export const CompareTransactionsSchema = z
     .object({
-    budget_id: z.string().min(1, 'Budget ID is required'),
-    account_id: z.string().min(1, 'Account ID is required'),
+    budget_id: z.string().min(1, "Budget ID is required"),
+    account_id: z.string().min(1, "Account ID is required"),
     csv_file_path: z.string().optional(),
     csv_data: z.string().optional(),
-    date_range_days: z.number().min(1).max(365).optional().default(30),
     amount_tolerance: z.number().min(0).max(1).optional().default(0.01),
     date_tolerance_days: z.number().min(0).max(7).optional().default(5),
     enable_chronology_bonus: z.boolean().optional().default(false),
@@ -19,31 +18,37 @@ export const CompareTransactionsSchema = z
     debug: z.boolean().optional().default(false),
     csv_format: z
         .object({
-        date_column: z.union([z.string(), z.number()]).optional().default('Date'),
+        date_column: z
+            .union([z.string(), z.number()])
+            .optional()
+            .default("Date"),
         amount_column: z.union([z.string(), z.number()]).optional(),
         debit_column: z.union([z.string(), z.number()]).optional(),
         credit_column: z.union([z.string(), z.number()]).optional(),
-        description_column: z.union([z.string(), z.number()]).optional().default('Description'),
-        date_format: z.string().optional().default('MM/DD/YYYY'),
+        description_column: z
+            .union([z.string(), z.number()])
+            .optional()
+            .default("Description"),
+        date_format: z.string().optional().default("MM/DD/YYYY"),
         has_header: z.boolean().optional().default(true),
-        delimiter: z.string().optional().default(','),
+        delimiter: z.string().optional().default(","),
     })
         .strict()
         .optional()
         .default(() => ({
-        date_column: 'Date',
-        amount_column: 'Amount',
-        description_column: 'Description',
-        date_format: 'MM/DD/YYYY',
+        date_column: "Date",
+        amount_column: "Amount",
+        description_column: "Description",
+        date_format: "MM/DD/YYYY",
         has_header: true,
-        delimiter: ',',
+        delimiter: ",",
     })),
 })
     .strict()
     .refine((data) => data.csv_file_path || data.csv_data, {
-    message: 'Either csv_file_path or csv_data must be provided',
+    message: "Either csv_file_path or csv_data must be provided",
 });
-export async function handleCompareTransactions(ynabAPI, params) {
+export async function handleCompareTransactions(ynabAPI, params, errorHandler) {
     return await withToolErrorHandling(async () => {
         const parsed = CompareTransactionsSchema.parse(params);
         const payeesResponse = await ynabAPI.payees.getPayees(parsed.budget_id);
@@ -52,37 +57,41 @@ export async function handleCompareTransactions(ynabAPI, params) {
         if (parsed.csv_file_path) {
             csvContent = readCSVFile(parsed.csv_file_path);
         }
-        else {
+        else if (parsed.csv_data) {
             csvContent = parsed.csv_data;
         }
+        else {
+            throw new Error("Missing CSV data: csv_data is required");
+        }
         let csvFormat = parsed.csv_format;
         if (parsed.auto_detect_format) {
             try {
                 csvFormat = autoDetectCSVFormat(csvContent);
                 if (parsed.debug) {
-                    console.warn('Auto-detected CSV format:', csvFormat);
+                    console.warn("Auto-detected CSV format:", csvFormat);
                 }
             }
             catch (error) {
                 if (parsed.debug) {
-                    console.warn('Auto-detection failed, using provided format:', error);
+                    console.warn("Auto-detection failed, using provided format:", error);
                 }
             }
         }
-        const bankTransactions = parseBankCSV(csvContent, csvFormat, { debug: parsed.debug });
+        const bankTransactions = parseBankCSV(csvContent, csvFormat, {
+            debug: parsed.debug,
+        });
         if (bankTransactions.length === 0) {
-            throw new Error('No valid transactions found in CSV data. ' +
-                'Check your csv_format parameters or try auto_detect_format: true. ' +
-                `CSV has ${csvContent.split('\n').length} lines.`);
+            throw new Error(`No valid transactions found in CSV data. Check your csv_format parameters or try auto_detect_format: true. CSV has ${csvContent.split("\n").length} lines.`);
         }
         const bankDates = bankTransactions.map((t) => t.date);
         const minDate = new Date(Math.min(...bankDates.map((d) => d.getTime())));
         const maxDate = new Date(Math.max(...bankDates.map((d) => d.getTime())));
+        const dateToleranceDays = parsed.date_tolerance_days ?? 0;
         const startDate = new Date(minDate);
-        startDate.setDate(startDate.getDate() - parsed.date_tolerance_days);
+        startDate.setDate(startDate.getDate() - dateToleranceDays);
         const endDate = new Date(maxDate);
-        endDate.setDate(endDate.getDate() + parsed.date_tolerance_days);
-        const sinceDate = startDate.toISOString().split('T')[0];
+        endDate.setDate(endDate.getDate() + dateToleranceDays);
+        const sinceDate = startDate.toISOString().split("T")[0];
         const response = await ynabAPI.transactions.getTransactionsByAccount(parsed.budget_id, parsed.account_id, sinceDate);
         const ynabTransactions = response.data.transactions
             .filter((txn) => {
@@ -102,8 +111,9 @@ export async function handleCompareTransactions(ynabAPI, params) {
         let filteredYnabTransactions = ynabTransactions;
         if (parsed.statement_start_date || parsed.statement_date) {
             filteredBankTransactions = bankTransactions.filter((t) => {
-                const dateStr = t.date.toISOString().split('T')[0];
-                if (parsed.statement_start_date && dateStr < parsed.statement_start_date) {
+                const dateStr = t.date.toISOString().split("T")[0] ?? "";
+                if (parsed.statement_start_date &&
+                    dateStr < parsed.statement_start_date) {
                     return false;
                 }
                 if (parsed.statement_date && dateStr > parsed.statement_date) {
@@ -112,8 +122,9 @@ export async function handleCompareTransactions(ynabAPI, params) {
                 return true;
             });
             filteredYnabTransactions = ynabTransactions.filter((t) => {
-                const dateStr = t.date.toISOString().split('T')[0];
-                if (parsed.statement_start_date && dateStr < parsed.statement_start_date) {
+                const dateStr = t.date.toISOString().split("T")[0] ?? "";
+                if (parsed.statement_start_date &&
+                    dateStr < parsed.statement_start_date) {
                     return false;
                 }
                 if (parsed.statement_date && dateStr > parsed.statement_date) {
@@ -122,7 +133,9 @@ export async function handleCompareTransactions(ynabAPI, params) {
                 return true;
             });
         }
-        const matchResults = findMatches(filteredBankTransactions, filteredYnabTransactions, parsed.amount_tolerance, parsed.date_tolerance_days, parsed.enable_chronology_bonus);
+        const amountTolerance = parsed.amount_tolerance ?? 0.01;
+        const chronologyBonus = parsed.enable_chronology_bonus ?? false;
+        const matchResults = findMatches(filteredBankTransactions, filteredYnabTransactions, amountTolerance, dateToleranceDays, chronologyBonus);
         let dateRange;
         if (parsed.statement_start_date || parsed.statement_date) {
             const filteredBankDates = filteredBankTransactions.map((t) => t.date);
@@ -130,25 +143,27 @@ export async function handleCompareTransactions(ynabAPI, params) {
                 const filteredMinDate = new Date(Math.min(...filteredBankDates.map((d) => d.getTime())));
                 const filteredMaxDate = new Date(Math.max(...filteredBankDates.map((d) => d.getTime())));
                 dateRange = {
-                    start: filteredMinDate.toISOString().split('T')[0],
-                    end: filteredMaxDate.toISOString().split('T')[0],
+                    start: filteredMinDate.toISOString().split("T")[0] ?? "",
+                    end: filteredMaxDate.toISOString().split("T")[0] ?? "",
                 };
             }
             else {
                 dateRange = {
-                    start: (parsed.statement_start_date ||
+                    start: parsed.statement_start_date ||
                         parsed.statement_date ||
-                        minDate.toISOString().split('T')[0]),
-                    end: (parsed.statement_date ||
+                        minDate.toISOString().split("T")[0] ||
+                        "",
+                    end: parsed.statement_date ||
                         parsed.statement_start_date ||
-                        maxDate.toISOString().split('T')[0]),
+                        maxDate.toISOString().split("T")[0] ||
+                        "",
                 };
             }
         }
         else {
             dateRange = {
-                start: minDate.toISOString().split('T')[0],
-                end: maxDate.toISOString().split('T')[0],
+                start: minDate.toISOString().split("T")[0] ?? "",
+                end: maxDate.toISOString().split("T")[0] ?? "",
             };
         }
         const parameters = {
@@ -156,5 +171,5 @@ export async function handleCompareTransactions(ynabAPI, params) {
             date_tolerance_days: parsed.date_tolerance_days,
         };
         return buildComparisonResult(matchResults, filteredBankTransactions, filteredYnabTransactions, payees, parameters, dateRange);
-    }, 'ynab:compare_transactions', 'comparing bank and YNAB transactions');
+    }, "ynab:compare_transactions", "comparing bank and YNAB transactions", errorHandler);
 }

package/dist/tools/compareTransactions/matcher.d.ts

@@ -1,4 +1,4 @@
-import { BankTransaction, YNABTransaction, TransactionMatch } from './types.js';
+import type { BankTransaction, TransactionMatch, YNABTransaction } from "./types.js";
 export declare function calculateMatchScore(bankTxn: BankTransaction, ynabTxn: YNABTransaction, amountTolerance: number, dateTolerance: number): {
     score: number;
     reasons: string[];

package/dist/tools/compareTransactions/matcher.js

@@ -5,7 +5,7 @@ export function calculateMatchScore(bankTxn, ynabTxn, amountTolerance, dateToler
     const daysDiff = dateDiff / (1000 * 60 * 60 * 24);
     if (daysDiff === 0) {
         score += 40;
-        reasons.push('Exact date match');
+        reasons.push("Exact date match");
     }
     else if (daysDiff <= dateTolerance) {
         score += Math.max(20, 40 - daysDiff * 10);
@@ -15,22 +15,26 @@ export function calculateMatchScore(bankTxn, ynabTxn, amountTolerance, dateToler
     const amountDiffPercent = amountDiff / Math.abs(bankTxn.amount);
     if (amountDiff === 0) {
         score += 50;
-        reasons.push('Exact amount match');
+        reasons.push("Exact amount match");
     }
     else if (amountDiffPercent <= amountTolerance) {
         score += Math.max(25, 50 - amountDiffPercent * 1000);
         reasons.push(`Amount within ${(amountDiffPercent * 100).toFixed(2)}% tolerance`);
     }
     const bankDesc = bankTxn.description.toLowerCase();
-    const ynabPayee = (ynabTxn.payee_name || '').toLowerCase();
-    const ynabMemo = (ynabTxn.memo || '').toLowerCase();
-    if (bankDesc && ynabPayee && (ynabPayee.includes(bankDesc) || bankDesc.includes(ynabPayee))) {
+    const ynabPayee = (ynabTxn.payee_name || "").toLowerCase();
+    const ynabMemo = (ynabTxn.memo || "").toLowerCase();
+    if (bankDesc &&
+        ynabPayee &&
+        (ynabPayee.includes(bankDesc) || bankDesc.includes(ynabPayee))) {
         score += 10;
-        reasons.push('Payee name similarity');
+        reasons.push("Payee name similarity");
     }
-    else if (bankDesc && ynabMemo && (ynabMemo.includes(bankDesc) || bankDesc.includes(ynabMemo))) {
+    else if (bankDesc &&
+        ynabMemo &&
+        (ynabMemo.includes(bankDesc) || bankDesc.includes(ynabMemo))) {
         score += 5;
-        reasons.push('Memo similarity');
+        reasons.push("Memo similarity");
     }
     return { score, reasons };
 }
@@ -41,7 +45,7 @@ export function groupTransactionsByAmount(transactions) {
         if (!groups.has(amount)) {
             groups.set(amount, []);
         }
-        groups.get(amount).push(txn);
+        groups.get(amount)?.push(txn);
     }
     return groups;
 }
@@ -58,16 +62,22 @@ export function matchDuplicateAmounts(bankTxns, ynabTxns, _amount, amountToleran
             const { score, reasons } = calculateMatchScore(bankTxn, ynabTxn, amountTolerance, dateTolerance);
             let chronologyBonus = 0;
             if (enableChronologyBonus) {
-                const daysDiff = Math.abs(bankTxn.date.getTime() - ynabTxn.date.getTime()) / (1000 * 60 * 60 * 24);
+                const daysDiff = Math.abs(bankTxn.date.getTime() - ynabTxn.date.getTime()) /
+                    (1000 * 60 * 60 * 24);
                 chronologyBonus = daysDiff <= 1 ? 15 : daysDiff <= 3 ? 10 : 0;
             }
             const adjustedScore = score + chronologyBonus;
-            if (adjustedScore >= 30 && (!bestMatch || adjustedScore > bestMatch.score)) {
+            if (adjustedScore >= 30 &&
+                (!bestMatch || adjustedScore > bestMatch.score)) {
                 const enhancedReasons = [...reasons];
                 if (chronologyBonus > 0) {
                     enhancedReasons.push(`Chronological order bonus (+${chronologyBonus})`);
                 }
-                bestMatch = { ynab: ynabTxn, score: adjustedScore, reasons: enhancedReasons };
+                bestMatch = {
+                    ynab: ynabTxn,
+                    score: adjustedScore,
+                    reasons: enhancedReasons,
+                };
             }
         }
         if (bestMatch) {
@@ -97,10 +107,11 @@ export function findMatches(bankTransactions, ynabTransactions, amountTolerance,
     for (const amount of duplicateAmounts) {
         const bankDuplicates = bankByAmount
             .get(amount)
-            ?.filter((txn) => 'raw_amount' in txn && !usedBankIndices.has(bankTransactions.indexOf(txn))) || [];
+            ?.filter((txn) => "raw_amount" in txn &&
+            !usedBankIndices.has(bankTransactions.indexOf(txn))) || [];
         const ynabDuplicates = ynabByAmount
             .get(amount)
-            ?.filter((txn) => 'id' in txn && !usedYnabIds.has(txn.id)) || [];
+            ?.filter((txn) => "id" in txn && !usedYnabIds.has(txn.id)) || [];
         if (bankDuplicates.length > 0 && ynabDuplicates.length > 0) {
             const duplicateMatches = matchDuplicateAmounts(bankDuplicates, ynabDuplicates, amount, amountTolerance, dateTolerance, enableChronologyBonus);
             for (const match of duplicateMatches) {
@@ -112,7 +123,9 @@ export function findMatches(bankTransactions, ynabTransactions, amountTolerance,
     }
     for (let i = 0; i < bankTransactions.length; i++) {
         const bankTxn = bankTransactions[i];
-        if (!bankTxn || usedBankIndices.has(i) || duplicateAmounts.has(bankTxn.amount))
+        if (!bankTxn ||
+            usedBankIndices.has(i) ||
+            duplicateAmounts.has(bankTxn.amount))
             continue;
         let bestMatch = null;
         for (const ynabTxn of ynabTransactions) {

package/dist/tools/compareTransactions/parser.d.ts

@@ -1,5 +1,5 @@
-import type { Milli } from '../../utils/money.js';
-import { BankTransaction, CSVFormat } from './types.js';
+import type { Milli } from "../../utils/money.js";
+import type { BankTransaction, CSVFormat } from "./types.js";
 export declare function parseDate(dateStr: string, format: string): Date;
 export declare function amountToMilliunits(amountStr: string): Milli;
 export declare function detectDateFormat(dateStr: string | undefined): string;