@dizzlkheinz/ynab-mcpb 0.18.3 → 0.19.0

package/src/tools/__tests__/payeeTools.delta.integration.test.ts

@@ -1,80 +1,80 @@
-import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
-import * as ynab from 'ynab';
-import type { CallToolResult } from '@modelcontextprotocol/sdk/types.js';
-import { handleListPayees } from '../payeeTools.js';
-import { CacheManager } from '../../server/cacheManager.js';
-import { ServerKnowledgeStore } from '../../server/serverKnowledgeStore.js';
-import { DeltaCache } from '../../server/deltaCache.js';
-import { DeltaFetcher } from '../deltaFetcher.js';
+import type { CallToolResult } from "@modelcontextprotocol/sdk/types.js";
+import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
+import * as ynab from "ynab";
+import { CacheManager } from "../../server/cacheManager.js";
+import { DeltaCache } from "../../server/deltaCache.js";
+import { ServerKnowledgeStore } from "../../server/serverKnowledgeStore.js";
+import { DeltaFetcher } from "../deltaFetcher.js";
+import { handleListPayees } from "../payeeTools.js";
 
-const shouldSkip = ['true', '1', 'yes', 'y', 'on'].includes(
-  (process.env['SKIP_E2E_TESTS'] || '').toLowerCase().trim(),
+const shouldSkip = ["true", "1", "yes", "y", "on"].includes(
+	(process.env.SKIP_E2E_TESTS || "").toLowerCase().trim(),
 );
-const hasToken = !!process.env['YNAB_ACCESS_TOKEN'];
+const hasToken = !!process.env.YNAB_ACCESS_TOKEN;
 const skipTests = shouldSkip || !hasToken;
 const describeIntegration = skipTests ? describe.skip : describe;
 
-describeIntegration('Delta-backed payee tool handler', () => {
-  let ynabAPI: ynab.API;
-  let testBudgetId: string;
-  let deltaFetcher: DeltaFetcher;
-  let previousNodeEnv: string | undefined;
+describeIntegration("Delta-backed payee tool handler", () => {
+	let ynabAPI: ynab.API;
+	let testBudgetId: string;
+	let deltaFetcher: DeltaFetcher;
+	let previousNodeEnv: string | undefined;
 
-  beforeAll(async () => {
-    const accessToken = process.env['YNAB_ACCESS_TOKEN']!;
-    ynabAPI = new ynab.API(accessToken);
-    const budgetsResponse = await ynabAPI.budgets.getBudgets();
-    const budget = budgetsResponse.data.budgets[0];
-    if (!budget) {
-      throw new Error('No budgets available for delta integration tests.');
-    }
-    testBudgetId = budget.id;
-  });
+	beforeAll(async () => {
+		const accessToken = process.env.YNAB_ACCESS_TOKEN!;
+		ynabAPI = new ynab.API(accessToken);
+		const budgetsResponse = await ynabAPI.budgets.getBudgets();
+		const budget = budgetsResponse.data.budgets[0];
+		if (!budget) {
+			throw new Error("No budgets available for delta integration tests.");
+		}
+		testBudgetId = budget.id;
+	});
 
-  beforeEach(() => {
-    previousNodeEnv = process.env['NODE_ENV'];
-    process.env['NODE_ENV'] = 'integration';
-    const cacheManager = new CacheManager();
-    const knowledgeStore = new ServerKnowledgeStore();
-    const deltaCache = new DeltaCache(cacheManager, knowledgeStore);
-    deltaFetcher = new DeltaFetcher(ynabAPI, deltaCache);
-    process.env['YNAB_MCP_ENABLE_DELTA'] = 'true';
-  });
+	beforeEach(() => {
+		previousNodeEnv = process.env.NODE_ENV;
+		process.env.NODE_ENV = "integration";
+		const cacheManager = new CacheManager();
+		const knowledgeStore = new ServerKnowledgeStore();
+		const deltaCache = new DeltaCache(cacheManager, knowledgeStore);
+		deltaFetcher = new DeltaFetcher(ynabAPI, deltaCache);
+		process.env.YNAB_MCP_ENABLE_DELTA = "true";
+	});
 
-  afterEach(() => {
-    delete process.env['YNAB_MCP_ENABLE_DELTA'];
-    if (previousNodeEnv === undefined) {
-      delete process.env['NODE_ENV'];
-    } else {
-      process.env['NODE_ENV'] = previousNodeEnv;
-    }
-    previousNodeEnv = undefined;
-  });
+	afterEach(() => {
+		process.env.YNAB_MCP_ENABLE_DELTA = undefined;
+		if (previousNodeEnv === undefined) {
+			process.env.NODE_ENV = undefined;
+		} else {
+			process.env.NODE_ENV = previousNodeEnv;
+		}
+		previousNodeEnv = undefined;
+	});
 
-  const parseResponse = (result: CallToolResult) => {
-    const content = result.content?.[0];
-    if (!content || content.type !== 'text') {
-      throw new Error('Unexpected tool response format');
-    }
-    return JSON.parse(content.text);
-  };
-  const expectCacheHit = (payload: { cached: boolean; cache_info: string }) => {
-    expect(payload.cached).toBe(true);
-    expect(payload.cache_info).toMatch(/cache/i);
-  };
+	const parseResponse = (result: CallToolResult) => {
+		const content = result.content?.[0];
+		if (!content || content.type !== "text") {
+			throw new Error("Unexpected tool response format");
+		}
+		return JSON.parse(content.text);
+	};
+	const expectCacheHit = (payload: { cached: boolean; cache_info: string }) => {
+		expect(payload.cached).toBe(true);
+		expect(payload.cache_info).toMatch(/cache/i);
+	};
 
-  it(
-    'serves cached payee results on the second invocation',
-    { meta: { tier: 'domain', domain: 'delta' } },
-    async () => {
-      const params = { budget_id: testBudgetId };
-      const firstCall = await handleListPayees(ynabAPI, deltaFetcher, params);
-      const firstPayload = parseResponse(firstCall);
-      expect(firstPayload.cached).toBe(false);
+	it(
+		"serves cached payee results on the second invocation",
+		{ meta: { tier: "domain", domain: "delta" } },
+		async () => {
+			const params = { budget_id: testBudgetId };
+			const firstCall = await handleListPayees(ynabAPI, deltaFetcher, params);
+			const firstPayload = parseResponse(firstCall);
+			expect(firstPayload.cached).toBe(false);
 
-      const secondCall = await handleListPayees(ynabAPI, deltaFetcher, params);
-      const secondPayload = parseResponse(secondCall);
-      expectCacheHit(secondPayload);
-    },
-  );
+			const secondCall = await handleListPayees(ynabAPI, deltaFetcher, params);
+			const secondPayload = parseResponse(secondCall);
+			expectCacheHit(secondPayload);
+		},
+	);
 });

package/src/tools/__tests__/payeeTools.integration.test.ts

@@ -1,150 +1,166 @@
-import { describe, it, expect, beforeAll } from 'vitest';
-import * as ynab from 'ynab';
-import { handleListPayees, handleGetPayee } from '../payeeTools.js';
+import { beforeAll, describe, expect, it } from "vitest";
+import * as ynab from "ynab";
+import { handleGetPayee, handleListPayees } from "../payeeTools.js";
 
 /**
  * Integration tests for payee tools using real YNAB API
  * Skips if YNAB_ACCESS_TOKEN is not set or if SKIP_E2E_TESTS is true
  */
-const hasToken = !!process.env['YNAB_ACCESS_TOKEN'];
-const shouldSkip = process.env['SKIP_E2E_TESTS'] === 'true' || !hasToken;
+const hasToken = !!process.env.YNAB_ACCESS_TOKEN;
+const shouldSkip = process.env.SKIP_E2E_TESTS === "true" || !hasToken;
 const describeIntegration = shouldSkip ? describe.skip : describe;
 
-describeIntegration('Payee Tools Integration', () => {
-  let ynabAPI: ynab.API;
-  let testBudgetId: string;
-  let testPayeeId: string;
-
-  beforeAll(async () => {
-    const accessToken = process.env['YNAB_ACCESS_TOKEN']!;
-    ynabAPI = new ynab.API(accessToken);
-    const budgetsResponse = await ynabAPI.budgets.getBudgets();
-    testBudgetId = budgetsResponse.data.budgets[0].id;
-  });
-
-  describe('handleListPayees', () => {
-    it(
-      'should successfully list payees from real API',
-      { meta: { tier: 'domain', domain: 'payees' } },
-      async () => {
-        const result = await handleListPayees(ynabAPI, { budget_id: testBudgetId });
-
-        expect(result.content).toHaveLength(1);
-        expect(result.content[0].type).toBe('text');
-
-        const parsedContent = JSON.parse(result.content[0].text);
-        expect(parsedContent.payees).toBeDefined();
-        expect(Array.isArray(parsedContent.payees)).toBe(true);
-        expect(parsedContent.payees.length).toBeGreaterThan(0);
-
-        // Store first payee ID for next test
-        testPayeeId = parsedContent.payees[0].id;
-
-        // Verify payee structure
-        const firstPayee = parsedContent.payees[0];
-        expect(firstPayee.id).toBeDefined();
-        expect(firstPayee.name).toBeDefined();
-        expect(firstPayee.deleted).toBeDefined();
-        expect(typeof firstPayee.deleted).toBe('boolean');
-
-        // Check for transfer payees
-        const transferPayees = parsedContent.payees.filter(
-          (p: any) => p.transfer_account_id !== null,
-        );
-        console.warn(`✅ Successfully listed ${parsedContent.payees.length} payees`);
-        console.warn(`   - ${transferPayees.length} transfer payees`);
-        console.warn(`   - ${parsedContent.payees.length - transferPayees.length} regular payees`);
-      },
-    );
-
-    it(
-      'should handle invalid budget ID gracefully',
-      { meta: { tier: 'domain', domain: 'payees' } },
-      async () => {
-        const result = await handleListPayees(ynabAPI, { budget_id: 'invalid-budget-id' });
-
-        expect(result.content).toHaveLength(1);
-        expect(result.content[0].type).toBe('text');
-
-        const parsedContent = JSON.parse(result.content[0].text);
-        expect(parsedContent.error).toBeDefined();
-        expect(parsedContent.error.message).toBeDefined();
-
-        console.warn(`✅ Correctly handled invalid budget ID: ${parsedContent.error.message}`);
-      },
-    );
-  });
-
-  describe('handleGetPayee', () => {
-    it(
-      'should successfully get payee details from real API',
-      { meta: { tier: 'domain', domain: 'payees' } },
-      async () => {
-        // Use the payee ID from the previous test
-        const result = await handleGetPayee(ynabAPI, {
-          budget_id: testBudgetId,
-          payee_id: testPayeeId,
-        });
-
-        expect(result.content).toHaveLength(1);
-        expect(result.content[0].type).toBe('text');
-
-        const parsedContent = JSON.parse(result.content[0].text);
-        expect(parsedContent.payee).toBeDefined();
-
-        const payee = parsedContent.payee;
-        expect(payee.id).toBe(testPayeeId);
-        expect(payee.name).toBeDefined();
-        expect(payee.deleted).toBeDefined();
-        expect(typeof payee.deleted).toBe('boolean');
-
-        console.warn(`✅ Successfully retrieved payee: ${payee.name}`);
-        if (payee.transfer_account_id) {
-          console.warn(`   - Transfer payee for account: ${payee.transfer_account_id}`);
-        } else {
-          console.warn(`   - Regular payee`);
-        }
-      },
-    );
-
-    it(
-      'should handle invalid payee ID gracefully',
-      { meta: { tier: 'domain', domain: 'payees' } },
-      async () => {
-        const result = await handleGetPayee(ynabAPI, {
-          budget_id: testBudgetId,
-          payee_id: 'invalid-payee-id',
-        });
-
-        expect(result.content).toHaveLength(1);
-        expect(result.content[0].type).toBe('text');
-
-        const parsedContent = JSON.parse(result.content[0].text);
-        expect(parsedContent.error).toBeDefined();
-        expect(parsedContent.error.message).toBeDefined();
-
-        console.warn(`✅ Correctly handled invalid payee ID: ${parsedContent.error.message}`);
-      },
-    );
-
-    it(
-      'should handle invalid budget ID gracefully',
-      { meta: { tier: 'domain', domain: 'payees' } },
-      async () => {
-        const result = await handleGetPayee(ynabAPI, {
-          budget_id: 'invalid-budget-id',
-          payee_id: testPayeeId,
-        });
-
-        expect(result.content).toHaveLength(1);
-        expect(result.content[0].type).toBe('text');
-
-        const parsedContent = JSON.parse(result.content[0].text);
-        expect(parsedContent.error).toBeDefined();
-        expect(parsedContent.error.message).toBeDefined();
-
-        console.warn(`✅ Correctly handled invalid budget ID: ${parsedContent.error.message}`);
-      },
-    );
-  });
+describeIntegration("Payee Tools Integration", () => {
+	let ynabAPI: ynab.API;
+	let testBudgetId: string;
+	let testPayeeId: string;
+
+	beforeAll(async () => {
+		const accessToken = process.env.YNAB_ACCESS_TOKEN!;
+		ynabAPI = new ynab.API(accessToken);
+		const budgetsResponse = await ynabAPI.budgets.getBudgets();
+		testBudgetId = budgetsResponse.data.budgets[0].id;
+	});
+
+	describe("handleListPayees", () => {
+		it(
+			"should successfully list payees from real API",
+			{ meta: { tier: "domain", domain: "payees" } },
+			async () => {
+				const result = await handleListPayees(ynabAPI, {
+					budget_id: testBudgetId,
+				});
+
+				expect(result.content).toHaveLength(1);
+				expect(result.content[0].type).toBe("text");
+
+				const parsedContent = JSON.parse(result.content[0].text);
+				expect(parsedContent.payees).toBeDefined();
+				expect(Array.isArray(parsedContent.payees)).toBe(true);
+				expect(parsedContent.payees.length).toBeGreaterThan(0);
+
+				// Store first payee ID for next test
+				testPayeeId = parsedContent.payees[0].id;
+
+				// Verify payee structure
+				const firstPayee = parsedContent.payees[0];
+				expect(firstPayee.id).toBeDefined();
+				expect(firstPayee.name).toBeDefined();
+				expect(firstPayee.deleted).toBeDefined();
+				expect(typeof firstPayee.deleted).toBe("boolean");
+
+				// Check for transfer payees
+				const transferPayees = parsedContent.payees.filter(
+					(p: any) => p.transfer_account_id !== null,
+				);
+				console.warn(
+					`✅ Successfully listed ${parsedContent.payees.length} payees`,
+				);
+				console.warn(`   - ${transferPayees.length} transfer payees`);
+				console.warn(
+					`   - ${parsedContent.payees.length - transferPayees.length} regular payees`,
+				);
+			},
+		);
+
+		it(
+			"should handle invalid budget ID gracefully",
+			{ meta: { tier: "domain", domain: "payees" } },
+			async () => {
+				const result = await handleListPayees(ynabAPI, {
+					budget_id: "invalid-budget-id",
+				});
+
+				expect(result.content).toHaveLength(1);
+				expect(result.content[0].type).toBe("text");
+
+				const parsedContent = JSON.parse(result.content[0].text);
+				expect(parsedContent.error).toBeDefined();
+				expect(parsedContent.error.message).toBeDefined();
+
+				console.warn(
+					`✅ Correctly handled invalid budget ID: ${parsedContent.error.message}`,
+				);
+			},
+		);
+	});
+
+	describe("handleGetPayee", () => {
+		it(
+			"should successfully get payee details from real API",
+			{ meta: { tier: "domain", domain: "payees" } },
+			async () => {
+				// Use the payee ID from the previous test
+				const result = await handleGetPayee(ynabAPI, {
+					budget_id: testBudgetId,
+					payee_id: testPayeeId,
+				});
+
+				expect(result.content).toHaveLength(1);
+				expect(result.content[0].type).toBe("text");
+
+				const parsedContent = JSON.parse(result.content[0].text);
+				expect(parsedContent.payee).toBeDefined();
+
+				const payee = parsedContent.payee;
+				expect(payee.id).toBe(testPayeeId);
+				expect(payee.name).toBeDefined();
+				expect(payee.deleted).toBeDefined();
+				expect(typeof payee.deleted).toBe("boolean");
+
+				console.warn(`✅ Successfully retrieved payee: ${payee.name}`);
+				if (payee.transfer_account_id) {
+					console.warn(
+						`   - Transfer payee for account: ${payee.transfer_account_id}`,
+					);
+				} else {
+					console.warn("   - Regular payee");
+				}
+			},
+		);
+
+		it(
+			"should handle invalid payee ID gracefully",
+			{ meta: { tier: "domain", domain: "payees" } },
+			async () => {
+				const result = await handleGetPayee(ynabAPI, {
+					budget_id: testBudgetId,
+					payee_id: "invalid-payee-id",
+				});
+
+				expect(result.content).toHaveLength(1);
+				expect(result.content[0].type).toBe("text");
+
+				const parsedContent = JSON.parse(result.content[0].text);
+				expect(parsedContent.error).toBeDefined();
+				expect(parsedContent.error.message).toBeDefined();
+
+				console.warn(
+					`✅ Correctly handled invalid payee ID: ${parsedContent.error.message}`,
+				);
+			},
+		);
+
+		it(
+			"should handle invalid budget ID gracefully",
+			{ meta: { tier: "domain", domain: "payees" } },
+			async () => {
+				const result = await handleGetPayee(ynabAPI, {
+					budget_id: "invalid-budget-id",
+					payee_id: testPayeeId,
+				});
+
+				expect(result.content).toHaveLength(1);
+				expect(result.content[0].type).toBe("text");
+
+				const parsedContent = JSON.parse(result.content[0].text);
+				expect(parsedContent.error).toBeDefined();
+				expect(parsedContent.error.message).toBeDefined();
+
+				console.warn(
+					`✅ Correctly handled invalid budget ID: ${parsedContent.error.message}`,
+				);
+			},
+		);
+	});
 });