@bevel-software/platform-core-frontend 0.15.1 → 0.20.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/THIRD-PARTY-NOTICES.md +2 -2
- package/package.json +3 -3
- package/src/core/CoreAppShell.tsx +20 -9
- package/src/core/__tests__/AppChrome.test.tsx +0 -3
- package/src/core/__tests__/events.test.ts +43 -0
- package/src/core/bootstrap.ts +11 -3
- package/src/core/events.ts +85 -3
- package/src/core/registry.ts +1 -1
- package/src/lib/__tests__/email.test.ts +44 -0
- package/src/lib/email.ts +37 -1
- package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
- package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
- package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
- package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
- package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
- package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
- package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
- package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
- package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
- package/src/modules/access/api.ts +140 -6
- package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
- package/src/modules/access/manage-access-affordance.ts +17 -0
- package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
- package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
- package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
- package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
- package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
- package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
- package/src/modules/admin/components/AddMemberInput.tsx +268 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
- package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
- package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
- package/src/modules/admin/components/group-members-path.ts +32 -0
- package/src/modules/admin/services/roles.api.ts +12 -1
- package/src/modules/audit/__tests__/AuditLogPage.test.tsx +312 -0
- package/src/modules/audit/components/AuditEventsPanel.tsx +319 -0
- package/src/modules/audit/components/AuditLogPage.tsx +373 -0
- package/src/modules/audit/components/principal-grouping.ts +49 -0
- package/src/modules/audit/services/audit.api.ts +98 -0
- package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
- package/src/modules/auth/components/AccountPage.tsx +73 -54
- package/src/modules/auth/components/LoginScreen.tsx +1 -0
- package/src/modules/auth/services/account.api.ts +78 -4
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
- package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
- package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
- package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
- package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
- package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
- package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
- package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
- package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
- package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
- package/src/modules/change-requests/services/change-requests.api.ts +57 -1
- package/src/modules/change-requests/services/denied-file.api.ts +53 -0
- package/src/modules/change-requests/services/propose.api.ts +97 -8
- package/src/modules/change-requests/utils/approval.ts +15 -0
- package/src/modules/change-requests/utils/author.ts +32 -0
- package/src/modules/change-requests/utils/readFailure.ts +110 -0
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
- package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
- package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
- package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
- package/src/modules/git/services/error-messages.ts +12 -0
- package/src/modules/git/services/pr-prompts.ts +5 -5
- package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
- package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
- package/src/modules/layout/components/AppLayout.tsx +2 -0
- package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
- package/src/modules/layout/components/SidebarFrame.tsx +108 -3
- package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
- package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
- package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
- package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
- package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
- package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
- package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
- package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
- package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
- package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
- package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
- package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
- package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
- package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
- package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
- package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
- package/src/modules/library/__tests__/auth-harness.tsx +9 -9
- package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
- package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
- package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
- package/src/modules/library/__tests__/library-data.test.ts +7 -0
- package/src/modules/library/__tests__/library-paths.test.ts +47 -4
- package/src/modules/library/__tests__/link-membership.test.ts +13 -4
- package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
- package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
- package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
- package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
- package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
- package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
- package/src/modules/library/__tests__/status.test.ts +82 -2
- package/src/modules/library/__tests__/tools.api.test.ts +44 -1
- package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
- package/src/modules/library/components/AddDialogTabs.tsx +103 -0
- package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
- package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
- package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
- package/src/modules/library/components/LibraryCard.tsx +146 -45
- package/src/modules/library/components/LibraryLayout.tsx +119 -256
- package/src/modules/library/components/LibraryPage.tsx +172 -39
- package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
- package/src/modules/library/components/LockedPluginView.tsx +62 -34
- package/src/modules/library/components/NameWithBadges.tsx +164 -0
- package/src/modules/library/components/NewPluginDialog.tsx +16 -2
- package/src/modules/library/components/PageActions.tsx +11 -9
- package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
- package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
- package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
- package/src/modules/library/components/PluginExtras.tsx +140 -17
- package/src/modules/library/components/PluginIndexRow.tsx +47 -12
- package/src/modules/library/components/PluginPage.tsx +157 -41
- package/src/modules/library/components/PluginRows.tsx +286 -0
- package/src/modules/library/components/PluginsSidebar.tsx +239 -263
- package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
- package/src/modules/library/components/ShareButton.tsx +17 -0
- package/src/modules/library/components/SkillsTree.tsx +141 -28
- package/src/modules/library/components/TeamRoute.tsx +15 -0
- package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
- package/src/modules/library/components/plugin-page-parts.tsx +103 -17
- package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
- package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
- package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
- package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
- package/src/modules/library/hooks/useLibraryData.ts +92 -19
- package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
- package/src/modules/library/routes/library-paths.ts +26 -28
- package/src/modules/library/services/library.api.ts +38 -20
- package/src/modules/library/services/plugins.api.ts +69 -8
- package/src/modules/library/services/teams.api.ts +15 -0
- package/src/modules/library/services/tools.api.ts +78 -0
- package/src/modules/library/state/library-data.tsx +170 -32
- package/src/modules/library/utils/personal-plugin.ts +13 -15
- package/src/modules/library/utils/plugin-entries.ts +134 -0
- package/src/modules/library/utils/plugin-summary.ts +75 -9
- package/src/modules/library/utils/status.ts +135 -33
- package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
- package/src/modules/onboarding/agent-clients.ts +55 -23
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
- package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
- package/src/modules/pr/services/pr-merge.api.ts +2 -1
- package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
- package/src/modules/review/components/ReviewPanel.tsx +15 -17
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
- package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
- package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
- package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
- package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
- package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
- package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
- package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
- package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
- package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
- package/src/modules/secrets-vault/services/connect.api.ts +36 -5
- package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
- package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
- package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
- package/src/modules/settings/components/DeploymentPage.tsx +10 -30
- package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
- package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +7 -6
- package/src/modules/settings/services/github-facade.api.ts +23 -0
- package/src/modules/settings/settings-nav-items.tsx +13 -3
- package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
- package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
- package/src/modules/setup/__tests__/setup.test.tsx +497 -4
- package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
- package/src/modules/setup/components/SetupGate.tsx +16 -16
- package/src/modules/setup/components/SetupScreen.tsx +532 -43
- package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
- package/src/modules/setup/services/setup.api.ts +141 -4
- package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
- package/src/modules/setup/utils/root-folders.ts +46 -0
- package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
- package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
- package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
- package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
- package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
- package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
- package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
- package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
- package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
- package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
- package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
- package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
- package/src/modules/toolbar/components/deployment-address.ts +29 -0
- package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
- package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
- package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
- package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
- package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
- package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
- package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
- package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
- package/src/modules/workflow/state/event-bus.context.ts +10 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
- package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
- package/src/modules/workspace/components/FileRoute.tsx +353 -36
- package/src/modules/workspace/components/FileViewer.tsx +172 -46
- package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
- package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
- package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2533 -129
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +381 -12
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
- package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
- package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
- package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
- package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
- package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
- package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
- package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
- package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
- package/src/modules/workspace/components/renderers/index.ts +53 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
- package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
- package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
- package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
- package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
- package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
- package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
- package/src/modules/workspace/routing/kb-routes.ts +206 -29
- package/src/modules/workspace/services/__tests__/workspace.api.test.ts +134 -1
- package/src/modules/workspace/services/workspace.api.ts +57 -4
- package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
- package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
- package/src/modules/workspace/state/open-change-requests.tsx +100 -12
- package/src/modules/workspace/state/workspace.context.ts +125 -19
- package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
- package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
- package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
- package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
- package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
- package/src/modules/workspace/utils/file-trace.ts +50 -0
- package/src/modules/workspace/utils/fileTree.ts +112 -36
- package/src/modules/workspace/utils/frontmatter.ts +8 -4
- package/src/modules/workspace/utils/pasteLink.ts +90 -0
- package/src/modules/workspace/utils/treeConfirm.ts +338 -0
- package/src/modules/workspace/utils/uploadError.ts +29 -0
- package/src/shared/__tests__/marketplace-url.test.ts +6 -1
- package/src/shared/components/Button.tsx +16 -2
- package/src/shared/components/Dialog.tsx +27 -11
- package/src/shared/components/Menu.tsx +13 -1
- package/src/shared/components/PageShell.tsx +13 -8
- package/src/shared/components/__tests__/primitives.test.tsx +116 -2
- package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
- package/src/shared/components/index.ts +2 -0
- package/src/shared/components/useDismissableMenu.ts +32 -10
- package/src/shared/components/useFocusHandoff.ts +51 -0
- package/src/shared/components/useLatestRef.ts +28 -0
- package/src/shared/markdown/Markdown.tsx +12 -3
- package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
- package/src/shared/markdown/hrefs.ts +50 -0
- package/src/shared/marketplace-url.ts +33 -5
- package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
- package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
- package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
- package/src/shared/mcp/connect-snippets.ts +14 -9
- package/src/shared/mcp/index.ts +1 -1
- package/src/shared/theme/__tests__/header-band.test.ts +197 -0
- package/src/shared/theme/header.ts +75 -0
- package/src/shared/theme/measure.ts +7 -4
- package/src/shared/theme/tokens.css +25 -0
- package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
- package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
- package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
- package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
- package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
- package/src/modules/update-check/services/update-check.api.ts +0 -24
|
@@ -4,6 +4,7 @@ import { useWorkspace } from '../state/workspace.context';
|
|
|
4
4
|
import { WorkspaceApiError } from '../services/workspace.api';
|
|
5
5
|
import { useGit } from '../../git/state/git.context';
|
|
6
6
|
import { readPersistedTabs } from '../utils/tab-persistence';
|
|
7
|
+
import { syncFileTraceFlag, traceFiles } from '../utils/file-trace';
|
|
7
8
|
import { DEFAULT_BRANCH } from '@bevel-software/platform-shared';
|
|
8
9
|
import {
|
|
9
10
|
NODE_ID_LINK_RE,
|
|
@@ -24,7 +25,16 @@ type SyncError =
|
|
|
24
25
|
| { kind: 'file-load-failed'; path: string; message: string }
|
|
25
26
|
| null;
|
|
26
27
|
|
|
27
|
-
|
|
28
|
+
/**
|
|
29
|
+
* `canonicalize` (default on): replace a path URL with the node's id URL once
|
|
30
|
+
* the file is open. OFF when this route is rendered inside the Library frame
|
|
31
|
+
* (`WorkspaceItemRoute`): an id URL (`/workspace/<branch>/<id>`) is not a
|
|
32
|
+
* library location, so the replacement would hand an id-bearing file — a
|
|
33
|
+
* `.tool` behind "Edit the tool file", a note with a frontmatter id — back to
|
|
34
|
+
* the Knowledge surface, which is exactly the switch that frame exists to
|
|
35
|
+
* avoid. The path URL stays; the file is the same.
|
|
36
|
+
*/
|
|
37
|
+
export function FileRoute({ canonicalize = true }: { canonicalize?: boolean } = {}) {
|
|
28
38
|
const params = useParams<{ branch: string; '*': string }>();
|
|
29
39
|
const navigate = useNavigate();
|
|
30
40
|
const location = useLocation();
|
|
@@ -70,9 +80,14 @@ export function FileRoute() {
|
|
|
70
80
|
// (workspaceId, branch) pair we've successfully hydrated tabs for. Reset to
|
|
71
81
|
// null on branch switch so re-hydration fires for the new branch.
|
|
72
82
|
const lastHydratedKeyRef = useRef<string | null>(null);
|
|
83
|
+
// `?trace=files` diagnostics only (see `utils/file-trace`): numbers each
|
|
84
|
+
// hydration so overlapping ones show in the console in start/settle order.
|
|
85
|
+
const hydrateSeqRef = useRef(0);
|
|
86
|
+
const traceOn = syncFileTraceFlag(location.search);
|
|
73
87
|
|
|
74
88
|
const {
|
|
75
89
|
workspaceId,
|
|
90
|
+
workspaceBranch,
|
|
76
91
|
openFilePath,
|
|
77
92
|
addTab,
|
|
78
93
|
hydrateTabs,
|
|
@@ -115,7 +130,7 @@ export function FileRoute() {
|
|
|
115
130
|
// ping-pong; gated on `openFilePath === segment` so the subsequent id→path
|
|
116
131
|
// load reuses the already-open tab instead of racing a second fetch.
|
|
117
132
|
useEffect(() => {
|
|
118
|
-
if (segmentIsId || !segment || !branchFromUrl) return;
|
|
133
|
+
if (!canonicalize || segmentIsId || !segment || !branchFromUrl) return;
|
|
119
134
|
if (openFilePath !== segment) return;
|
|
120
135
|
let cancelled = false;
|
|
121
136
|
(async () => {
|
|
@@ -127,17 +142,80 @@ export function FileRoute() {
|
|
|
127
142
|
return () => {
|
|
128
143
|
cancelled = true;
|
|
129
144
|
};
|
|
130
|
-
}, [segmentIsId, segment, branchFromUrl, openFilePath, location.hash, navigate]);
|
|
145
|
+
}, [canonicalize, segmentIsId, segment, branchFromUrl, openFilePath, location.hash, navigate]);
|
|
131
146
|
|
|
132
147
|
// ── Branch sync + hydrate + URL → state (forward direction) ──────────────
|
|
133
148
|
|
|
149
|
+
// Everything the decisions below read, so one console line says which gate
|
|
150
|
+
// held the page. A no-op unless the trace is on.
|
|
151
|
+
const trace = (decision: string, extra: Record<string, unknown> = {}) => {
|
|
152
|
+
if (!traceOn) return;
|
|
153
|
+
traceFiles(decision, {
|
|
154
|
+
url: location.pathname,
|
|
155
|
+
branchFromUrl,
|
|
156
|
+
pathFromUrl,
|
|
157
|
+
segment,
|
|
158
|
+
gitStatusBranch: currentBranch,
|
|
159
|
+
gitAvailability: git.availability,
|
|
160
|
+
gitLastError: git.lastError,
|
|
161
|
+
workspaceId,
|
|
162
|
+
workspaceBranch,
|
|
163
|
+
bootstrapError: workspace.bootstrapError,
|
|
164
|
+
hydrationKey: `${workspaceId}.${branchFromUrl}`,
|
|
165
|
+
lastHydratedKey: lastHydratedKeyRef.current,
|
|
166
|
+
openTabs: workspace.openTabs.map((t) => t.path),
|
|
167
|
+
openFilePath,
|
|
168
|
+
hasUnsavedEdits,
|
|
169
|
+
...extra,
|
|
170
|
+
});
|
|
171
|
+
};
|
|
172
|
+
|
|
173
|
+
// Trace only: a failed first bootstrap leaves `workspaceId` null and changes
|
|
174
|
+
// only `bootstrapError`, which the effect below does not re-run on (and must
|
|
175
|
+
// not: a re-run cancels an in-flight hydration). Log that wait from here, and
|
|
176
|
+
// again for each file click made while it lasts, so the console names the
|
|
177
|
+
// URL that stayed blank.
|
|
178
|
+
useEffect(() => {
|
|
179
|
+
if (!workspaceId) trace('wait:no-workspace');
|
|
180
|
+
// eslint-disable-next-line react-hooks/exhaustive-deps
|
|
181
|
+
}, [workspaceId, workspace.bootstrapError, location.pathname, traceOn]);
|
|
182
|
+
|
|
134
183
|
useEffect(() => {
|
|
135
184
|
if (!workspaceId) return;
|
|
136
185
|
if (!branchFromUrl) return;
|
|
137
186
|
|
|
138
187
|
let cancelled = false;
|
|
139
188
|
const branchKnown = currentBranch !== null;
|
|
140
|
-
|
|
189
|
+
// BOTH the workspace and the status it reported have to be on the URL's
|
|
190
|
+
// branch. They are two different facts:
|
|
191
|
+
// - `workspaceBranch` is what `workspaceId` IS (decoded straight off the
|
|
192
|
+
// id, so it moves in the same tick as the workspace).
|
|
193
|
+
// - `currentBranch` is what the last status refresh said, which is
|
|
194
|
+
// fetched against a workspace and lags a switch — and `useGitState`
|
|
195
|
+
// RETAINS the previous branch when a refresh fails.
|
|
196
|
+
// A retained status can therefore name the URL's branch while
|
|
197
|
+
// `workspaceId` already serves a different one: switch main → alice/draft,
|
|
198
|
+
// the status refresh against alice/draft's workspace fails and keeps
|
|
199
|
+
// saying `main`, then the user goes back to /workspace/main/... On the
|
|
200
|
+
// status alone that reads as a match, and the hydrate below would read
|
|
201
|
+
// main's paths out of alice/draft's workspace. Requiring the workspace
|
|
202
|
+
// itself to agree makes that impossible; the mismatch falls through to the
|
|
203
|
+
// re-bootstrap below, which is the recovery.
|
|
204
|
+
const branchMatches =
|
|
205
|
+
branchKnown && currentBranch === branchFromUrl && workspaceBranch === branchFromUrl;
|
|
206
|
+
|
|
207
|
+
// Nothing is read until we know which branch `workspaceId` is serving.
|
|
208
|
+
// Before, an unknown status (`gitStatusBranch=null` — every fresh browser
|
|
209
|
+
// session) fell straight through to the hydrate below and read the URL's
|
|
210
|
+
// path out of whatever workspace the first bootstrap happened to return.
|
|
211
|
+
// On a URL for a file that only exists on another branch that is a 404,
|
|
212
|
+
// dropped on the floor, followed by a silent wait for the next status
|
|
213
|
+
// poll. A read against the wrong branch is never useful: at best it is
|
|
214
|
+
// the wrong file's bytes, at worst a 404 for a file that exists.
|
|
215
|
+
if (!branchKnown) {
|
|
216
|
+
trace('wait:git-status');
|
|
217
|
+
return;
|
|
218
|
+
}
|
|
141
219
|
|
|
142
220
|
(async () => {
|
|
143
221
|
// 1) URL points at a different branch than the workspace currently
|
|
@@ -157,8 +235,9 @@ export function FileRoute() {
|
|
|
157
235
|
// state is NOT a gate here: per the save=share invariant the
|
|
158
236
|
// working tree is never dirty, and even if a bug leaves it dirty
|
|
159
237
|
// the user is moving to a different on-disk workspace anyway.
|
|
160
|
-
if (
|
|
238
|
+
if (!branchMatches) {
|
|
161
239
|
if (hasUnsavedEdits) {
|
|
240
|
+
trace('blocked:dirty');
|
|
162
241
|
setError({
|
|
163
242
|
kind: 'dirty',
|
|
164
243
|
current: currentBranch,
|
|
@@ -167,6 +246,7 @@ export function FileRoute() {
|
|
|
167
246
|
});
|
|
168
247
|
return;
|
|
169
248
|
}
|
|
249
|
+
trace('wait:branch-mismatch');
|
|
170
250
|
setError(null);
|
|
171
251
|
setPersistenceBranch(branchFromUrl);
|
|
172
252
|
// Bail out and wait for the bootstrap to update workspaceId +
|
|
@@ -189,9 +269,37 @@ export function FileRoute() {
|
|
|
189
269
|
}
|
|
190
270
|
const activePath = pathFromUrl || persisted.activePath;
|
|
191
271
|
setPersistenceBranch(branchFromUrl);
|
|
272
|
+
const hydrateSeq = ++hydrateSeqRef.current;
|
|
273
|
+
trace('hydrate:start', { hydrateSeq, paths, activePath });
|
|
192
274
|
try {
|
|
193
|
-
const { dropped, denied } = await hydrateTabs(paths, activePath);
|
|
275
|
+
const { surviving, dropped, denied, superseded } = await hydrateTabs(paths, activePath);
|
|
276
|
+
// The shared `openTabs`/`openFilePath` are this render's, from before
|
|
277
|
+
// the hydration; log what it left open, picking the active tab the
|
|
278
|
+
// way `hydrateTabs` does.
|
|
279
|
+
trace('hydrate:settled', {
|
|
280
|
+
hydrateSeq,
|
|
281
|
+
cancelled,
|
|
282
|
+
surviving,
|
|
283
|
+
dropped,
|
|
284
|
+
denied,
|
|
285
|
+
openTabs: surviving,
|
|
286
|
+
openFilePath:
|
|
287
|
+
activePath && surviving.includes(activePath)
|
|
288
|
+
? activePath
|
|
289
|
+
: (surviving[surviving.length - 1] ?? null),
|
|
290
|
+
});
|
|
194
291
|
if (cancelled) return;
|
|
292
|
+
// A hydration that never reached the tab strip — the workspace moved
|
|
293
|
+
// to another branch, or a newer restore overtook it — is not a
|
|
294
|
+
// hydration of this key. Recording it would mark the branch done
|
|
295
|
+
// while its tabs were never opened, and (`hydratedKeyRef` unset on
|
|
296
|
+
// the hook's side) never persisted again either. Leave the marker
|
|
297
|
+
// alone so the next run redoes it, and classify nothing: these
|
|
298
|
+
// results describe a strip that isn't on screen.
|
|
299
|
+
if (superseded) {
|
|
300
|
+
trace('hydrate:superseded', { hydrateSeq });
|
|
301
|
+
return;
|
|
302
|
+
}
|
|
195
303
|
lastHydratedKeyRef.current = hydrationKey;
|
|
196
304
|
// If the URL deeplinked to a path that 404'd or 403'd, say why
|
|
197
305
|
// nothing is showing. Persisted (non-deeplinked) tabs that fell in
|
|
@@ -204,6 +312,7 @@ export function FileRoute() {
|
|
|
204
312
|
setError(null);
|
|
205
313
|
}
|
|
206
314
|
} catch (err) {
|
|
315
|
+
trace('hydrate:failed', { hydrateSeq, cancelled, ...describeError(err) });
|
|
207
316
|
if (!cancelled) {
|
|
208
317
|
if (err instanceof WorkspaceApiError && err.status === 410) {
|
|
209
318
|
setError({ kind: 'branch-gone', branch: branchFromUrl });
|
|
@@ -219,27 +328,34 @@ export function FileRoute() {
|
|
|
219
328
|
// 3) URL → state delta (after hydrate; fires when the user navigates to
|
|
220
329
|
// a different file within the same branch).
|
|
221
330
|
if (pathFromUrl) {
|
|
222
|
-
|
|
223
|
-
|
|
224
|
-
|
|
225
|
-
|
|
226
|
-
|
|
227
|
-
|
|
228
|
-
|
|
229
|
-
|
|
230
|
-
|
|
231
|
-
|
|
232
|
-
|
|
233
|
-
|
|
234
|
-
|
|
235
|
-
|
|
236
|
-
|
|
237
|
-
|
|
331
|
+
// `addTab` runs even when this file is ALREADY the open one. It costs
|
|
332
|
+
// no read (the tab is reused) and it is the only way to say "this is
|
|
333
|
+
// the newest thing the user asked for" — skipping it left an older,
|
|
334
|
+
// still-in-flight `addTab` counting as the latest, so a burst of tree
|
|
335
|
+
// clicks ending on an open tab settled on whichever file that older
|
|
336
|
+
// read carried, with the URL naming this one and no way back but a
|
|
337
|
+
// reload.
|
|
338
|
+
trace(openFilePath === pathFromUrl ? 'add-tab:already-open' : 'add-tab:start');
|
|
339
|
+
try {
|
|
340
|
+
const added = await addTab(pathFromUrl);
|
|
341
|
+
trace('add-tab:settled', { added, cancelled });
|
|
342
|
+
if (!cancelled) setError(null);
|
|
343
|
+
} catch (err) {
|
|
344
|
+
trace('add-tab:failed', { cancelled, ...describeError(err) });
|
|
345
|
+
if (cancelled) return;
|
|
346
|
+
if (err instanceof WorkspaceApiError && err.status === 404) {
|
|
347
|
+
setError({ kind: 'file-missing', path: pathFromUrl });
|
|
348
|
+
} else if (err instanceof WorkspaceApiError && err.status === 403) {
|
|
349
|
+
setError({ kind: 'file-denied', path: pathFromUrl });
|
|
350
|
+
} else if (err instanceof WorkspaceApiError && err.status === 410) {
|
|
351
|
+
setError({ kind: 'branch-gone', branch: branchFromUrl });
|
|
352
|
+
} else {
|
|
353
|
+
const message = err instanceof Error ? err.message : 'Unknown error';
|
|
354
|
+
setError({ kind: 'file-load-failed', path: pathFromUrl, message });
|
|
238
355
|
}
|
|
239
|
-
} else if (!cancelled) {
|
|
240
|
-
setError(null);
|
|
241
356
|
}
|
|
242
357
|
} else if (!cancelled) {
|
|
358
|
+
trace('noop:no-path');
|
|
243
359
|
// URL with no path = "no active tab"; tabs in the strip stay open.
|
|
244
360
|
setError(null);
|
|
245
361
|
}
|
|
@@ -263,6 +379,7 @@ export function FileRoute() {
|
|
|
263
379
|
branchFromUrl,
|
|
264
380
|
pathFromUrl,
|
|
265
381
|
workspaceId,
|
|
382
|
+
workspaceBranch,
|
|
266
383
|
currentBranch,
|
|
267
384
|
hasUnsavedEdits,
|
|
268
385
|
]);
|
|
@@ -293,6 +410,137 @@ export function FileRoute() {
|
|
|
293
410
|
}
|
|
294
411
|
};
|
|
295
412
|
|
|
413
|
+
/**
|
|
414
|
+
* Manual retry for a git status refresh that failed. Until it answers, the
|
|
415
|
+
* route can't tell whether `workspaceId` is serving the URL's branch, so it
|
|
416
|
+
* reads nothing — which without this button was an indefinite silent wait
|
|
417
|
+
* for the 30 s poll (and if the failure persisted, forever).
|
|
418
|
+
*/
|
|
419
|
+
const retryStatus = async () => {
|
|
420
|
+
if (retrying) return;
|
|
421
|
+
setRetrying(true);
|
|
422
|
+
try {
|
|
423
|
+
await git.refreshStatus();
|
|
424
|
+
} finally {
|
|
425
|
+
setRetrying(false);
|
|
426
|
+
}
|
|
427
|
+
};
|
|
428
|
+
|
|
429
|
+
// ── Which of this route's screens is showing, and why ────────────────────
|
|
430
|
+
// All computed together, above the returns, so the `?trace=files` effect
|
|
431
|
+
// below can log the ONE state that won — and so the precedence between them
|
|
432
|
+
// is readable in one place instead of spread across eight early returns.
|
|
433
|
+
|
|
434
|
+
// The branch was deleted on the git host and its clone retired; there is
|
|
435
|
+
// nothing here to load or to retry. Two ways to learn it: a file read on a
|
|
436
|
+
// workspace we already had (410 from the read → `error`), or the bootstrap
|
|
437
|
+
// of the branch itself failing before there was a workspace at all (410
|
|
438
|
+
// from `GET /workspace` → `bootstrapError`, matched to THIS branch so a
|
|
439
|
+
// stale failure from a branch we left cannot paint over the current one).
|
|
440
|
+
const goneBranch =
|
|
441
|
+
error?.kind === 'branch-gone'
|
|
442
|
+
? error.branch
|
|
443
|
+
: workspace.bootstrapError?.status === 410 && workspace.bootstrapError.branch === branchFromUrl
|
|
444
|
+
? branchFromUrl
|
|
445
|
+
: null;
|
|
446
|
+
|
|
447
|
+
/**
|
|
448
|
+
* The URL names a branch the platform has never heard of (404 from
|
|
449
|
+
* `GET /workspace`) — a mistyped or made-up name, or a link to a branch
|
|
450
|
+
* that was never pushed. Nothing was deleted, so the branch-gone screen
|
|
451
|
+
* would be a lie; this is the file-missing story told about a branch.
|
|
452
|
+
* Matched to THIS branch for the same reason `goneBranch` is.
|
|
453
|
+
*/
|
|
454
|
+
const unknownBranch =
|
|
455
|
+
workspace.bootstrapError?.status === 404 && workspace.bootstrapError.branch === branchFromUrl
|
|
456
|
+
? branchFromUrl
|
|
457
|
+
: null;
|
|
458
|
+
|
|
459
|
+
/**
|
|
460
|
+
* A bootstrap that failed for a reason OTHER than "the branch is gone" —
|
|
461
|
+
* a 500, a 502, a dropped connection. It used to leave the page on its
|
|
462
|
+
* empty state for good: `workspaceId` stays where it was, the effect above
|
|
463
|
+
* either waits for a branch that will never arrive or reads from the wrong
|
|
464
|
+
* workspace, and nothing on screen says a thing.
|
|
465
|
+
*
|
|
466
|
+
* Shown when the failure is about the branch the URL names, and ALSO when
|
|
467
|
+
* there is no workspace at all — the first bootstrap runs against the
|
|
468
|
+
* default branch before any route has asked for one, so its failure is
|
|
469
|
+
* reported under the default branch's name while the URL may name another.
|
|
470
|
+
* Either way nothing can open until a bootstrap succeeds.
|
|
471
|
+
*/
|
|
472
|
+
const bootstrapFailure =
|
|
473
|
+
goneBranch === null &&
|
|
474
|
+
unknownBranch === null &&
|
|
475
|
+
workspace.bootstrapError &&
|
|
476
|
+
(workspace.bootstrapError.branch === branchFromUrl || workspaceId === null)
|
|
477
|
+
? workspace.bootstrapError
|
|
478
|
+
: null;
|
|
479
|
+
|
|
480
|
+
/**
|
|
481
|
+
* The git status refresh failed and the last branch we know of is not the
|
|
482
|
+
* one the URL names. `useGitState` keeps the previous `status.branch` on a
|
|
483
|
+
* failure and only flips `availability`, so this is indistinguishable from
|
|
484
|
+
* "still switching" — and the route waited on it silently, with
|
|
485
|
+
* `bootstrapError` null, until a later poll happened to succeed.
|
|
486
|
+
*/
|
|
487
|
+
const statusUnknown =
|
|
488
|
+
!bootstrapFailure && git.availability === 'error' && currentBranch !== branchFromUrl;
|
|
489
|
+
|
|
490
|
+
// What the viewer would render right now. It falls back to "Open a page to
|
|
491
|
+
// start reading." whenever there is no active tab carrying content — which,
|
|
492
|
+
// while the URL names a file, is the blank page this ticket is about.
|
|
493
|
+
const viewerIsBlank = !openFilePath || workspace.activeTab?.content == null;
|
|
494
|
+
|
|
495
|
+
/**
|
|
496
|
+
* The viewer is showing the file the URL names, read from the branch the URL
|
|
497
|
+
* names. Blankness alone is not the question: navigating from one open file
|
|
498
|
+
* to another (or to the same path on another branch) leaves the PREVIOUS
|
|
499
|
+
* tab's content on screen for the whole read, so a blank-only test called
|
|
500
|
+
* that "ready" and showed the old file with no sign that a new one was
|
|
501
|
+
* coming. Anything short of "the target, on the target's branch, with bytes
|
|
502
|
+
* in hand" is still loading.
|
|
503
|
+
*/
|
|
504
|
+
const viewerShowsTarget =
|
|
505
|
+
!viewerIsBlank &&
|
|
506
|
+
openFilePath === pathFromUrl &&
|
|
507
|
+
currentBranch === branchFromUrl &&
|
|
508
|
+
workspaceBranch === branchFromUrl;
|
|
509
|
+
|
|
510
|
+
/**
|
|
511
|
+
* An id segment whose path we haven't resolved yet: `pathFromUrl` is empty,
|
|
512
|
+
* so there is no path to compare and `viewerShowsTarget` is false by
|
|
513
|
+
* construction. Canonicalizing an open file (path URL → its id URL) passes
|
|
514
|
+
* through exactly this state with the file already on screen and nothing at
|
|
515
|
+
* all in flight — treating it as "not the target" would flash a loading
|
|
516
|
+
* screen over a page the user is reading, on every single file open. So
|
|
517
|
+
* while an id resolves, only true blankness counts as loading.
|
|
518
|
+
*/
|
|
519
|
+
const resolvingId = segmentIsId && pathFromUrl === '';
|
|
520
|
+
|
|
521
|
+
const loadingFile =
|
|
522
|
+
!error &&
|
|
523
|
+
!goneBranch &&
|
|
524
|
+
!unknownBranch &&
|
|
525
|
+
!bootstrapFailure &&
|
|
526
|
+
!statusUnknown &&
|
|
527
|
+
segment !== '' &&
|
|
528
|
+
(resolvingId ? viewerIsBlank : !viewerShowsTarget)
|
|
529
|
+
? pathFromUrl || segment
|
|
530
|
+
: null;
|
|
531
|
+
|
|
532
|
+
const screen =
|
|
533
|
+
error?.kind === 'dirty' ? 'dirty'
|
|
534
|
+
: goneBranch !== null ? 'branch-gone'
|
|
535
|
+
: unknownBranch !== null ? 'branch-not-found'
|
|
536
|
+
: bootstrapFailure ? 'bootstrap-failed'
|
|
537
|
+
: statusUnknown ? 'git-status-failed'
|
|
538
|
+
: error ? error.kind
|
|
539
|
+
: loadingFile ? 'loading'
|
|
540
|
+
: 'viewer';
|
|
541
|
+
// eslint-disable-next-line react-hooks/exhaustive-deps
|
|
542
|
+
useEffect(() => { trace('screen', { screen, loadingFile }); }, [screen, loadingFile, traceOn]);
|
|
543
|
+
|
|
296
544
|
// No state→URL effect. The URL is the single authority for "what's active",
|
|
297
545
|
// and only one direction of sync runs at a time:
|
|
298
546
|
// - User clicks a tab in EditorTabs → useFileNav.openFile(path) → URL changes → URL→state activates
|
|
@@ -330,18 +578,6 @@ export function FileRoute() {
|
|
|
330
578
|
);
|
|
331
579
|
}
|
|
332
580
|
|
|
333
|
-
// The branch was deleted on the git host and its clone retired; there is
|
|
334
|
-
// nothing here to load or to retry. Two ways to learn it: a file read on a
|
|
335
|
-
// workspace we already had (410 from the read → `error`), or the bootstrap
|
|
336
|
-
// of the branch itself failing before there was a workspace at all (410
|
|
337
|
-
// from `GET /workspace` → `bootstrapError`, matched to THIS branch so a
|
|
338
|
-
// stale failure from a branch we left cannot paint over the current one).
|
|
339
|
-
const goneBranch =
|
|
340
|
-
error?.kind === 'branch-gone'
|
|
341
|
-
? error.branch
|
|
342
|
-
: workspace.bootstrapError?.status === 410 && workspace.bootstrapError.branch === branchFromUrl
|
|
343
|
-
? branchFromUrl
|
|
344
|
-
: null;
|
|
345
581
|
if (goneBranch !== null) {
|
|
346
582
|
return (
|
|
347
583
|
<ErrorScreen title="This branch no longer exists">
|
|
@@ -355,6 +591,56 @@ export function FileRoute() {
|
|
|
355
591
|
);
|
|
356
592
|
}
|
|
357
593
|
|
|
594
|
+
if (unknownBranch !== null) {
|
|
595
|
+
return (
|
|
596
|
+
<ErrorScreen title="Branch not found">
|
|
597
|
+
<p className="text-ui text-ink-muted">
|
|
598
|
+
There is no branch named{' '}
|
|
599
|
+
<span className="font-mono text-ink">{unknownBranch}</span>.
|
|
600
|
+
</p>
|
|
601
|
+
<p className="text-meta text-ink-faint">
|
|
602
|
+
It may never have been pushed, or this link may have the name wrong.
|
|
603
|
+
</p>
|
|
604
|
+
<Button onClick={() => navigate(kbFileUrl(DEFAULT_BRANCH))}>Go to {DEFAULT_BRANCH}</Button>
|
|
605
|
+
</ErrorScreen>
|
|
606
|
+
);
|
|
607
|
+
}
|
|
608
|
+
|
|
609
|
+
if (bootstrapFailure) {
|
|
610
|
+
return (
|
|
611
|
+
<ErrorScreen title={`Couldn't open ${bootstrapFailure.branch}`}>
|
|
612
|
+
<p className="text-ui text-ink-muted">
|
|
613
|
+
Loading the workspace for{' '}
|
|
614
|
+
<span className="font-mono text-ink">{bootstrapFailure.branch}</span> failed
|
|
615
|
+
{bootstrapFailure.status ? ` with HTTP ${bootstrapFailure.status}` : ', the request never completed'}.
|
|
616
|
+
Nothing on this branch can open until it succeeds.
|
|
617
|
+
</p>
|
|
618
|
+
<p className="font-mono text-meta text-ink-faint">{bootstrapFailure.message}</p>
|
|
619
|
+
<Button onClick={workspace.retryBootstrap}>Retry</Button>
|
|
620
|
+
</ErrorScreen>
|
|
621
|
+
);
|
|
622
|
+
}
|
|
623
|
+
|
|
624
|
+
if (statusUnknown) {
|
|
625
|
+
return (
|
|
626
|
+
<ErrorScreen title="Couldn't check which branch this workspace is on">
|
|
627
|
+
<p className="text-ui text-ink-muted">
|
|
628
|
+
This link is on{' '}
|
|
629
|
+
<span className="font-mono text-ink">{branchFromUrl}</span>
|
|
630
|
+
{currentBranch
|
|
631
|
+
? <> and the workspace was last on <span className="font-mono text-ink">{currentBranch}</span></>
|
|
632
|
+
: null}
|
|
633
|
+
. Opening the file now could read it from the wrong branch, so it waits for
|
|
634
|
+
the check to answer.
|
|
635
|
+
</p>
|
|
636
|
+
{git.lastError && <p className="font-mono text-meta text-ink-faint">{git.lastError}</p>}
|
|
637
|
+
<Button onClick={retryStatus} disabled={retrying}>
|
|
638
|
+
{retrying ? 'Retrying…' : 'Retry'}
|
|
639
|
+
</Button>
|
|
640
|
+
</ErrorScreen>
|
|
641
|
+
);
|
|
642
|
+
}
|
|
643
|
+
|
|
358
644
|
if (error?.kind === 'file-missing') {
|
|
359
645
|
return (
|
|
360
646
|
<ErrorScreen title="File not found">
|
|
@@ -410,9 +696,40 @@ export function FileRoute() {
|
|
|
410
696
|
);
|
|
411
697
|
}
|
|
412
698
|
|
|
699
|
+
// The URL names a file and the viewer has nothing to show yet — a bootstrap,
|
|
700
|
+
// a git status or the read itself is still in flight. Say which file is
|
|
701
|
+
// coming. The viewer's "Open a page to start reading." is for a URL that
|
|
702
|
+
// names NO file; showing it here is what made a working page look empty.
|
|
703
|
+
if (loadingFile) {
|
|
704
|
+
return (
|
|
705
|
+
<div className="flex h-full w-full items-center justify-center bg-canvas px-6">
|
|
706
|
+
<div role="status" aria-live="polite" className="max-w-md space-y-3 text-center">
|
|
707
|
+
<h2 className="text-head text-ink">Opening {basename(loadingFile)}…</h2>
|
|
708
|
+
<p className="text-ui text-ink-muted">
|
|
709
|
+
<span className="font-mono text-ink">{loadingFile}</span> on{' '}
|
|
710
|
+
<span className="font-mono text-ink">{branchFromUrl}</span>
|
|
711
|
+
</p>
|
|
712
|
+
</div>
|
|
713
|
+
</div>
|
|
714
|
+
);
|
|
715
|
+
}
|
|
716
|
+
|
|
413
717
|
return <FileViewer />;
|
|
414
718
|
}
|
|
415
719
|
|
|
720
|
+
function basename(path: string): string {
|
|
721
|
+
const i = path.lastIndexOf('/');
|
|
722
|
+
return i >= 0 ? path.slice(i + 1) : path;
|
|
723
|
+
}
|
|
724
|
+
|
|
725
|
+
/** The status and message of a failed read, for the `?trace=files` log. */
|
|
726
|
+
function describeError(err: unknown): { status: number | null; message: string } {
|
|
727
|
+
return {
|
|
728
|
+
status: err instanceof WorkspaceApiError ? err.status : null,
|
|
729
|
+
message: err instanceof Error ? err.message : String(err),
|
|
730
|
+
};
|
|
731
|
+
}
|
|
732
|
+
|
|
416
733
|
/**
|
|
417
734
|
* One frame for the four full-screen states this route can end in.
|
|
418
735
|
*
|