@bevel-software/platform-core-frontend 0.15.1 → 0.20.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/THIRD-PARTY-NOTICES.md +2 -2
- package/package.json +3 -3
- package/src/core/CoreAppShell.tsx +20 -9
- package/src/core/__tests__/AppChrome.test.tsx +0 -3
- package/src/core/__tests__/events.test.ts +43 -0
- package/src/core/bootstrap.ts +11 -3
- package/src/core/events.ts +85 -3
- package/src/core/registry.ts +1 -1
- package/src/lib/__tests__/email.test.ts +44 -0
- package/src/lib/email.ts +37 -1
- package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
- package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
- package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
- package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
- package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
- package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
- package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
- package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
- package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
- package/src/modules/access/api.ts +140 -6
- package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
- package/src/modules/access/manage-access-affordance.ts +17 -0
- package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
- package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
- package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
- package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
- package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
- package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
- package/src/modules/admin/components/AddMemberInput.tsx +268 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
- package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
- package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
- package/src/modules/admin/components/group-members-path.ts +32 -0
- package/src/modules/admin/services/roles.api.ts +12 -1
- package/src/modules/audit/__tests__/AuditLogPage.test.tsx +312 -0
- package/src/modules/audit/components/AuditEventsPanel.tsx +319 -0
- package/src/modules/audit/components/AuditLogPage.tsx +373 -0
- package/src/modules/audit/components/principal-grouping.ts +49 -0
- package/src/modules/audit/services/audit.api.ts +98 -0
- package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
- package/src/modules/auth/components/AccountPage.tsx +73 -54
- package/src/modules/auth/components/LoginScreen.tsx +1 -0
- package/src/modules/auth/services/account.api.ts +78 -4
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
- package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
- package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
- package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
- package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
- package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
- package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
- package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
- package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
- package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
- package/src/modules/change-requests/services/change-requests.api.ts +57 -1
- package/src/modules/change-requests/services/denied-file.api.ts +53 -0
- package/src/modules/change-requests/services/propose.api.ts +97 -8
- package/src/modules/change-requests/utils/approval.ts +15 -0
- package/src/modules/change-requests/utils/author.ts +32 -0
- package/src/modules/change-requests/utils/readFailure.ts +110 -0
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
- package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
- package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
- package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
- package/src/modules/git/services/error-messages.ts +12 -0
- package/src/modules/git/services/pr-prompts.ts +5 -5
- package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
- package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
- package/src/modules/layout/components/AppLayout.tsx +2 -0
- package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
- package/src/modules/layout/components/SidebarFrame.tsx +108 -3
- package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
- package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
- package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
- package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
- package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
- package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
- package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
- package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
- package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
- package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
- package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
- package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
- package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
- package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
- package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
- package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
- package/src/modules/library/__tests__/auth-harness.tsx +9 -9
- package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
- package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
- package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
- package/src/modules/library/__tests__/library-data.test.ts +7 -0
- package/src/modules/library/__tests__/library-paths.test.ts +47 -4
- package/src/modules/library/__tests__/link-membership.test.ts +13 -4
- package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
- package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
- package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
- package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
- package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
- package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
- package/src/modules/library/__tests__/status.test.ts +82 -2
- package/src/modules/library/__tests__/tools.api.test.ts +44 -1
- package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
- package/src/modules/library/components/AddDialogTabs.tsx +103 -0
- package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
- package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
- package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
- package/src/modules/library/components/LibraryCard.tsx +146 -45
- package/src/modules/library/components/LibraryLayout.tsx +119 -256
- package/src/modules/library/components/LibraryPage.tsx +172 -39
- package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
- package/src/modules/library/components/LockedPluginView.tsx +62 -34
- package/src/modules/library/components/NameWithBadges.tsx +164 -0
- package/src/modules/library/components/NewPluginDialog.tsx +16 -2
- package/src/modules/library/components/PageActions.tsx +11 -9
- package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
- package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
- package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
- package/src/modules/library/components/PluginExtras.tsx +140 -17
- package/src/modules/library/components/PluginIndexRow.tsx +47 -12
- package/src/modules/library/components/PluginPage.tsx +157 -41
- package/src/modules/library/components/PluginRows.tsx +286 -0
- package/src/modules/library/components/PluginsSidebar.tsx +239 -263
- package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
- package/src/modules/library/components/ShareButton.tsx +17 -0
- package/src/modules/library/components/SkillsTree.tsx +141 -28
- package/src/modules/library/components/TeamRoute.tsx +15 -0
- package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
- package/src/modules/library/components/plugin-page-parts.tsx +103 -17
- package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
- package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
- package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
- package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
- package/src/modules/library/hooks/useLibraryData.ts +92 -19
- package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
- package/src/modules/library/routes/library-paths.ts +26 -28
- package/src/modules/library/services/library.api.ts +38 -20
- package/src/modules/library/services/plugins.api.ts +69 -8
- package/src/modules/library/services/teams.api.ts +15 -0
- package/src/modules/library/services/tools.api.ts +78 -0
- package/src/modules/library/state/library-data.tsx +170 -32
- package/src/modules/library/utils/personal-plugin.ts +13 -15
- package/src/modules/library/utils/plugin-entries.ts +134 -0
- package/src/modules/library/utils/plugin-summary.ts +75 -9
- package/src/modules/library/utils/status.ts +135 -33
- package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
- package/src/modules/onboarding/agent-clients.ts +55 -23
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
- package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
- package/src/modules/pr/services/pr-merge.api.ts +2 -1
- package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
- package/src/modules/review/components/ReviewPanel.tsx +15 -17
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
- package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
- package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
- package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
- package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
- package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
- package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
- package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
- package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
- package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
- package/src/modules/secrets-vault/services/connect.api.ts +36 -5
- package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
- package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
- package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
- package/src/modules/settings/components/DeploymentPage.tsx +10 -30
- package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
- package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +7 -6
- package/src/modules/settings/services/github-facade.api.ts +23 -0
- package/src/modules/settings/settings-nav-items.tsx +13 -3
- package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
- package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
- package/src/modules/setup/__tests__/setup.test.tsx +497 -4
- package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
- package/src/modules/setup/components/SetupGate.tsx +16 -16
- package/src/modules/setup/components/SetupScreen.tsx +532 -43
- package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
- package/src/modules/setup/services/setup.api.ts +141 -4
- package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
- package/src/modules/setup/utils/root-folders.ts +46 -0
- package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
- package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
- package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
- package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
- package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
- package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
- package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
- package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
- package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
- package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
- package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
- package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
- package/src/modules/toolbar/components/deployment-address.ts +29 -0
- package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
- package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
- package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
- package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
- package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
- package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
- package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
- package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
- package/src/modules/workflow/state/event-bus.context.ts +10 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
- package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
- package/src/modules/workspace/components/FileRoute.tsx +353 -36
- package/src/modules/workspace/components/FileViewer.tsx +172 -46
- package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
- package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
- package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2533 -129
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +381 -12
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
- package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
- package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
- package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
- package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
- package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
- package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
- package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
- package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
- package/src/modules/workspace/components/renderers/index.ts +53 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
- package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
- package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
- package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
- package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
- package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
- package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
- package/src/modules/workspace/routing/kb-routes.ts +206 -29
- package/src/modules/workspace/services/__tests__/workspace.api.test.ts +134 -1
- package/src/modules/workspace/services/workspace.api.ts +57 -4
- package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
- package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
- package/src/modules/workspace/state/open-change-requests.tsx +100 -12
- package/src/modules/workspace/state/workspace.context.ts +125 -19
- package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
- package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
- package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
- package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
- package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
- package/src/modules/workspace/utils/file-trace.ts +50 -0
- package/src/modules/workspace/utils/fileTree.ts +112 -36
- package/src/modules/workspace/utils/frontmatter.ts +8 -4
- package/src/modules/workspace/utils/pasteLink.ts +90 -0
- package/src/modules/workspace/utils/treeConfirm.ts +338 -0
- package/src/modules/workspace/utils/uploadError.ts +29 -0
- package/src/shared/__tests__/marketplace-url.test.ts +6 -1
- package/src/shared/components/Button.tsx +16 -2
- package/src/shared/components/Dialog.tsx +27 -11
- package/src/shared/components/Menu.tsx +13 -1
- package/src/shared/components/PageShell.tsx +13 -8
- package/src/shared/components/__tests__/primitives.test.tsx +116 -2
- package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
- package/src/shared/components/index.ts +2 -0
- package/src/shared/components/useDismissableMenu.ts +32 -10
- package/src/shared/components/useFocusHandoff.ts +51 -0
- package/src/shared/components/useLatestRef.ts +28 -0
- package/src/shared/markdown/Markdown.tsx +12 -3
- package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
- package/src/shared/markdown/hrefs.ts +50 -0
- package/src/shared/marketplace-url.ts +33 -5
- package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
- package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
- package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
- package/src/shared/mcp/connect-snippets.ts +14 -9
- package/src/shared/mcp/index.ts +1 -1
- package/src/shared/theme/__tests__/header-band.test.ts +197 -0
- package/src/shared/theme/header.ts +75 -0
- package/src/shared/theme/measure.ts +7 -4
- package/src/shared/theme/tokens.css +25 -0
- package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
- package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
- package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
- package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
- package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
- package/src/modules/update-check/services/update-check.api.ts +0 -24
|
@@ -0,0 +1,238 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { act, renderHook, waitFor } from '@testing-library/react';
|
|
3
|
+
import type { PullRequestSummary } from '@bevel-software/platform-shared';
|
|
4
|
+
|
|
5
|
+
/**
|
|
6
|
+
* The file page's change boxes: what each request does to the open file. Like
|
|
7
|
+
* the request dialog, a box reads its "before" at the request's fork point —
|
|
8
|
+
* an edit made on main after the proposal is not something the proposal
|
|
9
|
+
* deletes.
|
|
10
|
+
*/
|
|
11
|
+
|
|
12
|
+
const api = vi.hoisted(() => ({ readFileOnBranch: vi.fn(), readFileAtForkPoint: vi.fn() }));
|
|
13
|
+
vi.mock('../services/change-requests.api', () => api);
|
|
14
|
+
|
|
15
|
+
import { useCrFileDiffs } from '../hooks/useCrFileDiffs';
|
|
16
|
+
import { PR_STALE_EVENT } from '../../../core/events';
|
|
17
|
+
import { DEFAULT_BRANCH } from '@bevel-software/platform-shared';
|
|
18
|
+
import { WorkspaceApiError } from '../../workspace/services/workspace.api';
|
|
19
|
+
|
|
20
|
+
const PATH = 'Sales/deal.yaml';
|
|
21
|
+
const ORIGINAL = 'price: 100\nstatus: draft\n';
|
|
22
|
+
const MAIN_NOW = 'price: 100\nstatus: signed\n'; // edited on main after the proposal
|
|
23
|
+
const PROPOSED = 'price: 120\nstatus: draft\n';
|
|
24
|
+
const CR = {
|
|
25
|
+
number: 21,
|
|
26
|
+
branch: 'alice/deal',
|
|
27
|
+
base: DEFAULT_BRANCH,
|
|
28
|
+
touchedNodePaths: [PATH],
|
|
29
|
+
} as unknown as PullRequestSummary;
|
|
30
|
+
|
|
31
|
+
const lines = (d: { kind: string; text: string }[] | null | undefined | 'unreadable', kind: string) =>
|
|
32
|
+
(d === 'unreadable' ? [] : (d ?? [])).filter((l) => l.kind === kind).map((l) => l.text);
|
|
33
|
+
|
|
34
|
+
beforeEach(() => {
|
|
35
|
+
// The proposal branch answers with its copy; main, when it is read at all,
|
|
36
|
+
// answers with the tip carrying the later direct edit.
|
|
37
|
+
api.readFileOnBranch
|
|
38
|
+
.mockReset()
|
|
39
|
+
.mockImplementation(async (branch: string) => (branch === DEFAULT_BRANCH ? MAIN_NOW : PROPOSED));
|
|
40
|
+
api.readFileAtForkPoint.mockReset().mockResolvedValue({ content: ORIGINAL, forkSha: 'f'.repeat(40) });
|
|
41
|
+
});
|
|
42
|
+
|
|
43
|
+
describe('useCrFileDiffs', () => {
|
|
44
|
+
it("diffs from the request's fork point: a later edit on main is not shown as a deletion", async () => {
|
|
45
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
46
|
+
await waitFor(() => expect(result.current.get(21)).not.toBeNull());
|
|
47
|
+
const d = result.current.get(21)!;
|
|
48
|
+
expect(lines(d, 'removed')).toEqual(['price: 100']);
|
|
49
|
+
expect(lines(d, 'added')).toEqual(['price: 120']);
|
|
50
|
+
expect(api.readFileAtForkPoint).toHaveBeenCalledWith(21, null, PATH);
|
|
51
|
+
});
|
|
52
|
+
|
|
53
|
+
it('after an Update both sides move together — the target\'s own newer line is never a deletion', async () => {
|
|
54
|
+
// Exactly what a successful Update leaves behind: the proposal branch now
|
|
55
|
+
// carries the target's line too, and the fork point is the target it was
|
|
56
|
+
// merged from. Re-reading only the fork point put THAT text opposite the
|
|
57
|
+
// branch copy cached from before the merge, and the box struck through the
|
|
58
|
+
// target's own edit — the failure this test exists for.
|
|
59
|
+
const MERGED_BRANCH = 'price: 120\nstatus: signed\n';
|
|
60
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
61
|
+
await waitFor(() => expect(result.current.get(21)).not.toBeNull());
|
|
62
|
+
expect(lines(result.current.get(21), 'removed')).toEqual(['price: 100']);
|
|
63
|
+
|
|
64
|
+
api.readFileAtForkPoint.mockResolvedValue({ content: MAIN_NOW, forkSha: 'e'.repeat(40) });
|
|
65
|
+
// Hold the BRANCH copy so the fork point lands first — the order that used
|
|
66
|
+
// to mix, because the branch side was served from the pre-merge cache and
|
|
67
|
+
// the target's own newer line read as a deletion.
|
|
68
|
+
let releaseBranch: (content: string) => void = () => {};
|
|
69
|
+
api.readFileOnBranch.mockImplementationOnce(
|
|
70
|
+
() => new Promise((resolve) => (releaseBranch = resolve)),
|
|
71
|
+
);
|
|
72
|
+
await act(async () => {
|
|
73
|
+
window.dispatchEvent(new Event(PR_STALE_EVENT));
|
|
74
|
+
});
|
|
75
|
+
|
|
76
|
+
// Both sides are read again — the branch copy as well as the fork point.
|
|
77
|
+
await waitFor(() => expect(api.readFileOnBranch).toHaveBeenCalledTimes(2));
|
|
78
|
+
await waitFor(() => expect(api.readFileAtForkPoint).toHaveBeenCalledTimes(2));
|
|
79
|
+
// The fork point has landed and the branch copy has not: the box waits,
|
|
80
|
+
// rather than showing a diff between two moments.
|
|
81
|
+
expect(result.current.get(21)).toBeNull();
|
|
82
|
+
|
|
83
|
+
await act(async () => {
|
|
84
|
+
releaseBranch(MERGED_BRANCH);
|
|
85
|
+
});
|
|
86
|
+
await waitFor(() =>
|
|
87
|
+
expect(lines(result.current.get(21), 'added')).toEqual(['price: 120']),
|
|
88
|
+
);
|
|
89
|
+
expect(lines(result.current.get(21), 'removed')).toEqual(['price: 100']);
|
|
90
|
+
});
|
|
91
|
+
|
|
92
|
+
it('re-reads the fork point when a request moves, not on every revision bump', async () => {
|
|
93
|
+
const { result, rerender } = renderHook(({ rev }: { rev: number }) => useCrFileDiffs([CR], PATH, rev), {
|
|
94
|
+
initialProps: { rev: 0 },
|
|
95
|
+
});
|
|
96
|
+
await waitFor(() => expect(result.current.get(21)).not.toBeNull());
|
|
97
|
+
expect(api.readFileAtForkPoint).toHaveBeenCalledTimes(1);
|
|
98
|
+
|
|
99
|
+
// A tab switch or an apply elsewhere on the page re-reads the branch copy,
|
|
100
|
+
// which can have changed — the fork point cannot have.
|
|
101
|
+
rerender({ rev: 1 });
|
|
102
|
+
await waitFor(() => expect(api.readFileOnBranch).toHaveBeenCalledTimes(2));
|
|
103
|
+
expect(api.readFileAtForkPoint).toHaveBeenCalledTimes(1);
|
|
104
|
+
|
|
105
|
+
// An Update does move it, and says so.
|
|
106
|
+
await act(async () => {
|
|
107
|
+
window.dispatchEvent(new Event(PR_STALE_EVENT));
|
|
108
|
+
});
|
|
109
|
+
await waitFor(() => expect(api.readFileAtForkPoint).toHaveBeenCalledTimes(2));
|
|
110
|
+
});
|
|
111
|
+
|
|
112
|
+
it('a slow read from a passed generation never erases the current one', async () => {
|
|
113
|
+
// The first branch read is still out when a request moves. Its answer
|
|
114
|
+
// arrives last, describing a moment that is over: it must be dropped, and
|
|
115
|
+
// it must not take the newer answer with it — a box that loses the fresh
|
|
116
|
+
// read is never told to fetch again, and loads forever.
|
|
117
|
+
let releaseFirst: (content: string) => void = () => {};
|
|
118
|
+
api.readFileOnBranch.mockImplementationOnce(
|
|
119
|
+
() => new Promise((resolve) => (releaseFirst = resolve)),
|
|
120
|
+
);
|
|
121
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
122
|
+
await waitFor(() => expect(api.readFileOnBranch).toHaveBeenCalledTimes(1));
|
|
123
|
+
|
|
124
|
+
api.readFileOnBranch.mockResolvedValue('price: 140\nstatus: draft\n');
|
|
125
|
+
await act(async () => {
|
|
126
|
+
window.dispatchEvent(new Event(PR_STALE_EVENT));
|
|
127
|
+
});
|
|
128
|
+
await waitFor(() => expect(lines(result.current.get(21), 'added')).toEqual(['price: 140']));
|
|
129
|
+
|
|
130
|
+
await act(async () => {
|
|
131
|
+
releaseFirst(PROPOSED);
|
|
132
|
+
});
|
|
133
|
+
expect(lines(result.current.get(21), 'added')).toEqual(['price: 140']);
|
|
134
|
+
});
|
|
135
|
+
|
|
136
|
+
it('a file the fork point lacks (the request adds it) diffs from empty', async () => {
|
|
137
|
+
api.readFileAtForkPoint.mockResolvedValue({ content: null, forkSha: 'f'.repeat(40) });
|
|
138
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
139
|
+
await waitFor(() => expect(result.current.get(21)).not.toBeNull());
|
|
140
|
+
expect(lines(result.current.get(21), 'removed')).toEqual([]);
|
|
141
|
+
expect(lines(result.current.get(21), 'added')).toEqual(['price: 120', 'status: draft']);
|
|
142
|
+
});
|
|
143
|
+
|
|
144
|
+
it('branches with no shared history fall back to the target — the only text left', async () => {
|
|
145
|
+
api.readFileAtForkPoint.mockResolvedValue({ content: null, forkSha: null });
|
|
146
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
147
|
+
await waitFor(() => expect(result.current.get(21)).not.toBeNull());
|
|
148
|
+
expect(lines(result.current.get(21), 'removed')).toEqual(['price: 100', 'status: signed']);
|
|
149
|
+
// The target is read HERE, under this generation — and only because there
|
|
150
|
+
// was no fork point to read instead.
|
|
151
|
+
expect(api.readFileOnBranch).toHaveBeenCalledWith(DEFAULT_BRANCH, PATH);
|
|
152
|
+
});
|
|
153
|
+
|
|
154
|
+
it('never reads the target for a request that has a fork point', async () => {
|
|
155
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
156
|
+
await waitFor(() => expect(result.current.get(21)).not.toBeNull());
|
|
157
|
+
expect(api.readFileOnBranch).not.toHaveBeenCalledWith(DEFAULT_BRANCH, PATH);
|
|
158
|
+
});
|
|
159
|
+
|
|
160
|
+
it('a stale event re-reads the target too, so an unrelated-history box never pairs two moments', async () => {
|
|
161
|
+
api.readFileAtForkPoint.mockResolvedValue({ content: null, forkSha: null });
|
|
162
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
163
|
+
await waitFor(() => expect(result.current.get(21)).not.toBeNull());
|
|
164
|
+
|
|
165
|
+
// The target moved on, and so did the proposal.
|
|
166
|
+
api.readFileOnBranch.mockImplementation(async (branch: string) =>
|
|
167
|
+
branch === DEFAULT_BRANCH ? 'price: 100\nstatus: closed\n' : 'price: 140\nstatus: closed\n',
|
|
168
|
+
);
|
|
169
|
+
await act(async () => {
|
|
170
|
+
window.dispatchEvent(new Event(PR_STALE_EVENT));
|
|
171
|
+
});
|
|
172
|
+
await waitFor(() =>
|
|
173
|
+
expect(lines(result.current.get(21), 'added')).toEqual(['price: 140']),
|
|
174
|
+
);
|
|
175
|
+
// Against the target as it stands NOW: its 'status: closed' is not a deletion.
|
|
176
|
+
expect(lines(result.current.get(21), 'removed')).toEqual(['price: 100']);
|
|
177
|
+
});
|
|
178
|
+
|
|
179
|
+
it('an unreadable fork point says so — never a diff against main, never loading forever', async () => {
|
|
180
|
+
api.readFileAtForkPoint.mockRejectedValue(new Error('503'));
|
|
181
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
182
|
+
await waitFor(() => expect(result.current.get(21)).toBe('unreadable'));
|
|
183
|
+
});
|
|
184
|
+
|
|
185
|
+
it('a file the request deletes (absent on its branch) shows every line removed', async () => {
|
|
186
|
+
api.readFileOnBranch.mockRejectedValue(new WorkspaceApiError(404));
|
|
187
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
188
|
+
await waitFor(() => expect(Array.isArray(result.current.get(21))).toBe(true));
|
|
189
|
+
expect(lines(result.current.get(21), 'removed')).toEqual(['price: 100', 'status: draft']);
|
|
190
|
+
expect(lines(result.current.get(21), 'added')).toEqual([]);
|
|
191
|
+
});
|
|
192
|
+
|
|
193
|
+
it('an unreadable branch copy says so too', async () => {
|
|
194
|
+
api.readFileOnBranch.mockRejectedValue(new Error('403'));
|
|
195
|
+
const { result } = renderHook(() => useCrFileDiffs([CR], PATH));
|
|
196
|
+
await waitFor(() => expect(result.current.get(21)).toBe('unreadable'));
|
|
197
|
+
});
|
|
198
|
+
it("reads the request's OWN target, not the default branch", async () => {
|
|
199
|
+
// A proposal against a non-default target with no shared history: its
|
|
200
|
+
// "before" is that target's tip. Reading the default branch would show it
|
|
201
|
+
// changes someone else's file.
|
|
202
|
+
const RELEASE = 'release-2027';
|
|
203
|
+
const onRelease = { ...CR, number: 22, base: RELEASE } as unknown as PullRequestSummary;
|
|
204
|
+
api.readFileAtForkPoint.mockResolvedValue({ content: null, forkSha: null });
|
|
205
|
+
api.readFileOnBranch.mockImplementation(async (branch: string) =>
|
|
206
|
+
branch === RELEASE ? 'price: 90\nstatus: draft\n' : branch === DEFAULT_BRANCH ? MAIN_NOW : PROPOSED,
|
|
207
|
+
);
|
|
208
|
+
const { result } = renderHook(() => useCrFileDiffs([onRelease], PATH));
|
|
209
|
+
await waitFor(() => expect(result.current.get(22)).not.toBeNull());
|
|
210
|
+
|
|
211
|
+
expect(api.readFileOnBranch).toHaveBeenCalledWith(RELEASE, PATH);
|
|
212
|
+
expect(api.readFileOnBranch).not.toHaveBeenCalledWith(DEFAULT_BRANCH, PATH);
|
|
213
|
+
// Diffed against the release tip: only the price moved.
|
|
214
|
+
expect(lines(result.current.get(22), 'removed')).toEqual(['price: 90']);
|
|
215
|
+
expect(lines(result.current.get(22), 'added')).toEqual(['price: 120']);
|
|
216
|
+
});
|
|
217
|
+
|
|
218
|
+
it('two no-history requests on one file never share a target read', async () => {
|
|
219
|
+
const RELEASE = 'release-2027';
|
|
220
|
+
const onRelease = { ...CR, number: 22, branch: 'bo/deal', base: RELEASE } as unknown as PullRequestSummary;
|
|
221
|
+
api.readFileAtForkPoint.mockResolvedValue({ content: null, forkSha: null });
|
|
222
|
+
api.readFileOnBranch.mockImplementation(async (branch: string) =>
|
|
223
|
+
branch === RELEASE
|
|
224
|
+
? 'price: 90\nstatus: draft\n'
|
|
225
|
+
: branch === DEFAULT_BRANCH
|
|
226
|
+
? MAIN_NOW
|
|
227
|
+
: PROPOSED,
|
|
228
|
+
);
|
|
229
|
+
const { result } = renderHook(() => useCrFileDiffs([CR, onRelease], PATH));
|
|
230
|
+
await waitFor(() => expect(result.current.get(21)).not.toBeNull());
|
|
231
|
+
await waitFor(() => expect(result.current.get(22)).not.toBeNull());
|
|
232
|
+
|
|
233
|
+
// Each box against ITS own target: main's 'status: signed' for one, the
|
|
234
|
+
// release's 'price: 90' for the other.
|
|
235
|
+
expect(lines(result.current.get(21), 'removed')).toEqual(['price: 100', 'status: signed']);
|
|
236
|
+
expect(lines(result.current.get(22), 'removed')).toEqual(['price: 90']);
|
|
237
|
+
});
|
|
238
|
+
});
|
|
@@ -6,7 +6,7 @@ vi.mock('../services/change-requests.api', () => ({
|
|
|
6
6
|
readFileOnBranch: api.readFileOnBranch,
|
|
7
7
|
}));
|
|
8
8
|
|
|
9
|
-
import { useFileOnBranch } from '../hooks/useFileOnBranch';
|
|
9
|
+
import { useFileOnBranch, useFileOnBranchRead } from '../hooks/useFileOnBranch';
|
|
10
10
|
|
|
11
11
|
beforeEach(() => {
|
|
12
12
|
api.readFileOnBranch
|
|
@@ -70,3 +70,58 @@ describe('useFileOnBranch', () => {
|
|
|
70
70
|
expect(result.current).toBeNull();
|
|
71
71
|
});
|
|
72
72
|
});
|
|
73
|
+
|
|
74
|
+
/** What a rejected read settles as: failed, with the reason it gave. */
|
|
75
|
+
const FAILED_404 = {
|
|
76
|
+
content: null,
|
|
77
|
+
failed: true,
|
|
78
|
+
failure: { kind: 'error', reason: '404' },
|
|
79
|
+
};
|
|
80
|
+
|
|
81
|
+
/**
|
|
82
|
+
* A caller that cannot tell "failed" from "in flight" can only render
|
|
83
|
+
* "Loading…" for both — which is what left the change-request pane hanging on
|
|
84
|
+
* a file the default branch does not have.
|
|
85
|
+
*/
|
|
86
|
+
describe('useFileOnBranchRead', () => {
|
|
87
|
+
it('reports a settled failure as a failure, not as a wait', async () => {
|
|
88
|
+
api.readFileOnBranch.mockRejectedValue(new Error('404'));
|
|
89
|
+
const { result } = renderHook(() => useFileOnBranchRead('main', 'Ops/gone.yaml'));
|
|
90
|
+
expect(result.current).toEqual({ content: null, failed: false });
|
|
91
|
+
// A settled failure carries WHY, so the caller can say whether the read
|
|
92
|
+
// was refused or merely broke. A bare Error is the second.
|
|
93
|
+
await waitFor(() => expect(result.current).toEqual(FAILED_404));
|
|
94
|
+
// Settled means settled: the failure is cached, not retried on every render.
|
|
95
|
+
expect(api.readFileOnBranch).toHaveBeenCalledTimes(1);
|
|
96
|
+
});
|
|
97
|
+
|
|
98
|
+
it('a landed read is not a failure, and an unasked one is neither', async () => {
|
|
99
|
+
const { result, rerender } = renderHook(({ path }) => useFileOnBranchRead('main', path), {
|
|
100
|
+
initialProps: { path: null as string | null },
|
|
101
|
+
});
|
|
102
|
+
expect(result.current).toEqual({ content: null, failed: false });
|
|
103
|
+
|
|
104
|
+
rerender({ path: 'skill/SKILL.md' });
|
|
105
|
+
await waitFor(() =>
|
|
106
|
+
expect(result.current).toEqual({ content: 'content of skill/SKILL.md', failed: false }),
|
|
107
|
+
);
|
|
108
|
+
});
|
|
109
|
+
|
|
110
|
+
it('keys the failure to its own path — a sibling read is unaffected', async () => {
|
|
111
|
+
api.readFileOnBranch.mockImplementation(async (_branch: string, path: string) => {
|
|
112
|
+
if (path === 'Ops/gone.yaml') throw new Error('404');
|
|
113
|
+
return `content of ${path}`;
|
|
114
|
+
});
|
|
115
|
+
const { result, rerender } = renderHook(({ path }) => useFileOnBranchRead('main', path), {
|
|
116
|
+
initialProps: { path: 'Ops/gone.yaml' },
|
|
117
|
+
});
|
|
118
|
+
await waitFor(() => expect(result.current.failed).toBe(true));
|
|
119
|
+
|
|
120
|
+
rerender({ path: 'Ops/here.yaml' });
|
|
121
|
+
await waitFor(() => expect(result.current.content).toBe('content of Ops/here.yaml'));
|
|
122
|
+
expect(result.current.failed).toBe(false);
|
|
123
|
+
|
|
124
|
+
rerender({ path: 'Ops/gone.yaml' });
|
|
125
|
+
expect(result.current).toEqual(FAILED_404);
|
|
126
|
+
});
|
|
127
|
+
});
|
|
@@ -0,0 +1,79 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { renderHook, waitFor } from '@testing-library/react';
|
|
3
|
+
|
|
4
|
+
const api = vi.hoisted(() => ({ readFileAtForkPoint: vi.fn() }));
|
|
5
|
+
vi.mock('../services/change-requests.api', () => ({
|
|
6
|
+
readFileAtForkPoint: api.readFileAtForkPoint,
|
|
7
|
+
}));
|
|
8
|
+
|
|
9
|
+
/**
|
|
10
|
+
* The folder named by a denial is a fact about ONE branch's tree: the target
|
|
11
|
+
* the fork point belongs to is the tree the route checks read authority
|
|
12
|
+
* against. So the branch is part of what identifies a read, not merely part
|
|
13
|
+
* of what the effect watches — a key without it makes the hook's own
|
|
14
|
+
* already-asked guard serve the previous branch's answer, and the dialog goes
|
|
15
|
+
* on telling the reader to ask an owner of a folder that governs a different
|
|
16
|
+
* tree.
|
|
17
|
+
*/
|
|
18
|
+
const denial = vi.hoisted(() => ({ describeReadFailure: vi.fn() }));
|
|
19
|
+
vi.mock('../services/denied-file.api', () => ({
|
|
20
|
+
describeReadFailure: denial.describeReadFailure,
|
|
21
|
+
}));
|
|
22
|
+
|
|
23
|
+
import { useForkPointFileRead } from '../hooks/useForkPointFile';
|
|
24
|
+
|
|
25
|
+
const PATH = 'Knowledge/Finance/Payroll/bands.yaml';
|
|
26
|
+
|
|
27
|
+
beforeEach(() => {
|
|
28
|
+
api.readFileAtForkPoint.mockReset();
|
|
29
|
+
denial.describeReadFailure
|
|
30
|
+
.mockReset()
|
|
31
|
+
.mockImplementation(async (_err: unknown, branch: string) => ({
|
|
32
|
+
kind: 'denied',
|
|
33
|
+
folder: `${branch}-folder`,
|
|
34
|
+
}));
|
|
35
|
+
});
|
|
36
|
+
|
|
37
|
+
describe('useForkPointFileRead: the branch a read is described against', () => {
|
|
38
|
+
it('re-reads when the target branch moves under the same file and fork point', async () => {
|
|
39
|
+
api.readFileAtForkPoint.mockRejectedValue(Object.assign(new Error('nope'), { status: 403 }));
|
|
40
|
+
|
|
41
|
+
const { result, rerender } = renderHook(
|
|
42
|
+
({ branch }) => useForkPointFileRead(31, 'sha1', PATH, { targetBranch: branch }),
|
|
43
|
+
{ initialProps: { branch: 'main' } },
|
|
44
|
+
);
|
|
45
|
+
|
|
46
|
+
await waitFor(() =>
|
|
47
|
+
expect(result.current).toEqual({
|
|
48
|
+
content: null,
|
|
49
|
+
failed: true,
|
|
50
|
+
failure: { kind: 'denied', folder: 'main-folder' },
|
|
51
|
+
}),
|
|
52
|
+
);
|
|
53
|
+
|
|
54
|
+
rerender({ branch: 'release' });
|
|
55
|
+
|
|
56
|
+
await waitFor(() =>
|
|
57
|
+
expect(result.current).toEqual({
|
|
58
|
+
content: null,
|
|
59
|
+
failed: true,
|
|
60
|
+
failure: { kind: 'denied', folder: 'release-folder' },
|
|
61
|
+
}),
|
|
62
|
+
);
|
|
63
|
+
expect(api.readFileAtForkPoint).toHaveBeenCalledTimes(2);
|
|
64
|
+
});
|
|
65
|
+
|
|
66
|
+
it('still asks once per branch — a settled read is not re-fetched on every render', async () => {
|
|
67
|
+
api.readFileAtForkPoint.mockResolvedValue({ content: 'bands:\n - L3\n' });
|
|
68
|
+
|
|
69
|
+
const { result, rerender } = renderHook(() =>
|
|
70
|
+
useForkPointFileRead(31, 'sha1', PATH, { targetBranch: 'main' }),
|
|
71
|
+
);
|
|
72
|
+
await waitFor(() => expect(result.current.content).toBe('bands:\n - L3\n'));
|
|
73
|
+
|
|
74
|
+
rerender();
|
|
75
|
+
rerender();
|
|
76
|
+
|
|
77
|
+
expect(api.readFileAtForkPoint).toHaveBeenCalledTimes(1);
|
|
78
|
+
});
|
|
79
|
+
});
|