@bevel-software/platform-core-frontend 0.15.1 → 0.20.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (347) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +20 -9
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/events.test.ts +43 -0
  6. package/src/core/bootstrap.ts +11 -3
  7. package/src/core/events.ts +85 -3
  8. package/src/core/registry.ts +1 -1
  9. package/src/lib/__tests__/email.test.ts +44 -0
  10. package/src/lib/email.ts +37 -1
  11. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  12. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  16. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  20. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
  21. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  22. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  23. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  24. package/src/modules/access/api.ts +140 -6
  25. package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
  26. package/src/modules/access/manage-access-affordance.ts +17 -0
  27. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  28. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  29. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  30. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  31. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  32. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  33. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  34. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  35. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  36. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  37. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  38. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  39. package/src/modules/admin/components/group-members-path.ts +32 -0
  40. package/src/modules/admin/services/roles.api.ts +12 -1
  41. package/src/modules/audit/__tests__/AuditLogPage.test.tsx +312 -0
  42. package/src/modules/audit/components/AuditEventsPanel.tsx +319 -0
  43. package/src/modules/audit/components/AuditLogPage.tsx +373 -0
  44. package/src/modules/audit/components/principal-grouping.ts +49 -0
  45. package/src/modules/audit/services/audit.api.ts +98 -0
  46. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  47. package/src/modules/auth/components/AccountPage.tsx +73 -54
  48. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  49. package/src/modules/auth/services/account.api.ts +78 -4
  50. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  51. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  52. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  53. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  58. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  59. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  60. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  61. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  62. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  63. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  64. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  65. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  66. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  67. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  68. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  69. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  70. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  71. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  72. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  73. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  74. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  75. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  76. package/src/modules/change-requests/services/propose.api.ts +97 -8
  77. package/src/modules/change-requests/utils/approval.ts +15 -0
  78. package/src/modules/change-requests/utils/author.ts +32 -0
  79. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  80. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  81. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  82. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  83. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  84. package/src/modules/git/services/error-messages.ts +12 -0
  85. package/src/modules/git/services/pr-prompts.ts +5 -5
  86. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  87. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  88. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  89. package/src/modules/layout/components/AppLayout.tsx +2 -0
  90. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  91. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  92. package/src/modules/layout/components/SidebarFrame.tsx +108 -3
  93. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  94. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  95. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  96. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  97. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  98. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
  99. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
  100. package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
  101. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
  102. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  103. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  104. package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
  105. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  106. package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
  107. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
  108. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
  109. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  110. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  111. package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
  112. package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
  113. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  114. package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
  115. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
  116. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  117. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  118. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  119. package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
  120. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  121. package/src/modules/library/__tests__/library-paths.test.ts +47 -4
  122. package/src/modules/library/__tests__/link-membership.test.ts +13 -4
  123. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  124. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  125. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  126. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  127. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  128. package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
  129. package/src/modules/library/__tests__/status.test.ts +82 -2
  130. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  131. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  132. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  133. package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
  134. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  135. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  136. package/src/modules/library/components/LibraryCard.tsx +146 -45
  137. package/src/modules/library/components/LibraryLayout.tsx +119 -256
  138. package/src/modules/library/components/LibraryPage.tsx +172 -39
  139. package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
  140. package/src/modules/library/components/LockedPluginView.tsx +62 -34
  141. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  142. package/src/modules/library/components/NewPluginDialog.tsx +16 -2
  143. package/src/modules/library/components/PageActions.tsx +11 -9
  144. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  145. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  146. package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
  147. package/src/modules/library/components/PluginExtras.tsx +140 -17
  148. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  149. package/src/modules/library/components/PluginPage.tsx +157 -41
  150. package/src/modules/library/components/PluginRows.tsx +286 -0
  151. package/src/modules/library/components/PluginsSidebar.tsx +239 -263
  152. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  153. package/src/modules/library/components/ShareButton.tsx +17 -0
  154. package/src/modules/library/components/SkillsTree.tsx +141 -28
  155. package/src/modules/library/components/TeamRoute.tsx +15 -0
  156. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  157. package/src/modules/library/components/plugin-page-parts.tsx +103 -17
  158. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
  159. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  160. package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
  161. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  162. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  163. package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
  164. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  165. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  166. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  167. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  168. package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
  169. package/src/modules/library/routes/library-paths.ts +26 -28
  170. package/src/modules/library/services/library.api.ts +38 -20
  171. package/src/modules/library/services/plugins.api.ts +69 -8
  172. package/src/modules/library/services/teams.api.ts +15 -0
  173. package/src/modules/library/services/tools.api.ts +78 -0
  174. package/src/modules/library/state/library-data.tsx +170 -32
  175. package/src/modules/library/utils/personal-plugin.ts +13 -15
  176. package/src/modules/library/utils/plugin-entries.ts +134 -0
  177. package/src/modules/library/utils/plugin-summary.ts +75 -9
  178. package/src/modules/library/utils/status.ts +135 -33
  179. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
  180. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  181. package/src/modules/onboarding/agent-clients.ts +55 -23
  182. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  183. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  184. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  185. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  186. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  187. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  188. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  189. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  190. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  191. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  192. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  193. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  194. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  195. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  196. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  197. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  198. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  199. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  200. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  201. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  202. package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
  203. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  204. package/src/modules/settings/components/DeploymentPage.tsx +10 -30
  205. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  206. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
  207. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  208. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +7 -6
  209. package/src/modules/settings/services/github-facade.api.ts +23 -0
  210. package/src/modules/settings/settings-nav-items.tsx +13 -3
  211. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  212. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  213. package/src/modules/setup/__tests__/setup.test.tsx +497 -4
  214. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  215. package/src/modules/setup/components/SetupGate.tsx +16 -16
  216. package/src/modules/setup/components/SetupScreen.tsx +532 -43
  217. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  218. package/src/modules/setup/services/setup.api.ts +141 -4
  219. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  220. package/src/modules/setup/utils/root-folders.ts +46 -0
  221. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  222. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  223. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  224. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  225. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  226. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  227. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  228. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  229. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  230. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  231. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  232. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  233. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  234. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  235. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  236. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  237. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
  238. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  239. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  240. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  241. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
  242. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  243. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  244. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  245. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  246. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  247. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  248. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  249. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  250. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  251. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  252. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  253. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  254. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  255. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  256. package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
  257. package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
  258. package/src/modules/workspace/components/FileRoute.tsx +353 -36
  259. package/src/modules/workspace/components/FileViewer.tsx +172 -46
  260. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  261. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  262. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  263. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2533 -129
  264. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
  265. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +381 -12
  266. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  267. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  268. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  269. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  270. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  271. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  272. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  273. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  274. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  275. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  276. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  277. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  278. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  279. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  280. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  281. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  282. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  283. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  284. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  285. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  286. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  287. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  288. package/src/modules/workspace/components/renderers/index.ts +53 -2
  289. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  290. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  291. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  292. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  293. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  294. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  295. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  296. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
  297. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  298. package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
  299. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  300. package/src/modules/workspace/routing/kb-routes.ts +206 -29
  301. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +134 -1
  302. package/src/modules/workspace/services/workspace.api.ts +57 -4
  303. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  304. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  305. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  306. package/src/modules/workspace/state/workspace.context.ts +125 -19
  307. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  308. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
  309. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  310. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  311. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  312. package/src/modules/workspace/utils/file-trace.ts +50 -0
  313. package/src/modules/workspace/utils/fileTree.ts +112 -36
  314. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  315. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  316. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  317. package/src/modules/workspace/utils/uploadError.ts +29 -0
  318. package/src/shared/__tests__/marketplace-url.test.ts +6 -1
  319. package/src/shared/components/Button.tsx +16 -2
  320. package/src/shared/components/Dialog.tsx +27 -11
  321. package/src/shared/components/Menu.tsx +13 -1
  322. package/src/shared/components/PageShell.tsx +13 -8
  323. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  324. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  325. package/src/shared/components/index.ts +2 -0
  326. package/src/shared/components/useDismissableMenu.ts +32 -10
  327. package/src/shared/components/useFocusHandoff.ts +51 -0
  328. package/src/shared/components/useLatestRef.ts +28 -0
  329. package/src/shared/markdown/Markdown.tsx +12 -3
  330. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  331. package/src/shared/markdown/hrefs.ts +50 -0
  332. package/src/shared/marketplace-url.ts +33 -5
  333. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  334. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  335. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  336. package/src/shared/mcp/connect-snippets.ts +14 -9
  337. package/src/shared/mcp/index.ts +1 -1
  338. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  339. package/src/shared/theme/header.ts +75 -0
  340. package/src/shared/theme/measure.ts +7 -4
  341. package/src/shared/theme/tokens.css +25 -0
  342. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  343. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  344. package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
  345. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  346. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  347. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -0,0 +1,271 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, waitFor, within } from '@testing-library/react';
3
+ import userEvent from '@testing-library/user-event';
4
+ import type { PullRequestSummary } from '@bevel-software/platform-shared';
5
+
6
+ /**
7
+ * A file in a change request the viewer may not read.
8
+ *
9
+ * The dialog used to keep one `unreadable` flag per file and render one
10
+ * sentence for every failure — "…couldn't be read, so there is no honest
11
+ * before and after to show." A tester who was simply not allowed to see the
12
+ * file read that as an outage and asked what had broken. Nothing had: the
13
+ * answer was that the file was not theirs.
14
+ *
15
+ * So there are two forms now. A refusal names the access decision and the
16
+ * folder to ask an owner of; anything else names the reason and offers a
17
+ * retry. Both drop the word "honest", and the list carries a lock beside a
18
+ * file the viewer was refused.
19
+ */
20
+
21
+ const detailMock = vi.hoisted(() => ({ fetchPrDetail: vi.fn() }));
22
+ vi.mock('../../pr/services/pr-detail.api', () => ({ fetchPrDetail: detailMock.fetchPrDetail }));
23
+
24
+ const readMock = vi.hoisted(() => ({ readFileOnBranch: vi.fn() }));
25
+ vi.mock('../services/change-requests.api', () => ({
26
+ readFileOnBranch: readMock.readFileOnBranch,
27
+ }));
28
+ vi.mock('../../pr/services/pr-approvals.api', () => ({
29
+ approvePrFile: vi.fn(),
30
+ revertPrFile: vi.fn(),
31
+ unapprovePrFile: vi.fn(),
32
+ }));
33
+ vi.mock('../../pr/services/pr-merge.api', () => ({ mergePullRequest: vi.fn() }));
34
+ vi.mock('../../pr/services/pr-cancel.api', () => ({
35
+ cancelPullRequest: vi.fn(),
36
+ deleteChangeRequest: vi.fn(),
37
+ }));
38
+
39
+ /**
40
+ * The two calls that NAME the folder are stubbed, the classifier that uses
41
+ * them is not: the point of these tests is that a 403 travels from the read
42
+ * all the way to the sentence, folder and all.
43
+ */
44
+ const wsMock = vi.hoisted(() => ({ getOrCreateWorkspace: vi.fn() }));
45
+ vi.mock('../../workspace/services/workspace.api', async (importOriginal) => ({
46
+ ...(await importOriginal<typeof import('../../workspace/services/workspace.api')>()),
47
+ getOrCreateWorkspace: wsMock.getOrCreateWorkspace,
48
+ }));
49
+ const accessMock = vi.hoisted(() => ({ fetchFileAccess: vi.fn() }));
50
+ vi.mock('../../access/api', async (importOriginal) => ({
51
+ ...(await importOriginal<typeof import('../../access/api')>()),
52
+ fetchFileAccess: accessMock.fetchFileAccess,
53
+ }));
54
+
55
+ import { ChangeRequestDialog } from '../components/ChangeRequestDialog';
56
+ import { WorkspaceApiError } from '../../workspace/services/workspace.api';
57
+
58
+ /** What `test-setup.ts` pins the default branch to. */
59
+ const MAIN = 'target-company-state';
60
+ const CR_BRANCH = 'ali.raza/payroll-bands';
61
+ const PATH = 'Knowledge/Finance/Payroll/bands.yaml';
62
+
63
+ const DENIED_HERE =
64
+ "You don't have access to read this file, so its content can't be shown here. " +
65
+ 'Ask an owner of Knowledge/Finance/Payroll for read access if you need to review it.';
66
+ const DENIED_UNNAMED =
67
+ "You don't have access to read this file, so its content can't be shown here. " +
68
+ 'Ask an owner of this file for read access if you need to review it.';
69
+
70
+ const CR: PullRequestSummary = {
71
+ number: 31,
72
+ title: 'Refresh the payroll bands',
73
+ authorId: 'abc',
74
+ author: { login: 'user-abc', name: 'Ali' },
75
+ appAuthor: { name: 'Ali' },
76
+ branch: CR_BRANCH,
77
+ base: 'main',
78
+ state: 'open',
79
+ createdAt: '2026-09-17T00:00:00.000Z',
80
+ touchedNodePaths: [],
81
+ review: { approvals: 0, changesRequested: 0, pendingLogins: [] },
82
+ url: '/change-requests/31',
83
+ } as unknown as PullRequestSummary;
84
+
85
+ const detail = {
86
+ ...CR,
87
+ body: '',
88
+ headSha: 'h',
89
+ baseSha: 'b',
90
+ files: [
91
+ {
92
+ path: PATH,
93
+ status: 'modified' as const,
94
+ additions: 1,
95
+ deletions: 1,
96
+ isBinary: false,
97
+ sha: '',
98
+ rawUrl: '',
99
+ },
100
+ ],
101
+ comments: [],
102
+ approvals: [],
103
+ mergeableInBevel: true,
104
+ mergeBlockedReasons: [],
105
+ mergeWarnings: [],
106
+ viewerCanBypassMerge: false,
107
+ viewerCanCancel: false,
108
+ };
109
+
110
+ /** The read answers per branch: a string resolves, an error rejects. */
111
+ function reads(answers: Record<string, string | Error>) {
112
+ readMock.readFileOnBranch.mockImplementation(async (branch: string) => {
113
+ const answer = answers[branch];
114
+ if (answer === undefined) throw new WorkspaceApiError(404);
115
+ if (answer instanceof Error) throw answer;
116
+ return answer;
117
+ });
118
+ }
119
+
120
+ /** The resolved access view, as far as the folder-naming cares about it. */
121
+ function governedBy(accessMdPath: string) {
122
+ accessMock.fetchFileAccess.mockResolvedValue({
123
+ sources: { 'r:admin': { owner: [{ kind: 'ancestor', path: accessMdPath }] } },
124
+ });
125
+ }
126
+
127
+ beforeEach(() => {
128
+ detailMock.fetchPrDetail.mockReset();
129
+ readMock.readFileOnBranch.mockReset();
130
+ accessMock.fetchFileAccess.mockReset();
131
+ wsMock.getOrCreateWorkspace.mockReset();
132
+ wsMock.getOrCreateWorkspace.mockResolvedValue({
133
+ workspace: { id: 'ws-1', kbDirName: 'knowledge-base' },
134
+ fileTree: null,
135
+ });
136
+ detailMock.fetchPrDetail.mockResolvedValue(detail);
137
+ });
138
+
139
+ describe("ChangeRequestDialog: a file the viewer may not read", () => {
140
+ it('says it is an access decision, and names the folder to ask an owner of', async () => {
141
+ reads({ [CR_BRANCH]: new WorkspaceApiError(403), [MAIN]: 'bands:\n - L3\n' });
142
+ governedBy('Knowledge/Finance/Payroll/access.md');
143
+
144
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
145
+
146
+ expect(await screen.findByText(DENIED_HERE)).toBeInTheDocument();
147
+ // The old sentence, and the word the ticket was filed about, are gone.
148
+ expect(screen.queryByText(/no honest before and after/)).not.toBeInTheDocument();
149
+ expect(document.body.textContent).not.toMatch(/honest/);
150
+ // Nothing to retry: another read gets the same refusal.
151
+ expect(screen.queryByRole('button', { name: 'Try again' })).not.toBeInTheDocument();
152
+ // The folder was resolved against the change request's own branch.
153
+ expect(wsMock.getOrCreateWorkspace).toHaveBeenCalledWith(CR_BRANCH);
154
+ expect(accessMock.fetchFileAccess).toHaveBeenCalledWith('ws-1', PATH);
155
+ });
156
+
157
+ it('carries a lock on the file row, with the same sentence as its tooltip', async () => {
158
+ reads({ [CR_BRANCH]: new WorkspaceApiError(403), [MAIN]: 'bands:\n - L3\n' });
159
+ governedBy('Knowledge/Finance/Payroll/access.md');
160
+
161
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
162
+ await screen.findByText(DENIED_HERE);
163
+
164
+ const tree = screen.getByRole('tree', { name: 'Files in this change request' });
165
+ const lock = within(tree).getByRole('img', { name: DENIED_HERE });
166
+ expect(lock).toHaveAttribute('title', DENIED_HERE);
167
+ });
168
+
169
+ it('falls back to "this file" when no folder can be named', async () => {
170
+ reads({ [CR_BRANCH]: new WorkspaceApiError(403), [MAIN]: 'bands:\n - L3\n' });
171
+ // The rule lives in the file's own frontmatter — there is no folder whose
172
+ // owners to point at, and the platform does not invent one.
173
+ accessMock.fetchFileAccess.mockResolvedValue({
174
+ sources: { 'u:ali@example.com': { read: [{ kind: 'direct' }] } },
175
+ });
176
+
177
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
178
+
179
+ expect(await screen.findByText(DENIED_UNNAMED)).toBeInTheDocument();
180
+ });
181
+
182
+ it('still says it plainly when the folder lookup itself fails', async () => {
183
+ reads({ [CR_BRANCH]: new WorkspaceApiError(403), [MAIN]: 'bands:\n - L3\n' });
184
+ accessMock.fetchFileAccess.mockRejectedValue(new WorkspaceApiError(503));
185
+
186
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
187
+
188
+ expect(await screen.findByText(DENIED_UNNAMED)).toBeInTheDocument();
189
+ });
190
+
191
+ it('gives the CURRENT text the same two forms — a refused base copy reads the same', async () => {
192
+ reads({ [CR_BRANCH]: 'bands:\n - L3\n', [MAIN]: new WorkspaceApiError(403) });
193
+ governedBy('Knowledge/Finance/Payroll/access.md');
194
+
195
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
196
+
197
+ expect(await screen.findByText(DENIED_HERE)).toBeInTheDocument();
198
+ expect(document.body.textContent).not.toMatch(/honest/);
199
+ expect(wsMock.getOrCreateWorkspace).toHaveBeenCalledWith(MAIN);
200
+ });
201
+
202
+ /**
203
+ * The row and the pane answer the same question, so they cannot disagree
204
+ * about it. A refusal of the CURRENT copy is as much a refusal of the file
205
+ * as a refusal of the proposed one — a reader who meets the sentence in the
206
+ * pane and no lock in the list is being told two different things.
207
+ */
208
+ it("locks the row on a refused base copy too, with the pane's own sentence", async () => {
209
+ reads({ [CR_BRANCH]: 'bands:\n - L3\n', [MAIN]: new WorkspaceApiError(403) });
210
+ governedBy('Knowledge/Finance/Payroll/access.md');
211
+
212
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
213
+ await screen.findByText(DENIED_HERE);
214
+
215
+ const tree = screen.getByRole('tree', { name: 'Files in this change request' });
216
+ const lock = within(tree).getByRole('img', { name: DENIED_HERE });
217
+ expect(lock).toHaveAttribute('title', DENIED_HERE);
218
+ });
219
+
220
+ /** A base copy that merely broke is still not a refusal: reason, retry, no lock. */
221
+ it('leaves the row unlocked when the base copy merely broke', async () => {
222
+ reads({ [CR_BRANCH]: 'bands:\n - L3\n', [MAIN]: new WorkspaceApiError(500) });
223
+
224
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
225
+
226
+ const note = await screen.findByText(/couldn't be read right now/);
227
+ expect(note).toHaveTextContent("This file couldn't be read right now (HTTP 500). Try again.");
228
+ const tree = screen.getByRole('tree', { name: 'Files in this change request' });
229
+ expect(within(tree).queryByRole('img', { name: /don't have access/ })).not.toBeInTheDocument();
230
+ });
231
+ });
232
+
233
+ describe('ChangeRequestDialog: a read that merely broke', () => {
234
+ it("names the reason and offers a retry — not an access sentence", async () => {
235
+ reads({ [CR_BRANCH]: new WorkspaceApiError(500), [MAIN]: 'bands:\n - L3\n' });
236
+
237
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
238
+
239
+ const note = await screen.findByText(/couldn't be read right now/);
240
+ expect(note).toHaveTextContent("This file couldn't be read right now (HTTP 500). Try again.");
241
+ expect(note.textContent).not.toMatch(/honest/);
242
+ expect(screen.queryByText(/don't have access/)).not.toBeInTheDocument();
243
+ // A broken read is not a refusal, so the row carries no lock.
244
+ const tree = screen.getByRole('tree', { name: 'Files in this change request' });
245
+ expect(within(tree).queryByRole('img', { name: /don't have access/ })).not.toBeInTheDocument();
246
+ // Nothing to ask an owner about, so nothing was looked up.
247
+ expect(accessMock.fetchFileAccess).not.toHaveBeenCalled();
248
+ });
249
+
250
+ it('re-fetches that file when the retry is taken, and shows it once it lands', async () => {
251
+ let branchAttempts = 0;
252
+ readMock.readFileOnBranch.mockImplementation(async (branch: string) => {
253
+ if (branch !== CR_BRANCH) return 'bands:\n - L3\n';
254
+ branchAttempts += 1;
255
+ if (branchAttempts === 1) throw new WorkspaceApiError(500);
256
+ return 'bands:\n - L4\n';
257
+ });
258
+
259
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
260
+ await screen.findByText(/couldn't be read right now/);
261
+
262
+ await userEvent.click(screen.getByRole('button', { name: 'Try again' }));
263
+
264
+ await waitFor(() => expect(branchAttempts).toBe(2));
265
+ // The second read landed, so the pane shows the change instead of the note.
266
+ await waitFor(() =>
267
+ expect([...document.querySelectorAll('ins')].map((n) => n.textContent)).toEqual([' - L4']),
268
+ );
269
+ expect(screen.queryByText(/couldn't be read right now/)).not.toBeInTheDocument();
270
+ });
271
+ });
@@ -0,0 +1,208 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, fireEvent, waitFor, act } from '@testing-library/react';
3
+ import type { PullRequestSummary, WorkflowEvent } from '@bevel-software/platform-shared';
4
+ import { EventBusContext, type EventBusContextValue } from '../../workflow/state/event-bus.context';
5
+ import {
6
+ OpenChangeRequestsContext,
7
+ NO_CHANGE_REQUESTS,
8
+ } from '../../workspace/state/open-change-requests.context';
9
+
10
+ /**
11
+ * The file page's proposal boxes. Approval rights come from the FILE, not from
12
+ * authorship: an eligible approver who wrote a proposal decides it like any
13
+ * other, and keeps Withdraw beside the verdicts.
14
+ */
15
+
16
+ const api = vi.hoisted(() => ({
17
+ readFileOnBranch: vi.fn(),
18
+ readFileAtForkPoint: vi.fn(),
19
+ fetchPrDetail: vi.fn(),
20
+ approvePrFile: vi.fn(),
21
+ mergePullRequest: vi.fn(),
22
+ cancelPullRequest: vi.fn(),
23
+ }));
24
+ vi.mock('../services/change-requests.api', () => ({
25
+ readFileOnBranch: api.readFileOnBranch,
26
+ readFileAtForkPoint: api.readFileAtForkPoint,
27
+ }));
28
+ vi.mock('../../pr/services/pr-detail.api', () => ({ fetchPrDetail: api.fetchPrDetail }));
29
+ vi.mock('../../pr/services/pr-approvals.api', () => ({ approvePrFile: api.approvePrFile }));
30
+ vi.mock('../../pr/services/pr-merge.api', () => ({ mergePullRequest: api.mergePullRequest }));
31
+ vi.mock('../../pr/services/pr-cancel.api', () => ({ cancelPullRequest: api.cancelPullRequest }));
32
+
33
+ import { FileChangeBoxes } from '../components/FileChangeBoxes';
34
+ import { othersPendingBesides, waitingOnViewerLabel } from '../utils/author';
35
+
36
+ const PATH = 'Docs/guide.md';
37
+
38
+ const CR: PullRequestSummary = {
39
+ number: 31,
40
+ title: 'Tighten the guide',
41
+ author: { login: 'user-abc', name: 'Bevel Bot' },
42
+ appAuthor: { name: 'Olga' },
43
+ branch: 'olga/guide',
44
+ base: 'main',
45
+ state: 'open',
46
+ createdAt: '2026-09-01T00:00:00.000Z',
47
+ touchedNodePaths: [PATH],
48
+ review: { approvals: 0, changesRequested: 0, pendingLogins: [] },
49
+ url: '/change-requests/31',
50
+ } as unknown as PullRequestSummary;
51
+
52
+ function makeFakeBus() {
53
+ const handlers: Record<string, ((e: WorkflowEvent) => void)[]> = {};
54
+ const bus: EventBusContextValue & { emit(e: WorkflowEvent): void } = {
55
+ subscribe(kind, handler) {
56
+ (handlers[kind] ??= []).push(handler as (e: WorkflowEvent) => void);
57
+ return () => {
58
+ handlers[kind] = (handlers[kind] ?? []).filter((h) => h !== handler);
59
+ };
60
+ },
61
+ setFocus() {},
62
+ watchWorkspace() {
63
+ return () => {};
64
+ },
65
+ emit(e) {
66
+ (handlers[e.kind] ?? []).forEach((h) => h(e));
67
+ },
68
+ };
69
+ return bus;
70
+ }
71
+
72
+ function renderBoxes(opts: { mine: boolean; canDecide: boolean; othersPending?: number }) {
73
+ const bus = makeFakeBus();
74
+ render(
75
+ <EventBusContext.Provider value={bus}>
76
+ <OpenChangeRequestsContext.Provider
77
+ value={{ ...NO_CHANGE_REQUESTS, mineNumbers: new Set(opts.mine ? [CR.number] : []) }}
78
+ >
79
+ <FileChangeBoxes
80
+ repoRelativePath={PATH}
81
+ requests={[CR]}
82
+ canDecide={opts.canDecide}
83
+ ownersLabel="Docs"
84
+ othersPending={opts.othersPending}
85
+ onApplied={() => {}}
86
+ />
87
+ </OpenChangeRequestsContext.Provider>
88
+ </EventBusContext.Provider>,
89
+ );
90
+ return bus;
91
+ }
92
+
93
+ beforeEach(() => {
94
+ vi.clearAllMocks();
95
+ api.readFileOnBranch.mockImplementation(async (branch: string) =>
96
+ branch === CR.branch ? 'new line\n' : 'old line\n',
97
+ );
98
+ // The box's "before" side is the request's fork point, not main's tip.
99
+ api.readFileAtForkPoint.mockResolvedValue({ content: 'old line\n', forkSha: 'f'.repeat(40) });
100
+ api.fetchPrDetail.mockResolvedValue({
101
+ ...CR,
102
+ state: 'open',
103
+ approvals: [
104
+ {
105
+ path: PATH,
106
+ eligibleApprovers: { roles: ['Docs'], users: [] },
107
+ approvedBy: [],
108
+ isApproved: false,
109
+ // An owned markdown file: the merge gate binds it, so Apply approves it.
110
+ inMergeGate: true,
111
+ viewerCanApprove: true,
112
+ },
113
+ ],
114
+ });
115
+ api.approvePrFile.mockResolvedValue([]);
116
+ api.mergePullRequest.mockResolvedValue(undefined);
117
+ api.cancelPullRequest.mockResolvedValue(undefined);
118
+ });
119
+
120
+ describe('FileChangeBoxes: who may decide', () => {
121
+ it('offers an approver who wrote the proposal Approve, Decline and Withdraw', async () => {
122
+ renderBoxes({ mine: true, canDecide: true, othersPending: 0 });
123
+
124
+ expect(await screen.findByRole('button', { name: 'Approve' })).toBeInTheDocument();
125
+ expect(screen.getByRole('button', { name: 'Decline' })).toBeInTheDocument();
126
+ expect(screen.getByRole('button', { name: 'Withdraw' })).toBeInTheDocument();
127
+ expect(screen.getByText('You')).toBeInTheDocument();
128
+ });
129
+
130
+ it('offers an author without approval rights only Withdraw', async () => {
131
+ renderBoxes({ mine: true, canDecide: false, othersPending: 0 });
132
+
133
+ expect(await screen.findByRole('button', { name: 'Withdraw' })).toBeInTheDocument();
134
+ expect(screen.queryByRole('button', { name: 'Approve' })).not.toBeInTheDocument();
135
+ expect(screen.queryByRole('button', { name: 'Decline' })).not.toBeInTheDocument();
136
+ expect(screen.getByText('Waiting on Docs')).toBeInTheDocument();
137
+ });
138
+
139
+ it('offers an approver who did not write it the verdicts but not Withdraw', async () => {
140
+ renderBoxes({ mine: false, canDecide: true, othersPending: 0 });
141
+
142
+ expect(await screen.findByRole('button', { name: 'Approve' })).toBeInTheDocument();
143
+ expect(screen.getByRole('button', { name: 'Decline' })).toBeInTheDocument();
144
+ expect(screen.queryByRole('button', { name: 'Withdraw' })).not.toBeInTheDocument();
145
+ });
146
+
147
+ it('applies an author-approver’s own proposal like the dialog’s Apply, with the same banner', async () => {
148
+ const bus = renderBoxes({ mine: true, canDecide: true, othersPending: 0 });
149
+
150
+ fireEvent.click(await screen.findByRole('button', { name: 'Approve' }));
151
+
152
+ await waitFor(() => expect(api.approvePrFile).toHaveBeenCalledWith(CR.number, PATH));
153
+ await waitFor(() => expect(api.mergePullRequest).toHaveBeenCalledWith(CR.number));
154
+ expect(api.fetchPrDetail).toHaveBeenCalledWith(CR.number, { fresh: true });
155
+
156
+ act(() => {
157
+ bus.emit({ kind: 'change-request-merged', number: CR.number } as unknown as WorkflowEvent);
158
+ });
159
+ expect(
160
+ await screen.findByText('Applied: the file now reads with that change.'),
161
+ ).toBeInTheDocument();
162
+ });
163
+ });
164
+
165
+ describe('FileChangeBoxes: the waiting label', () => {
166
+ it('reads "Waiting on you" when the viewer is the only pending approver', async () => {
167
+ renderBoxes({ mine: true, canDecide: true, othersPending: 0 });
168
+ expect(await screen.findByText('Waiting on you')).toBeInTheDocument();
169
+ });
170
+
171
+ it('reads "Waiting on you and N others" when more are pending', async () => {
172
+ renderBoxes({ mine: false, canDecide: true, othersPending: 2 });
173
+ expect(await screen.findByText('Waiting on you and 2 others')).toBeInTheDocument();
174
+ });
175
+ });
176
+
177
+ describe('waiting-label helpers', () => {
178
+ it('pluralises the others', () => {
179
+ expect(waitingOnViewerLabel(0)).toBe('Waiting on you');
180
+ expect(waitingOnViewerLabel(1)).toBe('Waiting on you and 1 other');
181
+ expect(waitingOnViewerLabel(3)).toBe('Waiting on you and 3 others');
182
+ });
183
+
184
+ it('counts every approver except the viewer’s own grant', () => {
185
+ const approvers = {
186
+ roles: ['Docs'],
187
+ users: [
188
+ { name: 'Me', email: 'Me@Example.com' },
189
+ { name: 'Ali', email: 'ali@example.com' },
190
+ ],
191
+ };
192
+ expect(othersPendingBesides(approvers, 'me@example.com')).toBe(2);
193
+ expect(othersPendingBesides({ roles: [], users: [approvers.users[0]] }, 'me@example.com')).toBe(0);
194
+ // No user grant of the viewer's own: they decide through the role.
195
+ expect(othersPendingBesides(approvers, null)).toBe(2);
196
+ });
197
+
198
+ it('credits one role to a viewer who decides through a role', () => {
199
+ // The Admin-only file: an Admin viewer is the sole pending grant.
200
+ expect(othersPendingBesides({ roles: ['Admin'], users: [] }, 'admin@example.com')).toBe(0);
201
+ expect(
202
+ othersPendingBesides(
203
+ { roles: ['Admin', 'Docs'], users: [{ email: 'ali@example.com' }] },
204
+ 'admin@example.com',
205
+ ),
206
+ ).toBe(2);
207
+ });
208
+ });