@bevel-software/platform-core-frontend 0.15.1 → 0.20.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/THIRD-PARTY-NOTICES.md +2 -2
- package/package.json +3 -3
- package/src/core/CoreAppShell.tsx +20 -9
- package/src/core/__tests__/AppChrome.test.tsx +0 -3
- package/src/core/__tests__/events.test.ts +43 -0
- package/src/core/bootstrap.ts +11 -3
- package/src/core/events.ts +85 -3
- package/src/core/registry.ts +1 -1
- package/src/lib/__tests__/email.test.ts +44 -0
- package/src/lib/email.ts +37 -1
- package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
- package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
- package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
- package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
- package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
- package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
- package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
- package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
- package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
- package/src/modules/access/api.ts +140 -6
- package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
- package/src/modules/access/manage-access-affordance.ts +17 -0
- package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
- package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
- package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
- package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
- package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
- package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
- package/src/modules/admin/components/AddMemberInput.tsx +268 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
- package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
- package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
- package/src/modules/admin/components/group-members-path.ts +32 -0
- package/src/modules/admin/services/roles.api.ts +12 -1
- package/src/modules/audit/__tests__/AuditLogPage.test.tsx +312 -0
- package/src/modules/audit/components/AuditEventsPanel.tsx +319 -0
- package/src/modules/audit/components/AuditLogPage.tsx +373 -0
- package/src/modules/audit/components/principal-grouping.ts +49 -0
- package/src/modules/audit/services/audit.api.ts +98 -0
- package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
- package/src/modules/auth/components/AccountPage.tsx +73 -54
- package/src/modules/auth/components/LoginScreen.tsx +1 -0
- package/src/modules/auth/services/account.api.ts +78 -4
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
- package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
- package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
- package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
- package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
- package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
- package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
- package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
- package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
- package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
- package/src/modules/change-requests/services/change-requests.api.ts +57 -1
- package/src/modules/change-requests/services/denied-file.api.ts +53 -0
- package/src/modules/change-requests/services/propose.api.ts +97 -8
- package/src/modules/change-requests/utils/approval.ts +15 -0
- package/src/modules/change-requests/utils/author.ts +32 -0
- package/src/modules/change-requests/utils/readFailure.ts +110 -0
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
- package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
- package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
- package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
- package/src/modules/git/services/error-messages.ts +12 -0
- package/src/modules/git/services/pr-prompts.ts +5 -5
- package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
- package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
- package/src/modules/layout/components/AppLayout.tsx +2 -0
- package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
- package/src/modules/layout/components/SidebarFrame.tsx +108 -3
- package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
- package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
- package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
- package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
- package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
- package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
- package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
- package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
- package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
- package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
- package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
- package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
- package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
- package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
- package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
- package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
- package/src/modules/library/__tests__/auth-harness.tsx +9 -9
- package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
- package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
- package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
- package/src/modules/library/__tests__/library-data.test.ts +7 -0
- package/src/modules/library/__tests__/library-paths.test.ts +47 -4
- package/src/modules/library/__tests__/link-membership.test.ts +13 -4
- package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
- package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
- package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
- package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
- package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
- package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
- package/src/modules/library/__tests__/status.test.ts +82 -2
- package/src/modules/library/__tests__/tools.api.test.ts +44 -1
- package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
- package/src/modules/library/components/AddDialogTabs.tsx +103 -0
- package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
- package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
- package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
- package/src/modules/library/components/LibraryCard.tsx +146 -45
- package/src/modules/library/components/LibraryLayout.tsx +119 -256
- package/src/modules/library/components/LibraryPage.tsx +172 -39
- package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
- package/src/modules/library/components/LockedPluginView.tsx +62 -34
- package/src/modules/library/components/NameWithBadges.tsx +164 -0
- package/src/modules/library/components/NewPluginDialog.tsx +16 -2
- package/src/modules/library/components/PageActions.tsx +11 -9
- package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
- package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
- package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
- package/src/modules/library/components/PluginExtras.tsx +140 -17
- package/src/modules/library/components/PluginIndexRow.tsx +47 -12
- package/src/modules/library/components/PluginPage.tsx +157 -41
- package/src/modules/library/components/PluginRows.tsx +286 -0
- package/src/modules/library/components/PluginsSidebar.tsx +239 -263
- package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
- package/src/modules/library/components/ShareButton.tsx +17 -0
- package/src/modules/library/components/SkillsTree.tsx +141 -28
- package/src/modules/library/components/TeamRoute.tsx +15 -0
- package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
- package/src/modules/library/components/plugin-page-parts.tsx +103 -17
- package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
- package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
- package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
- package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
- package/src/modules/library/hooks/useLibraryData.ts +92 -19
- package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
- package/src/modules/library/routes/library-paths.ts +26 -28
- package/src/modules/library/services/library.api.ts +38 -20
- package/src/modules/library/services/plugins.api.ts +69 -8
- package/src/modules/library/services/teams.api.ts +15 -0
- package/src/modules/library/services/tools.api.ts +78 -0
- package/src/modules/library/state/library-data.tsx +170 -32
- package/src/modules/library/utils/personal-plugin.ts +13 -15
- package/src/modules/library/utils/plugin-entries.ts +134 -0
- package/src/modules/library/utils/plugin-summary.ts +75 -9
- package/src/modules/library/utils/status.ts +135 -33
- package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
- package/src/modules/onboarding/agent-clients.ts +55 -23
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
- package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
- package/src/modules/pr/services/pr-merge.api.ts +2 -1
- package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
- package/src/modules/review/components/ReviewPanel.tsx +15 -17
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
- package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
- package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
- package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
- package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
- package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
- package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
- package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
- package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
- package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
- package/src/modules/secrets-vault/services/connect.api.ts +36 -5
- package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
- package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
- package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
- package/src/modules/settings/components/DeploymentPage.tsx +10 -30
- package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
- package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +7 -6
- package/src/modules/settings/services/github-facade.api.ts +23 -0
- package/src/modules/settings/settings-nav-items.tsx +13 -3
- package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
- package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
- package/src/modules/setup/__tests__/setup.test.tsx +497 -4
- package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
- package/src/modules/setup/components/SetupGate.tsx +16 -16
- package/src/modules/setup/components/SetupScreen.tsx +532 -43
- package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
- package/src/modules/setup/services/setup.api.ts +141 -4
- package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
- package/src/modules/setup/utils/root-folders.ts +46 -0
- package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
- package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
- package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
- package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
- package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
- package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
- package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
- package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
- package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
- package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
- package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
- package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
- package/src/modules/toolbar/components/deployment-address.ts +29 -0
- package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
- package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
- package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
- package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
- package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
- package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
- package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
- package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
- package/src/modules/workflow/state/event-bus.context.ts +10 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
- package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
- package/src/modules/workspace/components/FileRoute.tsx +353 -36
- package/src/modules/workspace/components/FileViewer.tsx +172 -46
- package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
- package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
- package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2533 -129
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +381 -12
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
- package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
- package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
- package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
- package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
- package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
- package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
- package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
- package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
- package/src/modules/workspace/components/renderers/index.ts +53 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
- package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
- package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
- package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
- package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
- package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
- package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
- package/src/modules/workspace/routing/kb-routes.ts +206 -29
- package/src/modules/workspace/services/__tests__/workspace.api.test.ts +134 -1
- package/src/modules/workspace/services/workspace.api.ts +57 -4
- package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
- package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
- package/src/modules/workspace/state/open-change-requests.tsx +100 -12
- package/src/modules/workspace/state/workspace.context.ts +125 -19
- package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
- package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
- package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
- package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
- package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
- package/src/modules/workspace/utils/file-trace.ts +50 -0
- package/src/modules/workspace/utils/fileTree.ts +112 -36
- package/src/modules/workspace/utils/frontmatter.ts +8 -4
- package/src/modules/workspace/utils/pasteLink.ts +90 -0
- package/src/modules/workspace/utils/treeConfirm.ts +338 -0
- package/src/modules/workspace/utils/uploadError.ts +29 -0
- package/src/shared/__tests__/marketplace-url.test.ts +6 -1
- package/src/shared/components/Button.tsx +16 -2
- package/src/shared/components/Dialog.tsx +27 -11
- package/src/shared/components/Menu.tsx +13 -1
- package/src/shared/components/PageShell.tsx +13 -8
- package/src/shared/components/__tests__/primitives.test.tsx +116 -2
- package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
- package/src/shared/components/index.ts +2 -0
- package/src/shared/components/useDismissableMenu.ts +32 -10
- package/src/shared/components/useFocusHandoff.ts +51 -0
- package/src/shared/components/useLatestRef.ts +28 -0
- package/src/shared/markdown/Markdown.tsx +12 -3
- package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
- package/src/shared/markdown/hrefs.ts +50 -0
- package/src/shared/marketplace-url.ts +33 -5
- package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
- package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
- package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
- package/src/shared/mcp/connect-snippets.ts +14 -9
- package/src/shared/mcp/index.ts +1 -1
- package/src/shared/theme/__tests__/header-band.test.ts +197 -0
- package/src/shared/theme/header.ts +75 -0
- package/src/shared/theme/measure.ts +7 -4
- package/src/shared/theme/tokens.css +25 -0
- package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
- package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
- package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
- package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
- package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
- package/src/modules/update-check/services/update-check.api.ts +0 -24
|
@@ -37,6 +37,7 @@ vi.mock('../services/library.api', async (importOriginal) => ({
|
|
|
37
37
|
removeLibraryItem: libApiMock.removeLibraryItem,
|
|
38
38
|
}));
|
|
39
39
|
|
|
40
|
+
vi.mock('../services/teams.api', () => ({ listTeams: vi.fn().mockResolvedValue([]) }));
|
|
40
41
|
vi.mock('../services/plugins.api', () => ({
|
|
41
42
|
listPlugins: pluginsMock.listPlugins,
|
|
42
43
|
listJoinRequests: pluginsMock.listJoinRequests,
|
|
@@ -56,12 +57,37 @@ vi.mock('../services/plugins.api', () => ({
|
|
|
56
57
|
vi.mock('../../access/components/ManageAccessDialog', () => ({
|
|
57
58
|
ManageAccessDialog: ({
|
|
58
59
|
entry,
|
|
60
|
+
workspaceId,
|
|
61
|
+
onManageAncestor,
|
|
59
62
|
onClose,
|
|
60
63
|
}: {
|
|
61
64
|
entry: { relativePath: string; type: string };
|
|
65
|
+
workspaceId?: string;
|
|
66
|
+
onManageAncestor?(entry: { name: string; relativePath: string; type: string }): void;
|
|
62
67
|
onClose(): void;
|
|
63
68
|
}) => (
|
|
64
|
-
|
|
69
|
+
// The branch and the ancestor walk are the page's to hand over, so the
|
|
70
|
+
// stub surfaces both: which branch the rules are read and written on, and
|
|
71
|
+
// whether an inherited grant can be managed where it actually lives.
|
|
72
|
+
<div
|
|
73
|
+
role="dialog"
|
|
74
|
+
aria-label={`Manage access ${entry.type} ${entry.relativePath}`}
|
|
75
|
+
data-workspace={workspaceId}
|
|
76
|
+
>
|
|
77
|
+
{onManageAncestor && (
|
|
78
|
+
<button
|
|
79
|
+
type="button"
|
|
80
|
+
onClick={() =>
|
|
81
|
+
onManageAncestor({
|
|
82
|
+
name: 'GTM',
|
|
83
|
+
relativePath: 'knowledge-base/Plugins/GTM',
|
|
84
|
+
type: 'directory',
|
|
85
|
+
})
|
|
86
|
+
}
|
|
87
|
+
>
|
|
88
|
+
Manage GTM →
|
|
89
|
+
</button>
|
|
90
|
+
)}
|
|
65
91
|
<button type="button" onClick={onClose}>
|
|
66
92
|
Close access
|
|
67
93
|
</button>
|
|
@@ -130,8 +156,11 @@ const CATALOG: LibraryData = {
|
|
|
130
156
|
{ name: 'roadmap', description: 'Keeps the roadmap.', path: 'Plugins/Product/roadmap' },
|
|
131
157
|
],
|
|
132
158
|
pendingSkills: [],
|
|
159
|
+
pendingTools: [],
|
|
133
160
|
tools: [connectedTool()],
|
|
134
161
|
ownedSkills: new Set(['outreach']),
|
|
162
|
+
writableSkills: new Set(['outreach']),
|
|
163
|
+
ownedTools: new Set(),
|
|
135
164
|
allowedToolsBySkill: new Map(),
|
|
136
165
|
crs: [],
|
|
137
166
|
myCrNumbers: new Set<number>(),
|
|
@@ -163,11 +192,18 @@ function LocationProbe() {
|
|
|
163
192
|
return <div aria-label="href">{location.pathname + location.search}</div>;
|
|
164
193
|
}
|
|
165
194
|
|
|
166
|
-
function renderPlugin(
|
|
195
|
+
function renderPlugin(
|
|
196
|
+
name: string,
|
|
197
|
+
children?: ReactNode,
|
|
198
|
+
admin: AdminContextValue = nonAdmin,
|
|
199
|
+
// The branch the app happens to have OPEN. It is the default one in every
|
|
200
|
+
// case but the access test, which is about the page not following it.
|
|
201
|
+
ambient: WorkspaceContextValue = workspace,
|
|
202
|
+
) {
|
|
167
203
|
return render(
|
|
168
204
|
<MemoryRouter initialEntries={[`/skills-and-tools/plugins/${encodeURIComponent(name)}`]}>
|
|
169
205
|
<AdminContext.Provider value={admin}>
|
|
170
|
-
<WorkspaceContext.Provider value={
|
|
206
|
+
<WorkspaceContext.Provider value={ambient}>
|
|
171
207
|
<LibraryToastProvider>
|
|
172
208
|
<LibraryProvider>
|
|
173
209
|
{withAuth(
|
|
@@ -434,7 +470,11 @@ describe('PluginPage', () => {
|
|
|
434
470
|
expect(
|
|
435
471
|
await screen.findByRole('heading', { name: 'Add a skill or tool to GTM' }),
|
|
436
472
|
).toBeInTheDocument();
|
|
437
|
-
|
|
473
|
+
// The clause is on both the Skills prompt and the hidden Tools one, so
|
|
474
|
+
// this reads the panel on screen.
|
|
475
|
+
expect(
|
|
476
|
+
within(screen.getByRole('tabpanel')).getByText(/No review step/),
|
|
477
|
+
).toBeInTheDocument();
|
|
438
478
|
expect(screen.queryByText('Start an empty SKILL.md')).not.toBeInTheDocument();
|
|
439
479
|
});
|
|
440
480
|
|
|
@@ -494,6 +534,25 @@ describe('PluginPage', () => {
|
|
|
494
534
|
expect(urgent.compareDocumentPosition(tools) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
|
|
495
535
|
});
|
|
496
536
|
|
|
537
|
+
it("lists what the plugin's definition left out, in the server's words, and counts it as attention", async () => {
|
|
538
|
+
dataMock.useLibraryData.mockReturnValue({ ...CATALOG, tools: [connectedTool()] });
|
|
539
|
+
pluginsMock.listPlugins.mockResolvedValue([
|
|
540
|
+
gtm({
|
|
541
|
+
canWrite: true,
|
|
542
|
+
warnings: [
|
|
543
|
+
'registry.json: profile "global" selects server "docs", which was left out — args must be a list of strings',
|
|
544
|
+
'sourceSkillRoots entry "../escape" is not a folder path — ignored',
|
|
545
|
+
],
|
|
546
|
+
}),
|
|
547
|
+
]);
|
|
548
|
+
renderPlugin('GTM');
|
|
549
|
+
expect(await screen.findByText("2 things in this plugin's definition were left out:")).toBeInTheDocument();
|
|
550
|
+
expect(screen.getByText(/selects server "docs", which was left out/)).toBeInTheDocument();
|
|
551
|
+
expect(screen.getByText(/sourceSkillRoots entry/)).toBeInTheDocument();
|
|
552
|
+
// Not an integration to set up: that banner stays down.
|
|
553
|
+
expect(screen.queryByText(/integrations? needs? setup/)).not.toBeInTheDocument();
|
|
554
|
+
});
|
|
555
|
+
|
|
497
556
|
it("warns about a broken link even when the caller cannot read that skill — the server's count wins", async () => {
|
|
498
557
|
// The manager the missing grant locks out: the skill is NOT in their
|
|
499
558
|
// catalog, so nothing in `items` could say a link is broken. The summary
|
|
@@ -612,6 +671,96 @@ describe('PluginPage', () => {
|
|
|
612
671
|
).toBeInTheDocument();
|
|
613
672
|
});
|
|
614
673
|
|
|
674
|
+
/**
|
|
675
|
+
* The gap a business-user tester fell into: they were standing on a plugin's
|
|
676
|
+
* page looking at a skill, and the only Share on screen was the plugin's. A
|
|
677
|
+
* skill card carries its own now, and it opens the SKILL's folder — the
|
|
678
|
+
* thing the card is about — not the plugin's.
|
|
679
|
+
*/
|
|
680
|
+
it("a skill card's menu shares that skill's own folder, not the plugin's", async () => {
|
|
681
|
+
renderPlugin('GTM');
|
|
682
|
+
|
|
683
|
+
fireEvent.click(await screen.findByRole('button', { name: 'Actions for outreach' }));
|
|
684
|
+
expect(
|
|
685
|
+
within(screen.getByRole('menu'))
|
|
686
|
+
.getAllByRole('menuitem')
|
|
687
|
+
.map((i) => i.textContent),
|
|
688
|
+
).toEqual(['Open', 'Share']);
|
|
689
|
+
|
|
690
|
+
fireEvent.click(screen.getByRole('menuitem', { name: 'Share' }));
|
|
691
|
+
expect(
|
|
692
|
+
await screen.findByRole('dialog', {
|
|
693
|
+
name: 'Manage access directory knowledge-base/Plugins/GTM/outreach',
|
|
694
|
+
}),
|
|
695
|
+
).toBeInTheDocument();
|
|
696
|
+
});
|
|
697
|
+
|
|
698
|
+
/**
|
|
699
|
+
* A skill in a plugin usually has NO rules of its own — it reads the ones the
|
|
700
|
+
* plugin folder above it sets. The skill page answers that with the dialog's
|
|
701
|
+
* `Manage <Folder> →`, and a card's Share is the same Share: without the
|
|
702
|
+
* walk, the grant it lands on is read-only here and editable one click away,
|
|
703
|
+
* which is the same dialog disagreeing with itself.
|
|
704
|
+
*/
|
|
705
|
+
it("a card's Share can walk up to the folder the skill inherits from", async () => {
|
|
706
|
+
renderPlugin('GTM');
|
|
707
|
+
|
|
708
|
+
fireEvent.click(await screen.findByRole('button', { name: 'Actions for outreach' }));
|
|
709
|
+
fireEvent.click(screen.getByRole('menuitem', { name: 'Share' }));
|
|
710
|
+
fireEvent.click(await screen.findByRole('button', { name: 'Manage GTM →' }));
|
|
711
|
+
|
|
712
|
+
expect(
|
|
713
|
+
await screen.findByRole('dialog', {
|
|
714
|
+
name: 'Manage access directory knowledge-base/Plugins/GTM',
|
|
715
|
+
}),
|
|
716
|
+
).toBeInTheDocument();
|
|
717
|
+
});
|
|
718
|
+
|
|
719
|
+
/**
|
|
720
|
+
* The Library lists the DEFAULT branch, so the rules it shares are edited
|
|
721
|
+
* where it read them. The ambient workspace here is a different branch on
|
|
722
|
+
* purpose: without the page pinning it, a grant would be spliced into an
|
|
723
|
+
* `access.md` on whatever branch happened to be open — a rule nobody merges,
|
|
724
|
+
* which looks like it worked.
|
|
725
|
+
*/
|
|
726
|
+
it("edits access on the branch the catalog was read from, not the one that's open", async () => {
|
|
727
|
+
renderPlugin('GTM', undefined, nonAdmin, {
|
|
728
|
+
...workspace,
|
|
729
|
+
workspaceId: 'a-change-request-branch',
|
|
730
|
+
} as WorkspaceContextValue);
|
|
731
|
+
|
|
732
|
+
fireEvent.click(await screen.findByRole('button', { name: 'Share' }));
|
|
733
|
+
const dialog = await screen.findByRole('dialog');
|
|
734
|
+
expect(dialog.getAttribute('data-workspace')).toBe(encodeURIComponent(DEFAULT_BRANCH));
|
|
735
|
+
expect(dialog.getAttribute('data-workspace')).not.toBe('a-change-request-branch');
|
|
736
|
+
});
|
|
737
|
+
|
|
738
|
+
/**
|
|
739
|
+
* Both are corner controls on the same card, and the manager view is the one
|
|
740
|
+
* place they meet. Neither may sit on top of the other.
|
|
741
|
+
*/
|
|
742
|
+
it('gives a manager the card menu AND Remove, on separate targets', async () => {
|
|
743
|
+
pluginsMock.listPlugins.mockResolvedValue([gtm({ canWrite: true })]);
|
|
744
|
+
renderPlugin('GTM');
|
|
745
|
+
|
|
746
|
+
const remove = await screen.findByRole('button', { name: 'Remove outreach' });
|
|
747
|
+
const dots = screen.getByRole('button', { name: 'Actions for outreach' });
|
|
748
|
+
expect(remove).not.toBe(dots);
|
|
749
|
+
// The `…` keeps the corner every menu in this product lives in; Remove
|
|
750
|
+
// steps left of it rather than under it.
|
|
751
|
+
expect(dots.className).toContain('right-1.5');
|
|
752
|
+
expect(remove.className).toContain('right-8');
|
|
753
|
+
expect(remove.className).not.toContain('right-1.5');
|
|
754
|
+
});
|
|
755
|
+
|
|
756
|
+
it('leaves a TOOL card alone — access to a tool is decided at its plugin', async () => {
|
|
757
|
+
renderPlugin('GTM');
|
|
758
|
+
|
|
759
|
+
expect(await screen.findByRole('button', { name: 'Actions for outreach' })).toBeInTheDocument();
|
|
760
|
+
// `connectedTool()` is in this plugin and renders a card beside the skill.
|
|
761
|
+
expect(screen.queryByRole('button', { name: /^Actions for (?!outreach)/ })).toBeNull();
|
|
762
|
+
});
|
|
763
|
+
|
|
615
764
|
it('an UNDISCOVERABLE plugin renders exactly like one that does not exist', async () => {
|
|
616
765
|
// Fail-closed: the endpoint omits plugins with no verdict at all, so the
|
|
617
766
|
// page cannot tell "hidden from you" apart from "absent" — the point.
|
|
@@ -628,7 +777,7 @@ describe('PluginPage', () => {
|
|
|
628
777
|
]);
|
|
629
778
|
renderPlugin('Finance');
|
|
630
779
|
expect(
|
|
631
|
-
await screen.findByRole('button', { name: 'Subscribe to
|
|
780
|
+
await screen.findByRole('button', { name: 'Subscribe to this plugin' }),
|
|
632
781
|
).toBeInTheDocument();
|
|
633
782
|
expect(screen.queryByRole('heading', { name: 'Skills' })).not.toBeInTheDocument();
|
|
634
783
|
// A locked plugin offers no way in at all — not an add door, not a propose one.
|
|
@@ -661,7 +810,7 @@ describe('PluginPage', () => {
|
|
|
661
810
|
it('says so when the plugin does not exist', async () => {
|
|
662
811
|
renderPlugin('Nope');
|
|
663
812
|
expect(await screen.findByText("This plugin doesn't exist yet.")).toBeInTheDocument();
|
|
664
|
-
expect(screen.getByRole('link', { name: '
|
|
813
|
+
expect(screen.getByRole('link', { name: 'Everything' })).toHaveAttribute(
|
|
665
814
|
'href',
|
|
666
815
|
'/skills-and-tools',
|
|
667
816
|
);
|
|
@@ -790,4 +939,107 @@ describe('PluginPage', () => {
|
|
|
790
939
|
expect(screen.queryByText('Last updated just now')).not.toBeInTheDocument();
|
|
791
940
|
});
|
|
792
941
|
});
|
|
942
|
+
|
|
943
|
+
/**
|
|
944
|
+
* The Linked pill: which of a plugin's cards live somewhere else.
|
|
945
|
+
*
|
|
946
|
+
* The complaint behind it was a skill on the plugin's page that the Advanced
|
|
947
|
+
* tree did not list under the plugin's folder. Both were right — the skill is
|
|
948
|
+
* linked, the tree shows the disk — and the page was the one saying nothing.
|
|
949
|
+
* The pill is that missing sentence, and its tooltip is what reconciles the
|
|
950
|
+
* two views by naming where the item actually lives.
|
|
951
|
+
*/
|
|
952
|
+
describe('the Linked pill', () => {
|
|
953
|
+
/** A shared skill the plugin links, and a tool sitting under a linked root. */
|
|
954
|
+
const LINKED_CATALOG: LibraryData = {
|
|
955
|
+
...CATALOG,
|
|
956
|
+
skills: [
|
|
957
|
+
...CATALOG.skills,
|
|
958
|
+
{
|
|
959
|
+
name: 'test-shared-linking',
|
|
960
|
+
description: 'Shared across plugins.',
|
|
961
|
+
path: 'Skills/Testing/test-shared-linking',
|
|
962
|
+
plugins: [{ name: 'GTM', linked: true, granted: true }],
|
|
963
|
+
},
|
|
964
|
+
],
|
|
965
|
+
tools: [
|
|
966
|
+
connectedTool(),
|
|
967
|
+
connectedTool({ slug: 'grafana', name: 'grafana', path: 'Plugins/Shared/observability/grafana.tool' }),
|
|
968
|
+
],
|
|
969
|
+
};
|
|
970
|
+
/** The roots GTM's manifest points at — the skill's, and the tool's. */
|
|
971
|
+
const linking = gtm({
|
|
972
|
+
linkedRoots: ['Skills/Testing', 'Plugins/Shared/observability'],
|
|
973
|
+
skillCount: 2,
|
|
974
|
+
toolCount: 2,
|
|
975
|
+
});
|
|
976
|
+
|
|
977
|
+
const pillOn = (testId: string) => within(screen.getByTestId(testId)).queryByText('Linked');
|
|
978
|
+
|
|
979
|
+
beforeEach(() => {
|
|
980
|
+
dataMock.useLibraryData.mockReturnValue(LINKED_CATALOG);
|
|
981
|
+
pluginsMock.listPlugins.mockResolvedValue([linking]);
|
|
982
|
+
});
|
|
983
|
+
|
|
984
|
+
it('marks a LINKED skill and names where it lives; an inline skill wears none', async () => {
|
|
985
|
+
renderPlugin('GTM');
|
|
986
|
+
await screen.findByTestId('library-card-skill-test-shared-linking');
|
|
987
|
+
|
|
988
|
+
expect(pillOn('library-card-skill-test-shared-linking')).toHaveAttribute(
|
|
989
|
+
'title',
|
|
990
|
+
"Lives in Skills/Testing; linked from this plugin's manifest",
|
|
991
|
+
);
|
|
992
|
+
// The skill inside the plugin's own folder is simply here — nothing to say.
|
|
993
|
+
expect(pillOn('library-card-skill-outreach')).toBeNull();
|
|
994
|
+
});
|
|
995
|
+
|
|
996
|
+
// A manifest can link ONE skill folder rather than the shelf holding it.
|
|
997
|
+
// The tooltip names the root that was linked, not its parent: `Skills/Testing`
|
|
998
|
+
// here would point at a shelf this plugin was never given.
|
|
999
|
+
it('names the skill folder itself when the manifest links it outright', async () => {
|
|
1000
|
+
pluginsMock.listPlugins.mockResolvedValue([
|
|
1001
|
+
{ ...linking, linkedRoots: ['Skills/Testing/test-shared-linking', 'Plugins/Shared/observability'] },
|
|
1002
|
+
]);
|
|
1003
|
+
renderPlugin('GTM');
|
|
1004
|
+
await screen.findByTestId('library-card-skill-test-shared-linking');
|
|
1005
|
+
|
|
1006
|
+
expect(pillOn('library-card-skill-test-shared-linking')).toHaveAttribute(
|
|
1007
|
+
'title',
|
|
1008
|
+
"Lives in Skills/Testing/test-shared-linking; linked from this plugin's manifest",
|
|
1009
|
+
);
|
|
1010
|
+
});
|
|
1011
|
+
|
|
1012
|
+
it('marks a TOOL that reaches the plugin through a linked root, and leaves the inline one alone', async () => {
|
|
1013
|
+
renderPlugin('GTM');
|
|
1014
|
+
await screen.findByTestId('library-card-integration-grafana');
|
|
1015
|
+
|
|
1016
|
+
expect(pillOn('library-card-integration-grafana')).toHaveAttribute(
|
|
1017
|
+
'title',
|
|
1018
|
+
"Lives in Plugins/Shared/observability; linked from this plugin's manifest",
|
|
1019
|
+
);
|
|
1020
|
+
expect(pillOn('library-card-integration-heyreach')).toBeNull();
|
|
1021
|
+
});
|
|
1022
|
+
|
|
1023
|
+
it('is scoped to the page it is on: another plugin neither lists the linked items nor pills its own', async () => {
|
|
1024
|
+
// The pill says "linked from THIS plugin's manifest", so it is only ever
|
|
1025
|
+
// decided against the plugin whose page the card is on.
|
|
1026
|
+
renderPlugin('Product');
|
|
1027
|
+
await screen.findByTestId('library-card-skill-roadmap');
|
|
1028
|
+
expect(screen.queryByTestId('library-card-skill-test-shared-linking')).toBeNull();
|
|
1029
|
+
expect(screen.queryByTestId('library-card-integration-grafana')).toBeNull();
|
|
1030
|
+
expect(pillOn('library-card-skill-roadmap')).toBeNull();
|
|
1031
|
+
});
|
|
1032
|
+
|
|
1033
|
+
it('offers a manager no Remove on a tool reached by link — it is removed where it lives', async () => {
|
|
1034
|
+
pluginsMock.listPlugins.mockResolvedValue([{ ...linking, canWrite: true }]);
|
|
1035
|
+
renderPlugin('GTM');
|
|
1036
|
+
|
|
1037
|
+
// The tool in the plugin's own folder is still the manager's to remove.
|
|
1038
|
+
await screen.findByRole('button', { name: 'Remove heyreach' });
|
|
1039
|
+
expect(screen.queryByRole('button', { name: 'Remove grafana' })).toBeNull();
|
|
1040
|
+
// The linked SKILL keeps its verb: unlinking is a manifest edit this
|
|
1041
|
+
// plugin's manager owns.
|
|
1042
|
+
expect(screen.getByRole('button', { name: 'Remove test-shared-linking' })).toBeInTheDocument();
|
|
1043
|
+
});
|
|
1044
|
+
});
|
|
793
1045
|
});
|
|
@@ -9,9 +9,8 @@ import { PluginsSidebar, type PluginsSidebarProps } from '../components/PluginsS
|
|
|
9
9
|
*
|
|
10
10
|
* The sidebar itself only REPORTS the click: it suppresses the browser menu,
|
|
11
11
|
* reads the pointer and the row synchronously, and hands both up. Everything
|
|
12
|
-
* about which verbs are true for a given row lives in `LibraryLayout`,
|
|
13
|
-
*
|
|
14
|
-
* live too.
|
|
12
|
+
* about which verbs are true for a given row lives in `LibraryLayout`, so that
|
|
13
|
+
* is where those assertions live too.
|
|
15
14
|
*/
|
|
16
15
|
|
|
17
16
|
function renderSidebar(over: Partial<PluginsSidebarProps> = {}) {
|
|
@@ -20,21 +19,14 @@ function renderSidebar(over: Partial<PluginsSidebarProps> = {}) {
|
|
|
20
19
|
const props: PluginsSidebarProps = {
|
|
21
20
|
filter: { kind: 'all' },
|
|
22
21
|
onSelect,
|
|
23
|
-
plugins: [
|
|
24
|
-
{ plugin: 'Engineering', count: 4, attention: 0 },
|
|
25
|
-
{ plugin: 'GTM', count: 3, attention: 2 },
|
|
26
|
-
],
|
|
27
|
-
lockedPlugins: ['Finance'],
|
|
28
22
|
ownedCount: 2,
|
|
29
23
|
ownedAttention: 0,
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
24
|
+
teams: [
|
|
25
|
+
{ name: 'Engineering', count: 4, urgent: 0 },
|
|
26
|
+
{ name: 'GTM', count: 3, urgent: 2 },
|
|
27
|
+
],
|
|
34
28
|
onCreatePlugin: vi.fn(),
|
|
35
29
|
canCreatePlugin: true,
|
|
36
|
-
pluginsIndexActive: false,
|
|
37
|
-
onOpenPluginsIndex: vi.fn(),
|
|
38
30
|
onContextMenu,
|
|
39
31
|
...over,
|
|
40
32
|
};
|
|
@@ -47,14 +39,14 @@ const rightClick = (el: Element, at = { clientX: 120, clientY: 240 }) =>
|
|
|
47
39
|
fireEvent.contextMenu(el, at);
|
|
48
40
|
|
|
49
41
|
describe('PluginsSidebar: right-click', () => {
|
|
50
|
-
it('reports a
|
|
42
|
+
it('reports a team row with its filter, its name and the pointer', () => {
|
|
51
43
|
const { onContextMenu } = renderSidebar();
|
|
52
44
|
const gtm = screen.getByRole('button', { name: /^GTM/ });
|
|
53
45
|
rightClick(gtm, { clientX: 88, clientY: 310 });
|
|
54
46
|
|
|
55
47
|
expect(onContextMenu).toHaveBeenCalledTimes(1);
|
|
56
48
|
expect(onContextMenu).toHaveBeenCalledWith({
|
|
57
|
-
filter: { kind: '
|
|
49
|
+
filter: { kind: 'team', group: 'GTM' },
|
|
58
50
|
label: 'GTM',
|
|
59
51
|
x: 88,
|
|
60
52
|
y: 310,
|
|
@@ -71,42 +63,10 @@ describe('PluginsSidebar: right-click', () => {
|
|
|
71
63
|
label: 'Owned by me',
|
|
72
64
|
});
|
|
73
65
|
|
|
74
|
-
rightClick(screen.getByRole('button', { name: /^
|
|
66
|
+
rightClick(screen.getByRole('button', { name: /^Everything/ }));
|
|
75
67
|
expect(onContextMenu.mock.calls[1][0]).toMatchObject({
|
|
76
|
-
filter: { kind: '
|
|
77
|
-
label:
|
|
78
|
-
});
|
|
79
|
-
});
|
|
80
|
-
|
|
81
|
-
/**
|
|
82
|
-
* A locked row emits the same `{ kind: 'group' }` target a readable one does,
|
|
83
|
-
* for the same reason its CLICK does: a plugin you are not in is still a place.
|
|
84
|
-
* The label drops the "(locked)" suffix — that is the accessible name, not the
|
|
85
|
-
* plugin's name, and the menu titles itself with the latter.
|
|
86
|
-
*/
|
|
87
|
-
it('reports a locked row exactly like a readable plugin', () => {
|
|
88
|
-
const { onContextMenu } = renderSidebar();
|
|
89
|
-
rightClick(screen.getByRole('button', { name: 'Finance (locked)' }));
|
|
90
|
-
expect(onContextMenu.mock.calls[0][0]).toMatchObject({
|
|
91
|
-
filter: { kind: 'group', plugin: 'Finance' },
|
|
92
|
-
label: 'Finance',
|
|
93
|
-
});
|
|
94
|
-
});
|
|
95
|
-
|
|
96
|
-
/**
|
|
97
|
-
* The home row has no `LibraryFilter` behind it — the index lists places, not
|
|
98
|
-
* a slice of the catalog — so it reports `null` and gets the nav's own menu:
|
|
99
|
-
* create a plugin, and none of the verbs that need a folder to point at.
|
|
100
|
-
*/
|
|
101
|
-
it('reports the All plugins row with no filter, but with its own row and name', () => {
|
|
102
|
-
const { onContextMenu } = renderSidebar();
|
|
103
|
-
const home = screen.getByRole('button', { name: 'All plugins' });
|
|
104
|
-
rightClick(home);
|
|
105
|
-
expect(onContextMenu).toHaveBeenCalledTimes(1);
|
|
106
|
-
expect(onContextMenu.mock.calls[0][0]).toMatchObject({
|
|
107
|
-
filter: null,
|
|
108
|
-
label: 'All plugins',
|
|
109
|
-
row: home,
|
|
68
|
+
filter: { kind: 'all' },
|
|
69
|
+
label: 'Everything',
|
|
110
70
|
});
|
|
111
71
|
});
|
|
112
72
|
|
|
@@ -124,14 +84,14 @@ describe('PluginsSidebar: right-click', () => {
|
|
|
124
84
|
|
|
125
85
|
/**
|
|
126
86
|
* The nav wraps every row, so without `stopPropagation` a right-click on a
|
|
127
|
-
*
|
|
128
|
-
*
|
|
87
|
+
* row would report the row AND then the empty space — and the layout would
|
|
88
|
+
* render the empty-space menu, since the last call wins.
|
|
129
89
|
*/
|
|
130
90
|
it('does not also report the nav when the click landed on a row', () => {
|
|
131
91
|
const { onContextMenu } = renderSidebar();
|
|
132
92
|
rightClick(screen.getByRole('button', { name: /^Engineering/ }));
|
|
133
93
|
expect(onContextMenu).toHaveBeenCalledTimes(1);
|
|
134
|
-
expect(onContextMenu.mock.calls[0][0].filter).toEqual({ kind: '
|
|
94
|
+
expect(onContextMenu.mock.calls[0][0].filter).toEqual({ kind: 'team', group: 'Engineering' });
|
|
135
95
|
});
|
|
136
96
|
|
|
137
97
|
it('suppresses the browser menu when the click is being handled', () => {
|
|
@@ -157,12 +117,12 @@ describe('PluginsSidebar: right-click', () => {
|
|
|
157
117
|
it('still navigates on a left click. The menu changes nothing about selection', () => {
|
|
158
118
|
const { onSelect, onContextMenu } = renderSidebar();
|
|
159
119
|
fireEvent.click(screen.getByRole('button', { name: /^GTM/ }));
|
|
160
|
-
expect(onSelect).toHaveBeenCalledWith({ kind: '
|
|
120
|
+
expect(onSelect).toHaveBeenCalledWith({ kind: 'team', group: 'GTM' });
|
|
161
121
|
expect(onContextMenu).not.toHaveBeenCalled();
|
|
162
122
|
});
|
|
163
123
|
|
|
164
124
|
it('marks the current row from the target it navigates to', () => {
|
|
165
|
-
renderSidebar({ filter: { kind: '
|
|
125
|
+
renderSidebar({ filter: { kind: 'team', group: 'GTM' } });
|
|
166
126
|
expect(screen.getByRole('button', { name: /^GTM/ })).toHaveAttribute('aria-current', 'true');
|
|
167
127
|
expect(screen.getByRole('button', { name: /^Engineering/ })).toHaveAttribute(
|
|
168
128
|
'aria-current',
|