@bevel-software/platform-core-frontend 0.15.1 → 0.20.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (347) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +20 -9
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/events.test.ts +43 -0
  6. package/src/core/bootstrap.ts +11 -3
  7. package/src/core/events.ts +85 -3
  8. package/src/core/registry.ts +1 -1
  9. package/src/lib/__tests__/email.test.ts +44 -0
  10. package/src/lib/email.ts +37 -1
  11. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  12. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  16. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  20. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
  21. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  22. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  23. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  24. package/src/modules/access/api.ts +140 -6
  25. package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
  26. package/src/modules/access/manage-access-affordance.ts +17 -0
  27. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  28. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  29. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  30. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  31. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  32. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  33. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  34. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  35. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  36. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  37. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  38. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  39. package/src/modules/admin/components/group-members-path.ts +32 -0
  40. package/src/modules/admin/services/roles.api.ts +12 -1
  41. package/src/modules/audit/__tests__/AuditLogPage.test.tsx +312 -0
  42. package/src/modules/audit/components/AuditEventsPanel.tsx +319 -0
  43. package/src/modules/audit/components/AuditLogPage.tsx +373 -0
  44. package/src/modules/audit/components/principal-grouping.ts +49 -0
  45. package/src/modules/audit/services/audit.api.ts +98 -0
  46. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  47. package/src/modules/auth/components/AccountPage.tsx +73 -54
  48. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  49. package/src/modules/auth/services/account.api.ts +78 -4
  50. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  51. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  52. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  53. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  58. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  59. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  60. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  61. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  62. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  63. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  64. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  65. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  66. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  67. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  68. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  69. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  70. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  71. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  72. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  73. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  74. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  75. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  76. package/src/modules/change-requests/services/propose.api.ts +97 -8
  77. package/src/modules/change-requests/utils/approval.ts +15 -0
  78. package/src/modules/change-requests/utils/author.ts +32 -0
  79. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  80. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  81. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  82. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  83. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  84. package/src/modules/git/services/error-messages.ts +12 -0
  85. package/src/modules/git/services/pr-prompts.ts +5 -5
  86. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  87. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  88. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  89. package/src/modules/layout/components/AppLayout.tsx +2 -0
  90. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  91. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  92. package/src/modules/layout/components/SidebarFrame.tsx +108 -3
  93. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  94. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  95. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  96. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  97. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  98. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
  99. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
  100. package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
  101. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
  102. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  103. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  104. package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
  105. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  106. package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
  107. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
  108. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
  109. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  110. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  111. package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
  112. package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
  113. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  114. package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
  115. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
  116. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  117. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  118. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  119. package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
  120. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  121. package/src/modules/library/__tests__/library-paths.test.ts +47 -4
  122. package/src/modules/library/__tests__/link-membership.test.ts +13 -4
  123. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  124. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  125. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  126. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  127. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  128. package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
  129. package/src/modules/library/__tests__/status.test.ts +82 -2
  130. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  131. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  132. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  133. package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
  134. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  135. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  136. package/src/modules/library/components/LibraryCard.tsx +146 -45
  137. package/src/modules/library/components/LibraryLayout.tsx +119 -256
  138. package/src/modules/library/components/LibraryPage.tsx +172 -39
  139. package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
  140. package/src/modules/library/components/LockedPluginView.tsx +62 -34
  141. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  142. package/src/modules/library/components/NewPluginDialog.tsx +16 -2
  143. package/src/modules/library/components/PageActions.tsx +11 -9
  144. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  145. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  146. package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
  147. package/src/modules/library/components/PluginExtras.tsx +140 -17
  148. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  149. package/src/modules/library/components/PluginPage.tsx +157 -41
  150. package/src/modules/library/components/PluginRows.tsx +286 -0
  151. package/src/modules/library/components/PluginsSidebar.tsx +239 -263
  152. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  153. package/src/modules/library/components/ShareButton.tsx +17 -0
  154. package/src/modules/library/components/SkillsTree.tsx +141 -28
  155. package/src/modules/library/components/TeamRoute.tsx +15 -0
  156. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  157. package/src/modules/library/components/plugin-page-parts.tsx +103 -17
  158. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
  159. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  160. package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
  161. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  162. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  163. package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
  164. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  165. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  166. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  167. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  168. package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
  169. package/src/modules/library/routes/library-paths.ts +26 -28
  170. package/src/modules/library/services/library.api.ts +38 -20
  171. package/src/modules/library/services/plugins.api.ts +69 -8
  172. package/src/modules/library/services/teams.api.ts +15 -0
  173. package/src/modules/library/services/tools.api.ts +78 -0
  174. package/src/modules/library/state/library-data.tsx +170 -32
  175. package/src/modules/library/utils/personal-plugin.ts +13 -15
  176. package/src/modules/library/utils/plugin-entries.ts +134 -0
  177. package/src/modules/library/utils/plugin-summary.ts +75 -9
  178. package/src/modules/library/utils/status.ts +135 -33
  179. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
  180. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  181. package/src/modules/onboarding/agent-clients.ts +55 -23
  182. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  183. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  184. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  185. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  186. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  187. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  188. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  189. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  190. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  191. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  192. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  193. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  194. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  195. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  196. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  197. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  198. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  199. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  200. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  201. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  202. package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
  203. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  204. package/src/modules/settings/components/DeploymentPage.tsx +10 -30
  205. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  206. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
  207. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  208. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +7 -6
  209. package/src/modules/settings/services/github-facade.api.ts +23 -0
  210. package/src/modules/settings/settings-nav-items.tsx +13 -3
  211. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  212. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  213. package/src/modules/setup/__tests__/setup.test.tsx +497 -4
  214. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  215. package/src/modules/setup/components/SetupGate.tsx +16 -16
  216. package/src/modules/setup/components/SetupScreen.tsx +532 -43
  217. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  218. package/src/modules/setup/services/setup.api.ts +141 -4
  219. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  220. package/src/modules/setup/utils/root-folders.ts +46 -0
  221. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  222. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  223. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  224. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  225. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  226. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  227. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  228. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  229. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  230. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  231. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  232. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  233. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  234. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  235. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  236. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  237. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
  238. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  239. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  240. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  241. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
  242. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  243. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  244. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  245. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  246. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  247. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  248. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  249. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  250. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  251. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  252. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  253. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  254. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  255. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  256. package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
  257. package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
  258. package/src/modules/workspace/components/FileRoute.tsx +353 -36
  259. package/src/modules/workspace/components/FileViewer.tsx +172 -46
  260. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  261. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  262. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  263. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2533 -129
  264. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
  265. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +381 -12
  266. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  267. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  268. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  269. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  270. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  271. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  272. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  273. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  274. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  275. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  276. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  277. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  278. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  279. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  280. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  281. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  282. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  283. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  284. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  285. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  286. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  287. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  288. package/src/modules/workspace/components/renderers/index.ts +53 -2
  289. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  290. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  291. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  292. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  293. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  294. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  295. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  296. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
  297. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  298. package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
  299. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  300. package/src/modules/workspace/routing/kb-routes.ts +206 -29
  301. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +134 -1
  302. package/src/modules/workspace/services/workspace.api.ts +57 -4
  303. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  304. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  305. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  306. package/src/modules/workspace/state/workspace.context.ts +125 -19
  307. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  308. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
  309. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  310. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  311. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  312. package/src/modules/workspace/utils/file-trace.ts +50 -0
  313. package/src/modules/workspace/utils/fileTree.ts +112 -36
  314. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  315. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  316. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  317. package/src/modules/workspace/utils/uploadError.ts +29 -0
  318. package/src/shared/__tests__/marketplace-url.test.ts +6 -1
  319. package/src/shared/components/Button.tsx +16 -2
  320. package/src/shared/components/Dialog.tsx +27 -11
  321. package/src/shared/components/Menu.tsx +13 -1
  322. package/src/shared/components/PageShell.tsx +13 -8
  323. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  324. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  325. package/src/shared/components/index.ts +2 -0
  326. package/src/shared/components/useDismissableMenu.ts +32 -10
  327. package/src/shared/components/useFocusHandoff.ts +51 -0
  328. package/src/shared/components/useLatestRef.ts +28 -0
  329. package/src/shared/markdown/Markdown.tsx +12 -3
  330. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  331. package/src/shared/markdown/hrefs.ts +50 -0
  332. package/src/shared/marketplace-url.ts +33 -5
  333. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  334. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  335. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  336. package/src/shared/mcp/connect-snippets.ts +14 -9
  337. package/src/shared/mcp/index.ts +1 -1
  338. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  339. package/src/shared/theme/header.ts +75 -0
  340. package/src/shared/theme/measure.ts +7 -4
  341. package/src/shared/theme/tokens.css +25 -0
  342. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  343. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  344. package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
  345. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  346. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  347. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -1,82 +1,417 @@
1
- import { describe, it, expect, vi, beforeEach } from 'vitest';
2
- import { render, screen } from '@testing-library/react';
3
- import { MemoryRouter } from 'react-router-dom';
4
- import type { ToolSecrets } from '../../services/tool-secrets.api';
5
- import { SecretsPage } from '../SecretsPage';
6
-
7
- const toolSecretsMock = vi.hoisted(() => ({ listToolSecrets: vi.fn() }));
8
-
9
- vi.mock('../../services/secrets.api', () => ({
10
- listSecrets: vi.fn(async () => []),
11
- createOAuthSecret: vi.fn(async () => {}),
12
- deleteSecret: vi.fn(async () => {}),
13
- startOAuth: vi.fn(async () => ''),
14
- }));
15
- vi.mock('../../services/tool-secrets.api', () => ({
16
- listToolSecrets: toolSecretsMock.listToolSecrets,
17
- setAdminVar: vi.fn(async () => {}),
18
- setUserVar: vi.fn(async () => {}),
19
- setOAuthClientSecret: vi.fn(async () => {}),
20
- deleteAdminVar: vi.fn(async () => {}),
21
- deleteUserVar: vi.fn(async () => {}),
22
- }));
23
-
24
- /** The page carries links now, so it needs a router around it. */
25
- function renderPage() {
26
- return render(
27
- <MemoryRouter>
28
- <SecretsPage />
29
- </MemoryRouter>,
30
- );
31
- }
32
-
33
- describe('SecretsPage', () => {
34
- beforeEach(() => {
35
- // Each test starts on a clean /secrets URL (no leftover fragment).
36
- window.history.replaceState(null, '', '/secrets');
37
- toolSecretsMock.listToolSecrets.mockReset().mockResolvedValue([]);
38
- });
39
-
40
- it('renders as a full page (no dialog) and loads the secret lists', async () => {
41
- renderPage();
42
- expect(screen.getByRole('heading', { name: 'Secrets' })).toBeInTheDocument();
43
- expect(
44
- await screen.findByText('No tools you can access declare secrets yet.'),
45
- ).toBeInTheDocument();
46
- // Converted from the old gear-menu dialog: nothing modal is mounted.
47
- expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
48
- });
49
-
50
- it('links each tool name at its own page', async () => {
51
- const heyreach: ToolSecrets = {
52
- slug: 'heyreach',
53
- name: 'heyreach',
54
- path: 'Plugins/GTM/heyreach.tool',
55
- type: 'inline',
56
- setup: null,
57
- canWrite: false,
58
- variables: [],
59
- };
60
- toolSecretsMock.listToolSecrets.mockResolvedValue([heyreach]);
61
-
62
- renderPage();
63
- const link = await screen.findByRole('link', { name: 'Open heyreach' });
64
- expect(link).toHaveAttribute('href', '/skills-and-tools/tools/heyreach');
65
- });
66
-
67
- it('surfaces the OAuth-callback success carried in the #authorized fragment and strips it', async () => {
68
- window.history.replaceState(null, '', '/secrets#authorized');
69
- renderPage();
70
- expect(await screen.findByText('Authorization complete.')).toBeInTheDocument();
71
- // The fragment is consumed so a refresh doesn't re-announce it.
72
- expect(window.location.hash).toBe('');
73
- expect(window.location.pathname).toBe('/secrets');
74
- });
75
-
76
- it('surfaces the OAuth-callback error carried in the #error fragment and strips it', async () => {
77
- window.history.replaceState(null, '', '/secrets#error=Access%20denied');
78
- renderPage();
79
- expect(await screen.findByText('Access denied')).toBeInTheDocument();
80
- expect(window.location.hash).toBe('');
81
- });
82
- });
1
+ import { describe, it, expect, vi, afterEach, beforeEach } from 'vitest';
2
+ import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
+ import { MemoryRouter } from 'react-router-dom';
4
+ import type { ToolSecrets } from '../../services/tool-secrets.api';
5
+ import { SecretsPage } from '../SecretsPage';
6
+ import { TOOL_CREDENTIALS_STALE_EVENT } from '../../../../core/events';
7
+
8
+ const toolSecretsMock = vi.hoisted(() => ({
9
+ listToolSecrets: vi.fn(),
10
+ setUserVar: vi.fn(),
11
+ deleteUserVar: vi.fn(),
12
+ checkToolConnection: vi.fn(),
13
+ }));
14
+
15
+ vi.mock('../../services/secrets.api', () => ({
16
+ listSecrets: vi.fn(async () => []),
17
+ createOAuthSecret: vi.fn(async () => {}),
18
+ deleteSecret: vi.fn(async () => {}),
19
+ startOAuth: vi.fn(async () => ''),
20
+ }));
21
+ vi.mock('../../services/tool-secrets.api', () => ({
22
+ listToolSecrets: toolSecretsMock.listToolSecrets,
23
+ setAdminVar: vi.fn(async () => {}),
24
+ setUserVar: toolSecretsMock.setUserVar,
25
+ setOAuthClientSecret: vi.fn(async () => {}),
26
+ deleteAdminVar: vi.fn(async () => {}),
27
+ deleteUserVar: toolSecretsMock.deleteUserVar,
28
+ checkToolConnection: toolSecretsMock.checkToolConnection,
29
+ }));
30
+
31
+ /** The page carries links now, so it needs a router around it. */
32
+ function renderPage() {
33
+ return render(
34
+ <MemoryRouter>
35
+ <SecretsPage />
36
+ </MemoryRouter>,
37
+ );
38
+ }
39
+
40
+ describe('SecretsPage', () => {
41
+ beforeEach(() => {
42
+ // Each test starts on a clean /secrets URL (no leftover fragment).
43
+ window.history.replaceState(null, '', '/secrets');
44
+ toolSecretsMock.listToolSecrets.mockReset().mockResolvedValue([]);
45
+ });
46
+
47
+ it('renders as a full page (no dialog) and loads the secret lists', async () => {
48
+ renderPage();
49
+ expect(screen.getByRole('heading', { name: 'Secrets' })).toBeInTheDocument();
50
+ expect(
51
+ await screen.findByText('No tools you can access declare secrets yet.'),
52
+ ).toBeInTheDocument();
53
+ // Converted from the old gear-menu dialog: nothing modal is mounted.
54
+ expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
55
+ });
56
+
57
+ it('links each tool name at its own page', async () => {
58
+ const heyreach: ToolSecrets = {
59
+ slug: 'heyreach',
60
+ name: 'heyreach',
61
+ path: 'Plugins/GTM/heyreach.tool',
62
+ type: 'inline',
63
+ setup: null,
64
+ canWrite: false,
65
+ variables: [],
66
+ };
67
+ toolSecretsMock.listToolSecrets.mockResolvedValue([heyreach]);
68
+
69
+ renderPage();
70
+ const link = await screen.findByRole('link', { name: 'Open heyreach' });
71
+ expect(link).toHaveAttribute('href', '/skills-and-tools/tools/heyreach');
72
+ });
73
+
74
+ it('surfaces the OAuth-callback success carried in the #authorized fragment and strips it', async () => {
75
+ window.history.replaceState(null, '', '/secrets#authorized');
76
+ renderPage();
77
+ expect(await screen.findByText('Authorization complete.')).toBeInTheDocument();
78
+ // The fragment is consumed so a refresh doesn't re-announce it.
79
+ expect(window.location.hash).toBe('');
80
+ expect(window.location.pathname).toBe('/secrets');
81
+ });
82
+
83
+ it('surfaces the OAuth-callback error carried in the #error fragment and strips it', async () => {
84
+ window.history.replaceState(null, '', '/secrets#error=Access%20denied');
85
+ renderPage();
86
+ expect(await screen.findByText('Access denied')).toBeInTheDocument();
87
+ expect(window.location.hash).toBe('');
88
+ });
89
+
90
+ /**
91
+ * The vault is a shell route of its own: no Library is mounted under
92
+ * `/secrets`, so a key set here has no provider to call. It ANNOUNCES
93
+ * instead — the one rule every writing surface follows — and the cards and
94
+ * plugin banners pick it up wherever they are.
95
+ */
96
+ describe('a key set here reaches the Library', () => {
97
+ const heard = vi.fn();
98
+ const heyreach: ToolSecrets = {
99
+ slug: 'heyreach',
100
+ name: 'heyreach',
101
+ path: 'Plugins/GTM/heyreach.tool',
102
+ type: 'inline',
103
+ setup: null,
104
+ canWrite: false,
105
+ variables: [
106
+ {
107
+ name: 'API_KEY',
108
+ scope: 'user',
109
+ label: null,
110
+ key: 'heyreach_API_KEY',
111
+ adminConfigured: true,
112
+ userConfigured: false,
113
+ },
114
+ ],
115
+ };
116
+
117
+ beforeEach(() => {
118
+ heard.mockReset();
119
+ toolSecretsMock.setUserVar.mockReset().mockResolvedValue(undefined);
120
+ toolSecretsMock.deleteUserVar.mockReset().mockResolvedValue(undefined);
121
+ window.addEventListener(TOOL_CREDENTIALS_STALE_EVENT, heard);
122
+ });
123
+ afterEach(() => window.removeEventListener(TOOL_CREDENTIALS_STALE_EVENT, heard));
124
+
125
+ const showTool = async (userConfigured: boolean) => {
126
+ toolSecretsMock.listToolSecrets.mockResolvedValue([
127
+ { ...heyreach, variables: [{ ...heyreach.variables[0], userConfigured }] },
128
+ ]);
129
+ renderPage();
130
+ return screen.findByLabelText('Value for API_KEY');
131
+ };
132
+
133
+ it('announces a saved key', async () => {
134
+ const field = await showTool(false);
135
+ fireEvent.change(field, { target: { value: 'k' } });
136
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
137
+
138
+ await waitFor(() => expect(heard).toHaveBeenCalledTimes(1));
139
+ });
140
+
141
+ it('announces a removed one', async () => {
142
+ await showTool(true);
143
+ fireEvent.click(screen.getByRole('button', { name: 'Remove' }));
144
+
145
+ await waitFor(() => expect(heard).toHaveBeenCalledTimes(1));
146
+ });
147
+
148
+ it('announces nothing when the save fails', async () => {
149
+ toolSecretsMock.setUserVar.mockRejectedValue(new Error('Nope.'));
150
+ const field = await showTool(false);
151
+ fireEvent.change(field, { target: { value: 'k' } });
152
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
153
+
154
+ expect(await screen.findByRole('alert')).toHaveTextContent('Nope.');
155
+ expect(heard).not.toHaveBeenCalled();
156
+ });
157
+ });
158
+
159
+ /**
160
+ * The vault probes what it stores, beside the row that stored it.
161
+ *
162
+ * The quietest place in the app to install a key the provider would refuse:
163
+ * the vault has no cards, no banners and no agent watching, so a wrong value
164
+ * simply sat here reading `Set` until something far away failed. The same
165
+ * health check the tool page runs now runs here, said in the same words.
166
+ */
167
+ describe('the saved key is probed', () => {
168
+ const heyreach: ToolSecrets = {
169
+ slug: 'heyreach',
170
+ name: 'heyreach',
171
+ path: 'Plugins/GTM/heyreach.tool',
172
+ type: 'inline',
173
+ setup: null,
174
+ canWrite: false,
175
+ variables: [
176
+ {
177
+ name: 'API_KEY',
178
+ scope: 'user',
179
+ label: null,
180
+ key: 'heyreach_API_KEY',
181
+ adminConfigured: true,
182
+ userConfigured: false,
183
+ },
184
+ ],
185
+ };
186
+
187
+ beforeEach(() => {
188
+ toolSecretsMock.setUserVar.mockReset().mockResolvedValue(undefined);
189
+ toolSecretsMock.deleteUserVar.mockReset().mockResolvedValue(undefined);
190
+ // Reset, not clear: a test that forgets to state what its probe answers
191
+ // must not inherit its neighbour's implementation and pass by accident.
192
+ toolSecretsMock.checkToolConnection.mockReset();
193
+ toolSecretsMock.listToolSecrets.mockResolvedValue([heyreach]);
194
+ });
195
+
196
+ const saveKey = async (secret = 'k') => {
197
+ renderPage();
198
+ fireEvent.change(await screen.findByLabelText('Value for API_KEY'), {
199
+ target: { value: secret },
200
+ });
201
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
202
+ };
203
+
204
+ it('shows the quiet connected state when the provider accepts it', async () => {
205
+ toolSecretsMock.checkToolConnection.mockResolvedValue({
206
+ status: 'ok',
207
+ detail: null,
208
+ checkedAt: new Date().toISOString(),
209
+ });
210
+
211
+ await saveKey();
212
+
213
+ const row = await screen.findByTestId('saved-key-probe');
214
+ expect(row).toHaveTextContent('Connected');
215
+ expect(row).toHaveAttribute('data-probe-state', 'connected');
216
+ expect(toolSecretsMock.checkToolConnection).toHaveBeenCalledWith('heyreach');
217
+ expect(screen.queryByRole('alert')).toBeNull();
218
+ });
219
+
220
+ it("shows the provider's own status text when it rejects it", async () => {
221
+ toolSecretsMock.checkToolConnection.mockResolvedValue({
222
+ status: 'failed',
223
+ detail: '401 Unauthorized: bad credentials',
224
+ checkedAt: new Date().toISOString(),
225
+ });
226
+
227
+ await saveKey();
228
+
229
+ const row = await screen.findByTestId('saved-key-probe');
230
+ expect(row).toHaveAttribute('data-probe-state', 'rejected');
231
+ expect(row).toHaveAttribute('role', 'alert');
232
+ expect(row).toHaveTextContent('401 Unauthorized: bad credentials');
233
+ });
234
+
235
+ it('says Unverified, and why, when the manual defines no health check', async () => {
236
+ toolSecretsMock.checkToolConnection.mockResolvedValue({
237
+ status: 'unverifiable',
238
+ detail: "This tool doesn't offer a way to test its connection.",
239
+ checkedAt: new Date().toISOString(),
240
+ });
241
+
242
+ await saveKey();
243
+
244
+ const row = await screen.findByTestId('saved-key-probe');
245
+ expect(row).toHaveAttribute('data-probe-state', 'unverified');
246
+ expect(row).toHaveTextContent('Unverified');
247
+ expect(row).toHaveTextContent("This tool doesn't offer a way to test its connection.");
248
+ expect(screen.queryByRole('alert')).toBeNull();
249
+ });
250
+
251
+ it('says the check could not run — not that the key is wrong — when the probe fails', async () => {
252
+ toolSecretsMock.checkToolConnection.mockRejectedValue(new Error('Network down'));
253
+
254
+ await saveKey();
255
+
256
+ const row = await screen.findByTestId('saved-key-probe');
257
+ expect(row).toHaveAttribute('data-probe-state', 'unreachable');
258
+ expect(row).toHaveTextContent('Saved, but not tested.');
259
+ expect(row).not.toHaveTextContent('Not working');
260
+ });
261
+
262
+ it('stores the value first: a probe that never answers never blocks the save', async () => {
263
+ toolSecretsMock.checkToolConnection.mockReturnValue(new Promise(() => {}));
264
+
265
+ await saveKey('k');
266
+
267
+ await waitFor(() =>
268
+ expect(toolSecretsMock.setUserVar).toHaveBeenCalledWith('heyreach', 'API_KEY', 'k'),
269
+ );
270
+ await waitFor(() => expect(screen.getByLabelText('Value for API_KEY')).toHaveValue(''));
271
+ expect(await screen.findByTestId('saved-key-probe')).toHaveAttribute(
272
+ 'data-probe-state',
273
+ 'checking',
274
+ );
275
+ });
276
+
277
+ it('drops the answer when the value is REMOVED rather than saved', async () => {
278
+ // A verdict is about a value this row no longer holds. "Connected" over
279
+ // a deleted key is the stale claim in its purest form.
280
+ toolSecretsMock.checkToolConnection.mockResolvedValue({
281
+ status: 'ok',
282
+ detail: null,
283
+ checkedAt: new Date().toISOString(),
284
+ });
285
+ // Already stored, so the row carries Remove from the start and replacing
286
+ // the value does not change which controls are on it.
287
+ toolSecretsMock.listToolSecrets.mockResolvedValue([
288
+ { ...heyreach, variables: [{ ...heyreach.variables[0], userConfigured: true }] },
289
+ ]);
290
+
291
+ await saveKey();
292
+ expect(await screen.findByTestId('saved-key-probe')).toHaveTextContent('Connected');
293
+
294
+ fireEvent.click(screen.getByRole('button', { name: 'Remove' }));
295
+
296
+ await waitFor(() => expect(screen.queryByTestId('saved-key-probe')).toBeNull());
297
+ // And a delete has nothing to prove, so it starts no probe of its own.
298
+ expect(toolSecretsMock.checkToolConnection).toHaveBeenCalledTimes(1);
299
+ });
300
+
301
+ it('never repeats the submitted secret, whatever the probe says', async () => {
302
+ const secret = 'sk-live-DO-NOT-ECHO-4242';
303
+ toolSecretsMock.checkToolConnection.mockResolvedValue({
304
+ status: 'failed',
305
+ detail: 'The API key you supplied was rejected.',
306
+ checkedAt: new Date().toISOString(),
307
+ });
308
+
309
+ await saveKey(secret);
310
+
311
+ await screen.findByTestId('saved-key-probe');
312
+ expect(document.body.textContent).not.toContain(secret);
313
+ expect(document.body.innerHTML).not.toContain(secret);
314
+ });
315
+ });
316
+
317
+ /**
318
+ * A LIST load is an answer about the vault, and answers arrive out of order.
319
+ *
320
+ * Every save starts one, and the page had no way to tell a fresh answer from
321
+ * a late one — so the row a person had just filled in could flip back to
322
+ * `Needs a key` on the strength of a request that left before they typed it.
323
+ * The same newest-wins rule the probe follows, for the same reason: this
324
+ * page's whole job now is to stop saying confident things it cannot back up.
325
+ */
326
+ describe('a late list load cannot undo a newer one', () => {
327
+ const heyreach: ToolSecrets = {
328
+ slug: 'heyreach',
329
+ name: 'heyreach',
330
+ path: 'Plugins/GTM/heyreach.tool',
331
+ type: 'inline',
332
+ setup: null,
333
+ canWrite: false,
334
+ variables: [
335
+ {
336
+ name: 'API_KEY',
337
+ scope: 'user',
338
+ label: null,
339
+ key: 'heyreach_API_KEY',
340
+ adminConfigured: true,
341
+ userConfigured: false,
342
+ },
343
+ ],
344
+ };
345
+ const withKey = (userConfigured: boolean): ToolSecrets[] => [
346
+ { ...heyreach, variables: [{ ...heyreach.variables[0], userConfigured }] },
347
+ ];
348
+
349
+ beforeEach(() => {
350
+ toolSecretsMock.setUserVar.mockReset().mockResolvedValue(undefined);
351
+ toolSecretsMock.checkToolConnection.mockReset().mockResolvedValue({
352
+ status: 'ok',
353
+ detail: null,
354
+ checkedAt: new Date().toISOString(),
355
+ });
356
+ });
357
+
358
+ const save = async (value: string) => {
359
+ fireEvent.change(await screen.findByLabelText('Value for API_KEY'), { target: { value } });
360
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
361
+ };
362
+
363
+ it('shows the newest list even when an older load answers last', async () => {
364
+ /** Each load after the first is held open, so the order is ours to pick. */
365
+ const held: ((tools: ToolSecrets[]) => void)[] = [];
366
+ toolSecretsMock.listToolSecrets
367
+ .mockReset()
368
+ .mockResolvedValueOnce(withKey(false))
369
+ .mockImplementation(() => new Promise<ToolSecrets[]>((resolve) => held.push(resolve)));
370
+
371
+ renderPage();
372
+ await save('a');
373
+ await waitFor(() => expect(held).toHaveLength(1));
374
+ await save('b');
375
+ await waitFor(() => expect(held).toHaveLength(2));
376
+
377
+ // The newer load lands first, then the one that left before the key was
378
+ // typed — the shape of the bug, which no amount of retrying fixes.
379
+ held[1](withKey(true));
380
+ await screen.findByText('Set');
381
+ held[0](withKey(false));
382
+
383
+ await waitFor(() => expect(screen.getByText('Set')).toBeInTheDocument());
384
+ expect(screen.queryByText('Needs a key')).toBeNull();
385
+ });
386
+
387
+ it('keeps a verdict on the row when the header Refresh is pressed', async () => {
388
+ // The loud refresh dropped the page to "Loading…", unmounting the panel
389
+ // that holds the only copy of the probe's answer. Nothing persists a
390
+ // verdict, so the answer was simply gone — and pressing Refresh is
391
+ // exactly what someone does while waiting for one.
392
+ //
393
+ // Every load after the first reports the key as SET, which is what the
394
+ // server actually says once a save has landed. Feeding the pre-save list
395
+ // back instead would leave the badge reading `Needs a key` under a
396
+ // verdict reading `Connected` — a contradiction the real flow never
397
+ // produces, and not a state worth pinning a test to.
398
+ toolSecretsMock.listToolSecrets
399
+ .mockReset()
400
+ .mockResolvedValueOnce(withKey(false))
401
+ .mockResolvedValue(withKey(true));
402
+ renderPage();
403
+ await save('a');
404
+ expect(await screen.findByTestId('saved-key-probe')).toHaveTextContent('Connected');
405
+
406
+ fireEvent.click(screen.getByRole('button', { name: 'Refresh' }));
407
+
408
+ await waitFor(() => expect(toolSecretsMock.listToolSecrets).toHaveBeenCalledTimes(3));
409
+ expect(screen.queryByText('Loading…')).toBeNull();
410
+ // The row is coherent: the badge agrees with the verdict beneath it.
411
+ expect(screen.getByText('Set')).toBeInTheDocument();
412
+ expect(screen.getByTestId('saved-key-probe')).toHaveTextContent('Connected');
413
+ // Survived, not re-asked — a refresh is not a reason to call the provider.
414
+ expect(toolSecretsMock.checkToolConnection).toHaveBeenCalledTimes(1);
415
+ });
416
+ });
417
+ });
@@ -0,0 +1,105 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
+ import type { ToolSecrets } from '../../services/tool-secrets.api';
4
+ import { ToolSecretsPanel } from '../ToolSecretsPanel';
5
+
6
+ /**
7
+ * The panel is not always remounted when the tool under it changes.
8
+ *
9
+ * `SecretsPage` gives each tool its own list item, so React keys them apart —
10
+ * but the workspace's `.tool` renderer mounts ONE panel and swaps the `tool`
11
+ * prop as the reader opens a different file. A probe's answer that survived
12
+ * that swap would sit beside a variable of the same name on the new tool,
13
+ * saying `Connected` about a provider nobody has called for it: the confident
14
+ * stale claim this whole feature exists to remove, reached sideways.
15
+ *
16
+ * The rule under test lives in `useSavedKeyProbe`, not in the callers — the
17
+ * slug is part of the identity of every answer it holds, so a caller that
18
+ * forgets to key the panel cannot produce the bug.
19
+ */
20
+
21
+ const api = vi.hoisted(() => ({
22
+ setUserVar: vi.fn(),
23
+ checkToolConnection: vi.fn(),
24
+ }));
25
+
26
+ vi.mock('../../services/tool-secrets.api', () => ({
27
+ setAdminVar: vi.fn(async () => {}),
28
+ setUserVar: api.setUserVar,
29
+ setOAuthClientSecret: vi.fn(async () => {}),
30
+ deleteAdminVar: vi.fn(async () => {}),
31
+ deleteUserVar: vi.fn(async () => {}),
32
+ checkToolConnection: api.checkToolConnection,
33
+ }));
34
+ vi.mock('../../services/connect.api', () => ({ startToolOAuth: vi.fn(async () => '') }));
35
+
36
+ /** Two tools that declare the SAME variable name — the case that goes wrong. */
37
+ const tool = (slug: string): ToolSecrets => ({
38
+ slug,
39
+ name: slug,
40
+ path: `Plugins/Engineering/${slug}.tool`,
41
+ type: 'http',
42
+ setup: null,
43
+ canWrite: false,
44
+ variables: [
45
+ {
46
+ name: 'API_KEY',
47
+ scope: 'user',
48
+ label: null,
49
+ key: `${slug}_API_KEY`,
50
+ adminConfigured: true,
51
+ userConfigured: false,
52
+ },
53
+ ],
54
+ });
55
+
56
+ describe('ToolSecretsPanel: an answer belongs to the tool it was asked about', () => {
57
+ beforeEach(() => {
58
+ api.setUserVar.mockReset().mockResolvedValue(undefined);
59
+ api.checkToolConnection.mockReset();
60
+ });
61
+
62
+ it('drops the previous tool’s verdict when the panel is handed a new tool', async () => {
63
+ api.checkToolConnection.mockResolvedValue({
64
+ status: 'ok',
65
+ detail: null,
66
+ checkedAt: new Date().toISOString(),
67
+ });
68
+ const { rerender } = render(<ToolSecretsPanel tool={tool('github')} onChanged={() => {}} />);
69
+
70
+ fireEvent.change(screen.getByLabelText('Value for API_KEY'), { target: { value: 'k' } });
71
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
72
+ await waitFor(() =>
73
+ expect(screen.getByTestId('saved-key-probe')).toHaveTextContent('Connected'),
74
+ );
75
+
76
+ // The reader opens a different `.tool` file. Same component instance, same
77
+ // variable name, a provider that was never called.
78
+ rerender(<ToolSecretsPanel tool={tool('linear')} onChanged={() => {}} />);
79
+
80
+ expect(screen.queryByTestId('saved-key-probe')).toBeNull();
81
+ // And it is not merely hidden for a frame: nothing brings it back.
82
+ await waitFor(() => expect(screen.queryByTestId('saved-key-probe')).toBeNull());
83
+ expect(api.checkToolConnection).toHaveBeenCalledTimes(1);
84
+ expect(api.checkToolConnection).toHaveBeenCalledWith('github');
85
+ });
86
+
87
+ it('probes the NEW tool when a key is saved after the swap', async () => {
88
+ api.checkToolConnection.mockResolvedValue({
89
+ status: 'failed',
90
+ detail: 'The provider rejected this credential (401).',
91
+ checkedAt: new Date().toISOString(),
92
+ });
93
+ const { rerender } = render(<ToolSecretsPanel tool={tool('github')} onChanged={() => {}} />);
94
+ rerender(<ToolSecretsPanel tool={tool('linear')} onChanged={() => {}} />);
95
+
96
+ fireEvent.change(screen.getByLabelText('Value for API_KEY'), { target: { value: 'k' } });
97
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
98
+
99
+ await waitFor(() =>
100
+ expect(screen.getByTestId('saved-key-probe')).toHaveTextContent('Not working'),
101
+ );
102
+ expect(api.setUserVar).toHaveBeenCalledWith('linear', 'API_KEY', 'k');
103
+ expect(api.checkToolConnection).toHaveBeenCalledWith('linear');
104
+ });
105
+ });