@bevel-software/platform-core-frontend 0.15.1 → 0.20.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (347) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +20 -9
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/events.test.ts +43 -0
  6. package/src/core/bootstrap.ts +11 -3
  7. package/src/core/events.ts +85 -3
  8. package/src/core/registry.ts +1 -1
  9. package/src/lib/__tests__/email.test.ts +44 -0
  10. package/src/lib/email.ts +37 -1
  11. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  12. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  16. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  20. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
  21. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  22. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  23. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  24. package/src/modules/access/api.ts +140 -6
  25. package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
  26. package/src/modules/access/manage-access-affordance.ts +17 -0
  27. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  28. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  29. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  30. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  31. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  32. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  33. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  34. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  35. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  36. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  37. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  38. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  39. package/src/modules/admin/components/group-members-path.ts +32 -0
  40. package/src/modules/admin/services/roles.api.ts +12 -1
  41. package/src/modules/audit/__tests__/AuditLogPage.test.tsx +312 -0
  42. package/src/modules/audit/components/AuditEventsPanel.tsx +319 -0
  43. package/src/modules/audit/components/AuditLogPage.tsx +373 -0
  44. package/src/modules/audit/components/principal-grouping.ts +49 -0
  45. package/src/modules/audit/services/audit.api.ts +98 -0
  46. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  47. package/src/modules/auth/components/AccountPage.tsx +73 -54
  48. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  49. package/src/modules/auth/services/account.api.ts +78 -4
  50. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  51. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  52. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  53. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  58. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  59. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  60. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  61. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  62. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  63. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  64. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  65. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  66. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  67. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  68. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  69. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  70. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  71. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  72. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  73. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  74. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  75. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  76. package/src/modules/change-requests/services/propose.api.ts +97 -8
  77. package/src/modules/change-requests/utils/approval.ts +15 -0
  78. package/src/modules/change-requests/utils/author.ts +32 -0
  79. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  80. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  81. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  82. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  83. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  84. package/src/modules/git/services/error-messages.ts +12 -0
  85. package/src/modules/git/services/pr-prompts.ts +5 -5
  86. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  87. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  88. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  89. package/src/modules/layout/components/AppLayout.tsx +2 -0
  90. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  91. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  92. package/src/modules/layout/components/SidebarFrame.tsx +108 -3
  93. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  94. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  95. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  96. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  97. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  98. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
  99. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
  100. package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
  101. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
  102. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  103. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  104. package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
  105. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  106. package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
  107. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
  108. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
  109. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  110. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  111. package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
  112. package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
  113. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  114. package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
  115. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
  116. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  117. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  118. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  119. package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
  120. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  121. package/src/modules/library/__tests__/library-paths.test.ts +47 -4
  122. package/src/modules/library/__tests__/link-membership.test.ts +13 -4
  123. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  124. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  125. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  126. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  127. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  128. package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
  129. package/src/modules/library/__tests__/status.test.ts +82 -2
  130. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  131. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  132. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  133. package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
  134. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  135. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  136. package/src/modules/library/components/LibraryCard.tsx +146 -45
  137. package/src/modules/library/components/LibraryLayout.tsx +119 -256
  138. package/src/modules/library/components/LibraryPage.tsx +172 -39
  139. package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
  140. package/src/modules/library/components/LockedPluginView.tsx +62 -34
  141. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  142. package/src/modules/library/components/NewPluginDialog.tsx +16 -2
  143. package/src/modules/library/components/PageActions.tsx +11 -9
  144. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  145. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  146. package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
  147. package/src/modules/library/components/PluginExtras.tsx +140 -17
  148. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  149. package/src/modules/library/components/PluginPage.tsx +157 -41
  150. package/src/modules/library/components/PluginRows.tsx +286 -0
  151. package/src/modules/library/components/PluginsSidebar.tsx +239 -263
  152. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  153. package/src/modules/library/components/ShareButton.tsx +17 -0
  154. package/src/modules/library/components/SkillsTree.tsx +141 -28
  155. package/src/modules/library/components/TeamRoute.tsx +15 -0
  156. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  157. package/src/modules/library/components/plugin-page-parts.tsx +103 -17
  158. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
  159. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  160. package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
  161. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  162. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  163. package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
  164. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  165. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  166. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  167. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  168. package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
  169. package/src/modules/library/routes/library-paths.ts +26 -28
  170. package/src/modules/library/services/library.api.ts +38 -20
  171. package/src/modules/library/services/plugins.api.ts +69 -8
  172. package/src/modules/library/services/teams.api.ts +15 -0
  173. package/src/modules/library/services/tools.api.ts +78 -0
  174. package/src/modules/library/state/library-data.tsx +170 -32
  175. package/src/modules/library/utils/personal-plugin.ts +13 -15
  176. package/src/modules/library/utils/plugin-entries.ts +134 -0
  177. package/src/modules/library/utils/plugin-summary.ts +75 -9
  178. package/src/modules/library/utils/status.ts +135 -33
  179. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
  180. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  181. package/src/modules/onboarding/agent-clients.ts +55 -23
  182. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  183. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  184. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  185. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  186. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  187. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  188. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  189. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  190. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  191. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  192. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  193. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  194. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  195. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  196. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  197. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  198. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  199. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  200. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  201. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  202. package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
  203. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  204. package/src/modules/settings/components/DeploymentPage.tsx +10 -30
  205. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  206. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
  207. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  208. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +7 -6
  209. package/src/modules/settings/services/github-facade.api.ts +23 -0
  210. package/src/modules/settings/settings-nav-items.tsx +13 -3
  211. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  212. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  213. package/src/modules/setup/__tests__/setup.test.tsx +497 -4
  214. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  215. package/src/modules/setup/components/SetupGate.tsx +16 -16
  216. package/src/modules/setup/components/SetupScreen.tsx +532 -43
  217. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  218. package/src/modules/setup/services/setup.api.ts +141 -4
  219. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  220. package/src/modules/setup/utils/root-folders.ts +46 -0
  221. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  222. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  223. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  224. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  225. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  226. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  227. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  228. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  229. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  230. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  231. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  232. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  233. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  234. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  235. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  236. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  237. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
  238. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  239. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  240. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  241. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
  242. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  243. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  244. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  245. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  246. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  247. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  248. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  249. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  250. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  251. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  252. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  253. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  254. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  255. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  256. package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
  257. package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
  258. package/src/modules/workspace/components/FileRoute.tsx +353 -36
  259. package/src/modules/workspace/components/FileViewer.tsx +172 -46
  260. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  261. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  262. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  263. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2533 -129
  264. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
  265. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +381 -12
  266. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  267. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  268. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  269. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  270. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  271. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  272. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  273. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  274. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  275. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  276. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  277. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  278. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  279. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  280. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  281. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  282. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  283. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  284. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  285. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  286. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  287. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  288. package/src/modules/workspace/components/renderers/index.ts +53 -2
  289. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  290. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  291. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  292. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  293. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  294. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  295. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  296. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
  297. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  298. package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
  299. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  300. package/src/modules/workspace/routing/kb-routes.ts +206 -29
  301. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +134 -1
  302. package/src/modules/workspace/services/workspace.api.ts +57 -4
  303. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  304. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  305. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  306. package/src/modules/workspace/state/workspace.context.ts +125 -19
  307. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  308. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
  309. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  310. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  311. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  312. package/src/modules/workspace/utils/file-trace.ts +50 -0
  313. package/src/modules/workspace/utils/fileTree.ts +112 -36
  314. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  315. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  316. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  317. package/src/modules/workspace/utils/uploadError.ts +29 -0
  318. package/src/shared/__tests__/marketplace-url.test.ts +6 -1
  319. package/src/shared/components/Button.tsx +16 -2
  320. package/src/shared/components/Dialog.tsx +27 -11
  321. package/src/shared/components/Menu.tsx +13 -1
  322. package/src/shared/components/PageShell.tsx +13 -8
  323. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  324. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  325. package/src/shared/components/index.ts +2 -0
  326. package/src/shared/components/useDismissableMenu.ts +32 -10
  327. package/src/shared/components/useFocusHandoff.ts +51 -0
  328. package/src/shared/components/useLatestRef.ts +28 -0
  329. package/src/shared/markdown/Markdown.tsx +12 -3
  330. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  331. package/src/shared/markdown/hrefs.ts +50 -0
  332. package/src/shared/marketplace-url.ts +33 -5
  333. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  334. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  335. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  336. package/src/shared/mcp/connect-snippets.ts +14 -9
  337. package/src/shared/mcp/index.ts +1 -1
  338. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  339. package/src/shared/theme/header.ts +75 -0
  340. package/src/shared/theme/measure.ts +7 -4
  341. package/src/shared/theme/tokens.css +25 -0
  342. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  343. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  344. package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
  345. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  346. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  347. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -1,4 +1,4 @@
1
- import { describe, it, expect, vi, beforeEach } from 'vitest';
1
+ import { describe, it, expect, vi, afterEach, beforeEach } from 'vitest';
2
2
  import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
3
  import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
4
4
  import type { ReactNode } from 'react';
@@ -60,6 +60,8 @@ vi.mock('../../secrets-vault/services/connect.api', () => ({ startToolOAuth: vi.
60
60
  vi.mock('../utils/navigate-external', () => ({ navigateExternal: vi.fn() }));
61
61
 
62
62
  import { ToolPage } from '../components/tool-page/ToolPage';
63
+ import { NAME_MIN_WIDTH } from '../components/NameWithBadges';
64
+ import { TOOL_CREDENTIALS_STALE_EVENT } from '../../../core/events';
63
65
 
64
66
  const GITHUB: ToolSecrets = {
65
67
  slug: 'heyreach',
@@ -186,6 +188,32 @@ describe('ToolPage: frame', () => {
186
188
  expect(screen.getByText('Managed by the Admins.')).toBeInTheDocument();
187
189
  });
188
190
 
191
+ it('holds a long tool name to a readable width, and says the rest on hover', async () => {
192
+ // The card's rule, on the page header — the half of it a one-row band
193
+ // can keep. The name truncates and says the rest on hover; it does not
194
+ // take a floor, because the band has no second line to hand anything.
195
+ const long = 'disposable-weather-lookup-for-the-northern-hemisphere-v2beta';
196
+ secretsMock.listToolSecrets.mockResolvedValue([{ ...GITHUB, name: long }]);
197
+ toolsMock.getToolDetail.mockResolvedValue({ ...DETAIL, name: long });
198
+ renderPage();
199
+
200
+ // Whole in the DOM, so a screen reader reads all of it; whole in `title`,
201
+ // so the reader who only has the ellipsis can finish it.
202
+ const title = await screen.findByRole('heading', { name: long, level: 1 });
203
+ expect(title).toHaveAttribute('title', long);
204
+ expect(title.className).toContain('truncate');
205
+
206
+ // And NOT the floor. The band is one row tall, the same row the sidebar's
207
+ // header holds, so there is no second line for a floor to push anything
208
+ // onto — a floor here only made the title wider than the band and sent it
209
+ // out of the bottom of it at every phone width. The row says so itself:
210
+ // it cannot wrap, and it clips.
211
+ expect(title.className).not.toContain(NAME_MIN_WIDTH);
212
+ const row = title.parentElement as HTMLElement;
213
+ expect(row.className).toContain('flex-nowrap');
214
+ expect(row.className).toContain('overflow-hidden');
215
+ });
216
+
189
217
  it('shows no kicker for a legacy ungrouped path either', async () => {
190
218
  secretsMock.listToolSecrets.mockResolvedValue([
191
219
  { ...GITHUB, slug: 'slack', name: 'slack', path: 'Tools/slack.tool' },
@@ -218,7 +246,7 @@ describe('ToolPage: frame', () => {
218
246
  expect(
219
247
  await screen.findByText("This tool doesn't exist, or you don't have access to it."),
220
248
  ).toBeInTheDocument();
221
- expect(screen.getByRole('button', { name: '‹ All skills & tools' })).toBeInTheDocument();
249
+ expect(screen.getByRole('button', { name: '‹ Everything' })).toBeInTheDocument();
222
250
  });
223
251
 
224
252
  it('offers Try again when the secrets listing fails, and refetches on click', async () => {
@@ -371,7 +399,12 @@ describe('ToolPage: OAuth round-trip', () => {
371
399
  window.history.replaceState(null, '', '/skills-and-tools/tools/heyreach#authorized=sec_1');
372
400
  renderPage();
373
401
 
374
- expect(await screen.findByRole('status')).toHaveTextContent('Signed in to heyreach.');
402
+ // Scoped by NAME: the `⋯` menu carries its own (empty) status region for
403
+ // the copy-link answer, so "the only status on the page" is no longer a
404
+ // way to name the sign-in banner.
405
+ expect(
406
+ (await screen.findAllByRole('status')).map((s) => s.textContent),
407
+ ).toContain('Signed in to heyreach.');
375
408
  // Consumed, so a refresh doesn't re-announce it.
376
409
  await waitFor(() => expect(window.location.hash).toBe(''));
377
410
  expect(window.location.pathname).toBe('/skills-and-tools/tools/heyreach');
@@ -403,13 +436,63 @@ describe('ToolPage: OAuth round-trip', () => {
403
436
  );
404
437
  renderPage();
405
438
 
406
- expect(await screen.findByRole('status')).toHaveTextContent('Signed in to heyreach.');
439
+ // Scoped by NAME: the `⋯` menu carries its own (empty) status region for
440
+ // the copy-link answer, so "the only status on the page" is no longer a
441
+ // way to name the sign-in banner.
442
+ expect(
443
+ (await screen.findAllByRole('status')).map((s) => s.textContent),
444
+ ).toContain('Signed in to heyreach.');
407
445
  await waitFor(() => expect(window.location.hash).toBe(''));
408
446
  expect(window.location.search).toBe('?server=heyreach');
409
447
  expect(window.location.pathname).toBe(
410
448
  '/workspace/main/knowledge-base/Plugins/Everyone/mcp.json',
411
449
  );
412
450
  });
451
+
452
+ /**
453
+ * The Library is a second store, and the sign-in happened outside both of
454
+ * them. Everything that says "needs setup" — the cards, the plugin banner,
455
+ * the sidebar count — was loaded before the browser left for the provider,
456
+ * so the page the reader goes back to is the one that gets it wrong.
457
+ */
458
+ describe('telling the Library', () => {
459
+ const heard = vi.fn();
460
+ beforeEach(() => {
461
+ heard.mockReset();
462
+ window.addEventListener(TOOL_CREDENTIALS_STALE_EVENT, heard);
463
+ });
464
+ afterEach(() => window.removeEventListener(TOOL_CREDENTIALS_STALE_EVENT, heard));
465
+
466
+ it('announces a successful return', async () => {
467
+ window.history.replaceState(null, '', '/skills-and-tools/tools/heyreach#authorized=sec_1');
468
+ renderPage();
469
+
470
+ // `All`, because the page carries more than one live region (the
471
+ // sections announce their own loading) — the one this waits on is the
472
+ // sign-in's.
473
+ expect((await screen.findAllByRole('status')).map((s) => s.textContent)).toContain(
474
+ 'Signed in to heyreach.',
475
+ );
476
+ await waitFor(() => expect(heard).toHaveBeenCalledTimes(1));
477
+ });
478
+
479
+ it('announces a failed one too — the page wrote nothing either way', async () => {
480
+ // Not a failed save: this page stored nothing, and the outcome it was
481
+ // handed is the only evidence about a grant somebody else decided. The
482
+ // honest move on both is to go and re-read.
483
+ window.history.replaceState(null, '', '/skills-and-tools/tools/heyreach#error=Access%20denied');
484
+ renderPage();
485
+
486
+ await screen.findByRole('alert');
487
+ await waitFor(() => expect(heard).toHaveBeenCalledTimes(1));
488
+ });
489
+
490
+ it('stays quiet on an ordinary visit, with no fragment to consume', async () => {
491
+ renderPage();
492
+ await screen.findByRole('heading', { name: 'heyreach', level: 1 });
493
+ expect(heard).not.toHaveBeenCalled();
494
+ });
495
+ });
413
496
  });
414
497
 
415
498
  /**
@@ -1,5 +1,5 @@
1
1
  import { describe, it, expect, vi, beforeEach } from 'vitest';
2
- import { render, screen, waitFor } from '@testing-library/react';
2
+ import { cleanup, render, screen, waitFor } from '@testing-library/react';
3
3
  import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
4
4
  import type { ReactNode } from 'react';
5
5
  import { DEFAULT_BRANCH, type FileTreeEntry } from '@bevel-software/platform-shared';
@@ -7,6 +7,7 @@ import {
7
7
  WorkspaceContext,
8
8
  type WorkspaceContextValue,
9
9
  } from '../../workspace/state/workspace.context';
10
+ import { makeWorkspaceFixture } from '../../workspace/__tests__/testFixtures';
10
11
  import { AdminContext } from '../../admin/state/admin.context';
11
12
  import type { LibraryData } from '../hooks/useLibraryData';
12
13
 
@@ -21,6 +22,9 @@ import type { LibraryData } from '../hooks/useLibraryData';
21
22
  const dataMock = vi.hoisted(() => ({ useLibraryData: vi.fn() }));
22
23
  vi.mock('../hooks/useLibraryData', () => ({ useLibraryData: dataMock.useLibraryData }));
23
24
 
25
+ vi.mock('../services/teams.api', () => ({ listTeams: vi.fn().mockResolvedValue([]) }));
26
+ // The sidebar's change-request dock pulls in git wiring these routes do not exercise.
27
+ vi.mock('../../git/components/PullRequestsForMe', () => ({ PullRequestsForMe: () => null }));
24
28
  vi.mock('../services/plugins.api', () => ({
25
29
  listPlugins: vi.fn().mockResolvedValue([]),
26
30
  listJoinRequests: vi.fn().mockResolvedValue([]),
@@ -34,11 +38,38 @@ vi.mock('../components/skill-page/SkillPage', () => ({
34
38
  vi.mock('../components/tool-page/ToolPage', () => ({
35
39
  ToolPage: ({ slug }: { slug?: string }) => <div aria-label="tool-page">{slug}</div>,
36
40
  }));
41
+ // The Knowledge file route, rendered by the item route for a loose file:
42
+ // its own behaviour lives with the workspace tests.
43
+ vi.mock('../../workspace/components/FileRoute', () => ({
44
+ FileRoute: ({ canonicalize }: { canonicalize?: boolean }) => (
45
+ <div aria-label="file-view">{`canonicalize:${String(canonicalize)}`}</div>
46
+ ),
47
+ }));
37
48
 
38
49
  import { LibraryRoutes } from '../routes/LibraryRoutes';
39
50
  import { isLibraryLocation } from '../routes/library-paths';
51
+ import { listPlugins, type PluginSummary } from '../services/plugins.api';
40
52
  import { withAuth } from './auth-harness';
41
53
 
54
+ /** A listed plugin whose folder is `Plugins/Sales` and whose identity is `sales`. */
55
+ const SALES: PluginSummary = {
56
+ name: 'sales',
57
+ displayName: 'Sales',
58
+ folders: ['Plugins/Sales'],
59
+ canRead: true,
60
+ canWrite: false,
61
+ isOwner: false,
62
+ linksAreManaged: true,
63
+ skillCount: 1,
64
+ toolCount: 0,
65
+ brokenLinks: 0,
66
+ owners: { roles: [], users: [] },
67
+ writers: { roles: [], users: [] },
68
+ readers: { restricted: true, roles: [], users: [] },
69
+ hasRequested: false,
70
+ requestNumber: null,
71
+ };
72
+
42
73
  const CATALOG: LibraryData = {
43
74
  loading: false,
44
75
  error: null,
@@ -46,6 +77,7 @@ const CATALOG: LibraryData = {
46
77
  { name: 'create-sales-deck', description: '', path: 'Plugins/Sales/create-sales-deck' },
47
78
  ],
48
79
  pendingSkills: [],
80
+ pendingTools: [],
49
81
  tools: [
50
82
  {
51
83
  slug: 'notion',
@@ -58,6 +90,8 @@ const CATALOG: LibraryData = {
58
90
  },
59
91
  ],
60
92
  ownedSkills: new Set<string>(),
93
+ writableSkills: new Set<string>(),
94
+ ownedTools: new Set<string>(),
61
95
  allowedToolsBySkill: new Map(),
62
96
  crs: [],
63
97
  myCrNumbers: new Set<number>(),
@@ -77,12 +111,13 @@ function wrap(children: ReactNode, fileTree: FileTreeEntry | null = null) {
77
111
  rolesConfigErrors: [],
78
112
  runRolesRecovery: vi.fn(),
79
113
  };
80
- const workspaceValue = {
114
+ // The shared fixture, not an ad-hoc literal: a cast-shaped stub goes on
115
+ // compiling when the context gains a field and fails at render instead.
116
+ const workspaceValue: WorkspaceContextValue = makeWorkspaceFixture({
81
117
  workspaceId: 'ws',
82
118
  kbDirName: KB,
83
119
  fileTree,
84
- pendingUploads: new Map(),
85
- } as unknown as WorkspaceContextValue;
120
+ });
86
121
  return (
87
122
  <AdminContext.Provider value={adminValue}>
88
123
  <WorkspaceContext.Provider value={workspaceValue}>
@@ -128,6 +163,7 @@ const itemUrl = (repoRel: string, branch = DEFAULT_BRANCH) =>
128
163
 
129
164
  beforeEach(() => {
130
165
  dataMock.useLibraryData.mockReturnValue(CATALOG);
166
+ vi.mocked(listPlugins).mockResolvedValue([]);
131
167
  });
132
168
 
133
169
  describe('WorkspaceItemRoute', () => {
@@ -137,7 +173,7 @@ describe('WorkspaceItemRoute', () => {
137
173
  'create-sales-deck::reference/LESSONS.md',
138
174
  );
139
175
  // The ONE library sidebar is on screen with it — same surface, not a copy.
140
- expect(screen.getByRole('button', { name: /^All plugins/ })).toBeInTheDocument();
176
+ expect(screen.getByRole('button', { name: /^Everything/ })).toBeInTheDocument();
141
177
  });
142
178
 
143
179
  it('a bare skill-folder URL opens SKILL.md', async () => {
@@ -162,7 +198,7 @@ describe('WorkspaceItemRoute', () => {
162
198
  'brand-new-skill::SKILL.md',
163
199
  );
164
200
  // …inside the library surface, never the Knowledge view.
165
- expect(screen.getByRole('button', { name: /^All plugins/ })).toBeInTheDocument();
201
+ expect(screen.getByRole('button', { name: /^Everything/ })).toBeInTheDocument();
166
202
  });
167
203
 
168
204
  it("a `.tool` URL falls back to the filename slug when the catalog hasn't loaded", async () => {
@@ -171,11 +207,123 @@ describe('WorkspaceItemRoute', () => {
171
207
  expect(await screen.findByLabelText('tool-page')).toHaveTextContent('notion');
172
208
  });
173
209
 
174
- it("a Plugins path that is no item lands on its plugin's page", async () => {
175
- renderAt(itemUrl('Plugins/Sales/access.md'));
176
- await waitFor(() =>
177
- expect(screen.getByLabelText('pathname')).toHaveTextContent('/skills-and-tools/plugins/Sales'),
210
+ it('router state `rawFile` renders the file itself at a URL that would otherwise be a page — still inside the library', async () => {
211
+ // The tool page's "Edit the tool file" and the plugin page's manifest
212
+ // button ask for the raw editor by state; the app on screen does not
213
+ // change.
214
+ render(
215
+ <MemoryRouter initialEntries={[{ pathname: itemUrl('Plugins/Support/notion.tool'), state: { rawFile: true } }]}>
216
+ {wrap(
217
+ <Routes>
218
+ <Route path="/workspace/*" element={<LibraryRoutes />} />
219
+ </Routes>,
220
+ null,
221
+ )}
222
+ <LocationProbe />
223
+ </MemoryRouter>,
178
224
  );
225
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
226
+ expect(screen.queryByLabelText('tool-page')).not.toBeInTheDocument();
227
+ expect(screen.getByRole('button', { name: /^Everything/ })).toBeInTheDocument();
228
+ // A `.tool` carries a frontmatter id — the very case the id redirect
229
+ // would have bounced back to Knowledge.
230
+ expect(screen.getByLabelText('file-view')).toHaveTextContent('canonicalize:false');
231
+ });
232
+
233
+ it("a plugin's own file — its access.md — opens as the plain file it is, INSIDE the library frame, not the plugin page", async () => {
234
+ // The page keys on the plugin's IDENTITY, which the folder name need not
235
+ // be (a personal space, a folder spelled unlike its manifest), so the old
236
+ // bounce landed on "doesn't exist" for a file plainly there. The file
237
+ // route renders here: same URL, no navigation, no router state, and the
238
+ // library's own nav still around it — which app a file opens in follows
239
+ // the folder it is in.
240
+ renderAt(itemUrl('Plugins/Sales/access.md'));
241
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
242
+ expect(screen.getByLabelText('pathname')).toHaveTextContent(itemUrl('Plugins/Sales/access.md'));
243
+ expect(screen.getByLabelText('raw-file')).toHaveTextContent('false');
244
+ // The file route must not replace the path with a node-id URL here: an id
245
+ // URL is no library location, and the surface would switch after all.
246
+ expect(screen.getByLabelText('file-view')).toHaveTextContent('canonicalize:false');
247
+ expect(screen.getByRole('button', { name: /^Everything/ })).toBeInTheDocument();
248
+ expect(screen.queryByLabelText('skill-page')).not.toBeInTheDocument();
249
+ });
250
+
251
+ describe("a file inside a listed plugin", () => {
252
+ it("the manifest opens as the file, with a note naming the plugin and a link to its page", async () => {
253
+ vi.mocked(listPlugins).mockResolvedValue([SALES]);
254
+ renderAt(itemUrl('Plugins/Sales/plugin.json'));
255
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
256
+ // The file, at its own URL — no jump to the page.
257
+ expect(screen.getByLabelText('pathname')).toHaveTextContent(itemUrl('Plugins/Sales/plugin.json'));
258
+ // The note names the plugin as people know it and links by its identity.
259
+ expect(await screen.findByText('Sales')).toBeInTheDocument();
260
+ expect(screen.getByRole('link', { name: 'Open plugin' })).toHaveAttribute('href', '/skills-and-tools/plugins/sales');
261
+ });
262
+
263
+ it("the bundle dialect's manifest and the plugin's access.md carry the same note", async () => {
264
+ vi.mocked(listPlugins).mockResolvedValue([{ ...SALES, linksAreManaged: false }]);
265
+ renderAt(itemUrl('Plugins/Sales/plugin.bundle.json'));
266
+ expect(await screen.findByRole('link', { name: 'Open plugin' })).toHaveAttribute('href', '/skills-and-tools/plugins/sales');
267
+ cleanup();
268
+ vi.mocked(listPlugins).mockResolvedValue([SALES]);
269
+ renderAt(itemUrl('Plugins/Sales/access.md'));
270
+ expect(await screen.findByRole('link', { name: 'Open plugin' })).toHaveAttribute('href', '/skills-and-tools/plugins/sales');
271
+ });
272
+
273
+ it('shows the file at once but the note only from a settled plugin list', async () => {
274
+ // A stale list could name the wrong plugin for a frame; the file waits
275
+ // for nothing, the note does.
276
+ let answer: (plugins: PluginSummary[]) => void = () => {};
277
+ vi.mocked(listPlugins).mockReturnValue(new Promise<PluginSummary[]>((r) => (answer = r)));
278
+ renderAt(itemUrl('Plugins/Sales/plugin.json'));
279
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
280
+ expect(screen.queryByRole('link', { name: 'Open plugin' })).not.toBeInTheDocument();
281
+ answer([SALES]);
282
+ expect(await screen.findByRole('link', { name: 'Open plugin' })).toHaveAttribute('href', '/skills-and-tools/plugins/sales');
283
+ });
284
+
285
+ it('a file in a folder no listed plugin holds gets no note — the file alone', async () => {
286
+ renderAt(itemUrl('Plugins/Nope/plugin.json'));
287
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
288
+ expect(screen.queryByRole('link', { name: 'Open plugin' })).not.toBeInTheDocument();
289
+ });
290
+
291
+ it("a manifest bundled inside a SKILL stays that skill's file", async () => {
292
+ vi.mocked(listPlugins).mockResolvedValue([SALES]);
293
+ renderAt(itemUrl('Plugins/Sales/create-sales-deck/plugin.json'));
294
+ expect(await screen.findByLabelText('skill-page')).toHaveTextContent('create-sales-deck::plugin.json');
295
+ });
296
+
297
+ it('a sibling folder sharing a prefix with the plugin does not claim the file', async () => {
298
+ vi.mocked(listPlugins).mockResolvedValue([SALES]);
299
+ renderAt(itemUrl('Plugins/Sales-Team/plugin.json'));
300
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
301
+ expect(screen.queryByRole('link', { name: 'Open plugin' })).not.toBeInTheDocument();
302
+ });
303
+
304
+ it('router state `rawFile` opens the manifest as a file with the same note — the page’s Manifest button', async () => {
305
+ vi.mocked(listPlugins).mockResolvedValue([SALES]);
306
+ render(
307
+ <MemoryRouter initialEntries={[{ pathname: itemUrl('Plugins/Sales/plugin.json'), state: { rawFile: true } }]}>
308
+ {wrap(
309
+ <Routes>
310
+ <Route path="/workspace/*" element={<LibraryRoutes />} />
311
+ </Routes>,
312
+ null,
313
+ )}
314
+ <LocationProbe />
315
+ </MemoryRouter>,
316
+ );
317
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
318
+ expect(screen.getByLabelText('pathname')).toHaveTextContent(itemUrl('Plugins/Sales/plugin.json'));
319
+ expect(await screen.findByRole('link', { name: 'Open plugin' })).toBeInTheDocument();
320
+ });
321
+ });
322
+
323
+ it("a personal space's access.md opens the same way — it has no listed plugin page at all", async () => {
324
+ renderAt(itemUrl('Plugins/personal-u1/access.md'));
325
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
326
+ expect(screen.getByLabelText('pathname')).toHaveTextContent(itemUrl('Plugins/personal-u1/access.md'));
179
327
  });
180
328
 
181
329
  /**
@@ -260,15 +408,13 @@ describe('WorkspaceItemRoute', () => {
260
408
  expect(await screen.findByLabelText('tool-page')).toHaveTextContent('internal_deploy');
261
409
  });
262
410
 
263
- it("sends a category folder's own access.md to the plugin page", async () => {
411
+ it("opens a category folder's own access.md as a plain file", async () => {
264
412
  // The same answer a stray file at the plugin's top level gets. Before, it
265
413
  // fell through to a SkillPage named after the category.
266
414
  renderAt(itemUrl('Plugins/Engineering/coding/access.md'));
267
- await waitFor(() =>
268
- expect(screen.getByLabelText('pathname')).toHaveTextContent(
269
- '/skills-and-tools/plugins/Engineering',
270
- ),
271
- );
415
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
416
+ expect(screen.getByLabelText('pathname')).toHaveTextContent(itemUrl('Plugins/Engineering/coding/access.md'));
417
+ expect(screen.queryByLabelText('skill-page')).not.toBeInTheDocument();
272
418
  });
273
419
 
274
420
  it('waits for the catalog rather than guessing a category is the skill', async () => {
@@ -277,7 +423,7 @@ describe('WorkspaceItemRoute', () => {
277
423
  // the catalog is what settles it, so hold the slot until it lands.
278
424
  dataMock.useLibraryData.mockReturnValue({ ...NESTED, loading: true, skills: [], tools: [] });
279
425
  renderAt(itemUrl('Plugins/Engineering/coding/create-ticket'));
280
- expect(await screen.findByRole('button', { name: /^All plugins/ })).toBeInTheDocument();
426
+ expect(await screen.findByRole('button', { name: /^Everything/ })).toBeInTheDocument();
281
427
  expect(screen.queryByLabelText('skill-page')).toBeNull();
282
428
  });
283
429
 
@@ -410,7 +556,7 @@ describe('WorkspaceItemRoute', () => {
410
556
  it('waits for the catalog on a bare mcp.json URL rather than guessing', async () => {
411
557
  dataMock.useLibraryData.mockReturnValue({ ...CATALOG, loading: true, skills: [], tools: [] });
412
558
  renderAt(itemUrl('Plugins/LocalLab/mcp.json'));
413
- expect(await screen.findByRole('button', { name: /^All plugins/ })).toBeInTheDocument();
559
+ expect(await screen.findByRole('button', { name: /^Everything/ })).toBeInTheDocument();
414
560
  expect(screen.queryByLabelText('tool-page')).toBeNull();
415
561
  // …and it has not been bounced away either: the URL is still the file's.
416
562
  expect(screen.getByLabelText('pathname')).toHaveTextContent('/Plugins/LocalLab/mcp.json');
@@ -508,7 +654,7 @@ describe('WorkspaceItemRoute', () => {
508
654
  it("renders a shared skill file on that file's tab, inside the library nav", async () => {
509
655
  renderAt(itemUrl('Skills/Sales/discovery-call/checklist.md'));
510
656
  expect(await screen.findByLabelText('skill-page')).toHaveTextContent('discovery-call::checklist.md');
511
- expect(screen.getByRole('button', { name: /^All plugins/ })).toBeInTheDocument();
657
+ expect(screen.getByRole('button', { name: /^Everything/ })).toBeInTheDocument();
512
658
  });
513
659
 
514
660
  it('opens a bare shared skill folder on SKILL.md', async () => {
@@ -529,17 +675,18 @@ describe('WorkspaceItemRoute', () => {
529
675
  );
530
676
  });
531
677
 
532
- it("opens a scope's own file as a plain file, in the pane workspace", async () => {
678
+ it("opens a scope's own file as a plain file, inside the library frame", async () => {
533
679
  renderAt(itemUrl('Skills/Sales/access.md'));
534
- await waitFor(() => expect(screen.getByLabelText('raw-file')).toHaveTextContent('true'));
535
- // Same URL — the raw view is router state, never a different address.
680
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
681
+ // Same URL — the file route renders in place, no navigation.
536
682
  expect(screen.getByLabelText('pathname')).toHaveTextContent(itemUrl('Skills/Sales/access.md'));
683
+ expect(screen.getByRole('button', { name: /^Everything/ })).toBeInTheDocument();
537
684
  expect(screen.queryByLabelText('skill-page')).not.toBeInTheDocument();
538
685
  });
539
686
 
540
687
  it("carries a scope file's #fragment into the raw view — a heading deep link still lands", async () => {
541
688
  renderAt(`${itemUrl('Skills/Sales/README.md')}#goal`);
542
- await waitFor(() => expect(screen.getByLabelText('raw-file')).toHaveTextContent('true'));
689
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
543
690
  expect(screen.getByLabelText('hash')).toHaveTextContent('#goal');
544
691
  });
545
692
 
@@ -558,7 +705,7 @@ describe('WorkspaceItemRoute', () => {
558
705
  d(KB, [d(`${KB}/Skills`, [d(`${KB}/Skills/Sales`, [{ name: 'notes.md', relativePath: `${KB}/Skills/Sales/notes.md`, type: 'file' }])])]),
559
706
  ]);
560
707
  renderAt(itemUrl('Skills/Sales/notes.md'), tree);
561
- await waitFor(() => expect(screen.getByLabelText('raw-file')).toHaveTextContent('true'));
708
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
562
709
  expect(screen.queryByLabelText('skill-page')).not.toBeInTheDocument();
563
710
  });
564
711
 
@@ -574,14 +721,14 @@ describe('WorkspaceItemRoute', () => {
574
721
  d(KB, [d(`${KB}/Skills`, [d(`${KB}/Skills/Sales`, [{ name: 'notes.md', relativePath: `${KB}/Skills/Sales/notes.md`, type: 'file' }])])]),
575
722
  ]);
576
723
  renderAt(itemUrl('Skills/Sales/SKILL.md'), tree);
577
- await waitFor(() => expect(screen.getByLabelText('raw-file')).toHaveTextContent('true'));
724
+ await waitFor(() => expect(screen.getByLabelText('file-view')).toBeInTheDocument());
578
725
  expect(screen.queryByLabelText('skill-page')).not.toBeInTheDocument();
579
726
  });
580
727
 
581
728
  it('waits for the catalog rather than guessing a scope is a skill', async () => {
582
729
  dataMock.useLibraryData.mockReturnValue({ ...CATALOG, loading: true, skills: [], tools: [] });
583
730
  renderAt(itemUrl('Skills/Sales'));
584
- await waitFor(() => expect(screen.getByRole('button', { name: /^All plugins/ })).toBeInTheDocument());
731
+ await waitFor(() => expect(screen.getByRole('button', { name: /^Everything/ })).toBeInTheDocument());
585
732
  expect(screen.queryByLabelText('skill-page')).not.toBeInTheDocument();
586
733
  expect(screen.getByLabelText('pathname')).toHaveTextContent(itemUrl('Skills/Sales'));
587
734
  });
@@ -5,21 +5,21 @@ import { AuthContext, type AuthContextValue } from '../../auth/state/auth.contex
5
5
  /**
6
6
  * The signed-in user, for tests that render a Library surface.
7
7
  *
8
- * The Library names a person's own space after them ("Juan's Plugin"), so the
9
- * sidebar and the all-plugins index now read `useAuth`. In production that is
10
- * free — nothing under `CoreAppShell` renders before a user exists — but a
11
- * test that mounts a page in isolation has no provider above it, and `useAuth`
12
- * throws rather than returning null.
8
+ * Library surfaces read `useAuth` (the welcome page greets the person, the
9
+ * pages know whose items are theirs). In production that is free — nothing
10
+ * under `CoreAppShell` renders before a user exists — but a test that mounts
11
+ * a page in isolation has no provider above it, and `useAuth` throws rather
12
+ * than returning null.
13
13
  *
14
- * One harness rather than a provider pasted into each suite: the display name
15
- * is asserted in several files, and it should be one fact in one place.
14
+ * One harness rather than a provider pasted into each suite: the names are
15
+ * asserted in several files, and they should be one fact in one place.
16
16
  */
17
17
 
18
18
  /** The name every Library suite expects to see reflected back. */
19
19
  export const TEST_USER_NAME = 'Juan Viera';
20
20
 
21
- /** What `personalPluginName(TEST_USER_NAME)` produces — assert against this. */
22
- export const TEST_PERSONAL_GROUP = "Juan's Plugin";
21
+ /** What `personalPluginName()` produces — the own-space heading, one name for everyone. */
22
+ export const TEST_PERSONAL_GROUP = 'Personal plugin';
23
23
 
24
24
  export function authValue(over: Partial<AuthContextValue> = {}): AuthContextValue {
25
25
  return {