urbanopt-cli 0.10.0 → 0.11.0

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/battery.rb

@@ -1,12 +1,17 @@
+# *********************************************************************************
+# URBANopt (tm), Copyright (c) Alliance for Sustainable Energy, LLC.
+# See also https://github.com/urbanopt/urbanopt-cli/blob/develop/LICENSE.md
+# *********************************************************************************
+
 # frozen_string_literal: true
 
 class Battery
-  def self.apply(runner, model, pv_systems, battery, schedules_file)
+  def self.apply(runner, model, pv_systems, battery, schedules_file, unit_multiplier)
     charging_schedule = nil
     discharging_schedule = nil
     if not schedules_file.nil?
-      charging_schedule = schedules_file.create_schedule_file(col_name: SchedulesFile::ColumnBatteryCharging)
-      discharging_schedule = schedules_file.create_schedule_file(col_name: SchedulesFile::ColumnBatteryDischarging)
+      charging_schedule = schedules_file.create_schedule_file(model, col_name: SchedulesFile::ColumnBatteryCharging)
+      discharging_schedule = schedules_file.create_schedule_file(model, col_name: SchedulesFile::ColumnBatteryDischarging)
     end
 
     if pv_systems.empty? && charging_schedule.nil? && discharging_schedule.nil?
@@ -17,24 +22,29 @@ class Battery
     obj_name = battery.id
 
     rated_power_output = battery.rated_power_output # W
-    nominal_voltage = battery.nominal_voltage # V
     if not battery.nominal_capacity_kwh.nil?
       if battery.usable_capacity_kwh.nil?
         fail "UsableCapacity and NominalCapacity for Battery '#{battery.id}' must be in the same units."
       end
 
       nominal_capacity_kwh = battery.nominal_capacity_kwh # kWh
-      usable_fraction = battery.usable_capacity_kwh / nominal_capacity_kwh
+      usable_capacity_kwh = battery.usable_capacity_kwh
+      usable_fraction = usable_capacity_kwh / nominal_capacity_kwh
     else
       if battery.usable_capacity_ah.nil?
         fail "UsableCapacity and NominalCapacity for Battery '#{battery.id}' must be in the same units."
       end
 
-      nominal_capacity_kwh = get_kWh_from_Ah(battery.nominal_capacity_ah, nominal_voltage) # kWh
+      nominal_capacity_kwh = get_kWh_from_Ah(battery.nominal_capacity_ah, battery.nominal_voltage) # kWh
+      usable_capacity_kwh = get_kWh_from_Ah(battery.usable_capacity_ah, battery.nominal_voltage) # kWh
       usable_fraction = battery.usable_capacity_ah / battery.nominal_capacity_ah
     end
 
-    return if rated_power_output <= 0 || nominal_capacity_kwh <= 0 || nominal_voltage <= 0
+    return if rated_power_output <= 0 || nominal_capacity_kwh <= 0 || battery.nominal_voltage <= 0
+
+    nominal_capacity_kwh *= unit_multiplier
+    usable_capacity_kwh *= unit_multiplier
+    rated_power_output *= unit_multiplier
 
     is_outside = (battery.location == HPXML::LocationOutside)
     if not is_outside
@@ -46,7 +56,7 @@ class Battery
     default_nominal_cell_voltage = 3.342 # V, EnergyPlus default
     default_cell_capacity = 3.2 # Ah, EnergyPlus default
 
-    number_of_cells_in_series = Integer((nominal_voltage / default_nominal_cell_voltage).round)
+    number_of_cells_in_series = Integer((battery.nominal_voltage / default_nominal_cell_voltage).round)
     number_of_strings_in_parallel = Integer(((nominal_capacity_kwh * 1000.0) / ((default_nominal_cell_voltage * number_of_cells_in_series) * default_cell_capacity)).round)
     battery_mass = (nominal_capacity_kwh / 10.0) * 99.0 # kg
     battery_surface_area = 0.306 * (nominal_capacity_kwh**(2.0 / 3.0)) # m^2
@@ -64,7 +74,7 @@ class Battery
 
     elcs = OpenStudio::Model::ElectricLoadCenterStorageLiIonNMCBattery.new(model, number_of_cells_in_series, number_of_strings_in_parallel, battery_mass, battery_surface_area)
     elcs.setName("#{obj_name} li ion")
-    unless is_outside
+    if not is_outside
       elcs.setThermalZone(battery.additional_properties.space.thermalZone.get)
     end
     elcs.setRadiativeFraction(0.9 * frac_sens)
@@ -80,7 +90,7 @@ class Battery
     elcs.setCellVoltageatEndofNominalZone(default_nominal_cell_voltage)
     if not voltage_dependence
       elcs.setBatteryCellInternalElectricalResistance(0.002) # 2 mOhm/cell, based on OCHRE defaults (which are based on fitting to lab results)
-      # FIXME: if the voltage reported during charge/discharge is different, energy may not balance
+      # Note: if the voltage reported during charge/discharge is different, energy may not balance
       # elcs.setFullyChargedCellVoltage(default_nominal_cell_voltage)
       # elcs.setCellVoltageatEndofExponentialZone(default_nominal_cell_voltage)
     end
@@ -130,9 +140,13 @@ class Battery
     charge_sensor.setName('battery_charge')
     charge_sensor.setKeyName(elcs.name.to_s)
 
+    discharge_sensor = OpenStudio::Model::EnergyManagementSystemSensor.new(model, 'Electric Storage Discharge Energy')
+    discharge_sensor.setName('battery_discharge')
+    discharge_sensor.setKeyName(elcs.name.to_s)
+
     loss_adj_object_def = OpenStudio::Model::OtherEquipmentDefinition.new(model)
     loss_adj_object = OpenStudio::Model::OtherEquipment.new(loss_adj_object_def)
-    obj_name = Constants.ObjectNameBatteryLossesAdjustment(elcs.name)
+    obj_name = Constants.ObjectNameBatteryLossesAdjustment
     loss_adj_object.setName(obj_name)
     loss_adj_object.setEndUseSubcategory(obj_name)
     loss_adj_object.setFuelType(EPlus.fuel_type(HPXML::FuelTypeElectricity))
@@ -143,13 +157,16 @@ class Battery
     loss_adj_object_def.setFractionLatent(0)
     loss_adj_object_def.setFractionLost(frac_lost)
     loss_adj_object.setSchedule(model.alwaysOnDiscreteSchedule)
+    loss_adj_object.additionalProperties.setFeature('ObjectType', Constants.ObjectNameBatteryLossesAdjustment)
 
     battery_adj_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(loss_adj_object, *EPlus::EMSActuatorOtherEquipmentPower, loss_adj_object.space.get)
     battery_adj_actuator.setName('battery loss_adj_act')
 
     battery_losses_program = OpenStudio::Model::EnergyManagementSystemProgram.new(model)
     battery_losses_program.setName('battery_losses')
-    battery_losses_program.addLine("Set losses = -1 * #{charge_sensor.name} * (1 - #{battery.round_trip_efficiency})")
+    battery_losses_program.addLine("Set charge_losses = (-1 * #{charge_sensor.name} * (1 - (#{battery.round_trip_efficiency} ^ 0.5))) / #{unit_multiplier}")
+    battery_losses_program.addLine("Set discharge_losses = (-1 * #{discharge_sensor.name} * (1 - (#{battery.round_trip_efficiency} ^ 0.5))) / #{unit_multiplier}")
+    battery_losses_program.addLine('Set losses = charge_losses + discharge_losses')
     battery_losses_program.addLine("Set #{battery_adj_actuator.name} = -1 * losses / ( 3600 * SystemTimeStep )")
 
     battery_losses_pcm = OpenStudio::Model::EnergyManagementSystemProgramCallingManager.new(model)
@@ -157,12 +174,9 @@ class Battery
     battery_losses_pcm.setCallingPoint('EndOfSystemTimestepBeforeHVACReporting')
     battery_losses_pcm.addProgram(battery_losses_program)
 
-    battery_losses_output_var = OpenStudio::Model::EnergyManagementSystemOutputVariable.new(model, 'losses')
-    battery_losses_output_var.setName("#{Constants.ObjectNameBatteryLossesAdjustment(elcs.name)} outvar")
-    battery_losses_output_var.setTypeOfDataInVariable('Summed')
-    battery_losses_output_var.setUpdateFrequency('SystemTimestep')
-    battery_losses_output_var.setEMSProgramOrSubroutineName(battery_losses_program)
-    battery_losses_output_var.setUnits('J')
+    elcd.additionalProperties.setFeature('HPXML_ID', battery.id)
+    elcs.additionalProperties.setFeature('HPXML_ID', battery.id)
+    elcs.additionalProperties.setFeature('UsableCapacity_kWh', Float(usable_capacity_kwh))
   end
 
   def self.get_battery_default_values(has_garage = false)
@@ -186,4 +200,15 @@ class Battery
   def self.get_kWh_from_Ah(nominal_capacity_ah, nominal_voltage)
     return nominal_capacity_ah * nominal_voltage / 1000.0
   end
+
+  def self.get_usable_capacity_kWh(battery)
+    usable_capacity_kwh = battery.usable_capacity_kwh
+    if usable_capacity_kwh.nil?
+      usable_capacity_kwh = get_kWh_from_Ah(battery.usable_capacity_ah, battery.nominal_voltage) # kWh
+    end
+    return usable_capacity_kwh
+  end
+
+  def self.get_min_max_state_of_charge()
+  end
 end

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/constants.rb

@@ -1,3 +1,8 @@
+# *********************************************************************************
+# URBANopt (tm), Copyright (c) Alliance for Sustainable Energy, LLC.
+# See also https://github.com/urbanopt/urbanopt-cli/blob/develop/LICENSE.md
+# *********************************************************************************
+
 # frozen_string_literal: true
 
 class Constants
@@ -86,34 +91,18 @@ class Constants
             '4A', '4B', '4C', '5A', '5B', '5C', '6A', '6B', '6C', '7', '8']
   end
 
-  def self.IsDuctLoadForReport
-    return __method__.to_s
-  end
-
-  def self.ObjectNameAirflow
-    return 'airflow'
-  end
-
   def self.ObjectNameAirSourceHeatPump
     return 'air source heat pump'
   end
 
-  def self.ObjectNameBackupHeatingCoil
-    return 'backup htg coil'
-  end
-
-  def self.ObjectNameBatteryLossesAdjustment(battery_name)
-    return "#{battery_name} losses adjustment"
+  def self.ObjectNameBatteryLossesAdjustment
+    return 'battery losses adjustment'
   end
 
   def self.ObjectNameBoiler
     return 'boiler'
   end
 
-  def self.ObjectNameBoilerPilotLight(boiler_name)
-    return "#{boiler_name} pilot light"
-  end
-
   def self.ObjectNameCeilingFan
     return 'ceiling fan'
   end
@@ -134,10 +123,6 @@ class Constants
     return 'clothes dryer'
   end
 
-  def self.ObjectNameClothesDryerExhaust
-    return 'clothes dryer exhaust'
-  end
-
   def self.ObjectNameComponentLoadsProgram
     return 'component loads program'
   end
@@ -146,22 +131,10 @@ class Constants
     return 'cooking range'
   end
 
-  def self.ObjectNameCoolingSeason
-    return 'cooling season'
-  end
-
-  def self.ObjectNameCoolingSetpoint
-    return 'cooling setpoint'
-  end
-
   def self.ObjectNameDehumidifier
     return 'dehumidifier'
   end
 
-  def self.ObjectNameDesuperheater(water_heater_name)
-    return "#{water_heater_name} Desuperheater"
-  end
-
   def self.ObjectNameDishwasher
     return 'dishwasher'
   end
@@ -170,36 +143,28 @@ class Constants
     return 'dhw distribution waste'
   end
 
-  def self.ObjectNameDucts
-    return 'ducts'
+  def self.ObjectNameDuctLoad
+    return 'duct load'
   end
 
   def self.ObjectNameElectricBaseboard
-    return 'baseboard'
-  end
-
-  def self.ObjectNameERVHRV
-    return 'erv or hrv'
+    return 'electric baseboard'
   end
 
   def self.ObjectNameEvaporativeCooler
     return 'evap cooler'
   end
 
-  def self.ObjectNameExteriorLighting
-    return 'exterior lighting'
-  end
-
-  def self.ObjectNameFanPumpDisaggregateCool(fan_or_pump_name = '')
-    return "#{fan_or_pump_name} clg disaggregate"
+  def self.ObjectNameFanPumpDisaggregateCool
+    return 'disaggregate clg'
   end
 
-  def self.ObjectNameFanPumpDisaggregatePrimaryHeat(fan_or_pump_name = '')
-    return "#{fan_or_pump_name} htg primary disaggregate"
+  def self.ObjectNameFanPumpDisaggregatePrimaryHeat
+    return 'disaggregate htg primary'
   end
 
-  def self.ObjectNameFanPumpDisaggregateBackupHeat(fan_or_pump_name = '')
-    return "#{fan_or_pump_name} htg backup disaggregate"
+  def self.ObjectNameFanPumpDisaggregateBackupHeat
+    return 'disaggregate htg backup'
   end
 
   def self.ObjectNameFixtures
@@ -214,42 +179,22 @@ class Constants
     return 'furnace'
   end
 
-  def self.ObjectNamePTACHeating
-    return 'ptac heating'
-  end
-
-  def self.ObjectNameRoomACHeating
-    return 'room ac heating'
-  end
-
-  def self.ObjectNameFurniture
-    return 'furniture'
-  end
-
-  def self.ObjectNameGarageLighting
-    return 'garage lighting'
-  end
-
   def self.ObjectNameGroundSourceHeatPump
     return 'ground source heat pump'
   end
 
-  def self.ObjectNameGSHPSharedPump()
+  def self.ObjectNameGSHPSharedPump
     return 'gshp shared loop pump'
   end
 
-  def self.ObjectNameHeatingSeason
-    return 'heating season'
-  end
-
-  def self.ObjectNameHeatingSetpoint
-    return 'heating setpoint'
-  end
-
   def self.ObjectNameHotWaterRecircPump
     return 'dhw recirc pump'
   end
 
+  def self.ObjectNameHVACAvailabilitySensor
+    return 'hvac availability sensor'
+  end
+
   def self.ObjectNameIdealAirSystem
     return 'ideal air system'
   end
@@ -258,14 +203,22 @@ class Constants
     return 'infil'
   end
 
-  def self.ObjectNameInteriorLighting
-    return 'interior lighting'
+  def self.ObjectNameLightingExterior
+    return 'exterior lighting'
   end
 
   def self.ObjectNameLightingExteriorHoliday
     return 'exterior holiday lighting'
   end
 
+  def self.ObjectNameLightingGarage
+    return 'garage lighting'
+  end
+
+  def self.ObjectNameLightingInterior
+    return 'interior lighting'
+  end
+
   def self.ObjectNameMechanicalVentilation
     return 'mech vent'
   end
@@ -338,12 +291,12 @@ class Constants
     return 'misc pool pump'
   end
 
-  def self.ObjectNameMiscHotTubHeater
-    return 'misc hot tub heater'
+  def self.ObjectNameMiscPermanentSpaHeater
+    return 'misc permanent spa heater'
   end
 
-  def self.ObjectNameMiscHotTubPump
-    return 'misc hot tub pump'
+  def self.ObjectNameMiscPermanentSpaPump
+    return 'misc permanent spa pump'
   end
 
   def self.ObjectNameMiscPlugLoads
@@ -374,42 +327,18 @@ class Constants
     return 'occupants'
   end
 
-  def self.ObjectNameOverhangs
-    return 'overhangs'
-  end
-
-  def self.ObjectNamePlantLoopDHW
-    return 'dhw loop'
-  end
-
-  def self.ObjectNamePlantLoopSHW
-    return 'solar hot water loop'
-  end
-
   def self.ObjectNameRefrigerator
     return 'fridge'
   end
 
-  def self.ObjectNameRelativeHumiditySetpoint
-    return 'rh setpoint'
-  end
-
   def self.ObjectNameRoomAirConditioner
     return 'room ac'
   end
 
-  def self.ObjectNameSkylightShade
-    return 'skylight shade'
-  end
-
   def self.ObjectNameSolarHotWater
     return 'solar hot water'
   end
 
-  def self.ObjectNameTankHX
-    return 'dhw source hx'
-  end
-
   def self.ObjectNameTotalLoadsProgram
     return 'total loads program'
   end
@@ -438,8 +367,8 @@ class Constants
     return 'water sensible'
   end
 
-  def self.ObjectNameWaterHeaterAdjustment(water_heater_name)
-    return "#{water_heater_name} EC adjustment"
+  def self.ObjectNameWaterHeaterAdjustment
+    return 'water heater energy adjustment'
   end
 
   def self.ObjectNameWaterLoopHeatPump
@@ -450,10 +379,6 @@ class Constants
     return 'whole house fan'
   end
 
-  def self.ObjectNameWindowShade
-    return 'window shade'
-  end
-
   def self.ScheduleTypeLimitsFraction
     return 'Fractional'
   end

data/example_files/resources/hpxml-measures/HPXMLtoOpenStudio/resources/constructions.rb

@@ -1,3 +1,8 @@
+# *********************************************************************************
+# URBANopt (tm), Copyright (c) Alliance for Sustainable Energy, LLC.
+# See also https://github.com/urbanopt/urbanopt-cli/blob/develop/LICENSE.md
+# *********************************************************************************
+
 # frozen_string_literal: true
 
 class Constructions
@@ -1090,7 +1095,7 @@ class Constructions
     # Add remaining partition walls within spaces (those without geometric representation)
     # as internal mass object.
     obj_name = 'partition wall mass'
-    imdef = create_os_int_mass_and_def(model, obj_name, spaces[HPXML::LocationLivingSpace], partition_wall_area)
+    imdef = create_os_int_mass_and_def(model, obj_name, spaces[HPXML::LocationConditionedSpace], partition_wall_area)
 
     apply_wood_stud_wall(model, [imdef], constr_name,
                          0, 1, 3.5, false, 0.16,
@@ -1118,7 +1123,7 @@ class Constructions
       furnSolarAbsorptance = 0.6
       furnSpecHeat = mat.cp
       furnDensity = mat.rho
-      if location == HPXML::LocationLivingSpace
+      if location == HPXML::LocationConditionedSpace
         furnAreaFraction = furniture_mass.area_fraction
         furnMass = mass_lb_per_sqft
       elsif location == HPXML::LocationBasementUnconditioned
@@ -1132,9 +1137,9 @@ class Constructions
       next if furnAreaFraction.nil?
       next if furnAreaFraction <= 0
 
-      mat_obj_name_space = "#{Constants.ObjectNameFurniture} material #{space.name}"
-      constr_obj_name_space = "#{Constants.ObjectNameFurniture} construction #{space.name}"
-      mass_obj_name_space = "#{Constants.ObjectNameFurniture} mass #{space.name}"
+      mat_obj_name_space = "furniture material #{space.name}"
+      constr_obj_name_space = "furniture construction #{space.name}"
+      mass_obj_name_space = "furniture mass #{space.name}"
 
       furnThickness = UnitConversions.convert(furnMass / (furnDensity * furnAreaFraction), 'ft', 'in')
 
@@ -1535,7 +1540,7 @@ class Constructions
       initial_temp = indoor_temp
     else
       # Space temperature assumptions from ASHRAE 152 - Duct Efficiency Calculations.xls, Zone temperatures
-      ground_temp = weather.data.GroundMonthlyTemps[sim_begin_month - 1]
+      ground_temp = weather.data.ShallowGroundMonthlyTemps[sim_begin_month - 1]
       if slab.interior_adjacent_to == HPXML::LocationBasementUnconditioned
         if foundation_ceiling_insulated
           # Insulated ceiling: 75% ground, 25% outdoor, 0% indoor
@@ -1617,103 +1622,59 @@ class Constructions
     constr.create_and_assign_constructions([subsurface], model)
   end
 
-  def self.apply_window_skylight_shading(model, window_or_skylight, index, shading_vertices, parent_surface, sub_surface, shading_group,
-                                         shading_schedules, shading_ems, name, hpxml)
+  def self.apply_window_skylight_shading(model, window_or_skylight, sub_surface, shading_schedules, hpxml_header, hpxml_bldg)
     sf_summer = window_or_skylight.interior_shading_factor_summer * window_or_skylight.exterior_shading_factor_summer
     sf_winter = window_or_skylight.interior_shading_factor_winter * window_or_skylight.exterior_shading_factor_winter
     if (sf_summer < 1.0) || (sf_winter < 1.0)
       # Apply shading
-      # We use a ShadingSurface instead of a Shade so that we perfectly get the result we want.
-      # The latter object is complex and it is essentially impossible to achieve the target reduction in transmitted
-      # solar (due to, e.g., re-reflectance, absorptance, angle modifiers, effects on convection, etc.).
-
-      # Shading surface is used to reduce beam solar and sky diffuse solar
-      shading_surface = OpenStudio::Model::ShadingSurface.new(shading_vertices, model)
-      shading_surface.setName("#{window_or_skylight.id} shading surface")
-      shading_surface.additionalProperties.setFeature('Azimuth', window_or_skylight.azimuth)
-      shading_surface.additionalProperties.setFeature('ParentSurface', parent_surface.name.to_s)
 
       # Determine transmittance values throughout the year
-      trans_values = []
-      num_days_in_year = Constants.NumDaysInYear(hpxml.header.sim_calendar_year)
-      if not hpxml.header.shading_summer_begin_month.nil?
-        summer_start_day_num = Schedule.get_day_num_from_month_day(hpxml.header.sim_calendar_year,
-                                                                   hpxml.header.shading_summer_begin_month,
-                                                                   hpxml.header.shading_summer_begin_day)
-        summer_end_day_num = Schedule.get_day_num_from_month_day(hpxml.header.sim_calendar_year,
-                                                                 hpxml.header.shading_summer_end_month,
-                                                                 hpxml.header.shading_summer_end_day)
+      sf_values = []
+      num_days_in_year = Constants.NumDaysInYear(hpxml_header.sim_calendar_year)
+      if not hpxml_bldg.header.shading_summer_begin_month.nil?
+        summer_start_day_num = Schedule.get_day_num_from_month_day(hpxml_header.sim_calendar_year,
+                                                                   hpxml_bldg.header.shading_summer_begin_month,
+                                                                   hpxml_bldg.header.shading_summer_begin_day)
+        summer_end_day_num = Schedule.get_day_num_from_month_day(hpxml_header.sim_calendar_year,
+                                                                 hpxml_bldg.header.shading_summer_end_month,
+                                                                 hpxml_bldg.header.shading_summer_end_day)
         for i in 0..(num_days_in_year - 1)
           day_num = i + 1
           if summer_end_day_num >= summer_start_day_num
             if (day_num >= summer_start_day_num) && (day_num <= summer_end_day_num)
-              trans_values << [sf_summer] * 24
+              sf_values << [sf_summer] * 24
               next
             end
           else
             if (day_num >= summer_start_day_num) || (day_num <= summer_end_day_num)
-              trans_values << [sf_summer] * 24
+              sf_values << [sf_summer] * 24
               next
             end
           end
           # If we got this far, winter
-          trans_values << [sf_winter] * 24
+          sf_values << [sf_winter] * 24
         end
       else
         # No summer (year-round winter)
-        trans_values = [[sf_winter] * 24] * num_days_in_year
+        sf_values = [[sf_winter] * 24] * num_days_in_year
       end
 
       # Create transmittance schedule
-      if shading_schedules[trans_values].nil?
+      if shading_schedules[sf_values].nil?
         sch_name = "trans schedule winter=#{sf_winter} summer=#{sf_summer}"
-        if trans_values.flatten.uniq.size == 1
-          trans_sch = OpenStudio::Model::ScheduleConstant.new(model)
-          trans_sch.setValue(trans_values[0][0])
-          trans_sch.setName(sch_name)
+        if sf_values.flatten.uniq.size == 1
+          sf_sch = OpenStudio::Model::ScheduleConstant.new(model)
+          sf_sch.setValue(sf_values[0][0])
+          sf_sch.setName(sch_name)
         else
-          trans_sch = HourlyByDaySchedule.new(model, sch_name, trans_values, trans_values, Constants.ScheduleTypeLimitsFraction, false).schedule
+          sf_sch = HourlyByDaySchedule.new(model, sch_name, sf_values, sf_values, Constants.ScheduleTypeLimitsFraction, false).schedule
         end
-        shading_schedules[trans_values] = trans_sch
-      end
-      shading_surface.setTransmittanceSchedule(shading_schedules[trans_values])
-
-      # EMS to actuate view factor to ground
-      sub_surface_type = sub_surface.subSurfaceType.downcase.to_s
-      actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(sub_surface, *EPlus::EMSActuatorSurfaceViewFactorToGround)
-      actuator.setName("#{sub_surface_type}#{index}_actuator")
-
-      if shading_ems[:sensors][trans_values].nil?
-        shading_schedule_name = shading_schedules[trans_values].name.to_s
-        shading_coeff_sensor = OpenStudio::Model::EnergyManagementSystemSensor.new(model, 'Schedule Value')
-        shading_coeff_sensor.setName("#{sub_surface_type}_shading_coefficient")
-        shading_coeff_sensor.setKeyName(shading_schedule_name)
-        shading_ems[:sensors][trans_values] = shading_coeff_sensor
+        shading_schedules[sf_values] = sf_sch
       end
 
-      default_vf_to_ground = ((1.0 - Math::cos(sub_surface.tilt)) / 2.0).round(2)
-      shading_coeff = shading_ems[:sensors][trans_values].name
-      if shading_ems[:program].nil?
-        program = OpenStudio::Model::EnergyManagementSystemProgram.new(model)
-        program.setName("#{sub_surface_type}_view_factor_to_ground_program")
-        program.addLine("Set #{actuator.name} = #{default_vf_to_ground}*#{shading_coeff}")
-        shading_ems[:program] = program
-
-        program_cm = OpenStudio::Model::EnergyManagementSystemProgramCallingManager.new(model)
-        program_cm.setName("#{program.name} calling manager")
-        program_cm.setCallingPoint('BeginZoneTimestepAfterInitHeatBalance') # https://github.com/NREL/EnergyPlus/pull/8477#discussion_r567320478
-        program_cm.addProgram(program)
-      else
-        shading_ems[:program].addLine("Set #{actuator.name} = #{default_vf_to_ground}*#{shading_coeff}")
-      end
-
-      if shading_group.nil?
-        shading_group = OpenStudio::Model::ShadingSurfaceGroup.new(model)
-        shading_group.setName(name)
-      end
-      shading_surface.setShadingSurfaceGroup(shading_group)
+      ism = OpenStudio::Model::SurfacePropertyIncidentSolarMultiplier.new(sub_surface)
+      ism.setIncidentSolarMultiplierSchedule(shading_schedules[sf_values])
     end
-    return shading_group
   end
 
   def self.calc_non_cavity_r(film_r, constr_set)