spree 0.8.5 → 0.9.0

data/test/unit/product_test.rb

@@ -0,0 +1,279 @@
+# These tests are organized into four product configuration quadrants as follows:
+#
+#   product
+#     w/o variants
+#         w/o inventory
+#         w/inventory
+#
+#   product
+#     w/variants
+#         w/o inventory
+#         w/inventory
+#
+# Reusable context taken from:
+#   http://www.viget.com/extend/reusing-contexts-in-shoulda-with-context-macros/
+#
+# Additionally, some basic tests for Product.new vs. Product.create are defined to test
+# that Product creation vs instantiated behave the normal "rails way"
+#
+require 'test_helper'
+
+class ProductTest < Test::Unit::TestCase
+
+  def self.should_pass_basic_tests
+    subject { @product }
+    should "have a product" do
+      assert @product.is_a?(Product)
+    end
+    should_validate_presence_of :name
+    should "have 'Foo Bar' as name" do
+      assert_equal @product.name, "Foo Bar"
+    end
+    should "have 'foo-bar' as permalink" do
+      assert_equal "foo-bar", @product.permalink
+    end
+    should "not change permalink when name changes" do
+      @product.update_attributes :name => 'Foo BaZ'
+      assert_equal @product.name, 'Foo BaZ'
+      assert_equal 'foo-bar', @product.permalink
+    end
+    should "not obscure deleted_at" do
+      assert true, @product.deleted_at.nil?
+    end
+    should "have a price" do
+      assert_equal 19.99, @product.price
+    end
+    should "have a master price" do
+      assert_equal @product.price, @product.master.price
+      assert_equal @product.price, @product.price # deprecated, to be removed
+    end
+    should "change master price when price changes" do
+      @product.update_attributes(:price => 30.0)
+      assert_equal @product.price, @product.master.price
+      assert_equal 30.0, @product.price
+    end
+    should "change price when master price changes" do
+      @product.master.update_attributes(:price => 50.0)
+      assert_equal @product.price, @product.master.price
+      assert_equal 50.0, @product.price
+    end
+    should "persist a master variant record" do
+      assert_equal @master_variant, @product.master
+    end
+    should "have a sku" do
+      assert_equal 'ABC', @product.sku
+    end
+    context "when sku is changed" do
+      setup { @product.sku = "NEWSKU" }
+      should_change("@product.sku", :from => "ABC", :to => "NEWSKU") { @product.sku }
+      should_change("@product.master.sku", :from => "ABC", :to => "NEWSKU") { @product.master.sku }
+    end
+  end
+
+  def self.context_created_product(&block)
+    context "Created Product" do
+      setup do
+        @product = Factory(:product, :name => "Foo Bar")
+        @master_variant = Variant.find_by_product_id(@product.id, :conditions => ["is_master = ?", true])
+      end
+      teardown do
+        @product.destroy
+      end
+
+      merge_block(&block) if block_given?
+    end
+  end
+
+  def self.context_without_variants(&block)
+    context "without variants" do
+      should_pass_basic_tests
+      should "return false for has_variants?" do
+        assert !@product.has_variants?
+      end
+
+      merge_block(&block) if block_given?
+    end
+  end
+
+  def self.context_with_variants(&block)
+    context "with variants" do
+      setup do
+        @product.variants << Factory(:variant)
+        @first_variant = @product.variants.first
+      end
+      teardown { @first_variant.destroy }
+      should_pass_basic_tests
+      should "have variants" do
+        assert @product.has_variants?
+        assert @first_variant.is_a?(Variant)
+      end
+      should "return true for has_variants?" do
+        assert @product.has_variants?
+      end
+
+      merge_block(&block) if block_given?
+    end
+  end
+
+  def self.context_without_inventory_units(&block)
+    context "without inventory units" do
+      should_pass_basic_tests
+      should "return zero on_hand value" do
+        assert_equal 0, @product.on_hand
+      end
+      should "return true for master.has_stock?" do
+        assert !@product.master.in_stock?
+      end
+      should "return false for has_stock?" do
+        assert !@product.has_stock?
+      end
+
+      merge_block(&block) if block_given?
+    end
+  end
+
+  def self.should_pass_inventory_tests
+    should "return true for has_stock?" do
+      assert @product.has_stock?
+    end
+    should "have on_hand greater than zero" do
+      assert @product.on_hand > 0
+    end
+  end
+
+  context "New Product" do
+    setup do
+      @product = Factory.build(:product)
+    end
+
+    should_not_change("Product.count") { Product.count }
+    should_not_change("Variant.count") { Variant.count }
+    should "not have a product id" do
+      assert @product.id.nil?
+    end
+  end
+
+  context "New Product instantiated with on_hand" do
+    setup do
+      @product = Product.new(:name => "fubaz", :price => "10.0", :on_hand => 5)
+    end
+    should "not have a product id" do
+      assert @product.id.nil?
+    end
+    should_not_change("Product.count") { Product.count }
+    should_not_change("Variant.count") { Variant.count }
+    should_not_change("InventoryUnit.count") { InventoryUnit.count }
+    should "have a Product class" do
+      assert @product.is_a?(Product)
+    end
+    should "have specified on_hand" do
+      assert_equal 5, @product.on_hand
+    end
+  end
+
+  context "Product created with on_hand" do
+    setup do
+      @product = Product.create(:name => "fubaz", :price => "10.0", :on_hand => 7)
+    end
+    teardown do
+      @product.master.inventory_units.destroy_all
+      @product.destroy
+    end
+    should_change("InventoryUnit.count", :by => 7) { InventoryUnit.count }
+  end
+
+  context_created_product do
+    context_without_variants do
+      context_without_inventory_units do
+
+      end
+      context "with inventory units" do
+        setup { @product.master.inventory_units << Factory(:inventory_unit) }
+        teardown { @product.master.inventory_units.destroy_all }
+        should_pass_inventory_tests
+        should "be true for has_stock?" do
+          assert @product.has_stock?
+          assert @product.master.in_stock?
+        end
+        context "when on_hand is increased" do
+          setup { @product.update_attribute("on_hand", 5) }
+          should_change("InventoryUnit.count", :by => 4) { InventoryUnit.count }
+          should "have the specified on_hand" do
+            assert_equal 5, @product.on_hand
+          end
+        end
+        context "when on_hand is decreased" do
+          setup { @product.on_hand = 3 }
+          should_change("InventoryUnit.count", :by => 2) { InventoryUnit.count }
+          should "have the specified on_hand" do
+            assert_equal 3, @product.on_hand
+          end
+        end
+      end
+    end
+  end
+
+  context_created_product do
+    context_with_variants do
+      context_without_inventory_units
+      context "with inventory units" do
+        setup do
+          @first_variant.inventory_units << Factory(:inventory_unit)
+        end
+        teardown { @first_variant.inventory_units.destroy_all }
+        should_pass_inventory_tests
+        should "be true for has_stock?" do
+          assert !@product.master.in_stock?
+          assert @first_variant.in_stock?
+          assert @product.has_stock?
+        end
+        should "have one inventory unit initially" do
+          assert 1, @first_variant.inventory_units.count
+        end
+        context "when on_hand is increased" do
+          setup { @first_variant.on_hand = 5 }
+          should_change("InventoryUnit.count", :by => 4) { InventoryUnit.count }
+          should "have the specified on_hand" do
+            assert_equal 5, @product.on_hand
+          end
+        end
+        context "when on_hand is decreased" do
+          setup { @first_variant.on_hand = 3 }
+          should_change("InventoryUnit.count", :by => 2) { InventoryUnit.count }
+          should "have the specified on_hand" do
+            assert_equal 3, @product.on_hand
+          end
+        end
+      end
+    end
+  end
+
+  context "Product.available" do
+    setup do
+      5.times { Factory(:product, :available_on => Time.now - 1.day) }
+      Factory(:product, :available_on => Time.now - 15.minutes)
+      @future_product = Factory.create(:product, :available_on => Time.now + 2.weeks)
+    end
+    teardown do
+      Product.available.destroy_all
+      @future_product.destroy
+    end
+    should "only include available products" do
+      assert_equal 6, Product.available.size
+      assert !Product.available.include?(@future_product)
+    end
+  end
+
+  context "instance" do
+    setup { @product = Factory(:product, :price => 19.99) }
+    context "with a change in price" do
+      setup do
+        @product.price = 1.11
+        @product.save
+      end
+      should "change the save the new master price" do
+        assert_equal BigDecimal.new("1.11"), @product.reload.price
+      end
+    end
+  end
+end

data/test/unit/sales_tax_calculator_test.rb

@@ -0,0 +1,46 @@
+require 'test_helper'
+class SalesTaxCalculatorTest < ActiveSupport::TestCase
+  context "Calculator::SalesTax" do 
+    should "be available to TaxRate" do
+      assert TaxRate.calculators.include?(Calculator::SalesTax)
+    end
+    should "not be available to ShippingMethod" do
+      assert !Coupon.calculators.include?(Calculator::SalesTax)
+    end
+    should "not be available to Coupon" do
+      assert !ShippingMethod.calculators.include?(Calculator::SalesTax)
+    end
+
+    context "compute" do
+      setup do
+        @order = Factory(:order)
+        @tax_category = TaxCategory.create(:name => "foo") 
+        @taxable = Factory(:product, :tax_category => @tax_category)
+        @non_taxable = Factory(:product, :tax_category => nil)
+      end
+
+      context "for order where no line item contains a taxable product" do                                                                 
+        setup do 
+          @order.line_items = [Factory(:line_item, :variant => Factory(:variant, :product => @non_taxable))]
+          @calculator = Calculator::SalesTax.new(:calculable => Factory(:tax_rate))
+        end
+        should "return zero if none of the line items contains a taxable product" do
+          assert_equal 0, @calculator.compute(@order)
+        end
+      end       
+
+      context "for order with some taxable items" do
+        setup do             
+          @order.line_items = [Factory(:line_item, :variant => Factory(:variant, :product => @taxable), :price => 10, :quantity => 10), 
+                               Factory(:line_item, :variant => Factory(:variant, :product => @non_taxable))] 
+          @calculator = Calculator::SalesTax.new(:calculable => TaxRate.new(:amount => 0.05, :tax_category => @tax_category))
+        end
+        should "tax only the taxable line items" do
+          assert_equal 5, @calculator.compute(@order)
+        end
+      end
+
+    end
+
+  end
+end

data/test/unit/shipping_method_test.rb

@@ -0,0 +1,21 @@
+require 'test_helper'
+
+class ShippingMethodTest < ActiveSupport::TestCase
+  context "instance" do
+    setup do 
+      create_complete_order
+    end
+    context "when calculator indicates method is supported" do
+      should "be available" do
+        assert(@zone.include?(@order.shipment.address), "Zone doesn't include address")
+        assert(@shipping_method.calculator)
+        assert @shipping_method.available?(@order)
+      end
+      context "when the shipping address falls within the method's zone" do
+        should "return the amount as calculated by the method's calculator" do
+          assert_equal BigDecimal.new("10.0"), @shipping_method.calculate_cost(@order.shipment)
+        end      
+      end
+    end
+  end                 
+end

data/test/unit/state_event_test.rb

@@ -0,0 +1,40 @@
+require 'test_helper'
+
+class StateEventTest < ActiveSupport::TestCase
+  context "Order" do
+    setup do
+      @order = Factory(:order)
+    end
+
+    context "when completed" do
+      setup { @order.complete! }
+      should_change("StateEvent.count", :by => 1) { StateEvent.count }
+      should_change("@order.state", :from => "in_progress", :to => "new") { @order.state }
+
+      context "then canceled" do
+        setup { @order.cancel! }
+        should_change("StateEvent.count", :by => 1) { StateEvent.count }
+        should_change("@order.state", :from => "new", :to => "canceled") { @order.state }
+
+        should "allow resuming" do
+          assert @order.can_resume?, "Order can't be resumed(and it should!)"
+        end
+
+        context "then resumed" do
+          setup { @order.resume! }
+
+          should_change("StateEvent.count", :by => 1) { StateEvent.count }
+          should_change("@order.state", :from => "canceled", :to => "new") { @order.state }
+        end
+      end
+
+      context "then paid" do
+        setup do
+          Payment.create!({:amount => @order.total, :order => @order})
+        end
+
+        should_change("@order.state", :from => "new", :to => "paid") { @order.state }
+      end
+    end
+  end
+end

data/test/unit/state_test.rb

@@ -0,0 +1,7 @@
+require 'test_helper'
+
+class StateTest < ActiveSupport::TestCase
+  should_validate_presence_of :country
+  should_validate_presence_of :name
+  should_allow_values_for :abbr, "NY"  
+end

data/test/unit/tax_rate_test.rb

@@ -0,0 +1,9 @@
+require 'test_helper'
+
+class TaxRateTest < Test::Unit::TestCase  
+  should_belong_to :zone
+  should_belong_to :tax_category
+  #should_validate_presence_of :tax_type, :message => /should be Sales Tax and Vat/
+  should_validate_presence_of :amount
+  should_validate_numericality_of :amount
+end

data/test/unit/variant_test.rb

@@ -0,0 +1,128 @@
+require 'test_helper'
+
+class VariantTest < Test::Unit::TestCase
+
+  context "A new Variant" do
+    context "without inventory units" do
+      setup { @variant = Variant.new }
+      should "not have inventory units" do
+        assert 0, @variant.inventory_units.size
+      end
+      should "on_hand should be zero" do
+        assert 0, @variant.on_hand
+      end
+    end
+
+    context "with specified on_hand" do
+      setup { @variant = Variant.new(:on_hand => 5) }
+      should "have inventory units" do
+        assert 5, @variant.inventory_units.size
+      end
+      should "on_hand should match specified units" do
+        assert 5, @variant.on_hand
+      end
+      should_not_change("InventoryUnit.count") { InventoryUnit.count }
+    end
+  end
+
+  context "Variant.create" do
+    setup { @product = Factory(:product, :price => 10.99) }
+    teardown { @product.destroy }
+    context "with price specified" do
+      setup do
+        @variant = Variant.create(:product => @product, :name => 'foo bar', :price => 11.33)
+      end
+      teardown { @variant.destroy }
+      should "ignore the product's master price" do
+        assert_in_delta @variant.price, 11.33, 0.00001
+      end
+      should_not_change("InventoryUnit.count") { InventoryUnit.count }
+    end
+    context "with no price specified" do
+      setup do
+        @variant = Variant.create(:product => @product)
+      end
+      teardown { @variant.destroy }
+      should "use the product's master price" do
+        assert_in_delta @variant.price, 10.99, 0.00001
+      end
+      should_not_change("InventoryUnit.count") { InventoryUnit.count }
+    end
+    context "with specified inventory level" do
+      setup do
+        @variant = Variant.create(:product => @product, :on_hand => 3)
+      end
+      teardown do
+        @variant.inventory_units.destroy_all
+        @variant.destroy
+      end
+      should "adjust inventory levels" do
+        on_hand = @variant.on_hand
+        @variant.on_hand = 3
+        assert_equal 3, @variant.on_hand
+      end
+
+      should_change("InventoryUnit.count", :by => 3) { InventoryUnit.count }
+    end
+  end
+  context "Variant instance with 1 unit of inventory" do
+    setup do
+      @variant = Factory(:variant)
+      @variant.inventory_units << Factory(:inventory_unit)
+    end
+    teardown do
+      @variant.inventory_units.destroy_all
+      @variant.destroy
+    end
+    should "return true for in_stock?" do
+      assert @variant.in_stock?
+    end
+    context "when on_hand is increased" do
+      setup { @variant.update_attribute("on_hand", 5) }
+      should_change("InventoryUnit.count", :by => 4) { InventoryUnit.count }
+      should "return correct amount for on_hand" do
+        assert_equal 5, @variant.on_hand
+      end
+    end
+    context "when on_hand is changed to 0 and backorders are NOT allowed" do
+      setup do
+        @variant.update_attribute("on_hand", "0")
+        Spree::Config.set(:allow_backorders => false)
+      end
+      teardown do
+        @variant.inventory_units.destroy_all
+        @variant.destroy
+      end
+      should_change("InventoryUnit.count", :by => -1) { InventoryUnit.count }
+      should "return correct amount for on_hand" do
+        assert_equal 0, @variant.on_hand
+      end
+      should "return false for in_stock?" do
+        assert !@variant.in_stock?
+      end
+      should "return false for available?" do
+        assert !@variant.available?
+      end
+    end
+    context "when on_hand is changed to 0 and backorders are allowed" do
+      setup do
+        @variant.update_attribute("on_hand", "0")
+        Spree::Config.set(:allow_backorders => true)
+      end
+      teardown do
+        @variant.inventory_units.destroy_all
+        @variant.destroy
+      end
+      should_change("InventoryUnit.count", :by => -1) { InventoryUnit.count }
+      should "return correct amount for on_hand" do
+        assert_equal 0, @variant.on_hand
+      end
+      should "return false for in_stock?" do
+        assert !@variant.in_stock?
+      end
+      should "return false for available?" do
+        assert @variant.available?
+      end
+    end
+  end
+end