scss-lint 0.25.1 → 0.26.0

data/spec/scss_lint/linter/empty_rule_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::EmptyRule do
+  context 'when rule is empty' do
+    let(:css) { <<-CSS }
+      p {
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule contains an empty nested rule' do
+    let(:css) { <<-CSS }
+      p {
+        background: #000;
+        display: none;
+        margin: 5px;
+        padding: 10px;
+        a {
+        }
+      }
+    CSS
+
+    it { should report_lint line: 6 }
+  end
+end

data/spec/scss_lint/linter/final_newline_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::FinalNewline do
+  let(:linter_config) { { 'present' => present } }
+
+  context 'when trailing newline is preferred' do
+    let(:present) { true }
+
+    context 'when the file is empty' do
+      let(:css) { '' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the file ends with a newline' do
+      let(:css) { "p {}\n" }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the file does not end with a newline' do
+      let(:css) { 'p {}' }
+
+      it { should report_lint }
+    end
+  end
+
+  context 'when no trailing newline is preferred' do
+    let(:present) { false }
+
+    context 'when the file is empty' do
+      let(:css) { '' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the file ends with a newline' do
+      let(:css) { "p {}\n" }
+
+      it { should report_lint }
+    end
+
+    context 'when the file does not end with a newline' do
+      let(:css) { 'p {}' }
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/hex_length_spec.rb

@@ -0,0 +1,104 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::HexLength do
+  let(:linter_config) { { 'style' => style } }
+  let(:style) { 'short' }
+
+  context 'when rule is empty' do
+    let(:css) { <<-CSS }
+      p {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains properties with valid hex code' do
+    let(:css) { <<-CSS }
+      p {
+        color: #1234ab;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when ID selector starts with a hex code' do
+    let(:css) { <<-CSS }
+      #aabbcc {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when color is specified as a color keyword' do
+    let(:css) { <<-CSS }
+      p {
+        @include box-shadow(0 0 1px 1px gold);
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when short style is preferred' do
+    let(:style) { 'short' }
+
+    context 'with short hex code' do
+      let(:css) { <<-CSS }
+        p {
+          background: #ccc;
+          background: #CCC;
+          @include crazy-color(#fff);
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'with long hex code that could be condensed to 3 digits' do
+      let(:css) { <<-CSS }
+        p {
+          background: #cccccc;
+          background: #CCCCCC;
+          @include crazy-color(#ffffff);
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+  end
+
+  context 'when long style is preferred' do
+    let(:style) { 'long' }
+
+    context 'with long hex code that could be condensed to 3 digits' do
+      let(:css) { <<-CSS }
+        p {
+          background: #cccccc;
+          background: #CCCCCC;
+          @include crazy-color(#ffffff);
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'with short hex code' do
+      let(:css) { <<-CSS }
+        p {
+          background: #ccc;
+          background: #CCC;
+          @include crazy-color(#fff);
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+  end
+end

data/spec/scss_lint/linter/hex_notation_spec.rb

@@ -0,0 +1,104 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::HexNotation do
+  let(:linter_config) { { 'style' => style } }
+  let(:style) { nil }
+
+  context 'when rule is empty' do
+    let(:css) { <<-CSS }
+      p {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains color keyword' do
+    let(:css) { <<-CSS }
+      p {
+        border-color: red;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'lowercase style' do
+    let(:style) { 'lowercase' }
+
+    context 'when rule contains properties with lowercase hex code' do
+      let(:css) { <<-CSS }
+        p {
+          background: #ccc;
+          color: #cccccc;
+          @include crazy-color(#fff);
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'with uppercase hex codes' do
+      let(:css) { <<-CSS }
+        p {
+          background: #CCC;
+          color: #CCCCCC;
+          @include crazy-color(#FFF);
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+  end
+
+  context 'uppercase style' do
+    let(:style) { 'uppercase' }
+
+    context 'with uppercase hex codes' do
+      let(:css) { <<-CSS }
+        p {
+          background: #CCC;
+          color: #CCCCCC;
+          @include crazy-color(#FFF);
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when rule contains properties with lowercase hex code' do
+      let(:css) { <<-CSS }
+        p {
+          background: #ccc;
+          color: #cccccc;
+          @include crazy-color(#fff);
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+  end
+
+  context 'when ID selector starts with a hex code' do
+    let(:css) { <<-CSS }
+      #aabbcc {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when color is specified as a color keyword' do
+    let(:css) { <<-CSS }
+      p {
+        @include box-shadow(0 0 1px 1px gold);
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/hex_validation_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::HexValidation do
+  context 'when rule is empty' do
+    let(:css) { <<-CSS }
+      p {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains valid hex codes or color keyword' do
+    let(:css) { <<-CSS }
+      p {
+        background: #000;
+        color: #FFFFFF;
+        border-color: red;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains invalid hex codes' do
+    let(:css) { <<-CSS }
+      p {
+        background: #dd;
+        color: #dddd;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+  end
+end

data/spec/scss_lint/linter/id_with_extraneous_selector_spec.rb

@@ -0,0 +1,139 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::IdWithExtraneousSelector do
+  context 'when rule is just a type' do
+    let(:css) { <<-CSS }
+      p {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is just an ID' do
+    let(:css) { <<-CSS }
+      #identifier {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is just a class' do
+    let(:css) { <<-CSS }
+      .class {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is a type with a class' do
+    let(:css) { <<-CSS }
+      a.class {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is a type with an ID' do
+    let(:css) { <<-CSS }
+      a#identifier {
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule is an ID with a pseudo' do
+    let(:css) { <<-CSS }
+      #identifier:active {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is a type with an ID with a pseudo' do
+    let(:css) { <<-CSS }
+      a#identifier:active {
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule contains multiple selectors' do
+    context 'when all of the selectors are just IDs, classes, or types' do
+      let(:css) { <<-CSS }
+        #identifier,
+        .class,
+        a {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when one of the rules is an ID with a pseudo' do
+      let(:css) { <<-CSS }
+        #identifier:active,
+        .class {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when one of the rules is a type with an ID with a pseudo' do
+      let(:css) { <<-CSS }
+        a#identifier:active,
+        .class {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when one of the selectors is a type and class' do
+      let(:css) { <<-CSS }
+        #identifier,
+        a.class {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when one of the selectors is a type and ID' do
+      let(:css) { <<-CSS }
+        #identifier,
+        a#my-id {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when rule contains a nested rule with type and ID' do
+    let(:css) { <<-CSS }
+      p {
+        a#identifier {
+        }
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when selector contains a class and ID' do
+    let(:css) { <<-CSS }
+      #id.class {
+      }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+end