scss-lint 0.25.1 → 0.26.0

data/spec/scss_lint/linter/space_between_parens_spec.rb

@@ -0,0 +1,263 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SpaceBetweenParens do
+  context 'when the opening parens is followed by a space' do
+    let(:css) { <<-CSS }
+      p {
+        property: ( value);
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when the closing parens is preceded by a space' do
+    let(:css) { <<-CSS }
+      p {
+        property: (value );
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when both parens are space padded' do
+    let(:css) { <<-CSS }
+      p {
+        property: ( value );
+      }
+    CSS
+
+    it { should report_lint line: 2, count: 2 }
+  end
+
+  context 'when neither parens are space padded' do
+    let(:css) { <<-CSS }
+      p {
+        property: (value);
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when parens are multi-line' do
+    let(:css) { <<-CSS }
+      p {
+        property: (
+          value
+        );
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when parens are multi-line with tabs' do
+    let(:css) { <<-CSS }
+\t\t\tp {
+\t\t\t\tproperty: (
+\t\t\t\t\tvalue
+\t\t\t\t);
+\t\t\t}
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when outer parens are space padded' do
+    let(:css) { <<-CSS }
+      p {
+        property: fn( fn2(val1, val2) );
+      }
+    CSS
+
+    it { should report_lint line: 2, count: 2 }
+  end
+
+  context 'when inner parens are space padded' do
+    let(:css) { <<-CSS }
+      p {
+        property: fn(fn2( val1, val2 ));
+      }
+    CSS
+
+    it { should report_lint line: 2, count: 2 }
+  end
+
+  context 'when both parens are not space padded' do
+    let(:css) { <<-CSS }
+      p {
+        property: fn(fn2(val1, val2));
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when both parens are space padded' do
+    let(:css) { <<-CSS }
+      p {
+        property: fn( fn2( val1, val2 ) );
+      }
+    CSS
+
+    it { should report_lint line: 2, count: 4 }
+  end
+
+  context 'when multi level parens are multi-line' do
+    let(:css) { <<-CSS }
+      p {
+        property: fn(
+          fn2(
+            val1, val2
+          )
+        );
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when parens exist in a silent comment' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0; // Some comment ( with parens )
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when parens exist in an outputted comment' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0; /* Some comment ( with parens ) */
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when the number of spaces has been explicitly set' do
+    let(:linter_config) { { 'spaces' => 1 } }
+
+    context 'when the opening parens is followed by a space' do
+      let(:css) { <<-CSS }
+        p {
+          property: ( value);
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when the closing parens is preceded by a space' do
+      let(:css) { <<-CSS }
+        p {
+          property: (value );
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when neither parens are space padded' do
+      let(:css) { <<-CSS }
+        p {
+          property: (value);
+        }
+      CSS
+
+      it { should report_lint line: 2, count: 2 }
+    end
+
+    context 'when both parens are space padded' do
+      let(:css) { <<-CSS }
+        p {
+          property: ( value );
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when parens are multi-line' do
+      let(:css) { <<-CSS }
+        p {
+          property: (
+            value
+          );
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when parens are multi-line with tabs' do
+      let(:css) { <<-CSS }
+\t\t\t\tp {
+\t\t\t\t\tproperty: (
+\t\t\t\t\t\tvalue
+\t\t\t\t\t);
+\t\t\t\t}
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when outer parens are space padded' do
+      let(:css) { <<-CSS }
+        p {
+          property: fn( fn2(val1, val2) );
+        }
+      CSS
+
+      it { should report_lint line: 2, count: 2 }
+    end
+
+    context 'when inner parens are space padded' do
+      let(:css) { <<-CSS }
+        p {
+          property: fn(fn2( val1, val2 ));
+        }
+      CSS
+
+      it { should report_lint line: 2, count: 2 }
+    end
+
+    context 'when both parens are not space padded' do
+      let(:css) { <<-CSS }
+        p {
+          property: fn(fn2(val1, val2));
+        }
+      CSS
+
+      it { should report_lint line: 2, count: 4 }
+    end
+
+    context 'when both parens are space padded' do
+      let(:css) { <<-CSS }
+        p {
+          property: fn( fn2( val1, val2 ) );
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when multi level parens are multi-line' do
+      let(:css) { <<-CSS }
+        p {
+          property: fn(
+            fn2(
+              val1, val2
+            )
+          );
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/string_quotes_spec.rb

@@ -0,0 +1,303 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::StringQuotes do
+  context 'when string is written with single quotes' do
+    let(:css) { <<-CSS }
+      p {
+        content: 'hello';
+      }
+    CSS
+
+    it { should_not report_lint }
+
+    context 'and contains escaped single quotes' do
+      let(:css) { <<-CSS }
+        p {
+          content: 'hello \\'world\\'';
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'and contains single quotes escaped as hex' do
+      let(:css) { <<-CSS }
+        p {
+          content: 'hello \\27world\\27';
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and contains double quotes' do
+      let(:css) { <<-CSS }
+        p {
+          content: 'hello "world"';
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and contains interpolation' do
+      let(:css) { <<-CSS }
+        p {
+          content: 'hello \#{$world}';
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when @import uses single quotes' do
+    let(:css) { "@import 'file';" }
+
+    it { should_not report_lint }
+
+    context 'and has no trailing semicolon' do
+      let(:css) { "@import 'file'\n" }
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when @charset uses single quotes' do
+    let(:css) { "@charset 'UTF-8';" }
+
+    it { should_not report_lint }
+  end
+
+  context 'when string is written with double quotes' do
+    let(:css) { <<-CSS }
+      p {
+        content: "hello";
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+
+    context 'and contains escaped double quotes' do
+      let(:css) { <<-CSS }
+        p {
+          content: "hello \\"world\\"";
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'and contains double quotes escaped as hex' do
+      let(:css) { <<-CSS }
+        p {
+          content: "hello \\22world\\22";
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'and contains single quotes' do
+      let(:css) { <<-CSS }
+        p {
+          content: "hello 'world'";
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and contains interpolation' do
+      let(:css) { <<-CSS }
+        p {
+          content: "hello \#{$world}"
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when @import uses double quotes' do
+    let(:css) { '@import "file";' }
+
+    it { should report_lint }
+
+    context 'and has no trailing semicolon' do
+      let(:css) { '@import "file"' }
+
+      it { should report_lint }
+    end
+  end
+
+  context 'when @charset uses double quotes' do
+    let(:css) { '@charset "UTF-8";' }
+
+    it { should report_lint }
+  end
+
+  context 'when property has a literal identifier' do
+    let(:css) { <<-CSS }
+      p {
+        display: none;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property is a URL with single quotes' do
+    let(:css) { <<-CSS }
+      p {
+        background: url('image.png');
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property is a URL with double quotes' do
+    let(:css) { <<-CSS }
+      p {
+        background: url("image.png");
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when the configuration has been set to prefer double quotes' do
+    let(:linter_config) { { 'style' => 'double_quotes' } }
+
+    context 'and string is written with single quotes' do
+      let(:css) { <<-CSS }
+        p {
+          content: 'hello';
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+
+      context 'and contains escaped single quotes' do
+        let(:css) { <<-CSS }
+          p {
+            content: 'hello \\'world\\'';
+          }
+        CSS
+
+        it { should report_lint line: 2 }
+      end
+
+      context 'and contains single quotes escaped as hex' do
+        let(:css) { <<-CSS }
+          p {
+            content: 'hello \\27world\\27';
+          }
+        CSS
+
+        it { should report_lint line: 2 }
+      end
+
+      context 'and contains double quotes' do
+        let(:css) { <<-CSS }
+          p {
+            content: 'hello "world"';
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'and contains interpolation' do
+        let(:css) { <<-CSS }
+          p {
+            content: 'hello \#{$world}';
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+    end
+
+    context 'and string is written with double quotes' do
+      let(:css) { <<-CSS }
+        p {
+          content: "hello";
+        }
+      CSS
+
+      it { should_not report_lint }
+
+      context 'and contains escaped double quotes' do
+        let(:css) { <<-CSS }
+          p {
+            content: "hello \\"world\\"";
+          }
+        CSS
+
+        it { should report_lint line: 2 }
+      end
+
+      context 'and contains double quotes escaped as hex' do
+        let(:css) { <<-CSS }
+          p {
+            content: "hello \\22world\\22";
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'and contains single quotes' do
+        let(:css) { <<-CSS }
+          p {
+            content: "hello 'world'";
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'and contains interpolation' do
+        let(:css) { <<-CSS }
+          p {
+            content: "hello \#{$world}";
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+    end
+
+    context 'when property has a literal identifier' do
+      let(:css) { <<-CSS }
+        p {
+          display: none;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when property is a URL with single quotes' do
+      let(:css) { <<-CSS }
+        p {
+          background: url('image.png');
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when property is a URL with double quotes' do
+      let(:css) { <<-CSS }
+        p {
+          background: url("image.png");
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+end